[Mahara-contributors] [Bug 1749339] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9098 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749339 Title: Add pre_loginpage_hooks Status in Mahara: In Progress Bug description: Give a chance for auth plugins to authenticate the user or perform other tasks before showing the login page. This is similar to https://tracker.moodle.org/browse/MDL-48887 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749339/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1788062] Re: The group files page has a broken sidebar
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1788062 Title: The group files page has a broken sidebar Status in Mahara: Fix Committed Bug description: We get the error "[Dwoo\\Exception]: Plugin "PluginLoadgroupquota" can not be found, maybe you forgot to bind it if it's a custom plugin ?" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1788062/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1788062] A change has been merged
Reviewed: https://reviews.mahara.org/9081 Committed: https://git.mahara.org/mahara/mahara/commit/69eb93b0a17dabef8026f8485a37b2cf086ff110 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 69eb93b0a17dabef8026f8485a37b2cf086ff110 Author: Robert Lyon Date: Tue Aug 21 10:52:16 2018 +1200 Bug 1788062: group quota sidebar not showing Due to the name of the file being misspelled behatnotneeded Change-Id: I60eb05c098b52b21742734eade5be511093dff1b Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1788062 Title: The group files page has a broken sidebar Status in Mahara: Fix Committed Bug description: We get the error "[Dwoo\\Exception]: Plugin "PluginLoadgroupquota" can not be found, maybe you forgot to bind it if it's a custom plugin ?" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1788062/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1539322] Re: Do we still need device detection?
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1539322 Title: Do we still need device detection? Status in Mahara: Triaged Bug description: Mahara 15.10 introduced Bootstrap. All themes are now responsive. When I tested the "Deactivate device detection" functionality, I couldn't see much of a difference when using the site. I did notice the content chooser was displayed the start of the words instead of only showing the icon on the "Edit page" screen. I wonder if we can remove the custom device detection. You can enable the user turning off device detection in Admin -> Config site -> User settings -> Users can disable device detection. That then happens on the account settings page. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1770261] Re: duplicated id="login_login_submitted" in login form
** Tags added: code-cleanup -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1770261 Title: duplicated id="login_login_submitted" in login form Status in Mahara: Confirmed Bug description: as a logged out user in home screen the login form is fine, but if we add /?login to the url we can see that the id="login_login_submitted" is duplicated in the DOM It's easy to see in chrome since it shows and error in the browser console [DOM] Found 2 elements with non-unique id #login_login_submitted: To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1770261/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1037365] Re: some third party libraries do not respect the directorypermissions config setting
** Changed in: mahara Milestone: 18.10.0 => None ** Tags added: code-cleanup -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1037365 Title: some third party libraries do not respect the directorypermissions config setting Status in Mahara: Confirmed Bug description: one example is htmlpurifier, from a git grep mkdir, i see that pear, dwoo, adobdb, and flowplayer may also be culprits Also, the internal examples - extract function in artefact/file.lib.php - copyr function in lib/file.php - there is one instance in lib/db/upgrade.php To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1037365/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1519989] Re: Refactor duplicate collections access code in index.php & index.json.php
When tackling that, it should be looked at whether we can set coding standards / guidelines when we have a json.php and a .php file so we don't end up in a situation like this again. ** Tags added: code-cleanup ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1519989 Title: Refactor duplicate collections access code in index.php & index.json.php Status in Mahara: Confirmed Bug description: After patch https://reviews.mahara.org/#/c/5695/6 for Bug1514374, we've now got duplicate code it htdocs/collection/index.php and htdocs/collection/index.json.php, for checking whether the user has access to the particular collections they're trying to look at. This kind of duplication stands a high likelihood of falling out of sync if changes are made to the access code in the future, so we should abstract it out into a common access method that gets called by both scripts. The code is not *exactly* the same in both places. index.php intersperses it with code to set the menu headers, and index.json.php sends an error via json_reply on failure, while index.php throws an AccessDeniedException(). So it will require a little bit of thinking to do it. But it's not impossible. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1519989/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1434316] Re: Why two pieform directories?
** Tags added: code-cleanup ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1434316 Title: Why two pieform directories? Status in Mahara: Confirmed Bug description: Currently the basic pieform elements information lives in: htdocs/lib/pieforms/pieform/ but there are also pieform elements that live in htdocs/lib/forms/ Why do we need to have them in two places? I can imagine that there might have been a reason to keep the pieform plugin separate from custom pieform elements but seeing as mahara pieform is really a fork of the original this seperation is not needed within mahara. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1434316/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1787860] Re: Text block title is dropped when creating a page content via tags functionality
https://reviews.mahara.org/9082 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1787860 Title: Text block title is dropped when creating a page content via tags functionality Status in Mahara: Confirmed Bug description: Preconditions: - 1. Portfolio Page exists with the following Blocks --- a. Text Block (title = Text block 101) and has the tag = orange --- b. Note Block (title = Note block 123) and has the tag = orange Test Script - create page and add content via Tags functionality - 1. User create a Portfolio page (title = Page created via tags) 2. Fill in select2 input "Create via tags" with "orange" and select "orange" 3. click the save button 4. Confirm, that user sees the following blocks: --- a. Text Block (title = Text block 101) --- b. Note Block (title = Note block 123) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1787860/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776320] Re: Help files for view layout not being used anymore
We are looking into moving away from the current layouts to something more flexible and thus wouldn't need the help files anymore. ** No longer affects: mahara/17.10 ** No longer affects: mahara/18.04 ** Changed in: mahara/18.10 Assignee: Cecilia Vela Gurovic (ceciliavg) => (unassigned) ** Tags added: bite-sized ** No longer affects: mahara/18.10 ** Changed in: mahara Status: Confirmed => Won't Fix ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776320 Title: Help files for view layout not being used anymore Status in Mahara: Won't Fix Bug description: When we merged the settings and layout pages into one we lost the connection to a bunch of help files. Do we still need the help files? We either need to add back the help icon connections or delete the help files See screen-shot for an example (there maybe more) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776320/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1778792] Re: PDF.js does not have the presentation mode option in Firefox and IE
** Changed in: mahara Assignee: Rebecca Blundell (rjb-dev) => (unassigned) ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1778792 Title: PDF.js does not have the presentation mode option in Firefox and IE Status in Mahara: Confirmed Bug description: https://mahara.org/interaction/forum/topic.php?id=8303 When you embed a PDF into a page, the presentation mode option is only available in Chrome and Opera but not in Firefox and IE though according to the PDF.js website demo https://mozilla.github.io/pdf.js/ Firefox should be able to use the presentation mode. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1778792/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1777971] Re: jquery-ui timepicker- old code needs to be removed
** Tags added: code-cleanup ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1777971 Title: jquery-ui timepicker- old code needs to be removed Status in Mahara: Confirmed Bug description: when upgrading jquery-ui to 1.12.1 I found a customization in the file jquery-ui/js/jquery-ui.min.js that was made when this message was added to js/jquery/jquery-ui/README.Mahara * Added call to function after datepicker arrow key is pressed - to allow the year arrows to be re-added on day change that was added in commit here, a function add_prev_next_year() was defined and added to jquery-ui/js/jquery-ui.min.js that function was removed in commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0 for Bug #1744191: Updated the datepicker to use the bootstrap one there is no need to add extra code to jquery-ui.min.js and it would be good to check what else is in the code but not needed anymore To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1777971/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1775479] Re: obsolete code for displaying comments
** Tags added: code-cleanup ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1775479 Title: obsolete code for displaying comments Status in Mahara: Confirmed Bug description: We have old code not used anymore for displaying comment list from a text note in view/view.php ln 308 It was added in commit e03327b0f68d6c7bc40cd04cfed441f42b802ba3 in 15.04 for "Adjusting the textbox so it can show/hide comments (Bug #1037531) The comments will be displayed (or hidden) below the block by clicking on the 'Comments (x)' link. There is also a 'close' link at the bottom of the comment list as well to close them." We don't use this anymore since now, when clicking on coment(x) link, they are displayed in a right side modal panel. We have to check what other obsolete related code we need to clean. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1775479/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1772298] Re: login help icon hidden on Modern theme
** Changed in: mahara Assignee: (unassigned) => Liam (liam-sharpe) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1772298 Title: login help icon hidden on Modern theme Status in Mahara: Confirmed Bug description: Environment tested: Master Browser tested: Chrome Summary: Help icon is missing when the site theme is set to Modern theme and the user is on the log in page. 1. site has Modern Theme set 2. User is on the login screen Actual result: the help icon is hidden - if user clicks in the general area the help text is displayed Expected result: help icon is displayed and is clickable to reveal help text. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1772298/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1757923] Re: Look into newer version of datepicker for 18.10
While updating, also check if bug #1759054 still applies. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1757923 Title: Look into newer version of datepicker for 18.10 Status in Mahara: Confirmed Bug description: The datepicker that was implemented for 18.04 is in code freeze and is no longer being maintained. However, there is a version 5 which is hosted on a different repository which can be found at: https://github.com/tempusdominus/core . There are also bootstrap-3 and bootstrap-4 repos on the same github account. Investigation should be done to see what changes there are to this new version and accessibility should be considered. The previous version has had numerous accessibility changes (now merged in 18.04) and either these changes should be modified and implemented in this new version if it does not already have accessibility features. Thanks, Liam Sharpe To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1757923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1768160] Re: resume tinyMCE keeps old text
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1768160 Title: resume tinyMCE keeps old text Status in Mahara: Confirmed Bug description: In User Menu-> Content -> Resume when adding "Education and employment" or "Achievements items", e.g. "Education history" we can add and item with description "Some text" in the TinyMCE text area, when we save and want to add a new one, we can see that the text "Some text" still show in the description field, but it should be empty. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1768160/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1757923] Re: Look into newer version of datepicker for 18.10
We are moving that to 19.04 to also look at it with Bootstrap 4 ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1757923 Title: Look into newer version of datepicker for 18.10 Status in Mahara: Confirmed Bug description: The datepicker that was implemented for 18.04 is in code freeze and is no longer being maintained. However, there is a version 5 which is hosted on a different repository which can be found at: https://github.com/tempusdominus/core . There are also bootstrap-3 and bootstrap-4 repos on the same github account. Investigation should be done to see what changes there are to this new version and accessibility should be considered. The previous version has had numerous accessibility changes (now merged in 18.04) and either these changes should be modified and implemented in this new version if it does not already have accessibility features. Thanks, Liam Sharpe To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1757923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1759054] Re: datepicker not accessible by screen reader
This will need to be looked at together with bug #1757923 ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1759054 Title: datepicker not accessible by screen reader Status in Mahara: Confirmed Bug description: There are still a few issues that make datepicker not accessible: - when the datepicker field receives focus, the screen reader doesn't see the datepicker form has been displayed - when on the datepicker we press 'H' it changes to the timepicker form, but the screen reader doesn't see there has been a change - the text with instructions on how to change the time (hours or minutes) is not read by the sr - it doesn't say how to come back from the timepicker mode reported by Julius To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1759054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1680633] Re: Cron job metadata
** Changed in: mahara
Importance: Medium => Wishlist
** Changed in: mahara
Milestone: 18.10.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1680633
Title:
Cron job metadata
Status in Mahara:
Confirmed
Bug description:
Hello,
Currently the meta data stored for cron jobs is fairly limited having only
the following fields:
We are implementing a plugin for Mahara that will mirror the cron
check functionality present in this Moodle plugin:
https://github.com/brendanheywood/moodle-tool_heartbeat.
It would be beneficial if Mahara included two new fields in the cron
and the plugintype_cron tables:
1. lastruntime - the last runtime of the cron job.
Currently on /admin/statistics.php the following sql is used to determine if
cron has run.
record_exists_select('cron', 'nextrun IS NULL OR nextrun < CURRENT_DATE') -
from a monitoring standpoint this is not acceptable as it will give false
positives/negatives depending on the situation. With this change, the max
lastruntime could be used to determine if cron had run recently.
2. faildelay - An Exponentially increasing fail delay that is updated
when the cron job fails (if it throws an exception). This way if there
is a consistently failing cron job its execution is throttled and its
failure is being tracked in some way aside from just logging an error.
The heartbeat plugin above uses this to help us to identify and fix
issues that would otherwise go undetected.
Aside from the benefits from a monitoring perspective, these fields
provide useful information when it comes to debugging anything cron
related.
I'm happy to discuss at any time and more than happy to do the dev on
this. Ill be floating around the Mahara IRC under the kenH handle if
you would like to talk at any time.
Thanks,
Kenneth
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1680633/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1606738] Re: Accessibility - Information icon and navigation to content in information overlay
** Changed in: mahara Status: Confirmed => Incomplete ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1606738 Title: Accessibility - Information icon and navigation to content in information overlay Status in Mahara: Incomplete Bug description: Mahara: master Information icons are appearing as h1 headers. Also, screen readers can't get to the content in the pop up dialog. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1606738/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1749308] Re: Collection navigation triggering swiperight event on mouse click
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749308 Title: Collection navigation triggering swiperight event on mouse click Status in Mahara: Confirmed Bug description: Mahara: 17.10.3 OS: Linux 16.04 DB: Postgres (not relevant) Browser: Firefox and Chrome In a collection on a view with the 'Previous page' displayed, the swiperight event is getting triggered on a mouse click. When a user tries to select some text (i.e. click mouse, hold it down, and select text), this action is interpreted as a swipe action. And, the swiperight event is triggered. I've come across this stackoverflow discussion: https://stackoverflow.com/questions/36317660/jquery-mobile-swipe- gesture-for-touch-screen-only-and-not-for-mouse Bascially, the swiperight and swipeleft events should be disabled on the mousedown event and enabled on the touchstart event. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1755945] Re: Behat: trigger cron step is broken on master
** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1755945 Title: Behat: trigger cron step is broken on master Status in Mahara: Confirmed Bug description: Following a failed test run I found the test (loginattempts.feature) failing locally as well. In this case the cron fails to reset the number of failed logins, so the log in fails. Two other tests use the step, but only one of them fails, as the other one doesn't require a cron run. contact_us.feature (fails) unsubscribe_watchlist.feature (passes, because cron run isn't needed by test.) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1755945/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756182] Re: delete icon not needed for primary email address
** Changed in: mahara Milestone: 18.10.0 => None ** Tags added: snack-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756182 Title: delete icon not needed for primary email address Status in Mahara: Confirmed Bug description: Environment tested: Master Browser tested: Chrome === Manual Test Script === 1) user browse to Main menu > Profile > Contact information 2) User adds multiple email addresses 3) User tries to delete primary email address Actual Result: error message is displayed "You cannot remove your primary email address." Expected Result: If user cannot delete a primary email address, then the delete icon next to the primary email should not be displayed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756182/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1749022] Re: Duplicated code for checking plugins
** Tags added: code-cleanup ** Changed in: mahara Milestone: 18.10.0 => None ** Tags added: snack-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749022 Title: Duplicated code for checking plugins Status in Mahara: Confirmed Bug description: code for checking whether a plugin is installed is almost completely duplicated in lib/upgrade.php from line 153 and mahara.php from line 4844. It might make sense to have this only once. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749022/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1742590] Re: Text/Note/Annotation Maxlength rule is unnecessary
To Do: 1. Check what the upper limits are with the newer versions of Postgres and MySQL. 2. Upt the limit on the text boxes that were mentioned minus a few characters to deal with saving the block data in serialized format. 3. Change the message when the limit has been reached to something along the lines of comment #3. ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 ** Tags added: snack-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1742590 Title: Text/Note/Annotation Maxlength rule is unnecessary Status in Mahara: Confirmed Bug description: Mahara: 17.10.1 OS: Ubuntu 16.04 DB: Postgres Browser: FF When inserting a base-64 encoded image into a comment on a form, the user is presented with the following error: 'This field must be 8192 characters long.' This rule validation is not really required because the DB field that it inserting into is a 'Text' type. Which basically means it's almost unlimited. Postgres 7.1+ does have an upper limit at 1 Gb for a Text field. Mahara supports Postgres 9+. I do think it's safe to remove the maxlength rule for the Text, Note and Annoation fields. Please let me know your thoughts. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1742590/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1603294] Re: Licenses: Once you've selected a license, you can't go back to "None"
"None selected" was changed to "All rights reserved", which fixed the problem. ** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1603294 Title: Licenses: Once you've selected a license, you can't go back to "None" Status in Mahara: Fix Committed Bug description: While testing out Bug 1279526, I noticed that you can't change an uploaded file from a particular license to "No License". This may have been by design, with the idea that "No License" was a temporary thing until you pick a license. But with Bug 1279526 we're changing the wording of "No License" to make it clear that if you're not choosing a particular license, then the default copyright rules apply, so it becomes more necessary to be able to switch to that. To replicate: 1. Go to "Administration -> Configure Site -> General Settings", and enable "License metadata" 2. Go to "Content -> Files" and upload a file. 3. Once the file is uploaded, click the pencil "edit" button to open its editing form. It should be at "No license" or the equivalent. Change it to "Creative Commons Attribution 4.0" 4. Click "Save changes" 5. Now click the pencil "edit" button again. Change the License back to "No license" or the equivalent. 6. Again click "Save changes" 7. Again click the pencil "edit" button. Expected result: You see "No license" or the equivalent as the license selection. Actual result: You see "Creative Commons Attribution 4.0" as the license selection. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1603294/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1599414] Re: New composer-managed SimpleSAML breaks PHPUnit tests.
We do more Behat tests than PHPUnit tests these days and Robert provided
a way of dealing with the problem.
** Changed in: mahara
Milestone: 18.10.0 => None
** Changed in: mahara
Status: Confirmed => Won't Fix
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1599414
Title:
New composer-managed SimpleSAML breaks PHPUnit tests.
Status in Mahara:
Won't Fix
Bug description:
While writing a PHPUnit test for one of my patches, I noticed that the
new composer-managed SimpleSAML, if present, breaks "make phpunit",
because it contains some phpunit tests that get detected but are
lacking the proper stuff to make them run correctly.
To replicate:
1. Install the SimpleSAMLPHP library by doing "make ssphp"
2. Run phpunit tests by doing "make phpunit"
Expected result: tests run with no failures
Actual result: Tests fail out with this error message
PHP Fatal error: Class 'SimpleSAML_Auth_ProcessingFilter' not found in
/home/aaronw/www/mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/exampleauth/lib/Auth/Process/RedirectTest.php
on line 7
PHP Stack trace:
PHP 1. {main}()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:0
PHP 2. PHPUnit_TextUI_Command::main()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/composer/bin/phpunit:63
PHP 3. PHPUnit_TextUI_Command->run()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:129
PHP 4. PHPUnit_Runner_BaseTestRunner->getTest()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/TextUI/Command.php:150
PHP 5. PHPUnit_Framework_TestSuite->addTestFiles()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Runner/BaseTestRunner.php:96
PHP 6. PHPUnit_Framework_TestSuite->addTestFile()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:416
PHP 7. PHPUnit_Util_Fileloader::checkAndLoad()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Framework/TestSuite.php:355
PHP 8. PHPUnit_Util_Fileloader::load()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:76
PHP 9. include_once()
/home/aaronw/www/mahara/external/vendor/phpunit/phpunit/PHPUnit/Util/Fileloader.php:92
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1599414/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1690291] Re: Behat: Combine multiple tests for webservices into one
** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1690291 Title: Behat: Combine multiple tests for webservices into one Status in Mahara: Confirmed Bug description: webservices_master_switch.feature and webservices_switch_dependencies.feature can be combined into one test. It would be good to explore testing the functionality as well as whether the switches work too. To do: Enable/disable toggles at the beginning are a bit pointless. Just enable both switches. Figure out best way to test functionality. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1690291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692756] Re: Note that menu has been expanded
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692756 Title: Note that menu has been expanded Status in Mahara: Confirmed Bug description: Mahara 17.04+ The "collapsed" state of the Show Main Menu / User Menu / Admin Menu button should become "Expanded" as the main menu has been expanded. When a screen reader focuses on the "Show main menu" button for the first time, the screen reader speaks "Show main menu, collapsed" as it is collapsed. But when the user presses Enter and the menu expands, the screen reader still says "Show main menu, collapsed", instead of saying "Show main menu, expanded". It is important to note that on the menu items e.g. Show menu for content, show menu for portfolio, show menu for groups, the screen reader is correctly able to speak the collapsed or expanded state of the menu items. The issue is present only in the main menu, administration menu, and user menu buttons. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692756/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1732302] Re: Behat: fix secret_URL test
** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1732302 Title: Behat: fix secret_URL test Status in Mahara: Confirmed Bug description: This test doesn't do what it says it does - i.e. it says it checks the secret url can be reliably copied. All it currently does is check that a 1 appears after the url is created. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1732302/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1689312] Re: New username isn't checked for spaces when added to LDAP
** Changed in: mahara Milestone: 18.10.0 => None ** Tags added: bite-sized -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1689312 Title: New username isn't checked for spaces when added to LDAP Status in Mahara: Confirmed Bug description: Mahara version: 16.10.3 When adding a new user, if you select an institution/authentication method with LDAP, the usersame is not being checked for leading/trailing spaces, and it isn't trimmed before being added to the database. Users can be created with usernames like " newuser ". If you try to do this with a non LDAP authentication method, it thows an error and will not continue (although the error message does not highlight the username field as the source of the error in this case). I've fixed it locally with trim() around the username value before it's put into the databse. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1714082] Re: The user's primary email address is not checked in a case insensitive way
** Tags added: snack-sized ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1714082 Title: The user's primary email address is not checked in a case insensitive way Status in Mahara: Confirmed Bug description: Currently you can create 2 users, via the Admin -> Users -> Add user screen, with this: username: Test one email: us...@example.com username: Test two email: us...@example.com but not another user with username: Test three email: us...@example.com As it complains the email address 'us...@example.com' is used However, with email addresses the domain part is case insensitive and only the username part is case sensitive - yet saying that most email servers treat the username part also as case insensitive to avoid email delivery confusion - see https://www.lifewire.com/are-email- addresses-case-sensitive-117 To also avoid confusion within Mahara we should limit the primary email address to be case insensitive unique. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1714082/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1575923] Re: Mathslate/MathJax fails to load on https
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1575923 Title: Mathslate/MathJax fails to load on https Status in Mahara: Confirmed Bug description: On HTTPS-enabled sites, the Mathslate tinymce plugin fails, due to loading http:// resources from yui.yahooapis.com and cdn.mathjax.org. The file htdocs/js/tinymce/plugins/mathslate/mathslate.html is hardcoded to pull http:// versions of these scripts (lines 11-12). Ultimately this is an upstream bug, but it's one that affects https- enabled Mahara sites. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1575923/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1576075] Re: Namespaces and Autoloader
SimpleSAML and Dwoo are now namespaced ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1576075 Title: Namespaces and Autoloader Status in Mahara: Confirmed Bug description: Discussed at the 52nd developer meeting: https://wiki.mahara.org/wiki/Developer_Area/Developer_Meetings/52 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1576075/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1564715] Re: Change Mahara's content-sniffing to match the WHATWG standard
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1564715 Title: Change Mahara's content-sniffing to match the WHATWG standard Status in Mahara: Confirmed Bug description: WHATWG (Web Hypertext Application Technology Working Group) is basically the official specification organization for HTML5. They've written up some specifications about the correct & secure way that HTTP clients & servers ought to deal with file content types aka MIME types: https://mimesniff.spec.whatwg.org To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1564715/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1528122] Re: Be able to decide whether to include or not feedback in Leap2A
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 ** Changed in: mahara Milestone: 19.04.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1528122 Title: Be able to decide whether to include or not feedback in Leap2A Status in Mahara: Confirmed Bug description: When you create an HTML export, you can decide whether to include feedback or not. However, when you create a Leap2A export, you do not have that option and feedback is now always included. Users should be able to have the choice like for HTML. At some point, feedback was added to the Leap2A export but without providing the option. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1528122/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1558830] Re: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier
** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1558830 Title: Set "URI.DefinitionID" and "URI.DefinitionRev" in HTMLPurifier Status in Mahara: Confirmed Bug description: While working on https://bugs.launchpad.net/mahara/+bug/1558387, Robert pointed out to me that we don't set URI.DefinitionRev. We also don't set URI.DefinitionID. Although the HTMLPurifier docs say that URI.DefinitionID is required if you have custom URIFilters (and our allowed iframe list is a custom URIFilter), it looks like the fallback behavior is that it generates a URI.DefinitionID based on a hash of the config. This has the effect that a new "Revision 1" URI config file is generated each time the allowed iframes list changes. It also results in an accumulation of old URI cache files in the dataroot/htmlpurifier directory, since they're all Revision 1, and all have different IDs. I think the best approach here is to give the URI.DefinitionRev its own revision number, stored in the database, and increment it every time we change the allowed iframe list. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1558830/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1564117] Re: Refactor blocktype JS methods
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1564117 Title: Refactor blocktype JS methods Status in Mahara: Confirmed Bug description: Currently the PluginBlocktype abstract class has three methods for loading Javascript libraries, and invoking Javascript code to run when a block is loaded: 1. PluginBlocktype::get_instance_javascript(BlockInstance $instance): Called when a block instance is displayed (either on the page in view mode, or the page in edit mode). Expects to return an array of sub- arrays where each sub-array has a "file" item, which is the relative path to a JS file (relative to the blocktype's root), and an optional "init" item, which is a snippet of code that gets executed once the "file" library has loaded. (It currently uses jQuery.getScript() to do this). 2. PluginBlocktype::get_instance_inline_javascript(BlockInstance $instance): Called when a block instance is displayed (either on the page in view mode, or the page in edit mode). The code here is inserted into a
[Mahara-contributors] [Bug 1563641] Re: Rewrite "mixed content" URLs via an HTMLPurifier custom filter
To be revisited when we upgrade HTMLpurifier for 19.04 ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 ** Changed in: mahara Assignee: (unassigned) => Cecilia Vela Gurovic (ceciliavg) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1563641 Title: Rewrite "mixed content" URLs via an HTMLPurifier custom filter Status in Mahara: Confirmed Bug description: "Mixed content" refers to the scenario where a web page is served via HTTPS, but it includes assets that are served via an HTTP URL. See https://developer.mozilla.org/en-US/docs/Security/Mixed_content for some discussion of this. In Bug 1463629 we fixed this issue for embedded iframes, by patching the HTMLPurifier core class HTMLPurifier_URIFilter_SafeIframe so that, in addition to filtering iframes for an allowed set of URLs, it also transformed them from HTTPS to HTTP if needed. After having recently done some work on HTMLPurifier for other bugs, and becoming more familiar with their API, it now becomes apparent to me that this was a bit of a hack (patching core code should have told me this anyway). What we should have done is, instead, write up a new custom URIFilter specifically for rewriting URI's from HTTP to HTTPS in this way, and used that instead. Doing it that way will make future HTMLPurifier upgrades easier, by eliminating the need to patch that file. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1563641/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422264] Re: IPv6 Compliance
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1422264 Title: IPv6 Compliance Status in Mahara: Confirmed Bug description: Mahara: 15.04 DB: any Browser: any OS: any Currently, Mahara is not compliant with the IPv6 protocol. Some places that need to change (where IP addresses are validated/checked): - SAML auth - validate URL Syntax (preg_match for IPv6 also). - DB: table - host.ipaddress needs to cater for 128 bit address. - Peer bootstrap: 1) preg-match should also include IPv6 format; 2) use of PHP function gethostbyname(). - Zend third part library - current version only supports IPv4. We currently use version 1.10.6. MNET heavily relise on Zend. The latest Zend is on version 3. But there is a release for 1.12.11 - which still doesn't support IPv6 (as far as I can tell). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1422264/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1413431] Re: Queue messages and send them out in small batches
Aaron's solution is sufficient right now until we need to make more changes. ** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1413431 Title: Queue messages and send them out in small batches Status in Mahara: Fix Committed Bug description: When a Mahara training is taking place on a site and pages / collections are created in / shared with a group and "Shared page notifications" are turned on, a lot of emails can be generated. When they are sent out they can result in a mail server to reject them esp. if all users have the same email domain. It would be better if a queue was established and sent out in smaller batches so that mail servers don't blackmail the sender. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1413431/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422837] Re: XML RPC simpleXML limits payload size
We are moving away from MNet to LTI.
** Changed in: mahara
Status: Confirmed => Won't Fix
** Changed in: mahara
Milestone: 18.10.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1422837
Title:
XML RPC simpleXML limits payload size
Status in Mahara:
Won't Fix
Bug description:
Operating System: Ubuntu 14.04.1 LTS
Mahara version: 1.9.3
Database: mysql
Browser: chrome 40.0.2214.111
--
Steps to reproduce - you need a system capable of XMLRPC communication
with Mahara (e.g. Moodle)
1) With Moodle - set up mahara networking / portfolios.
2) Open a course with a forum
3) Add 2 entries. One with an attachment under 5 MB. One with an attachment
over 5 MB. On Each click "Export to portfolio" in the bottom. 4) Go through the
screens to start export - ask it to do it now (i.e. not wait for cron).
5) Check the Mahara site to see what made it through successfully.
--
simpleXML may not be the best parser for XMLRPC payloads
in api/xmlrpc/lib.php
function parse_payload($payload) {
try {
$xml = new SimpleXMLElement($payload);
return $xml;
} catch (Exception $e) {
throw new MaharaException('Encrypted payload is not a valid XML
document', 6002);
}
}
This means if you send a large file (in our tests greater than approx 7mb)
base 64 encoded over XMLRPC it will fail to parse.
It didn't seem to make any difference if we increased the memory limit to
800M in php.ini or even by setting the php memory limit to 800M via PHP ini_set
in function parse_payload - this suggests that there is a limit to what
SimpleXML can handle regardless of the PHP memory limit.
Note - 932 in my source code is the 'throw new exception' following
$xml = new SimpleXMLElement($payload);
called at [/vagrant/www/maharadev/mahara/lib/errors.php:465] #1
exception(MaharaException Object ([] => 1,[] => Encrypted payload is not a
valid XML document,[] => ,[] => 6002,[] =>
/vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] => Array ([0] =>
Array ([file] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] =>
921,[function] => parse_payload,[args] => Array ([0] =>ERROR 4:
4: remote server error: code: , message: A nonrecoverable error occurred.
This probably means you have encountered a bug in the system #0
MaharaException->handle_exception() called at
[/vagrant/www/maharadev/mahara/lib/errors.php:465] #1 exception(MaharaException
Object ([] => 1,[] => Encrypted payload is not a valid XML document,[] => ,[]
=> 6002,[] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] =>
Array ([0] => Array ([file] =>
/vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] => 921,[function] =>
parse_payload,[args] => Array ([0] =>
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1422837/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1434312] Re: Pieform elements/renderers documentation
** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1434312 Title: Pieform elements/renderers documentation Status in Mahara: Confirmed Bug description: Need to develop some useful documentation for the pieform elements/renderers Each element need to include at the top of the file a comment about what settings it uses and whether they are optional or not. Once we get each element/renderer file updated then we can collate the information on the wiki page: https://wiki.mahara.org/index.php/Developer_Area/Core_Subsystems/Form_API To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1434312/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1513710] Re: Destructor methods that access global variables can cause crashes
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1513710 Title: Destructor methods that access global variables can cause crashes Status in Mahara: Confirmed Bug description: See : https://mahara.org/interaction/forum/topic.php?id=7397 Here's the problem (which appears to be intermittent): 1. ArtefactType has a destructor method, which gets called when an artefact object is garbage-collected by PHP. 2. PHP runs destructor methods and garbage collects variables in no guaranteed order when exit() is called. 3. Sometimes the ArtefactType destructor method tries to call DML methods, which use the global variable $db 4. Apparently sometimes the $db global variable has already been garbage collected by the time the destructor runs 5. This causes a fatal "method on a non-object" crash. It's unclear why this error has only started happening recently. It might be due to a change in the behavior of PHP's garbage collector, or it might be from new Mahara code leaving some artefacts with their $dirty flag set (which triggers that artefact commit). In either case, both global variables and implicit destructor methods are considered harmful design practices, in part because of this particular thing. So it's high time we got rid of these __destruct() methods. Alternatively, as a workaround for older Mahara versions, we could add some code to the top of each __destruct() method that re-creates the global $db if it's not set. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1513710/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1777785] Re: Users from a suspended institution can still log in
** No longer affects: mahara/17.04 ** No longer affects: mahara/17.10 ** No longer affects: mahara/18.04 ** Changed in: mahara/18.10 Milestone: 18.10.0 => 19.04.0 ** Also affects: mahara/19.04 Importance: Undecided Status: New ** Changed in: mahara/19.04 Status: New => Confirmed ** Changed in: mahara/19.04 Importance: Undecided => High ** Changed in: mahara/19.04 Milestone: None => 19.04.0 ** No longer affects: mahara/18.10 ** No longer affects: mahara/19.04 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/185 Title: Users from a suspended institution can still log in Status in Mahara: Confirmed Bug description: It should not be possible for people to log into their account if their institution has been suspended. the latest fix for that also for external auth methods is https://reviews.mahara.org/#/c/6671/ This did not work on a Mahara 17.04 for SAML auth and on a Mahara 18.10dev for internal auth. To replicate: 1. Have an institution with one member and a site admin. 2. Site admin suspends the institution. 3. Expected result: Institution member cannot log in anymore. Actual result: Institution member can still log in. This would need to be tested with all auth methods: internal, LDAP, SAML, MNet, LTI To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/185/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1723047] Re: New Subtheme // SASS // File to import not found or unreadable
The paths can be updated manually. It might also be a Windows only problem. ** Changed in: mahara Assignee: Pat (pat-kira) => (unassigned) ** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1723047 Title: New Subtheme // SASS // File to import not found or unreadable Status in Mahara: Won't Fix Bug description: When compiling sass for a new subtheme you will get this error: File to import not found or unreadable: ../../../lib/bootstrap/assets/stylesheets/bootstrap/mixins Parent style sheet: _bootstrap-index.scss 1: 2: @import "../../../lib/bootstrap/assets/stylesheets/bootstrap/mixins";3: C:/../../mahara/htdocs/theme/raw/sass/utilities/_bootstrap-index.scss Solution: All pathes has to be one directory further up. e.g. @import "../../../lib/bootstrap/assets/stylesheets/bootstrap/mixins"; has to be be @import "../../../../lib/bootstrap/assets/stylesheets/bootstrap/mixins"; To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1723047/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1775103] Re: broken js in "general settings" from site options
This sounds like a conflict with JS and Ajax. Robert's idea is to make this entire page work with JS only and not have Ajax calls and force a reload of the page when the "Save" button is clicked. The switches that depend on each other would need to be tested in particular, e.g. the one mentioned in this report as well as the "Strict privacy" one. ** No longer affects: mahara/17.04 ** No longer affects: mahara/17.10 ** No longer affects: mahara/18.04 ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1775103 Title: broken js in "general settings" from site options Status in Mahara: Confirmed Bug description: In Admin menu -> Configure site -> Site options-> General settings, the first time we load the page clicking on the "Allow public pages" switch doesn't update "Allow public profiles" switch. To test Go to site options Reload the page go to general settings and click on "Allow public pages" switch it should update "Allow public profiles" switch but it doesn't. Save the form and try again without reloading the page. Now it works properly, clicking on "Allow public pages" updates "Allow public profiles" switch. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1775103/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1777014] Re: Inst admin cannot see profile completion
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1777014 Title: Inst admin cannot see profile completion Status in Mahara: Confirmed Bug description: Summary: -- Site admin enables profile completion and sets a few fields required for completion for an institution. Institution admin wants to add a few more profile completion fields but cannot see profile completion in the admin menu > Institution --- Environment tested: all supported Browser tested: Chrome Preconditions: 1) Institution exists 2) Institution admin exists 3) site admin enables profile completion in the user settings 4) site admin sets a few required fields for completion in Institutions - Profile completion page 5) Site admin log out 6) Institution admin log in 7) browse to admin menu > Institutions Actual result: no link to profile completion page displayed Expected result: Inst admin should see profile completion link to add more required fields Dev to check if both Site admin and Inst admin had the ability to set the required fields when this functionality as developed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1777014/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1427885] Re: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data
Note: We'll need to check if MySQL moves nested sets better. Postgres does, but MySQL couldn't so far. ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1427885 Title: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data Status in Mahara: Triaged Bug description: Originally, we just had each artefact store its parent ID. This is slow because it requires running multiple queries to find all the descendants of a node. Then, we added a "path" element to each artefact. This is better, but you can't get a performance improvement by indexing the column, because most of the queries rely on the "LIKE" operator. (See https://bugs.launchpad.net/mahara/+bug/1423700 ) So if we want to squeeze more performance out of this, I think the one remaining thing to look into is the "nested set" technique. This technique results in very fast searches for descendants, with the cost of somewhat slower writes. http://mikehillyer.com/articles/managing- hierarchical-data-in-mysql/ There are even existing PHP libraries for using the technique, such as this one: http://www.sideralis.org/baobab/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1427885/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1779020] Re: need to upgrade charts.js library to v2.7.2
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Status: Opinion => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1779020 Title: need to upgrade charts.js library to v2.7.2 Status in Mahara: Confirmed Bug description: Need to upgrade library in /js/chartsjs from v1.1.0 to v2.7.2 https://github.com/chartjs/Chart.js/releases/tag/v2.7.2 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1779020/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756904] Re: UTF8 character encoding problem in HTML export
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756904 Title: UTF8 character encoding problem in HTML export Status in Mahara: In Progress Bug description: - Tested in demo.mahara.org - Client Os : Windows - Chrome 64.0.3282.186, Firefox 58.0.2, Microsoft Edge 41.16299.248.0 Steps to reproduce - Create a Portfolio page with UTF8 accents in Title. - Export to HTML with "All my data" - Url to the page in index.html contains accents - Look in the archive /views/ and the folder's page name contains undefined characters (Windows) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756904/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785576] Re: Erros on building CSS for Mahara 18.10dev
** Changed in: mahara
Milestone: 18.10.0 => None
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1785576
Title:
Erros on building CSS for Mahara 18.10dev
Status in Mahara:
Invalid
Bug description:
I have the following errors on building CSS for Mahara 18.10dev
(2018070500).
# cat /etc/redhat-release
CentOS Linux release 7.5.1804 (Core)
# node -v
v5.12.0
# make css
npm install
Building CSS...
/git-mahara/mahara/node_modules/gulp-sass/index.js:66
let sassMap;
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet
supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:387:25)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Module.require (module.js:367:17)
at require (internal/module.js:20:19)
at Object. (/git-mahara/mahara/gulpfile.js:8:12)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
To avoid the errors, we can add "use strict"; to index.js as below.
File to modify:
mahara/node_modules/gulp-sass/index.js
Line:
1
[ Before ]
const chalk = require('chalk');
const PluginError = require('plugin-error');
[ After ]
"use strict";
const chalk = require('chalk');
const PluginError = require('plugin-error');
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1785576/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1758801] Re: Mahara to ask for password before self-deleting account
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1758801 Title: Mahara to ask for password before self-deleting account Status in Mahara: In Progress Bug description: Follow-on from bug #1422492 When a user clicks the "Delete account" button, they should be asked for their password before initiating the direct account deletion or request the account deletion (possible from 18.04 onwards). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1758801/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1774106] Re: Upgrade 3rd party plugin simpleSAMLphp for php 7.2
We are waiting for SimpleSAMLphp 1.16.0 to be released. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1774106 Title: Upgrade 3rd party plugin simpleSAMLphp for php 7.2 Status in Mahara: In Progress Bug description: related to https://bugs.launchpad.net/mahara/+bug/1752743 Our current version of simpleSAMLphp has the deprecated function create_function. I'm not sure which version we are running, but I've checked the source code on the latest Github version which has updated this. https://simplesamlphp.org/download https://github.com/simplesamlphp/simplesamlphp To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1774106/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 634193] Re: post-max-size exceeding error is not tracked
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/634193 Title: post-max-size exceeding error is not tracked Status in Mahara: In Progress Bug description: If post-max-size PHP setting (http://php.net/manual/en/ini.core.php#ini.post-max-size) value is exceeded (by large file upload for example) no error is triggered, as result wherever upload is handled by ajax, no callback functions are called. This is partly related to bugs: https://bugs.launchpad.net/mahara/+bug/633760 https://bugs.launchpad.net/mahara/+bug/547505 Given that this error is triggered by PHP prior to processing the code, it can't be catch through exception. As forums suggests, it may worth using error_get_last() and grep result for "PHP Warning: POST Content-Length of" string. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/634193/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1261234] Re: A cron task to periodically clear the VERP bounce counts
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1261234 Title: A cron task to periodically clear the VERP bounce counts Status in Mahara: In Progress Bug description: Mahara has a VERP system to disable email addresses that have been bouncing. "Bounces_min" and "Bounces_ratio", and it disables an email when it has received more than "bounces_min" bounces and the ratio of bounced messages to all messages sent is greater than bounces_ratio. The thing is, these are *lifetime* numbers, and never get reset. This poses some difficulties once a site has been around for a few years, like mahara.org. We have some email addresses that have received thousands of messages. So, if we set bounces_threshold to something like the default "0.2" setting, then if one of those longtime addresses become invalid, we would continue to send hundreds of messages to it before we got around to disabling it. On the other hand, if we set bounces_threshold to 0, then we have the problem that the bounce count is cumulative and never gets reset. So, if we leave it at the default 5 emails, I could get disabled due to one bounce every three months over the course of a year and a half. Really, whether to disable someone's email should be based on how much it has been bouncing *recently*. So what we should do is add a cron task which sets the artefact_internal_profile_email.maillsent and artefact_internal_profile_email.bouncecount columns back to 0 periodically. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1261234/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1788287] Re: Allow blocks created via tags to keep original title
For "Also delete tag" we need to check the database that the association of the block with the tag is gone. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1788287 Title: Allow blocks created via tags to keep original title Status in Mahara: In Progress Bug description: Also delete the block tags when deleting the block This is fixing up problems from Bug 1775106: Creating page from tags To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1788287/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1773609] Re: User export has column "remotename" instead of "remoteuser"
We abandonded the original patch because it added complexity. Just make the CSV file download have the correct artefacttype names for preferredname and remoteuser. ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 ** Changed in: mahara Status: In Progress => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1773609 Title: User export has column "remotename" instead of "remoteuser" Status in Mahara: Confirmed Bug description: When you export user details via the "Reports" in Mahara, the column for the remote username / Username for external authentication is called "remotename". However, if you want to use the resulting CSV file to update user details, you'll have to rename that column to "remoteuser" first. It would be better if the column was called "remoteuser" to start with in the export. To replicate: 1. Have a couple of users on your Mahara site. 2. Go to Admin -> User search and click the check boxes. 3. Click the "Get reports for selected users" button. 4. Download the data on the next screen. Expected result: The column storing the remote username is called "remoteuser". Actual result: It's called "remotename". To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1773609/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1755626] Re: behat test for latest pages name change to Latest changes
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1755626 Title: behat test for latest pages name change to Latest changes Status in Mahara: In Progress Bug description: Update Existing Behat feature file Need to amend existing feature file to automate manual test for bug: https://bugs.launchpad.net/mahara/+bug/1493199 Amendment to Behat: test/behat/features/site_content/homepage_buttons.feature Add the following to the bottom of Scenario: Checking navigation of the big homepage buttons And I should see "Latest changes I can view" And I should not see "Latest pages" To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1755626/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1756751] Re: Behat: fix click on the locator/selector step
changes superceeded by bug 1733995 https://reviews.mahara.org/#/c/8666/ ** Changed in: mahara Status: In Progress => Invalid ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1756751 Title: Behat: fix click on the locator/selector step Status in Mahara: Invalid Bug description: The new step merged with https://reviews.mahara.org/#/c/8553/ doesn't allow a selectortype (e.g. css/xpath) to be passed in with the locator, but assumes that the selector will be css. This needs to be fixed to make it more configurable. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1756751/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1773272] Re: Behat: copy_taggedposts.feature failing in jenkins
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1773272 Title: Behat: copy_taggedposts.feature failing in jenkins Status in Mahara: Fix Committed Bug description: Despite not being able to replicate this locally, there is a problem with jenkins failing the test/behat/features/user_content/copy_taggedposts.feature. It fails on line 55: And I follow "Page UserA_01", which comes directly after: And I scroll to the id "view" My supposition is that the scroll step not being finished is causing the test to fail, but there are several tests using that step successfully, so that is not the whole story. This issue needs a bit of investigation to see what is going on. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1773272/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1752699] Re: Behat test: Export collections in bulk
** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: In Progress => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1752699 Title: Behat test: Export collections in bulk Status in Mahara: Confirmed Bug description: In bug #1528117 the option to export collections in bulk is added. Here we are creating the Behat test for it. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1752699/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692755] Re: Move focus to first item in menu list
** Changed in: mahara Status: In Progress => Confirmed ** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Assignee: Pramith Dayananda (pramithkm) => (unassigned) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692755 Title: Move focus to first item in menu list Status in Mahara: Confirmed Bug description: Mahara 17.04+ When user presses Enter on Show Main Menu button, focus should move to the first item on the menu list. This also applies to Show User Menu button and the "Show Admin Menu" button. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692755/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1649433] Re: Consolidate "Add file" buttons
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1649433 Title: Consolidate "Add file" buttons Status in Mahara: In Progress Bug description: We use two different ways of adding files to a text box / resume sections etc.: One, which allows you to add files from both your Mahara storage and computer and another one only from the computer. The latter one is the older one and can still be found in certain places. We should consolidate the occurances to always use the new way of adding files to be more consistent. Best case in point: When you add a file to your education history, you get the old button. However, when you edit that entry, you get the new button (see attachment). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1649433/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1761637] Re: Update Existing Behat feature file to check for error messages
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1761637 Title: Update Existing Behat feature file to check for error messages Status in Mahara: Fix Committed Bug description: Update Existing Behat feature file Need to check for error messages Behat test: Settings > loginattempts.feature already exists - need to update behat test to include the following: # Check for error message * Then I should see "You have not provided the correct credentials to log in. Please check your username and password are correct." * And I should see "There was an error with submitting this form. Please check the marked fields and try again." To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1761637/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1755049] Re: behat test for themes
** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: In Progress => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1755049 Title: behat test for themes Status in Mahara: Confirmed Bug description: Update Existing Behat feature file Behat test: Settings > User_themes.feature already exists - need to update behat test to include the following: Verify Themes: 1) Must be uploaded directly onto the web server by a system administrator. 2) Can override the page template for every single screen in Mahara, giving total control over how everything is displayed. 4) Depending on site and institution settings, there may be: * a single theme for the whole site * a theme for every institution * the possibility for users to choose their own theme for browsing the site * the possibility for users to apply a particular theme to each portfolio page, the page themes To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1755049/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1780328] Re: MNet logs user out when they try to jump from moodle to mahara once already logged in
We are moving away from MNet and will have the assignment submission via LTI. If someone requires this fix, it is available under the patch https://reviews.mahara.org/8990 ** Changed in: mahara Milestone: 18.10.0 => None ** Changed in: mahara Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1780328 Title: MNet logs user out when they try to jump from moodle to mahara once already logged in Status in Mahara: Won't Fix Bug description: When connecting from Moodle to Mahara we login via the MNet connection but on subsequent jumps it logs us out. Steps to reprodule: 1) Have a Moodle -> Mahara setup using MNet 2) On Moodle side have a course with an assignment submission block and have a user assigned to course 3) Log in as user 4) Go to the assignment and 'edit assignment' then click the "click here to visit" link This will take you to Mahara and log you in 5) Click the "Return to Moodle" link 6) do step 4 again You end up logged out of mahara/moodle The reason for this is when we come from moodle this way it sets the HTTP_USER_AGENT to be 'Moodle' which is not the same as your current useragent. We need to allow useragent 'Moodle' to only clear/reset current session on store To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1780328/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1742304] Re: Remove duplicate language strings
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1742304 Title: Remove duplicate language strings Status in Mahara: In Progress Bug description: There are quite a few instances where the same language string is repeated in different files. The duplicates should be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1742304/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681591] Re: Reorganise where we have the profile links/information
We are doing #1 in https://reviews.mahara.org/9084 ** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681591 Title: Reorganise where we have the profile links/information Status in Mahara: In Progress Bug description: I am thinking of reorganising the placement of profile things. Ideas: - Move the navigation 'Profile' and 'Profile image' options from 'Main menu' (content section) to 'User menu' - Merge 'Profile' and 'Profile image' options into one 'Profile settings' page/link - Remove the profile page/dashboard page from list of 'Pages and collections' list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681591/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1782954] Re: Change main menu and move items around
https://reviews.mahara.org/9084 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1782954 Title: Change main menu and move items around Status in Mahara: Confirmed Bug description: The main menu and the user menu in Mahara need updating as the distinction between "Content" and "Portfolio" does not quite work anymore. The proposal was made at https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Navigation For Mahara 18.10, we would implement the option with no functionality change for the main menu as attached. The menu is supposed to look as in the attached mock-up, except for the icons, where we'll choose Font Awesome icons. The user menu also changes slightly. The admin menu stays pretty much the same, but does get icons added. For all three menus, the following change is to be made: The category is used entirely to show or hide the submenus and not used to click on and get to the first item in the sub menu as is presently the case. The chevron still stays at the category level to indicate the possibility to expand and retract the menu. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1782954/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1667522] Re: Separate account registration and institution joining requests
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1667522 Title: Separate account registration and institution joining requests Status in Mahara: In Progress Bug description: When you allow registration in an institution, two actions are allowed: 1. New users can register on the site for that institution. 2. Existing users can request membership in the institution. These two actions should be separated as they are two very different actions. While an institution may allow the registration of new accounts, they may not allow the switching of institutions by simply contacting another institution. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1667522/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1749339] Re: Add pre_loginpage_hooks
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1749339 Title: Add pre_loginpage_hooks Status in Mahara: In Progress Bug description: Give a chance for auth plugins to authenticate the user or perform other tasks before showing the login page. This is similar to https://tracker.moodle.org/browse/MDL-48887 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1749339/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1753520] Re: Include external js files for blocktype config forms
This already exists in Mahara. ** Changed in: mahara Status: In Progress => Invalid ** Changed in: mahara Milestone: 18.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1753520 Title: Include external js files for blocktype config forms Status in Mahara: Invalid Bug description: In Cloud plugin blocktypes I need the ability to include external javascript files that are needed in blocktype config forms. The ability to include external javascript files in blocktype config form might be usable also for other artefacts/blocktypes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1753520/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1696291] Re: Allow the splitting of Behat tests
** Changed in: mahara Milestone: 18.10.0 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1696291 Title: Allow the splitting of Behat tests Status in Mahara: In Progress Bug description: https://reviews.mahara.org/#/c/7811/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1696291/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1784778] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9097 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1784778 Title: Peer assessment block Status in Mahara: In Progress Bug description: A new block is created that can only be filled with content from a person who has the “Peer assessment” role for a portfolio. The block can be selected by the portfolio author for inclusion on any page, but it can only be used in conjunction with the peer assessor role. If no peer assessor is selected for a portfolio, the block stays empty. It is also available on the site and institution level for inclusion into portfolio pages there (for the creation of templates). Characteristics of the block: • Title: Peer assessment (editable by the portfolio author); • Retractable functionality is available like on every other block and follows the same rules and the portfolio author can move or delete the block as usual; • Instructions can be added to the block to let peer know what is expected of them. The page owner can write these instructions (or they are transferred from the template). The instructions can be made available via an expandable link in the block itself so as not to be present at all times. • Portfolio author cannot enter any content; • When a person with the “Peer assessor” role views a portfolio page that contains this block, they see the link “Add peer assessment”; • A modal slides in from the side in which the peers have a text box available in which they can write their assessment. It does not have to be a TinyMCE text field; • The text can be saved as draft (visible only to the peer) or published (visible to the user); • When the text is in draft mode, the peer can make changes to it and nobody else but them can see the text, the block always slides out in the side panel when making changes to the text; • The block tracks when it was first saved and when the last update was made; • The profile picture and name of the peer assessor is displayed in the block (similar to the display in comments); • When the text is published, the peer assessor has 10 minutes to make any other changes before the assessment is locked in place, and the user can view the assessment and delete it if necessary; • Peer assessments become visible to everybody else when the user signs off the entire page; • More than one peer assessment can be made. Every peer assessor only sees their own content. When their content is published, the assessments are distinguished by the name of the peer assessor; • When peer assessments have been made, but peer assessor status has been revoked for a person, their assessment stays on the page either in draft or published status. The portfolio author can fully remove the block and thus delete any drafts and pull another peer assessment block into the page if needed. In order for it to work properly, it will require a new role "Peer assessor" and the possibility to choose that during the portfolio sharing process (bug #1784781). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1784778/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776814] A change has been merged
Reviewed: https://reviews.mahara.org/9096 Committed: https://git.mahara.org/mahara/mahara/commit/1dc696cbfa92123bd5e1d7f031d42ba6e933d03e Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:18.04_STABLE commit 1dc696cbfa92123bd5e1d7f031d42ba6e933d03e Author: Sarah Kirby Date: Mon Jul 16 10:48:14 2018 +1200 Bug1776814: Ensure search field doesn't close on mobile when field is focused behatnotneeded Change-Id: I5353e13e4e41bfcf742cb013e5640288e6f03bda (cherry picked from commit 71f1616032315abb8a3b0085919171536603b49b) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776814 Title: can't search on mobile Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: for 18.04.2, tested on demo.mahara.org mobile screen 320x480 login and click on search icon the search users field is displayed if we click on it, the field is hidden making it impossible to type a search value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776814] A change has been merged
Reviewed: https://reviews.mahara.org/9013 Committed: https://git.mahara.org/mahara/mahara/commit/71f1616032315abb8a3b0085919171536603b49b Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 71f1616032315abb8a3b0085919171536603b49b Author: Sarah Kirby Date: Mon Jul 16 10:48:14 2018 +1200 Bug1776814: Ensure search field doesn't close on mobile when field is focused behatnotneeded Change-Id: I5353e13e4e41bfcf742cb013e5640288e6f03bda -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776814 Title: can't search on mobile Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: for 18.04.2, tested on demo.mahara.org mobile screen 320x480 login and click on search icon the search users field is displayed if we click on it, the field is hidden making it impossible to type a search value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776814] Re: can't search on mobile
** Changed in: mahara/18.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776814 Title: can't search on mobile Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: for 18.04.2, tested on demo.mahara.org mobile screen 320x480 login and click on search icon the search users field is displayed if we click on it, the field is hidden making it impossible to type a search value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776814] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9096 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776814 Title: can't search on mobile Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: for 18.04.2, tested on demo.mahara.org mobile screen 320x480 login and click on search icon the search users field is displayed if we click on it, the field is hidden making it impossible to type a search value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1776814] Re: can't search on mobile
** Changed in: mahara/18.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1776814 Title: can't search on mobile Status in Mahara: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: for 18.04.2, tested on demo.mahara.org mobile screen 320x480 login and click on search icon the search users field is displayed if we click on it, the field is hidden making it impossible to type a search value To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1776814/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785514] Re: Adding user to new institution changes auth method for all users
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785514 Title: Adding user to new institution changes auth method for all users Status in Mahara: Fix Committed Bug description: When testing on master I did the following: 1) Upgrade an existing site from 16.10 -> Master 2) Checked the auth instance of all of the users (it was 1 = mahara / internal) 3) Created a new institution and added 'webservice' auth and deleted internal auth and saved 4) Checked the auth_instance table - there was only mahara/internal and newinstitution/webservice options 5) On admin user edit page I add a user to the new institution - they go from mahara/internal to newistitution/internal auth. 6) On checking the auth_instance table there is now a newinstitution/internal option - which is correct as the user will still need internal auth But the problem comes when I check the usr table - all the users have this new newinstitution/internal option no matter what institution they are currently in There is something wrong with adding user to institution To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785514] A change has been merged
Reviewed: https://reviews.mahara.org/9046 Committed: https://git.mahara.org/mahara/mahara/commit/6b1e661837a1737b0ab9d67750c320dada49a82d Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 6b1e661837a1737b0ab9d67750c320dada49a82d Author: Robert Lyon Date: Mon Aug 6 10:04:38 2018 +1200 Bug 1785514: Only update auth instance for this user When we add a user to an institution that doesn't have internal auth on the admin/users/edit.php page behatnotneeded Change-Id: I7395d1481b15c0e1e82eec0a61b3cca891df72f9 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785514 Title: Adding user to new institution changes auth method for all users Status in Mahara: Fix Committed Bug description: When testing on master I did the following: 1) Upgrade an existing site from 16.10 -> Master 2) Checked the auth instance of all of the users (it was 1 = mahara / internal) 3) Created a new institution and added 'webservice' auth and deleted internal auth and saved 4) Checked the auth_instance table - there was only mahara/internal and newinstitution/webservice options 5) On admin user edit page I add a user to the new institution - they go from mahara/internal to newistitution/internal auth. 6) On checking the auth_instance table there is now a newinstitution/internal option - which is correct as the user will still need internal auth But the problem comes when I check the usr table - all the users have this new newinstitution/internal option no matter what institution they are currently in There is something wrong with adding user to institution To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785514/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
