Re: [Mesa-dev] [PATCH 2/2] radv/gfx10: hardcode some depth+stencil formats in the format table
r-b for both.
On Tue, Aug 20, 2019 at 3:19 PM Samuel Pitoiset
wrote:
>
> The script doesn't handle them correctly and D16_UNORM_S8_UINT
> isn't supported by the hardware, mark it as invalid.
>
> This fixes warning when generating gfx10_format_table.h.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111393
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/gfx10_format_table.py | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/amd/vulkan/gfx10_format_table.py
> b/src/amd/vulkan/gfx10_format_table.py
> index 81b0bed92aa..f55b302bf82 100644
> --- a/src/amd/vulkan/gfx10_format_table.py
> +++ b/src/amd/vulkan/gfx10_format_table.py
> @@ -66,6 +66,11 @@ HARDCODED = {
> 'VK_FORMAT_BC6H_SFLOAT_BLOCK': hardcoded_format('BC6_SFLOAT'),
> 'VK_FORMAT_BC7_UNORM_BLOCK': hardcoded_format('BC7_UNORM'),
> 'VK_FORMAT_BC7_SRGB_BLOCK': hardcoded_format('BC7_SRGB'),
> +
> +# DS
> +'VK_FORMAT_D16_UNORM_S8_UINT': hardcoded_format('INVALID'),
> +'VK_FORMAT_D24_UNORM_S8_UINT': hardcoded_format('8_24_UNORM'),
> +'VK_FORMAT_D32_SFLOAT_S8_UINT': hardcoded_format('X24_8_32_FLOAT'),
> }
>
>
> --
> 2.22.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [ANNOUNCE] mesa 19.2.0-rc1
The first release candidate for Mesa 19.2.0 is now available. The plan is to have one release candidate every Tuesday, until the anticipated final release on 10th September 2019. The expectation is that the 19.1 branch will remain alive with bi-weekly releases until the 19.2.1 release. In the path to 19.2.0 release, there is a tracker bug for the regressions found since 19.1: https://bugs.freedesktop.org/show_bug.cgi?id=111444 Here are the people which helped shape the current release. 8 Adam Jackson 1 Ahmad Fatoum 35 Alejandro Piñeiro 1 Alex Villacís Lasso 26 Alexandros Frantzis 1 Alistair Strachan 638 Alyssa Rosenzweig 1 Amit Pundir 12 Andreas Baierl 1 Andreas Bergmeier 3 Andres Gomez 1 Andres Rodriguez 1 Andrii Kryvytskyi 5 Andrii Simiklit 14 Antia Puentes 7 Anuj Phogat 5 Arcady Goldmints-Orlov 1 Arfrever Frehtes Taifersar Arahesis 1 Arnaud Patard 1 Axel Davy 114 Bas Nieuwenhuizen 33 Boris Brezillon 19 Boyuan Zhang 9 Brian Paul 95 Caio Marcelo de Oliveira Filho 3 Charmaine Lee 1 Chenglei Ren 53 Chia-I Wu 11 Chih-Wei Huang 1 Chris Forbes 3 Chris Wilson 1 Christian GMEINER 28 Christian Gmeiner 69 Connor Abbott 24 Daniel Schürmann 2 Daniel Stone 7 Danylo Piliaiev 41 Dave Airlie 1 David Riley 2 Deepak Rawat 5 Dongwon Kim 24 Dylan Baker 7 Eduardo Lima Mitev 13 Emil Velikov 90 Eric Anholt 169 Eric Engestrom 26 Erico Nunes 89 Erik Faye-Lund 5 Francisco Jerez 38 Gert Wollny 8 Greg V 20 Guido Günther 8 Gurchetan Singh 1 Haihao Xiang 2 Harish Krupo 1 Heinrich Fink 7 Hyunjun Ko 57 Iago Toral Quiroga 83 Ian Romanick 12 Ilia Mirkin 1 Illia Iorin 1 James Clarke 1 James Zhu 1 Jan Vesely 20 Jan Zielinski 198 Jason Ekstrand 1 Jeremy Newton 5 John Stultz 3 Jon Turney 1 Jonas Ådahl 56 Jonathan Marek 14 Jordan Justen 1 Jorge Natz 2 Jory Pratt 4 Jose Maria Casanova Crespo 1 José Fonseca 19 Juan A. Suarez Romero 1 Julien Isorce 1 Józef Kucia 1 Kai Wasserbäch 9 Karol Herbst 167 Kenneth Graunke 2 Kevin Strasser 4 Khaled Emara 10 Kristian Høgsberg 2 Krzysztof Raszkowski 8 Leo Liu 1 Lepton Wu 54 Lionel Landwerlin 2 Lucas Stach 274 Marek Olšák 5 Marek Vasut 62 Mark Janes 1 Mark Menzynski 1 Mateusz Krzak 9 Mathias Fröhlich 9 Matt Turner 10 Mauro Rossi 13 Michel Dänzer 1 Michel Zou 2 Mika Kuoppala 10 Mike Blumenkrantz 1 Mike Lothian 14 Nanley Chery 3 Nataraj Deshpande 1 Neha Bhende 14 Neil Roberts 133 Nicolai Hähnle 1 Nicolas Dufresne 2 Patrick Lerda 9 Paulo Zanoni 1 Philipp Zabel 64 Pierre-Eric Pelloux-Prayer 1 Pratik Vishwakarma 7 Qiang Yu 18 Rafael Antognolli 15 Rhys Perry 1 Richard Thier 99 Rob Clark 2 Rob Herring 5 Rohan Garg 5 Roland Scheidegger 4 Roman Stratiienko 1 Rui Salvaterra 1 Ruslan Kabatsayev 28 Sagar Ghuge 3 Samuel Iglesias Gonsálvez 282 Samuel Pitoiset 6 Sergii Romantsov 2 Sonny Jiang 9 Tapani Pälli 11 Thomas Hellstrom 42 Timothy Arceri 2 Timur Kristóf 58 Tomeu Vizoso 1 Uros Bizjak 23 Vasily Khoruzhick 1 Ville Syrjälä 5 Vinson Lee 1 Xiong, James 11 Yevhenii Kolesnikov 1 renchenglei git tag: mesa-19.2.0-rc1 https://mesa.freedesktop.org/archive/mesa-19.2.0-rc1.tar.xz MD5: 24834b9b9eda02522b6f5ea28cee226b mesa-19.2.0-rc1.tar.xz SHA1: da226b53126de99b302baca0a64e4d6c8a63b555 mesa-19.2.0-rc1.tar.xz SHA256: 71baa3bb608cfc818f48d55405d230ca863927e7751a21d88deaeddf17d3b2ec mesa-19.2.0-rc1.tar.xz SHA512: babafb6ec668834e041a62e966452fe315e4f5afef8e1f7d35e038993c73b32ea6ad9929399edae4686f44cd11704fd9a8801821befc1d1767bc0662d4c39fac mesa-19.2.0-rc1.tar.xz PGP: https://mesa.freedesktop.org/archive/mesa-19.2.0-rc1.tar.xz.sig ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111444] [TRACKER] Mesa 19.2 release tracker
https://bugs.freedesktop.org/show_bug.cgi?id=111444 Bug ID: 111444 Summary: [TRACKER] Mesa 19.2 release tracker Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Other Assignee: mesa-dev@lists.freedesktop.org Reporter: emil.l.veli...@gmail.com QA Contact: mesa-dev@lists.freedesktop.org This is a tracker for regressions from 19.1 until 19.2 release -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Mesa 19.2.0 release plan
Sorry for the late breaking hold but I just realized that GL_ARB_gl_spirv and OpenGL 4.6 for Intel is 1 regression (I think it's not even a regression) away from landing. Can I have 24 hours? On Mon, Aug 19, 2019 at 10:30 AM Emil Velikov wrote: > On Sunday, 18 August 2019, Matt Turner wrote: > >> On Thu, Aug 8, 2019 at 2:56 AM Emil Velikov >> wrote: >> > >> > On Wed, 7 Aug 2019 at 21:43, Mark Janes wrote: >> > > >> > > Eric Engestrom writes: >> > > >> > > > On 2019-07-31 at 09:38, Emil Velikov >> wrote: >> > > >> Hi all, >> > > >> >> > > >> Here is the tentative release plan for 19.2.0. >> > > >> >> > > >> As many of you are well aware, it's time to the next branch point. >> > > >> The calendar is already updated, so these are the tentative dates: >> > > >> >> > > >> Aug 06 2019 - Feature freeze/Release candidate 1 >> > > >> Aug 13 2019 - Release candidate 2 >> > > >> Aug 20 2019 - Release candidate 3 >> > > >> Aug 27 2019 - Release candidate 4/final release >> > > >> >> > > >> This gives us around 1 week until the branch point. >> > > >> >> > > >> Note: In the spirit of keeping things clearer and more >> transparent, we >> > > >> will be keeping track of any features planned for the release in >> > > >> Bugzilla [1]. >> > > >> >> > > >> Do add a separate "Depends on" for each work you have planned. >> > > >> Alternatively you can reply to this email and I'll add them for >> you. >> > > >> >> > > >> [1] https://bugs.freedesktop.org/show_bug.cgi?id=111265 >> > > > >> > > > Thanks! >> > > > >> > > > As per previous discussions (I don't remember where, sorry) as well >> as >> > > > internal discussions, I think we should add all currently open >> > > > regressions since 19.1 as blockers for this release. >> > > >> > > My understanding is that the "feature tracker" blocks the creation of >> > > the release branchpoint. A separate "release tracker" blocks the >> > > release of 19.2.0. Unfixed regressions go on the "release tracker", >> not >> > > the "feature tracker". We backport bug fixes to release branches, but >> > > we don't backport features. >> > > >> > Yes that is correct. We are interested in features for the next few >> days. >> > Afterwords we'll focus on bugfixes. >> >> The last bug in the feature tracker was closed on the 14th. Can we make >> RC1 now? >> > > Hi Matt, > > Sure thing. I'm about to board the plane in a few minutes, I'll roll RC1 > first thing tomorrow morning. > > Thanks > Emil > P.S. Pardon the html formatting > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] gallivm: fix atomic compare-and-swap
From: Dave Airlie
Not sure how I missed this before, but compswap was hitting an
assert here as it is it's own special case.
Fixes: b5ac381d8f ("gallivm: add buffer operations to the tgsi->llvm
conversion.")
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index 31f6f082acc..7c747f38e7a 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
@@ -3585,6 +3585,8 @@ atomic_emit(
case TGSI_OPCODE_ATOMIMAX:
op = LLVMAtomicRMWBinOpMax;
break;
+ case TGSI_OPCODE_ATOMCAS:
+ break;
default:
assert(0);
return;
--
2.21.0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [ANNOUNCE] Mesa 19.1.5 release candidate
Hello list, The candidate for the Mesa 19.1.5 is now available. Currently we have: - 15 queued - 1 nominated (outstanding) - and 1 rejected patch The current queue is not as big as in previous releases, and it is as usual mostly fixes. Take a look at section "Mesa stable queue" for more information Testing reports/general approval Any testing reports (or general approval of the state of the branch) will be greatly appreciated. The plan is to have 19.1.5 this Friday (23th August), around or shortly after 10:00 GMT. If you have any questions or suggestions - be that about the current patch queue or otherwise, please go ahead. Trivial merge conflicts --- commit c4ab0e18bbd99664b364936c039edbd7757385c0 Author: Bas Nieuwenhuizen radv: Avoid VEGA/RAVEN scissor bug in binning. (cherry picked from commit 23a9d20997517dfff7f35e3a6c2b954564f0f6c4) commit 908d85ffce745ea3e417f807d3f9db6fdd9c3f55 Author: Bas Nieuwenhuizen radv: Avoid binning RAVEN hangs. (cherry picked from commit 4a3f987afda6469f274485e9f8b4ecc2308ad815) commit f837d0a6a36ba2ce2699ff6935c6275ef7dd10e9 Author: Marek Olšák radeonsi: disable SDMA image copies on dGPUs to fix corruption in games (cherry picked from commit 6b3ee86989edb854094d3aba122b40498fca94d8) Cheers, J.A. Mesa stable queue - Nominated (1) == Daniel Schürmann (1): 204846ad062 nir/lcssa: handle deref instructions properly Queued (15) === Bas Nieuwenhuizen (4): radv: Do non-uniform lowering before bool lowering. ac/nir: Use correct cast for readfirstlane and ptrs. radv: Avoid binning RAVEN hangs. radv: Avoid VEGA/RAVEN scissor bug in binning. Danylo Piliaiev (1): i965: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D Eric Engestrom (1): util: fix mem leak of program path Erik Faye-Lund (2): gallium/dump: add missing query-type to short-list gallium/dump: add missing query-type to short-list Greg V (2): anv: remove unused Linux-specific include intel/perf: use MAJOR_IN_SYSMACROS/MAJOR_IN_MKDEV Jason Ekstrand (1): anv: Emit a dummy MEDIA_VFE_STATE before switching from GPGPU to 3D Marek Olšák (2): radeonsi: disable SDMA image copies on dGPUs to fix corruption in games radeonsi: fix an assertion failure: assert(!res->b.is_shared) Matt Turner (1): meson: Test for program_invocation_name Sergii Romantsov (1): i965/clear: clear_value better precision Rejected (1) = Boris Brezillon (1): 20b00e1ff24 panfrost: Make ctx->job useful Reason: This commit requires other commits not landed in branch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] dEQP + llvmpipe
> I think that for GL and GLES contexts, we should disable noncormant hacks > instead of using env vars to falsely claim conformance. The hacks controlled for `GALLIVM_DEBUG=no_rho_approx,no_brilinear,no_quad_lod` where meant to speed up commonplace 3D rendering, on any kind of context (GL or not). These particular hacks were not designed with Direct3D contexts or any VMware specific workloads in mind. They are meant to speed up texture sampling, which often dominates pixel shader performance. Regarding the default llvmpipe behavior is, it really depends what its goal is: fast SW renderering with acceptable quality, or a fully compliant SW renderering. So far we've favoured performance over full conformance. Unfortunately, it's impossible to be both. I'm OK not claiming any conformance with llvmpipe FWIW. Jose From: mesa-dev on behalf of Eric Anholt Sent: Tuesday, August 13, 2019 21:49 To: Ilia Mirkin Cc: ML Mesa-dev Subject: Re: [Mesa-dev] dEQP + llvmpipe Ilia Mirkin writes: > Hi Eric, > > I see that you recently added testing dEQP with llvmpipe in the CI. It > looks like a number of your expected failures would be resolved by > disabling some llvmpipe optimizations. You can do this by running with > > GALLIVM_DEBUG=no_rho_approx,no_brilinear,no_quad_lod > > in the environment. Some of this is detailed in > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2Fshow_bug.cgi%3Fid%3D94957data=02%7C01%7Cjfonseca%40vmware.com%7C8cfcb00c765b4596fc0708d7202fc088%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637013261788370956sdata=WZ0LimnTNWwlGYoaldC0q9D3vBk4zBFONF6W0MibFxA%3Dreserved=0 > . Yeah, this was discussed in the MR. I think that for GL and GLES contexts, we should disable noncormant hacks instead of using env vars to falsely claim conformance. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111125] [RADV] Graphic glitches regression in The Witcher 3 with DXVK on AMD Radeon HD7850
https://bugs.freedesktop.org/show_bug.cgi?id=25 --- Comment #4 from Samuel Pitoiset --- Are you still able to reproduce the problem? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/vl: use compute preference for all multimedia, not just blit
Reviewed-by: Marek Olšák Marek On Sat, Aug 17, 2019 at 12:17 PM Ilia Mirkin wrote: > The compute paths in vl are a bit AMD-specific. For example, they (on > nouveau), try to use a BGRX8 image format, which is not supported. > Fixing all this is probably possible, but since the compute paths aren't > in any way better, it's difficult to care. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 > Fixes: 9364d66cb7 (gallium/auxiliary/vl: Add video compositor compute > shader render) > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/util/u_screen.c| 2 +- > src/gallium/auxiliary/vl/vl_compositor.c | 2 +- > src/gallium/docs/source/screen.rst | 4 ++-- > src/gallium/drivers/radeonsi/si_get.c| 2 +- > src/gallium/include/pipe/p_defines.h | 2 +- > src/gallium/state_trackers/va/postproc.c | 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_screen.c > b/src/gallium/auxiliary/util/u_screen.c > index 0b4bb067d6d..88f4945e755 100644 > --- a/src/gallium/auxiliary/util/u_screen.c > +++ b/src/gallium/auxiliary/util/u_screen.c > @@ -331,7 +331,7 @@ u_pipe_screen_get_param_defaults(struct pipe_screen > *pscreen, > case PIPE_CAP_TGSI_ATOMFADD: > case PIPE_CAP_TGSI_SKIP_SHRINK_IO_ARRAYS: > case PIPE_CAP_IMAGE_LOAD_FORMATTED: > - case PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA: > + case PIPE_CAP_PREFER_COMPUTE_FOR_MULTIMEDIA: > case PIPE_CAP_FRAGMENT_SHADER_INTERLOCK: > case PIPE_CAP_CS_DERIVED_SYSTEM_VALUES_SUPPORTED: > case PIPE_CAP_ATOMIC_FLOAT_MINMAX: > diff --git a/src/gallium/auxiliary/vl/vl_compositor.c > b/src/gallium/auxiliary/vl/vl_compositor.c > index 04808e80d84..a381af108b3 100644 > --- a/src/gallium/auxiliary/vl/vl_compositor.c > +++ b/src/gallium/auxiliary/vl/vl_compositor.c > @@ -764,7 +764,7 @@ vl_compositor_init(struct vl_compositor *c, struct > pipe_context *pipe) > > memset(c, 0, sizeof(*c)); > > - c->pipe_cs_composit_supported = pipe->screen->get_param(pipe->screen, > PIPE_CAP_COMPUTE) && > + c->pipe_cs_composit_supported = pipe->screen->get_param(pipe->screen, > PIPE_CAP_PREFER_COMPUTE_FOR_MULTIMEDIA) && > pipe->screen->get_param(pipe->screen, > PIPE_CAP_TGSI_TEX_TXF_LZ) && > pipe->screen->get_param(pipe->screen, PIPE_CAP_TGSI_DIV); > > diff --git a/src/gallium/docs/source/screen.rst > b/src/gallium/docs/source/screen.rst > index c033321ec66..d149a2f4c9f 100644 > --- a/src/gallium/docs/source/screen.rst > +++ b/src/gallium/docs/source/screen.rst > @@ -528,8 +528,8 @@ The integer capabilities: >execution. 0 = throttling is disabled. > * ``PIPE_CAP_DMABUF``: Whether Linux DMABUF handles are supported by >resource_from_handle and resource_get_handle. > -* ``PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA``: Whether VDPAU, VAAPI, > and > - OpenMAX should use a compute-based blit instead of pipe_context::blit. > +* ``PIPE_CAP_PREFER_COMPUTE_FOR_MULTIMEDIA``: Whether VDPAU, VAAPI, and > + OpenMAX should use a compute-based blit instead of pipe_context::blit > and compute pipeline for compositing images. > * ``PIPE_CAP_FRAGMENT_SHADER_INTERLOCK``: True if fragment shader > interlock >functionality is supported. > * ``PIPE_CAP_CS_DERIVED_SYSTEM_VALUES_SUPPORTED``: True if driver handles > diff --git a/src/gallium/drivers/radeonsi/si_get.c > b/src/gallium/drivers/radeonsi/si_get.c > index c9895edafb8..f85a53393aa 100644 > --- a/src/gallium/drivers/radeonsi/si_get.c > +++ b/src/gallium/drivers/radeonsi/si_get.c > @@ -156,7 +156,7 @@ static int si_get_param(struct pipe_screen *pscreen, > enum pipe_cap param) > case PIPE_CAP_FBFETCH: > case PIPE_CAP_COMPUTE_GRID_INFO_LAST_BLOCK: > case PIPE_CAP_IMAGE_LOAD_FORMATTED: > - case PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA: > + case PIPE_CAP_PREFER_COMPUTE_FOR_MULTIMEDIA: > case PIPE_CAP_TGSI_DIV: > return 1; > > diff --git a/src/gallium/include/pipe/p_defines.h > b/src/gallium/include/pipe/p_defines.h > index 0c79cac5cff..808c2b8cfaf 100644 > --- a/src/gallium/include/pipe/p_defines.h > +++ b/src/gallium/include/pipe/p_defines.h > @@ -885,7 +885,7 @@ enum pipe_cap > PIPE_CAP_IMAGE_LOAD_FORMATTED, > PIPE_CAP_MAX_FRAMES_IN_FLIGHT, > PIPE_CAP_DMABUF, > - PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA, > + PIPE_CAP_PREFER_COMPUTE_FOR_MULTIMEDIA, > PIPE_CAP_FRAGMENT_SHADER_INTERLOCK, > PIPE_CAP_FBFETCH_COHERENT, > PIPE_CAP_CS_DERIVED_SYSTEM_VALUES_SUPPORTED, > diff --git a/src/gallium/state_trackers/va/postproc.c > b/src/gallium/state_trackers/va/postproc.c > index fbc55b7714b..3431b1b48c7 100644 > --- a/src/gallium/state_trackers/va/postproc.c > +++ b/src/gallium/state_trackers/va/postproc.c > @@ -222,7 +222,7 @@ static VAStatus vlVaPostProcBlit(vlVaDriver *drv, > vlVaContext *context, >blit.filter = PIPE_TEX_MIPFILTER_LINEAR; > >if (drv->pipe->screen->get_param(drv->pipe->screen, > - >
Re: [Mesa-dev] [PATCH 2/2] radv: force enable VK_AMD_shader_ballot for Wolfenstein Youngblood
want to cc to 19.2?
r-b for both
On Tue, Aug 20, 2019 at 4:47 PM Samuel Pitoiset
wrote:
>
> This gives a nice boost, +20% at this time on my Vega 56. Shader
> ballot should be enabled by default at some point but it reduces
> performance a bit (-6%) with Wolfeinstein II. Enable it only for
> Youngblood at the moment, like what we did for Talos in the past.
>
> As a bonus point, it gets rid of some minor artifacts that only
> happens when ballot is disabled for some reasons.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 49518d43218..c04f6a27e82 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -554,6 +554,14 @@ radv_handle_per_app_options(struct radv_instance
> *instance,
> */
> if (HAVE_LLVM < 0x900)
> instance->debug_flags |= RADV_DEBUG_NO_LOAD_STORE_OPT;
> + } else if (!strcmp(name, "Wolfenstein: Youngblood")) {
> + if (!(instance->debug_flags & RADV_DEBUG_NO_SHADER_BALLOT)) {
> + /* Force enable VK_AMD_shader_ballot because it looks
> +* safe and it gives a nice boost (+20% on Vega 56 at
> +* this time).
> +*/
> + instance->perftest_flags |=
> RADV_PERFTEST_SHADER_BALLOT;
> + }
> }
> }
>
> --
> 2.22.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/2] radv: add a new debug option called RADV_DEBUG=noshaderballot
Shader ballot will be enabled by default for Wolfenstein
Youngblood. This follows what we did for sisched.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_debug.h | 1 +
src/amd/vulkan/radv_device.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h
index ef5b331d188..1a8b9a42c20 100644
--- a/src/amd/vulkan/radv_debug.h
+++ b/src/amd/vulkan/radv_debug.h
@@ -53,6 +53,7 @@ enum {
RADV_DEBUG_NOBINNING = 0x80,
RADV_DEBUG_NO_LOAD_STORE_OPT = 0x100,
RADV_DEBUG_NO_NGG= 0x200,
+ RADV_DEBUG_NO_SHADER_BALLOT = 0x400,
};
enum {
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index cc45ac95c08..49518d43218 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -495,6 +495,7 @@ static const struct debug_control radv_debug_options[] = {
{"nobinning", RADV_DEBUG_NOBINNING},
{"noloadstoreopt", RADV_DEBUG_NO_LOAD_STORE_OPT},
{"nongg", RADV_DEBUG_NO_NGG},
+ {"noshaderballot", RADV_DEBUG_NO_SHADER_BALLOT},
{NULL, 0}
};
--
2.22.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 2/2] radv: force enable VK_AMD_shader_ballot for Wolfenstein Youngblood
This gives a nice boost, +20% at this time on my Vega 56. Shader
ballot should be enabled by default at some point but it reduces
performance a bit (-6%) with Wolfeinstein II. Enable it only for
Youngblood at the moment, like what we did for Talos in the past.
As a bonus point, it gets rid of some minor artifacts that only
happens when ballot is disabled for some reasons.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 49518d43218..c04f6a27e82 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -554,6 +554,14 @@ radv_handle_per_app_options(struct radv_instance *instance,
*/
if (HAVE_LLVM < 0x900)
instance->debug_flags |= RADV_DEBUG_NO_LOAD_STORE_OPT;
+ } else if (!strcmp(name, "Wolfenstein: Youngblood")) {
+ if (!(instance->debug_flags & RADV_DEBUG_NO_SHADER_BALLOT)) {
+ /* Force enable VK_AMD_shader_ballot because it looks
+* safe and it gives a nice boost (+20% on Vega 56 at
+* this time).
+*/
+ instance->perftest_flags |= RADV_PERFTEST_SHADER_BALLOT;
+ }
}
}
--
2.22.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 2/2] radv/gfx10: hardcode some depth+stencil formats in the format table
The script doesn't handle them correctly and D16_UNORM_S8_UINT
isn't supported by the hardware, mark it as invalid.
This fixes warning when generating gfx10_format_table.h.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111393
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/gfx10_format_table.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/amd/vulkan/gfx10_format_table.py
b/src/amd/vulkan/gfx10_format_table.py
index 81b0bed92aa..f55b302bf82 100644
--- a/src/amd/vulkan/gfx10_format_table.py
+++ b/src/amd/vulkan/gfx10_format_table.py
@@ -66,6 +66,11 @@ HARDCODED = {
'VK_FORMAT_BC6H_SFLOAT_BLOCK': hardcoded_format('BC6_SFLOAT'),
'VK_FORMAT_BC7_UNORM_BLOCK': hardcoded_format('BC7_UNORM'),
'VK_FORMAT_BC7_SRGB_BLOCK': hardcoded_format('BC7_SRGB'),
+
+# DS
+'VK_FORMAT_D16_UNORM_S8_UINT': hardcoded_format('INVALID'),
+'VK_FORMAT_D24_UNORM_S8_UINT': hardcoded_format('8_24_UNORM'),
+'VK_FORMAT_D32_SFLOAT_S8_UINT': hardcoded_format('X24_8_32_FLOAT'),
}
--
2.22.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/2] radv/gfx10: tidy up gfx10_format_table.py
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/gfx10_format_table.py | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/src/amd/vulkan/gfx10_format_table.py
b/src/amd/vulkan/gfx10_format_table.py
index 34ad5f6cdf2..81b0bed92aa 100644
--- a/src/amd/vulkan/gfx10_format_table.py
+++ b/src/amd/vulkan/gfx10_format_table.py
@@ -21,7 +21,7 @@
# USE OR OTHER DEALINGS IN THE SOFTWARE.
#
"""
-Script that generates the mapping from Gallium PIPE_FORMAT_xxx to gfx10
+Script that generates the mapping from Vulkan VK_FORMAT_xxx to gfx10
IMG_FORMAT_xxx enums.
"""
@@ -34,12 +34,10 @@ import re
import sys
AMD_REGISTERS = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]),
"../registers"))
-#GALLIUM_UTIL = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]),
"../../auxiliary/util"))
sys.path.extend([AMD_REGISTERS])
from regdb import Object, RegisterDatabase
from vk_format_parse import *
-#from u_format_parse import *
#
# Hard-coded mappings
@@ -82,11 +80,11 @@ header_template = mako.template.Template("""\
##__VA_ARGS__ }
static const struct gfx10_format gfx10_format_table[VK_FORMAT_RANGE_SIZE] = {
-% for pipe_format, args in formats:
+% for vk_format, args in formats:
% if args is not None:
- [${pipe_format}] = FMT(${args}),
+ [${vk_format}] = FMT(${args}),
% else:
-/* ${pipe_format} is not supported */
+/* ${vk_format} is not supported */
% endif
% endfor
};
@@ -114,8 +112,8 @@ class Gfx10Format(object):
class Gfx10FormatMapping(object):
-def __init__(self, pipe_formats, gfx10_formats):
-self.pipe_formats = pipe_formats
+def __init__(self, vk_formats, gfx10_formats):
+self.vk_formats = vk_formats
self.gfx10_formats = gfx10_formats
self.plain_gfx10_formats = dict(
@@ -219,17 +217,17 @@ class Gfx10FormatMapping(object):
if __name__ == '__main__':
-pipe_formats = parse(sys.argv[1])
+vk_formats = parse(sys.argv[1])
with open(sys.argv[2], 'r') as filp:
db = RegisterDatabase.from_json(json.load(filp))
gfx10_formats = [Gfx10Format(entry) for entry in
db.enum('IMG_FORMAT').entries]
-mapping = Gfx10FormatMapping(pipe_formats, gfx10_formats)
+mapping = Gfx10FormatMapping(vk_formats, gfx10_formats)
formats = []
-for fmt in pipe_formats:
+for fmt in vk_formats:
if fmt.name in HARDCODED:
obj = HARDCODED[fmt.name]
else:
--
2.22.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 111406] [regression] - build failure on arm64
https://bugs.freedesktop.org/show_bug.cgi?id=111406 --- Comment #2 from Fabio Pedretti --- It seems the arm64 regression only happens when building with -flto on Ubuntu <= disco. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 110471] No Man Sky GPU hang
https://bugs.freedesktop.org/show_bug.cgi?id=110471 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #7 from Samuel Pitoiset --- Since the last update of No Man Sky, the game no longer hangs with RADV. The old issue probably still remains in LLVM but it got "fixed" by the game itself. As for the other issues, we are working on. Closing this ticket as it refers to an old GPU hang. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 2/2] radv/gfx10: do not emit PA_SC_TILE_STEERING_OVERRIDE twice
r-b for both On Mon, Aug 19, 2019 at 2:57 PM Samuel Pitoiset wrote: > > CLEAR_STATE emits it for us. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/si_cmd_buffer.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c > index a5057fe25a2..68ec925f2b5 100644 > --- a/src/amd/vulkan/si_cmd_buffer.c > +++ b/src/amd/vulkan/si_cmd_buffer.c > @@ -366,8 +366,6 @@ si_emit_graphics(struct radv_physical_device > *physical_device, > radeon_set_context_reg(cs, R_028C50_PA_SC_NGG_MODE_CNTL, >S_028C50_MAX_DEALLOCS_IN_WAVE(512)); > radeon_set_context_reg(cs, > R_028C58_VGT_VERTEX_REUSE_BLOCK_CNTL, 14); > - radeon_set_context_reg(cs, > R_02835C_PA_SC_TILE_STEERING_OVERRIDE, > - > physical_device->rad_info.pa_sc_tile_steering_override); > radeon_set_context_reg(cs, R_02807C_DB_RMI_L2_CACHE_CONTROL, > > S_02807C_Z_WR_POLICY(V_02807C_CACHE_STREAM_WR) | > > S_02807C_S_WR_POLICY(V_02807C_CACHE_STREAM_WR) | > -- > 2.22.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
