Re: [Mesa-dev] [PATCH] mesa/vbo: fix check for zero aliases with 2/10/10/10

2016-05-10 Thread Dave Airlie 
On 11 May 2016 at 04:06, Ian Romanick  wrote:
> It seems like at least some of these recent fixes should be candidates
> for stable.

I didn't think they were fixing any real world problems so I hadn't
really bothered,

I think I tagged one of them so far, my goal was to try and get Haswell to pass
GL 3.3 CTS, either by fixing CTS or fixing the driver. So far it's
mostly involved
fixing CTS, (I added you and a few others to my gitlab cts branch).

GL33-CTS.clip_distance.functional,Fail
GL33-CTS.transform_feedback.capture_special_interleaved_test,Fail
GL33-CTS.CommonBugs.CommonBug_ReservedNames,Fail
GL33-CTS.texture_size_promotion.functional,InternalError
are the 4 tests I have left,

the first is kinda random failing on i965, but passes on llvmpipe
the second is a bug in i965 somewhere I haven't located
(https://bugs.freedesktop.org/show_bug.cgi?id=95322)
the third is a GLSL compiler bug
(https://bugs.freedesktop.org/show_bug.cgi?id=95323)
the last after much test fixing is failing on depth textures somehow
but it's inconsistent and it still might
be the test, however it did find the snorm clamping bug.

I'm also in passing running CTS on radeonsi forced to GL4.5 to get
better coverage from CTS,
but I'll probably run out of time/steam soon.

Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/vbo: fix check for zero aliases with 2/10/10/10

2016-05-10 Thread Ian Romanick 
It seems like at least some of these recent fixes should be candidates
for stable.

On 05/09/2016 08:37 PM, Kenneth Graunke wrote:
> On Tuesday, May 10, 2016 11:07:23 AM PDT Dave Airlie wrote:
>> From: Dave Airlie 
>>
>> This fixes:
>> GL33-
> CTS.gtf33.GL3Tests.vertex_type_2_10_10_10_rev.vertex_type_2_10_10_10_rev_attrib
>>
>> Signed-off-by: Dave Airlie 
>> ---
>>  src/mesa/vbo/vbo_attrib_tmp.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/vbo/vbo_attrib_tmp.h b/src/mesa/vbo/vbo_attrib_tmp.h
>> index e73b8fb..ed0b2de 100644
>> --- a/src/mesa/vbo/vbo_attrib_tmp.h
>> +++ b/src/mesa/vbo/vbo_attrib_tmp.h
>> @@ -226,7 +226,7 @@ static inline float conv_i2_to_norm_float(const struct 
> gl_context *ctx, int i2)
>> } while(0)
>>  
>>  #define ATTR_UI_INDEX(ctx, val, type, normalized, index, arg) do {  \
>> -  if ((index) == 0) {   \
>> +  if ((index) == 0 && _mesa_attr_zero_aliases_vertex(ctx)) {\
>>   ATTR_UI(ctx, val, (type), normalized, 0, (arg));   \
>>} else if ((index) < MAX_VERTEX_GENERIC_ATTRIBS) {\
>>   ATTR_UI(ctx, val, (type), normalized, VBO_ATTRIB_GENERIC0 + (index), 
> (arg)); \
>>
> 
> It does look like we do this in every other case, so...
> 
> Reviewed-by: Kenneth Graunke 
> 
> 
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 




signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/vbo: fix check for zero aliases with 2/10/10/10

2016-05-09 Thread Kenneth Graunke 
On Tuesday, May 10, 2016 11:07:23 AM PDT Dave Airlie wrote:
> From: Dave Airlie 
> 
> This fixes:
> GL33-
CTS.gtf33.GL3Tests.vertex_type_2_10_10_10_rev.vertex_type_2_10_10_10_rev_attrib
> 
> Signed-off-by: Dave Airlie 
> ---
>  src/mesa/vbo/vbo_attrib_tmp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/vbo/vbo_attrib_tmp.h b/src/mesa/vbo/vbo_attrib_tmp.h
> index e73b8fb..ed0b2de 100644
> --- a/src/mesa/vbo/vbo_attrib_tmp.h
> +++ b/src/mesa/vbo/vbo_attrib_tmp.h
> @@ -226,7 +226,7 @@ static inline float conv_i2_to_norm_float(const struct 
gl_context *ctx, int i2)
> } while(0)
>  
>  #define ATTR_UI_INDEX(ctx, val, type, normalized, index, arg) do {   \
> -  if ((index) == 0) {\
> +  if ((index) == 0 && _mesa_attr_zero_aliases_vertex(ctx)) { \
>ATTR_UI(ctx, val, (type), normalized, 0, (arg));   \
>} else if ((index) < MAX_VERTEX_GENERIC_ATTRIBS) { \
>ATTR_UI(ctx, val, (type), normalized, VBO_ATTRIB_GENERIC0 + (index), 
(arg)); \
> 

It does look like we do this in every other case, so...

Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa/vbo: fix check for zero aliases with 2/10/10/10

2016-05-09 Thread Dave Airlie 
From: Dave Airlie 

This fixes:
GL33-CTS.gtf33.GL3Tests.vertex_type_2_10_10_10_rev.vertex_type_2_10_10_10_rev_attrib

Signed-off-by: Dave Airlie 
---
 src/mesa/vbo/vbo_attrib_tmp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/vbo/vbo_attrib_tmp.h b/src/mesa/vbo/vbo_attrib_tmp.h
index e73b8fb..ed0b2de 100644
--- a/src/mesa/vbo/vbo_attrib_tmp.h
+++ b/src/mesa/vbo/vbo_attrib_tmp.h
@@ -226,7 +226,7 @@ static inline float conv_i2_to_norm_float(const struct 
gl_context *ctx, int i2)
} while(0)
 
 #define ATTR_UI_INDEX(ctx, val, type, normalized, index, arg) do { \
-  if ((index) == 0) {  \
+  if ((index) == 0 && _mesa_attr_zero_aliases_vertex(ctx)) {   \
 ATTR_UI(ctx, val, (type), normalized, 0, (arg));   \
   } else if ((index) < MAX_VERTEX_GENERIC_ATTRIBS) {   \
 ATTR_UI(ctx, val, (type), normalized, VBO_ATTRIB_GENERIC0 + (index), 
(arg)); \
-- 
2.5.5

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev