Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
If the extension is core only, we can rip out the checks, but the checks that test ctx-API == API_OPEGL_CORE should stay (if they are missing, they should be added). Marek On Thu, Jul 9, 2015 at 3:27 PM, Roland Scheidegger srol...@vmware.com wrote: Should expose that only if hw has glsl 130 support? Roland Am 09.07.2015 um 09:17 schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
On 21 July 2015 at 08:50, Marek Olšák mar...@gmail.com wrote: If the extension is core only, we can rip out the checks, but the checks that test ctx-API == API_OPEGL_CORE should stay (if they are missing, they should be added). I've reconsidered this, and I'm sticking with my original plan, NIR and the i965 driver will need some changes to support this, so I should really provide a way to turn it off. this is due to the subroutine type and the subroutine to int conversion function. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; -- 2.4.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
Should expose that only if hw has glsl 130 support? Roland Am 09.07.2015 um 09:17 schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
On Sun, 2015-05-31 at 20:41 -0700, Kenneth Graunke wrote: On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; I know people have talked about enabling it everywhere 1.30+ is available. That makes some sense. Here's an argument for keeping it optional: We don't want people using this extension, so there's no value - in fact, negative value - to exposing it unless we have to. Ignorant question, but why don't you want people using it? Drivers that can't do 4.0, such as Sandybridge, could avoid advertising it if we kept it optional. I'm happy to defer to majority opinion. signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
In that case, it should use the ARB_gpu_shader5 enable bit. Marek On Mon, Jun 1, 2015 at 5:41 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; I know people have talked about enabling it everywhere 1.30+ is available. That makes some sense. Here's an argument for keeping it optional: We don't want people using this extension, so there's no value - in fact, negative value - to exposing it unless we have to. Drivers that can't do 4.0, such as Sandybridge, could avoid advertising it if we kept it optional. I'm happy to defer to majority opinion. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
On Monday, June 01, 2015 11:35:03 AM Dave Airlie wrote: From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; I know people have talked about enabling it everywhere 1.30+ is available. That makes some sense. Here's an argument for keeping it optional: We don't want people using this extension, so there's no value - in fact, negative value - to exposing it unless we have to. Drivers that can't do 4.0, such as Sandybridge, could avoid advertising it if we kept it optional. I'm happy to defer to majority opinion. signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 19/19] st/mesa: enable shader subroutine
From: Dave Airlie airl...@redhat.com I'm not sure if we shouldn't enable this everywhere and rip out the API checks, discuss, Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index b1057f3..3b828fa 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -598,6 +598,7 @@ void st_init_extensions(struct pipe_screen *screen, extensions-ARB_half_float_vertex = GL_TRUE; extensions-ARB_internalformat_query = GL_TRUE; extensions-ARB_map_buffer_range = GL_TRUE; + extensions-ARB_shader_subroutine = GL_TRUE; extensions-ARB_texture_border_clamp = GL_TRUE; /* XXX temp */ extensions-ARB_texture_cube_map = GL_TRUE; extensions-ARB_texture_env_combine = GL_TRUE; -- 2.1.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
