Re: [Mingw-w64-public] Fwd: Re: [PATCH] Include driverspecs.h in specstrings.h.

[David Grayson]

Yeah, sorry, I only sent those patches to LH by mistake.  Yes, I purposely
used the same include guard name as Microsoft.

--David

On Wed, May 10, 2017 at 8:55 AM, Liu Hao  wrote:

>
>
>
>  Forwarded Message 
> Subject:Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in
> specstrings.h.
> Date:   Wed, 10 May 2017 08:24:25 -0700
> From:   David Grayson 
> To: Liu Hao 
>
>
>
> OK, thanks.  I've attached a new patch where the #include is after the
> __cplusplus stuff.
>
> I also included a second patch that will add an include guard for
> specstrings.h, since Microsoft seems to do that too.
>
> driverspecs.h is also missing an include guard but it is part of the React
> DDK so I didn't want to mess around with editing at the moment.
>
> --David
>
> On Tue, May 9, 2017 at 9:07 PM, Liu Hao > wrote:
>
> On 2017/5/10 10:34, David Grayson wrote:
>
> This patch adds "#include " near the end of
> specstrings.h,
> because the same is done in Microsoft's version of
> specstrings.h.  With
> this patch, I am able to build Microsoft's devcon utility without
> modification.  Thanks!
>
> You must `#include` that header AFTER the `#ifdef __cplusplus ...
> #endif` block.
>
> Anyway, this header seems short of a header guard. I shall ask
> someone for sure.
>
> -- Best regards,
> LH_Mouse
>
>
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] Fwd: Re: [PATCH] Include driverspecs.h in specstrings.h.

[Liu Hao]

 Forwarded Message 
Subject: 	Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in 
specstrings.h.

Date:   Wed, 10 May 2017 08:24:25 -0700
From:   David Grayson 
To: Liu Hao 



OK, thanks.  I've attached a new patch where the #include is after the 
__cplusplus stuff.


I also included a second patch that will add an include guard for 
specstrings.h, since Microsoft seems to do that too.


driverspecs.h is also missing an include guard but it is part of the 
React DDK so I didn't want to mess around with editing at the moment.


--David

On Tue, May 9, 2017 at 9:07 PM, Liu Hao > wrote:


On 2017/5/10 10:34, David Grayson wrote:

This patch adds "#include " near the end of
specstrings.h,
because the same is done in Microsoft's version of
specstrings.h.  With
this patch, I am able to build Microsoft's devcon utility without
modification.  Thanks!

You must `#include` that header AFTER the `#ifdef __cplusplus ...
#endif` block.

Anyway, this header seems short of a header guard. I shall ask
someone for sure.

-- Best regards,
LH_Mouse


From bb87ae14e5a381617d1969837efd0d9c3ddefa25 Mon Sep 17 00:00:00 2001
From: David Grayson 
Date: Tue, 9 May 2017 09:15:29 -0700
Subject: [PATCH 1/2] specstrings.h:  Include driverspecs.h near the bottom.

That's what the Microsoft header does, and their devcon utility
depends on it.
---
 mingw-w64-headers/include/specstrings.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mingw-w64-headers/include/specstrings.h 
b/mingw-w64-headers/include/specstrings.h
index 485b4330..984dd64b 100644
--- a/mingw-w64-headers/include/specstrings.h
+++ b/mingw-w64-headers/include/specstrings.h
@@ -328,3 +328,5 @@ extern "C" {
 #ifdef __cplusplus
 }
 #endif
+
+#include 
-- 
2.12.1

From 65c70e8cad7d6c234b00a4d3240a98cae49465e7 Mon Sep 17 00:00:00 2001
From: David Grayson 
Date: Wed, 10 May 2017 07:07:04 -0700
Subject: [PATCH 2/2] specstrings.h: Add an include guard.

---
 mingw-w64-headers/include/specstrings.h | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/mingw-w64-headers/include/specstrings.h 
b/mingw-w64-headers/include/specstrings.h
index 984dd64b..bcb9fc3c 100644
--- a/mingw-w64-headers/include/specstrings.h
+++ b/mingw-w64-headers/include/specstrings.h
@@ -3,6 +3,10 @@
  * This file is part of the mingw-w64 runtime package.
  * No warranty is given; refer to the file DISCLAIMER.PD within this package.
  */
+
+#ifndef SPECSTRINGS_H
+#define SPECSTRINGS_H
+
 #define __specstrings
 
 #include 
@@ -330,3 +334,5 @@ extern "C" {
 #endif
 
 #include 
+
+#endif
-- 
2.12.1

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Include driverspecs.h in specstrings.h.

[Liu Hao]

On 2017/5/10 23:24, David Grayson wrote:
> OK, thanks.  I've attached a new patch where the #include is after the 
> __cplusplus stuff.
> 
> I also included a second patch that will add an include guard for 
> specstrings.h, since Microsoft seems to do that too.
> 
> driverspecs.h is also missing an include guard but it is part of the 
> React DDK so I didn't want to mess around with editing at the moment.
> I pushed both patches to master.

The name for the include guard macro used by this file is the same as 
that used by Microsoft so I think it should be safe.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public