Re: issues configuring vlan on top of aggr device

[David Gwynne]

On Tue, Dec 03, 2019 at 02:11:16PM +, Pedro Caetano wrote:
> Hi again,
> 
> I'm sorry, but since the boxes do not (yet) have working networking it is
> not easy for me to get the text output.
> I'm attaching a few pictures with the requested output.
> 
> https://picpaste.me/images/2019/12/03/cat_hostname.vl3800_hostname.aggr0.jpg
> https://picpaste.me/images/2019/12/03/ifconfig_vl3800.jpg
> https://picpaste.me/images/2019/12/03/ifconfig_aggr0.jpg
> 
> 
> Best regards,
> Pedro Caetano
> 
> On Tue, Dec 3, 2019 at 12:35 PM Hrvoje Popovski  wrote:
> 
> > On 3.12.2019. 13:15, Pedro Caetano wrote:
> > > Hi Hrvoje, thank you for the fast reply,
> > >
> > > Unfortunately I have the same behavior.
> > > The aggr0 works as expected, as I can see the links bonded on the switch.
> > > I'm able to se the correct vid s, when tcpdump'ing the aggr0 interface.
> > >
> > > I'd appreciate any help on this topic.
> > >
> >
> > can you send ifconfig aggr0 and ifconfig vlan3800 ?
> >
> >
> >
> >
> > > This configuration is working on -current with em(4) nics.
> > >
> > >
> > > Best regards,
> > > Pedro Caetano
> > >
> > > A ter??a, 3/12/2019, 12:01, Hrvoje Popovski  > > > escreveu:
> > >
> > > On 3.12.2019. 12:21, Pedro Caetano wrote:
> > > > Hi misc@
> > > >
> > > > I'm running openbsd 6.6 with latest patches running on a pair of
> > > hp dl 360
> > > > gen6 servers.
> > > >
> > > > I'm attempting to configure an aggr0 device towards a cat 3650.
> > > >
> > > > The aggr0 associates successfully with the switch, but I'm unable
> > > to run
> > > > vlans on top of it.
> > > >
> > > > The configuration on openbsd is the following:
> > > > #ifconfig aggr0 create
> > > > #ifconfig aggr0 trunkport bnx0
> > > > #ifconfig aggr0 trunkport bnx1
> > >
> > > add this - ifconfig aggr0 up
> > > if you have hostname.aggr0 add "up" at the end of that file ...
> > >
> > > > #ifconfig vlan3800 create
> > > > #ifconfig vlan3800 vnetid 3800
> > > > #ifconfig vlan3800 parent aggr0
> > > > #ifconfig vlan3800 10.80.253.10/24 
> > > > ifconfig: SIOCAIFADDR: No buffer space available.

hey,

hrvoje gave me a heads up about this, and i came up with some diffs that
which seem to help according to his testing.

the most useful for you using aggr is this diff for bnx which enables
the use of jumbos. it's pretty mechanical, except that it stops
advertising the VLAN_MTU capability. instead it advertises what the
actual hardmtu is, which allows the extra 4 bytes to be used by any
protocol, not just vlan(4).

aggr(4) does not (currently) pass the VLAN_MTU capability from it's
ports through for vlan(4) to use, but passing the larger hardmtu through
has the same effect.

unless anyone objects, im going to commit this tomorrow.

fyi, ifconfig foo0 hwfeatures is how you see the capabilities and
hardmtu settings.

Index: if_bnx.c
===
RCS file: /cvs/src/sys/dev/pci/if_bnx.c,v
retrieving revision 1.125
diff -u -p -r1.125 if_bnx.c
--- if_bnx.c10 Mar 2018 10:51:46 -  1.125
+++ if_bnx.c5 Dec 2019 09:52:04 -
@@ -875,12 +875,13 @@ bnx_attachhook(struct device *self)
ifp->if_ioctl = bnx_ioctl;
ifp->if_qstart = bnx_start;
ifp->if_watchdog = bnx_watchdog;
+   ifp->if_hardmtu = BNX_MAX_JUMBO_ETHER_MTU_VLAN -
+   sizeof(struct ether_header);
IFQ_SET_MAXLEN(>if_snd, USABLE_TX_BD - 1);
bcopy(sc->eaddr, sc->arpcom.ac_enaddr, ETHER_ADDR_LEN);
bcopy(sc->bnx_dev.dv_xname, ifp->if_xname, IFNAMSIZ);
 
-   ifp->if_capabilities = IFCAP_VLAN_MTU | IFCAP_CSUM_TCPv4 |
-   IFCAP_CSUM_UDPv4;
+   ifp->if_capabilities = IFCAP_CSUM_TCPv4 | IFCAP_CSUM_UDPv4;
 
 #if NVLAN > 0
ifp->if_capabilities |= IFCAP_VLAN_HWTAGGING;
@@ -2417,7 +2418,7 @@ bnx_dma_alloc(struct bnx_softc *sc)
 */
for (i = 0; i < TOTAL_TX_BD; i++) {
if (bus_dmamap_create(sc->bnx_dmatag,
-   MCLBYTES * BNX_MAX_SEGMENTS, BNX_MAX_SEGMENTS,
+   BNX_MAX_JUMBO_ETHER_MTU_VLAN, BNX_MAX_SEGMENTS,
MCLBYTES, 0, BUS_DMA_NOWAIT, >tx_mbuf_map[i])) {
printf(": Could not create Tx mbuf %d DMA map!\n", 1);
rc = ENOMEM;
@@ -2650,8 +2651,8 @@ bnx_dma_alloc(struct bnx_softc *sc)
 * Create DMA maps for the Rx buffer mbufs.
 */
for (i = 0; i < TOTAL_RX_BD; i++) {
-   if (bus_dmamap_create(sc->bnx_dmatag, BNX_MAX_MRU,
-   BNX_MAX_SEGMENTS, BNX_MAX_MRU, 0, BUS_DMA_NOWAIT,
+   if (bus_dmamap_create(sc->bnx_dmatag, BNX_MAX_JUMBO_MRU,
+   1, BNX_MAX_JUMBO_MRU, 0, BUS_DMA_NOWAIT,
>rx_mbuf_map[i])) {
printf(": Could not create Rx mbuf %d DMA map!\n", i);
rc = ENOMEM;
@@ 

Re: issues configuring vlan on top of aggr device

[Hrvoje Popovski]

On 3.12.2019. 15:11, Pedro Caetano wrote:
> Hi again,
> 
> I'm sorry, but since the boxes do not (yet) have working networking it
> is not easy for me to get the text output.
> I'm attaching a few pictures with the requested output.
> 
> https://picpaste.me/images/2019/12/03/cat_hostname.vl3800_hostname.aggr0.jpg
> https://picpaste.me/images/2019/12/03/ifconfig_vl3800.jpg

you should have ip address on vlan3800 interface, right?

> https://picpaste.me/images/2019/12/03/ifconfig_aggr0.jpg

Re: issues configuring vlan on top of aggr device

[Pedro Caetano]

Hi again,

I'm sorry, but since the boxes do not (yet) have working networking it is
not easy for me to get the text output.
I'm attaching a few pictures with the requested output.

https://picpaste.me/images/2019/12/03/cat_hostname.vl3800_hostname.aggr0.jpg
https://picpaste.me/images/2019/12/03/ifconfig_vl3800.jpg
https://picpaste.me/images/2019/12/03/ifconfig_aggr0.jpg


Best regards,
Pedro Caetano

On Tue, Dec 3, 2019 at 12:35 PM Hrvoje Popovski  wrote:

> On 3.12.2019. 13:15, Pedro Caetano wrote:
> > Hi Hrvoje, thank you for the fast reply,
> >
> > Unfortunately I have the same behavior.
> > The aggr0 works as expected, as I can see the links bonded on the switch.
> > I'm able to se the correct vid s, when tcpdump'ing the aggr0 interface.
> >
> > I'd appreciate any help on this topic.
> >
>
> can you send ifconfig aggr0 and ifconfig vlan3800 ?
>
>
>
>
> > This configuration is working on -current with em(4) nics.
> >
> >
> > Best regards,
> > Pedro Caetano
> >
> > A terça, 3/12/2019, 12:01, Hrvoje Popovski  > > escreveu:
> >
> > On 3.12.2019. 12:21, Pedro Caetano wrote:
> > > Hi misc@
> > >
> > > I'm running openbsd 6.6 with latest patches running on a pair of
> > hp dl 360
> > > gen6 servers.
> > >
> > > I'm attempting to configure an aggr0 device towards a cat 3650.
> > >
> > > The aggr0 associates successfully with the switch, but I'm unable
> > to run
> > > vlans on top of it.
> > >
> > > The configuration on openbsd is the following:
> > > #ifconfig aggr0 create
> > > #ifconfig aggr0 trunkport bnx0
> > > #ifconfig aggr0 trunkport bnx1
> >
> > add this - ifconfig aggr0 up
> > if you have hostname.aggr0 add "up" at the end of that file ...
> >
> > > #ifconfig vlan3800 create
> > > #ifconfig vlan3800 vnetid 3800
> > > #ifconfig vlan3800 parent aggr0
> > > #ifconfig vlan3800 10.80.253.10/24 
> > > ifconfig: SIOCAIFADDR: No buffer space available.
> >
>
>

Re: issues configuring vlan on top of aggr device

[Hrvoje Popovski]

On 3.12.2019. 13:15, Pedro Caetano wrote:
> Hi Hrvoje, thank you for the fast reply,
> 
> Unfortunately I have the same behavior.
> The aggr0 works as expected, as I can see the links bonded on the switch.
> I'm able to se the correct vid s, when tcpdump'ing the aggr0 interface.
> 
> I'd appreciate any help on this topic.
> 

can you send ifconfig aggr0 and ifconfig vlan3800 ?




> This configuration is working on -current with em(4) nics.
> 
> 
> Best regards,
> Pedro Caetano
> 
> A terça, 3/12/2019, 12:01, Hrvoje Popovski  > escreveu:
> 
> On 3.12.2019. 12:21, Pedro Caetano wrote:
> > Hi misc@
> >
> > I'm running openbsd 6.6 with latest patches running on a pair of
> hp dl 360
> > gen6 servers.
> >
> > I'm attempting to configure an aggr0 device towards a cat 3650.
> >
> > The aggr0 associates successfully with the switch, but I'm unable
> to run
> > vlans on top of it.
> >
> > The configuration on openbsd is the following:
> > #ifconfig aggr0 create
> > #ifconfig aggr0 trunkport bnx0
> > #ifconfig aggr0 trunkport bnx1
> 
> add this - ifconfig aggr0 up
> if you have hostname.aggr0 add "up" at the end of that file ...
> 
> > #ifconfig vlan3800 create
> > #ifconfig vlan3800 vnetid 3800
> > #ifconfig vlan3800 parent aggr0
> > #ifconfig vlan3800 10.80.253.10/24 
> > ifconfig: SIOCAIFADDR: No buffer space available.
> 

Re: issues configuring vlan on top of aggr device

[Pedro Caetano]

Hi Hrvoje, thank you for the fast reply,

Unfortunately I have the same behavior.
The aggr0 works as expected, as I can see the links bonded on the switch.
I'm able to se the correct vid s, when tcpdump'ing the aggr0 interface.

I'd appreciate any help on this topic.

This configuration is working on -current with em(4) nics.


Best regards,
Pedro Caetano

A terça, 3/12/2019, 12:01, Hrvoje Popovski  escreveu:

> On 3.12.2019. 12:21, Pedro Caetano wrote:
> > Hi misc@
> >
> > I'm running openbsd 6.6 with latest patches running on a pair of hp dl
> 360
> > gen6 servers.
> >
> > I'm attempting to configure an aggr0 device towards a cat 3650.
> >
> > The aggr0 associates successfully with the switch, but I'm unable to run
> > vlans on top of it.
> >
> > The configuration on openbsd is the following:
> > #ifconfig aggr0 create
> > #ifconfig aggr0 trunkport bnx0
> > #ifconfig aggr0 trunkport bnx1
>
> add this - ifconfig aggr0 up
> if you have hostname.aggr0 add "up" at the end of that file ...
>
> > #ifconfig vlan3800 create
> > #ifconfig vlan3800 vnetid 3800
> > #ifconfig vlan3800 parent aggr0
> > #ifconfig vlan3800 10.80.253.10/24
> > ifconfig: SIOCAIFADDR: No buffer space available.
>
>

Re: issues configuring vlan on top of aggr device

[Hrvoje Popovski]

On 3.12.2019. 12:21, Pedro Caetano wrote:
> Hi misc@
> 
> I'm running openbsd 6.6 with latest patches running on a pair of hp dl 360
> gen6 servers.
> 
> I'm attempting to configure an aggr0 device towards a cat 3650.
> 
> The aggr0 associates successfully with the switch, but I'm unable to run
> vlans on top of it.
> 
> The configuration on openbsd is the following:
> #ifconfig aggr0 create
> #ifconfig aggr0 trunkport bnx0
> #ifconfig aggr0 trunkport bnx1

add this - ifconfig aggr0 up
if you have hostname.aggr0 add "up" at the end of that file ...

> #ifconfig vlan3800 create
> #ifconfig vlan3800 vnetid 3800
> #ifconfig vlan3800 parent aggr0
> #ifconfig vlan3800 10.80.253.10/24
> ifconfig: SIOCAIFADDR: No buffer space available.