Re: [PATCH](or feature-request) build both systemd and ck versions
Hi Luke, could you please look at the following bug report, subscribe to Cc and comment? https://bugzilla.gnome.org/show_bug.cgi?id=686997 Thank you in advance, Pavel - Original Message - From: Luke T. Shumaker luke...@sbcglobal.net To: Pavel Simerda psime...@redhat.com Cc: Luke T. Shumaker luke...@sbcglobal.net, networkmanager-list@gnome.org Sent: Thursday, October 18, 2012 10:52:56 PM Subject: Re: [PATCH](or feature-request) build both systemd and ck versions At Thu, 18 Oct 2012 05:19:57 -0400 (EDT), Pavel Simerda wrote: In my opinion, you should have just one binary. It is easy to detect systemd at runtime, as it requires cgroups and creates one. Symlink management is an overkill here. CK should be likewise very easy to detect. In absence of both, NetworkManager should still work. For the most part, I agree with you. I think the best argument against a single binary is that currently for systemd support it must be linked against `libsystemd-login`, which a non-systemd user might not have. But really, that is a long-term change, I am advocating producing both versions as they currently exist. What this patch does is the same thing as if I built it twice with different configure flags; there is no modification to NetworkManager itself, just the build system. ~ Luke Shumaker ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
Pavel Simerda wrote: In my opinion, you should have just one binary. It is easy to detect systemd at runtime, as it requires cgroups and creates one. Symlink management is an overkill here. CK should be likewise very easy to detect. In absence of both, NetworkManager should still work. For the most part, I agree with you. I think the best argument against a single binary is that currently for systemd support it must be linked against `libsystemd-login`, which a non-systemd user might not have. This is not an argument against a single binary at all. If you don't have the dependency, just don't build in the systemd part. You can even end up with a binary that supports neither of them, if applicable. But really, that is a long-term change, I am advocating producing both versions as they currently exist. What this patch does is the same thing as if I built it twice with different configure flags; there is no modification to NetworkManager itself, just the build system. Yes, and I believe this sort of modification to the build system is unwelcome and the product of it (the two binaries) likewise. Pavel ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
In my opinion, you should have just one binary. It is easy to detect systemd at runtime, as it requires cgroups and creates one. Symlink management is an overkill here. CK should be likewise very easy to detect. In absence of both, NetworkManager should still work. Pavel - Original Message - From: Luke T. Shumaker luke...@sbcglobal.net To: networkmanager-list@gnome.org Sent: Wednesday, October 17, 2012 9:04:29 PM Subject: Re: [PATCH](or feature-request) build both systemd and ck versions At Wed, 17 Oct 2012 15:02:09 -0400, Luke T. Shumaker wrote: The attached patch ... And I forgot to attache the patch, sorry! ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
At Thu, 18 Oct 2012 05:19:57 -0400 (EDT), Pavel Simerda wrote: In my opinion, you should have just one binary. It is easy to detect systemd at runtime, as it requires cgroups and creates one. Symlink management is an overkill here. CK should be likewise very easy to detect. In absence of both, NetworkManager should still work. For the most part, I agree with you. I think the best argument against a single binary is that currently for systemd support it must be linked against `libsystemd-login`, which a non-systemd user might not have. But really, that is a long-term change, I am advocating producing both versions as they currently exist. What this patch does is the same thing as if I built it twice with different configure flags; there is no modification to NetworkManager itself, just the build system. ~ Luke Shumaker ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
On Wed, 2012-10-17 at 15:02 -0400, Luke T.Shumaker wrote: I propose that the build system should generage both `NetworkManager-ck' and `NetworkManager-systemd' binaries and symlink `NetworkManager' to one of them. This way a distro that supports both sysvinit and systemd (such as Arch) can easily offer both. In the case of Arch, the correct version can be decided by symlinking `NetworkManager'-`NetworkManager-ck' (for compatability) and modifying the systemd `NetworkManager.service' file to run `NetworkManager-systemd' instead of just `NetworkManager'. You could just have two separate binary packages that conflict. So anyways in GNOME, we do the same compile-time flag. Changing it to be fully dynamic like this in the large scale would be really insane. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
On Thu, 2012-10-18 at 05:19 -0400, Pavel Simerda wrote: In my opinion, you should have just one binary. It is easy to detect systemd at runtime, as it requires cgroups and creates one. There is sd_booted() as public API for that. For what NetworkManager is doing, runtime detection may indeed be simple enough. ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH](or feature-request) build both systemd and ck versions
At Wed, 17 Oct 2012 15:02:09 -0400, Luke T. Shumaker wrote: The attached patch ... And I forgot to attache the patch, sorry! all-sessions.patch Description: Binary data ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
