date:20210311

[GitHub] [apisix] spacewander commented on a change in pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox



spacewander commented on a change in pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#discussion_r592967287



##
File path: docs/zh/latest/admin-api.md
##
@@ -23,7 +23,7 @@ title: Admin API
 
 ## 目录
 
-- [目录](#目录)
+- [目录](#%e7%9b%ae%e5%bd%95)

Review comment:
   Please keep the original name

##
File path: docs/en/latest/admin-api.md
##
@@ -547,11 +547,11 @@ In addition to the basic complex equalization algorithm 
selection, APISIX's Upst
 `hash_on` can be set to different types:
 
 1. when it is `vars`, the `key` is required. The `key` can be any [Nginx 
builtin variables](http://nginx.org/en/docs/varindex.html), without the prefix 
'$'.
-1. when it is `header`, the `key` is required. It is equal to "http_`key`".
-1. when it is `cookie`, the `key` is required. It is equal to "cookie_`key`".
-1. when it is `consumer`, the `key` is optional. The key is the 
`consumer_name` set by authentication plugin.
-1. when it is `vars_combinations`, the `key` is required. The `key` can be any 
[Nginx builtin variables](http://nginx.org/en/docs/varindex.html) combinations, 
such as `$request_uri$remote_addr`.
-1. If there is no value for either `hash_on` or `key`, `remote_addr` will be 
used as key.
+2. when it is `header`, the `key` is required. It is equal to "http_`key`".

Review comment:
   We don't need to change this. Markdown will handle the order 
automatically. There is no need to maintain the order by us.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #3816: test: make node/priority-balancer/sanity.t stable

2021-03-11 Thread GitBox



spacewander opened a new pull request #3816:
URL: https://github.com/apache/apisix/pull/3816


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox



tzssangglass commented on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-797297250


   > Hi @tzssangglass are you still working on this  I could take care of it 
if you do not got enough time
   
   okay, I haven't had enough time lately, so leave it to you.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.

2021-03-11 Thread GitBox



nic-chen commented on issue #1482:
URL: 
https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-797294000


   @bisakhmondal  
   Thanks !
   I think you could try to submit a proposal for this change  : )
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #3814: docs: use the build script which is more up-to-date.

2021-03-11 Thread GitBox



spacewander merged pull request #3814:
URL: https://github.com/apache/apisix/pull/3814


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: docs: use the build script which is more up-to-date. (#3814)

2021-03-11 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 038acfc  docs: use the build script which is more up-to-date. (#3814)
038acfc is described below

commit 038acfcc9b5e93732f71ad0e5148eb389e8284be
Author: 罗泽轩 
AuthorDate: Fri Mar 12 15:26:15 2021 +0800

docs: use the build script which is more up-to-date. (#3814)
---
 docs/en/latest/how-to-build.md| 6 ++
 docs/en/latest/plugins/dubbo-proxy.md | 2 +-
 docs/zh/latest/how-to-build.md| 6 ++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/docs/en/latest/how-to-build.md b/docs/en/latest/how-to-build.md
index 885f20d..81fa6f8 100644
--- a/docs/en/latest/how-to-build.md
+++ b/docs/en/latest/how-to-build.md
@@ -171,3 +171,9 @@ Content-Type: text/html
 ... ...
 {"node":{...},"action":"get"}
 ```
+
+## 6. Build OpenResty for APISIX
+
+Some features require you to build OpenResty with extra Nginx modules.
+If you need those features, you can build OpenResty with
+[this build 
script](https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-openresty.sh).
diff --git a/docs/en/latest/plugins/dubbo-proxy.md 
b/docs/en/latest/plugins/dubbo-proxy.md
index 82ab574..59586b8 100644
--- a/docs/en/latest/plugins/dubbo-proxy.md
+++ b/docs/en/latest/plugins/dubbo-proxy.md
@@ -37,7 +37,7 @@ dubbo-proxy plugin allows you proxy HTTP request to 
[**dubbo**](http://dubbo.apa
 
 ## Requirement
 
-If you are using OpenResty, you need to build it with dubbo support, see [How 
to build](https://github.com/api7/mod_dubbo#how-to-build).
+If you are using OpenResty, you need to build it with dubbo support, see [how 
to build](../how-to-build.md#6-build-openresty-for-apisix)
 
 To make http2dubbo work in APISIX, we enhance the dubbo module based on 
Tengine's `mod_dubbo`. The modifications are contributed back to Tengine, but 
they are not included in the latest release version (Tengine-2.3.2) yet. So 
Tengine itself is unsupported.
 
diff --git a/docs/zh/latest/how-to-build.md b/docs/zh/latest/how-to-build.md
index 2b1705f..6735494 100644
--- a/docs/zh/latest/how-to-build.md
+++ b/docs/zh/latest/how-to-build.md
@@ -166,3 +166,9 @@ Content-Type: text/html
 ... ...
 {"node":{...},"action":"get"}
 ```
+
+## 6. 为 APISIX 构建 OpenResty
+
+有些功能需要你引入额外的 Nginx 模块到 OpenResty 当中。
+如果你需要这些功能，你可以用[这个脚本](https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-openresty.sh)
+构建 OpenResty。

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



nic-chen commented on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-797291310


   Thanks! @Jaycean 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen merged pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



nic-chen merged pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo (#1570)

2021-03-11 Thread chenjunxu

This is an automated email from the ASF dual-hosted git repository.

chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 48e66cd  feat: rewrite e2e 
test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo (#1570)
48e66cd is described below

commit 48e66cded1f4f7b67d37a9f1337fca492d6f44f5
Author: JinChen 
AuthorDate: Fri Mar 12 15:21:55 2021 +0800

feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) 
with ginkgo (#1570)
---
 api/test/e2e/route_with_script_luacode_test.go | 355 -
 .../e2enew/route/route_with_script_luacode_test.go | 337 +++
 2 files changed, 337 insertions(+), 355 deletions(-)

diff --git a/api/test/e2e/route_with_script_luacode_test.go 
b/api/test/e2e/route_with_script_luacode_test.go
deleted file mode 100644
index 55685ce..000
--- a/api/test/e2e/route_with_script_luacode_test.go
+++ /dev/null
@@ -1,355 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
-   "net/http"
-   "testing"
-   "time"
-
-   "github.com/stretchr/testify/assert"
-)
-
-func TestRoute_with_script_lucacode(t *testing.T) {
-
-   // clean error log
-   CleanAPISIXErrorLog(t)
-
-   tests := []HttpTestCase{
-   {
-   Desc:   "create route with script of valid lua code",
-   Object: ManagerApiExpect(t),
-   Method: http.MethodPut,
-   Path:   "/apisix/admin/routes/r1",
-   Body: `{
-   "uri": "/hello",
-   "upstream": {
-   "type": "roundrobin",
-   "nodes": [{
-   "host": "172.16.238.20",
-   "port": 1980,
-   "weight": 1
-   }]
-   },
-   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
-   }`,
-   Headers:  map[string]string{"Authorization": token},
-   ExpectStatus: http.StatusOK,
-   },
-   {
-   Desc: "get the route",
-   Object:   ManagerApiExpect(t),
-   Method:   http.MethodGet,
-   Path: "/apisix/admin/routes/r1",
-   Headers:  map[string]string{"Authorization": token},
-   ExpectStatus: http.StatusOK,
-   ExpectBody:   "hit access phase",
-   Sleep:sleepTime,
-   },
-   {
-   Desc: "hit the route",
-   Object:   APISIXExpect(t),
-   Method:   http.MethodGet,
-   Path: "/hello",
-   Headers:  map[string]string{"Authorization": token},
-   ExpectStatus: http.StatusOK,
-   ExpectBody:   "hello world\n",
-   },
-   {
-   Desc:   "update route with script of valid lua code",
-   Object: ManagerApiExpect(t),
-   Method: http.MethodPut,
-   Path:   "/apisix/admin/routes/r1",
-   Body: `{
-   "uri": "/hello",
-   "upstream": {
-   "type": "roundrobin",
-   "nodes": [{
-   "host": "172.16.238.20",
-   "port": 1981,
-

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox



Firstsawyou commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-797288180


   Hi, @jbampton  
   A new version of `api7/jsonschema` has been released, you can now try to 
update the following two parts of the code:
   
   ```shell
   diff --git a/rockspec/apisix-master-0.rockspec 
b/rockspec/apisix-master-0.rockspec
   index 1806b7c..37f911f 100644
   --- a/rockspec/apisix-master-0.rockspec
   +++ b/rockspec/apisix-master-0.rockspec
   @@ -50,7 +50,7 @@ dependencies = {
"luafilesystem = 1.7.0-2",
"lua-tinyyaml = 1.0",
"nginx-lua-prometheus = 0.20201218",
   -"jsonschema = 0.9.3",
   +"jsonschema = 0.9.4",
"lua-resty-ipmatcher = 0.6",
"lua-resty-kafka = 0.07",
"lua-resty-logger-socket = 2.0-0",
   diff --git a/t/plugin/echo.t b/t/plugin/echo.t
   index e45fa89..97103a4 100644
   --- a/t/plugin/echo.t
   +++ b/t/plugin/echo.t
   @@ -269,7 +269,7 @@ Location: https://www.iresty.com
"plugins": {
   "echo": {
"before_body": "before the body 
modification ",
   - "auth_value" : "userpasswrd",
   + "auth_value" : "userpassword",
"headers": {
"Location":"https://www.iresty.com;
}
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox



membphis commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-797280721


   > The PR has been 
submitted：[api7/jsonschema#57](https://github.com/api7/jsonschema/pull/57)
   
   merged and released new version, please take a look:
   
   
![image](https://user-images.githubusercontent.com/6814606/110904122-6f66fd00-8343-11eb-8839-abfaa7baf6dd.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (00baca2 -> 20ee3c1)

2021-03-11 Thread membphis

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 00baca2  docs: added generated contributor over time service provider 
(#3813)
 add 20ee3c1  feat: add a safe exit to disable sync conf during start 
(#3812)

No new revisions were added by this update.

Summary of changes:
 apisix/core/config_etcd.lua | 14 +-
 conf/config-default.yaml|  1 +
 t/core/etcd-sync.t  | 19 ++-
 3 files changed, 28 insertions(+), 6 deletions(-)

[GitHub] [apisix] membphis merged pull request #3812: feat: add a safe exit to disable sync conf during start

2021-03-11 Thread GitBox



membphis merged pull request #3812:
URL: https://github.com/apache/apisix/pull/3812


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] gxthrj merged pull request #41: fix: unified subchart value name

2021-03-11 Thread GitBox



gxthrj merged pull request #41:
URL: https://github.com/apache/apisix-helm-chart/pull/41


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-helm-chart] branch master updated: fix: unified subchart value name (#41)

2021-03-11 Thread kvn

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
 new 23b0216  fix: unified subchart value name (#41)
23b0216 is described below

commit 23b021670c9de75f30104d31d836b8f47486f40a
Author: Jun 
AuthorDate: Fri Mar 12 14:52:12 2021 +0800

fix: unified subchart value name (#41)
---
 charts/apisix/Chart.yaml  | 4 ++--
 charts/apisix/values.yaml | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml
index 3a17ab7..b23e109 100644
--- a/charts/apisix/Chart.yaml
+++ b/charts/apisix/Chart.yaml
@@ -31,7 +31,7 @@ type: application
 # This is the chart version. This version number should be incremented each 
time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.0
+version: 0.2.1
 
 # This is the version number of the application being deployed. This version 
number should be
 # incremented each time you make changes to the application. Versions are not 
expected to
@@ -51,5 +51,5 @@ dependencies:
   - name: apisix-ingress-controller
 version: 0.2.0
 repository: file://../apisix-ingress-controller
-condition: ingressController.enabled
+condition: ingress-controller.enabled
 alias: ingress-controller
diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml
index 3526a63..20af1ba 100644
--- a/charts/apisix/values.yaml
+++ b/charts/apisix/values.yaml
@@ -118,7 +118,7 @@ admin:
 dashboard:
   enabled: false
 
-ingressController:
+ingress-controller:
   enabled: false
 
 allow:

[GitHub] [apisix] juzhiyuan commented on pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox



juzhiyuan commented on pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273854


   ok



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox



moonming commented on pull request #3815:
URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273544


   @juzhiyuan please update the dashboard repo.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming opened a new pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox



moonming opened a new pull request #3815:
URL: https://github.com/apache/apisix/pull/3815


   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] qier222 commented on issue #259: invalid URLs in translation docs

2021-03-11 Thread GitBox



qier222 commented on issue #259:
URL: https://github.com/apache/apisix-website/issues/259#issuecomment-797272642


   My last PR only replace links referenced to a markdown file. eureka.lua is 
not an article, maybe we should place it inside the assets folder.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox



Junnplus commented on a change in pull request #296:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/296#discussion_r592941271



##
File path: pkg/ingress/controller/controller.go
##
@@ -137,7 +137,7 @@ func NewController(cfg *config.Config) (*Controller, error) 
{
if cfg.Kubernetes.IngressVersion == config.IngressNetworkingV1 {
ingressInformer = 
kube.CoreSharedInformerFactory.Networking().V1().Ingresses().Informer()
} else {
-   ingressInformer = 
kube.CoreSharedInformerFactory.Extensions().V1beta1().Ingresses().Informer()
+   ingressInformer = 
kube.CoreSharedInformerFactory.Networking().V1beta1().Ingresses().Informer()

Review comment:
   done.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox



gxthrj commented on pull request #275:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797270041


   > Not till now. I am having issues in understanding
   
   what is the problem?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox



iamayushdas commented on pull request #275:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797264551


   Not till now. I am having issues in understanding 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan opened a new issue #259: invalid URLs in translation docs

2021-03-11 Thread GitBox



juzhiyuan opened a new issue #259:
URL: https://github.com/apache/apisix-website/issues/259


   # Improve Docs
   
   ## Please describe which part of docs should be improved or typo fixed
   
   Hi, we have contributors who noticed that there have some broken links in 
translated docs:
   
   e.g.: https://apisix.apache.org/zh/docs/apisix/discovery/
   and this doc is targeted to 
https://github.com/apache/apisix/edit/master/docs/zh/latest/discovery.md
   
   
![image](https://user-images.githubusercontent.com/2106987/110486681-d4460b80-8127-11eb-96b6-15d9a32ad24b.png)
   
   ## Describe the solution you'd like
   
   Those broken links are due to our doc site doesn't support relative 
reference yet, for example:
   
   
![image](https://user-images.githubusercontent.com/2106987/110486810-f770bb00-8127-11eb-8c83-63ccf2a8ce0b.png)
   
   In this file, there have 2 links which are targeted the outside files. Here 
is the solution to fix this issue:
   
   For those referenced links, please use 
`https://github.com/apache/apisix/blob/master/docs/en/latest/{FILE_PATH}` 
instead, e.g: 
`https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on pull request #3794: docs: fixed invalid URLs in translation docs

2021-03-11 Thread GitBox



juzhiyuan commented on pull request #3794:
URL: https://github.com/apache/apisix/pull/3794#issuecomment-797263301


   https://github.com/apache/apisix-website/pull/257
   
   Hi, this PR fixes most issues, we could close this PR IMO.
   
   cc @iamayushdas Thanks for your watch and contribution!!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan closed pull request #3794: docs: fixed invalid URLs in translation docs

2021-03-11 Thread GitBox



juzhiyuan closed pull request #3794:
URL: https://github.com/apache/apisix/pull/3794


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on issue #3791: invalid URLs in translation docs

2021-03-11 Thread GitBox



juzhiyuan commented on issue #3791:
URL: https://github.com/apache/apisix/issues/3791#issuecomment-797262950


   Hi, @qier222 , after your last PR gets merged, most issues were resolved. I 
noticed that there has one `lua` file which is missing.
   
   
![image](https://user-images.githubusercontent.com/2106987/110900304-84d92880-833d-11eb-9c4e-0e391d4a083b.png)
   
   https://apisix.apache.org/zh/docs/apisix/discovery/



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] soulsoul commented on issue #294: architecture diagram

2021-03-11 Thread GitBox



soulsoul commented on issue #294:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/294#issuecomment-797262437


nice！



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #283: docs: update deployments repository url

2021-03-11 Thread GitBox



gxthrj commented on pull request #283:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-797261594


   Any update? @stu01509 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox



gxthrj commented on pull request #275:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797261233


   Any update? @iamayushdas 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox



gxthrj commented on a change in pull request #296:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/296#discussion_r592932371



##
File path: pkg/ingress/controller/controller.go
##
@@ -137,7 +137,7 @@ func NewController(cfg *config.Config) (*Controller, error) 
{
if cfg.Kubernetes.IngressVersion == config.IngressNetworkingV1 {
ingressInformer = 
kube.CoreSharedInformerFactory.Networking().V1().Ingresses().Informer()
} else {
-   ingressInformer = 
kube.CoreSharedInformerFactory.Extensions().V1beta1().Ingresses().Informer()
+   ingressInformer = 
kube.CoreSharedInformerFactory.Networking().V1beta1().Ingresses().Informer()

Review comment:
   Need to declare the minimum version of k8s supported by Ingress: 1.14 .
   Please update the README by the way.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu edited a comment on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox



Yiyiyimu edited a comment on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-797259563


   Hi @tzssangglass are you still working on this  I could take care of it if 
you do not got enough time



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox



Yiyiyimu commented on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-797259563


   Hi @tzssangglass are you still working on this  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox



Firstsawyou commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-797258954


   > > 2、[api7/jsonschema](https://github.com/api7/jsonschema) has not released 
a new version after `sctrictly` is fixed (`sctrictly` -> `strictly`). We need 
to release a new version of 
[api7/jsonschema](https://github.com/api7/jsonschema) to support `strictly`.
   > 
   > welcome to submit a pr, then I can release a new version
   
   The PR has been submitted：https://github.com/api7/jsonschema/pull/57



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox



gxthrj merged pull request #297:
URL: https://github.com/apache/apisix-ingress-controller/pull/297


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated (e2ddfad -> 8221ce6)

2021-03-11 Thread kvn

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.


from e2ddfad  fix: grammar typo (#291)
 add 8221ce6  chore: release 0.4.0 (#297)

No new revisions were added by this update.

Summary of changes:
 CHANGELOG.md | 17 +
 Makefile |  2 +-
 2 files changed, 18 insertions(+), 1 deletion(-)

[GitHub] [apisix-ingress-controller] debu99 commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox



debu99 commented on issue #136:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797246675


   Yes, I would like to use git/yaml to update routing info, like Kong dbless 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox



tokers commented on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797245654


   > > We should use `Networking().V1beta1().Ingress().Informer().
   > 
   > yep, I make a PR to fixed.
   > 
   > > Some users running versions < Kubernetes 1.14
   > 
   > In addition, After K8s 1.13 the API server automatically translate 
`extensions/v1beta1.Ingress` objects to `networking/v1beta1.Ingress` objects, 
we may need to be compatible with the previous version.
   
   Then I think we should support "extensions/v1beta1.Ingress", instead of 
"networking/v1beta1.Ingress".



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox



tokers commented on issue #136:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797244660


   @debu99 By using the term "standalone", what's your exact meaning? Does it 
mean do not rely on ETCD?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



codecov-io edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) 
Report
   > Merging 
[#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) 
(be0fd2b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/afa05e706e45d4867b3556524e240fef4b73ff06?el=desc)
 (afa05e7) will **decrease** coverage by `1.35%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1570  +/-   ##
   ==
   - Coverage   71.54%   70.18%   -1.36% 
   ==
 Files 132   46  -86 
 Lines5341 3019-2322 
 Branches  5840 -584 
   ==
   - Hits 3821 2119-1702 
   + Misses   1275  655 -620 
 Partials  245  245  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `60.74% <ø> (-0.07%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `46.27% <ø> (+1.85%)` | :arrow_up: |
   | backend-unit-test | `51.54% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-1.82%)` | :arrow_down: |
   | 
[...c/pages/Route/components/ResultView/ResultView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1Jlc3VsdFZpZXcvUmVzdWx0Vmlldy50c3g=)
 | | |
   | 
[.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz)
 | | |
   | 
[web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4)
 | | |
   | 
[web/src/pages/Service/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvUHJldmlldy50c3g=)
 | | |
   | 
[web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==)
 | | |
   | 
[web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==)
 | | |
   | 
[web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4)
 | | |
   | 
[web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=)
 | | |
   | 
[web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz)
 | | |
   | ... and [77 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer).
 Last update 
[afa05e7...be0fd2b](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox



codecov-io edited a comment on pull request #297:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/297#issuecomment-797239231


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=h1)
 Report
   > Merging 
[#297](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=desc)
 (317bbec) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4262138c0dc7d8bf1729639cb56c73ca1b0b1da3?el=desc)
 (4262138) will **increase** coverage by `47.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ##   master  #297   +/-   ##
   
   + Coverage   52.90%   100.00%   +47.09% 
   
 Files  33 1   -32 
 Lines2321 1 -2320 
   
   - Hits 1228 1 -1227 
   + Misses938 0  -938 
   + Partials  155 0  -155 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv)
 | | |
   | 
[pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==)
 | | |
   | 
[pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv)
 | | |
   | 
[pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv)
 | | |
   | 
[pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==)
 | | |
   | 
[pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3R5cGVzL2V2ZW50Lmdv)
 | | |
   | 
[cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | | |
   | 
[pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==)
 | | |
   | 
[pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==)
 | | |
   | 
[pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=)
 | | |
   | ... and [22 
more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=footer).
 Last update 
[4262138...317bbec](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



codecov-io edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) 
Report
   > Merging 
[#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) 
(be0fd2b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/afa05e706e45d4867b3556524e240fef4b73ff06?el=desc)
 (afa05e7) will **decrease** coverage by `5.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1570  +/-   ##
   ==
   - Coverage   71.54%   66.34%   -5.20% 
   ==
 Files 132   46  -86 
 Lines5341 3019-2322 
 Branches  5840 -584 
   ==
   - Hits 3821 2003-1818 
   + Misses   1275  768 -507 
   - Partials  245  248   +3 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `46.27% <ø> (+1.85%)` | :arrow_up: |
   | backend-unit-test | `51.54% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `77.14% <0.00%> (-8.58%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-1.82%)` | :arrow_down: |
   | ... and [86 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer).
 Last update 
[afa05e7...be0fd2b](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox



codecov-io commented on pull request #297:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/297#issuecomment-797239231


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=h1)
 Report
   > Merging 
[#297](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=desc)
 (1e96f8a) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4262138c0dc7d8bf1729639cb56c73ca1b0b1da3?el=desc)
 (4262138) will **increase** coverage by `47.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ##   master  #297   +/-   ##
   
   + Coverage   52.90%   100.00%   +47.09% 
   
 Files  33 1   -32 
 Lines2321 1 -2320 
   
   - Hits 1228 1 -1227 
   + Misses938 0  -938 
   + Partials  155 0  -155 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | | |
   | 
[pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==)
 | | |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | | |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==)
 | | |
   | 
[pkg/seven/state/route\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3JvdXRlX3dvcmtlci5nbw==)
 | | |
   | 
[pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==)
 | | |
   | 
[pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==)
 | | |
   | 
[pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==)
 | | |
   | 
[pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv)
 | | |
   | 
[pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=)
 | | |
   | ... and [22 
more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=footer).
 Last update 
[4262138...317bbec](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



Jaycean commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592913445



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



codecov-io edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) 
Report
   > Merging 
[#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) 
(be0fd2b) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/afa05e706e45d4867b3556524e240fef4b73ff06?el=desc)
 (afa05e7) will **decrease** coverage by `19.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1570   +/-   ##
   ===
   - Coverage   71.54%   51.54%   -20.00% 
   ===
 Files 132   37   -95 
 Lines5341 2555 -2786 
 Branches  5840  -584 
   ===
   - Hits 3821 1317 -2504 
   + Misses   1275 1057  -218 
   + Partials  245  181   -64 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.54% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [118 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer).
 Last update 
[afa05e7...be0fd2b](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please

[GitHub] [apisix-dashboard] starsz commented on issue #1265: use apisix-docker to manage Dockerfile

2021-03-11 Thread GitBox



starsz commented on issue #1265:
URL: 
https://github.com/apache/apisix-dashboard/issues/1265#issuecomment-797235989


   > > ref to 
[apache/apisix-docker#150](https://github.com/apache/apisix-docker/pull/150)
   > 
   > @gxthrj That is just adding dashboard in docker-compose example..
   
   Yes. @gxthrj Can you help to create a dockerfile in apisix-docker to manage 
the apisix-dashboard.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] starsz commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr

2021-03-11 Thread GitBox



starsz commented on issue #149:
URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-797235184


   Good. @pahud Can you create a PR for it? Thank you very much.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



starsz commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592910565



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[apisix-ingress-controller] branch v0.4.0 updated (1e96f8a -> 317bbec)

2021-03-11 Thread kvn

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a change to branch v0.4.0
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.


from 1e96f8a  chore: modify default version to 0.4.0
 add 317bbec  fix: lint

No new revisions were added by this update.

Summary of changes:
 CHANGELOG.md | 2 --
 1 file changed, 2 deletions(-)

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



starsz commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592909965



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox



gxthrj opened a new pull request #297:
URL: https://github.com/apache/apisix-ingress-controller/pull/297


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] tag 0.4.0 created (now 1e96f8a)

2021-03-11 Thread kvn

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a change to tag 0.4.0
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.


  at 1e96f8a  (commit)
No new revisions were added by this update.

[apisix-website] branch master updated: fix: update sync-docs.js (#257)

2021-03-11 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 15572f2  fix: update sync-docs.js (#257)
15572f2 is described below

commit 15572f27a06699315368d0959dc09b835fd115d1
Author: qier222 
AuthorDate: Fri Mar 12 12:27:51 2021 +0800

fix: update sync-docs.js (#257)
---
 sync-docs.js | 54 +++---
 1 file changed, 39 insertions(+), 15 deletions(-)

diff --git a/sync-docs.js b/sync-docs.js
index fc4c1d3..c8a127a 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -6,6 +6,8 @@ const fs = require("fs");
 // NOTE: disable "apisix-docker" "apisix-helm-chart" currently
 const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];
 
+const langs = ["en", "zh", "es"];
+
 const projectPaths = projects.map((project) => {
   return {
 project: project,
@@ -26,31 +28,53 @@ const isFileExisted = (path) => {
   }
 };
 
-const replaceMDImageUrl = (project, paths) => {
+const replaceMDElements = (project, path) => {
   const replace = require("replace-in-file");
-  const allMDFilePaths = paths.map((p) => `${p}/**/*.md`);
+  const allMDFilePaths = path.map((p) => `${p}/**/*.md`);
 
-  const options = {
+  // replace the image urls inside markdown files
+  const imageOptions = {
 files: allMDFilePaths,
 // NOTE: just replace the url begin with ../assets/images ,then can 
replace with absolute url path
 from: 
/(\.\.\/)+assets\/images\/[-A-Za-z0-9+&@#/%?=~_|!:,.;]+[-A-Za-z0-9+&@#/%=~_|]/g,
 to: (match) => {
-  const imgPath = match
-.replace("(", "")
-.replace(")", "")
-.replace("../", "")
-.replace("../", "")
-.replace("../", "")
-.replace("../", "");
+  const imgPath = match.replace(/\(|\)|\.\.\/*/g, "");
   const newUrl = 
`https://raw.githubusercontent.com/apache/${project}/master/docs/${imgPath}`;
-  console.log(`${project}: ${match} -> ${newUrl}`);
+  console.log(`${project}: ${match}  ${newUrl}`);
+  return newUrl;
+},
+  };
+
+  // replace the markdown urls inside markdown files
+  const markdownOptions = {
+files: allMDFilePaths,
+from: RegExp(
+  `\\[.*\\]\\((\\.\\.\\/)*(${langs.join("|")})\\/.*\\.md\\)`,
+  "g"
+),
+to: (match) => {
+  const markdownPath = match.replace(/\(|\)|\.\.\/*|\[.*\]|\.\//g, ""); // 
"en/latest/discovery/dns.md"
+  const lang = markdownPath.split("/")[0];
+  const urlPath = markdownPath.replace(
+RegExp(`(${langs.join("|")})\\/latest\\/|\\.md`, "g"),
+""
+  ); // "discovery/dns"
+  const projectNameWithoutPrefix =
+project === "apisix" ? "apisix" : project.replace("apisix-", "");
+  let newUrl = match.replace(
+/\]\(.*\)/g,
+`](https://apisix.apache.org${
+  lang !== "en" ? "/" + lang : ""
+}/docs/${projectNameWithoutPrefix}/${urlPath})`
+  );
+  console.log(`${project}: ${match}  ${newUrl}`);
   return newUrl;
 },
   };
 
   try {
-const results = replace.sync(options);
-console.log(`${project} - Replacement results:`, results);
+replace.sync(imageOptions);
+replace.sync(markdownOptions);
   } catch (error) {
 console.error(`${project} - Error occurred:`, error);
   }
@@ -95,9 +119,9 @@ const main = () => {
   .join(" & ") + " & wait";
   childProcess.execSync(gitCommand, { cwd: "./tmp" });
 
-  console.log("Replace image url inside MD files");
+  console.log("Replace elements inside MD files");
   projects.map((project) => {
-replaceMDImageUrl(project, [`./tmp/${project}/docs`]);
+replaceMDElements(project, [`./tmp/${project}/docs`]);
   });
 
   console.log("Copy docs");

[GitHub] [apisix-website] juzhiyuan merged pull request #257: fix: update sync-docs.js

2021-03-11 Thread GitBox



juzhiyuan merged pull request #257:
URL: https://github.com/apache/apisix-website/pull/257


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] gxthrj merged pull request #258: docs: add docs for ingress 0.4.0

2021-03-11 Thread GitBox



gxthrj merged pull request #258:
URL: https://github.com/apache/apisix-website/pull/258


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-website] branch master updated: docs: add docs for ingress 0.4.0 (#258)

2021-03-11 Thread kvn

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 0dfff69  docs: add docs for ingress 0.4.0 (#258)
0dfff69 is described below

commit 0dfff69d37302c3cc7697d8abe505e3ce30c5887
Author: kv 
AuthorDate: Fri Mar 12 12:21:45 2021 +0800

docs: add docs for ingress 0.4.0 (#258)

* docs: add docs for ingress 0.4.0

* docs: modify ingress downloads

* fix: lint
---
 website/docusaurus.config.js  |  4 ++--
 ...-release-apache-apisix-ingress-controller-0.4.0.md | 19 +++
 website/static/data/events.json   |  4 
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index 0c44c89..2133727 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -45,8 +45,8 @@ module.exports = {
 shape: "hexagon",
 color: "#2563EB",
 githubRepo: "apache/apisix-ingress-controller",
-version: "0.3.0",
-releaseDate: "2021-02-11",
+version: "0.4.0",
+releaseDate: "2021-03-12",
 firstDocPath: "/getting-started",
   },
 ],
diff --git 
a/website/events/2021-03-12-release-apache-apisix-ingress-controller-0.4.0.md 
b/website/events/2021-03-12-release-apache-apisix-ingress-controller-0.4.0.md
new file mode 100644
index 000..574ff52
--- /dev/null
+++ 
b/website/events/2021-03-12-release-apache-apisix-ingress-controller-0.4.0.md
@@ -0,0 +1,19 @@
+---
+title: Release Apache APISIX Ingress Controller 0.4.0
+---
+
+This release mainly improves the program robustness and adds some features.
+
+
+
+## Core
+
+- Support Kubernetes Ingress resources 
[#250](https://github.com/apache/apisix-ingress-controller/pull/250)
+- Support ApisixRoute v2alpha1 
[#262](https://github.com/apache/apisix-ingress-controller/pull/262)
+- Support healthchecks definition 
[#117](https://github.com/apache/apisix-ingress-controller/issues/117)
+- Support secret controller 
[#284](https://github.com/apache/apisix-ingress-controller/pull/284)
+- Project optimization 
[#92](https://github.com/apache/apisix-ingress-controller/issues/92)
+
+## Test
+
+- Add test cases for pkg/kube 
[#99](https://github.com/apache/apisix-ingress-controller/issues/99)
diff --git a/website/static/data/events.json b/website/static/data/events.json
index ef979d9..af9b5d9 100644
--- a/website/static/data/events.json
+++ b/website/static/data/events.json
@@ -1,5 +1,9 @@
 [
   {
+"title": "Release Apache APISIX Ingress Controller 0.4.0",
+"fileName": "2021-03-12-release-apache-apisix-ingress-controller-0.4.0"
+  },
+  {
 "title": "Release Apache APISIX 2.4",
 "fileName": "2021-03-05-release-apache-apisix-2.4"
   },

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



Jaycean commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592899777



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-website] gxthrj opened a new pull request #258: docs: add docs for ingress 0.4.0

2021-03-11 Thread GitBox



gxthrj opened a new pull request #258:
URL: https://github.com/apache/apisix-website/pull/258


   Fixes: #[Add issue number here]
   
   Changes:
   
   
   
   Screenshots of the change:
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



nic-chen commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592892360



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-dashboard] nic-chen commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds

2021-03-11 Thread GitBox



nic-chen commented on issue #1565:
URL: 
https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-797215540


   ping  @stu01509 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1265: use apisix-docker to manage Dockerfile

2021-03-11 Thread GitBox



nic-chen commented on issue #1265:
URL: 
https://github.com/apache/apisix-dashboard/issues/1265#issuecomment-797215376


   > ref to 
[apache/apisix-docker#150](https://github.com/apache/apisix-docker/pull/150)
   
   @gxthrj  That is just adding dashboard in docker-compose example..
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (83537ad -> 00baca2)

2021-03-11 Thread spacewander

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 83537ad  feat: load etcd configuration when apisix starts (#3799)
 add 00baca2  docs: added generated contributor over time service provider 
(#3813)

No new revisions were added by this update.

Summary of changes:
 README.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

[GitHub] [apisix] spacewander merged pull request #3813: docs: added generated contributor over time service provider

2021-03-11 Thread GitBox



spacewander merged pull request #3813:
URL: https://github.com/apache/apisix/pull/3813


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] yangxikun closed issue #3804: request help: How to log upstream.name in access log?

2021-03-11 Thread GitBox



yangxikun closed issue #3804:
URL: https://github.com/apache/apisix/issues/3804


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] yangxikun commented on issue #3804: request help: How to log upstream.name in access log?

2021-03-11 Thread GitBox



yangxikun commented on issue #3804:
URL: https://github.com/apache/apisix/issues/3804#issuecomment-797206001


   ok, thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox



codecov-io commented on pull request #296:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/296#issuecomment-797204573


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=h1)
 Report
   > Merging 
[#296](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=desc)
 (4a3657d) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/038a047de16d44d4ac06f15332aca7da17390da8?el=desc)
 (038a047) will **increase** coverage by `47.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ##   master  #296   +/-   ##
   
   + Coverage   52.21%   100.00%   +47.78% 
   
 Files  33 1   -32 
 Lines2321 1 -2320 
   
   - Hits 1212 1 -1211 
   + Misses952 0  -952 
   + Partials  157 0  -157 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv)
 | | |
   | 
[pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==)
 | | |
   | 
[pkg/seven/state/route\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3JvdXRlX3dvcmtlci5nbw==)
 | | |
   | 
[pkg/log/options.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2xvZy9vcHRpb25zLmdv)
 | | |
   | 
[pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=)
 | | |
   | 
[pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==)
 | | |
   | 
[pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==)
 | | |
   | 
[pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=)
 | | |
   | 
[pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==)
 | | |
   | 
[pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=)
 | | |
   | ... and [22 
more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=footer).
 Last update 
[038a047...4a3657d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



Jaycean commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592880742



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox



Jaycean commented on a change in pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592880742



##
File path: api/test/e2enew/route/route_with_script_luacode_test.go
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+   "net/http"
+   "time"
+
+   "github.com/onsi/ginkgo"
+   "github.com/onsi/ginkgo/extensions/table"
+   "github.com/stretchr/testify/assert"
+
+   "e2enew/base"
+)
+
+var _ = ginkgo.Describe("route with script lucacode", func() {
+   ginkgo.It("clean APISIX error log", func() {
+   base.CleanAPISIXErrorLog()
+   })
+   table.DescribeTable("test route with script lucacode",
+   func(tc base.HttpTestCase) {
+   base.RunTestCase(tc)
+   },
+   table.Entry("create route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1980": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("get the route", base.HttpTestCase{
+   Object:   base.ManagerApiExpect(),
+   Method:   http.MethodGet,
+   Path: "/apisix/admin/routes/r1",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hit access phase",
+   Sleep:base.SleepTime,
+   }),
+   table.Entry("hit the route", base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello",
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "hello world\n",
+   }),
+   table.Entry("update route with script of valid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+   "uri": "/hello",
+   "upstream": {
+   "type": "roundrobin",
+   "nodes": {
+   "` + 
base.UpstreamIp + `:1981": 1
+   }
+   },
+   "script": "local _M = {} \n function 
_M.access(api_ctx) \n ngx.log(ngx.WARN,\"hit access phase\") \n end \nreturn _M"
+   }`,
+   Headers:  map[string]string{"Authorization": 
base.GetToken()},
+   ExpectStatus: http.StatusOK,
+   }),
+   table.Entry("update route with script of invalid lua code", 
base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPut,
+   Path:   "/apisix/admin/routes/r1",
+   Body: `{
+

[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #41: fix: unified subchart value name

2021-03-11 Thread GitBox



Junnplus opened a new pull request #41:
URL: https://github.com/apache/apisix-helm-chart/pull/41


   before: 
   `helm install apisix apisix/apisix --set ingressController.enabled=true 
--set ingress-controller.replicaCount=2`
   
   after:
   `helm install apisix apisix/apisix --set ingress-controller.enabled=true 
--set ingress-controller.replicaCount=2`
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox



Junnplus edited a comment on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653


   > We should use `Networking().V1beta1().Ingress().Informer().
   
   yep, I make a PR to fixed.
   
   > Some users running versions < Kubernetes 1.14
   
   In addition, After K8s 1.13 the API server automatically translate 
`extensions/v1beta1.Ingress` objects to `networking/v1beta1.Ingress` objects, 
we may need to be compatible with the previous version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox



Junnplus edited a comment on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653


   > We should use `Networking().V1beta1().Ingress().Informer().
   
   yep, I make a PR to fixed.
   
   > Some users running versions < Kubernetes 1.14
   
   In addition, After K8s 1.13 the API server automatically translate 
`extensions/v1beta1.Ingress` objects to `networking/v1beta1.Ingress` objects, 
we may need to be compatible with it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] Junnplus commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox



Junnplus commented on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653


   > We should use `Networking().V1beta1().Ingress().Informer().
   
   ye, I make a PR to fixed.
   
   > Some users running versions < Kubernetes 1.14
   
   In addition, After K8s 1.13 the API server automatically translate 
`extensions/v1beta1.Ingress` objects to `networking/v1beta1.Ingress` objects, 
we may need to be compatible with it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] Junnplus opened a new pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox



Junnplus opened a new pull request #296:
URL: https://github.com/apache/apisix-ingress-controller/pull/296


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   ref https://github.com/apache/apisix-ingress-controller/issues/293
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch juzhiyuan-patch-1 updated (428ced9 -> 5be7ddc)

2021-03-11 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 428ced9  docs: added service provider
 add 5be7ddc  Update README.md

No new revisions were added by this update.

Summary of changes:
 README.md | 2 ++
 1 file changed, 2 insertions(+)

[GitHub] [apisix] spacewander opened a new pull request #3814: docs: use the build script which is more up-to-date.

2021-03-11 Thread GitBox



spacewander opened a new pull request #3814:
URL: https://github.com/apache/apisix/pull/3814


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan opened a new pull request #3813: docs: added service provider

2021-03-11 Thread GitBox



juzhiyuan opened a new pull request #3813:
URL: https://github.com/apache/apisix/pull/3813


   ### What this PR does / why we need it:
   
   added service provider
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] 01/01: docs: added service provider

2021-03-11 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git

commit 428ced9eb5692154fea9e08c8a142eb7735aff0c
Author: 琚致远 
AuthorDate: Fri Mar 12 10:11:01 2021 +0800

docs: added service provider
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 33b8d3f..8de3de3 100644
--- a/README.md
+++ b/README.md
@@ -297,7 +297,7 @@ Benchmark comparison test [details 
data](https://gist.github.com/membphis/137db9
 
 ### Contributor Over Time
 
-![contributor-over-time](docs/assets/images/contributor-over-time.png)
+[![contributor-over-time](docs/assets/images/contributor-over-time.png)](https://www.apiseven.com/contributor-graph)
 
 ## Videos And Articles

[apisix] branch juzhiyuan-patch-1 created (now 428ced9)

2021-03-11 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git.


  at 428ced9  docs: added service provider

This branch includes the following new commits:

 new 428ced9  docs: added service provider

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[GitHub] [apisix] spacewander opened a new pull request #3812: feat: add a safe exit to disable sync conf during start

2021-03-11 Thread GitBox



spacewander opened a new pull request #3812:
URL: https://github.com/apache/apisix/pull/3812


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox



membphis commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-797179334


   > 2、[api7/jsonschema](https://github.com/api7/jsonschema) has not released a 
new version after `sctrictly` is fixed (`sctrictly` -> `strictly`). We need to 
release a new version of [api7/jsonschema](https://github.com/api7/jsonschema) 
to support `strictly`.
   
   welcome to submit a pr, then I can release a new version



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1577: fix: fix fe ci failed

2021-03-11 Thread GitBox



juzhiyuan merged pull request #1577:
URL: https://github.com/apache/apisix-dashboard/pull/1577


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: fix fe ci failed (#1577)

2021-03-11 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new afa05e7  fix: fix fe ci failed (#1577)
afa05e7 is described below

commit afa05e706e45d4867b3556524e240fef4b73ff06
Author: JinChen 
AuthorDate: Fri Mar 12 09:51:49 2021 +0800

fix: fix fe ci failed (#1577)
---
 .../integration/pluginTemplate/create-plugin-template-with-route.spec.js | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js
 
b/web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js
index 67bd664..36a2f8e 100644
--- 
a/web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js
+++ 
b/web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js
@@ -41,6 +41,7 @@ context('Create PluginTemplate Binding To Route', () => {
 cy.contains('Next').click();
 cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
 cy.contains('Next').click();
+cy.contains('Custom').should('be.visible');
 cy.get(this.domSelector.customSelector).click();
 cy.contains(this.data.pluginTemplateName).click();

[GitHub] [apisix-docker] membphis commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr

2021-03-11 Thread GitBox



membphis commented on issue #149:
URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-797175798


   sorry for my late reply.
   
   I was hesitant before, but after looking at other projects such as Nginx, I 
think this method is good.
   
   
https://github.com/nginxinc/docker-nginx/blob/master/stable/alpine/Dockerfile#L110-L111
 
   
   agree +1
   
   let us do it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] debu99 commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox



debu99 commented on issue #136:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797167805


   I need standalone mode for apisix ingress controller, does it currently 
support?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-11 Thread GitBox



tzssangglass commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r592844344



##
File path: apisix/plugins/traffic-split.lua
##
@@ -309,7 +314,8 @@ function _M.access(conf, ctx)
 return
 end
 
-local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, 
weighted_upstreams)
+local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, 
weighted_upstreams,

Review comment:
   > So we can ensure either route_upstream_id or weighted_upstreams 
changes, the version will change.
   
   got!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox



tokers commented on issue #293:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797164418


   @Junnplus Seems we have a bug here:
   
![image](https://user-images.githubusercontent.com/10428333/110876941-7413bd00-8313-11eb-9a22-8139cea16f10.png)
   
   We should use `Networking().V1beta1().Ingress().Informer().
   
   Would you like to submit a PR to solve this? Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-11 Thread GitBox



spacewander commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r592841252



##
File path: apisix/plugins/traffic-split.lua
##
@@ -309,7 +314,8 @@ function _M.access(conf, ctx)
 return
 end
 
-local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, 
weighted_upstreams)
+local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, 
weighted_upstreams,

Review comment:
   The default key should ensure if the configuration of the route changes, 
it will change too. So we can ensure either route_upstream_id or 
weighted_upstreams changes, the version will change.
   
   The corruption of the route configuration is another story (which should be 
fixed)...





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on issue #295: request help: Both v1 and v1beta of ingress are supported

2021-03-11 Thread GitBox



tokers commented on issue #295:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/295#issuecomment-797162872


   @Junnplus Kubernetes will create `v1` incarnation replica when you create a 
`v1beta1` version Ingress and vice versa. What the `--ingress-version` does is 
tell the controller use which version's informer and lister to serve.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers merged pull request #3799: feat: load etcd configuration when apisix starts

2021-03-11 Thread GitBox



tokers merged pull request #3799:
URL: https://github.com/apache/apisix/pull/3799


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers closed issue #3370: bug: http service should not be started before etcd data is pulled

2021-03-11 Thread GitBox



tokers closed issue #3370:
URL: https://github.com/apache/apisix/issues/3370


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (843a652 -> 83537ad)

2021-03-11 Thread tokers

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 843a652  docs: update the admin-api.md document (#3805)
 add 83537ad  feat: load etcd configuration when apisix starts (#3799)

No new revisions were added by this update.

Summary of changes:
 apisix/cli/etcd.lua|  14 +-
 apisix/{core/version.lua => constants.lua} |  21 ++-
 apisix/core/config_etcd.lua| 288 +++--
 apisix/core/config_yaml.lua|   1 +
 apisix/core/etcd.lua   |   8 +-
 apisix/init.lua|  17 +-
 apisix/patch.lua   | 177 ++
 t/APISIX.pm|   2 +
 t/admin/plugins-reload.t   |  12 +-
 t/core/etcd-sync.t |   1 +
 t/core/etcd.t  |  44 +
 t/{control/plugin-api.t => misc/patch.t}   |  38 ++--
 12 files changed, 492 insertions(+), 131 deletions(-)
 copy apisix/{core/version.lua => constants.lua} (58%)
 create mode 100644 apisix/patch.lua
 copy t/{control/plugin-api.t => misc/patch.t} (67%)

[GitHub] [apisix-ingress-controller] tokers merged pull request #291: fix: grammar typo

2021-03-11 Thread GitBox



tokers merged pull request #291:
URL: https://github.com/apache/apisix-ingress-controller/pull/291


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: fix: grammar typo (#291)

2021-03-11 Thread tokers

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new e2ddfad  fix: grammar typo (#291)
e2ddfad is described below

commit e2ddfadbc0fa0a9bad35172651bba83db1f01b01
Author: fredster33 <64927044+fredste...@users.noreply.github.com>
AuthorDate: Thu Mar 11 17:08:30 2021 -0800

fix: grammar typo (#291)

Co-authored-by: Alex Zhang

[GitHub] [apisix] tokers closed issue #3802: docs: update the admin-api.md document

2021-03-11 Thread GitBox



tokers closed issue #3802:
URL: https://github.com/apache/apisix/issues/3802


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: docs: update the admin-api.md document (#3805)

2021-03-11 Thread tokers

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 843a652  docs: update the admin-api.md document (#3805)
843a652 is described below

commit 843a6523d3803a73bb67352c0177459d6586edc1
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Fri Mar 12 09:07:50 2021 +0800

docs: update the admin-api.md document (#3805)

related issue #3802
---
 docs/en/latest/admin-api.md | 24 
 docs/zh/latest/admin-api.md |  6 +++---
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/docs/en/latest/admin-api.md b/docs/en/latest/admin-api.md
index 5015891..604e3bb 100644
--- a/docs/en/latest/admin-api.md
+++ b/docs/en/latest/admin-api.md
@@ -517,25 +517,25 @@ Return response from etcd currently.
 
 In addition to the basic complex equalization algorithm selection, APISIX's 
Upstream also supports logic for upstream passive health check and retry, see 
the table below.
 
-|Name|Optional|Description|
-|--- |-|--|
+|Name|Optional|Description|
+|||---|
 |type|required|the balancer algorithm|
 |nodes   |required, can't be used with `service_name` |Hash table, the 
key of the internal element is the upstream machine address list, the format is 
`Address + Port`, where the address part can be IP or domain name, such as 
`192.168.1.100:80`, `foo.com:80`, etc. Value is the weight of the node. In 
particular, when the weight value is `0`, it has a special meaning, which 
usually means that the upstream node is invalid and never wants to be selected. 
The `nodes` can be empty, whi [...]
 |service_name|required, can't be used with `nodes` |the name of service 
used in the service discovery, see [discovery](discovery.md) for more details|
-|discovery_type |required, if `service_name` is used | the type of service 
discovery, see [discovery](discovery.md) for more details|
+|discovery_type  |required, if `service_name` is used | the type of service 
discovery, see [discovery](discovery.md) for more details|
 |hash_on |optional|This option is only valid if the `type` is `chash`. 
Supported types `vars`(Nginx variables), `header`(custom header), `cookie`, 
`consumer`, the default value is `vars`.|
 |key |optional|This option is only valid if the `type` is `chash`. 
Find the corresponding node `id` according to `hash_on` and `key`. When 
`hash_on` is set as `vars`, `key` is the required parameter, for now, it 
support nginx built-in variables like `uri, server_name, server_addr, 
request_uri, remote_port, remote_addr, query_string, host, hostname, arg_***`, 
`arg_***` is arguments in the request line, [Nginx variables 
list](http://nginx.org/en/docs/varindex.html). When `hash_ [...]
 |checks  |optional|Configure the parameters of the health check. For 
details, refer to [health-check](health-check.md).|
 |retries |optional|Pass the request to the next upstream using the 
underlying Nginx retry mechanism, the retry mechanism is enabled by default and 
set the number of retries according to the number of available backend nodes. 
If `retries` option is explicitly set, it will override the default value. `0` 
means disable retry mechanism.|
-|timeout|optional| Set the timeout for connection, sending and receiving 
messages. |
-|name |optional|Identifies upstream names|
-|desc |optional|upstream usage scenarios, and more.|
-|pass_host|optional|`pass` pass the client request host, `node` 
not pass the client request host, using the upstream node host, `rewrite` 
rewrite host by the configured `upstream_host`. Default to `pass`.|
-|upstream_host|optional|This option is only valid if the `pass_host` is 
`rewrite`.|
-|scheme|optional |The scheme used when talk with the upstream. The value is 
one of ['http', 'https', 'grpc', 'grpcs'], default to 'http'.|
-|labels|optional |Key/value pairs to specify 
attributes|{"version":"v2","build":"16","env":"production"}|
-|create_time|optional| epoch timestamp in second, like `1602883670`, will be 
created automatically if missing|
-|update_time|optional| epoch timestamp in second, like `1602883670`, will be 
created automatically if missing|
+|timeout |optional| Set the timeout for connection, sending and 
receiving messages. |
+|name|optional|Identifies upstream names|
+|desc|optional|upstream usage scenarios, and more.|
+|pass_host   |optional|Specify the source of the upstream request host, 
can be one of [`pass`, `node`, `rewrite`]. `pass`: use the host requested by 
the client as the host of the upstream request, `node`: use the host configured 
in the node of `upstream` as the upstream request host, `rewrite`: use the 
value configured by `upstream_host` to rewrite the

[GitHub] [apisix] tokers merged pull request #3805: docs: update the admin-api.md document

2021-03-11 Thread GitBox



tokers merged pull request #3805:
URL: https://github.com/apache/apisix/pull/3805


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3811: request help: is there dbless version for apisix

2021-03-11 Thread GitBox



spacewander commented on issue #3811:
URL: https://github.com/apache/apisix/issues/3811#issuecomment-797161681


   Does standalone mode satisfy your requirement?
   https://github.com/apache/apisix/blob/master/docs/en/latest/stand-alone.md



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox



codecov-io commented on pull request #291:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-797161470


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=h1)
 Report
   > Merging 
[#291](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=desc)
 (01bdaf0) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c65802ce918fa746f2c8617c517d1eedd1792605?el=desc)
 (c65802c) will **increase** coverage by `47.80%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ##   master  #291   +/-   ##
   
   + Coverage   52.19%   100.00%   +47.80% 
   
 Files  32 1   -31 
 Lines2320 1 -2319 
   
   - Hits 1211 1 -1210 
   + Misses952 0  -952 
   + Partials  157 0  -157 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[pkg/metrics/prometheus.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL21ldHJpY3MvcHJvbWV0aGV1cy5nbw==)
 | | |
   | 
[pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv)
 | | |
   | 
[pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv)
 | | |
   | 
[pkg/log/logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=)
 | | |
   | 
[cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==)
 | | |
   | 
[pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==)
 | | |
   | 
[pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv)
 | | |
   | 
[pkg/log/options.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2xvZy9vcHRpb25zLmdv)
 | | |
   | 
[pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv)
 | | |
   | 
[pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv)
 | | |
   | ... and [23 
more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=footer).
 Last update 
[c65802c...01bdaf0](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox



tokers commented on pull request #291:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-797154565


   @fredster33 Don't worry, I have solved these conflicts.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] fredster33 commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox



fredster33 commented on pull request #291:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-796938156


   > @fredster33 There are conflicting files
   
   Hmm, it seems like somebody else edited the README after my change. How 
could this be resolved?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox



Firstsawyou commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-796899591


   > @Firstsawyou
   > 
   > Do you have time to find out why the test case failed? You can submit a 
patch for @jbampton
   > 
   > help him to finish this PR, many thx
   
   The test case failure is caused by the following two reasons:
   
   1. In the test file of `t/plugin/echo.t`, `userpasswrd` should be 
`userpassword`.
   
   ```git
   diff --git a/t/plugin/echo.t b/t/plugin/echo.t
   index e45fa89..97103a4 100644
   --- a/t/plugin/echo.t
   +++ b/t/plugin/echo.t
   @@ -269,7 +269,7 @@ Location: https://www.iresty.com
"plugins": {
   "echo": {
"before_body": "before the body 
modification ",
   - "auth_value" : "userpasswrd",
   + "auth_value" : "userpassword",
"headers": {
"Location":"https://www.iresty.com;
}
   ```
   
   2、[api7/jsonschema](https://github.com/api7/jsonschema) has not released a 
new version after `sctrictly` is fixed (`sctrictly` -> `strictly`). We need to 
release a new version of [api7/jsonschema](https://github.com/api7/jsonschema) 
to support `strictly`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

1 2 >

1 - 100 of 194 matches

Mail list logo