Change in asterixdb[master]: Support implicit variable name and column name.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1690/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Decoding of byte[] Records

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 42: public class DCPMessageToRecordConverter implements 
IRecordToRecordWithMetadataAndPKConverter {
> If by Style, you mean the formatting? then I think so.
I mean formatting. Right, I double checked.  It's correct.


Line 116: bytes.compact();
> the SDK use netty byte buffer which id different from java ByteBuffer. the 
How many copies are done for each buffer, roughly?
i.e., how many times compact() is called for each frame?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix Decoding of byte[] Records

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/951/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java:

Line 42: public class DCPMessageToRecordConverter implements 
IRecordToRecordWithMetadataAndPKConverter {
> Is the code style correct?
If by Style, you mean the formatting? then I think so.

If by style you mean interfaces and class design, Till and I have been 
discussing going over the interfaces at some point.
For now, this is correct and it means that you give this converter a DCPRequest 
(DCPRequest id a dcp message. I don't know why they named the class DCPRequest 
and I brought it up with them). The char[] means that the returned record 
object has a char[] which can be parsed.


Line 116: bytes.compact();
> A lot of memory copies here?
the SDK use netty byte buffer which id different from java ByteBuffer. the 
decoder only deals with ByteBuffers and CharBuffer. The parser can only deal 
with char[].
hence, doing all of this data movement.
For now, I think this is okay. At least, I am not creating any objects and all 
the copying is bulk operations which are relatively cheaper.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1689/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1479: Change storage valid int and add explicit ve...

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/919

to look at the new patch set (#11).

Change subject: ASTERIXDB-1479: Change storage valid int and add explicit 
version
..

ASTERIXDB-1479: Change storage valid int and add explicit version

This change will stop old versions from possibly corrupting data written
by newer versions of Hyracks. It also adds an explicit version to the
tree metadata that must match the version at runtime.

Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
---
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ITreeIndexMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/frames/LIFOMetaDataFrame.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java
4 files changed, 84 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/919/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/919
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I888ff0eacf5b3cb6ad7ec002c74f113c6ffcd496
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix Decoding of byte[] Records

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix Decoding of byte[] Records
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1688/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Decoding of byte[] Records

[abdullah alamoudi (Code Review)]

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/951

Change subject: Fix Decoding of byte[] Records
..

Fix Decoding of byte[] Records

Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
1 file changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/51/951/1

diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
index 6ce5e98..7e1f142 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPMessageToRecordConverter.java
@@ -39,17 +39,15 @@
 import com.couchbase.client.deps.io.netty.buffer.ByteBuf;
 import com.couchbase.client.deps.io.netty.util.ReferenceCountUtil;
 
-public class DCPMessageToRecordConverter
-implements IRecordToRecordWithMetadataAndPKConverter {
+public class DCPMessageToRecordConverter implements 
IRecordToRecordWithMetadataAndPKConverter {
 
 private final RecordWithMetadataAndPK recordWithMetadata;
 private final CharArrayRecord value;
 private final CharsetDecoder decoder = StandardCharsets.UTF_8.newDecoder();
 private final ByteBuffer bytes = 
ByteBuffer.allocateDirect(ExternalDataConstants.DEFAULT_BUFFER_SIZE);
 private final CharBuffer chars = 
CharBuffer.allocate(ExternalDataConstants.DEFAULT_BUFFER_SIZE);
-private static final IAType[] CB_META_TYPES = new IAType[] { 
/*ID*/BuiltinType.ASTRING,
-/*VBID*/BuiltinType.AINT32, /*SEQ*/BuiltinType.AINT64, 
/*CAS*/BuiltinType.AINT64,
-/*EXPIRATION*/BuiltinType.AINT32,
+private static final IAType[] CB_META_TYPES = new IAType[] { 
/*ID*/BuiltinType.ASTRING, /*VBID*/BuiltinType.AINT32,
+/*SEQ*/BuiltinType.AINT64, /*CAS*/BuiltinType.AINT64, 
/*EXPIRATION*/BuiltinType.AINT32,
 /*FLAGS*/BuiltinType.AINT32, /*REV*/BuiltinType.AINT64, 
/*LOCK*/BuiltinType.AINT32 };
 private static final int[] PK_INDICATOR = { 1 };
 private static final int[] PK_INDEXES = { 0 };
@@ -105,16 +103,19 @@
 int position = content.readerIndex();
 final int limit = content.writerIndex();
 final int contentSize = content.readableBytes();
+bytes.clear();
+System.err.println("Using netty decoder: " + 
content.toString(StandardCharsets.UTF_8));
 while (position < limit) {
-bytes.clear();
 chars.clear();
-if ((contentSize - position) < bytes.capacity()) {
+if ((contentSize - position) < bytes.remaining()) {
 bytes.limit(contentSize - position);
 }
-content.getBytes(position, bytes);
+content.getBytes(position + bytes.position(), bytes);
 position += bytes.position();
 bytes.flip();
 decoder.decode(bytes, chars, false);
+bytes.compact();
+position -= bytes.position();
 chars.flip();
 record.append(chars);
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/951
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I71c3d8b8dfa5a98123725f139247d2b5ce10012e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 

Change in asterixdb[master]: ASTERIXDB-1375 - New Query Web UI

[Kaveen Rodrigo (Code Review)]

Kaveen Rodrigo has uploaded a new patch set (#3).

Change subject: ASTERIXDB-1375 - New Query Web UI
..

ASTERIXDB-1375 - New Query Web UI

This commit includes

Web Query UI implemented in bootstrap according to specification.
Internal Javascript logic written with Angular JS .
Custom CSS to comply to the design specification given in the ticket.
Code Mirror implementation with custom AQL mode to highlight syntax.
Servlet to host the web interface on Port 19006
Modification on the HTTP API to support CORS 

Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
---
M .gitignore
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap-theme.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/bootstrap.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/codemirror.css
A asterixdb/asterix-app/src/main/resources/newui/css/json-formatter.min.css
A asterixdb/asterix-app/src/main/resources/newui/css/master.css
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.eot
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.svg
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.ttf
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff
A 
asterixdb/asterix-app/src/main/resources/newui/fonts/glyphicons-halflings-regular.woff2
A asterixdb/asterix-app/src/main/resources/newui/img/finalasterixlogo.png
A asterixdb/asterix-app/src/main/resources/newui/js/angular.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/aql-mode.js
A asterixdb/asterix-app/src/main/resources/newui/js/bootstrap.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/js/javascript.js
A asterixdb/asterix-app/src/main/resources/newui/js/jquery-1.12.4.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/json-formatter.min.js
A asterixdb/asterix-app/src/main/resources/newui/js/main.js
A asterixdb/asterix-app/src/main/resources/newui/js/ui-codemirror.js
A asterixdb/asterix-app/src/main/resources/newui/queryui.html
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixExternalProperties.java
M asterixdb/asterix-installer/src/main/resources/conf/asterix-configuration.xml
27 files changed, 11,515 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/935/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 

Change in asterixdb[master]: Support implicit variable name and column name.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Support implicit variable name and column name.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1686/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/950
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Support implicit variable name and column name.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/950

Change subject: Support implicit variable name and column name.
..

Support implicit variable name and column name.

1. Fixed open/closed type optimization;
2. Fixed scoping for nested aggregations;
3. Support WITH clauses in general cases.

Change-Id: I409b9ba139c9f000a6b9b84d519d172d0069e4bb
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AbstractResolveVariableRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveAggregateVariableRule.java
A 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestExecutor.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/disjunction-to-join-delete-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert-secondary-index.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/scan-insert.plan
M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias2.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast
M 
asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/nestedFLWOGR3.ast
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-2/q2-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-3/q2-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-4/q2-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dapd/q2-5/q2-5.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/varlen-encoding/varlen-encoding.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/distinct_by/distinct_by.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/group_no_agg/group_no_agg.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate/nest_aggregate.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/nest_aggregate2/nest_aggregate2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q01_pricing_summary_report_nt/q01_pricing_summary_report_nt.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/q01_pricing_summary_report_nt/q01_pricing_summary_report_nt.2.update.sqlpp
A 

Change in asterixdb[master]: Fix Indexing on Open fields and Meta fields

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Fix Indexing on Open fields and Meta fields
..


Patch Set 6:

(7 comments)

1. Can you add optimizer tests for those added runtime tests to verify index 
access path is used?  

2. Can you add tests to check whether index join work?
For that, you said 
" For joins and left outer joins, I have only created optimizer tests and not 
runtime tests.",  but somehow they are not in this change.  Are they on your 
local branch but not pushed?

https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.1.ddl.aql:

Line 21:  * build a secondary index after the dataset has data 
WS


https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.2.update.aql:

Line 21:  * build a secondary index after the dataset has data 
WS


https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.3.ddl.aql:

Line 21:  * build a secondary index after the dataset has data 
WS


https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.4.query.aql:

Line 21:  * build a secondary index after the dataset has data 
WS


https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/change-feed-with-meta-pk-in-meta-index-after-ingest/change-feed-with-meta-pk-in-meta-index-after-ingest.5.ddl.aql:

Line 21:  * build a secondary index after the dataset has data 
Ws


https://asterix-gerrit.ics.uci.edu/#/c/930/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java:

Line 95: hasMeta = true;
replace the if-block with the following?

hasMeta=(fieldPermutation.length > numOfPrimaryKeys + 1) &&(filterFieldIndex < 
0 || (filterFieldIndex >= 0 && (fieldPermutation.length > numOfPrimaryKeys + 
2)));


https://asterix-gerrit.ics.uci.edu/#/c/930/6/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeSearchOperatorDescriptor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/dataflow/BTreeSearchOperatorDescriptor.java:

Line 70: throw new IllegalArgumentException();
Error message?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6195149940f150250a65f2515e9ac9d6de2a33f9
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes