Change in asterixdb[master]: Enhanced Insert AQL Added "return records" and "returning [f...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Enhanced Insert AQL Added "return records" and "returning 
[fieldName]" "return records" returns to the user all records that were 
inserted "returning [fieldName]" returns only the valuse inserted for 
[fieldName] Allow commits to be non-sink operators (con
..


Patch Set 9:

(15 comments)

There seem to be a few unrelated modifications in this change and there are a 
few
points that I'm not sure about:

- Why is ExtensionStatement needed for this change? (I'm especially suspicious
  about the decisions taken in the rewriting rules base on the fact that a
  statement in an ExtensionStatement)

- Why do we need to modify IExtensionStatement?

- What is the relationship between ExtensionStatement and IExtensionStatement?

https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java
File 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/IActiveEntityEventsListener.java:

Line 34: public boolean isEntityUsingDataset(String dataverseName, String 
datasetName);
Seems unrelated ..


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java:

Line 54: int resultSetIdCounter) throws HyracksDataException, 
AlgebricksException;
Seems unrelated as well ...


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java:

Line 101: if (op1.getOperatorTag() == 
LogicalOperatorTag.EXTENSION_OPERATOR) {
This seems unrelated as well ...


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java:

Line 96: if (op0.getOperatorTag() != 
LogicalOperatorTag.EXTENSION_OPERATOR
Seems unrelated.


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java:

Line 96: if (op1.getOperatorTag() == 
LogicalOperatorTag.EXTENSION_OPERATOR) {
Seems unrelated ...


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java:

Line 66: ExtensionOperator eOp = (ExtensionOperator) op;
Seems unrelated.


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java:

Line 26: import org.apache.asterix.external.feed.watch.FeedActivityDetails;
Seems unrelated.


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 305: throws AlgebricksException {
Revert this file?


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:

Line 86: AlgebricksBuiltinFunctions.GE, 
AlgebricksBuiltinFunctions.LT, AlgebricksBuiltinFunctions.GT));
There seems to be no semantic change in this file, can we revert it?


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java:

Line 108: assignsAndUnnestsRefs.add(subTreeOpRef);
This seems to be a step back in terms of extensibility, could we revert the 
file?


https://asterix-gerrit.ics.uci.edu/#/c/1150/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java:

Change in asterixdb[master]: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.

[Wenhai Li (Code Review)]

Wenhai Li has posted comments on this change.

Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 11:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1119/11//COMMIT_MSG
Commit Message:

Line 10: 2. Disable the join branch pruning in case of unnestmap following 
datasourcescan.
> Can you add more explanation on " unnestmap following datasourcescan"?  
Done


Line 11: 
> Remove local commit history in the commit message.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java:

Line 159: for (int i = 0; i < joinOp.getInputs().size(); i++) {
> Move the unnest-map gathering/check to line 189. 
This is really more general. Let's try it later.


Line 188: // The pre-plan is (broadcast B and index search on A on each 
A.a ~= B.b) join B on A.a = B.b
> Can you add the explanation as a comment in the code?  Particularly, explai
Done


https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql:

Line 19: 
> Can you a description of this test? What it is intended for? And the expect
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add result location HTTP API.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add result location HTTP API.
..


Patch Set 1:

(4 comments)

I've got a few comments in the source and a few requests :)

1) Could you add a test?
2) Could you file an issue about the weak error handling capabilities of the
   result distribution framework that mentions that
   a) HyracksDatasetReader.getResultStatus ignores exceptions and
   b) DatasetDirectoryService.getResultStatus hangs forever on an invalid jobId?

https://asterix-gerrit.ics.uci.edu/#/c/1178/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java:

Line 14:  */
Please use an Apache license header.


Line 56: String strHandle = request.getParameter("handle");
Handle the case if no handle is given. Should probably return a 400.


Line 81: JSONArray handle = handleObj.getJSONArray("handle");
Check the syntax of the handle.


Line 116: out.println(e.getMessage());
Could we produce a JSON error like 

{ "errors": [ { "msg" : "bla bla" } ] }

here?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1178
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By...

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: ASTERIXDB-1566, ASTERIXDB-1628: Fixed External Hash Group By to 
conform to the memory budget
..


Patch Set 10:

(13 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1056/10/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java:

Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / 
frameSize);
> MAJOR SonarQube violation:
Done


Line 413: int numberOfHeaderFrame = (int) Math.ceil(tableSize * 2 / 
frameSize);
> CRITICAL SonarQube violation:
Done


Line 414: int numberOfContentFrame = (int) Math
> MAJOR SonarQube violation:
Done


Line 415: .ceil((getNumberOfEntryInSlot() * 2 * getUnitSize() * 
tableSize) / frameSize);
> CRITICAL SonarQube violation:
Done


Line 445: int slotCapacity = 0;
> MAJOR SonarQube violation:
Done


Line 446: int slotUsedCount = 0;
> MAJOR SonarQube violation:
Done


Line 447: int capacityInIntCount = 0;
> MAJOR SonarQube violation:
Done


Line 462: slotCapacity = INVALID_VALUE;
> MAJOR SonarQube violation:
Done


Line 463: slotUsedCount = INVALID_VALUE;
> MAJOR SonarQube violation:
Done


Line 549: intReadAtThisTime = Math.min(intToRead, 
(frameCapacity - currentReadIntOffsetInPageForGC));
> MAJOR SonarQube violation:
Done


Line 580: oneTimeIntCapacityForWriter = Math.min(chunksToMove, 
(frameCapacity - tempWriteIntPosInPage));
> MAJOR SonarQube violation:
Done


Line 581: oneTimeIntCapacityForReader = Math.min(chunksToMove, 
(frameCapacity - tempReadIntPosInPage));
> MAJOR SonarQube violation:
Done


Line 639: chunksToDeleteAtThisTime = Math.min(chunksToDelete, 
(frameCapacity - tempReadIntPosInPage));
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

[jira] [Updated] (ASTERIXDB-1640) IndexDataflowHelper deletes existing index on create

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1640:

Assignee: Abdullah Alamoudi

> IndexDataflowHelper deletes existing index on create
> 
>
> Key: ASTERIXDB-1640
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1640
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Abdullah Alamoudi
>Assignee: Abdullah Alamoudi
>  Labels: soon
>
> Creating an index might lead to deletion of on disk existing resources.
> Look at the implementation of create() in IndexDataflowHelper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1612) Shutdown of *DB cluster leaves threads running

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1612:

Assignee: Michael Blow

> Shutdown of *DB cluster leaves threads running
> --
>
> Key: ASTERIXDB-1612
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1612
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Test Framework
>Reporter: Michael Blow
>Assignee: Michael Blow
>  Labels: soon
>
> When a cluster is started using AsterixHyracksIntegrationUtil and 
> subsequently shut down without terminating the VM, a number of *DB threads 
> remain active.
> "Thread-176" #237 prio=5 os_prio=31 tid=0x7f962acb nid=0x1cc07 
> waiting on condition [0x769ce000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d608> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>   at 
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>   at 
> org.apache.asterix.transaction.management.service.logging.LogManager$FlushLogsLogger.run(LogManager.java:602)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> "Thread-175" #236 prio=5 os_prio=31 tid=0x7f962acb2000 nid=0x11207 
> waiting on condition [0x768cb000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d6f0> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>   at 
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>   at 
> org.apache.asterix.transaction.management.service.logging.LogManager$FlushLogsLogger.run(LogManager.java:602)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> "TCPEndpoint IO Thread" #222 daemon prio=5 os_prio=31 tid=0x7f962a503800 
> nid=0x1aa07 runnable [0x7c079000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
>   at sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
>   at sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:117)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x0007071582d0> (a sun.nio.ch.Util$2)
>   - locked <0x0007071582e0> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x000707158280> (a sun.nio.ch.KQueueSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
>   at 
> org.apache.hyracks.net.protocols.tcp.TCPEndpoint$IOThread.run(TCPEndpoint.java:121)
> "IPC Network Listener Thread" #221 daemon prio=10 os_prio=31 
> tid=0x7f962b02a000 nid=0x1a507 runnable [0x7bc17000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
>   at sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
>   at sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:117)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x000707158478> (a sun.nio.ch.Util$2)
>   - locked <0x000707158488> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x00070702ffa8> (a sun.nio.ch.KQueueSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
>   at 
> org.apache.hyracks.ipc.impl.IPCConnectionManager$NetworkThread.run(IPCConnectionManager.java:200)
> "Thread-70" #111 prio=5 os_prio=31 tid=0x7f9627b52000 nid=0x11a03 waiting 
> on condition [0x775f2000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d608> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at 

[jira] [Updated] (ASTERIXDB-1625) NC2NC Messaging networking parameters should be configurable when using NCService

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1625:

Assignee: Michael Blow

> NC2NC Messaging networking parameters should be configurable when using 
> NCService
> -
>
> Key: ASTERIXDB-1625
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1625
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Hyracks Core
>Reporter: Michael Blow
>Assignee: Michael Blow
>  Labels: soon
>
> Currently the NC2NC messaging port, address are not able to be configured for 
> clusters using the NCService.
> Ini properties need to be defined for the following:
> -messaging-ip-address: IP Address to bind messaging listener (default: same 
> as -address)
> -messaging-port: IP port to bind messaging listener (default: random port)
> -messaging-public-ip-address: Public IP Address to announce messaging 
> listener (default: same as -messaging-ip-address)
> -messaging-public-port: Public IP port to announce messaging listener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1614) DatasetDirectoryService.deinitState() fix intermittently fails

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1614:

Assignee: Abdullah Alamoudi

> DatasetDirectoryService.deinitState() fix intermittently fails
> --
>
> Key: ASTERIXDB-1614
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1614
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Hyracks
>Reporter: Michael Blow
>Assignee: Abdullah Alamoudi
>  Labels: soon
>
> After merging a fix for type-correctness in 
> DatasetDirectoryService.deinitState(), tests started intermittently failing.  
> e.g. 
> https://asterix-jenkins.ics.uci.edu/view/All/job/asterix-integration-tests/208/
> java.lang.NullPointerException
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.registerResultPartitionLocation(DatasetDirectoryService.java:98)
>   at 
> org.apache.hyracks.control.cc.work.RegisterResultPartitionLocationWork.run(RegisterResultPartitionLocationWork.java:58)
>   at 
> org.apache.hyracks.control.common.work.WorkQueue$WorkerThread.run(WorkQueue.java:133)
> java.lang.NullPointerException
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.reportResultPartitionWriteCompletion(DatasetDirectoryService.java:133)
>   at 
> org.apache.hyracks.control.cc.work.ReportResultPartitionWriteCompletionWork.run(ReportResultPartitionWriteCompletionWork.java:45)
>   at 
> org.apache.hyracks.control.common.work.WorkQueue$WorkerThread.run(WorkQueue.java:133)
> org.apache.hyracks.api.exceptions.HyracksDataException: Requested JobId 
> JID:1968 doesn't exist
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.updatedRecords(DatasetDirectoryService.java:253)
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.getResultPartitionLocations(DatasetDirectoryService.java:210)
>   at 
> org.apache.hyracks.control.cc.work.GetResultPartitionLocationsWork$1.run(GetResultPartitionLocationsWork.java:59)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1638) Print the retainMissing flag for SelectOperator if the flag is true

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1638:

Labels: so  (was: )

> Print the retainMissing flag for SelectOperator if the flag is true
> ---
>
> Key: ASTERIXDB-1638
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1638
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Yingyi Bu
>Assignee: Yingyi Bu
>Priority: Minor
>  Labels: soon
>
> There is a retainMissing flag in the select operator. That's set to be true 
> for the select operator that results from an index left outer join rewriting, 
> e.g.:
> select (function-call: algebricks:and, Args:[function-call: algebricks:neq, 
> Args:[%0->$$26, %0->$$25], function-call: asterix:get-item, 
> Args:[function-call: asterix:similarity-jaccard-check, Args:[%0->$$29, 
> %0->$$30, AFloat:
> {0.6}], AInt64: {0}]]) – |LOCAL|
> It would be helpful to print that flag in the plan, e.g.:
> select *[retainMissing=true]* (function-call: algebricks:and, 
> Args:[function-call: algebricks:neq, Args:[%0->$$26, %0->$$25], 
> function-call: asterix:get-item, Args:[function-call: 
> asterix:similarity-jaccard-check, Args:[%0->$$29, %0->$$30, AFloat: {0.6}
> ], AInt64:
> {0}
> ]]) – |LOCAL|



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1638) Print the retainMissing flag for SelectOperator if the flag is true

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1638:

Labels: soon  (was: so)

> Print the retainMissing flag for SelectOperator if the flag is true
> ---
>
> Key: ASTERIXDB-1638
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1638
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Yingyi Bu
>Assignee: Yingyi Bu
>Priority: Minor
>  Labels: soon
>
> There is a retainMissing flag in the select operator. That's set to be true 
> for the select operator that results from an index left outer join rewriting, 
> e.g.:
> select (function-call: algebricks:and, Args:[function-call: algebricks:neq, 
> Args:[%0->$$26, %0->$$25], function-call: asterix:get-item, 
> Args:[function-call: asterix:similarity-jaccard-check, Args:[%0->$$29, 
> %0->$$30, AFloat:
> {0.6}], AInt64: {0}]]) – |LOCAL|
> It would be helpful to print that flag in the plan, e.g.:
> select *[retainMissing=true]* (function-call: algebricks:and, 
> Args:[function-call: algebricks:neq, Args:[%0->$$26, %0->$$25], 
> function-call: asterix:get-item, Args:[function-call: 
> asterix:similarity-jaccard-check, Args:[%0->$$29, %0->$$30, AFloat: {0.6}
> ], AInt64:
> {0}
> ]]) – |LOCAL|



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Ian Maxon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494780#comment-15494780
 ] 

Ian Maxon commented on ASTERIXDB-1616:
--

It's fixed for me. 

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Wail Alkowaileet
>  Labels: soon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Ian Maxon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Maxon resolved ASTERIXDB-1616.
--
Resolution: Fixed

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Wail Alkowaileet
>  Labels: soon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1621) Deadlock observed in PartitionedLSMInvertedIndexMultiThreadTest

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1621:

Labels: soon  (was: )

> Deadlock observed in PartitionedLSMInvertedIndexMultiThreadTest
> ---
>
> Key: ASTERIXDB-1621
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1621
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Storage
>Reporter: Michael Blow
>Priority: Critical
>  Labels: soon
> Attachments: thread_dump.txt
>
>
> Observed in 
> [this|https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2461] 
> jenkins run, a deadlock in PartitionedLSMInvertedIndexMultiThreadTest.  
> Thread dump is available 
> [here|https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2461/artifact/target/threaddumps/jstack_23864.html],
>  and will also be attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Ian Maxon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Maxon updated ASTERIXDB-1616:
-
Assignee: Wail Alkowaileet  (was: Ian Maxon)

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Wail Alkowaileet
>  Labels: soon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1622) Add test case for https://asterix-gerrit.ics.uci.edu/#/c/1130/

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1622:

Labels: soon  (was: )

> Add test case for https://asterix-gerrit.ics.uci.edu/#/c/1130/
> --
>
> Key: ASTERIXDB-1622
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1622
> Project: Apache AsterixDB
>  Issue Type: Test
>  Components: Hyracks
>Reporter: Michael Blow
>Assignee: Michael Blow
>  Labels: soon
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1616:

Labels: soon  (was: )

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Ian Maxon
>  Labels: soon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Log ResultStateSweeper As Finer, Test Default Level->INFO

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Log ResultStateSweeper As Finer, Test Default Level->INFO
..


Log ResultStateSweeper As Finer, Test Default Level->INFO

Change-Id: Ie8e9408590734694ce1fa5840783adee8d7ce695
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1176
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml 
b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
index 544f4ec..142b93a 100644
--- a/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
+++ b/asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
@@ -47,7 +47,7 @@
 
   
 log.level
-WARNING
+INFO
 Log level for running tests/build
   
   
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
index fc49cb1..8b66885 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
@@ -18,7 +18,7 @@
 "feed.memory.global.budget": 67108864,
 "feed.pending.work.threshold": 50,
 "feed.port": 19003,
-"log.level": "WARNING",
+"log.level": "INFO",
 "max.wait.active.cluster": 60,
 "nc.java.opts": "-Xmx1024m",
 "plot.activate": false,
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
index d17858b..150875b 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java
@@ -75,8 +75,8 @@
 datasetManager.deinitState(jobId);
 }
 }
-if (LOGGER.isLoggable(Level.INFO)) {
-LOGGER.info("Result state cleanup instance successfully 
completed.");
+if (LOGGER.isLoggable(Level.FINER)) {
+LOGGER.finer("Result state cleanup instance successfully 
completed.");
 }
 }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1176
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e9408590734694ce1fa5840783adee8d7ce695
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

[jira] [Updated] (ASTERIXDB-1614) DatasetDirectoryService.deinitState() fix intermittently fails

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1614:

Labels: soon  (was: )

> DatasetDirectoryService.deinitState() fix intermittently fails
> --
>
> Key: ASTERIXDB-1614
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1614
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Hyracks
>Reporter: Michael Blow
>  Labels: soon
>
> After merging a fix for type-correctness in 
> DatasetDirectoryService.deinitState(), tests started intermittently failing.  
> e.g. 
> https://asterix-jenkins.ics.uci.edu/view/All/job/asterix-integration-tests/208/
> java.lang.NullPointerException
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.registerResultPartitionLocation(DatasetDirectoryService.java:98)
>   at 
> org.apache.hyracks.control.cc.work.RegisterResultPartitionLocationWork.run(RegisterResultPartitionLocationWork.java:58)
>   at 
> org.apache.hyracks.control.common.work.WorkQueue$WorkerThread.run(WorkQueue.java:133)
> java.lang.NullPointerException
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.reportResultPartitionWriteCompletion(DatasetDirectoryService.java:133)
>   at 
> org.apache.hyracks.control.cc.work.ReportResultPartitionWriteCompletionWork.run(ReportResultPartitionWriteCompletionWork.java:45)
>   at 
> org.apache.hyracks.control.common.work.WorkQueue$WorkerThread.run(WorkQueue.java:133)
> org.apache.hyracks.api.exceptions.HyracksDataException: Requested JobId 
> JID:1968 doesn't exist
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.updatedRecords(DatasetDirectoryService.java:253)
>   at 
> org.apache.hyracks.control.cc.dataset.DatasetDirectoryService.getResultPartitionLocations(DatasetDirectoryService.java:210)
>   at 
> org.apache.hyracks.control.cc.work.GetResultPartitionLocationsWork$1.run(GetResultPartitionLocationsWork.java:59)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ASTERIXDB-1613) Shutdown of *DB cluster leaves threads running

[Till (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494771#comment-15494771
 ] 

Till commented on ASTERIXDB-1613:
-

[~mblow]: Is this a duplicate of the previous one?

> Shutdown of *DB cluster leaves threads running
> --
>
> Key: ASTERIXDB-1613
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1613
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: AsterixDB, Test Framework
>Reporter: Michael Blow
>
> When a cluster is started using AsterixHyracksIntegrationUtil and 
> subsequently shut down without terminating the VM, a number of *DB threads 
> remain active.
> "Thread-176" #237 prio=5 os_prio=31 tid=0x7f962acb nid=0x1cc07 
> waiting on condition [0x769ce000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d608> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>   at 
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>   at 
> org.apache.asterix.transaction.management.service.logging.LogManager$FlushLogsLogger.run(LogManager.java:602)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> "Thread-175" #236 prio=5 os_prio=31 tid=0x7f962acb2000 nid=0x11207 
> waiting on condition [0x768cb000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d6f0> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
>   at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
>   at 
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
>   at 
> org.apache.asterix.transaction.management.service.logging.LogManager$FlushLogsLogger.run(LogManager.java:602)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> "TCPEndpoint IO Thread" #222 daemon prio=5 os_prio=31 tid=0x7f962a503800 
> nid=0x1aa07 runnable [0x7c079000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
>   at sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
>   at sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:117)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x0007071582d0> (a sun.nio.ch.Util$2)
>   - locked <0x0007071582e0> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x000707158280> (a sun.nio.ch.KQueueSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
>   at 
> org.apache.hyracks.net.protocols.tcp.TCPEndpoint$IOThread.run(TCPEndpoint.java:121)
> "IPC Network Listener Thread" #221 daemon prio=10 os_prio=31 
> tid=0x7f962b02a000 nid=0x1a507 runnable [0x7bc17000]
>java.lang.Thread.State: RUNNABLE
>   at sun.nio.ch.KQueueArrayWrapper.kevent0(Native Method)
>   at sun.nio.ch.KQueueArrayWrapper.poll(KQueueArrayWrapper.java:198)
>   at sun.nio.ch.KQueueSelectorImpl.doSelect(KQueueSelectorImpl.java:117)
>   at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
>   - locked <0x000707158478> (a sun.nio.ch.Util$2)
>   - locked <0x000707158488> (a java.util.Collections$UnmodifiableSet)
>   - locked <0x00070702ffa8> (a sun.nio.ch.KQueueSelectorImpl)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
>   at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
>   at 
> org.apache.hyracks.ipc.impl.IPCConnectionManager$NetworkThread.run(IPCConnectionManager.java:200)
> "Thread-70" #111 prio=5 os_prio=31 tid=0x7f9627b52000 nid=0x11a03 waiting 
> on condition [0x775f2000]
>java.lang.Thread.State: WAITING (parking)
>   at sun.misc.Unsafe.park(Native Method)
>   - parking to wait for  <0x00070299d608> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>   at 

[jira] [Updated] (ASTERIXDB-1610) Document MISSING in data model

[Till (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-1610:

Labels: soon  (was: )

> Document MISSING in data model
> --
>
> Key: ASTERIXDB-1610
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1610
> Project: Apache AsterixDB
>  Issue Type: Task
>  Components: Documentation
>Reporter: Yingyi Bu
>Assignee: Michael J. Carey
>  Labels: soon
>
> MISSING needs to be added into the ADM document.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1175

to look at the new patch set (#7).

Change subject: Full-text search implementation step 1
..

Full-text search implementation step 1

 - Changed a function name: contains -> string-contains to remove any confusions
   since Full-text search also uses "contains" as a part of its syntax
 - Changed a few test cases to reserve 'text' as a keyword in AQL for the same 
reason

Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-4/dataset_with_meta-4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-5/dataset_with_meta-5.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-6/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-7/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1/issue_251_dataset_hint_error_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2/issue_251_dataset_hint_error_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_255_create_feed_error/issue_255_create_feed_error.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/closedtables-q9.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/opentables-q9.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/count-tweets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/with-primary-index-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains.aql
M 

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2662/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6:

@Yingyi: got it! Thanks.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6:

Hi Taewoo,

   One quick comment. Pls do not modify any SQL++ test queries.  "Contains" is 
a SQL++ builtin function that follows Oracle SQL. Please add the map from 
"contains" to "string-contains" in FunctionMapUtil.java if the AQL function has 
to be renamed.

Best,
Yingyi

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/651/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/651/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2661/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2660/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1175

to look at the new patch set (#5).

Change subject: Full-text search implementation step 1
..

Full-text search implementation step 1

 - Changed a function name: contains -> string-contains to remove any confusions
   since Full-text search also uses "contains" as a part of its syntax
 - Changed a few test cases to reserve 'text' as a keyword in AQL for the same 
reason

Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-4/dataset_with_meta-4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-5/dataset_with_meta-5.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-6/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-7/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1/issue_251_dataset_hint_error_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2/issue_251_dataset_hint_error_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_255_create_feed_error/issue_255_create_feed_error.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/closedtables-q9.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/opentables-q9.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/count-tweets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/with-primary-index-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains.aql
M 

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2659/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1175

to look at the new patch set (#4).

Change subject: Full-text search implementation step 1
..

Full-text search implementation step 1

 - Changed a function name: contains -> string-contains to remove any confusions
   since Full-text search also uses "contains" as a part of its syntax
 - Changed a few test cases to reserve 'text' as a keyword in AQL for the same 
reason

Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-4/dataset_with_meta-4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-5/dataset_with_meta-5.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-6/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-7/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1/issue_251_dataset_hint_error_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2/issue_251_dataset_hint_error_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_255_create_feed_error/issue_255_create_feed_error.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/closedtables-q9.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/opentables-q9.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/count-tweets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/with-primary-index-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains.aql
M 

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1175/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 482: public static final FunctionIdentifier 
EDIT_DISTANCE_STRING_CONTAINS = new 
FunctionIdentifier(FunctionConstants.ASTERIX_NS,
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2658/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1175

to look at the new patch set (#3).

Change subject: Full-text search implementation step 1
..

Full-text search implementation step 1

 - Changed a function name: contains -> string-contains to remove any confusions
   since Full-text search also uses "contains" as a part of its syntax
 - Changed a few test cases to reserve 'text' as a keyword in AQL for the same 
reason

Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-4/dataset_with_meta-4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-5/dataset_with_meta-5.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-6/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-7/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1/issue_251_dataset_hint_error_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2/issue_251_dataset_hint_error_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_255_create_feed_error/issue_255_create_feed_error.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/closedtables-q9.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/opentables-q9.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/count-tweets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/with-primary-index-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains.aql
M 

Change in asterixdb[master]: Full-text search implementation step 1

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1175

to look at the new patch set (#2).

Change subject: Full-text search implementation step 1
..

Full-text search implementation step 1

 - Changed a function name: contains -> string-contains to remove any confusions
   since Full-text search also uses "contains" as a part of its syntax
 - Changed a few test cases to reserve 'text' as a keyword in AQL for the same 
reason

Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-4/dataset_with_meta-4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-5/dataset_with_meta-5.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-6/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-7/dataset_with_meta-6.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_1/issue_251_dataset_hint_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_1/issue_251_dataset_hint_error_1.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_251_dataset_hint_error_2/issue_251_dataset_hint_error_2.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/exception/issue_255_create_feed_error/issue_255_create_feed_error.1.ddl.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/closedtables-q9.aql
M 
asterixdb/asterix-app/src/test/resources/nontagged/tpch/local/opentables-q9.aql
M asterixdb/asterix-app/src/test/resources/optimizerts/queries/count-tweets.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/with-primary-index-intersect.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/ngram-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-basic/word-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-index/inverted-index-join/ngram-edit-distance-contains.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains-panic.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-basic/ngram-contains.aql
M 

Change in asterixdb[master]: Full-text search implementation step 1

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Full-text search implementation step 1
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2657/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id680ca2cc0d529670f5e3239236fdeb3aaf9ab53
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 11:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java:

Line 159: for (int i = 0; i < joinOp.getInputs().size(); i++) {
Move the unnest-map gathering/check to line 189. 

Add a method isParentOfUnnestMap(...) to just check if an operator is the 
parent of an unnestmap.

Call 
isParentOfUnnestMap(joinOp.getInputs().get(unusedJoinBranchIndex).getValue()) 
to check the condition at line 189.

One more question:
Should the condition be more general than unnest-map?   Any cardinality 
reduction operator should be qualified here?   E.g., SELECT etc.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add result location HTTP API.

[Wail Alkowaileet (Code Review)]

Wail Alkowaileet has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1178

Change subject: Add result location HTTP API.
..

Add result location HTTP API.

This addition allows other systems to connect to AsterixDB
and collect the result locations of a an async query.

Change-Id: If5d691635c6003947b4eb06291f620127de1eef8
---
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
3 files changed, 160 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1178/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
new file mode 100644
index 000..da0eaa2
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultLocationsAPIServlets.java
@@ -0,0 +1,155 @@
+/*
+ * Copyright 2009-2013 by The Regents of the University of California
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * you may obtain a copy of the License from
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.asterix.api.http.servlet;
+
+import java.io.IOException;
+import java.io.PrintWriter;
+
+import javax.servlet.ServletContext;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.asterix.app.result.ResultReader;
+import org.apache.hyracks.api.client.HyracksConnection;
+import org.apache.hyracks.api.client.IHyracksClientConnection;
+import org.apache.hyracks.api.comm.NetworkAddress;
+import org.apache.hyracks.api.dataset.DatasetDirectoryRecord;
+import org.apache.hyracks.api.dataset.DatasetJobRecord.Status;
+import org.apache.hyracks.api.dataset.IHyracksDataset;
+import 
org.apache.hyracks.api.dataset.IHyracksDatasetDirectoryServiceConnection;
+import org.apache.hyracks.api.dataset.ResultSetId;
+import org.apache.hyracks.api.job.JobId;
+import org.apache.hyracks.client.dataset.HyracksDataset;
+import 
org.apache.hyracks.client.dataset.HyracksDatasetDirectoryServiceConnection;
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+
+/**
+ * A servlet to get the result locations.
+ */
+public class QueryResultLocationsAPIServlets extends HttpServlet {
+
+private static final long serialVersionUID = 1L;
+
+private static final String HYRACKS_CONNECTION_ATTR = 
"org.apache.asterix.HYRACKS_CONNECTION";
+
+private static final String HYRACKS_DATASET_ATTR = 
"org.apache.asterix.HYRACKS_DATASET";
+
+@Override
+public void doGet(HttpServletRequest request, HttpServletResponse 
response) throws IOException {
+response.setContentType("text/html");
+response.setCharacterEncoding("utf-8");
+String strHandle = request.getParameter("handle");
+PrintWriter out = response.getWriter();
+ServletContext context = getServletContext();
+IHyracksClientConnection hcc;
+IHyracksDataset hds;
+
+try {
+HyracksProperties hp = new HyracksProperties();
+String strIP = hp.getHyracksIPAddress();
+int port = hp.getHyracksPort();
+
+synchronized (context) {
+hcc = (IHyracksClientConnection) 
context.getAttribute(HYRACKS_CONNECTION_ATTR);
+if (hcc == null) {
+hcc = new HyracksConnection(strIP, port);
+context.setAttribute(HYRACKS_CONNECTION_ATTR, hcc);
+}
+
+hds = (IHyracksDataset) 
context.getAttribute(HYRACKS_DATASET_ATTR);
+if (hds == null) {
+hds = new HyracksDataset(hcc, ResultReader.FRAME_SIZE, 
ResultReader.NUM_READERS);
+context.setAttribute(HYRACKS_DATASET_ATTR, hds);
+}
+}
+JSONObject handleObj = new JSONObject(strHandle);
+JSONArray handle = handleObj.getJSONArray("handle");
+JobId jobId = new JobId(handle.getLong(0));
+ResultSetId rsId = new ResultSetId(handle.getLong(1));
+
+ResultReader 

Change in asterixdb[master]: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1487: fix the wrong plan for inverted fuzzyjoin.
..


Patch Set 11:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1119/11//COMMIT_MSG
Commit Message:

Line 10: 2. Disable the join branch pruning in case of unnestmap following 
datasourcescan.
Can you add more explanation on " unnestmap following datasourcescan"?  

What does it mean?  An index join?  Why it needs to disable the join branch 
pruning?


Line 11: 
Remove local commit history in the commit message.


https://asterix-gerrit.ics.uci.edu/#/c/1119/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java:

Line 188: // The pre-plan is (broadcast B and index search on A on each 
A.a ~= B.b) join B on A.a = B.b
> for $d in dataset A
Can you add the explanation as a comment in the code?  Particularly, explain 
why the addition if-branch here is necessary and what happens if the if-branch 
is not added.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1119
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li 
Gerrit-Reviewer: Chen Li 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Wenhai Li 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Add Default Dataverse and AnyObject Datatype

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1174

to look at the new patch set (#3).

Change subject: Add Default Dataverse and AnyObject Datatype
..

Add Default Dataverse and AnyObject Datatype

Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/types/any-object/any-object.3.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-installer/src/test/resources/integrationts/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/TypeReferenceExpression.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
A 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBuiltinEntities.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataConstants.java
M 
asterixdb/asterix-yarn/src/test/resources/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm
24 files changed, 473 insertions(+), 153 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/74/1174/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1174
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Add Default Dataverse and AnyObject Datatype

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Default Dataverse and AnyObject Datatype
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2654/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1174
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Default Dataverse and AnyObject Datatype

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1174

to look at the new patch set (#2).

Change subject: Add Default Dataverse and AnyObject Datatype
..

Add Default Dataverse and AnyObject Datatype

Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/TypeTranslator.java
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta01/meta01.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_datatype/metadata_datatype.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataverse/metadata_dataverse.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.1.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.2.update.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/types/any-object/any-object.3.query.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/any-object/any-object.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/types/any-object/any-object.3.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M 
asterixdb/asterix-installer/src/test/resources/integrationts/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/expression/TypeReferenceExpression.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
A 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBuiltinEntities.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataConstants.java
M 
asterixdb/asterix-yarn/src/test/resources/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm
24 files changed, 460 insertions(+), 138 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/74/1174/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1174
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Add Default Dataverse and AnyObject Datatype

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Add Default Dataverse and AnyObject Datatype
..


Patch Set 1:

@Till,
Not sure. I will give it a try and add a test case.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1174
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02c74c8b005dce73888afd4dfe19ede2c60a8e8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Log ResultStateSweeper As Finer, Test Default Level->INFO

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Log ResultStateSweeper As Finer, Test Default Level->INFO
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/649/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1176
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e9408590734694ce1fa5840783adee8d7ce695
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Remove Dup FieldAccessByNameDescriptor.FACTORY Reference

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Remove Dup FieldAccessByNameDescriptor.FACTORY Reference
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/648/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1177
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bbc44a6b474720b7ac59082940c5f55368afef4
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No