Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/854/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/853/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5
Jenkins has posted comments on this change. Change subject: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5 .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/852/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1253 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd082fa9877f3f0287c9dc17eab4ae3d0f318fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2931/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 3: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 7: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1251 to look at the new patch set (#3). Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantVariablesRule.java 11 files changed, 252 insertions(+), 27 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/51/1251/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2930/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1247 to look at the new patch set (#7). Change subject: Wait For Metadata Registration Before Active, Etc. .. Wait For Metadata Registration Before Active, Etc. Also: - metadata.port moved to [app]; honored - += metadata.node to [app] to optionally specify metadata node - += metadata.callback.port to [app] - Decrease timeout for metadata registration from 7 days to default of one minute, configurable with property - Log swallowed exception in SynchronizableWork - Add missing properties (metadata) to cluster state http api - Make AsterixPropertiesAccessor, to ensure consistent values when accessed in virtual cluster Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 --- M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActiveManagerMessage.java M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixMetadataProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/IMetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IAsterixStateProxy.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReplicaEventMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AsterixAppContextInfo.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java M asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IClusterLifecycleListener.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCDriver.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java M
Change in asterixdb[master]: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5
Jenkins has posted comments on this change. Change subject: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5 .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1253 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd082fa9877f3f0287c9dc17eab4ae3d0f318fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5
Jenkins has posted comments on this change. Change subject: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5 .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2929/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1253 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd082fa9877f3f0287c9dc17eab4ae3d0f318fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5
Michael Blow has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1253 Change subject: Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5 .. Update Dependencies: Junit *->4.12, Commons-IO 2.4->2.5 Change-Id: Idd082fa9877f3f0287c9dc17eab4ae3d0f318fcc --- M asterixdb/asterix-client-helper/pom.xml M asterixdb/pom.xml M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml M hyracks-fullstack/pom.xml 4 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/53/1253/1 diff --git a/asterixdb/asterix-client-helper/pom.xml b/asterixdb/asterix-client-helper/pom.xml index e082629..a078d16 100644 --- a/asterixdb/asterix-client-helper/pom.xml +++ b/asterixdb/asterix-client-helper/pom.xml @@ -100,12 +100,10 @@ commons-io commons-io - 2.4 org.json json - 20090211 diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml index 6cbe20a..2e9f859 100644 --- a/asterixdb/pom.xml +++ b/asterixdb/pom.xml @@ -66,8 +66,8 @@ 0.2.18-SNAPSHOT 0.2.18-SNAPSHOT 2.2.0 -4.11 -2.4 +4.12 +2.5 3.1.0 20090211 0.7.6.201602180812 diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml index ac7323c..223aa9e 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml @@ -35,13 +35,11 @@ org.apache.hyracks hyracks-api ${project.version} - jar compile commons-io commons-io - jar compile diff --git a/hyracks-fullstack/pom.xml b/hyracks-fullstack/pom.xml index 1a0ed20..d70e917 100644 --- a/hyracks-fullstack/pom.xml +++ b/hyracks-fullstack/pom.xml @@ -55,8 +55,8 @@ 2.2.0 -4.8.1 -2.4 +4.12 +2.5 0.7.6.201602180812 -- To view, visit https://asterix-gerrit.ics.uci.edu/1253 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idd082fa9877f3f0287c9dc17eab4ae3d0f318fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 6: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2928/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Remove Conflicting Servlet API From Install Repo
Jenkins has posted comments on this change. Change subject: Remove Conflicting Servlet API From Install Repo .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1252 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88795f3b805d09f83950bbf24fff0e5caed79ef4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1247 to look at the new patch set (#6). Change subject: Wait For Metadata Registration Before Active, Etc. .. Wait For Metadata Registration Before Active, Etc. Also: - metadata.port moved to [app]; honored - += metadata.node to [app] to optionally specify metadata node - += metadata.callback.port to [app] - Decrease timeout for metadata registration from 7 days to default of one minute, configurable with property - Log swallowed exception in SynchronizableWork - Add missing properties (metadata) to cluster state http api - Make AsterixPropertiesAccessor, to ensure consistent values when accessed in virtual cluster Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 --- M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActiveManagerMessage.java M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixMetadataProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/IMetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IAsterixStateProxy.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReplicaEventMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AsterixAppContextInfo.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java M asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IClusterLifecycleListener.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCDriver.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java M
Change in asterixdb[master]: Remove Conflicting Servlet API From Install Repo
Michael Blow has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1252 Change subject: Remove Conflicting Servlet API From Install Repo .. Remove Conflicting Servlet API From Install Repo Outdated servlet jars are getting included in repo by way of Hadoop dependencies. Refactor some test dependencies in hyracks-hdfs to live in tests, and exclude problematic dependencies in asterix-external-data Change-Id: I88795f3b805d09f83950bbf24fff0e5caed79ef4 --- M asterixdb/asterix-external-data/pom.xml M hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/pom.xml R hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/src/test/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java M hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml R hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/src/test/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java M hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-core/pom.xml 6 files changed, 167 insertions(+), 9 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/52/1252/1 diff --git a/asterixdb/asterix-external-data/pom.xml b/asterixdb/asterix-external-data/pom.xml index c3cf3c4..245f340 100644 --- a/asterixdb/asterix-external-data/pom.xml +++ b/asterixdb/asterix-external-data/pom.xml @@ -244,10 +244,26 @@ hadoop-client jar compile + + + com.sun.jersey.jersey-test-framework + jersey-test-framework-grizzly2 + + org.apache.hadoop hadoop-hdfs + + + javax.servlet.jsp + jsp-api + + + javax.servlet + servlet-api + + net.java.dev.rome diff --git a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/pom.xml b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/pom.xml index 9e8d185..254fc87 100644 --- a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/pom.xml @@ -30,6 +30,23 @@ ${basedir}/../../.. + + + +org.apache.maven.plugins +maven-jar-plugin +2.4 + + + + test-jar + + + + + + + @@ -49,7 +66,7 @@ hadoop-test 0.20.2 jar - compile + test @@ -75,14 +92,14 @@ hadoop-minicluster 1.0.4 jar - compile + test org.apache.hadoop hadoop-test 1.0.4 jar - compile + test diff --git a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/src/main/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/src/test/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java similarity index 100% rename from hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/src/main/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java rename to hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-1.x/src/test/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java diff --git a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml index 7cca256..dbe9858 100644 --- a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml @@ -30,6 +30,23 @@ ${basedir}/../../.. + + + +org.apache.maven.plugins +maven-jar-plugin +2.4 + + + + test-jar + + + + + + + @@ -63,7 +80,7 @@ org.apache.hadoop hadoop-minicluster jar - compile + test @@ -99,7 +116,7 @@ org.apache.hadoop hadoop-minicluster jar - compile + test @@ -139,7 +156,7 @@ hadoop-minicluster 0.23.6 jar - compile + test @@ -179,7 +196,7 @@ hadoop-minicluster 2.0.0-cdh4.2.0 jar - compile + test @@ -219,7 +236,7 @@ hadoop-minicluster 2.0.0-cdh4.1.0 jar - compile + test diff --git a/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/src/main/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java b/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/src/test/java/org/apache/hyracks/hdfs/MiniDFSClusterFactory.java similarity index
Change in asterixdb[master]: tiny cleanup
Jenkins has posted comments on this change. Change subject: tiny cleanup .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/851/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1250 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5263537acff90a0a02b25dd26371760cba9fb665 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jenkins has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 13: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/850/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 5: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2926/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1247 to look at the new patch set (#5). Change subject: Wait For Metadata Registration Before Active, Etc. .. Wait For Metadata Registration Before Active, Etc. Also: - metadata.port moved to [app]; honored - += metadata.node to [app] to optionally specify metadata node - += metadata.callback.port to [app] - Decrease timeout for metadata registration from 7 days to default of one minute, configurable with property - Log swallowed exception in SynchronizableWork - Add missing properties (metadata) to cluster state http api - Make AsterixPropertiesAccessor, to ensure consistent values when accessed in virtual cluster Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 --- M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActiveManagerMessage.java M asterixdb/asterix-active/src/main/java/org/apache/asterix/active/message/ActivePartitionMessage.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java M asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixMetadataProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/IApplicationMessage.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/metadata/IMetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IAsterixStateProxy.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/CompleteFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/PreparePartitionsFailbackResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReplicaEventMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportMaxResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ResourceIdRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverMetadataNodeResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsRequestMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TakeoverPartitionsResponseMessage.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/AsterixAppContextInfo.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java M asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IClusterLifecycleListener.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCDriver.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/application/CCApplicationContext.java M
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jenkins has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 13: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/850/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Michael Blow has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java: Line 52: break; > Should we log when we start/quit the thread? Might be interesting to be abl Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java: Line 89: private static final Logger LOGGER = Logger.getLogger(MetadataManager.class.getName()); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java: Line 677: void setRebindMetadataNode(boolean rebindMetadataNode); > Do we need all those here? Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java: Line 58: public IMetadataNode getMetadataNode() { > Does anybody use this? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Hello Jianfeng Jia, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1196 to look at the new patch set (#13). Change subject: Index-only plan step 2: Added SplitOperator .. Index-only plan step 2: Added SplitOperator - Introduced SplitOperator that sends a tuple to only one output frame unlike the ReplicateOperator that propagates a tuple into all outputs frames. - Removed PartitioningSplitOperator and PartitioningSplitOperatorDescriptor that are not functional (lacking physical operator) - Added a unit test case of SplitOperatorDescriptor in PushRuntimeTest. Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/LogicalOperatorTag.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/PhysicalOperatorTag.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractReplicateOperator.java D hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/PartitioningSplitOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ReplicateOperator.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SplitOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/CardinalityInferenceVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/FDsAndEquivClassesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismOperatorVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismVariableMappingVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalOperatorDeepCopyWithNewVariablesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalPropertiesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/OperatorDeepCopyVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/PrimaryKeyVariablesVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/ProducedVariableVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SchemaVariableVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SubstituteVariableVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AbstractReplicatePOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/ReplicatePOperator.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/SplitPOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/visitors/ILogicalOperatorVisitor.java M
Change in asterixdb[master]: Tests for ASTERIXDB-1636
Jenkins has posted comments on this change. Change subject: Tests for ASTERIXDB-1636 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/849/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1521f1d53121b6768ac123e49e731932c85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian MaxonGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 2: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2924/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1251 to look at the new patch set (#2). Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/subquery/query-ASTERIXDB-1674/query-ASTERIXDB-1674.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantVariablesRule.java 11 files changed, 251 insertions(+), 27 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/51/1251/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins
Change in asterixdb[master]: tiny cleanup
Jenkins has posted comments on this change. Change subject: tiny cleanup .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/847/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1250 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5263537acff90a0a02b25dd26371760cba9fb665 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundant...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1674: fix LoadRecordFieldsRule and RemoveRedundantVariablesRule. .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1251 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52b2e3afac5ea99c13723cfc707821f95220a54a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jianfeng Jia has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 12: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Tests for ASTERIXDB-1636
Jenkins has posted comments on this change. Change subject: Tests for ASTERIXDB-1636 .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/848/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1521f1d53121b6768ac123e49e731932c85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian MaxonGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/846/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Tests for ASTERIXDB-1636
Jenkins has posted comments on this change. Change subject: Tests for ASTERIXDB-1636 .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2922/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1521f1d53121b6768ac123e49e731932c85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian MaxonGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Tests for ASTERIXDB-1636
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1248 to look at the new patch set (#2). Change subject: Tests for ASTERIXDB-1636 .. Tests for ASTERIXDB-1636 This is a test for the scenario described in the Jira issue. The only thing I have taken liberty with is changing the socket feed to a file one. The test case fails when I revert AqlMetadataProvider to the previous version, and should pass now with this parent. Change-Id: Ic1521f1d53121b6768ac123e49e731932c85 --- A asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java A asterixdb/asterix-installer/src/test/resources/integrationts/restart/828.h1w.adm A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.1.ddl.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.10.script.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.11.script.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.2.ddl.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.3.script.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.4.ddl.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.5.mgx.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.6.mgx.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.7.script.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.8.ddl.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.9.sleep.aql A asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/cat.sh A asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/grep_log.sh A asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/kill_cc_and_nc.sh A asterixdb/asterix-installer/src/test/resources/integrationts/restart/scripts/feed-restart/issue-1636/touch.sh A asterixdb/asterix-installer/src/test/resources/integrationts/restart/testsuite.xml A asterixdb/asterix-installer/src/test/resources/integrationts/restart/tweets.json 19 files changed, 10,301 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/48/1248/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic1521f1d53121b6768ac123e49e731932c85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian MaxonGerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIXDB-1566: Fixed External Hash Group By to conform to t...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget .. Patch Set 17: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/844/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls .. Patch Set 9: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1057 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven JacobsGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2921/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1057 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven JacobsGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Steven Jacobs Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure ...
Hello Michael Blow, Preston Carman, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1057 to look at the new patch set (#9). Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls .. ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls This fix makes it so that nonpure functions are called in the same place and with the same number of executions as specified by the user in the query. This also means that indexes cannot be used for queries that compare with a nonpure call that is made on a per-record basis. Added optimizer tests Change-Id: I2dec322b30835625430c06acd7626d902bada137 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableFuncExpr.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-no-index.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-use-index-return-time.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/global-datetime-use-index.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/keep-datetime-local.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/local-datetime-ignore-index.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/local-datetime-no-index.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/maintain-nonpure-location-in-join-cannot-index.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nonpure/query-ASTERIXDB-1608.aql M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index/btree-datetime-02.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-no-index.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-use-index-return-time.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/global-datetime-use-index.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/keep-datetime-local.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/local-datetime-ignore-index.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/local-datetime-no-index.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/maintain-nonpure-location-in-join-cannot-index.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/query-ASTERIXDB-1608.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query_issue849.plan M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ConsolidateAssignsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonExpressionsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushMapOperatorDownThroughProductRule.java M
Change in asterixdb[master]: tiny cleanup
Jenkins has posted comments on this change. Change subject: tiny cleanup .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2920/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1250 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5263537acff90a0a02b25dd26371760cba9fb665 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2919/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Till Westmann has submitted this change and it was merged. Change subject: Fix potential hanging in op.initialize(). .. Fix potential hanging in op.initialize(). - Let initialize()/deinitialize() always pair up. Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Reviewed-on: https://asterix-gerrit.ics.uci.edu/1243 Tested-by: JenkinsIntegration-Tests: Jenkins Reviewed-by: Till Westmann --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobFailureTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java 4 files changed, 57 insertions(+), 22 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; Verified Objections: Jenkins: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java index 4ee8303..3e557a2 100644 --- a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java +++ b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java @@ -20,12 +20,13 @@ package org.apache.hyracks.api.rewriter.runtime; import java.util.ArrayList; +import java.util.Arrays; import java.util.HashMap; import java.util.LinkedList; import java.util.List; import java.util.Map; -import java.util.Map.Entry; import java.util.Queue; +import java.util.Map.Entry; import java.util.concurrent.Callable; import java.util.concurrent.Future; @@ -56,6 +57,7 @@ private final int partition; private final int nPartitions; private int inputArity = 0; +private boolean[] startedInitialization; public SuperActivityOperatorNodePushable(SuperActivity parent, Map startActivities, IHyracksTaskContext ctx, IRecordDescriptorProvider recordDescProvider, int partition, int nPartitions) { @@ -79,8 +81,11 @@ @Override public void initialize() throws HyracksDataException { -// Initializes all OperatorNodePushables in parallel. -runInParallel(op -> op.initialize()); +// Initializes all OperatorNodePushables in parallel and then finally deinitializes them. +runInParallel((op, index) -> { +startedInitialization[index] = true; +op.initialize(); +}); } public void init() throws HyracksDataException { @@ -150,12 +155,19 @@ } } } + +// Sets the startedInitialization flags to be false. +startedInitialization = new boolean[operatorNodePushablesBFSOrder.size()]; +Arrays.fill(startedInitialization, false); } @Override public void deinitialize() throws HyracksDataException { -// De-initialize all OperatorNodePushables in parallel. -runInParallel(op -> op.deinitialize()); +runInParallel((op, index) -> { +if (startedInitialization[index]) { +op.deinitialize(); +} +}); } @Override @@ -191,18 +203,21 @@ } interface OperatorNodePushableAction { -public void runAction(IOperatorNodePushable op) throws HyracksDataException; +void runAction(IOperatorNodePushable op, int opIndex) throws HyracksDataException; } -private void runInParallel(OperatorNodePushableAction opAction) throws HyracksDataException { -List initializationTasks = new ArrayList (); +private void runInParallel(OperatorNodePushableAction opAction) +throws HyracksDataException { +List initializationTasks = new ArrayList<>(); try { +int index = 0; // Run one action for all OperatorNodePushables in parallel through a thread pool. for (final IOperatorNodePushable op : operatorNodePushablesBFSOrder) { +final int opIndex = index++; initializationTasks.add(ctx.getExecutorService().submit(new Callable() { @Override public Void call() throws Exception { -opAction.runAction(op); +opAction.runAction(op, opIndex);
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Till Westmann has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 7: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jenkins has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 12: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/845/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566: Fixed External Hash Group By to conform to t...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget .. Patch Set 17: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/844/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jenkins has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2918/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Index-only plan step 2: Added SplitOperator
Jenkins has posted comments on this change. Change subject: Index-only plan step 2: Added SplitOperator .. Patch Set 12: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1196 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice190827513cd8632764b52c9d0338d65c830740 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566: Fixed External Hash Group By to conform to t...
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget .. Patch Set 17: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1566: Fixed External Hash Group By to conform to t...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1056 to look at the new patch set (#17). Change subject: ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget .. ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget - External Hash Group By now conforms to the memory budget (compiler.groupmemory) - The number of hash entries (hash table size) is calculated based on an estimation of the aggregated tuple size and possible hash values for the given field size in that tuple. - Garbage Collection feature has been added to SerializableHashTable. For external hash group-by, whenever we spill a data partition to the disk, we also check the ratio of garbage in the hash table. If it's greater than the given threshold, we conduct a GC on Hash Table. Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java M hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IFramePool.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/PreferToSpillFullyOccupiedFramePolicy.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFramePool.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/ISpillableTable.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/external/ExternalHashGroupBy.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTableTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/unit/AbstractExternalGroupbyTest.java 15 files changed, 817 insertions(+), 180 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/56/1056/17 -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo KimGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/843/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add test TPC-DS data and 35 TPC-DS queries.
Yingyi Bu has posted comments on this change. Change subject: Add test TPC-DS data and 35 TPC-DS queries. .. Patch Set 5: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 3: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/840/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/843/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Add test TPC-DS data and 35 TPC-DS queries.
Jenkins has posted comments on this change. Change subject: Add test TPC-DS data and 35 TPC-DS queries. .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/842/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2916/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Hello abdullah alamoudi, Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1243 to look at the new patch set (#7). Change subject: Fix potential hanging in op.initialize(). .. Fix potential hanging in op.initialize(). - Let initialize()/deinitialize() always pair up. Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobFailureTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java 4 files changed, 57 insertions(+), 22 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1243/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Add test TPC-DS data and 35 TPC-DS queries.
Jenkins has posted comments on this change. Change subject: Add test TPC-DS data and 35 TPC-DS queries. .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/842/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [asterix] -> [app] for NCService configs
Michael Blow has submitted this change and it was merged. Change subject: [asterix] -> [app] for NCService configs .. [asterix] -> [app] for NCService configs Change-Id: Ie7bcc249b117bffb5671d087cd1760ef6a85110a Reviewed-on: https://asterix-gerrit.ics.uci.edu/1246 Sonar-Qube: JenkinsTested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java M asterixdb/asterix-server/src/main/samples/local/conf/cc.conf M asterixdb/asterix-server/src/test/resources/NCServiceExecutionIT/cc.conf 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; No violations found; Verified diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java index ea1ee31..61cb618 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java @@ -286,7 +286,14 @@ p = asterixConfigurationParams.get(property); value = (p == null) ? null : p.getValue(); } else { -value = cfg.getString("asterix", property); +value = cfg.getString("app", property); +if (value == null) { +value = cfg.getString("asterix", property); +if (value != null) { +LOGGER.warn("[asterix] config section deprecated and will be removed in a future release;" + +" please update to [app] (found: " + property + ')'); +} +} } if (value == null) { return defaultValue; diff --git a/asterixdb/asterix-server/src/main/samples/local/conf/cc.conf b/asterixdb/asterix-server/src/main/samples/local/conf/cc.conf index 5ef1cbf..b5f05d3 100644 --- a/asterixdb/asterix-server/src/main/samples/local/conf/cc.conf +++ b/asterixdb/asterix-server/src/main/samples/local/conf/cc.conf @@ -17,5 +17,5 @@ [cc] cluster.address = 127.0.0.1 -[asterix] +[app] log.level=INFO diff --git a/asterixdb/asterix-server/src/test/resources/NCServiceExecutionIT/cc.conf b/asterixdb/asterix-server/src/test/resources/NCServiceExecutionIT/cc.conf index c4c76e6..c69873c 100644 --- a/asterixdb/asterix-server/src/test/resources/NCServiceExecutionIT/cc.conf +++ b/asterixdb/asterix-server/src/test/resources/NCServiceExecutionIT/cc.conf @@ -20,6 +20,6 @@ cluster.address = 127.0.0.1 app.class=org.apache.asterix.hyracks.bootstrap.CCApplicationEntryPoint -[asterix] +[app] storage.memorycomponent.globalbudget = 1073741824 -- To view, visit https://asterix-gerrit.ics.uci.edu/1246 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7bcc249b117bffb5671d087cd1760ef6a85110a Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: Add test TPC-DS data and 35 TPC-DS queries.
Jenkins has posted comments on this change. Change subject: Add test TPC-DS data and 35 TPC-DS queries. .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2915/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Add test TPC-DS data and 37 TPC-DS queries.
Jenkins has posted comments on this change. Change subject: Add test TPC-DS data and 37 TPC-DS queries. .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/841/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2914/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Hello abdullah alamoudi, Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1243 to look at the new patch set (#6). Change subject: Fix potential hanging in op.initialize(). .. Fix potential hanging in op.initialize(). - Let initialize()/deinitialize() always be called in the same thread and pair up. Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobFailureTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java 4 files changed, 48 insertions(+), 21 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1243/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2913/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Hello abdullah alamoudi, Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1243 to look at the new patch set (#5). Change subject: Fix potential hanging in op.initialize(). .. Fix potential hanging in op.initialize(). - Let initialize()/deinitialize() always be called in the same thread and pair up. Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobFailureTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java 4 files changed, 48 insertions(+), 21 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1243/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2912/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Hello abdullah alamoudi, Michael Blow, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1243 to look at the new patch set (#4). Change subject: Fix potential hanging in op.initialize(). .. Fix potential hanging in op.initialize(). - Let initialize()/deinitialize() always be called in the same thread and pair up. Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 --- M hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/JobFailureTest.java M hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java 4 files changed, 47 insertions(+), 20 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/1243/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/840/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Add test TPC-DS data and 37 TPC-DS queries.
Jenkins has posted comments on this change. Change subject: Add test TPC-DS data and 37 TPC-DS queries. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2911/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1195 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3389ee8cce7b54a0121477411842feca66480d48 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Vignesh RaghunathanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Vignesh Raghunathan Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-1673) ARecordCaster potential object creation problem
[ https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546100#comment-15546100 ] Yingyi Bu commented on ASTERIXDB-1673: -- Cool, thx, [~wyk]! > ARecordCaster potential object creation problem > --- > > Key: ASTERIXDB-1673 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB, Data Model >Reporter: Wail Alkowaileet >Assignee: Wail Alkowaileet >Priority: Trivial > > I use ACastVIsitor extensively in my work and I found that on > loadRequiredType: > The allocator will keep allocating Pointables (for typetag and fieldNames) > which would never be cleared. > I ran an experiment and got more than 6 million objects on a dataset of size > 1.5GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1673) ARecordCaster potential object creation problem
[ https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546028#comment-15546028 ] Yingyi Bu commented on ASTERIXDB-1673: -- [~wyk], got it. Not sure how ARecordCaster fits for the tuple-level compaction, but I can guess you can fix loadRequiredType() to reuse objects. > ARecordCaster potential object creation problem > --- > > Key: ASTERIXDB-1673 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB, Data Model >Reporter: Wail Alkowaileet >Assignee: Wail Alkowaileet >Priority: Trivial > > I use ACastVIsitor extensively in my work and I found that on > loadRequiredType: > The allocator will keep allocating Pointables (for typetag and fieldNames) > which would never be cleared. > I ran an experiment and got more than 6 million objects on a dataset of size > 1.5GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (ASTERIXDB-1671) Order by + Limit 0 results in NPE
[ https://issues.apache.org/jira/browse/ASTERIXDB-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingyi Bu closed ASTERIXDB-1671. Resolution: Fixed Fixed with regression tests. > Order by + Limit 0 results in NPE > - > > Key: ASTERIXDB-1671 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1671 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Yingyi Bu >Assignee: Yingyi Bu > > query: > {noformat} > select * from Metadata.`Dataset` order by DatasetName limit 0; > {noformat} > stack trace: > {noformat} > Caused by: java.lang.NullPointerException > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort$HeapEntry.reset(TupleSorterHeapSort.java:102) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort$HeapEntry.reset(TupleSorterHeapSort.java:57) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.structures.MaxHeap.peekMax(MaxHeap.java:58) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort.insertTuple(TupleSorterHeapSort.java:159) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.HybridTopKSortRunGenerator.nextFrame(HybridTopKSortRunGenerator.java:74) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.AbstractSorterOperatorDescriptor$SortActivity$1.nextFrame(AbstractSorterOperatorDescriptor.java:125) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:92) > ~[hyracks-dataflow-common-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:63) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:69) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:55) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$2.close(AlgebricksMetaOperatorDescriptor.java:153) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.storage.am.common.dataflow.IndexSearchOperatorNodePushable.close(IndexSearchOperatorNodePushable.java:230) > ~[hyracks-storage-am-common-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:60) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$1.initialize(AlgebricksMetaOperatorDescriptor.java:116) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$initialize$0(SuperActivityOperatorNodePushable.java:83) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$$Lambda$10/1701417721.runAction(Unknown > Source) ~[?:?] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:205) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:202) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ASTERIXDB-1671) Order by + Limit 0 results in NPE
[ https://issues.apache.org/jira/browse/ASTERIXDB-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545990#comment-15545990 ] ASF subversion and git services commented on ASTERIXDB-1671: Commit 6adeec2d19f0051d5696f9453e52b86e7a02461d in asterixdb's branch refs/heads/master from [~buyingyi] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=6adeec2 ] ASTERIXDB-1671: fix non-positive limit with order by. Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Reviewed-on: https://asterix-gerrit.ics.uci.edu/1240 Sonar-Qube: JenkinsTested-by: Jenkins Reviewed-by: Till Westmann Integration-Tests: Jenkins Reviewed-by: Taewoo Kim > Order by + Limit 0 results in NPE > - > > Key: ASTERIXDB-1671 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1671 > Project: Apache AsterixDB > Issue Type: Bug >Reporter: Yingyi Bu >Assignee: Yingyi Bu > > query: > {noformat} > select * from Metadata.`Dataset` order by DatasetName limit 0; > {noformat} > stack trace: > {noformat} > Caused by: java.lang.NullPointerException > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort$HeapEntry.reset(TupleSorterHeapSort.java:102) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort$HeapEntry.reset(TupleSorterHeapSort.java:57) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.structures.MaxHeap.peekMax(MaxHeap.java:58) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.TupleSorterHeapSort.insertTuple(TupleSorterHeapSort.java:159) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.HybridTopKSortRunGenerator.nextFrame(HybridTopKSortRunGenerator.java:74) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.std.sort.AbstractSorterOperatorDescriptor$SortActivity$1.nextFrame(AbstractSorterOperatorDescriptor.java:125) > ~[hyracks-dataflow-std-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.dataflow.common.comm.io.AbstractFrameAppender.write(AbstractFrameAppender.java:92) > ~[hyracks-dataflow-common-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushAndReset(AbstractOneInputOneOutputOneFramePushRuntime.java:63) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.flushIfNotFailed(AbstractOneInputOneOutputOneFramePushRuntime.java:69) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.base.AbstractOneInputOneOutputOneFramePushRuntime.close(AbstractOneInputOneOutputOneFramePushRuntime.java:55) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$2.close(AlgebricksMetaOperatorDescriptor.java:153) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.storage.am.common.dataflow.IndexSearchOperatorNodePushable.close(IndexSearchOperatorNodePushable.java:230) > ~[hyracks-storage-am-common-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.std.EmptyTupleSourceRuntimeFactory$1.close(EmptyTupleSourceRuntimeFactory.java:60) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.algebricks.runtime.operators.meta.AlgebricksMetaOperatorDescriptor$1.initialize(AlgebricksMetaOperatorDescriptor.java:116) > ~[algebricks-runtime-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable.lambda$initialize$0(SuperActivityOperatorNodePushable.java:83) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$$Lambda$10/1701417721.runAction(Unknown > Source) ~[?:?] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:205) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] > at > org.apache.hyracks.api.rewriter.runtime.SuperActivityOperatorNodePushable$1.call(SuperActivityOperatorNodePushable.java:202) > ~[hyracks-api-0.2.18-SNAPSHOT.jar:0.2.18-SNAPSHOT] >
Change in asterixdb[master]: ASTERIXDB-1671: fix non-positive limit with order by.
Yingyi Bu has submitted this change and it was merged. Change subject: ASTERIXDB-1671: fix non-positive limit with order by. .. ASTERIXDB-1671: fix non-positive limit with order by. Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Reviewed-on: https://asterix-gerrit.ics.uci.edu/1240 Sonar-Qube: JenkinsTested-by: Jenkins Reviewed-by: Till Westmann Integration-Tests: Jenkins Reviewed-by: Taewoo Kim --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1671.plan A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671-2/query-ASTERIXDB-1671-2.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671-2/query-ASTERIXDB-1671-2.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671-2/query-ASTERIXDB-1671-2.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/misc/query-ASTERIXDB-1671/query-ASTERIXDB-1671.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/HybridTopKSortRunGenerator.java 12 files changed, 278 insertions(+), 4 deletions(-) Approvals: Taewoo Kim: Looks good to me, approved Till Westmann: Looks good to me, but someone else must approve Jenkins: Verified; No violations found; Verified diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java index b573ae4..4c0247f 100644 --- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java +++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java @@ -96,8 +96,6 @@ return false; } -boolean needToCheckOffsetValue = true; - // Get the LIMIT constant if (limitOp.getMaxObjects().getValue().getExpressionTag() == LogicalExpressionTag.CONSTANT) { // Currently, we support LIMIT with a constant value. @@ -106,6 +104,9 @@ // since the original external sort's performance might be better. if (topK > Integer.MAX_VALUE) { return false; +} +if (topK < 0) { +topK = 0; } } else { return false; @@ -116,7 +117,15 @@ // Final topK will be applied through LIMIT. if (limitOp.getOffset().getValue() != null) { if (limitOp.getOffset().getValue().getExpressionTag() == LogicalExpressionTag.CONSTANT) { -topK = topK + ((int) AccessMethodUtils.getInt64Constant(limitOp.getOffset())); +long offset = AccessMethodUtils.getInt64Constant(limitOp.getOffset()); +if (offset < 0) { +offset = 0; +} +// Check the overflow case. +if (offset >= Integer.MAX_VALUE - topK) { +return false; +} +topK += offset; } else { return false; } @@ -133,7 +142,6 @@ opRef2.setValue(newOrderOp); context.computeAndSetTypeEnvironmentForOperator(newOrderOp); context.addToDontApplySet(this, limitOp); - return true; } diff --git a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp new file mode 100644 index 000..33b40b2 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-1671.sqlpp @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0
[jira] [Commented] (ASTERIXDB-1673) ARecordCaster potential object creation problem
[ https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545981#comment-15545981 ] Yingyi Bu commented on ASTERIXDB-1673: -- Wail, why do you need to loadRequiredType many times? Typically, you have one required type for casting? > ARecordCaster potential object creation problem > --- > > Key: ASTERIXDB-1673 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB, Data Model >Reporter: Wail Alkowaileet >Assignee: Wail Alkowaileet >Priority: Trivial > > I use ACastVIsitor extensively in my work and I found that on > loadRequiredType: > The allocator will keep allocating Pointables (for typetag and fieldNames) > which would never be cleared. > I ran an experiment and got more than 6 million objects on a dataset of size > 1.5GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: ASTERIXDB-1671: fix non-positive limit with order by.
Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1671: fix non-positive limit with order by. .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1240 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: remove ini file on abnormal termination
Jenkins has posted comments on this change. Change subject: remove ini file on abnormal termination .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/839/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963825969bbe9e6e1ce686222b42d6e0f5769d28 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: remove ini file on abnormal termination
Jenkins has posted comments on this change. Change subject: remove ini file on abnormal termination .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/839/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963825969bbe9e6e1ce686222b42d6e0f5769d28 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: remove ini file on abnormal termination
Till Westmann has posted comments on this change. Change subject: remove ini file on abnormal termination .. Patch Set 1: TRIGGER: asterix-gerrit-integration-tests -- To view, visit https://asterix-gerrit.ics.uci.edu/1249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963825969bbe9e6e1ce686222b42d6e0f5769d28 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
[jira] [Updated] (ASTERIXDB-1673) ARecordCaster potential object creation problem
[ https://issues.apache.org/jira/browse/ASTERIXDB-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wail Alkowaileet updated ASTERIXDB-1673: Priority: Trivial (was: Major) I changed it into Trivial because this should not be a problem currently. > ARecordCaster potential object creation problem > --- > > Key: ASTERIXDB-1673 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673 > Project: Apache AsterixDB > Issue Type: Bug > Components: AsterixDB, Data Model >Reporter: Wail Alkowaileet >Assignee: Wail Alkowaileet >Priority: Trivial > > I use ACastVIsitor extensively in my work and I found that on > loadRequiredType: > The allocator will keep allocating Pointables (for typetag and fieldNames) > which would never be cleared. > I ran an experiment and got more than 6 million objects on a dataset of size > 1.5GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/838/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-1673) ARecordCaster potential object creation problem
Wail Alkowaileet created ASTERIXDB-1673: --- Summary: ARecordCaster potential object creation problem Key: ASTERIXDB-1673 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1673 Project: Apache AsterixDB Issue Type: Bug Components: AsterixDB, Data Model Reporter: Wail Alkowaileet Assignee: Wail Alkowaileet I use ACastVIsitor extensively in my work and I found that on loadRequiredType: The allocator will keep allocating Pointables (for typetag and fieldNames) which would never be cleared. I ran an experiment and got more than 6 million objects on a dataset of size 1.5GB. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Change in asterixdb[master]: Fix potential hanging in op.initialize().
abdullah alamoudi has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 3: Code-Review-1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
Jenkins has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/838/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1671: fix non-positive limit with order by.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1671: fix non-positive limit with order by. .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/837/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1240 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 2: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/834/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Update README.md: the maven version and local cluster setup.
Jenkins has posted comments on this change. Change subject: Update README.md: the maven version and local cluster setup. .. Patch Set 3: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/836/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1241 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c366f669bbcda23226f95840e6b4a1873847fff Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1671: fix non-positive limit with order by.
Jenkins has posted comments on this change. Change subject: ASTERIXDB-1671: fix non-positive limit with order by. .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/837/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1240 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id28218c100e4cca0f94e37eda82d3bc6ae78322f Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: remove ini file on abnormal termination
Jenkins has posted comments on this change. Change subject: remove ini file on abnormal termination .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/835/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963825969bbe9e6e1ce686222b42d6e0f5769d28 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: Update README.md: the maven version and local cluster setup.
Jenkins has posted comments on this change. Change subject: Update README.md: the maven version and local cluster setup. .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/836/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1241 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c366f669bbcda23226f95840e6b4a1873847fff Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: remove ini file on abnormal termination
Jenkins has posted comments on this change. Change subject: remove ini file on abnormal termination .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/835/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963825969bbe9e6e1ce686222b42d6e0f5769d28 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: fix tabs
Jenkins has posted comments on this change. Change subject: fix tabs .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/833/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1245 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f46ef62c2220def96dd1caa175284eef661e7b0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Wait For Metadata Registration Before Active, Etc.
Jenkins has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/834/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [asterix] -> [app] for NCService configs
Jenkins has posted comments on this change. Change subject: [asterix] -> [app] for NCService configs .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/832/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1246 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7bcc249b117bffb5671d087cd1760ef6a85110a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael BlowGerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Fix potential hanging in op.initialize().
abdullah alamoudi has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). .. Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1243/3/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java: Line 134: // should be executed. let's fix the comment and then: instead of using atomic integers, lets' use mutable static int[]s where the size = the number of partitions. we can set the int[]s before creating the jobs and then starts the job, each task will then work on its own createPushRuntime[partition], openCloseCounter[partition], and initializeCounter[partition]. then in succeed(), we can check that the values in all of the counters == 0. that is more precise and would tell us if exactly what we expect is happening. -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi BuGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: Adding three interval join algorithms.
Jenkins has posted comments on this change. Change subject: Adding three interval join algorithms. .. Patch Set 25: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/457 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d Gerrit-PatchSet: 25 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston CarmanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Adding three interval join algorithms.
Jenkins has posted comments on this change. Change subject: Adding three interval join algorithms. .. Patch Set 25: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2908/ -- To view, visit https://asterix-gerrit.ics.uci.edu/457 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d Gerrit-PatchSet: 25 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston CarmanGerrit-Reviewer: Jenkins Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: Adding three interval join algorithms.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/457 to look at the new patch set (#25). Change subject: Adding three interval join algorithms. .. Adding three interval join algorithms. The algorithms are based the following join approaches: sort-merge, partition-based, and index-based. The change includes an range connector used to partition ordered data. Change-Id: Id4f9be43eb0c500f04f99438c34e69503591641d --- A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/IntervalLocalRangeSplitterOperator.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/AbstractIntervalJoinPOperator.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalIndexJoinPOperator.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalLocalRangeOperatorDescriptor.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalLocalRangeSplitterPOperator.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IntervalPartitionJoinPOperator.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntervalSplitPartitioningRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SweepIllegalNonfunctionalFunctions.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineLeftNtsInSubplanJoinFlatteningVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanSpecialFlatteningCheckVisitor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/temporal/TranslateIntervalExpressionRule.java A asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/util/JoinUtils.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/test/resources/logging.properties M asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-numeric-desc.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-numeric.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-string-desc.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/range-connector/sort-hint-on-closed-string.plan M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by-exception_01/order-by-exception_01.4.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by-exception_02/order-by-exception_02.4.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.4.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.5.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.6.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/range-hints/order-by/order-by.7.query.aql D asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.1.query.aql D asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_functions/interval_functions.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.10.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.11.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.12.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.13.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.14.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/interval_joins/interval_before/interval_before.15.query.aql A
Change in asterixdb[master]: fix tabs
Jenkins has posted comments on this change. Change subject: fix tabs .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/833/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1245 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f46ef62c2220def96dd1caa175284eef661e7b0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till WestmannGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No