Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4278/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4: Contrib-1

Analytics Compatibility Tests Failed Build 2766
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


[NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove the hardcoded 64MB memory limit from
  ByteArrayAccessibleOutputStream as the limit
  shouldn't be controlled by this structure but
  rather by operators using it.

Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2073
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
1 file changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; ; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
 
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
index bf0e1dd..1a806cd 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
@@ -23,8 +23,7 @@
 
 public class ByteArrayAccessibleOutputStream extends ByteArrayOutputStream {
 
-private static final int MAX_SIZE = 1024 * 1024 * 32;
-private static final double BUFFER_INCREMENT_FACTOR = 1.5;
+private static final int MAX_ARRAY_SIZE = Integer.MAX_VALUE;
 
 public ByteArrayAccessibleOutputStream() {
 super();
@@ -97,22 +96,24 @@
 private void grow(int minCapacity) {
 // overflow-conscious code
 int oldCapacity = buf.length;
-if (oldCapacity == MAX_SIZE) {
-throw new IllegalArgumentException("Buffer is too large...");
-}
-int newCapacity = Math.min((int) (oldCapacity * 
BUFFER_INCREMENT_FACTOR), MAX_SIZE);
+// increase by a factor of 1.5
+int newCapacity = oldCapacity + (oldCapacity >> 1);
 if (newCapacity - minCapacity < 0) {
 newCapacity = minCapacity;
 }
-if (newCapacity < 0) {
-if (minCapacity < 0) {
-throw new OutOfMemoryError();
-}
-newCapacity = Integer.MAX_VALUE;
+if (newCapacity - MAX_ARRAY_SIZE > 0) {
+newCapacity = hugeCapacity(minCapacity);
 }
 buf = Arrays.copyOf(buf, newCapacity);
 }
 
+private static int hugeCapacity(int minCapacity) {
+if (minCapacity < 0) { // overflow
+throw new RuntimeException("Memory allocation limit (" + 
MAX_ARRAY_SIZE + " bytes) exceeded");
+}
+return (minCapacity > MAX_ARRAY_SIZE) ? Integer.MAX_VALUE : 
MAX_ARRAY_SIZE;
+}
+
 /**
  * Return the current length of this stream (not capacity).
  */

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1948/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1948/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4278/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1556/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1897/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2119/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1219/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1835/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5276/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1935/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6772/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1228/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2124] Throw NPE early

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2124] Throw NPE early
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1227/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2055
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84a458d2293450bce973788ac84b6fbc4c993a4a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6:

(4 comments)

Has this been benchmarked for memory consumption? I see a lot of places that 
look like to me, they will consume memory in proportion to the data perhaps...

https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java:

PS6, Line 49: OGCGeometry geometry = OGCGeometry
: 
.createFromOGCStructure(OperatorImportFromWkb.local().executeOGC(0, buffer, 
null),
: SpatialReference.create(4326))
What are the 0, null, and 4326 here for? Can we get them defined as static 
final variables if they indeed are?


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java:

Line 73: throw new RuntimeException(e);
> CRITICAL SonarQube violation:
+1, should throw something else preferably...


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/utils/NonTaggedFormatUtil.java:

PS6, Line 200: AInt32SerializerDeserializer
Wait, what? Why AInt32?


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java:

PS6, Line 66: geometry = new OGCPoint(new Point(), 
SpatialReference.create(4326));
: }
Again what is the 4326 about?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6: Contrib-1

Analytics Compatibility Tests Failed Build 2765
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1947/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1947/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data t...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2118/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful Build 2764
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4277/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1946/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1946/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-2131) An Aborted Metadata Txn Leads to Invalid Active Ops

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204810#comment-16204810
 ] 

ASF subversion and git services commented on ASTERIXDB-2131:


Commit e2cf9c2715b74d79cb2185ec862bd12d2bfbb7a5 in asterixdb's branch 
refs/heads/master from [~mhubail]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=e2cf9c2 ]

[ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Metadata Txn

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Do not reset the primary index operation tracker active operations
  count if the metadata transaction was aborted.
- Add test cases.

Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2071
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Ian Maxon 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 


> An Aborted Metadata Txn Leads to Invalid Active Ops
> ---
>
> Key: ASTERIXDB-2131
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2131
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: TX - Transactions
>Reporter: Murtadha Hubail
>Assignee: Murtadha Hubail
>Priority: Critical
>
> When a metadata transaction is aborted, the number of active operations on 
> the primary index are decremented twice, one time when the job abort log is 
> written and the other when the transaction completes its abortion. This will 
> result in the following exception when the index is accessed the next time:
> {code:java}
> Caused by: org.apache.hyracks.api.exceptions.HyracksDataException: The number 
> of active operations cannot be negative!
>   at 
> org.apache.asterix.common.context.PrimaryIndexOperationTracker.completeOperation(PrimaryIndexOperationTracker.java:85)
>  ~[asterix-common-0.9.3-SNAPSHOT.jar:0.9.3-SNAPSHOT]
>   at 
> org.apache.asterix.metadata.MetadataNode.deleteTupleFromIndex(MetadataNode.java:835)
>  ~[asterix-metadata-0.9.3-SNAPSHOT.jar:0.9.3-SNAPSHOT]
>   at 
> org.apache.asterix.metadata.MetadataNode.dropNodegroup(MetadataNode.java:734) 
> ~[asterix-metadata-0.9.3-SNAPSHOT.jar:0.9.3-SNAPSHOT]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


[ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Metadata Txn

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Do not reset the primary index operation tracker active operations
  count if the metadata transaction was aborted.
- Add test cases.

Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2071
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Ian Maxon 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionContext.java
4 files changed, 152 insertions(+), 1 deletion(-)

Approvals:
  Anon. E. Moose #1000171: 
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified
  Ian Maxon: Looks good to me, but someone else must approve



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index 71c67f4..f5e94b1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -121,6 +121,10 @@
 this.ncs = nodeControllers.toArray(new 
NodeControllerService[nodeControllers.size()]);
 }
 
+public ClusterControllerService getClusterControllerService() {
+return cc;
+}
+
 protected CCConfig createCCConfig(ConfigManager configManager) throws 
IOException {
 CCConfig ccConfig = new CCConfig(configManager);
 
ccConfig.setClusterListenAddress(Inet4Address.getLoopbackAddress().getHostAddress());
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
new file mode 100644
index 000..3969ec5
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.test.metadata;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.apache.asterix.api.common.AsterixHyracksIntegrationUtil;
+import org.apache.asterix.common.config.GlobalConfig;
+import org.apache.asterix.common.dataflow.ICcApplicationContext;
+import org.apache.asterix.metadata.MetadataManager;
+import org.apache.asterix.metadata.MetadataTransactionContext;
+import org.apache.asterix.metadata.bootstrap.MetadataBuiltinEntities;
+import org.apache.asterix.metadata.declared.MetadataProvider;
+import org.apache.asterix.metadata.entities.Dataset;
+import org.apache.asterix.metadata.entities.NodeGroup;
+import org.apache.asterix.metadata.utils.DatasetUtil;
+import org.apache.asterix.test.common.TestExecutor;
+import org.apache.asterix.testframework.context.TestCaseContext;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+public class MetadataTxnTest {
+
+private static final String TEST_CONFIG_FILE_NAME = 
"asterix-build-configuration.xml";
+private static final TestExecutor testExecutor = new TestExecutor();
+private static 

Change in asterixdb[master]: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted Met...

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2073/2/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
File 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java:

PS2, Line 112: OutOfMemoryError
> I'm not sure that we should throw Java's OOM here as that indicates that th
That does make sense. Since we are extending ByteArrayOutputStream and its 
write methods don't throw checked exceptions, I changed this to a 
RuntimeException with a custom message so one wouldn't get the indication that 
the JVM is OOM.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4277/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5275/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1896/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1834/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2117/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1226/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2073

to look at the new patch set (#3).

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..

[NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove the hardcoded 64MB memory limit from
  ByteArrayAccessibleOutputStream as the limit
  shouldn't be controlled by this structure but
  rather by operators using it.

Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
---
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/73/2073/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1934/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1218/ 
(10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1555/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6771/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

The change looks good. I've got one question on the use of OOM, but that is 
orthogonal to the content of the change.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2073/2/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
File 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java:

PS2, Line 112: OutOfMemoryError
I'm not sure that we should throw Java's OOM here as that indicates that the 
JVM wasn't able to allocate there memory (and thus the application maybe 
unstable as other threads might not have enough memory as well and potentially 
corrupted state). 
In this case we see the problem before affecting other threads and so it seems 
that we could just throw a regular exception here which will fail the job that 
caused the allocation, but not affect other threads.
Does that make sense or do we want the OOM behavior?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful Build 2763
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4276/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1945/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1945/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4276/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1: Contrib-1

Analytics Compatibility Tests Failed Build 2762
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5274/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2073

to look at the new patch set (#2).

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..

[NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove the hardcoded 64MB memory limit from
  ByteArrayAccessibleOutputStream as the limit
  shouldn't be controlled by this structure but
  rather by operators using it.

Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
---
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
1 file changed, 12 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/73/2073/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1554/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1895/
 (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1217/ 
(10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1933/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1226/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1225/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1833/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2116/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6770/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4275/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1944/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1944/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful Build 2761
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4275/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1224/
 (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1225/ 
(8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6769/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1553/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1216/ 
(10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1932/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1832/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1894/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2115/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5273/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessib...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2073

Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in 
ByteArrayAccessibleOutputStream
..

[NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove the hardcoded 64MB memory limit from
  ByteArrayAccessibleOutputStream as the limit
  shouldn't be controlled by this structure but
  rather by operators using it.

Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
---
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/73/2073/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
 
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
index bf0e1dd..0f39a90 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
@@ -23,8 +23,7 @@
 
 public class ByteArrayAccessibleOutputStream extends ByteArrayOutputStream {
 
-private static final int MAX_SIZE = 1024 * 1024 * 32;
-private static final double BUFFER_INCREMENT_FACTOR = 1.5;
+private static final float BUFFER_INCREMENT_FACTOR = 1.5f;
 
 public ByteArrayAccessibleOutputStream() {
 super();
@@ -97,10 +96,7 @@
 private void grow(int minCapacity) {
 // overflow-conscious code
 int oldCapacity = buf.length;
-if (oldCapacity == MAX_SIZE) {
-throw new IllegalArgumentException("Buffer is too large...");
-}
-int newCapacity = Math.min((int) (oldCapacity * 
BUFFER_INCREMENT_FACTOR), MAX_SIZE);
+int newCapacity = (int) (oldCapacity * BUFFER_INCREMENT_FACTOR);
 if (newCapacity - minCapacity < 0) {
 newCapacity = minCapacity;
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 

Change in asterixdb[master]: [NO ISSUE][CLUS] Prevent Possible Deadlock in GlobalRecovery...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Prevent Possible Deadlock in 
GlobalRecoveryManager
..


Patch Set 1:

Analytics Compatibility Tests Failed Build 2760
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2072
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0491a84fb24b428d5ce98f392adafc6dfacff9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No