Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Vijay Sarathy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 15: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/p7aXddkthvrNdJN48 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 15 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Sat, 27 Apr 2024 02:54:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Jenkins : Attention is currently required from: Vijay Sarathy. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 15: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/387/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 15 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Sat, 27 Apr 2024 01:52:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
Attention is currently required from: Vijay Sarathy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. Patch Set 15: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/xJ7TSZGaCUK2umYC7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 15 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Sat, 27 Apr 2024 00:45:20 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Vijay Sarathy : Attention is currently required from: Vijay Sarathy. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 to look at the new patch set (#15). Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly .. [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac --- M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-12.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-15.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-14.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-11.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-5.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinEnum.java D asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-7.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/JoinNode.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-16.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-7.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-4.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-10.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-3.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-13.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/SkipSecondaryIndexSearchExpressionAnnotation.java M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-10.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-16.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-13.plan M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/AbstractExpressionAnnotationWithIndexNames.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/IndexedNLJoinExpressionAnnotation.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/annotations/SecondaryIndexSearchPreferenceAnnotation.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-14.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/hints-indexnl-params/hints-indexnl-params-6.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-12.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-selection/hints-use-index/hints-use-index-11.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-selection/hints-use-index/hints-use-index-15.plan M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java D asterixdb/asterix-app/src/test/resources/optimizerts/results_cbo/btree-index-join/hints-indexnl-params/hints-indexnl-params-5.plan 35 files changed, 294 insertions(+), 296 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/77/18177/15 -- To view, visit
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
Attention is currently required from: Wail Alkowaileet, Savyasach Reddy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 8: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/wy2kTjanQtxUf36U6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Savyasach Reddy Gerrit-Comment-Date: Fri, 26 Apr 2024 19:30:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Jenkins : Attention is currently required from: Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 8: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/386/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 18:21:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Ali Alsuliman : Attention is currently required from: Vijay Sarathy. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 ) Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working correctly. .. Patch Set 14: (1 comment) File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/86e75939_fd6dc5d1 PS14, Line 564: || (annotationRemoved && (this instanceof IntroduceJoinAccessMethodRule)) Take it to an else part and then call: removeNonPreferredSecondaryIndexes(analysisCtx, Collections.empty()); Put a comment to explain why you are doing this -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac Gerrit-Change-Number: 18177 Gerrit-PatchSet: 14 Gerrit-Owner: Vijay Sarathy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Vijay Sarathy Gerrit-CC: Ali Alsuliman Gerrit-Attention: Vijay Sarathy Gerrit-Comment-Date: Fri, 26 Apr 2024 18:16:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Savyasach Reddy : Attention is currently required from: Wail Alkowaileet. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 8: (2 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/26f476ca_24457fbe PS6, Line 35: DELETE_BATCH_SIZE > Yes. https://cloud.google. […] Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/b8da7b60_0ea2ed31 PS6, Line 100: list > We will need the size. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 17:31:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet Comment-In-Reply-To: Savyasach Reddy Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
Attention is currently required from: Savyasach Reddy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 8: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/HRBRzMCpancDZ1Sr7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Savyasach Reddy Gerrit-Comment-Date: Fri, 26 Apr 2024 17:18:46 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3358][COMP] Indexnl hint with index names not working corr...
>From Ali Alsuliman :
Attention is currently required from: Vijay Sarathy.
Ali Alsuliman has posted comments on this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177 )
Change subject: [ASTERIXDB-3358][COMP] Indexnl hint with index names not
working correctly.
..
Patch Set 14:
(4 comments)
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/1e0ef55b_f286b625
PS14, Line 377:
Remove extra line.
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/52003737_ef666d2c
PS14, Line 626: applicableIndexNames != null
How can this ever be 'null'?
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/6ec7796b_23423954
PS14, Line 644: if (anno instanceof SecondaryIndexSearchPreferenceAnnotation) {
: param1 =
SecondaryIndexSearchPreferenceAnnotation.HINT_STRING;
: } else if (anno instanceof
IndexedNLJoinExpressionAnnotation) {
: param1 =
IndexedNLJoinExpressionAnnotation.HINT_STRING;
: }
I had a comment before about the use of instanceof and that it's not accurate.
You should add an abstract method in AbstractExpressionAnnotationWithIndexNames
and each subclass would just return their "HINT_STRING"
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177/comment/2816fb23_12db6bcf
PS14, Line 1071: public AbstractExpressionAnnotationWithIndexNames
getSecondaryIndexAnnotation
We shouldn't duplicate code here. You should change (and possibly rename) the
existing getSecondaryIndexPreferences to return the annotation. For the current
callers of getSecondaryIndexPreferences that want the names, they can get them
from the annotation itself.
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18177
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I603ae267efd137d4e9f3491be2a6bdcb1179eeac
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 14
Gerrit-Owner: Vijay Sarathy
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Vijay Sarathy
Gerrit-CC: Ali Alsuliman
Gerrit-Attention: Vijay Sarathy
Gerrit-Comment-Date: Fri, 26 Apr 2024 17:12:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[jira] [Updated] (ASTERIXDB-3386) Add config to specify percentage of runtime memory overhead
[ https://issues.apache.org/jira/browse/ASTERIXDB-3386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3386: - Labels: triaged (was: ) > Add config to specify percentage of runtime memory overhead > --- > > Key: ASTERIXDB-3386 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3386 > Project: Apache AsterixDB > Issue Type: Improvement > Components: CONF - Configuration >Affects Versions: 0.9.10 >Reporter: Murtadha Makki Al Hubail >Assignee: Murtadha Makki Al Hubail >Priority: Major > Labels: triaged > Fix For: 0.9.10 > > > To account for runtime memory overhead, we should add a configuration to > allow specifying a percentage of memory to be added on top of the job's > required memory. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Savyasach Reddy : Attention is currently required from: Savyasach Reddy. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 to look at the new patch set (#8). Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. [ASTERIXDB-3390][STO]: Support GCS for cloud deployment Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 --- M asterixdb/asterix-app/pom.xml M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/IParallelCacher.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/GCSExternalFileWriterFactory.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_external_dataset_s3.xml A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/accessor/ReplaceableCloudAccessor.java A asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/GCSExternalFileWriter.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageGCSTest.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSParallelDownloader.java M asterixdb/asterix-cloud/pom.xml A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java A asterixdb/asterix-cloud/src/test/java/org/apache/asterix/cloud/gcs/LSMGCSTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/LocalCloudUtil.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudClient.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/CloudClientProvider.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/IParallelDownloader.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/ParallelCacher.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/bulk/IBulkOperationCallBack.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudBufferedWriter.java 23 files changed, 1,239 insertions(+), 11 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/53/18253/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 8 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Savyasach Reddy Gerrit-MessageType: newpatchset
[jira] [Updated] (ASTERIXDB-3385) Duplicate fields should not accepted in primary key
[
https://issues.apache.org/jira/browse/ASTERIXDB-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Maxon updated ASTERIXDB-3385:
-
Labels: triaged (was: )
> Duplicate fields should not accepted in primary key
> ---
>
> Key: ASTERIXDB-3385
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-3385
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: COMP - Compiler
>Reporter: Peeyush Gupta
>Priority: Major
> Labels: triaged
>
> The following create dataset statement should not be allowed.
> {noformat}
> CREATE DATASET test PRIMARY KEY(name: string, name:string);{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3388) Document median function
[ https://issues.apache.org/jira/browse/ASTERIXDB-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3388: - Labels: triaged (was: ) > Document median function > > > Key: ASTERIXDB-3388 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3388 > Project: Apache AsterixDB > Issue Type: Task >Reporter: Murtadha Makki Al Hubail >Assignee: Ali Alsuliman >Priority: Major > Labels: triaged > > The median function was recently added and it should be documented. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3389) Allow caching and evicting pages of columnar collection in cloud deployment
[ https://issues.apache.org/jira/browse/ASTERIXDB-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3389: - Labels: triaged (was: ) > Allow caching and evicting pages of columnar collection in cloud deployment > --- > > Key: ASTERIXDB-3389 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3389 > Project: Apache AsterixDB > Issue Type: Improvement > Components: STO - Storage >Affects Versions: 0.9.10 >Reporter: Wail Y. Alkowaileet >Assignee: Wail Y. Alkowaileet >Priority: Major > Labels: triaged > Fix For: 0.9.10 > > > In a cloud deployment, columnar collections will not be downloaded as we > currently do. Instead, only pages of the requested columns will be brought up > from the cloud. On disk pressure, those pages can be evicted (given some > eviction policy/criteria). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3387) Introduce Selective Cloud Accessor
[ https://issues.apache.org/jira/browse/ASTERIXDB-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3387: - Labels: triaged (was: ) > Introduce Selective Cloud Accessor > -- > > Key: ASTERIXDB-3387 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3387 > Project: Apache AsterixDB > Issue Type: Improvement > Components: STO - Storage >Affects Versions: 0.9.10 >Reporter: Wail Y. Alkowaileet >Assignee: Wail Y. Alkowaileet >Priority: Major > Labels: triaged > Fix For: 0.9.10 > > > In order to support unlimited storage, a "Selective" accessor should be added > (currently we have only a Lazy accessor). The Selective accessor will allow > to uncache a file as well as punching a hole in a file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ASTERIXDB-3390) Support GCS for cloud deployment
[ https://issues.apache.org/jira/browse/ASTERIXDB-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian Maxon updated ASTERIXDB-3390: - Labels: triaged (was: ) > Support GCS for cloud deployment > > > Key: ASTERIXDB-3390 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-3390 > Project: Apache AsterixDB > Issue Type: Improvement > Components: STO - Storage >Affects Versions: 0.9.10 >Reporter: Murtadha Makki Al Hubail >Assignee: Murtadha Makki Al Hubail >Priority: Major > Labels: triaged > Fix For: 0.9.10 > > > Currently, only S3 is supported for cloud deployment with compute-storage > separation. We should add support for GCS. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Wail Alkowaileet : Attention is currently required from: Savyasach Reddy. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 7: (4 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/370aa47a_7814bf5e PS6, Line 102: partNumber > Not necessary. I noticed that ICloudBufferedWriter. […] I see... We Can change int upload(InputStream stream, int length) in ICloudBufferedWriter to be void upload(InputStream stream, int length). The returned value isn't used. You can leave as is for now and we can remove it in a follow up patch https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/e642e090_14023778 PS6, Line 104: setChunkSize > https://cloud.google.com/storage/docs/performing-resumable-uploads#:~:text=want%20to%20upload. > […] Done File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/d6c1a539_7278713f PS6, Line 100: list > No, It's added when we want to fetch the size of objects. The name is always > fetched. We will need the size. Let's include it here https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/d26ab907_c1a90cb3 PS6, Line 121: seek > Checked it using a local gcs server. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Savyasach Reddy Gerrit-Comment-Date: Fri, 26 Apr 2024 16:51:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet Comment-In-Reply-To: Savyasach Reddy Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Murtadha Hubail : Murtadha Hubail has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function ... and associated MEDIAN() aggregation pseudo-function. - Add ARRAY_MEDIAN to the builtin functions - Add MEDIAN to aggregation pseudo-functions - Fix typo: SKEWENESS → SKEWNESS - Fix order of aggregation pseudo-function table - Update details of OVER clause with aggregate functions - Update return values for all aggregate functions Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 Reviewed-by: Ali Alsuliman Tested-by: Murtadha Hubail --- M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md M asterixdb/asterix-doc/src/main/markdown/sqlpp/4_windowfunctions.md M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 3 files changed, 98 insertions(+), 31 deletions(-) Approvals: Ali Alsuliman: Looks good to me, approved Murtadha Hubail: Verified diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md b/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md index 0657fb0..755fd39 100644 --- a/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md +++ b/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md @@ -48,8 +48,8 @@ * or, a `missing` value. * Return Value: * a `bigint` value representing the number of non-null and non-missing items in the given collection, -* `null` is returned if the input is `null` or `missing`, -* any other non-array and non-multiset input value will cause an error. +* `0` is returned if the input is `null` or `missing`, +* `0` is returned if the input is not an array or a multiset. * Example: @@ -77,8 +77,8 @@ * a `double` value representing the average of the non-null and non-missing numbers in the given collection, * `null` is returned if the input is `null` or `missing`, * `null` is returned if the given collection does not contain any non-null and non-missing items, -* any other non-array and non-multiset input value will cause a type error, -* any other non-numeric value in the input collection will cause a type error. +* `null` is returned if the input is not an array or a multiset, +* any other non-numeric value in the input collection will be ignored. * Example: @@ -107,8 +107,8 @@ items. * `null` is returned if the input is `null` or `missing`, * `null` is returned if the given collection does not contain any non-null and non-missing items, -* any other non-array and non-multiset input value will cause a type error, -* any other non-numeric value in the input collection will cause a type error. +* `null` is returned if the input is not an array or a multiset, +* any other non-numeric value in the input collection will be ignored. * Example: @@ -136,8 +136,8 @@ type promotion order (`tinyint`-> `smallint`->`integer`->`bigint`->`float`->`double`) among numeric items. * `null` is returned if the input is `null` or `missing`, * `null` is returned if the given collection does not contain any non-null and non-missing items, -* multiple incomparable items in the input array or multiset will cause a type error, -* any other non-array and non-multiset input value will cause a type error. +* `null` is returned if there are incomparable items in the input array or multiset, +* `null` is returned if the input is not an array or a multiset. * Example: @@ -165,8 +165,8 @@ type promotion order (`tinyint`-> `smallint`->`integer`->`bigint`->`float`->`double`) among numeric items. * `null` is returned if the input is `null` or `missing`, * `null` is returned if the given collection does not contain any non-null and non-missing items, -* multiple incomparable items in the input array or multiset will cause a type error, -* any other non-array and non-multiset input value will cause a type error. +* `null` is returned if there are incomparable items in the input array or multiset, +* `null` is returned if the input is not an array or a multiset. * Example: @@ -177,6 +177,44 @@ 3.4 +### array_median ### + * Syntax: + +array_median(num_collection) + + * Gets the median value of the numeric items in the given collection, ignoring null, missing, and non-numeric items. + + The function starts by sorting the numeric items. + + - If there is an odd number of numeric items, the function returns the item that is exactly in the middle of the range: that is, it has the same number of items before and after. + - If there is an even number of numeric items, the function returns the mean
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Murtadha Hubail : Attention is currently required from: Ali Alsuliman, Simon Dew. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Patch Set 4: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-Comment-Date: Fri, 26 Apr 2024 15:46:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Murtadha Hubail : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Removed Integration-Tests-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-MessageType: deleteVote
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Murtadha Hubail : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Removed Verified-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-MessageType: deleteVote
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Jenkins : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Patch Set 4: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/385/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-Comment-Date: Fri, 26 Apr 2024 15:32:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Patch Set 4: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/d8wsGNrLZFgrwpJa9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-Comment-Date: Fri, 26 Apr 2024 14:38:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Ali Alsuliman : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-Comment-Date: Fri, 26 Apr 2024 14:33:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Simon Dew : Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Simon Dew has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 ) Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. Patch Set 4: (3 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/f889b387_a63d332b PS3, Line 7: DOC-12137: > Replace this with [ASTERIXDB-3388][DOC]: Done Patchset: PS4: Updates after review of patch set 3 File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/87f53790_50f4ce45 PS2, Line 204: * any other non-array and non-multiset input value will cause a type error, > Yes, please. […] Done. Thanks very much for checking these! -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Ali Alsuliman Gerrit-Comment-Date: Fri, 26 Apr 2024 14:25:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman Comment-In-Reply-To: Simon Dew Gerrit-MessageType: comment
Change in asterixdb[neo]: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function
>From Simon Dew : Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Hello Murtadha Hubail, Ali Alsuliman, Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 to look at the new patch set (#4). Change subject: [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function .. [ASTERIXDB-3388][DOC]: Add ARRAY_MEDIAN() Function ... and associated MEDIAN() aggregation pseudo-function. - Add ARRAY_MEDIAN to the builtin functions - Add MEDIAN to aggregation pseudo-functions - Fix typo: SKEWENESS → SKEWNESS - Fix order of aggregation pseudo-function table - Update details of OVER clause with aggregate functions - Update return values for all aggregate functions Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a --- M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md M asterixdb/asterix-doc/src/main/markdown/sqlpp/4_windowfunctions.md M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 3 files changed, 95 insertions(+), 31 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/51/18251/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Dew Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Ali Alsuliman Gerrit-Attention: Murtadha Hubail Gerrit-Attention: Ali Alsuliman Gerrit-Attention: Simon Dew Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
Attention is currently required from: Wail Alkowaileet, Savyasach Reddy. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 7: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/AUJ4ATaqoiwVQRBX9 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Attention: Savyasach Reddy Gerrit-Comment-Date: Fri, 26 Apr 2024 14:13:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Jenkins : Attention is currently required from: Wail Alkowaileet. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/384/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 12:56:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
Attention is currently required from: Wail Alkowaileet. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 7: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/gVkY5xoBrhS2JV7J7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 11:59:42 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Savyasach Reddy : Attention is currently required from: Wail Alkowaileet. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. Patch Set 7: (1 comment) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/59768792_fe0b0867 PS6, Line 7: Add > [ASTERIXDB-3390][STO] Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 11:51:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment
>From Savyasach Reddy : Attention is currently required from: Wail Alkowaileet. Hello Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 to look at the new patch set (#7). Change subject: [ASTERIXDB-3390][STO]: Support GCS for cloud deployment .. [ASTERIXDB-3390][STO]: Support GCS for cloud deployment Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 --- M asterixdb/asterix-app/pom.xml M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/IParallelCacher.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/GCSExternalFileWriterFactory.java M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_external_dataset_s3.xml A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/provider/ExternalWriterProvider.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/accessor/ReplaceableCloudAccessor.java A asterixdb/asterix-app/src/test/resources/cc-cloud-storage-gcs.conf A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/writer/GCSExternalFileWriter.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/cloud_storage/CloudStorageGCSTest.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSParallelDownloader.java M asterixdb/asterix-cloud/pom.xml A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java A asterixdb/asterix-cloud/src/test/java/org/apache/asterix/cloud/gcs/LSMGCSTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/LocalCloudUtil.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudClient.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/CloudClientProvider.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/IParallelDownloader.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/ParallelCacher.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/bulk/IBulkOperationCallBack.java A asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java M asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/ICloudBufferedWriter.java 23 files changed, 1,235 insertions(+), 12 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/53/18253/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 7 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-MessageType: newpatchset
Change in asterixdb[master]: [ASTERIXDB-3384][DOC] Document COPY
Attention is currently required from: Peeyush Gupta, Ian Maxon, Hussain Towaileb. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 ) Change subject: [ASTERIXDB-3384][DOC] Document COPY .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/UpsqJXehJev955MAA : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c Gerrit-Change-Number: 18243 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Peeyush Gupta Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ian Maxon Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Fri, 26 Apr 2024 11:12:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3384][DOC] Document COPY
>From Jenkins : Attention is currently required from: Peeyush Gupta, Ian Maxon, Hussain Towaileb. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 ) Change subject: [ASTERIXDB-3384][DOC] Document COPY .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/382/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c Gerrit-Change-Number: 18243 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Peeyush Gupta Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ian Maxon Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Fri, 26 Apr 2024 09:38:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3384][DOC] Document COPY
Attention is currently required from: Peeyush Gupta, Ian Maxon, Hussain Towaileb. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 ) Change subject: [ASTERIXDB-3384][DOC] Document COPY .. Patch Set 3: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/PuyT25TSPJ8LrRo18 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c Gerrit-Change-Number: 18243 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Peeyush Gupta Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ian Maxon Gerrit-Attention: Hussain Towaileb Gerrit-Comment-Date: Fri, 26 Apr 2024 09:01:17 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [ASTERIXDB-3384][DOC] Document COPY
>From Ian Maxon : Attention is currently required from: Peeyush Gupta, Ian Maxon, Hussain Towaileb. Hello Peeyush Gupta, Hussain Towaileb, Jenkins, Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 to look at the new patch set (#2). Change subject: [ASTERIXDB-3384][DOC] Document COPY .. [ASTERIXDB-3384][DOC] Document COPY Details: Add some brief documentation about each COPY statement. Also add the simplified BNF for railroad diagrams for each. Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c --- M asterixdb/asterix-doc/src/main/grammar/sqlpp.ebnf M asterixdb/asterix-doc/src/main/markdown/sqlpp/7_ddl_dml.md 2 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/43/18243/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ibdacf4e6b156a3b6ef15b1420a4102c122f8bf1c Gerrit-Change-Number: 18243 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Peeyush Gupta Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Peeyush Gupta Gerrit-Attention: Ian Maxon Gerrit-Attention: Hussain Towaileb Gerrit-MessageType: newpatchset
Change in asterixdb[master]: Add GCS Cloud Client
>From Savyasach Reddy : Attention is currently required from: Wail Alkowaileet. Savyasach Reddy has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 ) Change subject: Add GCS Cloud Client .. Patch Set 6: (6 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSBufferedWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/b16eccd9_f0199052 PS6, Line 102: partNumber > Why you need this? Not necessary. I noticed that ICloudBufferedWriter.upload has a return for 'amount uploaded,' so I mirrored that behaviour from S3BufferedWriter. Would you prefer I remove this? Also, could you clarify what should be returned in the upload()? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/c438d050_b5c78d8a PS6, Line 104: setChunkSize > what's the minimum/maximum for this? https://cloud.google.com/storage/docs/performing-resumable-uploads#:~:text=want%20to%20upload.-,The%20chunk%20size%20should%20be%20a%20multiple%20of%20256%20KiB,MiB%20for%20the%20chunk%20size. Minimum: 256KiB. Default: 16MiB. Recommended: 8MiB. Couldn't find maximum. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/1f2f1234_a7495ca5 PS6, Line 35: DELETE_BATCH_SIZE > Hmm that's 10x lower than S3. […] Yes. https://cloud.google.com/storage/quotas#:~:text=Don%27t%20include%20more%20than%20100%20calls%20in%20a%20single%20request. File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/7a6f9be5_f665a441 PS6, Line 100: list > Should that also include BlobListOption.fields(Storage.BlobField. […] No, It's added when we want to fetch the size of objects. The name is always fetched. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/3eafc014_73c523d8 PS6, Line 121: seek > What's the cost of this seek? Just curious if that actually will bring > anything from the cloud and t […] Checked it using a local gcs server. No HTTP request is triggered during the seek/limit operation; data is retrieved only upon calling the read function with appropriate values set in the HTTP header "Range". https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253/comment/072aec3f_ae7b628f PS6, Line 187: DELETE_BATCH_SIZE > We probably should include a URL of the documentation that states the limit. Ack -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18253 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I0b9cad99de2d32d1e672a3d396897807687685e8 Gerrit-Change-Number: 18253 Gerrit-PatchSet: 6 Gerrit-Owner: Savyasach Reddy Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-CC: Murtadha Hubail Gerrit-CC: Wail Alkowaileet Gerrit-Attention: Wail Alkowaileet Gerrit-Comment-Date: Fri, 26 Apr 2024 08:24:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet Gerrit-MessageType: comment
