Change in asterixdb[master]: [NO ISSUE][HYR] Fix wait for completion work

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [NO ISSUE][HYR] Fix wait for completion work
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1999/1//COMMIT_MSG
Commit Message:

PS1, Line 7: HYR
> Are you sure?!
You should not write [*DB] or [HYR] as the concrete component:

https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting

This change should be [RT].


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e50f6ce1df9f27517d7ec3a3f8a5d38246f71ff
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2086][RT] Remove table size from InMemoryHashJoin...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2086][RT] Remove table size from InMemoryHashJoin 
interface
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1994
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02a677ecfef80ccd4332447a6dcb5d480be6fe80
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][HYR] Fix wait for completion work

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [NO ISSUE][HYR] Fix wait for completion work
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1999/1//COMMIT_MSG
Commit Message:

PS1, Line 7: HYR
HYR is not a component in JIRA.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1999
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e50f6ce1df9f27517d7ec3a3f8a5d38246f71ff
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [HYR] Remove table size from InMemoryHashJoin interface

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [HYR] Remove table size from InMemoryHashJoin interface
..


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1994/2//COMMIT_MSG
Commit Message:

PS2, Line 7: HYR
HYR is not a component defined in JIRA.

Either:
[ISSUE][RT] Remove table size from InMemoryHashJoin interface

or
[NOISSUE][RT] Remove table size from InMemoryHashJoin interface


https://asterix-gerrit.ics.uci.edu/#/c/1994/2/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/ISerializableTable.java:

PS2, Line 68: int getTableSize();
Document public method in interfaces.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1994
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02a677ecfef80ccd4332447a6dcb5d480be6fe80
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md:

PS1, Line 22: 
> I believe this should be implicit since the new syntax of Statement enforce
OK, that should be fine then.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md:

PS1, Line 22: 
Have semi-colon after this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1996
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Memory budgeting for aggregation.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1995

Change subject: [ASTERIXDB-1812][RT] Memory budgeting for aggregation.
..

[ASTERIXDB-1812][RT] Memory budgeting for aggregation.

Change-Id: I1d39478a4f484c6e1b9ab95688253dfc580db069
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
6 files changed, 108 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/1995/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.1.ddl.sqlpp
new file mode 100644
index 000..5b9099d
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.1.ddl.sqlpp
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+drop  dataverse tpch if exists;
+create  dataverse tpch;
+
+use tpch;
+
+create type tpch.LineItemType as
+ closed {
+  l_orderkey : bigint,
+  l_partkey : bigint,
+  l_suppkey : bigint,
+  l_linenumber : bigint,
+  l_quantity : double,
+  l_extendedprice : double,
+  l_discount : double,
+  l_tax : double,
+  l_returnflag : string,
+  l_linestatus : string,
+  l_shipdate : string,
+  l_commitdate : string,
+  l_receiptdate : string,
+  l_shipinstruct : string,
+  l_shipmode : string,
+  l_comment : string
+};
+
+create  dataset LineItem(LineItemType) primary key l_orderkey,l_linenumber;
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.2.update.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.2.update.sqlpp
new file mode 100644
index 000..5fe734c
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.2.update.sqlpp
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+use tpch;
+
+
+load  dataset LineItem using localfs 
((`path`=`asterix_nc1://data/tpch0.001/lineitem.tbl`),(`format`=`delimited-text`),(`delimiter`=`|`))
 pre-sorted;
+
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/query-ASTERIXDB-1812/query-ASTERIXDB-1812.3.query.sqlpp
new file mode 100644
index 000..79d30ba
--- 

Change in asterixdb[master]: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for co...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for 
complex cases.
..


Patch Set 2:

Analytics jenkins job passes: 
http://analytics.jenkins.couchbase.com/job/cbas-cbcluster-test/1255/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1992
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I969c40112be0506981357a9c41bf9675ae12ffb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for co...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1992

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for 
complex cases.
..

[ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for complex cases.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- re-implement PushSubplanIntoGroupByRule and let it handle general cases;
- add an option to LogicalOperatorDeepCopyWithNewVariablesVisitor for
  not re-mapping free variables in the given plan subtree.

Change-Id: I969c40112be0506981357a9c41bf9675ae12ffb9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inlined_q18_large_volume_customer.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1263.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue697.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue785.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810-2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-2.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalExpressionDeepCopyWithNewVariablesVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalOperatorDeepCopyWithNewVariablesVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/PushSubplanIntoGroupByRule.java
18 files changed, 437 insertions(+), 208 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/92/1992/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1992
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I969c40112be0506981357a9c41bf9675ae12ffb9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for co...

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1992

Change subject: [ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for 
complex cases.
..

[ASTERIXDB-2051][COMP] Fix PushSubplanIntoGroupByRule for complex cases.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- re-implement PushSubplanIntoGroupByRule and let it handle general cases;
- add an option to LogicalOperatorDeepCopyWithNewVariablesVisitor for
  not re-mapping free variables in the given plan subtree.

Change-Id: I969c40112be0506981357a9c41bf9675ae12ffb9
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/inlined_q18_large_volume_customer.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1263.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-3.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue697.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue785.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810-2.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-2.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalExpressionDeepCopyWithNewVariablesVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/LogicalOperatorDeepCopyWithNewVariablesVisitor.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/PushSubplanIntoGroupByRule.java
18 files changed, 431 insertions(+), 205 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/92/1992/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
index 725de12..19c6da7 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
@@ -629,13 +629,13 @@
 
 // Create first copy.
 LogicalOperatorDeepCopyWithNewVariablesVisitor firstDeepCopyVisitor = 
new LogicalOperatorDeepCopyWithNewVariablesVisitor(
-context, context, newProbeSubTreeVarMap);
+context, context, newProbeSubTreeVarMap, true);
 ILogicalOperator newProbeSubTree = 
firstDeepCopyVisitor.deepCopy(probeSubTree.getRoot());
 inferTypes(newProbeSubTree, context);
 Mutable newProbeSubTreeRootRef = new 
MutableObject(newProbeSubTree);
 // Create second copy.
 LogicalOperatorDeepCopyWithNewVariablesVisitor secondDeepCopyVisitor = 
new LogicalOperatorDeepCopyWithNewVariablesVisitor(
-context, context, joinInputSubTreeVarMap);
+context, context, joinInputSubTreeVarMap, true);
 ILogicalOperator joinInputSubTree = 
secondDeepCopyVisitor.deepCopy(probeSubTree.getRoot());
 inferTypes(joinInputSubTree, context);
 probeSubTree.getRootRef().setValue(joinInputSubTree);
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp
new file mode 100644
index 000..4b94bf6
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-3.sqlpp
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright 

Change in asterixdb[master]: [ASTERIXDB-2057][API] Add detailed error message for 500 in ...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2057][API] Add detailed error message for 500 in 
REST API
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1959
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17759141116a1baf878abf7d5ec70295a18946e8
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 56: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 56
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..


[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1940
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/big-object/big_object_groupby/big_object_groupby.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_groupby/big_object_groupby.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/big-object/big_object_groupby/big_object_groupby.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushGroupByIntoSortRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
28 files changed, 310 insertions(+), 37 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
index 5aaf87b..d22ec54 100644
--- 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..


Patch Set 12:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
File 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java:

Line 190: op.setPhysicalOperator(new 
PreclusteredGroupByPOperator(columnList, gby.isGroupAll(),
> rename to getMaxFramesGroupBy()
Done


https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
File 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java:

Line 151: if (memoryBudget > 0 && data.length > memoryBudget) {
> move if (memoryBugdet>0) up 2 lines
Done


https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java:

Line 83: this.memoryLimit = ((long) (framesLimit - 2)) * 
ctx.getInitialFrameSize(); // Deducts input/output frames.
> set to -1 if framesLimit is -1
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#13).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/big-object/big_object_groupby/big_object_groupby.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_groupby/big_object_groupby.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/big-object/big_object_groupby/big_object_groupby.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/PhysicalOptimizationConfig.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushGroupByIntoSortRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
28 files changed, 310 insertions(+), 37 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#11).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/big-object/big_object_groupby/big_object_groupby.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_groupby/big_object_groupby.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/big-object/big_object_groupby/big_object_groupby.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
26 files changed, 301 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#10).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/big-object/big_object_groupby/big_object_groupby.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_groupby/big_object_groupby.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
25 files changed, 300 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#9).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/big-object/big_object_groupby/big_object_groupby.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
24 files changed, 298 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#7).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- let pre-clustered group-by consider memory budget.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
23 files changed, 288 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive
  subplans;
- Fix various places that assumes the nested plans inside a group-by
  operator cannot be empty;
- Added regression tests.

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1946
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Yingyi Bu 
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
10 files changed, 277 insertions(+), 46 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Anon. E. Moose #1000171: 
  Jenkins: Verified; ; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
new file mode 100644
index 000..b6f6159
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : This test case is to verify the fix for issue810
+ * https://code.google.com/p/asterixdb/issues/detail?id=810
+ * Expected Res : SUCCESS
+ * Date : 16th Nov. 2014
+ */
+
+DROP  DATAVERSE tpch IF EXISTS;
+CREATE  dataverse tpch;
+
+USE tpch;
+
+
+CREATE TYPE LineItemType AS CLOSED {
+  l_orderkey : integer,
+  l_partkey : integer,
+  l_suppkey : integer,
+  l_linenumber : integer,
+  l_quantity : double,
+  l_extendedprice : double,
+  l_discount : double,
+  l_tax : double,
+  l_returnflag : string,
+  l_linestatus : string,
+  l_shipdate : string,
+  l_commitdate : string,
+  l_receiptdate : string,
+  l_shipinstruct : string,
+  l_shipmode : string,
+  l_comment : string
+}
+
+CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber;
+
+
+SELECT l_returnflag AS l_returnflag,
+   l_linestatus AS l_linestatus,
+   coll_count(cheap) AS count_cheaps,
+   coll_count(expensive) AS count_expensives
+FROM LineItem AS l
+/* +hash */
+GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus
+GROUP AS g
+LET cheap = (
+  SELECT ELEMENT g.l
+  FROM g
+  WHERE g.l.l_discount > 0.05
+),
+expensive = (
+  SELECT ELEMENT g.l
+  FROM g
+  WHERE g.l.l_discount <= 0.05
+)
+ORDER BY l_returnflag,l_linestatus
+;
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..


Patch Set 5: Code-Review+2

Fwd Dmitry's +2.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Hello Jenkins, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1946

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..

[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix EliminateSubplanWithInputCardinalityOneRule to handle recursive
  subplans;
- Fix various places that assumes the nested plans inside a group-by
  operator cannot be empty;
- Added regression tests.

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
10 files changed, 277 insertions(+), 46 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/46/1946/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1946

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2044][COMP] Eliminate listify for complex group-by
..

[ASTERIXDB-2044][COMP] Eliminate listify for complex group-by

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
10 files changed, 277 insertions(+), 46 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/46/1946/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1946
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [COMP] Eliminate listify for complex group-by

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1946

Change subject: [COMP] Eliminate listify for complex group-by
..

[COMP] Eliminate listify for complex group-by

Change-Id: Ida9aa8d89a89f90256e54c8c1806af9b4a162d21
---
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1308-1.plan
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/typing/AbstractTypeEnvironment.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/subplan/EliminateSubplanWithInputCardinalityOneRule.java
8 files changed, 167 insertions(+), 46 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/46/1946/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
new file mode 100644
index 000..451f163
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/query-ASTERIXDB-810.sqlpp
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description  : This test case is to verify the fix for issue810
+ * https://code.google.com/p/asterixdb/issues/detail?id=810
+ * Expected Res : SUCCESS
+ * Date : 16th Nov. 2014
+ */
+
+DROP  DATAVERSE tpch IF EXISTS;
+CREATE  dataverse tpch;
+
+USE tpch;
+
+
+CREATE TYPE LineItemType AS CLOSED {
+  l_orderkey : integer,
+  l_partkey : integer,
+  l_suppkey : integer,
+  l_linenumber : integer,
+  l_quantity : double,
+  l_extendedprice : double,
+  l_discount : double,
+  l_tax : double,
+  l_returnflag : string,
+  l_linestatus : string,
+  l_shipdate : string,
+  l_commitdate : string,
+  l_receiptdate : string,
+  l_shipinstruct : string,
+  l_shipmode : string,
+  l_comment : string
+}
+
+CREATE DATASET LineItem(LineItemType) PRIMARY KEY l_orderkey,l_linenumber;
+
+
+SELECT l_returnflag AS l_returnflag,
+   l_linestatus AS l_linestatus,
+   coll_count(cheap) AS count_cheaps,
+   coll_count(expensive) AS count_expensives
+FROM LineItem AS l
+/* +hash */
+GROUP BY l.l_returnflag AS l_returnflag,l.l_linestatus AS l_linestatus
+GROUP AS g
+LET cheap = (
+  SELECT ELEMENT m
+  FROM (FROM g SELECT VALUE l) AS m
+  WHERE m.l_discount > 0.05
+),
+expensive = (
+  SELECT ELEMENT m
+  FROM (FROM g SELECT VALUE l) AS m
+  WHERE m.l_discount <= 0.05
+)
+ORDER BY l_returnflag,l_linestatus
+;
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
new file mode 100644
index 000..1c56f1c
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-810.plan
@@ -0,0 +1,39 @@
+-- DISTRIBUTE_RESULT  |PARTITIONED|
+  -- ONE_TO_ONE_EXCHANGE  |PARTITIONED|
+-- STREAM_PROJECT  |PARTITIONED|
+  -- ASSIGN  |PARTITIONED|
+-- SORT_MERGE_EXCHANGE [$$l_returnflag(ASC), $$l_linestatus(ASC) ]  
|PARTITIONED|
+  -- PRE_CLUSTERED_GROUP_BY[$$42, $$43]  |PARTITIONED|
+  {
+-- AGGREGATE  |LOCAL|
+  -- NESTED_TUPLE_SOURCE  |LOCAL|
+  }
+  {
+-- AGGREGATE  |LOCAL|
+  -- NESTED_TUPLE_SOURCE  |LOCAL|
+ 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#6).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/tpch/query-issue810-3/query-issue810-3.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
27 files changed, 289 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#5).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/tpch/query-issue810-3/query-issue810-3.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
27 files changed, 290 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#4).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify-2/listify-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
26 files changed, 289 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
23 files changed, 183 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1812][RT] Budget the memory usage for pre-cluster...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1940

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered 
group-by.
..

[ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/group-by/listify/listify.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
24 files changed, 184 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1940
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [RT]Buget the memory usage for pre-clustered group-by.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1940

Change subject: [RT]Buget the memory usage for pre-clustered group-by.
..

[RT]Buget the memory usage for pre-clustered group-by.

Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/listify/listify.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql-sugar/query-issue810-3/query-issue810-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch-sql/query-issue810/query-issue810.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpch/query-issue810-3/query-issue810-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/group-by/listify/listify.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/PreclusteredGroupByPOperator.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SerializableAggregatorDescriptorFactory.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/SimpleAlgebricksAccumulatingAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/AbstractAccumulatingAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/HashSpillableTableFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/IAggregatorDescriptorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/aggregators/MultiFieldsAggregatorFactory.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java
24 files changed, 184 insertions(+), 31 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/40/1940/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
index 5aaf87b..fa066f9 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
@@ -182,7 +182,8 @@
 
columnList.add(varRef.getVariableReference());
 }
 }
-op.setPhysicalOperator(new 
PreclusteredGroupByPOperator(columnList, gby.isGroupAll()));
+op.setPhysicalOperator(new 
PreclusteredGroupByPOperator(columnList, gby.isGroupAll(),
+
context.getPhysicalOptimizationConfig().getMaxFramesExternalGroupBy()));
 }
 }
 } else if (((AbstractLogicalOperator) 
(r0.getValue())).getOperatorTag()
@@ -196,7 +197,8 @@
 columnList.add(varRef.getVariableReference());
 }
   

Change in asterixdb[master]: [ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.
..


[ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.

Change-Id: I44d75e518cca604273790aa1d862ca5764fa6395
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1933
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Till Westmann 
---
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
1 file changed, 16 insertions(+), 7 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; 



diff --git 
a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh 
b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
index dbce377..f33f403 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
@@ -25,6 +25,16 @@
   echo "  -f[orce]  : Forcibly terminates any running ${PRODUCT} processes 
(after shutting down cluster, if running)"
 }
 
+function kill_procs() {
+  cat /tmp/$$_pids | while read line; do
+if [ $minus_nine ]; then
+   echo $line | awk '{ print $2 }' | xargs -n1 kill -9
+else
+   echo $line | awk '{ print $2 }' | xargs -n1 kill
+fi
+  done
+}
+
 while [ -n "$1" ]; do
   case $1 in
 -f|-force) force=1;;
@@ -58,7 +68,10 @@
 INSTALLDIR=$(cd "$CLUSTERDIR/../.."; echo $PWD)
 "$INSTALLDIR/bin/${HELPER_COMMAND}" get_cluster_state -quiet
 if [ $? -ne 1 ]; then
-  "$INSTALLDIR/bin/${HELPER_COMMAND}" shutdown_cluster_all
+  if ps -ef | grep 
'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)'
 > /tmp/$$_pids; then
+minus_nine=0;
+kill_procs;
+  fi
   first=1
   tries=0
   echo -n "INFO: Waiting up to 60s for cluster to shutdown"
@@ -79,12 +92,8 @@
 if ps -ef | grep 
'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)'
 > /tmp/$$_pids; then
   echo -n "WARNING: ${PRODUCT} processes remain after cluster shutdown; "
   if [ $force ]; then
-echo "-f[orce] specified, forcibly terminating ${PRODUCT} processes:"
-cat /tmp/$$_pids | while read line; do
-  echo -n "   - $line..."
-  echo $line | awk '{ print $2 }' | xargs -n1 kill -9
-  echo "killed"
-done
+minus_nine=1;
+kill_procs;
   else
 echo "re-run with -f|-force to forcibly terminate all ${PRODUCT} 
processes:"
 cat /tmp/pids |  sed 's/^ *[0-9]* 
\([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1933
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44d75e518cca604273790aa1d862ca5764fa6395
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2028][SQL] No recursion for list creation

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2028][SQL] No recursion for list creation
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1936
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b65371bc007b57fd80542f6530db12dd936242
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2025][STO] Fix Merge Lifecycle

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle
..


Patch Set 12:

(1 comment)

>>Had a discussion about this with Mike Carey. 
>>we will log warning for double deletion (not fail) 
>>but we should still never do it...

I still couldn't clearly see the upside of doing so by ourselves.  It seems 
like that you are overriding sth. that the OS has already provided.  

- For better user experience?  The same thing is logged and no exception is 
thrown.
- For debugging purpose?  But from the logged warnings, there's no difference.
- For better design?  It complicates the synchronization etc.

Maybe we should discuss offline.

https://asterix-gerrit.ics.uci.edu/#/c/1930/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java:

PS12, Line 59:  synchronized (this) {
> other is called from a synchronized block...
Why do need two synchronizations to protect this one counter?
In other words, what will be a problem if you don't synchronize on "this"?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2025][STO] Fix Merge Lifecycle

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle
..


Patch Set 11:

PS, I don't think we need to synchronize on deletion by ourselves.

1.  Throwing an exception about deleting a non-existing file doesn't give a 
user additional information, as long as we log deletion operations in the log.  
With an exception on hands, a user is still not able to find out where the file 
gets deleted in the first place.

2.  Simple solution (i.e., the OS has already serialized file deletion 
operations) is easier to understand and maintain.  

3. If we add ROLL_BACK, there'll be one more thing to synchronize by ourselves.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2025][STO] Fix Merge Lifecycle

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2025][STO] Fix Merge Lifecycle
..


Patch Set 11:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1930/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/BaseOperationTracker.java:

PS12, Line 59:  synchronized (this) {
Why do you need to synchronize on "this"?

Other dsInfo.undeclareActiveIOOperation() calls do not synchronize on "this",  
e.g., the one in afterOperation().


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1930
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I843de8b26c181205e43f4eabe22a7c43f3ebfcbc
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1933

Change subject: [ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.
..

[ASTERIXDB-2032]Let stop-sample-cluster.sh to kill processes.

Change-Id: I44d75e518cca604273790aa1d862ca5764fa6395
---
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
1 file changed, 16 insertions(+), 7 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/33/1933/1

diff --git 
a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh 
b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
index dbce377..f33f403 100755
--- a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.sh
@@ -25,6 +25,16 @@
   echo "  -f[orce]  : Forcibly terminates any running ${PRODUCT} processes 
(after shutting down cluster, if running)"
 }
 
+function kill_procs() {
+  cat /tmp/$$_pids | while read line; do
+if [ $minus_nine ]; then
+   echo $line | awk '{ print $2 }' | xargs -n1 kill -9
+else
+   echo $line | awk '{ print $2 }' | xargs -n1 kill
+fi
+  done
+}
+
 while [ -n "$1" ]; do
   case $1 in
 -f|-force) force=1;;
@@ -58,7 +68,10 @@
 INSTALLDIR=$(cd "$CLUSTERDIR/../.."; echo $PWD)
 "$INSTALLDIR/bin/${HELPER_COMMAND}" get_cluster_state -quiet
 if [ $? -ne 1 ]; then
-  "$INSTALLDIR/bin/${HELPER_COMMAND}" shutdown_cluster_all
+  if ps -ef | grep 
'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)'
 > /tmp/$$_pids; then
+minus_nine=0;
+kill_procs;
+  fi
   first=1
   tries=0
   echo -n "INFO: Waiting up to 60s for cluster to shutdown"
@@ -79,12 +92,8 @@
 if ps -ef | grep 
'java.*org\.apache\.hyracks\.control\.[cn]c\.\([CN]CDriver\|service\.NCService\)'
 > /tmp/$$_pids; then
   echo -n "WARNING: ${PRODUCT} processes remain after cluster shutdown; "
   if [ $force ]; then
-echo "-f[orce] specified, forcibly terminating ${PRODUCT} processes:"
-cat /tmp/$$_pids | while read line; do
-  echo -n "   - $line..."
-  echo $line | awk '{ print $2 }' | xargs -n1 kill -9
-  echo "killed"
-done
+minus_nine=1;
+kill_procs;
   else
 echo "re-run with -f|-force to forcibly terminate all ${PRODUCT} 
processes:"
 cat /tmp/pids |  sed 's/^ *[0-9]* 
\([0-9]*\).*org\.apache\.hyracks\.control\.[cn]c[^ ]*\.\([^ ]*\) .*/\1 - \2/'

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1933
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44d75e518cca604273790aa1d862ca5764fa6395
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2030][FAIL] Do not reformat error messages

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2030][FAIL] Do not reformat error messages
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd922bca36c7b40903c8b7abbe3386fbedd9c77b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2029][COMP]Remove this from dataset errors

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2029][COMP]Remove this from dataset errors
..


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1928/2//COMMIT_MSG
Commit Message:

PS2, Line 7: this
this->"this"


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1928
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc74edb44aef8bfac3cb73fb8192bf6c353a66de
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.
..


[ASTERIXDB-1897][COMP][RT] Fix complex group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix type computer for numeric aggregations;
- Fix error reporting for SubplanRuntimeFactory;
- Add a negative test query.

Change-Id: Iebb393820a8edd0c54d80248b2a33c77d4f6fd7b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1923
Sonar-Qube: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericAggTypeComputer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java
7 files changed, 233 insertions(+), 25 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
new file mode 100644
index 000..0242f1c
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+DROP DATAVERSE gby IF EXISTS;
+CREATE DATAVERSE gby;
+
+USE gby;
+
+CREATE TYPE PolicyType AS {
+id: UUID
+}
+
+CREATE DATASET policies(PolicyType) PRIMARY KEY id AUTOGENERATED;
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
new file mode 100644
index 000..3b865bb
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+USE gby;
+
+INSERT INTO policies
+(
+  [ {
+"policyno": "C123",
+"state": "CA",
+"zipcode": "96008",
+"make": "Honda",
+"accidents": [
+  {
+"year": "2015",
+"cost": 5000
+  },
+  {
+"year": "2016",
+"cost": 8000
+  },
+  {
+"year": "2016",
+"cost": 6000
+  }
+]
+  },
+  {
+"policyno": "C124",
+"state": "CA",
+"zipcode": "96853",
+"make": "Ford",
+"accidents": [
+  {
+"year": 

Change in asterixdb[master]: [NO ISSUE][HYR][FAIL][RT] Avoid wrapping Errors

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [NO ISSUE][HYR][FAIL][RT] Avoid wrapping Errors
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1922
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb47c036a58ac9d8cb2dc77391a17dd22df19ad
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1923

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.
..

[ASTERIXDB-1897][COMP][RT] Fix complex group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix type computer for numeric aggregations;
- Fix error reporting for SubplanRuntimeFactory;
- Add a negative test query.

Change-Id: Iebb393820a8edd0c54d80248b2a33c77d4f6fd7b
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericAggTypeComputer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java
7 files changed, 233 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/23/1923/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1923
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebb393820a8edd0c54d80248b2a33c77d4f6fd7b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1923

Change subject: [ASTERIXDB-1897][COMP][RT] Fix complex group-by.
..

[ASTERIXDB-1897][COMP][RT] Fix complex group-by.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix type computer for numeric aggregations;
- Fix error reporting for SubplanRuntimeFactory;
- Add a negative test query.

Change-Id: Iebb393820a8edd0c54d80248b2a33c77d4f6fd7b
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.3.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NonTaggedGetItemResultType.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericAggTypeComputer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/SubplanRuntimeFactory.java
9 files changed, 226 insertions(+), 28 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/23/1923/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
index 0bda955..1ee4098 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
@@ -341,7 +341,7 @@
 replacedVarMap.putAll(resultFromChild.second);
 }
 VariableUtilities.substituteVariables(op, replacedVarMap, context);
-context.computeAndSetTypeEnvironmentForOperator(op);
+OperatorManipulationUtil.computeTypeEnvironmentBottomUp(op, context);
 return new Pair<>(changed, replacedVarMapForAncestor);
 }
 
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
new file mode 100644
index 000..0242f1c
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.1.ddl.sqlpp
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+DROP DATAVERSE gby IF EXISTS;
+CREATE DATAVERSE gby;
+
+USE gby;
+
+CREATE TYPE PolicyType AS {
+id: UUID
+}
+
+CREATE DATASET policies(PolicyType) PRIMARY KEY id AUTOGENERATED;
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
new file mode 100644
index 000..3b865bb
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/policy-05/policy-05.2.update.sqlpp
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

PS10, Line 117: boolean updateEntireExprInfo)
What does this parameter mean and why it is needed?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

PS10, Line 323: fillSubTreeIndexExprs(leftSubTree, analyzedAMs, context, false);
Why do we need to map variables for the left sub tree?


PS10, Line 351: isNullFuncExpr
isNullFuncExpr -> isMissingFuncExpr ?


PS10, Line 400: boolean leftSubTreeInitialized = 
leftSubTree.initFromSubTree(joinOp.getInputs().get(0), false);
Still need to init the left sub tree?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java:

PS10, Line 102:  if (!initDataSource) {
  : return true;
  : }
for left subtree, it's a no-op?   Maybe it shouldn't be called at all?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(51 comments)

1. Can you add other two queries listed in the issue ASTERIXDB-1984 into the 
tests?

2. Can you leave tests under nested-open-index as they are now, instead of 
changing them to closed fields which are covered elsewhere.  Instead, making 
them negative tests and check that hash join is used.

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql:

PS10, Line 40: $x.clineid 
Can you let the test as it is and change the resulting plan?

We want to prevent index join in that case.


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql:

PS10, Line 47: countA: int32
Can you leave the test as it is and update the resulting query plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql:

PS10, Line 47:  countA: int32
leave the query as it is and update the resulting query plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql:

PS10, Line 32: cfname : string,
 : clname : string
leave the query as it is and change the resulting plan


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql:

PS10, Line 32:cfname : string,
 : clname : string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql:

PS10, Line 32: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql:

PS10, Line 33: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql:

PS10, Line 33: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql:

PS10, Line 33:  
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql:

PS10, Line 33: clname
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_06.aql
File 

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 35:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml
File asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml:

PS35, Line 21: 0.5
should 1.0 be the default?


https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/create_aws_cluster.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/create_aws_cluster.yml:

PS35, Line 26: spark_test
spark_test --> spark_{{ lookup('env','USER') }} ?

So that different users can run the tests at same time?


https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml:

PS35, Line 48: tpch_scale: 0.5
Should this be generated from another config file?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 35
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2009][RT] Improve error reporting in MultiplexedC...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2009][RT] Improve error reporting in 
MultiplexedConnection
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c2db3b966dbde5c4c04ba061132a74195fb155
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2009][HYR] Improve error reporting in Multiplexed...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2009][HYR] Improve error reporting in 
MultiplexedConnection
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1910/1//COMMIT_MSG
Commit Message:

PS1, Line 7: HYR
Maybe RT could be more specific?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c2db3b966dbde5c4c04ba061132a74195fb155
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2003][FAIL] Abort jobs failing during job start

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2003][FAIL] Abort jobs failing during job start
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1904
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6fe4ed9084270f9f22ee4b4c71936d679c8b883
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..


Patch Set 8: Code-Review+2

Fwd Dmitry's +2.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..


[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1901
Tested-by: Jenkins 
BAD: Jenkins 
Reviewed-by: Yingyi Bu 
---
A asterixdb/asterix-app/data/infinity.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/infinity/infinity.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterixdb/asterix-external-data/src/main/resources/adm.grammar
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
35 files changed, 179 insertions(+), 63 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found

Objections:
  Jenkins: Violations found



diff --git a/asterixdb/asterix-app/data/infinity.adm 
b/asterixdb/asterix-app/data/infinity.adm
new file mode 100644
index 000..fd44c8f
--- /dev/null
+++ b/asterixdb/asterix-app/data/infinity.adm
@@ -0,0 +1 @@
+{ "id": 1, "a": INF, "b": -INF, "c":NaN }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
new file mode 100644
index 000..7059c72
--- /dev/null
+++ 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Dmitry Lychagin, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
A asterixdb/asterix-app/data/infinity.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/infinity/infinity.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterixdb/asterix-external-data/src/main/resources/adm.grammar
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
35 files changed, 179 insertions(+), 63 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
A asterixdb/asterix-app/data/infinity.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/infinity/infinity.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterixdb/asterix-external-data/src/main/resources/adm.grammar
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
35 files changed, 179 insertions(+), 63 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#6).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
A asterixdb/asterix-app/data/infinity.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/infinity/infinity.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/infinity/infinity.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M asterixdb/asterix-external-data/src/main/resources/adm.grammar
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
35 files changed, 179 insertions(+), 63 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
27 files changed, 83 insertions(+), 59 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/float_01/float_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/atan2/atan2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling2/ceiling2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor2/floor2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even2/round-half-to-even2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even22/round-half-to-even22.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/scientific/scientific.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_float_02/unary-minus_float_02.1.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AFloatPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AFloatPrinterFactory.java
29 files changed, 85 insertions(+), 61 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/atan2/atan2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/scientific/scientific.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
19 files changed, 48 insertions(+), 35 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON f...

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1901

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON 
format.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF in JSON format.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Use INF to represent infinity.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/constructor/double_01/double_01.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs2/abs2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/abs3/abs3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/atan2/atan2.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/caret0/caret0.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ceiling3/ceiling3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/floor3/floor3.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ln/ln.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/log/log.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even23/round-half-to-even23.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round-half-to-even3/round-half-to-even3.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/scientific/scientific.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/unary-minus_double_02/unary-minus_double_02.1.adm
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/ADoublePrinterFactory.java
19 files changed, 48 insertions(+), 35 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF.
..


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1901/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java:

Line 27: public class ADoublePrinterFactory implements IPrinterFactory {
> There are 3 other ADoublePrinterFactory classes under org.apache.asterix.da
Done


Line 34: if (Double.isFinite(d) && !Double.isNaN(d)) {
> is this new comparison necessary here (Double.isNaN)? 
Done


Line 38: ps.print(Double.compare(d, Double.NaN) == 0 ? "NaN"
> btw, you could use Double.isNaN() here instead of Double.compare() and then
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1901

Change subject: [ASTERIXDB-2000][RT] Fix roundtrip-ability for INF.
..

[ASTERIXDB-2000][RT] Fix roundtrip-ability for INF.

Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/01/1901/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
index db5a90c..66e3f84 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/non-finite/non-finite.1.json
@@ -1,2 +1,2 @@
-[ { "NaN": "NaN", "Infinity": "Infinity", "-Infinity": "-Infinity" }
+[ { "NaN": "NaN", "Infinity": "INF", "-Infinity": "-INF" }
  ]
diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
index abf9ced..00fbff4 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/ADoublePrinterFactory.java
@@ -31,11 +31,12 @@
 
 public static final IPrinter PRINTER = (byte[] b, int s, int l, 
PrintStream ps) -> {
 final double d = ADoubleSerializerDeserializer.getDouble(b, s + 1);
-if (Double.isFinite(d)) {
+if (Double.isFinite(d) && !Double.isNaN(d)) {
 ps.print(d);
 } else {
 ps.append('"');
-ps.print(Double.toString(d));
+ps.print(Double.compare(d, Double.NaN) == 0 ? "NaN"
+: (Double.compare(d, Double.POSITIVE_INFINITY) == 0 ? 
"INF" : "-INF"));
 ps.append('"');
 }
 };

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1901
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13687822433744afe1ad3439029b2c0887563f9b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-2002][HYR] Report failures during task start

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-2002][HYR] Report failures during task start
..


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1900/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java:

PS1, Line 279: oblet.getJobId(), taskAttemptId)
These two are contained in the second arg?


PS1, Line 364: joblet.getJobId(), taskAttemptId
These two are contained in the second arg?


https://asterix-gerrit.ics.uci.edu/#/c/1900/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/NotifyTaskFailureWork.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/NotifyTaskFailureWork.java:

Line 47: this.taskId = taskId;
> As taskId can be obtained from task, any particular reason to add this in t
Agree with Xikui


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1900
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf79088c1ea08e66a7b130e4836f153ea9603723
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [DOC] Reorganize data model documentations.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [DOC] Reorganize data model documentations.
..


[DOC] Reorganize data model documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize data model documentations;
- Align results in the function doc with JSON;
- Fix a few minor issues in the function doc.

Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1898
Sonar-Qube: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
Tested-by: Jenkins 
BAD: Jenkins 
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
M asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
M asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_header.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md
A 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_delta.md
D asterixdb/asterix-doc/src/site/markdown/datamodel.md
12 files changed, 501 insertions(+), 424 deletions(-)

Approvals:
  Dmitry Lychagin: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index a707434..57ed8f1 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -59,7 +59,10 @@
   
 
 
-  
+  
+
+
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
index 5cb22d4..a2b2555 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Type Functions [Back to TOC] ##
+## Type Functions ##
 
 ### is_array (isarray) ###
  * Syntax:
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
index b28443c..ac2a465 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Miscellaneous Functions [Back to TOC] ##
+## Miscellaneous Functions ##
 
 ### uuid ###
  * Syntax:
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
index 04fa943..202f7e4 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Conditional Functions [Back to TOC] ##
+## Conditional Functions ##
 
 ### if_null (ifnull) ###
 
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
index 9a4c080..c058d10 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
@@ -56,7 +56,7 @@
 * `missing` if the argument is a `missing` value,
 * `null` if the argument is a `null` value,
 * any other non-numeric input value will cause a type error,
-* NaN for other legitimate numeric values.
+* "NaN" for other legitimate numeric values.
 
  * Example:
 
@@ -65,7 +65,7 @@
 
  * The expected result is:
 
-{ "v1": 0.0, "v2": NaN, "v3": 1.5707963267948966, "v4": 
1.0471975511965979, "v5": 2.0943951023931957 }
+{ "v1": 0.0, "v2": "NaN", "v3": 1.5707963267948966, "v4": 
1.0471975511965979, "v5": 2.0943951023931957 }
 
 
 
@@ -83,7 +83,7 @@
 * `missing` if the argument is a `missing` value,
 * `null` if the argument is a `null` value,
 * any other non-numeric input value will cause a type error,
-* NaN for other legitimate numeric values.
+* "NaN" for other legitimate numeric values.
 
  * Example:
 
@@ -92,7 +92,7 @@
 
  * The expected result is:
 
-{ "v1": 1.5707963267948966, "v2": NaN, "v3": 0.0, "v4": 
0.5235987755982989, "v5": 

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 30:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/prepare_queries.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/prepare_queries.yml:

PS30, Line 24:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml:

PS30, Line 32: 1024
Make it a ratio to the physical RAM size instead of hardcoded?


PS30, Line 48: 2
Make it a ratio to the physical RAM size instead of hardcoded?


PS30, Line 50: (small x 2)
This part should be dynamically generated from aws_settings.yaml?


https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/backup_queries/q18.txt
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/backup_queries/q18.txt:

PS30, Line 18: 
Can you let the extension name of the file be q18.sql?


https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/execute-query.tmpl
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/execute-query.tmpl:

PS30, Line 41:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/ssh_config
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/conf/ssh_config:

PS30, Line 21:  
Tab->spaces


https://asterix-gerrit.ics.uci.edu/#/c/1879/30/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/run_sparksql.sh
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/run_sparksql.sh:

PS30, Line 40: sparks
"sparks" -> "spark"?


PS30, Line 47: ansible-playbook -i $INVENTORY 
$SCRIPT_PATH/ansible/execute_queries.yml
It looks that all queries are only executed once?  Can you execute & report 
them three times like that for AsterixDB?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [DOC] Reorganize data model documentations.

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [DOC] Reorganize data model documentations.
..


Patch Set 2:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1898/2/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md
File asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md:

PS2, Line 37: represents a missing name-value pair in an object.
> indicates that a name-value pair is missing from an object.
Done


PS2, Line 38: If the referenced field does not exist,
> If a missing name-value pair is accessed,
Done


https://asterix-gerrit.ics.uci.edu/#/c/1898/2/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
File 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md:

Line 51: - `tinyint`: -127 to 127
> min value for tinyint should be -128, right? 
Done


Line 73: { "v1": float("NaN"), "v2": float("INF"), "v3": float("-INF"), 
"v4": float("-2013.5") };
> do we parse 'INF' or 'Infinity' or both? This example might be confusing to
Unfortunately, we do not parse Infinity...

Created ASTERIXDB-2000 for it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1898
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [DOC] Reorganize data model documentations.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1898

to look at the new patch set (#3).

Change subject: [DOC] Reorganize data model documentations.
..

[DOC] Reorganize data model documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize data model documentations;
- Align results in the function doc with JSON;
- Fix a few minor issues in the function doc.

Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
M asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
M asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_header.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md
A 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_delta.md
D asterixdb/asterix-doc/src/site/markdown/datamodel.md
12 files changed, 501 insertions(+), 424 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/1898/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1898
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [DOC] Reorganize data model documentations.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1898

to look at the new patch set (#2).

Change subject: [DOC] Reorganize data model documentations.
..

[DOC] Reorganize data model documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize data model documentations;
- Align results in the function doc with JSON;
- Fix a few minor issues in the function doc.

Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
M asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
M asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_header.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md
A 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_delta.md
D asterixdb/asterix-doc/src/site/markdown/datamodel.md
12 files changed, 501 insertions(+), 424 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/1898/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1898
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [DOC] Reorganize data model documentations.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1898

Change subject: [DOC] Reorganize data model documentations.
..

[DOC] Reorganize data model documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize data model documentations;
- Fix a few minor issues in function documentations.

Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
M asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
M asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_header.md
A asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_incomplete.md
A 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
R asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_delta.md
10 files changed, 244 insertions(+), 166 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/98/1898/1

diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index a707434..57ed8f1 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -59,7 +59,10 @@
   
 
 
-  
+  
+
+
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
index 5cb22d4..a2b2555 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Type Functions [Back to TOC] ##
+## Type Functions ##
 
 ### is_array (isarray) ###
  * Syntax:
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
index b28443c..ac2a465 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/12_misc.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Miscellaneous Functions [Back to TOC] ##
+## Miscellaneous Functions ##
 
 ### uuid ###
  * Syntax:
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
index 04fa943..202f7e4 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
@@ -17,7 +17,7 @@
  ! under the License.
  !-->
 
-## Conditional Functions [Back to TOC] ##
+## Conditional Functions ##
 
 ### if_null (ifnull) ###
 
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
index 62a35c3..90eb017 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md
@@ -19,13 +19,12 @@
 
 ## Aggregate Functions (Array Functions)  ##
 
-A high-level description of SQL++ aggregate functions can be found at here.
-As SQL++ supports all legitimate SQL GROUP BY and Aggregation queries,
-here is a description 
of how standard SQL aggregation functions
-are supported.
-
 This section contains detailed descriptions of each SQL++ aggregate function 
(i.e., array function).
-
+Note that as described in the SQL++ query reference documentation, standard
+SQL aggregate functions (e.g., `MIN`, `MAX`, `SUM`, `COUNT`, and `AVG`)
+are not real functions in SQL++ but just syntactic sugars over corresponding
+SQL++ builtin aggregate functions (e.g., `ARRAY_MIN`, `ARRAY_MAX`,
+`ARRAY_SUM`, `ARRAY_COUNT`, and `ARRAY_AVG`).
 
 ### array_count ###
  * Syntax:
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md 
b/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
new file mode 100644
index 000..7ed4e34
--- /dev/null
+++ b/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_composite.md
@@ -0,0 +1,57 @@
+
+
+
+## Derived Types ##
+
+### Object###
+An `object` contains a set of fields, where each field is described by its name 
and type. An object type may be defined as either open or closed. Open objects 
(instances of open object types) are permitted to contain fields that are not 
part of the type definition, while closed objects do not permit their instances 
to carry extra fields. An example type definition for an object is:
+
+create 

Change in asterixdb[master]: [Doc]reorganize DDL documentations.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [Doc]reorganize DDL documentations.
..


[Doc]reorganize DDL documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize DDL documentations;
- Move declaration to queries;
- Fix several links;
- Add an example for non-enforced index.

Change-Id: I269750827ef529ac0e474fa0862635cc1f3aefed
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1892
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query_title.md
R asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_dataset_index.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_dml.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_function_removal.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_nonenforced_index.md
11 files changed, 332 insertions(+), 201 deletions(-)

Approvals:
  Dmitry Lychagin: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index d2fbefc..a707434 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -53,7 +53,7 @@
 
   
 
-  
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
index 134ce95..84986ae 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
@@ -36,6 +36,7 @@
* [Function call Expressions](#Function_call_expressions)
* [Constructors](#Constructors)
 * [3. Queries](#Queries)
+  * [Declarations](#Declarations)
   * [SELECT Statements](#SELECT_statements)
   * [SELECT Clauses](#Select_clauses)
* [Select Element/Value/Raw](#Select_element)
@@ -77,12 +78,14 @@
   * [Type Errors](#Type_errors)
   * [Resource Errors](#Resource_errors)
 * [5. DDL and DML Statements](#DDL_and_DML_statements)
-  * [Declarations](#Declarations)
   * [Lifecycle Management Statements](#Lifecycle_management_statements)
* [Dataverses](#Dataverses)
-   * [Datasets](#Datasets)
* [Types](#Types)
+   * [Datasets](#Datasets)
+   * [Indices](#Indices)
* [Functions](#Functions)
+   * [Removal](#Removal)
+   * [Load Statement](#Load_statement)
   * [Modification Statements](#Modification_statements)
* [Inserts](#Inserts)
* [Upserts](#Upserts)
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
new file mode 100644
index 000..1d1ab8e
--- /dev/null
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
@@ -0,0 +1,33 @@
+
+
+## Declarations
+
+DatabaseDeclaration ::= "USE" Identifier
+
+At the uppermost level, the world of data is organized into data namespaces 
called **dataverses**.
+To set the default dataverse for a series of statements, the USE statement is 
provided in SQL++.
+
+As an example, the following statement sets the default dataverse to be 
"TinySocial".
+
+# Example
+
+USE TinySocial;
+
+
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
new file mode 100644
index 000..a45996c
--- /dev/null
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
@@ -0,0 +1,45 @@
+
+
+When writing a complex SQL++ query, it can sometimes be helpful to define one 
or more auxilliary functions
+that each address a sub-piece of the overall query.
+The declare function statement supports the creation of such helper functions.
+In general, the function body (expression) can be any legal SQL++ query 
expression.
+
+FunctionDeclaration  ::= "DECLARE" "FUNCTION" Identifier ParameterList "{" 
Expression "}"
+ParameterList::= "(" (  ( ","  )* )? ")"
+
+The following is a simple example of a temporary SQL++ function definition and 
its use.
+
+# Example
+
+DECLARE 

Change in asterixdb[master]: [Doc]reorganize DDL documentations.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1892

Change subject: [Doc]reorganize DDL documentations.
..

[Doc]reorganize DDL documentations.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Re-organize DDL documentations;
- Move declaration to queries;
- Fix several links;
- Add an example for non-enforced index.

Change-Id: I269750827ef529ac0e474fa0862635cc1f3aefed
---
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query_title.md
R asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_dataset_index.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_dml.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_function_removal.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_head.md
A asterixdb/asterix-doc/src/main/markdown/sqlpp/5_ddl_nonenforced_index.md
11 files changed, 332 insertions(+), 201 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/92/1892/1

diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index d2fbefc..a707434 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -53,7 +53,7 @@
 
   
 
-  
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
index 134ce95..84986ae 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/0_toc.md
@@ -36,6 +36,7 @@
* [Function call Expressions](#Function_call_expressions)
* [Constructors](#Constructors)
 * [3. Queries](#Queries)
+  * [Declarations](#Declarations)
   * [SELECT Statements](#SELECT_statements)
   * [SELECT Clauses](#Select_clauses)
* [Select Element/Value/Raw](#Select_element)
@@ -77,12 +78,14 @@
   * [Type Errors](#Type_errors)
   * [Resource Errors](#Resource_errors)
 * [5. DDL and DML Statements](#DDL_and_DML_statements)
-  * [Declarations](#Declarations)
   * [Lifecycle Management Statements](#Lifecycle_management_statements)
* [Dataverses](#Dataverses)
-   * [Datasets](#Datasets)
* [Types](#Types)
+   * [Datasets](#Datasets)
+   * [Indices](#Indices)
* [Functions](#Functions)
+   * [Removal](#Removal)
+   * [Load Statement](#Load_statement)
   * [Modification Statements](#Modification_statements)
* [Inserts](#Inserts)
* [Upserts](#Upserts)
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
new file mode 100644
index 000..1d1ab8e
--- /dev/null
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md
@@ -0,0 +1,33 @@
+
+
+## Declarations
+
+DatabaseDeclaration ::= "USE" Identifier
+
+At the uppermost level, the world of data is organized into data namespaces 
called **dataverses**.
+To set the default dataverse for a series of statements, the USE statement is 
provided in SQL++.
+
+As an example, the following statement sets the default dataverse to be 
"TinySocial".
+
+# Example
+
+USE TinySocial;
+
+
diff --git 
a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
new file mode 100644
index 000..a45996c
--- /dev/null
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_function.md
@@ -0,0 +1,45 @@
+
+
+When writing a complex SQL++ query, it can sometimes be helpful to define one 
or more auxilliary functions
+that each address a sub-piece of the overall query.
+The declare function statement supports the creation of such helper functions.
+In general, the function body (expression) can be any legal SQL++ query 
expression.
+
+FunctionDeclaration  ::= "DECLARE" "FUNCTION" Identifier ParameterList "{" 
Expression "}"
+ParameterList::= "(" (  ( ","  )* )? ")"
+
+The following is a simple example of a temporary SQL++ function definition and 
its use.
+
+# Example
+
+DECLARE FUNCTION friendInfo(userId) {
+(SELECT u.id, u.name, len(u.friendIds) AS friendCount
+ FROM GleambookUsers u
+ WHERE u.id = userId)[0]
+ };
+
+SELECT VALUE friendInfo(2);
+
+For our sample data set, this returns:
+
+[
+  { "id": 2, "name": "IsbelDull", "friendCount": 2 }
+]
+
diff --git 

Change in asterixdb[master]: [ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be...

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be 
1-based
..


[ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be 1-based

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Change function position and regexp_position to be 1-based;
- Re-organize function documentations.

Change-Id: I415e0ba0ac4dfceba95913ff27af95c0c1af5fee
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1888
Sonar-Qube: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
M asterixdb/asterix-doc/pom.xml
R asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_delta.md
R asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/2_string_delta.md
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionWithFlagDescriptor.java
11 files changed, 252 insertions(+), 213 deletions(-)

Approvals:
  Dmitry Lychagin: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
index 76e3e97..5c54d04 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
@@ -1 +1 @@
-[ 2, -1 ]
+[ 3, -1 ]
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
index 428917f..83ee615 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
@@ -1,15 +1,15 @@
-0
+1
 -1
-0
-0
-0
+1
+1
+1
 -1
-0
+1
 -1
 -1
-0
-0
-0
-0
+1
+1
+1
+1
 -1
-0
+1
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
index fa99af7..f962896 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
@@ -1 +1 @@
-{ "result1": 0 }
+{ "result1": 1 }
diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index 9b980e1..d2fbefc 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -56,7 +56,7 @@
   
 
 
-  
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
similarity index 90%
rename from asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
rename to asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
index 563860c..9a4c080 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
@@ -357,44 +357,6 @@
 { "v1": 2013, "v2": -4036, "v3": 1.0, "v4": -2013.0, "v5": -2014.0 }
 
 
-### round_half_to_even ###
- * Syntax:
-
-round_half_to_even(numeric_value, [precision])
-
- * Computes the closest numeric value to `numeric_value` that is a multiple of 
ten to the power of minus `precision`.
-   `precision` is optional and by default value `0` is used.
- * Arguments:
-* `numeric_value`: a 

Change in asterixdb[master]: [WIP][ASTERIXDB-1982][FAIL]Fix async error notification.

[Yingyi Bu (Code Review)]

Yingyi Bu has abandoned this change.

Change subject: [WIP][ASTERIXDB-1982][FAIL]Fix async error notification.
..


Abandoned

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1889
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5a1817c1c793e1118308e3824ec08f6d20b0eadd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1982][FAIL] Fix DatasetPartitionWriter fail behavior

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1982][FAIL] Fix DatasetPartitionWriter fail behavior
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1891
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e065fd7e4204773e17d809b6e44059c709eb27b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1982][FAIL]Fix async error notification.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1889

to look at the new patch set (#2).

Change subject: [WIP][ASTERIXDB-1982][FAIL]Fix async error notification.
..

[WIP][ASTERIXDB-1982][FAIL]Fix async error notification.

Change-Id: I5a1817c1c793e1118308e3824ec08f6d20b0eadd
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TaskFailureWork.java
2 files changed, 9 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1889/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1889
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5a1817c1c793e1118308e3824ec08f6d20b0eadd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1982][FAIL] setException(..) in removeWaiter(..).

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1889

Change subject: [ASTERIXDB-1982][FAIL] setException(..) in removeWaiter(..).
..

[ASTERIXDB-1982][FAIL] setException(..) in removeWaiter(..).

Change-Id: I5a1817c1c793e1118308e3824ec08f6d20b0eadd
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/89/1889/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
index 8401fcf..4182a4d 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
@@ -284,7 +284,11 @@
 }
 
 Waiter removeWaiter(ResultSetId rsId) {
-return waiters.remove(rsId);
+Waiter waiter = waiters.remove(rsId);
+if (exception != null) {
+waiter.callback.setException(exception);
+}
+return waiter;
 }
 
 Waiter getWaiter(ResultSetId rsId) {
@@ -298,7 +302,9 @@
 }
 }
 // Caches the exception anyway for future added waiters.
-this.exception = exception;
+if (this.exception == null) {
+this.exception = exception;
+}
 }
 
 @Override

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1889
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a1817c1c793e1118308e3824ec08f6d20b0eadd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 

Change in asterixdb[master]: [ASTERIXDB-1982][FAIL] Unify runtime error reporting

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1883

to look at the new patch set (#7).

Change subject: [ASTERIXDB-1982][FAIL] Unify runtime error reporting
..

[ASTERIXDB-1982][FAIL] Unify runtime error reporting

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Unify error reporting in result distribution and operator pipeline;
  The fact that ASTERIXDB-1982 is sporadic is because the order of
  DatasetDirectoryService.reportJobFailure(...) and
  DatasetDirectoryService.reportResultPartitionFailure(...)
  is not deterministic and the latter can override the former;
- Make the order of setException and addWaiter irrelevant to
  avoid sporadically slipped exception;
- Fix the exception list in Task to be thread-safe.

Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/IDatasetDirectoryService.java
D 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/ReportResultPartitionFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java
12 files changed, 12 insertions(+), 132 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/1883/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1883
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be...

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new patch set (#2).

Change subject: [ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be 
1-based
..

[ASTERIXDB-1664][FUN][DOC] Fix position/regexp_postion to be 1-based

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Change function position and regexp_position to be 1-based;
- Re-organize function documentations.

Change-Id: I415e0ba0ac4dfceba95913ff27af95c0c1af5fee
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
M asterixdb/asterix-doc/pom.xml
R asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_delta.md
R asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/2_string_delta.md
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionWithFlagDescriptor.java
11 files changed, 252 insertions(+), 213 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/88/1888/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1888
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I415e0ba0ac4dfceba95913ff27af95c0c1af5fee
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1664] Fix position/regexp_postion to be 1-based

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1888

Change subject: [ASTERIXDB-1664] Fix position/regexp_postion to be 1-based
..

[ASTERIXDB-1664] Fix position/regexp_postion to be 1-based

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Change function position and regexp_position to be 1-based;
- Re-organize function documentations.

Change-Id: I415e0ba0ac4dfceba95913ff27af95c0c1af5fee
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
M asterixdb/asterix-doc/pom.xml
R asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_delta.md
R asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
A asterixdb/asterix-doc/src/main/markdown/builtins/2_string_delta.md
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpPositionWithFlagDescriptor.java
11 files changed, 250 insertions(+), 211 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/88/1888/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
index 76e3e97..5c54d04 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/position/position.1.adm
@@ -1 +1 @@
-[ 2, -1 ]
+[ 3, -1 ]
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
index 428917f..83ee615 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position/regexp_position.1.adm
@@ -1,15 +1,15 @@
-0
+1
 -1
-0
-0
-0
+1
+1
+1
 -1
-0
+1
 -1
 -1
-0
-0
-0
-0
+1
+1
+1
+1
 -1
-0
+1
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
index fa99af7..f962896 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/string/regexp_position_with_flag/regexp_position_with_flag.1.adm
@@ -1 +1 @@
-{ "result1": 0 }
+{ "result1": 1 }
diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index 9b980e1..d2fbefc 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -56,7 +56,7 @@
   
 
 
-  
+  
 
 
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
similarity index 90%
rename from asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
rename to asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
index 563860c..9a4c080 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric_common.md
@@ -357,44 +357,6 @@
 { "v1": 2013, "v2": -4036, "v3": 1.0, "v4": -2013.0, "v5": -2014.0 }
 
 
-### round_half_to_even ###
- * Syntax:
-
-round_half_to_even(numeric_value, [precision])
-
- * Computes the closest numeric value to `numeric_value` that is a multiple of 
ten to the power of minus `precision`.
-   `precision` is optional and by default value `0` is used.
- * Arguments:
-* `numeric_value`: a 
`tinyint`/`smallint`/`integer`/`bigint`/`float`/`double` value.
-* `precision`: an optional `tinyint`/`smallint`/`integer`/`bigint` field 
representing the
-   number of digits in the fraction of the the result
- * Return Value:
-* The rounded value for the given number in the same type as the input 
argument,
-* `missing` if any argument is a `missing` value,
-

Change in asterixdb[master]: [WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1883

to look at the new patch set (#5).

Change subject: [WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.
..

[WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Unify error reporting in result distribution and operator pipeline;
  The fact that ASTERIXDB-1982 is sporadic is because the order of
  DatasetDirectoryService.reportJobFailure(...) and
  DatasetDirectoryService.reportResultPartitionFailure(...)
  is not deterministic and the latter can override the former;
- Make the order of setException and addWaiter irrelevant to
  avoid sporadically slipped exception;
- Fix the exception list in Task to be thread-safe.

Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/IDatasetDirectoryService.java
D 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/ReportResultPartitionFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java
12 files changed, 12 insertions(+), 132 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/1883/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1883
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1982][FAIL] Unify runtime error reporting.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1883

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1982][FAIL] Unify runtime error reporting.
..

[ASTERIXDB-1982][FAIL] Unify runtime error reporting.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Unify error reporting in result distribution and operator pipeline;
  The fact that ASTERIXDB-1982 is sporadic is because the order of
  DatasetDirectoryService.reportJobFailure(...) and
  DatasetDirectoryService.reportResultPartitionFailure(...)
  is not deterministic and the latter can override the former;
- Fix the exception list in Task to be thread-safe.

Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/IDatasetDirectoryService.java
D 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/ReportResultPartitionFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java
11 files changed, 2 insertions(+), 130 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/1883/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1883
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1883

to look at the new patch set (#2).

Change subject: [WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.
..

[WIP][ASTERIXDB-1982][FAIL] Unify runtime error reporting.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Unify error reporting in result distribution and operator pipeline.
- Fix the exception list in Task to be thread-safe.

Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/IDatasetDirectoryService.java
D 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/ReportResultPartitionFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java
11 files changed, 2 insertions(+), 130 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/1883/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1883
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [WIP] [ASTERIXDB-1982][FAIL] Fix error reporting in SuperAct...

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1883

Change subject: [WIP] [ASTERIXDB-1982][FAIL] Fix error reporting in 
SuperActivity.
..

[WIP] [ASTERIXDB-1982][FAIL] Fix error reporting in SuperActivity.

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fix error reporting in SuperActivityOperatorNodePushable;
- Unify error reporting in result distribution and operator pipeline.

Change-Id: I36f243c98876ff40e2539ca9241ff6d19fee929f
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/IDatasetDirectoryService.java
D 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/ReportResultPartitionFailureWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/IClusterController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/ClusterControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java
11 files changed, 14 insertions(+), 129 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/83/1883/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
index f79ce53..3119ddd 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetPartitionManager.java
@@ -21,7 +21,6 @@
 import org.apache.hyracks.api.comm.IFrameWriter;
 import org.apache.hyracks.api.context.IHyracksTaskContext;
 import org.apache.hyracks.api.exceptions.HyracksException;
-import org.apache.hyracks.api.io.IWorkspaceFileFactory;
 import org.apache.hyracks.api.job.JobId;
 
 public interface IDatasetPartitionManager extends IDatasetManager {
@@ -33,8 +32,6 @@
 
 public void reportPartitionWriteCompletion(JobId jobId, ResultSetId 
resultSetId, int partition)
 throws HyracksException;
-
-public void reportPartitionFailure(JobId jobId, ResultSetId resultSetId, 
int partition) throws HyracksException;
 
 public void initializeDatasetPartitionReader(JobId jobId, ResultSetId 
resultSetId, int partition, IFrameWriter noc)
 throws HyracksException;
diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
index 7fdf106..5126d71 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
@@ -25,8 +25,9 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
-import java.util.Map.Entry;
 import java.util.Queue;
+import java.util.Map.Entry;
+import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.Future;
 import java.util.concurrent.Semaphore;
 
@@ -192,6 +193,7 @@
 
 private void runInParallel(OperatorNodePushableAction action) throws 
HyracksDataException {
 List tasks = new ArrayList<>();
+List exceptions = new CopyOnWriteArrayList();
 final Semaphore startSemaphore = new Semaphore(1 - 
operatorNodePushablesBFSOrder.size());
 final Semaphore completeSemaphore = new Semaphore(1 - 
operatorNodePushablesBFSOrder.size());
 try {
@@ -200,6 +202,8 @@
 

Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Corre...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for 
Correlated Datasets
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1845
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I100fc0b86b8a6fa36a95d77806107bad0307544e
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Luo Chen 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1986][DOC] Remove auto plural documentation.

[Yingyi Bu (Code Review)]

Yingyi Bu has submitted this change and it was merged.

Change subject: [ASTERIXDB-1986][DOC] Remove auto plural documentation.
..


[ASTERIXDB-1986][DOC] Remove auto plural documentation.

Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1878
Sonar-Qube: Jenkins 
Reviewed-by: Till Westmann 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
1 file changed, 20 insertions(+), 71 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
index e98510d..e44b6a7 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
@@ -930,33 +930,22 @@
"uid": 2
} ]
 
-Because this is a fairly common case, a third variant with output identical to 
the second variant is also possible:
-
-# Example
-
-SELECT uid, msg AS msgs
-FROM GleambookMessages gbm
-GROUP BY gbm.authorId AS uid
-GROUP AS g(gbm as msg);
-
-This variant of the query exploits a bit of SQL-style "syntactic sugar" that 
SQL++ offers to shorten some user queries.
-In particular, in the `SELECT` list, the reference to the `GROUP` variable 
field `msg` -- because it references a field of the group variable -- is 
allowed but is "pluralized". As a result, the `msg` reference in the `SELECT` 
list is
-implicitly rewritten into the second variant's `SELECT VALUE` subquery.
-
 The next example shows a more interesting case involving the use of a subquery 
in the `SELECT` list.
 Here the subquery further processes the groups.
+There is no renaming in the declaration of the group variable `g` such that
+`g` only has one field `gbm` which comes from the `FROM` clause.
 
 # Example
 
 SELECT uid,
-   (SELECT VALUE g.msg
+   (SELECT VALUE g.gbm
 FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
+WHERE g.gbm.message LIKE '% like%'
+ORDER BY g.gbm.messageId
 LIMIT 2) AS msgs
 FROM GleambookMessages gbm
 GROUP BY gbm.authorId AS uid
-GROUP AS g(gbm as msg);
+GROUP AS g;
 
 This example query returns:
 
@@ -1014,14 +1003,14 @@
 # Example
 
 SELECT authorId,
-   (SELECT VALUE g.msg
+   (SELECT VALUE g.gbm
 FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
+WHERE g.gbm.message LIKE '% like%'
+ORDER BY g.gbm.messageId
 LIMIT 2) AS msgs
 FROM GleambookMessages gbm
 GROUP BY gbm.authorId
-GROUP AS g(gbm as msg);
+GROUP AS g;
 
 This query returns:
 
@@ -1071,54 +1060,11 @@
 ### Implicit Group Variables
 The group variable itself is also optional in SQL++'s `GROUP BY` syntax.
 If a user's query does not declare the name and structure of the group 
variable using `GROUP AS`,
-the query compiler will generate a unique group variable whose fields include 
all of the
-binding variables defined in the `FROM` clause of the current enclosing 
`SELECT` statement.
-(In this case the user's query will not be able to refer to the generated 
group variable.)
+the query compiler will generate a unique group variable whose fields include 
all of the binding
+variables defined in the `FROM` clause of the current enclosing `SELECT` 
statement.
+In this case the user's query will not be able to refer to the generated group 
variable,
+but is able to call SQL-92 aggregation functions as in SQL-92.
 
-# Example
-
-SELECT uid,
-   (SELECT m.message
-FROM message m
-WHERE m.message LIKE '% like%'
-ORDER BY m.messageId
-LIMIT 2) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid;
-
-This query returns:
-
-[ {
-"msgs": [
-{
-"message": " like ccast the 3G is awesome:)"
-}
-],
-"uid": 1
-}, {
-"msgs": [
-{
-"message": " like product-y the plan is amazing"
-},
-{
-"message": " like product-z its platform is mind-blowing"
-}
-],
-"uid": 2
-} ]
-
-Note that in the query above, in principle, `message` is not an in-scope 
variable in the `SELECT` clause.
-However, the query above is a syntactically-sugared simplification of the 
following query and it is thus
-legal, executable, and returns the same result:
-

Change in asterixdb[master]: [ASTERIXDB-1986][DOC] Remove auto plural documentation.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1878

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1986][DOC] Remove auto plural documentation.
..

[ASTERIXDB-1986][DOC] Remove auto plural documentation.

Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
1 file changed, 20 insertions(+), 71 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1878/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1878
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1986][DOC] Remove auto plural documentation.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1878

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1986][DOC] Remove auto plural documentation.
..

[ASTERIXDB-1986][DOC] Remove auto plural documentation.

Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
1 file changed, 22 insertions(+), 74 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1878/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1878
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1985][CLUS] Add rebalance callback

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1985][CLUS] Add rebalance callback
..


Patch Set 12:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1863/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

PS11, Line 44: ster
> Where do we use this?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1863/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java:

PS5, Line 317: int[] primaryKeyFields = 
getPrimaryKeyPermutationForUpsert(target);
 : return new AlgebricksMetaOperatorDescriptor(spec, 1, 0,
> instead of this, do:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1985][CLUS] Add rebalance callback

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#12).

Change subject: [ASTERIXDB-1985][CLUS] Add rebalance callback
..

[ASTERIXDB-1985][CLUS] Add rebalance callback

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
9 files changed, 199 insertions(+), 36 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [ASTERIXDB-1985][CLUS] Add rebalance callback

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#11).

Change subject: [ASTERIXDB-1985][CLUS] Add rebalance callback
..

[ASTERIXDB-1985][CLUS] Add rebalance callback

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
9 files changed, 201 insertions(+), 36 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [ASTERIXDB-1985][CLUS] Add rebalance callback

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#10).

Change subject: [ASTERIXDB-1985][CLUS] Add rebalance callback
..

[ASTERIXDB-1985][CLUS] Add rebalance callback

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
9 files changed, 200 insertions(+), 36 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [DOC]Remove auto plural documentation.

[Yingyi Bu (Code Review)]

Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1878

Change subject: [DOC]Remove auto plural documentation.
..

[DOC]Remove auto plural documentation.

Change-Id: If18db7bea1a2b51f6f75f73ed5970eaa1c6e0437
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
1 file changed, 22 insertions(+), 74 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/78/1878/1

diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
index e98510d..85ede37 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
@@ -930,33 +930,22 @@
"uid": 2
} ]
 
-Because this is a fairly common case, a third variant with output identical to 
the second variant is also possible:
-
-# Example
-
-SELECT uid, msg AS msgs
-FROM GleambookMessages gbm
-GROUP BY gbm.authorId AS uid
-GROUP AS g(gbm as msg);
-
-This variant of the query exploits a bit of SQL-style "syntactic sugar" that 
SQL++ offers to shorten some user queries.
-In particular, in the `SELECT` list, the reference to the `GROUP` variable 
field `msg` -- because it references a field of the group variable -- is 
allowed but is "pluralized". As a result, the `msg` reference in the `SELECT` 
list is
-implicitly rewritten into the second variant's `SELECT VALUE` subquery.
-
 The next example shows a more interesting case involving the use of a subquery 
in the `SELECT` list.
 Here the subquery further processes the groups.
+There is no renaming in the declaration of the group variable `g` such that
+`g` only has one field `gbm` which comes from the `FROM` clause.
 
 # Example
 
 SELECT uid,
-   (SELECT VALUE g.msg
+   (SELECT VALUE g.gbm
 FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
+WHERE g.gbm.message LIKE '% like%'
+ORDER BY g.gbm.messageId
 LIMIT 2) AS msgs
 FROM GleambookMessages gbm
 GROUP BY gbm.authorId AS uid
-GROUP AS g(gbm as msg);
+GROUP AS g;
 
 This example query returns:
 
@@ -1014,14 +1003,14 @@
 # Example
 
 SELECT authorId,
-   (SELECT VALUE g.msg
+   (SELECT VALUE g.gbm
 FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
+WHERE g.gbm.message LIKE '% like%'
+ORDER BY g.gbm.messageId
 LIMIT 2) AS msgs
 FROM GleambookMessages gbm
 GROUP BY gbm.authorId
-GROUP AS g(gbm as msg);
+GROUP AS g;
 
 This query returns:
 
@@ -1068,57 +1057,13 @@
 Based on the three variable generation rules, the generated variable for the 
grouping key expression `message.authorId`
 is `authorId` (which is how it is referred to in the example's `SELECT` 
clause).
 
-### Implicit Group Variables
-The group variable itself is also optional in SQL++'s `GROUP BY` syntax.
-If a user's query does not declare the name and structure of the group 
variable using `GROUP AS`,
+### Implicit Group Variables

+The group variable itself is also optional in SQL++'s `GROUP BY` syntax.

+If a user's query does not declare the name and structure of the group 
variable using `GROUP AS`,

 the query compiler will generate a unique group variable whose fields include 
all of the
-binding variables defined in the `FROM` clause of the current enclosing 
`SELECT` statement.
-(In this case the user's query will not be able to refer to the generated 
group variable.)
-
-# Example
-
-SELECT uid,
-   (SELECT m.message
-FROM message m
-WHERE m.message LIKE '% like%'
-ORDER BY m.messageId
-LIMIT 2) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid;
-
-This query returns:
-
-[ {
-"msgs": [
-{
-"message": " like ccast the 3G is awesome:)"
-}
-],
-"uid": 1
-}, {
-"msgs": [
-{
-"message": " like product-y the plan is amazing"
-},
-{
-"message": " like product-z its platform is mind-blowing"
-}
-],
-"uid": 2
-} ]
-
-Note that in the query above, in principle, `message` is not an in-scope 
variable in the `SELECT` clause.
-However, the query above is a syntactically-sugared simplification of the 
following query and it is thus
-legal, executable, and returns the same result:
-
-SELECT uid,
-   (SELECT g.msg.message
-FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
-LIMIT 2) AS msgs
-FROM GleambookMessages gbm
-GROUP BY gbm.authorId AS uid GROUP AS g(gbm as msg);
+binding variables defined in the 

Change in asterixdb[master]: Add rebalance callback.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#7).

Change subject: Add rebalance callback.
..

Add rebalance callback.

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
1 file changed, 22 insertions(+), 74 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: WIP: Add rebalance callback.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#5).

Change subject: WIP: Add rebalance callback.
..

WIP: Add rebalance callback.

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
9 files changed, 136 insertions(+), 34 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: WIP: Add rebalance callback.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#3).

Change subject: WIP: Add rebalance callback.
..

WIP: Add rebalance callback.

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
A 
cbas-connector/src/main/java/com/couchbase/analytics/runtime/DcpStateWriteOperatorDescriptor.java
A cbas-connector/src/main/java/com/couchbase/analytics/util/DcpUtil.java
A cbas-server/pom.xml
A 
cbas-server/src/main/java/com/couchbase/analytics/control/rebalance/Rebalance.java
A 
cbas-server/src/main/java/com/couchbase/analytics/control/rebalance/ShadowStateWriteCallback.java
A 
cbas-test/cbas-cbserver-test/src/test/java/com/couchbase/analytics/test/cbserver/ClusterExecutionIT.java
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.001.ddl.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.002.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.004.pollquery.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.005.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.006.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.007.cb.cmd
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.008.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.009.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.010.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.011.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.012.cb.cmd
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.013.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.014.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.015.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.016.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.017.cb.cmd
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.018.update.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.019.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.020.query.sqlpp
A 
cbas-test/cbas-cbserver-test/src/test/resources/runtimets/queries/rebalance/connect-multiple-filtered-buckets/connect-multiple-filtered-buckets.021.update.sqlpp
A 

Change in asterixdb[master]: WIP: Add rebalance callback.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#4).

Change subject: WIP: Add rebalance callback.
..

WIP: Add rebalance callback.

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
9 files changed, 136 insertions(+), 34 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-1959][COMP] Fixed wrong result with non-enforced ...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1959][COMP] Fixed wrong result with non-enforced 
index
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1872
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe3c9c8045411939d3ad946f6e3b6105ebe1f5a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1980][FUNC] Cleanup FunctionManager lifecycle

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1980][FUNC] Cleanup FunctionManager lifecycle
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1873
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If96e425a096bc0312a68d81b04686d7165f1a1fd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for Corre...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1946][STO][IDX]Create RTree/InvertedIdx for 
Correlated Datasets
..


Patch Set 7:

(15 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1845/3/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql:

PS3, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/4/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.6.txnqbc.aql:

PS4, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/3/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql:

PS3, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/4/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql:

PS4, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_correlated_rtree_index/primary_plus_correlated_rtree_index.9.txnqar.aql:

PS7, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/3/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql:

PS3, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/4/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql:

PS4, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.6.txnqbc.aql:

PS7, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/3/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql:

PS3, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/4/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql:

PS4, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1845/7/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_correlated_secondary_index/primary_plus_keyword_correlated_secondary_index.9.txnqar.aql
File 

Change in asterixdb[master]: [ASTERIXDB-1972][COMP][RT][TX] index-only plan

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1972][COMP][RT][TX] index-only plan
..


Patch Set 13:

(31 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1866/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 595: } catch (HyracksDataException e) {
> CRITICAL SonarQube violation:
fix this?


Line 608: } catch (HyracksDataException e) {
> CRITICAL SonarQube violation:
Fix this?


PS13, Line 750:  // Are we transforming a join plan?
considering keeping the old method and create a new one for index only?


PS13, Line 752: topOpRef.getValue().getOperatorTag() != 
LogicalOperatorTag.SELECT
is there any chance to make the code agnostic to SELECT?


PS13, Line 939: // If there are ASSIGN operators before the given SELECT or 
JOIN operator, we need to propagate
  : // these variables to the UNIONALL operator, too.
update the comment to be based on variable usage/liveness.


PS13, Line 962: if (afterTopOpRefs != null) {
  : for (Mutable afterTopOpRef : 
afterTopOpRefs) {
  : tmpVars.clear();
  : 
VariableUtilities.getUsedVariables((ILogicalOperator) afterTopOpRef.getValue(), 
tmpVars);
  : for (LogicalVariable tmpVar : tmpVars) {
  : if 
(!usedVarsAfterTopOp.contains(tmpVar)) {
  : usedVarsAfterTopOp.add(tmpVar);
  : }
  : }
  : }
  : }
OperatorPropertiesUtils.getFreeVaraibles()


PS13, Line 977: 
  : // Is the used variables after SELECT operator from 
the primary index?
  :  
UnionAll need to generate new variable, so that the query plan can stay as SSA 
form.  

You have a top-down pass to keep variables that needs to be retained and have a 
bottom-up pass to replace variables according to the mapping produced by the 
down stream.


PS13, Line 1077: unionVarMap.add(new Triple<>(v, v, v));
make v/v/v as SSA?

v1/v2/v3


PS13, Line 1376: else {
   : // Non-index-only plan optimization - still 
index-utilization plan.
   : return primaryIndexUnnestOp;
   : }
Pull that into a separate if block and then the current if branch doesn't need 
nesting.


PS13, Line 1644: ILogicalOperator tmpOp = indexSubTree.getRoot();
   : while (tmpOp.getOperatorTag()
OperatorPropertiesUtil.getFreeVariables(...)


PS13, Line 2396:   return unionAllOp;
   : } else {
   : return unionOp;
   : }
flip condition and reduce if branch.


https://asterix-gerrit.ics.uci.edu/#/c/1866/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java:

Line 95: private static List> 
FUNC_IDENTIFIERS = Collections.unmodifiableList(
> MAJOR SonarQube violation:
final?


PS13, Line 155: secondaryKeyFieldUsedAfterSelectOp 
this variable is not needed for B-tree?


PS13, Line 218: || dataSourceRefOp.getOperatorTag() == 
LogicalOperatorTag.LEFT_OUTER_UNNEST_MAP
Is the or branch covered by any tests?


PS13, Line 232:  // The whole plan is now changed into an index-only plan
you only use primary index for this branch, why it is related to index only?


PS13, Line 240: dataSourceRefOp.getOperatorTag() == 
LogicalOperatorTag.LEFT_OUTER_UNNEST_MAP
same as above


PS13, Line 305: boolean secondaryKeyFieldUsedAfterJoinOp = false;
Is this variable necessary?


PS13, Line 349: IsNull
IsNull -> isMissing?


PS13, Line 391: primaryIndexUnnestOp
rename the variable?

Replace the if-else with an one line conditional expression.


https://asterix-gerrit.ics.uci.edu/#/c/1866/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java:

PS13, Line 384: intersectAllSecondaryIndexes
factor out single index handling as another method and call the new method in 
the else block.


https://asterix-gerrit.ics.uci.edu/#/c/1866/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/RTreeAccessMethod.java:

PS13, Line 240: 

Change in asterixdb[master]: [ASTERIXDB-1975][COMP] Joins using non-enforced secondary in...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1975][COMP] Joins using non-enforced secondary 
indexes
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1869
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc90ebe439a9b45b72ca549ba7ee9e1881221524
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1976][FUN] Invoke code generation from asterix-ru...

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [ASTERIXDB-1976][FUN] Invoke code generation from 
asterix-runtime module
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bb9a2cef1d346242c65d76378fbbf0e18a94bfe
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP: Add rebalance callback.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1863

to look at the new patch set (#2).

Change subject: WIP: Add rebalance callback.
..

WIP: Add rebalance callback.

Change-Id: I9a90ba975467c136371236195f82d48430d8319d
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/IDatasetRebalanceCallback.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/rebalance/NoOpDatasetRebalanceCallback.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FlushDatasetUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/RebalanceUtil.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/utils/ComponentMetadataUtil.java
8 files changed, 125 insertions(+), 22 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/63/1863/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a90ba975467c136371236195f82d48430d8319d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins