[jira] [Updated] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10093: -- Issue Type: Improvement (was: Sub-task) Parent: (was: OFBIZ-9978) > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541189#comment-16541189 ] Aditya Sharma commented on OFBIZ-10093: --- Ohh Yes, I just missed on limitations with LGPL license. Quill with 'BSD 3-Clause "New" or "Revised" License' seems more promising with a quite good active community. I will update the current ticket. > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540589#comment-16540589 ] Jacques Le Roux commented on OFBIZ-10093: - Hi Aditya, Since the remaining warnings depend on an unavailable JQuery UI release, I'd close OFBIZ-9978 noting that. And make the issue here just linked as related to OFBIZ-9978. I'd also create a new task to prepare the next effort for JQuery UI when available and link it to OFBIZ-9978. We have a problem with TinyMCE though. Because it's LGPL licensed we can't embed it in OFBiz. I found this alternative https://quilljs.com/guides/comparison-with-other-rich-text-editors/ > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540520#comment-16540520 ] Jacques Le Roux commented on OFBIZ-7598: OK, then +1 commit > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540280#comment-16540280 ] Dennis Balkir commented on OFBIZ-7598: -- Hi Jacques, I didn't see the button at first, too. But now that I have found it (I didn't knew this existed to be honest), applying the patch worked. I tested it on some entity searches and it looks like it is working fine: * for no found entries, no header * for found entries it shows the header and the found entries Looks like it works fine for one found entry, too > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540200#comment-16540200 ] Jacques Le Roux commented on OFBIZ-7598: Cool :) > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with TinyMCE.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540093#comment-16540093 ] Aditya Sharma commented on OFBIZ-10093: --- Hi Pierre, Jacques, I have added it as a subtask because in order to suppress all JQuery migrate warnings we need to either upgrade ELRTE plugin or replace it. ELRTE community no longer supports the plugin so it was better to switch to an alternative. Though if we remove it from subtask still OFBIZ-9978 cannot be closed now. There are some warnings with [jQuery Ui|https://jqueryui.com/]: * jQuery.expr[":"] is now jQuery.expr.pseudos in jquery-ui.min.js * jQuery.expr.filters is now jQuery.expr.pseudos in query-ui.min.js * jQuery.unique is deprecated, use jQuery.uniqueSort OFBiz is on latest JQuery UI release & we have to wait for the next release. Though I don't find any problem removing it as subtask and just linking it to OFBIZ-9978. WDYT should be done? > Replace ELRTE plugin with TinyMCE. > -- > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > https://github.com/Studio-42/elRTE it is to be replaced with some other good > editor like TinyMCE: > * 171 releases (latest 14 days ago) > * Good community support of 171 contributors > * Licence - GNU LESSER GENERAL PUBLIC LICENSE Version 2.1, February 1999 > Links for reference: > https://github.com/tinymce/tinymce. > https://www.tinymce.com/download/ > https://www.tinymce.com/docs/configure/localization/ > https://www.tinymce.com/download/language-packages/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540064#comment-16540064 ] Michael Brohl commented on OFBIZ-7598: -- Ah, sorry Jacques. i did not see the button in the screenshot, I had to scoll right first. I think Dennis already found it... > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540039#comment-16540039 ] Jacques Le Roux commented on OFBIZ-7598: But the patch is ready, why not using the guess button as explained in the image I made the effort to attach? > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540013#comment-16540013 ] Michael Brohl commented on OFBIZ-7598: -- Why not just provide a new patch or describe the guess, this would be more efficient. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10307) Navigate from a domain to another with automated signed in authentication
[ https://issues.apache.org/jira/browse/OFBIZ-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540010#comment-16540010 ] Jacques Le Roux edited comment on OFBIZ-10307 at 7/11/18 12:25 PM: --- Oops :D, I wrote bq.To my surprise this morning the link to the trunk demo no longer works Of course, because I removed the changes from the trunk :D That's what happens when you get back to a subject after months of waiting :) was (Author: jacques.le.roux): Oops :D, I wrote bq.To my surprise this morning the link to the trunk demo no longer works Of course, because I removed the changes from the trunk :D > Navigate from a domain to another with automated signed in authentication > - > > Key: OFBIZ-10307 > URL: https://issues.apache.org/jira/browse/OFBIZ-10307 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10307-test from example.patch, > OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, OFBIZ-10307.patch, > OFBIZ-10307.patch > > > This will use a JWT Token authentication to get from one domain, where you > are signed in, to another domain where you get signed in automatically. > Something like ExternalLoginKey or Tomcat SSO, but not on the same domain. > This will build upon the initial work done at OFBIZ-9833 which has been > partially reverted in trunk with r1827439 (see OFBIZ-10304) and r1827441. I > explained why and what I did at [https://s.apache.org/a5Km] > I turned to Ajax for the "Authorization" header sending. I initially thought > I'd just pass an "Authorization" header and use it in the > externalServerLoginCheck preprocessor, et voilà. > But I stumbled upon something I did not know well : CORS! And in particular > the upstream control (Pre-verified requests): > > [https://en.wikipedia.org/wiki/Cross-origin_resource_sharing#Preflight_example] > [https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS] > [https://www.w3.org/TR/cors/] > To be able to pass an "Authorization" header, the server must respond > positively in the Preflight HTTP response (OPTIONS). To do this, either you > use a Tomcat filter (or your own filter, there are examples on the Net) or > use HTTPD (or Nginx) configuration on the target server. > I tried Tomcat first, without success. With HTTPD it's easier just 3 lines. > For my tests, future tests by OFBiz users and as an example, I asked infra to > put them in our HTTPD trunk demo config: > Header set Access-Control-Allow-Origin "https://localhost:8443"; > Header set Access-Control-Allow-Headers "Authorization" > Header set Access-Control-Allow-Credentials "true" > No code change (either in all web.xml files for Tomcat or Java for own > filter), and more safety. It does not give more right to outsiders than what > we give with the admin credential. > In Header set Access-Control-Allow-Origin you can put more domains. I just > used [https://localhost:8443|https://localhost:8443/] for the tests. > It works in Chrome, Firefox and Opera and partially in IE11 (not tested in > Edge). I did not test Safari, but I guess like other modern browsers it > should work. > For those (very few I guess) interested by IE11 (for Edge test yourself and > report please), here is the solution > > [https://stackoverflow.com/questions/12643960/internet-explorer-10-is-ignoring-xmlhttprequest-xhr-withcredentials-true] > > [https://web.archive.org/web/20130308142134/http://msdn.microsoft.com/en-us/library/ms537343%28v=vs.85%29.aspx] > > [https://blogs.msdn.microsoft.com/ieinternals/2013/09/17/a-quick-look-at-p3p/] > TODO (maybe) in the future, use the new Fetch API (not available yet): > [https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API] > > Here is a complement about the way it's architectured: > # A change to cookies was introduced with OFBIZ-4959. Actually it was not > really a bug rather a clean-up. The autoLogin cookies were only used by the > ecommerce component and maybe webpos. But all applications were creating such > cookies with a one year duration. They were useless until I needed them for > the feature of this Jira issue. But even if they were safe (httponly) then I > needed them to be clean, not a one year duration (to be as safe as possible, > temporary cookies are better). So after doing it crudely, [inspired by > Taher's suggestion|[https://s.apache.org/qLGC]] I introduced the > keep-autologin-cookie attribute in ofbiz-component.xml. It's used to > remove not kept cookies when login in or out. So those cookies are only kept > during a session. Also a cookie
[jira] [Commented] (OFBIZ-10307) Navigate from a domain to another with automated signed in authentication
[ https://issues.apache.org/jira/browse/OFBIZ-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540010#comment-16540010 ] Jacques Le Roux commented on OFBIZ-10307: - Oops :D, I wrote bq.To my surprise this morning the link to the trunk demo no longer works Of course, because I removed the changes from the trunk :D > Navigate from a domain to another with automated signed in authentication > - > > Key: OFBIZ-10307 > URL: https://issues.apache.org/jira/browse/OFBIZ-10307 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10307-test from example.patch, > OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, OFBIZ-10307.patch, > OFBIZ-10307.patch > > > This will use a JWT Token authentication to get from one domain, where you > are signed in, to another domain where you get signed in automatically. > Something like ExternalLoginKey or Tomcat SSO, but not on the same domain. > This will build upon the initial work done at OFBIZ-9833 which has been > partially reverted in trunk with r1827439 (see OFBIZ-10304) and r1827441. I > explained why and what I did at [https://s.apache.org/a5Km] > I turned to Ajax for the "Authorization" header sending. I initially thought > I'd just pass an "Authorization" header and use it in the > externalServerLoginCheck preprocessor, et voilà. > But I stumbled upon something I did not know well : CORS! And in particular > the upstream control (Pre-verified requests): > > [https://en.wikipedia.org/wiki/Cross-origin_resource_sharing#Preflight_example] > [https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS] > [https://www.w3.org/TR/cors/] > To be able to pass an "Authorization" header, the server must respond > positively in the Preflight HTTP response (OPTIONS). To do this, either you > use a Tomcat filter (or your own filter, there are examples on the Net) or > use HTTPD (or Nginx) configuration on the target server. > I tried Tomcat first, without success. With HTTPD it's easier just 3 lines. > For my tests, future tests by OFBiz users and as an example, I asked infra to > put them in our HTTPD trunk demo config: > Header set Access-Control-Allow-Origin "https://localhost:8443"; > Header set Access-Control-Allow-Headers "Authorization" > Header set Access-Control-Allow-Credentials "true" > No code change (either in all web.xml files for Tomcat or Java for own > filter), and more safety. It does not give more right to outsiders than what > we give with the admin credential. > In Header set Access-Control-Allow-Origin you can put more domains. I just > used [https://localhost:8443|https://localhost:8443/] for the tests. > It works in Chrome, Firefox and Opera and partially in IE11 (not tested in > Edge). I did not test Safari, but I guess like other modern browsers it > should work. > For those (very few I guess) interested by IE11 (for Edge test yourself and > report please), here is the solution > > [https://stackoverflow.com/questions/12643960/internet-explorer-10-is-ignoring-xmlhttprequest-xhr-withcredentials-true] > > [https://web.archive.org/web/20130308142134/http://msdn.microsoft.com/en-us/library/ms537343%28v=vs.85%29.aspx] > > [https://blogs.msdn.microsoft.com/ieinternals/2013/09/17/a-quick-look-at-p3p/] > TODO (maybe) in the future, use the new Fetch API (not available yet): > [https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API] > > Here is a complement about the way it's architectured: > # A change to cookies was introduced with OFBIZ-4959. Actually it was not > really a bug rather a clean-up. The autoLogin cookies were only used by the > ecommerce component and maybe webpos. But all applications were creating such > cookies with a one year duration. They were useless until I needed them for > the feature of this Jira issue. But even if they were safe (httponly) then I > needed them to be clean, not a one year duration (to be as safe as possible, > temporary cookies are better). So after doing it crudely, [inspired by > Taher's suggestion|[https://s.apache.org/qLGC]] I introduced the > keep-autologin-cookie attribute in ofbiz-component.xml. It's used to > remove not kept cookies when login in or out. So those cookies are only kept > during a session. Also a cookie is created when an user jumps from one > application to another on the source domain. These cookies are used when > navigating from a domain to another to guarantee the safety of the user who > jumps from the source domain to the target domain. Note that protected > cookies (httponly) are one of the safer way
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540001#comment-16540001 ] Jacques Le Roux commented on OFBIZ-7598: I answered to that 6 days ago bq. Same here but passes with a Guess (of 1) Could you try please? > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539959#comment-16539959
]
Dennis Balkir commented on OFBIZ-7598:
--
I see, there truly was a misunderstanding.
I wanted to try it, but as I mentioned before in this issue, I could not fully
apply it.
My comment from the 4th:
{quote}Hi Suraj Khurana,
I tried to apply the patch via eclipse using an up-to-date trunk branch, but
there seems to be a difference in the file
themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl, which results in
some incompability.
Can you please check for that?
Thanks{quote}
> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch,
> OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png
>
>
> If list inside form doesn't contain data, then header row should not render
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10472) Rename the misnamed setUserLocale.js to setUserTimeZone.js
[ https://issues.apache.org/jira/browse/OFBIZ-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10472. --- Resolution: Implemented Fix Version/s: Upcoming Branch Done at r1835628 with "documentation" (a comment) added about the auth mismatch as suggested by Mathieu in OFBIZ-10460 > Rename the misnamed setUserLocale.js to setUserTimeZone.js > -- > > Key: OFBIZ-10472 > URL: https://issues.apache.org/jira/browse/OFBIZ-10472 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > Because this anme is confusing as it's only about handling user timezone. It > was done with OFBIZ-9264 and improved/fixed since -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539904#comment-16539904 ] Jacques Le Roux commented on OFBIZ-7598: Ah, there is a misunderstanding, by last patch I mean really the last one available here, the one from one week ago. Did you try it? > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539901#comment-16539901 ] Jacques Le Roux commented on OFBIZ-10464: - OK thanks > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10472) Rename the misnamed setUserLocale.js to setUserTimeZone.js
[ https://issues.apache.org/jira/browse/OFBIZ-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539806#comment-16539806 ] Jacques Le Roux commented on OFBIZ-10472: - At the same time rename setLocaleFromBrowser to SetTimeZoneFromBrowser everywhere it's needed > Rename the misnamed setUserLocale.js to setUserTimeZone.js > -- > > Key: OFBIZ-10472 > URL: https://issues.apache.org/jira/browse/OFBIZ-10472 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > > Because this anme is confusing as it's only about handling user timezone. It > was done with OFBIZ-9264 and improved/fixed since -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539797#comment-16539797 ] Dennis Balkir commented on OFBIZ-10464: --- I already created a Jira for AR: OFBIZ-10469 > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539795#comment-16539795 ] Dennis Balkir commented on OFBIZ-7598: -- Hi Jacques, yes I mean with the now reverted patch. I just specified this, because you asked for it :) > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10460) setLocaleFromBrowser requires authentification
[
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539788#comment-16539788
]
Jacques Le Roux commented on OFBIZ-10460:
-
Good idea Mathieu, will do so
> setLocaleFromBrowser requires authentification
> --
>
> Key: OFBIZ-10460
> URL: https://issues.apache.org/jira/browse/OFBIZ-10460
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has
> an attribute of {{auth=false}}
> {code:xml}
>
>
>
>
>
>
> {code}
> while the service associated with it in
> {{framework/common/servicedef/services.xml}} has an attribute of
> {{auth=true}}.
> {code:xml}
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy"
> invoke="setLocaleFromBrowser" auth="true">
> Set locale from browser.
>
>
> {code}
> It seems like a (minor) bug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10307) Navigate from a domain to another with automated signed in authentication
[
https://issues.apache.org/jira/browse/OFBIZ-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539785#comment-16539785
]
Jacques Le Roux commented on OFBIZ-10307:
-
To my surprise this morning the link to the trunk demo no longer works. I mean
you still have to sign in. This is weird because the link to jleroux.nereide.fr
still works and they share the same code and CORS config :-o.
After checking by myself I have asked Infra about possible change on their side.
{quote}Hi Infra team,
I did not see any recent changes in Puppet for the OFBiz-VM, but it seems
something happened to the OFBiz-VM
Yesterday all the demos were down, not even running at all
And today I tested a CORS functionality which works on a personal domain but
not in the OFBiz-VM despite having the same HTTPD CORS config
Any idea for the CORS issue?
This was working a month ago...
The setting, only in /etc/apache2/sites-enabled/25-ofbiz-trunk-vm2-443.conf, is
{code:java}
Header set Access-Control-Allow-Origin "https://localhost:8443";
Header set Access-Control-Allow-Headers "Authorization"
Header set Access-Control-Allow-Credentials "true"
{code}
But the calls don't pass, unlike on the personnal site (same code, same HTTPD
config)
If some recent infra change could be related please tell me :)
BTW I already restarted apache2
{quote}
No answer for now...
I'll anyway change the patch to use Deepak's code at OFBIZ-9833
> Navigate from a domain to another with automated signed in authentication
> -
>
> Key: OFBIZ-10307
> URL: https://issues.apache.org/jira/browse/OFBIZ-10307
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10307-test from example.patch,
> OFBIZ-10307-test.patch, OFBIZ-10307-test.patch, OFBIZ-10307.patch,
> OFBIZ-10307.patch
>
>
> This will use a JWT Token authentication to get from one domain, where you
> are signed in, to another domain where you get signed in automatically.
> Something like ExternalLoginKey or Tomcat SSO, but not on the same domain.
> This will build upon the initial work done at OFBIZ-9833 which has been
> partially reverted in trunk with r1827439 (see OFBIZ-10304) and r1827441. I
> explained why and what I did at [https://s.apache.org/a5Km]
> I turned to Ajax for the "Authorization" header sending. I initially thought
> I'd just pass an "Authorization" header and use it in the
> externalServerLoginCheck preprocessor, et voilà.
> But I stumbled upon something I did not know well : CORS! And in particular
> the upstream control (Pre-verified requests):
>
> [https://en.wikipedia.org/wiki/Cross-origin_resource_sharing#Preflight_example]
> [https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS]
> [https://www.w3.org/TR/cors/]
> To be able to pass an "Authorization" header, the server must respond
> positively in the Preflight HTTP response (OPTIONS). To do this, either you
> use a Tomcat filter (or your own filter, there are examples on the Net) or
> use HTTPD (or Nginx) configuration on the target server.
> I tried Tomcat first, without success. With HTTPD it's easier just 3 lines.
> For my tests, future tests by OFBiz users and as an example, I asked infra to
> put them in our HTTPD trunk demo config:
> Header set Access-Control-Allow-Origin "https://localhost:8443";
> Header set Access-Control-Allow-Headers "Authorization"
> Header set Access-Control-Allow-Credentials "true"
> No code change (either in all web.xml files for Tomcat or Java for own
> filter), and more safety. It does not give more right to outsiders than what
> we give with the admin credential.
> In Header set Access-Control-Allow-Origin you can put more domains. I just
> used [https://localhost:8443|https://localhost:8443/] for the tests.
> It works in Chrome, Firefox and Opera and partially in IE11 (not tested in
> Edge). I did not test Safari, but I guess like other modern browsers it
> should work.
> For those (very few I guess) interested by IE11 (for Edge test yourself and
> report please), here is the solution
>
> [https://stackoverflow.com/questions/12643960/internet-explorer-10-is-ignoring-xmlhttprequest-xhr-withcredentials-true]
>
> [https://web.archive.org/web/20130308142134/http://msdn.microsoft.com/en-us/library/ms537343%28v=vs.85%29.aspx]
>
> [https://blogs.msdn.microsoft.com/ieinternals/2013/09/17/a-quick-look-at-p3p/]
> TODO (maybe) in the future, use the new Fetch API (not available yet):
> [https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API]
>
> Here is a complement about the way it's architectured:
> # A
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539778#comment-16539778 ] Jacques Le Roux commented on OFBIZ-7598: Hi Dennis, So you mean that with the last patch, right? > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10454) Align the input fields at catalog/control/main
[ https://issues.apache.org/jira/browse/OFBIZ-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539772#comment-16539772 ] Jacques Le Roux commented on OFBIZ-10454: - In the meantime, before using form widgets, I separateed forms with form-container and especially horizontal rules at r1835620 I noticed we miss a LookupProductCatalog... > Align the input fields at catalog/control/main > -- > > Key: OFBIZ-10454 > URL: https://issues.apache.org/jira/browse/OFBIZ-10454 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > The right solution for r1829700, to align the input fields at > catalog/control/main, is to use a form widget. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10460) setLocaleFromBrowser requires authentification
[
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539769#comment-16539769
]
Mathieu Lirzin commented on OFBIZ-10460:
I would recommend adding a "XXX" comment directly in the code explaining the
reason why we are keeping the mismatch. If the explanation is unclear or too
long to explain properly you can add a link to OFBIZ-10471.
> setLocaleFromBrowser requires authentification
> --
>
> Key: OFBIZ-10460
> URL: https://issues.apache.org/jira/browse/OFBIZ-10460
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has
> an attribute of {{auth=false}}
> {code:xml}
>
>
>
>
>
>
> {code}
> while the service associated with it in
> {{framework/common/servicedef/services.xml}} has an attribute of
> {{auth=true}}.
> {code:xml}
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy"
> invoke="setLocaleFromBrowser" auth="true">
> Set locale from browser.
>
>
> {code}
> It seems like a (minor) bug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539760#comment-16539760 ] Jacques Le Roux commented on OFBIZ-10464: - BTW did you create a Jira for the same for AR? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10470) Inconsistent screenlet-title containers
[
https://issues.apache.org/jira/browse/OFBIZ-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539731#comment-16539731
]
Jacques Le Roux commented on OFBIZ-10470:
-
Hi Dennis,
It would be great if you could come with these conventions. I know an OFBiz
provider which tried to resolve this problem by using more FTL macros. But I
still prefer Widget Forms :)
> Inconsistent screenlet-title containers
> ---
>
> Key: OFBIZ-10470
> URL: https://issues.apache.org/jira/browse/OFBIZ-10470
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Priority: Minor
>
> Through the OFBiz-Backend there is some inconsistency in the use of
> screenlet-titles.
> The title is normally nested inside this:
> {code:html}
>
>
>
> {code}
> But the title itself differs throughout the. backend quite often.
> As far as I have seen, there are 3 main kinds of title:
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
> Title
> {code}
> # {code:html}
>
>
>
> Title
> {code}
> All three variants can be found right here:
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry
> ({{li}} is used in the {{left}}-container, {{h3}} is used for "Create Sales
> Order" and {{div}} is used for the other screenlets)
> Wouldn't it be better to limit this to one kind of container, and maybe style
> the differences (if wanted) through classes?
> Or maybe two containers, which then can be styled differently?
> The way it is now, with most of them looking the same anyway, it seems rather
> confusing than useful
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539728#comment-16539728 ] Jacques Le Roux commented on OFBIZ-10464: - Hi Dennis, Long ago, after creating the Widgets Forms, we decided that we should use FTL with parsimony in the backend. Because it's easier to set rules in Widgets Forms than in FTL where you can digress more easily. And if developers have more possibilites with the code you will see more difference in it ;) But I agree it's unfortunately our legacy (FTL was largely used before Widgets Forms) and it's now hard to get back when it's so easy to tune existing code. And though I'm reluctant to do so, because of lack of time, I think I will do that for OFBIZ-10454 :/ > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10460) setLocaleFromBrowser requires authentification
[
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-10460:
-
> setLocaleFromBrowser requires authentification
> --
>
> Key: OFBIZ-10460
> URL: https://issues.apache.org/jira/browse/OFBIZ-10460
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has
> an attribute of {{auth=false}}
> {code:xml}
>
>
>
>
>
>
> {code}
> while the service associated with it in
> {{framework/common/servicedef/services.xml}} has an attribute of
> {{auth=true}}.
> {code:xml}
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy"
> invoke="setLocaleFromBrowser" auth="true">
> Set locale from browser.
>
>
> {code}
> It seems like a (minor) bug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539698#comment-16539698 ] Jacques Le Roux commented on OFBIZ-10471: - Thanks Deepak, I reverted both at r1835616 > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10460) setLocaleFromBrowser requires authentification
[
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10460.
---
Resolution: Not A Problem
> setLocaleFromBrowser requires authentification
> --
>
> Key: OFBIZ-10460
> URL: https://issues.apache.org/jira/browse/OFBIZ-10460
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has
> an attribute of {{auth=false}}
> {code:xml}
>
>
>
>
>
>
> {code}
> while the service associated with it in
> {{framework/common/servicedef/services.xml}} has an attribute of
> {{auth=true}}.
> {code:xml}
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy"
> invoke="setLocaleFromBrowser" auth="true">
> Set locale from browser.
>
>
> {code}
> It seems like a (minor) bug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10460) setLocaleFromBrowser requires authentification
[
https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539697#comment-16539697
]
Jacques Le Roux commented on OFBIZ-10460:
-
After Deepak's report at OFBIZ-10471, I reverted both at r1835616
> setLocaleFromBrowser requires authentification
> --
>
> Key: OFBIZ-10460
> URL: https://issues.apache.org/jira/browse/OFBIZ-10460
> Project: OFBiz
> Issue Type: Bug
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> The setLocaleFromBrowser request map defined in {{common-controller.xml}} has
> an attribute of {{auth=false}}
> {code:xml}
>
>
>
>
>
>
> {code}
> while the service associated with it in
> {{framework/common/servicedef/services.xml}} has an attribute of
> {{auth=true}}.
> {code:xml}
> location="component://common/groovyScripts/SetLocaleFromBrowser.groovy"
> invoke="setLocaleFromBrowser" auth="true">
> Set locale from browser.
>
>
> {code}
> It seems like a (minor) bug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539696#comment-16539696 ] Deepak Dixit commented on OFBIZ-10471: -- Thanks Jacques, In my case I am not hitting webtools/control/setLocaleFromBrowser, I am accessing webtools/control/main, it redirects to the login page after login system redirect to webtools/control/setLocaleFromBrowser > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10471) setLocaleFromBrowser should only called once by session
[ https://issues.apache.org/jira/browse/OFBIZ-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539684#comment-16539684 ] Jacques Le Roux commented on OFBIZ-10471: - Thanks Deepak, I crossed that too when directly going to catalog/control/setLocaleFromBrowser being logged in or not. Since this should not be called manually I let it go. But indeed webtools is peculiar (we have also OFBIZ-9379). I will revert OFBIZ-10460. It's inconsistent for this reason and better to keep the service protected. > setLocaleFromBrowser should only called once by session > --- > > Key: OFBIZ-10471 > URL: https://issues.apache.org/jira/browse/OFBIZ-10471 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Screen Shot 2018-07-11 at 11.03.02 AM.png > > > As Deepak mentioned in r1816537, currenlty setLocaleFromBrowser is called > each time a page is refreshed. > We can use > [sessionStorage|https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage] > to have it called only once by session -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
[
https://issues.apache.org/jira/browse/OFBIZ-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539657#comment-16539657
]
Aditya Sharma commented on OFBIZ-10473:
---
Thanks Dennis, Pierre and Jacques for the discussion at OFBIZ-10467 :)
This was committed in Trunk at r1835613.
Doesn't require backporting.
> Upper case styling for buttontext in Tomahawk theme causing wrong behaviour
> for alphabetical index of the service engine page
> -
>
> Key: OFBIZ-10473
> URL: https://issues.apache.org/jira/browse/OFBIZ-10473
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> As discussed on OFBIZ-10467, override the upper case styling with a more
> specific rule in Tomahawk theme to avoid upper casing of small case letters
> for alphabetical index of the service engine page
> {code:java}
> .button-bar > a.buttontext {
> text-transform:none!important;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
[
https://issues.apache.org/jira/browse/OFBIZ-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma closed OFBIZ-10473.
-
> Upper case styling for buttontext in Tomahawk theme causing wrong behaviour
> for alphabetical index of the service engine page
> -
>
> Key: OFBIZ-10473
> URL: https://issues.apache.org/jira/browse/OFBIZ-10473
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> As discussed on OFBIZ-10467, override the upper case styling with a more
> specific rule in Tomahawk theme to avoid upper casing of small case letters
> for alphabetical index of the service engine page
> {code:java}
> .button-bar > a.buttontext {
> text-transform:none!important;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
[
https://issues.apache.org/jira/browse/OFBIZ-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma resolved OFBIZ-10473.
---
Resolution: Fixed
Fix Version/s: Upcoming Branch
> Upper case styling for buttontext in Tomahawk theme causing wrong behaviour
> for alphabetical index of the service engine page
> -
>
> Key: OFBIZ-10473
> URL: https://issues.apache.org/jira/browse/OFBIZ-10473
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> As discussed on OFBIZ-10467, override the upper case styling with a more
> specific rule in Tomahawk theme to avoid upper casing of small case letters
> for alphabetical index of the service engine page
> {code:java}
> .button-bar > a.buttontext {
> text-transform:none!important;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
[
https://issues.apache.org/jira/browse/OFBIZ-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-10473:
--
Description:
As discussed on OFBIZ-10467, override the upper case styling with a more
specific rule in Tomahawk theme to avoid upper casing of small case letters for
alphabetical index of the service engine page
{code:java}
.button-bar > a.buttontext {
text-transform:none!important;
}{code}
was:
As discussed on OFBIZ-10467, override the upper case styling with a more
specific rule in Tomahawk theme to avoid upper casing of small case letters
{code:java}
.button-bar > a.buttontext {
text-transform:none!important;
}{code}
> Upper case styling for buttontext in Tomahawk theme causing wrong behaviour
> for alphabetical index of the service engine page
> -
>
> Key: OFBIZ-10473
> URL: https://issues.apache.org/jira/browse/OFBIZ-10473
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed on OFBIZ-10467, override the upper case styling with a more
> specific rule in Tomahawk theme to avoid upper casing of small case letters
> for alphabetical index of the service engine page
> {code:java}
> .button-bar > a.buttontext {
> text-transform:none!important;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
[
https://issues.apache.org/jira/browse/OFBIZ-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-10473:
--
Description:
As discussed on OFBIZ-10467, override the upper case styling with a more
specific rule in Tomahawk theme to avoid upper casing of small case letters
{code:java}
.button-bar > a.buttontext {
text-transform:none!important;
}{code}
> Upper case styling for buttontext in Tomahawk theme causing wrong behaviour
> for alphabetical index of the service engine page
> -
>
> Key: OFBIZ-10473
> URL: https://issues.apache.org/jira/browse/OFBIZ-10473
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed on OFBIZ-10467, override the upper case styling with a more
> specific rule in Tomahawk theme to avoid upper casing of small case letters
> {code:java}
> .button-bar > a.buttontext {
> text-transform:none!important;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10473) Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page
Aditya Sharma created OFBIZ-10473: - Summary: Upper case styling for buttontext in Tomahawk theme causing wrong behaviour for alphabetical index of the service engine page Key: OFBIZ-10473 URL: https://issues.apache.org/jira/browse/OFBIZ-10473 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Trunk Reporter: Aditya Sharma Assignee: Aditya Sharma -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10467. - > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10467) Using "buttontext" styling for the index of service engine
[ https://issues.apache.org/jira/browse/OFBIZ-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539645#comment-16539645 ] Aditya Sharma commented on OFBIZ-10467: --- Thanks Dennis, Pierre and Jacques :) This was committed in Trunk at r1835612. Closing here & will create a separate ticket and fix uppercase styling issue specific to Tomahawk theme as discussed. It is an improvement so doesn't require backporting > Using "buttontext" styling for the index of service engine > -- > > Key: OFBIZ-10467 > URL: https://issues.apache.org/jira/browse/OFBIZ-10467 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Aditya Sharma >Priority: Minor > Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, > image-2018-07-09-16-13-01-707.png, service-engine_buttons.patch > > > To give OFBiz a more equal look, the style "buttontext" can be added for the > alphabetical index of the service engine main page. > This makes the buttons look alike with the ones that are already there for > the entity engine main page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
