[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728462#comment-16728462
 ] 

Jacques Le Roux commented on OFBIZ-5608:


Should we not 1st change the title, is it not confusing? Then we could 
programmatically force the same than Adrian proposed ie set the same than 
{{ignore-time-zone="false"]] for {{ Dates Displaying Incorrectly With Negative Offest Timezones.
> 
>
> Key: OFBIZ-5608
> URL: https://issues.apache.org/jira/browse/OFBIZ-5608
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
>Reporter: Rupert Howell
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: DateField_1.jpg, DateField_2.jpg, French calendar 
> tootip.png, IgnoreTimeZone.patch, ObjectTypeTests.patch, dates.patch, 
> dates_1589040.patch, en-GB calendar tootip.png, sqldate_scenarios.png
>
>
> Dates are displaying incorrectly when negative offset (relative to UTC) are 
> applied by the users settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728444#comment-16728444
 ] 

Jacques Le Roux commented on OFBIZ-7357:


No worries guys, 

It's not related with r1849547. I reverted it and did {{g cleanAll loadAll 
eclipse ofbiz}}: same issue. I see this issue was reported by Arpit Mor at 
OFBIZ-10741

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7357.patch, OFBIZ-7357.patch, OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728448#comment-16728448
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Priya,

About
bq.  say maybe because I think we have a problem with OFBIZ-7357 and I can test 
all I'd like to.

Actually the problem is not with OFBIZ-7357 and was reported by by Arpit Mor at 
OFBIZ-10741 (you are assigned there)

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728448#comment-16728448
 ] 

Jacques Le Roux edited comment on OFBIZ-10536 at 12/24/18 4:21 PM:
---

Priya,

About
bq.  say maybe because I think we have a problem with OFBIZ-7357 and I can test 
all I'd like to.

Actually the problem is not with OFBIZ-7357 and was reported by Arpit Mor at 
OFBIZ-10741 (you are assigned there)


was (Author: jacques.le.roux):
Priya,

About
bq.  say maybe because I think we have a problem with OFBIZ-7357 and I can test 
all I'd like to.

Actually the problem is not with OFBIZ-7357 and was reported by by Arpit Mor at 
OFBIZ-10741 (you are assigned there)

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728447#comment-16728447
 ] 

Jacques Le Roux commented on OFBIZ-10741:
-

So it must be a change in data...

> Blank page is displayed on ecommerce
> 
>
> Key: OFBIZ-10741
> URL: https://issues.apache.org/jira/browse/OFBIZ-10741
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Priya Sharma
>Priority: Major
> Attachments: 1-Enchiladas.png, 2-BlankPage.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Under Feature Products section, click on product Enchiladas (Please refer 
> attachment: 1-Enchiladas)
> Or open URL: 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p]
> Actual: Blank page is displayed (Please refer attachment: 2-BlankPage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10741) Blank page is displayed on ecommerce

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728445#comment-16728445
 ] 

Jacques Le Roux commented on OFBIZ-10741:
-

We have this in log:

{code}
2018-12-24 16:13:39,935 |jsse-nio-8443-exec-9 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [2] 
milliseconds
2018-12-24 16:13:39,936 |jsse-nio-8443-exec-9 |ProductWorker 
|I| Returning false because there is insufficient inventory available in 
facility with id WebStoreWarehouse for product id DOUGH; desired quantity is 
1.000,
 available quantity is 0
Dec 24, 2018 4:13:39 PM org.apache.catalina.core.ApplicationDispatcher invoke
SEVERE: Servlet.service() for servlet [ControlServlet] threw exception
java.lang.StackOverflowError
at 
org.apache.ofbiz.product.config.ProductConfigWrapper.hashCode(ProductConfigWrapper.java:235)
at 
org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigOption.hashCode(ProductConfigWrapper.java:823)
at java.util.AbstractList.hashCode(AbstractList.java:541)
at java.util.Arrays.hashCode(Arrays.java:4146)
at java.util.Objects.hash(Objects.java:128)
{code}

Then you have a kind of loop

> Blank page is displayed on ecommerce
> 
>
> Key: OFBIZ-10741
> URL: https://issues.apache.org/jira/browse/OFBIZ-10741
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Priya Sharma
>Priority: Major
> Attachments: 1-Enchiladas.png, 2-BlankPage.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Under Feature Products section, click on product Enchiladas (Please refer 
> attachment: 1-Enchiladas)
> Or open URL: 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/enchiladas-ENCHILADAS-p]
> Actual: Blank page is displayed (Please refer attachment: 2-BlankPage)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728438#comment-16728438
 ] 

Jacques Le Roux edited comment on OFBIZ-7357 at 12/24/18 3:53 PM:
--

Hi Guys,

Could you please check if there are no side effects. For instance now in 
ecommerce I get this when I want to go to from ecommerce/main to eg enchiladas 
product or Gold-Pizza. It's reproductible on trunk demo and locally
{code}
2018-12-24 16:13:39,935 |jsse-nio-8443-exec-9 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [2] 
milliseconds
2018-12-24 16:13:39,936 |jsse-nio-8443-exec-9 |ProductWorker 
|I| Returning false because there is insufficient inventory available in 
facility with id WebStoreWarehouse for product id DOUGH; desired quantity is 
1.000,
 available quantity is 0
Dec 24, 2018 4:13:39 PM org.apache.catalina.core.ApplicationDispatcher invoke
SEVERE: Servlet.service() for servlet [ControlServlet] threw exception
java.lang.StackOverflowError
at 
org.apache.ofbiz.product.config.ProductConfigWrapper.hashCode(ProductConfigWrapper.java:235)
at 
org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigOption.hashCode(ProductConfigWrapper.java:823)
at java.util.AbstractList.hashCode(AbstractList.java:541)
at java.util.Arrays.hashCode(Arrays.java:4146)
at java.util.Objects.hash(Objects.java:128)
{code}

Then you have a kind of loop


was (Author: jacques.le.roux):
Hi Guys,

Could you please check if there are no side effects. For instance now in 
ecommerce I get this when I want to go to from ecommerce/main to eg enchiladas 
product or Gold-Pizza. It's reproductible on trunk demo and locally

2018-12-24 16:13:39,935 |jsse-nio-8443-exec-9 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [2] 
milliseconds
2018-12-24 16:13:39,936 |jsse-nio-8443-exec-9 |ProductWorker 
|I| Returning false because there is insufficient inventory available in 
facility with id WebStoreWarehouse for product id DOUGH; desired quantity is 
1.000,
 available quantity is 0
Dec 24, 2018 4:13:39 PM org.apache.catalina.core.ApplicationDispatcher invoke
SEVERE: Servlet.service() for servlet [ControlServlet] threw exception
java.lang.StackOverflowError
at 
org.apache.ofbiz.product.config.ProductConfigWrapper.hashCode(ProductConfigWrapper.java:235)
at 
org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigOption.hashCode(ProductConfigWrapper.java:823)
at java.util.AbstractList.hashCode(AbstractList.java:541)
at java.util.Arrays.hashCode(Arrays.java:4146)
at java.util.Objects.hash(Objects.java:128)

Then you have a kind of loop

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7357.patch, OFBIZ-7357.patch, OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728438#comment-16728438
 ] 

Jacques Le Roux commented on OFBIZ-7357:


Hi Guys,

Could you please check if there are no side effects. For instance now in 
ecommerce I get this when I want to go to from ecommerce/main to eg enchiladas 
product or Gold-Pizza. It's reproductible on trunk demo and locally

2018-12-24 16:13:39,935 |jsse-nio-8443-exec-9 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [2] 
milliseconds
2018-12-24 16:13:39,936 |jsse-nio-8443-exec-9 |ProductWorker 
|I| Returning false because there is insufficient inventory available in 
facility with id WebStoreWarehouse for product id DOUGH; desired quantity is 
1.000,
 available quantity is 0
Dec 24, 2018 4:13:39 PM org.apache.catalina.core.ApplicationDispatcher invoke
SEVERE: Servlet.service() for servlet [ControlServlet] threw exception
java.lang.StackOverflowError
at 
org.apache.ofbiz.product.config.ProductConfigWrapper.hashCode(ProductConfigWrapper.java:235)
at 
org.apache.ofbiz.product.config.ProductConfigWrapper$ConfigOption.hashCode(ProductConfigWrapper.java:823)
at java.util.AbstractList.hashCode(AbstractList.java:541)
at java.util.Arrays.hashCode(Arrays.java:4146)
at java.util.Objects.hash(Objects.java:128)

Then you have a kind of loop

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7357.patch, OFBIZ-7357.patch, OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728437#comment-16728437
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Hi Priya,

Then I agree your patch is (maybe) a step in the right direction. I say maybe 
because I think we have a problem with OFBIZ-7357 and I can test all I'd like 
to.

But what I reported was something else. This is what I see after applying your 
patch (I use a dark theme)

!Image 002.png!

As you can see, once I have selected the 2 options, a "Select Unit of Measure" 
dropdown surges. Obviously this is not wanted, did you not notice it?

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9893) New methods for EntityQuery

2018-12-24 Thread Gareth Carter (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728435#comment-16728435
 ] 

Gareth Carter commented on OFBIZ-9893:
--

I will try to update the patch with comments in the new year

> New methods for EntityQuery
> ---
>
> Key: OFBIZ-9893
> URL: https://issues.apache.org/jira/browse/OFBIZ-9893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Gareth Carter
>Priority: Minor
> Attachments: EntityQuery.patch, ForUpdate.patch
>
>
> [See discussion on devml|http://markmail.org/message/zyzswygu6jqkg4nb]
> New methods:
> - getFieldMap
> - forEach
> - forUpdate - to be decided



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.

2018-12-24 Thread Gareth Carter (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728433#comment-16728433
 ] 

Gareth Carter commented on OFBIZ-5608:
--

Shall we close this issue down? There is no consensus for a fix or any updates 
since 2016!

> Dates Displaying Incorrectly With Negative Offest Timezones.
> 
>
> Key: OFBIZ-5608
> URL: https://issues.apache.org/jira/browse/OFBIZ-5608
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
>Reporter: Rupert Howell
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: DateField_1.jpg, DateField_2.jpg, French calendar 
> tootip.png, IgnoreTimeZone.patch, ObjectTypeTests.patch, dates.patch, 
> dates_1589040.patch, en-GB calendar tootip.png, sqldate_scenarios.png
>
>
> Dates are displaying incorrectly when negative offset (relative to UTC) are 
> applied by the users settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10536:

Attachment: Image 002.png

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9890) Having condition is ignored on queryList() and queryFirst() calls in EntityQuery

2018-12-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9890.
--
   Resolution: Fixed
Fix Version/s: 16.11.06
   17.12.01

Thanks Gareth,

The test passes with the patch. The patch makes sense to me (did not try)

Your patch is in
trunk r1849693  
R17 r1849694
R16 r1849695


> Having condition is ignored on queryList() and queryFirst() calls in 
> EntityQuery
> 
>
> Key: OFBIZ-9890
> URL: https://issues.apache.org/jira/browse/OFBIZ-9890
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.06
>
> Attachments: OFBIZ-9890.patch
>
>
> queryList() and queryFirst() both call internal private query() method. This 
> method calls delegator.findList if a normal Entity/ViewEntity is used (not a 
> DVE). This has no option to include a having condition and so must opt to use 
> queryIterator(). Even queryCount() can use a having condition



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10673) Unable to add additional product images from catalog

2018-12-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10673:
---

Assignee: Rohit Koushal  (was: Jacques Le Roux)

> Unable to add additional product images from catalog
> 
>
> Key: OFBIZ-10673
> URL: https://issues.apache.org/jira/browse/OFBIZ-10673
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> Server logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-10673) Unable to add additional product images from catalog

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728416#comment-16728416
 ] 

Jacques Le Roux commented on OFBIZ-10673:
-

Thanks for your feedback Rohit,

What a mess, it almost gives me headache when I try to follow the path.

So you say it was 1st broken by OFBIZ-4212 (r1081272), somehow fixed by 
r1081526, then broken again by OFBIZ-9776 (r1817623). 

I have double checked all that. Because r1081526 concern only 
*scaleImageInAllSize()*  and your patch concerns it also. But *filePathPrefix* 
is only changed by OFBIZ-9776 (r1817623) in *scaleImageManageInAllSize()*. So 
why do you speak about OFBIZ-9776 (r1817623) and *filePathPrefix*?

Also the fix done by OFBIZ-9776 (r1817623) seems good to me, why do you want to 
remove it? Maybe it fixes your issue (did nto try) but are you sure it does not 
put in regressions?

> Unable to add additional product images from catalog
> 
>
> Key: OFBIZ-10673
> URL: https://issues.apache.org/jira/browse/OFBIZ-10673
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> Server logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
> at 
> 

[jira] [Closed] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma closed OFBIZ-10745.
-

> Refactor boolean returns for ShoppingCart methods 
> --
>
> Key: OFBIZ-10745
> URL: https://issues.apache.org/jira/browse/OFBIZ-10745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10745.patch, OFBIZ-10745.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728398#comment-16728398
 ] 

Aditya Sharma commented on OFBIZ-10745:
---

Improves code in isPaymentMethodType() and isValidateGCFinAccount().

Done for trunk at r1849688

No more instances in ShoppingCart class. Hence, closing.

> Refactor boolean returns for ShoppingCart methods 
> --
>
> Key: OFBIZ-10745
> URL: https://issues.apache.org/jira/browse/OFBIZ-10745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10745.patch, OFBIZ-10745.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728363#comment-16728363
 ] 

Jacques Le Roux commented on OFBIZ-7257:


+1

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Devanshu Vyas
>Priority: Major
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10673) Unable to add additional product images from catalog

2018-12-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10673:
---

Assignee: Jacques Le Roux  (was: Rohit Koushal)

> Unable to add additional product images from catalog
> 
>
> Key: OFBIZ-10673
> URL: https://issues.apache.org/jira/browse/OFBIZ-10673
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> Server logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-9738) ShoppingCartItem equals method does not compare object references

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728365#comment-16728365
 ] 

Jacques Le Roux commented on OFBIZ-9738:


I agree with Gareth

> ShoppingCartItem equals method does not compare object references
> -
>
> Key: OFBIZ-9738
> URL: https://issues.apache.org/jira/browse/OFBIZ-9738
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Saurabh Dixit
>Priority: Minor
> Attachments: OFBIZ-9738.patch
>
>
> The default Object class equals method checks for reference equality however 
> ShoppingCartItem does not (I believe it should). When it filters down through 
> the other equals methods some properties have a default value which could be 
> different to the value stored in the object



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Priya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma updated OFBIZ-10536:
-
Attachment: Screenshot from 2018-12-24 17-37-07.png

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: OFBIZ-10536.patch, OFBIZ-10536_16-11.patch, Screenshot 
> from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2018-12-24 Thread Priya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728364#comment-16728364
 ] 

Priya Sharma commented on OFBIZ-10536:
--

Hi Jacques,

I am not aware of the utility of this drop down though, but the issue which I 
could see was, a broken screen on hitting the add to cart button.
Attaching the screenshot for the same. !Screenshot from 2018-12-24 17-37-07.png!

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: OFBIZ-10536.patch, OFBIZ-10536_16-11.patch, Screenshot 
> from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728325#comment-16728325
 ] 

Aditya Sharma commented on OFBIZ-10745:
---

Makes Sense [~jacques.le.roux]. Thanks for sharing :) 

> Refactor boolean returns for ShoppingCart methods 
> --
>
> Key: OFBIZ-10745
> URL: https://issues.apache.org/jira/browse/OFBIZ-10745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10745.patch, OFBIZ-10745.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728318#comment-16728318
 ] 

Aditya Sharma commented on OFBIZ-10726:
---

Added a patch that improves code in isJavaScriptEnabled().

In this patch, instead of using if-else block, a ternary operator is used for 
improving readability.

> Refactor boolean returns for UtilHttp methods 
> --
>
> Key: OFBIZ-10726
> URL: https://issues.apache.org/jira/browse/OFBIZ-10726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10726.patch, OFBIZ-10726.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10726:
--
Attachment: OFBIZ-10726.patch

> Refactor boolean returns for UtilHttp methods 
> --
>
> Key: OFBIZ-10726
> URL: https://issues.apache.org/jira/browse/OFBIZ-10726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10726.patch, OFBIZ-10726.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10716) Browser Unresponsive when Loading Entity with Large Results

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728317#comment-16728317
 ] 

Jacques Le Roux commented on OFBIZ-10716:
-

Hi Devanshu,

This should be parameterizable (eg a properties) because then you can't get to 
a certain page, except next, 1st and last) which can be useful sometimes when 
you look for something ordered. Not sure if it should be old way or new by 
defaut. Another question in the thread on dev ML should be asked. Also a link 
to this thread would fit here, thanks.

> Browser Unresponsive when Loading Entity with Large Results
> ---
>
> Key: OFBIZ-10716
> URL: https://issues.apache.org/jira/browse/OFBIZ-10716
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: OFBIZ-10716.patch, Screenshot from 2018-12-22 
> 11-03-16.png
>
>
> Recently, I came across a situation where an entity was taking too much of a 
> time(browser asked me to either wait or kill) while loading/searching results 
> in the Webtools application. The entity had close to 5M records, and I 
> checked the server responded timely but the rendering of the screen was 
> taking time.
> When I explored the issue I came across a macro which renders the pagination 
> on the screen, and it had a code block which was causing the screen rendering 
> delay.
> {code}
> <#assign x=(listSize/viewSize)?ceiling>
>   <#list 1..x as i>
> <#if i == (viewIndex+1)>${i-1}">${i}
>   
> {code}
> This code seems logical enough to me, and what I gather from this is that the 
> list will render a select box with 250,000 options. 
> I would like to propose a change in this UI/UX from select box to an input 
> text box so a user can navigate to any page, similar to a navigation input 
> box in a PDF document reader application.
> Please let me know your thoughts on this and share some more ideas to how we 
> can improve/resolve this issue. Looking forward to your replies!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728314#comment-16728314
 ] 

Jacques Le Roux commented on OFBIZ-10745:
-

Hi Aditya, 

I think you can commit directly for all these simple kind of changes. They are 
straightforward and we can always [commit then review 
(CTR)|https://www.apache.org/foundation/glossary.html#CommitThenReview] which 
is the way OFBiz works (see also start of 
https://www.apache.org/dev/new-committers-guide.html#guide-for-new-committers). 
Only for big changes we prefer to ask reviews before commit. The frontier is 
normaly esier to see: if it's a pain to review, or you have a doubt, then 
better ask others to do it before commit I'd say.

Thanks

> Refactor boolean returns for ShoppingCart methods 
> --
>
> Key: OFBIZ-10745
> URL: https://issues.apache.org/jira/browse/OFBIZ-10745
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10745.patch, OFBIZ-10745.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10726) Refactor boolean returns for UtilHttp methods

2018-12-24 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728269#comment-16728269
 ] 

Aditya Sharma commented on OFBIZ-10726:
---

Done for trunk at R1849675

> Refactor boolean returns for UtilHttp methods 
> --
>
> Key: OFBIZ-10726
> URL: https://issues.apache.org/jira/browse/OFBIZ-10726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10726.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10728) Refactor boolean returns for UtilValidate methods

2018-12-24 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728222#comment-16728222
 ] 

Aditya Sharma commented on OFBIZ-10728:
---

Added a patch that improves code in isTime().

> Refactor boolean returns for UtilValidate methods 
> --
>
> Key: OFBIZ-10728
> URL: https://issues.apache.org/jira/browse/OFBIZ-10728
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10728.patch, OFBIZ-10728.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)