[jira] [Commented] (OFBIZ-5522) Introduce websocket usage
[ https://issues.apache.org/jira/browse/OFBIZ-5522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006615#comment-17006615 ] Raj Verma commented on OFBIZ-5522: -- Good happy to see this here and very thankful to you https://dpviral.blogspot.com/ https://www.viraldpstatus.com/ https://www.viraldpstatus.com/2019/10/hindi-good-morning-thoughts-hd-images.html https://dpviral.blogspot.com/2019/11/hindi-shayari-gf.html > Introduce websocket usage > - > > Key: OFBIZ-5522 > URL: https://issues.apache.org/jira/browse/OFBIZ-5522 > Project: OFBiz > Issue Type: Task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > After a discussion with Ean, was suggested (draft here): > You need a service that lets you "subscribe" a widget to an entity and > then propagate change events to the widget as the entity is modified. > A generic mechanism like that could eventually expand to be a general > purpose "data bound widgets" system that mostly looks like the existing > system but magically reflects updates. > Could be used with/for > * The entity cache and webforms to automatically update views when data > changes. > * Replaces the current system notes > * Create a dashboard type pages (to be discussed futher) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion
Mathieu Lirzin created OFBIZ-11314: -- Summary: Avoid stack overflow in the presence of cycles in controller inclusion Key: OFBIZ-11314 URL: https://issues.apache.org/jira/browse/OFBIZ-11314 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Mathieu Lirzin Assignee: Mathieu Lirzin The inclusion of controller configuration files can lead to inclusion cycles which are not safely handled, because they can lead to infinite recursion that end up in stack overflow exception. A very basic form of cycle is controllers A and B which includes each other. I would be better to checket the inclusion cycles and report an appropriate error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11313) Parsing included controller files eagerly
[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin closed OFBIZ-11313.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~jamesyong] for the review.
> Parsing included controller files eagerly
> -
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11313) Parsing included controller files eagerly
[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006407#comment-17006407
]
ASF subversion and git services commented on OFBIZ-11313:
-
Commit 7508917a0af0311694c37cf1ddd4231a0c8b3529 in ofbiz-framework's branch
refs/heads/trunk from Mathieu Lirzin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7508917 ]
Improved: Remove ‘RequestHandler#ControllerConfig’ wrapper
(OFBIZ-11313)
‘RequestHandler#ControllerConfig’ was a wrapper around
‘ConfigXMLReader#ControllerConfig’ used as a convenience to gather
error handling when accessing configuration properties. Since the
later is now only throwing exceptions when instantiating the object,
‘RequestHandler#ControllerConfig’ is not useful anymore.
> Parsing included controller files eagerly
> -
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11313) Parsing included controller files eagerly
[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006406#comment-17006406
]
ASF subversion and git services commented on OFBIZ-11313:
-
Commit 6c745f6ea56db746e3a2d3c96c9c6b2cca1496bf in ofbiz-framework's branch
refs/heads/trunk from Mathieu Lirzin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6c745f6 ]
Improved: Retrieve the included controller files eagerly
(OFBIZ-11313)
The included controller files resolution was previously delayed when
accessing the configuration properties. The issue is that it imposes
callers to handle exceptions when accessing those
properties. Additionally this has the drawback of detecting inclusion
issues late.
We are now retrieving the included files when instantiating the
controller configuration object. This provides more guarantee on the
integrity of instantiated controllers and relax the error handling
requirements on configuration properties callers.
> Parsing included controller files eagerly
> -
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11313) Parsing included controller files eagerly
[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11313:
---
Issue Type: Improvement (was: Bug)
> Parsing included controller files eagerly
> -
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11313) Parsing included controller files eagerly
[
https://issues.apache.org/jira/browse/OFBIZ-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006344#comment-17006344
]
James Yong commented on OFBIZ-11313:
Tested the patches. No functional change here.
I am ok with error handling being closer to the source, to simplify the code.
Also fine with the removal of MultivaluedMapContext.
> Parsing included controller files eagerly
> -
>
> Key: OFBIZ-11313
> URL: https://issues.apache.org/jira/browse/OFBIZ-11313
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> 0001-Improved-Retrieve-the-included-controller-files-eage.patch,
> 0002-Improved-Remove-RequestHandler-ControllerConfig-wrap.patch
>
>
> Controller configuration files have the ability to include other controllers
> which can be useful to make the controller more modular and potentially
> reusable.
> Currently included controller files are retrieved lazily when reading the
> properties from a controller configuration. This technique avoids unnecessary
> work at startup but in this concrete case the gain in negligeable and has the
> drawback of requiring error handling everytime a property is read which is
> cumbersome.
> As a consequence it would be better to parse included files eagerly at
> startup time to be able to detect inclusion errors early and relaxing the
> error handling when reading properties since all the sensible work will be
> done when instantiating the {{ControllerConfig}} object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
