[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165160#comment-17165160 ] Aditya Sharma commented on OFBIZ-9901: -- Thanks Jacques for taking care of it :) I will try to ensure that further > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11900) Extract FTL macro call generation from MacroFormRenderer
[ https://issues.apache.org/jira/browse/OFBIZ-11900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-11900: -- Assignee: Daniel Watford > Extract FTL macro call generation from MacroFormRenderer > > > Key: OFBIZ-11900 > URL: https://issues.apache.org/jira/browse/OFBIZ-11900 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > As part of refactoring MacroFormRenderer (OFBIZ-11456), extract code > responsible for building the FTL macro calls for form elements into a > supporting class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11553: -- Attachment: OFBIZ-11553-test.patch > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165082#comment-17165082 ] Suraj Khurana commented on OFBIZ-11553: --- I guess due to some other test, shopping cart has multiple payment methods, and as cart has multiple payment methods, order is not approved (org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java:1166) One quick solution patch has been attached, ensuring single paymentMethod, please check if it looks good to everyone. HTH. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10313) Capture Transactions are still displayed as Authorize
[ https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165080#comment-17165080 ] Jacques Le Roux commented on OFBIZ-10313: - Hi [~deepa.barfa] do you intend to close this ticket? > Capture Transactions are still displayed as Authorize > - > > Key: OFBIZ-10313 > URL: https://issues.apache.org/jira/browse/OFBIZ-10313 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Deepa Barfa >Priority: Major > > Steps: > 1. Open URL > https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses > 2. Navigate to Transactions with Authorize > 3. Try to Capture payment > 4. Again navigate to FindGatewayResponses and check for transaction > Actual Result: > The transaction still displayed with Authorize status and no update on > payment capture > Expected Result: > Correct status of transaction should be displayed (Capture/Authorize) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9901. -- Resolution: Fixed > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-2562) On changing the order status from order view page, the changeOrderStatus request throws twice and gives error on consol.
[
https://issues.apache.org/jira/browse/OFBIZ-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165068#comment-17165068
]
ASF subversion and git services commented on OFBIZ-2562:
Commit 1662e5b42ef5ee36dc2aa68544615340056b68de in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1662e5b ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> On changing the order status from order view page, the changeOrderStatus
> request throws twice and gives error on consol.
>
>
> Key: OFBIZ-2562
> URL: https://issues.apache.org/jira/browse/OFBIZ-2562
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 4.0, Trunk
>Reporter: Rishi Solanki
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Fixes.patch.tar.gz
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-2562) On changing the order status from order view page, the changeOrderStatus request throws twice and gives error on consol.
[
https://issues.apache.org/jira/browse/OFBIZ-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165072#comment-17165072
]
ASF subversion and git services commented on OFBIZ-2562:
Commit 30c0d6d7af060e33e7c5c8d1214310968be137c7 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=30c0d6d ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> On changing the order status from order view page, the changeOrderStatus
> request throws twice and gives error on consol.
>
>
> Key: OFBIZ-2562
> URL: https://issues.apache.org/jira/browse/OFBIZ-2562
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 4.0, Trunk
>Reporter: Rishi Solanki
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Fixes.patch.tar.gz
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165074#comment-17165074 ] ASF subversion and git services commented on OFBIZ-9901: Commit e5860cc11b8925dcbddbd2afd3b4b2825bd61760 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e5860cc ] Fixed: Unable to create event in SFA component (OFBIZ-9901) The tests failed because CAL_OWNER instead of CONTACT was necessary Conflicts handled by hand in WorkEffortTests.xml > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165073#comment-17165073
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit 30c0d6d7af060e33e7c5c8d1214310968be137c7 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=30c0d6d ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pritam Kute
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165069#comment-17165069
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit 1662e5b42ef5ee36dc2aa68544615340056b68de in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1662e5b ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pritam Kute
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165067#comment-17165067
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit 1662e5b42ef5ee36dc2aa68544615340056b68de in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1662e5b ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pritam Kute
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165075#comment-17165075 ] ASF subversion and git services commented on OFBIZ-9901: Commit 077625c5a6e86e38152bd3021b144cef510e25dd in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=077625c ] Fixed: Unable to create event in SFA component (OFBIZ-9901) The tests failed because CAL_OWNER instead of CONTACT was necessary > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165070#comment-17165070 ] ASF subversion and git services commented on OFBIZ-9901: Commit 8dc864ff71edebc66ed4af5adb77765369bf7133 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8dc864f ] Fixed: Unable to create event in SFA component (OFBIZ-9901) The tests failed because CAL_OWNER instead of CONTACT was necessary Handled by hand, cherry-pick was impossible > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165071#comment-17165071
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit 30c0d6d7af060e33e7c5c8d1214310968be137c7 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=30c0d6d ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pritam Kute
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9901: > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165041#comment-17165041 ] Jacques Le Roux commented on OFBIZ-9901: Hi Aditya, It seems this introduced 2 test failures: https://ci.apache.org/projects/ofbiz/logs/17.12/framework/html/ https://ci.apache.org/projects/ofbiz/logs/18.12/framework/html/ > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164965#comment-17164965 ] ASF subversion and git services commented on OFBIZ-11487: - Commit 1542844add7c5ac179c064b7c86627c7bc0c8bb5 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1542844 ] In previous commit 2b041186909982f37b6a32688fe910d65b6d0fad for Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)" This reverts commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478. I wrongly put back 2 files not part of faa59b325 commit CostTests.xml ProductPriceTests.xml This removes them > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164947#comment-17164947 ] ASF subversion and git services commented on OFBIZ-11487: - Commit 2b041186909982f37b6a32688fe910d65b6d0fad in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2b04118 ] Revert "Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487)" This reverts commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478. It introduced 3 errors in testIntegration, in: testGlPostingOnCancelCheckRun testGlPostingsOnVoidPayment testVoidPayment > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164942#comment-17164942 ] Suraj Khurana commented on OFBIZ-11922: --- Attached patch for indentation correction in java files, this fixed around *3000+* checkstyle issues. These were all the bulk group changes, apart from these around 400 more are pending of this kind. > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11922: -- Attachment: OFBIZ-11904.patch OFBIZ-11904-plugins.patch > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption
[ https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Choudhary updated OFBIZ-11917: -- Description: *Step to reproduce* 1. Login with a valid username and password. 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main|https://demo-trunk.ofbiz.apache.org/ecommerce/control]; 3. Create an order with Tax Identification and Exemption *Actual Result:* The error message is displayed. *Screenprint attached* was: *Step to reproduce* 1. Login with a valid username and password. 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; 3. Create an order with Tax Identification and Exemption *Actual Result:* The error message is displayed. *Screenprint attached* > Error message is displayed while creating order with Tax Identification and > Exemption > - > > Key: OFBIZ-11917 > URL: https://issues.apache.org/jira/browse/OFBIZ-11917 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Shubham Choudhary >Priority: Minor > Attachments: OFBIZ-11917.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to > "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main|https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Create an order with Tax Identification and Exemption > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9901. Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164933#comment-17164933 ] Aditya Sharma commented on OFBIZ-9901: -- This has been fixed. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11727) Warning message should be shown when added back date with card details
[ https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164931#comment-17164931 ] Pritam Kute commented on OFBIZ-11727: - Hello [~Dikpal.Kanungo] Can you please check this once again? Looks like it is working fine now. We have fixed the related ticket. If it's working as expected, feel free to close the ticket. > Warning message should be shown when added back date with card details > -- > > Key: OFBIZ-11727 > URL: https://issues.apache.org/jira/browse/OFBIZ-11727 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Pritam Kute >Priority: Minor > Attachments: Back date should not be selected.png > > > > Steps to regenerate: > 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > 2. Add products to cart and proceed with 'Single page checkout' > 3. In step 4 for the checkout process at Billing and shipping form, try > adding a back date for the in reference to card details > 4. It will not prompt the user for adding an expiry date, and the page will > just refresh again and again > > Expected: User should be notified of adding an expired date. > > Reference: > !Back date should not be selected.png! > > Let me know if you need any further help with the same. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164930#comment-17164930 ] ASF subversion and git services commented on OFBIZ-9901: Commit ca62bd6cef357d33f6770fd7e693e3dd97630525 in ofbiz-framework's branch refs/heads/release17.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ca62bd6 ] Fixed: Unable to create event in SFA component (OFBIZ-9901) When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164927#comment-17164927 ] ASF subversion and git services commented on OFBIZ-9901: Commit b5ae3a5b710ed225bbbeccc9a641e4469c9fa9de in ofbiz-framework's branch refs/heads/release18.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b5ae3a5 ] Fixed: Unable to create event in SFA component (OFBIZ-9901) When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164916#comment-17164916 ] Jacques Le Roux commented on OFBIZ-11921: - So it will be a big manual process (ouch! 1215 Java files). That's fine with me, I see no other ways. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164915#comment-17164915 ] Jacques Le Roux commented on OFBIZ-7529: Hi Mridul, I think we can let it like that. It should have been one of the R16 releases, but that's no longer available, not a big deal. > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > Fix For: 17.12.03 > > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164914#comment-17164914 ] ASF subversion and git services commented on OFBIZ-9901: Commit 6804a9dac3a9c8e9c0c4678661e7918dc50cf6eb in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6804a9d ] Fixed: Unable to create event in SFA component (OFBIZ-9901) When creating event for the party other than the loggedin user, the party should be in CAL_OWNER role to be added to event. Added appropriate check in service along with the error message. Thanks Rubia Elza Joshep for reporting the issue and Aditi Patidar for providing the patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9901: Assignee: Aditya Sharma (was: Aditi Patidar) > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7529) Delete stale java files from applications and framework
[ https://issues.apache.org/jira/browse/OFBIZ-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak closed OFBIZ-7529. Fix Version/s: 17.12.03 Resolution: Fixed Added to the attic so closing now. [~jleroux] Could you please check the fix version, I wasn't sure what to put? > Delete stale java files from applications and framework > --- > > Key: OFBIZ-7529 > URL: https://issues.apache.org/jira/browse/OFBIZ-7529 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > Fix For: 17.12.03 > > > As per the discussions on the thread - > http://ofbiz.135035.n4.nabble.com/Proposal-to-delete-stale-java-files-tt4683855.html, > following files and their references needs to be deleted from applications > and framework, > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java > applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java > applications/content/src/org/ofbiz/content/report > applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java > applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java > applications/product/src/ShipmentScaleApplet.java > applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java > framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164904#comment-17164904 ] Suraj Khurana commented on OFBIZ-11921: --- Yes, you are right Jacques. We have wrapping and braces setting in IntelliJ IDE ([https://www.jetbrains.com/help/phpstorm/settings-code-style-wrapping-and-braces-common.html]) and after proper settings when I re-format the source-code ([https://www.jetbrains.com/help/phpstorm/reformat-and-rearrange-code.html]), it works fine. Till now, I have applied this changes in some selected code and observed it works well, except some manual changes, like sometimes if leaves white space in the end which needs to be re-checked and removed with replace all option. Other than this, it works pretty well. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164903#comment-17164903 ] Aditya Sharma commented on OFBIZ-10740: --- Hi [~Dikpal.Kanungo] , [~sourabh.punyani] , It seems the changes applied are reflecting on category page too. [https://localhost:8443/ecommerce/best-sell-2-BEST-SELL-2-c] Please verify once if these changes are applied on other pages too. Apart from that, in ShowBestsellingCategories we are listing child categories and not the products, I think we can skip making a change to it > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11924) Issues with additional image on ecommerce
Arpit Mor created OFBIZ-11924: - Summary: Issues with additional image on ecommerce Key: OFBIZ-11924 URL: https://issues.apache.org/jira/browse/OFBIZ-11924 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Arpit Mor Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png Following issues were found: #1) Additional image uploaded for product is not displayed (if product already has additional image) Steps to regenerate: * Download additional images attached in the ticket * Navigate to URL: [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569] * Browse additional images that are downloaded in the earlier step * Click on upload button * Navigate to URL: [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html] Actual: Uploaded additional images are not displayed Expected: Uploaded additional image should be displayed on ecommerce Note: This issue is product specific, for product: Tiny Chrome Widget (Id: WG-5569), uploaded additional images are not displayed. But for product: Nan Gizmo (Id: GZ-1001), uploaded additional images are displayed #2) UI issue on ecommerce when additional images are uploaded for product Steps to regenerate: * Download additional images attached in the ticket * Navigate to URL: [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001] * Browse additional images that are downloaded in the earlier step * Click on upload button * Navigate to URL: [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html] Actual: Please refer attachment: Image2.1 Expected: Please refer attachment: Image 2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11923) Convert SetupEvents.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11923: - Assignee: Rohit Koushal > Convert SetupEvents.xml mini lang to groovy > --- > > Key: OFBIZ-11923 > URL: https://issues.apache.org/jira/browse/OFBIZ-11923 > Project: OFBiz > Issue Type: Sub-task >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10740: -- Description: We can apply ellipsis to various places at home page like on name and description of the product to keep the symmetry of the page aligned and to attain consistency. Please have a look at the attached screenshot was: We can apply ellipsis to various places at home page like on name and description of the product to keep the symmetry of the page aligned and to attain consistency. Please have a look at the attached screenshot !ellipsis for consistency.png! > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11923) Convert SetupEvents.xml mini lang to groovy
Rohit Koushal created OFBIZ-11923: - Summary: Convert SetupEvents.xml mini lang to groovy Key: OFBIZ-11923 URL: https://issues.apache.org/jira/browse/OFBIZ-11923 Project: OFBiz Issue Type: Sub-task Reporter: Rohit Koushal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164898#comment-17164898 ] Jacques Le Roux commented on OFBIZ-11921: - Hi Suraj, I guess this is a big one. How do yo intend to fix it? > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
Suraj Khurana created OFBIZ-11921: - Summary: Checkstyle: Line is longer than 150 characters Key: OFBIZ-11921 URL: https://issues.apache.org/jira/browse/OFBIZ-11921 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11922) Checkstyle: has incorrect indentation level
Suraj Khurana created OFBIZ-11922: - Summary: Checkstyle: has incorrect indentation level Key: OFBIZ-11922 URL: https://issues.apache.org/jira/browse/OFBIZ-11922 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[ https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11838. --- Fix Version/s: 17.12.05 18.12.01 Assignee: Pritam Kute (was: Jacques Le Roux) Resolution: Fixed Thanks Pritam, good catch! > One page checkout is broken because of ordermgr::getAssociatedStateList > --- > > Key: OFBIZ-11838 > URL: https://issues.apache.org/jira/browse/OFBIZ-11838 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pritam Kute >Priority: Major > Fix For: 18.12.01, 17.12.05 > > > It works in example/control/FormWidgetExamples so it's an ecommerce issue. It > also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so > it's something "recent" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-2562) On changing the order status from order view page, the changeOrderStatus request throws twice and gives error on consol.
[
https://issues.apache.org/jira/browse/OFBIZ-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164891#comment-17164891
]
ASF subversion and git services commented on OFBIZ-2562:
Commit fc865c458a16a681183c25297d0f395027a36625 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fc865c4 ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> On changing the order status from order view page, the changeOrderStatus
> request throws twice and gives error on consol.
>
>
> Key: OFBIZ-2562
> URL: https://issues.apache.org/jira/browse/OFBIZ-2562
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 4.0, Trunk
>Reporter: Rishi Solanki
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Fixes.patch.tar.gz
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164890#comment-17164890
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit fc865c458a16a681183c25297d0f395027a36625 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fc865c4 ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164892#comment-17164892
]
ASF subversion and git services commented on OFBIZ-11838:
-
Commit fc865c458a16a681183c25297d0f395027a36625 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fc865c4 ]
Fixed: One page checkout is broken because of ordermgr::getAssociatedStateList
(OFBIZ-11838)
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
<@ofbizUrl>changeOrderStatus/orderview
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview.
When js functions running in the backend like "getAssociatedStateList" are
called, they are getting the wrong URL to send a request to. This was causing
the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in OFBIZ-2562 and OFBIZ-11838.
1.
To change the request mapping for "changeOrderStatus" and add request-redirect
to "orderview" screen. Change the actions in the forms in OrderInfo.ftl to
call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
2.
To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
Thanks: Pritam Kute!
I picked the 2nd solution
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11920) Distorted Final Checkout Review page when Credit card is selected as Payment option
Rashi Dhagat created OFBIZ-11920: Summary: Distorted Final Checkout Review page when Credit card is selected as Payment option Key: OFBIZ-11920 URL: https://issues.apache.org/jira/browse/OFBIZ-11920 Project: OFBiz Issue Type: Bug Affects Versions: Release Branch 17.12 Reporter: Rashi Dhagat Attachments: DistortedUI.png Steps to regenerate: 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ |https://demo-trunk.ofbiz.apache.org/ecomseo/] 2. Add item in the cart 3. Click on Quick Checkout 4. Click on checkout under Checkout Without Login section 5. Enter details 6. Select Payment Option as Credit Card Actual: Final Checkout Review page Is distorted Please refer to the attachment. !DistortedUI.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing
[ https://issues.apache.org/jira/browse/OFBIZ-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11918: Assignee: Anushi Gupta > Incorrect error message in the checkout page if last name is missing > > > Key: OFBIZ-11918 > URL: https://issues.apache.org/jira/browse/OFBIZ-11918 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 17.12 >Reporter: Rashi Dhagat >Assignee: Anushi Gupta >Priority: Critical > Attachments: LastNameMissing.webm > > > Steps to regenerate: > 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ > |https://demo-trunk.ofbiz.apache.org/ecomseo/] > 2. Add item in the cart > 3. Click on Quick Checkout > 4. Click on checkout under Checkout Without Login section > 5. Enter details > 6. Select Payment Option as Credit Card > 7. Enter Details without last name > 8. Select the shipping method > 9. Click on Submit Order > Actual: No message for the last name missing instead "No payment Method Type > selected " message displays. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy
Rohit Koushal created OFBIZ-11919: - Summary: Convert SystemInfoServices.xml mini lang to groovy Key: OFBIZ-11919 URL: https://issues.apache.org/jira/browse/OFBIZ-11919 Project: OFBiz Issue Type: Sub-task Components: commonext Reporter: Rohit Koushal Assignee: Rohit Koushal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing
[ https://issues.apache.org/jira/browse/OFBIZ-11918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rashi Dhagat updated OFBIZ-11918: - Affects Version/s: (was: 17.12.04) Release Branch 17.12 > Incorrect error message in the checkout page if last name is missing > > > Key: OFBIZ-11918 > URL: https://issues.apache.org/jira/browse/OFBIZ-11918 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 17.12 >Reporter: Rashi Dhagat >Priority: Critical > Attachments: LastNameMissing.webm > > > Steps to regenerate: > 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ > |https://demo-trunk.ofbiz.apache.org/ecomseo/] > 2. Add item in the cart > 3. Click on Quick Checkout > 4. Click on checkout under Checkout Without Login section > 5. Enter details > 6. Select Payment Option as Credit Card > 7. Enter Details without last name > 8. Select the shipping method > 9. Click on Submit Order > Actual: No message for the last name missing instead "No payment Method Type > selected " message displays. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11859) Convert CostTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11859. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma (was: Anushi Gupta) Resolution: Implemented Thanks, Akash and Anushi! > Convert CostTests.xml to Groovy > --- > > Key: OFBIZ-11859 > URL: https://issues.apache.org/jira/browse/OFBIZ-11859 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11859.patch > > > Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11859) Convert CostTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164888#comment-17164888 ] ASF subversion and git services commented on OFBIZ-11859: - Commit 5799c7e5e46f9915fcb0a8160b8f5e3f9644603f in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5799c7e ] Improved: Convert CostTests.xml to Groovy(OFBIZ-11859) Thanks, Akash for report and Anushi for the Patch. > Convert CostTests.xml to Groovy > --- > > Key: OFBIZ-11859 > URL: https://issues.apache.org/jira/browse/OFBIZ-11859 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Anushi Gupta >Priority: Minor > Attachments: OFBIZ-11859.patch > > > Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11217) Unable to proceed after payment information when Checkout Without Login
[ https://issues.apache.org/jira/browse/OFBIZ-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164887#comment-17164887 ] Jacques Le Roux commented on OFBIZ-11217: - Great, thanks Rashi! > Unable to proceed after payment information when Checkout Without Login > --- > > Key: OFBIZ-11217 > URL: https://issues.apache.org/jira/browse/OFBIZ-11217 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Major > Attachments: CheckoutWithoutLoginPaymentopt.webm, > V-CheckoutwithoutLogin.webm, > screencast-nimbus-capture-2020.07.25-11_34_27.webm, trunkChanges.webm > > > Following issues found: > # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > # Add item to cart > # Click on Quick Checkout > # Click on checkout under Checkout Without Login section > # Enter Personal Info and continue > # Enter the address and continue > # Select shipping option and continue > # Select Payment Option and continue > Actual: > # If Payment Option id PayPal/offline, Billing Address section is not > visible and unable to proceed after a click on continue on the Payment > Information page and groovy error occurred. > # If Payment Option id Credit card, Check the "Billing address is the same > as the shipping address". Page get refreshed and checked box is unchecked. > Please refer attachment for same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164884#comment-17164884 ] Rohit Koushal commented on OFBIZ-11500: --- Here is the patch in which createMatchingPaymentApplication minilang service is converted into its respective groovy logic. [^OFBIZ-11500.patch] > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11500.patch > > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11857) Convert ProductTagTest.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11857: Assignee: Anushi Gupta (was: Akash Jain) > Convert ProductTagTest.xml to Groovy > > > Key: OFBIZ-11857 > URL: https://issues.apache.org/jira/browse/OFBIZ-11857 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Anushi Gupta >Priority: Minor > > Convert ProductTagTest XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11918) Incorrect error message in the checkout page if last name is missing
Rashi Dhagat created OFBIZ-11918: Summary: Incorrect error message in the checkout page if last name is missing Key: OFBIZ-11918 URL: https://issues.apache.org/jira/browse/OFBIZ-11918 Project: OFBiz Issue Type: Bug Affects Versions: 17.12.04 Reporter: Rashi Dhagat Attachments: LastNameMissing.webm Steps to regenerate: 1. Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/ |https://demo-trunk.ofbiz.apache.org/ecomseo/] 2. Add item in the cart 3. Click on Quick Checkout 4. Click on checkout under Checkout Without Login section 5. Enter details 6. Select Payment Option as Credit Card 7. Enter Details without last name 8. Select the shipping method 9. Click on Submit Order Actual: No message for the last name missing instead "No payment Method Type selected " message displays. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11500: -- Attachment: OFBIZ-11500.patch > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11500.patch > > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11494) Convert cancelCheckRunPayments service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-11494: Attachment: OFBIZ-11494.patch > Convert cancelCheckRunPayments service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11494 > URL: https://issues.apache.org/jira/browse/OFBIZ-11494 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-11494.patch > > > Convert the cancelCheckRunPayments service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11494) Convert cancelCheckRunPayments service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164883#comment-17164883 ] Yogesh Naroliya commented on OFBIZ-11494: - Hello team, I have added patch for the conversion of *cancelCheckRunPayments* service from mini-lang to groovy DSL. Also verified the patch. Please have a look and let me know in case of any concerns. Thanks in advance !! > Convert cancelCheckRunPayments service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11494 > URL: https://issues.apache.org/jira/browse/OFBIZ-11494 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-11494.patch > > > Convert the cancelCheckRunPayments service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption
[ https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Choudhary reassigned OFBIZ-11917: - Assignee: Shubham Choudhary > Error message is displayed while creating order with Tax Identification and > Exemption > - > > Key: OFBIZ-11917 > URL: https://issues.apache.org/jira/browse/OFBIZ-11917 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Shubham Choudhary >Priority: Minor > Attachments: OFBIZ-11917.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Create an order with Tax Identification and Exemption > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption
[ https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-11917: -- Priority: Minor (was: Major) > Error message is displayed while creating order with Tax Identification and > Exemption > - > > Key: OFBIZ-11917 > URL: https://issues.apache.org/jira/browse/OFBIZ-11917 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Priority: Minor > Attachments: OFBIZ-11917.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Create an order with Tax Identification and Exemption > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption
[ https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-11917: -- Attachment: OFBIZ-11917.png > Error message is displayed while creating order with Tax Identification and > Exemption > - > > Key: OFBIZ-11917 > URL: https://issues.apache.org/jira/browse/OFBIZ-11917 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Priority: Major > Attachments: OFBIZ-11917.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Create an order with Tax Identification and Exemption > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption
Ashish Sharma created OFBIZ-11917: - Summary: Error message is displayed while creating order with Tax Identification and Exemption Key: OFBIZ-11917 URL: https://issues.apache.org/jira/browse/OFBIZ-11917 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Ashish Sharma *Step to reproduce* 1. Login with a valid username and password. 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; 3. Create an order with Tax Identification and Exemption *Actual Result:* The error message is displayed. *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11217) Unable to proceed after payment information when Checkout Without Login
[ https://issues.apache.org/jira/browse/OFBIZ-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164875#comment-17164875 ] Rashi Dhagat commented on OFBIZ-11217: -- Hi [~jleroux], Verified the changes for trunk - offline option. Working as expected. [^trunkChanges.webm] > Unable to proceed after payment information when Checkout Without Login > --- > > Key: OFBIZ-11217 > URL: https://issues.apache.org/jira/browse/OFBIZ-11217 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Major > Attachments: CheckoutWithoutLoginPaymentopt.webm, > V-CheckoutwithoutLogin.webm, > screencast-nimbus-capture-2020.07.25-11_34_27.webm > > > Following issues found: > # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > # Add item to cart > # Click on Quick Checkout > # Click on checkout under Checkout Without Login section > # Enter Personal Info and continue > # Enter the address and continue > # Select shipping option and continue > # Select Payment Option and continue > Actual: > # If Payment Option id PayPal/offline, Billing Address section is not > visible and unable to proceed after a click on continue on the Payment > Information page and groovy error occurred. > # If Payment Option id Credit card, Check the "Billing address is the same > as the shipping address". Page get refreshed and checked box is unchecked. > Please refer attachment for same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11217) Unable to proceed after payment information when Checkout Without Login
[ https://issues.apache.org/jira/browse/OFBIZ-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rashi Dhagat updated OFBIZ-11217: - Attachment: trunkChanges.webm > Unable to proceed after payment information when Checkout Without Login > --- > > Key: OFBIZ-11217 > URL: https://issues.apache.org/jira/browse/OFBIZ-11217 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Major > Attachments: CheckoutWithoutLoginPaymentopt.webm, > V-CheckoutwithoutLogin.webm, > screencast-nimbus-capture-2020.07.25-11_34_27.webm, trunkChanges.webm > > > Following issues found: > # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > # Add item to cart > # Click on Quick Checkout > # Click on checkout under Checkout Without Login section > # Enter Personal Info and continue > # Enter the address and continue > # Select shipping option and continue > # Select Payment Option and continue > Actual: > # If Payment Option id PayPal/offline, Billing Address section is not > visible and unable to proceed after a click on continue on the Payment > Information page and groovy error occurred. > # If Payment Option id Credit card, Check the "Billing address is the same > as the shipping address". Page get refreshed and checked box is unchecked. > Please refer attachment for same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11913) Error message is displayed when print order invoice PDF
[ https://issues.apache.org/jira/browse/OFBIZ-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirti Arora reassigned OFBIZ-11913: --- Assignee: Kirti Arora > Error message is displayed when print order invoice PDF > --- > > Key: OFBIZ-11913 > URL: https://issues.apache.org/jira/browse/OFBIZ-11913 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Kirti Arora >Priority: Minor > Attachments: OFBIZ-11913.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Place an order. > 4. Navigate to order history and click on the view link. > 5. Click on PDF > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10740: -- Issue Type: Improvement (was: Bug) > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > !ellipsis for consistency.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10313) Capture Transactions are still displayed as Authorize
[ https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepa Barfa reassigned OFBIZ-10313: --- Assignee: Deepa Barfa > Capture Transactions are still displayed as Authorize > - > > Key: OFBIZ-10313 > URL: https://issues.apache.org/jira/browse/OFBIZ-10313 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Deepa Barfa >Priority: Major > > Steps: > 1. Open URL > https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses > 2. Navigate to Transactions with Authorize > 3. Try to Capture payment > 4. Again navigate to FindGatewayResponses and check for transaction > Actual Result: > The transaction still displayed with Authorize status and no update on > payment capture > Expected Result: > Correct status of transaction should be displayed (Capture/Authorize) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList
[
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164871#comment-17164871
]
Pritam Kute commented on OFBIZ-11838:
-
Hello [~jleroux],
I have investigated more on
[OFBIZ-2562|https://issues.apache.org/jira/browse/OFBIZ-2562] and made the
following observations.
On orderview screen at the ordermgr, when a user tries to change the status of
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as
{code:java}
<@ofbizUrl>changeOrderStatus/orderview
{code}
Hence when the request is done, it is rewriting URL to
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview. When js
functions are running in the backend like "getAssociatedStateList" are called,
they are getting the wrong URL to send a request to. This was causing the issue.
For now, there are two different fixes that can handle both problems which are
mentioned in [OFBIZ-2562|https://issues.apache.org/jira/browse/OFBIZ-2562] and
[OFBIZ-11838|https://issues.apache.org/jira/browse/OFBIZ-11838].
# To change the request mapping for "changeOrderStatus" and add
request-redirect to "orderview" screen. Change the actions in the forms in
OrderInfo.ftl to call "changeOrderStatus" request only and then remove code in
"getAssociatedStateList" js function to rewrite URL.
# To add .length to the existing URL rewrite code written in
"getAssociatedStateList" js function as
{code:java}
if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}
{code}
> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so
> it's something "recent"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10740) Ellipsis on product name and description
[ https://issues.apache.org/jira/browse/OFBIZ-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10740: - Assignee: Aditya Sharma > Ellipsis on product name and description > > > Key: OFBIZ-10740 > URL: https://issues.apache.org/jira/browse/OFBIZ-10740 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Aditya Sharma >Priority: Trivial > Attachments: 1046.png, 1046.png, OFBIZ-10740.patch, Screenshot.png, > ellipsis for consistency.png, ellipsis for consistency.png > > > We can apply ellipsis to various places at home page like on name and > description of the product to keep the symmetry of the page aligned and to > attain consistency. > Please have a look at the attached screenshot > > !ellipsis for consistency.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164870#comment-17164870 ] Jacques Le Roux commented on OFBIZ-11915: - I'd ask on dev ML :) > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11859) Convert CostTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164868#comment-17164868 ] Anushi Gupta commented on OFBIZ-11859: -- Provided the patch This can be tested using this command ./gradlew "ofbiz --test component=product --test suitename=productcosttests" > Convert CostTests.xml to Groovy > --- > > Key: OFBIZ-11859 > URL: https://issues.apache.org/jira/browse/OFBIZ-11859 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Anushi Gupta >Priority: Minor > Attachments: OFBIZ-11859.patch > > > Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11859) Convert CostTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta updated OFBIZ-11859: - Attachment: OFBIZ-11859.patch > Convert CostTests.xml to Groovy > --- > > Key: OFBIZ-11859 > URL: https://issues.apache.org/jira/browse/OFBIZ-11859 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Anushi Gupta >Priority: Minor > Attachments: OFBIZ-11859.patch > > > Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11916) Order parts of product
Jacques Le Roux created OFBIZ-11916: --- Summary: Order parts of product Key: OFBIZ-11916 URL: https://issues.apache.org/jira/browse/OFBIZ-11916 Project: OFBiz Issue Type: Improvement Components: ecommerce, order, product/catalog Affects Versions: Trunk Reporter: Jacques Le Roux I created this as an improvement after our [discussion on dev ML|https://markmail.org/message/xo7uzu46gdebzapi] but it could be considered a bug. You should not be able to order parts of products like "Tiny Chrome Widget". The idea it to set orderDecimalQuantity to false for all products data but some, like Pizza, you can decide to sell parts of it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164858#comment-17164858 ] Suraj Khurana commented on OFBIZ-11915: --- Currently there are around 200 issues due to this. Default value is 150, we need to decide this configuration. Maximum length I noticed is of 945 lines (createOrder#OrderServices.java) Any thoughts ?? > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164857#comment-17164857 ] Aditya Sharma edited comment on OFBIZ-10111 at 7/25/20, 10:03 AM: -- I think it should rather be Open as we are waiting for the patch for the repeated label issue. Hence changing the status was (Author: aditya.sharma): I think it should rather be Open as we are waiting for the patch for the repeated label issue. > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164857#comment-17164857 ] Aditya Sharma commented on OFBIZ-10111: --- I think it should rather be Open as we are waiting for the patch for the repeated label issue. > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11915) Handle MethodLength checkstyle rule
Suraj Khurana created OFBIZ-11915: - Summary: Handle MethodLength checkstyle rule Key: OFBIZ-11915 URL: https://issues.apache.org/jira/browse/OFBIZ-11915 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11487. --- Resolution: Implemented > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11904) Case indentation for all switch statements should be 0
[ https://issues.apache.org/jira/browse/OFBIZ-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11904. - Fix Version/s: Upcoming Branch Resolution: Implemented This ticket fixed around *2000* checkstyle issues, bringing it down near to 18k. > Case indentation for all switch statements should be 0 > -- > > Key: OFBIZ-11904 > URL: https://issues.apache.org/jira/browse/OFBIZ-11904 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > > Currently in java code all switch statements are indented to 4 or more than > zero. > As per [https://www.oracle.com/technetwork/java/codeconventions-150003.pdf] > and same configured in checkstyle.xml, we need to make 'case' indentation to > 0 in all java code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164834#comment-17164834 ] ASF subversion and git services commented on OFBIZ-11487: - Commit faa59b325fc50fc58b578c2b5d9b6d50d21b2478 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=faa59b3 ] Improved: Convert voidPayment service from mini-lang to groovy DSL (OFBIZ-11487) Thanks: Sourabh Punyani > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164833#comment-17164833 ] Jacques Le Roux commented on OFBIZ-10834: - Thanks, got it after looking at you last comment at OFBIZ-9254 ;) > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[
https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164832#comment-17164832
]
Ankush Upadhyay commented on OFBIZ-10834:
-
Inside method *persistDataResourceAndDataMethod*, line number 642
} else if ("_FILE".indexOf(dataResourceTypeId) >= 0) {
.
In same file there are 4 places where startWith and indexOf touched under
OFBIZ-9254.
> Uploading image to data resource
>
>
> Key: OFBIZ-10834
> URL: https://issues.apache.org/jira/browse/OFBIZ-10834
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Assignee: Ankush Upadhyay
>Priority: Major
>
> Content --> DataResource --> "Create new"
> * Data Resource Id: some Id
> * Data Resource Type Id: local file
> --> "create"
> --> Upload --> "select local file" --> upload
> The result is no file uploaded. No error message.
> It works fine in ofbiz 16.11
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164830#comment-17164830
]
Sourabh Punyani commented on OFBIZ-11490:
-
Hello All,
I have been trying to convert this service
createPaymentAndPaymentGroupForInvoices from xml to groovy.
This is the service definition:
{code:xml}
Creates Payments, Payment Application and Payment Group
for the same
{code}
I am trying to figure out this piece of code
{code:xml}
{code}
Here, partyInvoices is not fetched in this service, neither it is coming from
service IN parameters.
It would be great if anyone could look into this and let me know what I am
missing here.
> Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to
> groovy DSL
>
>
> Key: OFBIZ-11490
> URL: https://issues.apache.org/jira/browse/OFBIZ-11490
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
>
> Convert the createPaymentAndPaymentGroupForInvoices service code from
> mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164829#comment-17164829 ] Jacques Le Roux commented on OFBIZ-11882: - Thanks Aditya for the reminder! > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11904) Case indentation for all switch statements should be 0
[ https://issues.apache.org/jira/browse/OFBIZ-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164828#comment-17164828 ] ASF subversion and git services commented on OFBIZ-11904: - Commit df21972eed26117dada43f7f50c0029598175f49 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=df21972 ] Improved: Updated case indentation to 0 for all switch statements in applications component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904) > Case indentation for all switch statements should be 0 > -- > > Key: OFBIZ-11904 > URL: https://issues.apache.org/jira/browse/OFBIZ-11904 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > > Currently in java code all switch statements are indented to 4 or more than > zero. > As per [https://www.oracle.com/technetwork/java/codeconventions-150003.pdf] > and same configured in checkstyle.xml, we need to make 'case' indentation to > 0 in all java code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11904) Case indentation for all switch statements should be 0
[ https://issues.apache.org/jira/browse/OFBIZ-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164827#comment-17164827 ] ASF subversion and git services commented on OFBIZ-11904: - Commit f4f2722d36839610008e514b18ab6da3cd0fe325 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f4f2722 ] Improved: Updated case indentation to 0 for all switch statements in framework component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904) > Case indentation for all switch statements should be 0 > -- > > Key: OFBIZ-11904 > URL: https://issues.apache.org/jira/browse/OFBIZ-11904 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > > Currently in java code all switch statements are indented to 4 or more than > zero. > As per [https://www.oracle.com/technetwork/java/codeconventions-150003.pdf] > and same configured in checkstyle.xml, we need to make 'case' indentation to > 0 in all java code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11904) Case indentation for all switch statements should be 0
[ https://issues.apache.org/jira/browse/OFBIZ-11904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164826#comment-17164826 ] ASF subversion and git services commented on OFBIZ-11904: - Commit 78801df4539f3d53d031e40697717315630529f1 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=78801df ] Improved: Updated case indentation to 0 for all switch statements in plugins component. Also done formatting changes as per checkstyle best practices. (OFBIZ-11904) > Case indentation for all switch statements should be 0 > -- > > Key: OFBIZ-11904 > URL: https://issues.apache.org/jira/browse/OFBIZ-11904 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > > Currently in java code all switch statements are indented to 4 or more than > zero. > As per [https://www.oracle.com/technetwork/java/codeconventions-150003.pdf] > and same configured in checkstyle.xml, we need to make 'case' indentation to > 0 in all java code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164824#comment-17164824 ] Jacques Le Roux commented on OFBIZ-10834: - Hi Ankush, Could you please be more specific about bq. This happened due to changes done with OFBIZ-9254 Where exactly? > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11217) Unable to proceed after payment information when Checkout Without Login
[ https://issues.apache.org/jira/browse/OFBIZ-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164823#comment-17164823 ] Jacques Le Roux commented on OFBIZ-11217: - Hi Rashi, Could you please check on trunk, it seems an error for PayPal/offline still exists? TIA > Unable to proceed after payment information when Checkout Without Login > --- > > Key: OFBIZ-11217 > URL: https://issues.apache.org/jira/browse/OFBIZ-11217 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Major > Attachments: CheckoutWithoutLoginPaymentopt.webm, > V-CheckoutwithoutLogin.webm, > screencast-nimbus-capture-2020.07.25-11_34_27.webm > > > Following issues found: > # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > # Add item to cart > # Click on Quick Checkout > # Click on checkout under Checkout Without Login section > # Enter Personal Info and continue > # Enter the address and continue > # Select shipping option and continue > # Select Payment Option and continue > Actual: > # If Payment Option id PayPal/offline, Billing Address section is not > visible and unable to proceed after a click on continue on the Payment > Information page and groovy error occurred. > # If Payment Option id Credit card, Check the "Billing address is the same > as the shipping address". Page get refreshed and checked box is unchecked. > Please refer attachment for same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10136) Update markup of Quick Checkout Page according to standard markup given by Bootstrap v4.0.0
[ https://issues.apache.org/jira/browse/OFBIZ-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164820#comment-17164820 ] ASF subversion and git services commented on OFBIZ-10136: - Commit c05bc3af1b6cb6d6748c12762b86509a36fe5175 in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c05bc3a ] Improved: Update markup of Quick Checkout Page according Bootstrap v4.0.0 (OFBIZ-10136) Fixes a typo > Update markup of Quick Checkout Page according to standard markup given by > Bootstrap v4.0.0 > --- > > Key: OFBIZ-10136 > URL: https://issues.apache.org/jira/browse/OFBIZ-10136 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: 17.12.01 >Reporter: Mayank Lambhate >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10136.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164819#comment-17164819 ] Ankush Upadhyay commented on OFBIZ-10834: - Linking both tickets > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164818#comment-17164818
]
Ankush Upadhyay commented on OFBIZ-9254:
[~devanshu.vyas],
Due to this ticket efforts, OFBIZ-10834 issue occurs because of changes made in
*startsWith* and *indexOf* methods in
ContentManagementServices.java file.
We should look for other places as well to fix all hidden/visible issues due to
this change.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10136) Update markup of Quick Checkout Page according to standard markup given by Bootstrap v4.0.0
[ https://issues.apache.org/jira/browse/OFBIZ-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164816#comment-17164816 ] ASF subversion and git services commented on OFBIZ-10136: - Commit dc55cb4746d21564068b872f81cffe81f17c73ed in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=dc55cb4 ] Improved: Update markup of Quick Checkout Page according Bootstrap v4.0.0 (OFBIZ-10136) Fixes a typo > Update markup of Quick Checkout Page according to standard markup given by > Bootstrap v4.0.0 > --- > > Key: OFBIZ-10136 > URL: https://issues.apache.org/jira/browse/OFBIZ-10136 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: 17.12.01 >Reporter: Mayank Lambhate >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10136.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164815#comment-17164815 ] Ankush Upadhyay commented on OFBIZ-10834: - This happened due to changes done with OFBIZ-9254, I believe we should have not touched other methods except equals and equalsIgnoreCase, else the functioning of the method can change and cause this type of issues. IMO we should look again OFBIZ-9254 and fix all affected places. FYI, [~jleroux], [~swapnilmmane], [~devanshu.vyas] > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11913) Error message is displayed when print order invoice PDF
[ https://issues.apache.org/jira/browse/OFBIZ-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-11913: -- Component/s: order > Error message is displayed when print order invoice PDF > --- > > Key: OFBIZ-11913 > URL: https://issues.apache.org/jira/browse/OFBIZ-11913 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ashish Sharma >Priority: Minor > Attachments: OFBIZ-11913.png > > > *Step to reproduce* > 1. Login with a valid username and password. > 2. Navigate to "[https://demo-trunk.ofbiz.apache.org/ecommerce/control]; > 3. Place an order. > 4. Navigate to order history and click on the view link. > 5. Click on PDF > *Actual Result:* The error message is displayed. > *Screenprint attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay reassigned OFBIZ-10834: --- Assignee: Ankush Upadhyay > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11914) Getting Error in receiving PO
[ https://issues.apache.org/jira/browse/OFBIZ-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11914. --- Resolution: Duplicate > Getting Error in receiving PO > - > > Key: OFBIZ-11914 > URL: https://issues.apache.org/jira/browse/OFBIZ-11914 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: ReceivingError.png > > > During receiving when we add quantity accepted and click on Receive selected > product and it shows error. > Steps to reproduce: > # Create PO and approve. > # Click on the receive button in the action section on the view order screen. > # User navigated to receive screen select the shipment and click on Receive > selected shipment. > # The user navigated to the receiving screen. > # Enter the quantity accepted and click on receive selected products. > # Error page render. > Expected: The product should be received and user should be navigated to the > shipment receipt screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11914) Getting Error in receiving PO
[ https://issues.apache.org/jira/browse/OFBIZ-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11914: - > Getting Error in receiving PO > - > > Key: OFBIZ-11914 > URL: https://issues.apache.org/jira/browse/OFBIZ-11914 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: ReceivingError.png > > > During receiving when we add quantity accepted and click on Receive selected > product and it shows error. > Steps to reproduce: > # Create PO and approve. > # Click on the receive button in the action section on the view order screen. > # User navigated to receive screen select the shipment and click on Receive > selected shipment. > # The user navigated to the receiving screen. > # Enter the quantity accepted and click on receive selected products. > # Error page render. > Expected: The product should be received and user should be navigated to the > shipment receipt screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9475) Refactor serialize and non-serialize inventory item implementaion
[ https://issues.apache.org/jira/browse/OFBIZ-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164789#comment-17164789 ] Yashwant Dhakad commented on OFBIZ-9475: Hi Deepak, Any update on this? If we commit this then I will start on duplicate code cleanup work. > Refactor serialize and non-serialize inventory item implementaion > - > > Key: OFBIZ-9475 > URL: https://issues.apache.org/jira/browse/OFBIZ-9475 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-9475.patch, OFBIZ-9475.patch, OFBIZ-9475.patch, > OFBIZ-9475.patch, OFBIZ-9475.patch > > > As discussed on dev mailing list [1][2] we need to refactor serialize and > non-serialize inventory item design. > As per current implementation serialize inventory item work on status and > non-serialized inventory item work on inventory item detail. > Proposed Design: > - Use inventory item detail for both serialise and non-serialize inventory > item. Only one additional condition for serialized inventory item that qoh > can't be greater then one. > - We can maintain inventory item status record for both type > [1] http://markmail.org/thread/bd2bpiv6c5wvl7km > [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7 > As we do a lot of discussion in the respective mail threads. > [1] http://markmail.org/thread/bd2bpiv6c5wvl7km > [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7 > According to this email threads, I conclude that:- > There are 2 types of the inventory item in OFBiz. > 1. *Serialized* > 2. *Non serialized* > Majorly there are 3 entities to manage the various transaction of serialised > and non-serialized inventory items. > 1. _InventoryItem_ > 2. _InventoryItemDetail_ > 3. _InventoryItemStatus_ > Following changes need to be done in the workflow of inventory item records:- > 1) There is no need to manage a different workflow for serialised and non- > serialised inventory items. > 2) Transaction of serialised and non-serialised inventory item should be > managed in both InventoryItemStatus and InventoryItemDetail entity. > a) Transaction of serialised inventory items is managed by > inventoryItemstatus entity not managed in inventoryItemDetail entity. While > inventoryItemDetail and inventoryItemStatus should be managed for both > serialised and non-serialised inventory items. > b) As ATP/QOH/AQT are updated on the basis of ATPDIFF/QOHDIFF/AQTDIFF in > non-serialised inventory item. We should follow the same pattern for > serialised inventory item. > c) Change in ATP/QOH/AQT is tracked by inventoryItemDetail entity. > d)Status transaction of an inventory item is tracked in > InventoryItemStatus entity. > 3) No need to manage separate status for serialised and non-serialised > inventory item. They are already distinguished on the basis of inventory item > type. > 1. *Serialised*:- > In a serialised inventory item as of now ATP/QOH/AQT are managed on the > basis of inventory item status.While ATP/QOH/AQT should be the sum of > ATPDIFF/QOHDIFF/AQTDIFF of inventory item detail. > Ex: > 1. If we receive 2 inventory of serialised inventory item then 2 separate > inventory item records are created > InventoryItem:- > inventoryItemId="10001",status="AVAILABLE", ATP="1", QOH="1",AQT="1" > inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1" > InventoryItemDetail:- > inventoryItemId="10001", inventoryItemDetailSeqId="10001", ATPDIFF="1", > QOHDIFF="1", AQTDIFF="1" > inventoryItemId="10002", inventoryItemDetailSeqId="10002", ATPDIFF="1", > QOHDIFF="1", AQTDIFF="1" > InventoryItemStatus:- > inventoryItemId="10001" statusId="AVAILABLE" > inventoryItemId="10002" statusId="AVAILABLE" > 2. If status of inventory item is changed from AVAILABLE -> PROMISED then > InventoryItem:- > inventoryItemId="10001",status="PROMISED", ATP="1", QOH="1",AQT="1" > inventoryItemId="10002",status="AVAILABLE", ATP="1", QOH="1",AQT="1" > InventoryItemDetail:- > inventoryItemId="10001", inventoryItemDetailSeqId="10001", ATPDIFF="1", > QOHDIFF="1", AQTDIFF="1" > inventoryItemId="10001", inventoryItemDetailSeqId="10002", ATPDIFF="-1", > QOHDIFF="0", AQTDIFF="0" > inventoryItemId="10002", inventoryItemDetailSeqId="10002", ATPDIFF="1", > QOHDIFF="1", AQTDIFF="1" > InventoryItemStatus:- > inventoryItemId="10001" statusId="AVAILABLE" statusEndDateTime="" > inventoryItemId="10002" statusId="PROMISED" > 2. *Non-serialised*:- > At the time of receive non-serialised inventory, Item should be received > in Available status. So that status of non-serialised inventory item can be > managed further. > Status of non-serialised inventory item
[jira] [Assigned] (OFBIZ-11735) Product link on Order confirmation page is not responding
[ https://issues.apache.org/jira/browse/OFBIZ-11735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani reassigned OFBIZ-11735: --- Assignee: Sourabh Punyani > Product link on Order confirmation page is not responding > - > > Key: OFBIZ-11735 > URL: https://issues.apache.org/jira/browse/OFBIZ-11735 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: 17.12.03 >Reporter: Rashi Dhagat >Assignee: Sourabh Punyani >Priority: Minor > Attachments: ProductlinkNotresponding.webm > > > Steps to regenerate: > 1. Open [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > 2. Login > 3. Add item to Cart > 4. Checkout > 5. Click on the product name in Order Items section > Actual: Page timeout error when click on product name link but working for > other links. > Please refer the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
