[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484423#comment-15484423 ] Jacques Le Roux commented on OFBIZ-8179: Thanks Scott and Jacopo, this is the better compromise indeed. > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484256#comment-15484256 ] Jacopo Cappellato commented on OFBIZ-8179: -- Thanks for all your feedback and reviews. I ended up committing a different version of my patch, in order to address Scott's comment: see rev. 1760376 With this fix I have removed the cyclic dependency between the two components; I didn't simplify the chain of calls required to get a connection from GeronimoTransactionFactory+DBCPConnectionFactory in order to maintain the flexibility to replace one of the two factories. We could revisit this discussion if/when we will have a measure that tells that direct calls improve the performance. > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480761#comment-15480761 ] Scott Gray commented on OFBIZ-8179: --- Hi Jacopo, Doesn't this change force users to use geronimo as their transaction manager when using dbcp2? Alternatively, if I want to use a different connection pooling implementation, I would now need to reimplement the TransactionFactory as well? Could we not just move GeronimoTransactionFactory.java into the entity component and achieve roughly the same result while still maintaining separation between transactions and connections? > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479392#comment-15479392
]
Jacopo Cappellato commented on OFBIZ-8179:
--
[~taher] I think you are referring to:
{code}
+
{code}
I have commented it out because it is not required setting and it is not
specifically required by the new transaction-factory.
I agree with you that it is better to remove it rather than leaving it
commented out.
Thanks
> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove
> the geronimo component
> -
>
> Key: OFBIZ-8179
> URL: https://issues.apache.org/jira/browse/OFBIZ-8179
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacopo Cappellato
>Assignee: Jacopo Cappellato
>Priority: Minor
> Attachments: OFBIZ-8179.patch,
> TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by
> moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and
> component dependencies because it removes a cyclic dependency between entity
> and geronimo components (see diagram attached that explain the architecture
> before and after this change).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477916#comment-15477916 ] Taher Alkhateeb commented on OFBIZ-8179: Hi Jacopo, Great work! Why comment out the transaction-factory and not delete instead? Or do you want to do that in one shot while deleting the geronimo component and libs from build.gradle as well (which would be great I might add) > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477817#comment-15477817 ] Jacques Le Roux commented on OFBIZ-8179: +1 after review (voted) > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
