[jira] [Created] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Denglong Zhou (JIRA)
Denglong Zhou created OFBIZ-11029:
-

 Summary: Issue in function getVariantSelectionFeatures of 
ProductWorker.java
 Key: OFBIZ-11029
 URL: https://issues.apache.org/jira/browse/OFBIZ-11029
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: 16.11.05, 18.12.01
Reporter: Denglong Zhou


{code:java}

//代码占位符
public static List getVariantSelectionFeatures(GenericValue 
variantProduct) {
if (!"Y".equals(variantProduct.getString("isVariant"))) {
return null;
}
GenericValue virtualProduct = 
ProductWorker.getParentProduct(variantProduct.getString("productId"), 
variantProduct.getDelegator());
if (virtualProduct == null || 
!"Y".equals(virtualProduct.getString("productId"))) {
return null;
}
{code}
for the above coding, i guess the part colored by red should be the following,
{code:java}
//代码占位符
if (virtualProduct == null || 
!"Y".equals(virtualProduct.getString("isVirtual"))) {
{code}
thanks!

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11028) field emplFromDate is forgot in PayHistory entity

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839171#comment-16839171
 ] 

Jacques Le Roux commented on OFBIZ-11028:
-

Thanks Olivier,

I just made a quick review and it sounds good to me. I don't think we need 
anything about upgrading the DB since it's only an adding. I'll review deeper 
and test soon...

> field emplFromDate is forgot in PayHistory entity
> -
>
> Key: OFBIZ-11028
> URL: https://issues.apache.org/jira/browse/OFBIZ-11028
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Olivier Heintz
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: OFBIZ-11028.patch
>
>
> A Employment can have multiple PayHistory and should have multiple 
> because PayHistory should show history of Pay  for a employment  !
> Currently, in PayHistory the field fromDate from Employment is confused with 
> fromDate about the current record, it's necessary to have a field 
> emplFromDate (to have the complete employment primaryKey).
> Currently user interface for PayHistory is not working, when modifying a 
> PayRecord the current should be expire and a new one should be created.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11029:
---

Assignee: Pawan Verma

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: 16.11.05, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Pawan Verma
>Priority: Critical
>  Labels: product, variant
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11029:

Attachment: OFBIZ-11029.patch

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: 16.11.05, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Pawan Verma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839209#comment-16839209
 ] 

Pawan Verma commented on OFBIZ-11029:
-

Nice Catch, Yes it should be isVirtual instead of productId. Attached patch for 
the same and also handled a NullPointerException for variantProduct.

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: 16.11.05, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Pawan Verma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11029:

Affects Version/s: Release Branch 17.12
   Trunk

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Pawan Verma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839209#comment-16839209
 ] 

Pawan Verma edited comment on OFBIZ-11029 at 5/14/19 8:41 AM:
--

Nice Catch, Yes it should be isVirtual instead of productId. Attached patch for 
the same and also handled a NullPointerException for variantProduct.

I have also updated Affected Version(s).


was (Author: pawan.verma):
Nice Catch, Yes it should be isVirtual instead of productId. Attached patch for 
the same and also handled a NullPointerException for variantProduct.

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Pawan Verma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-11029:
-

Assignee: Aditya Sharma  (was: Pawan Verma)

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839223#comment-16839223
 ] 

Suraj Khurana commented on OFBIZ-11029:
---

+1.
Patch looks good to me.

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, 16.11.05, Release Branch 17.12, 18.12.01
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-11029:
--
Affects Version/s: (was: 18.12.01)
   (was: 16.11.05)
   Release Branch 18.12
   Release Branch 16.11

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839737#comment-16839737
 ] 

Jacques Le Roux commented on OFBIZ-11029:
-

Thanks Aditya for changing the affected versions.

Pawan, though in this case it's obvious, in generarlwe never know when a bug 
will be fixed. So, by and large, we use releases branches in affected versions 
and not directly a release version.

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Critical
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11029:

Priority: Major  (was: Critical)

Thanks for report Zhou,

This bug is major not critical. Critical bugs block releases by our 
conventions.  This should not block a release (even if I guess it will be 
committed before next release).

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy

2019-05-14 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10948:
-
Affects Version/s: Trunk

> Convert DimensionServices.xml minilang to groovy
> 
>
> Key: OFBIZ-10948
> URL: https://issues.apache.org/jira/browse/OFBIZ-10948
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Minilang, groovy,
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert 
> DimensionServices.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11030) Convert FactServices.xml minilang to groovy

2019-05-14 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-11030:


 Summary: Convert FactServices.xml minilang to groovy
 Key: OFBIZ-11030
 URL: https://issues.apache.org/jira/browse/OFBIZ-11030
 Project: OFBiz
  Issue Type: Sub-task
  Components: bi
Affects Versions: Trunk
Reporter: Pierre Smits


With the purpose to deprecate mini-lang OFBIZ-9350,  convert FactServices.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839743#comment-16839743
 ] 

Jacques Le Roux commented on OFBIZ-11029:
-

Thanks Pawan,

Your patch looks good to me too :)

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840021#comment-16840021
 ] 

Aditya Sharma commented on OFBIZ-11029:
---

Thanks Denglong Zhou for reporting the issue, Pawan Verma for the patch and 
Suraj Khurana & Jacques Le Roux for the review

Fixed in 

trunk r1859255
R18 r1859256
R17 r1859257
R16 r1859258

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: product, variant
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma closed OFBIZ-11029.
-

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: product, variant
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma resolved OFBIZ-11029.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: product, variant
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11029.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue 
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct = 
> ProductWorker.getParentProduct(variantProduct.getString("productId"), 
> variantProduct.getDelegator());
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null || 
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840068#comment-16840068
 ] 

Jacques Le Roux commented on OFBIZ-5776:


HI Deepak, All,

What is the situation here?

> Move static resources from framework/images to framework/resources webapp
> -
>
> Key: OFBIZ-5776
> URL: https://issues.apache.org/jira/browse/OFBIZ-5776
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-5776.patch
>
>
> Move all the static resources form images webapp to resources webapp, as they 
> all are more related to resources rather then images.
> Also we need to rearrange these resources based on their purpose, like 
> - Move all js related files and plugins under resources/js
> - Move all the css related files and plugins under resources/css
> - Move all the images related to js and css under resources/images or 
> resources/img



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840070#comment-16840070
 ] 

Jacques Le Roux commented on OFBIZ-10895:
-

Fixed in HR:

trunk r1859263
R18 r1859264

Not a problem in older branches

> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) 
> [tomcat-coyote-9.0

[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840071#comment-16840071
 ] 

Jacques Le Roux commented on OFBIZ-10895:
-

BTW [we have a problem with "images" at 
large|https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20text%20~%20%22images%22]

> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
> [tomcat-ca

[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2019-05-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840078#comment-16840078
 ] 

Suraj Khurana commented on OFBIZ-10518:
---

Improved condition in which reservation block was not being executed in case of 
auto-reserve not found in attribute.

Done at rev #1859267

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518-UI.patch, 
> OFBiz-10518-data.patch, OFBiz-10518-entity-model.patch, 
> OFBiz-10518-secas.patch, OFBiz-10518-services.patch, 
> OFBiz-10518-ui-labels.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-14 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840070#comment-16840070
 ] 

Jacques Le Roux edited comment on OFBIZ-10895 at 5/15/19 6:17 AM:
--

Fixed in HR:

trunk r1859263+r1859268
 R18 r1859264+1859269

Not a problem in older branches


was (Author: jacques.le.roux):
Fixed in HR:

trunk r1859263
R18 r1859264

Not a problem in older branches

> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(

[jira] [Created] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-14 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-11031:


 Summary: Improve SalesOrderItemFact table
 Key: OFBIZ-11031
 URL: https://issues.apache.org/jira/browse/OFBIZ-11031
 Project: OFBiz
  Issue Type: Improvement
  Components: bi
Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
Reporter: Pierre Smits


Improve the SalesOrderFactTable to include additional dimensions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)