date:20180330

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

2018-03-30 Thread ejwhite922

GitHub user ejwhite922 opened a pull request:

https://github.com/apache/incubator-rya/pull/285

RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.

## Description
Joins were not working in Rya Streams.  The KeyValueJoinStateStore needed 
to have a queryId associated with each row in RocksDB.  Also, the range search 
that returned the RocksDB iterator needed to mark where the join variables 
ended so the results would not include characters that came after the start and 
end range markers (i.e. a range search from "urn:Student9[0x00]" to 
"urn:Student9[0xFF]" would incorrectly include 
"urn:Student95,[remainingBindingResults]" when we only wanted rows for 
"urn:Student9").

### Tests
LUBM data and queries were added for testing.
Unit Tests

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-469)

### Checklist
- [ ] Code Review
- [ ] Squash Commits

 People To Review
@isper3at 
@kchilton2 
@pujav65 
@meiercaleb 
@amihalik 
@DLotts
@jessehatfield 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ejwhite922/incubator-rya 
RYA-469_RyaStreamsJoinIteratorBug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit a6c9bf8604705ece21d68543cd7bcc1ea252204a
Author: eric.white 
Date:   2018-03-29T19:32:56Z

RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.




---

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420844#comment-16420844
 ] 

ASF GitHub Bot commented on RYA-469:


GitHub user ejwhite922 opened a pull request:

https://github.com/apache/incubator-rya/pull/285

RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.

## Description
Joins were not working in Rya Streams.  The KeyValueJoinStateStore needed 
to have a queryId associated with each row in RocksDB.  Also, the range search 
that returned the RocksDB iterator needed to mark where the join variables 
ended so the results would not include characters that came after the start and 
end range markers (i.e. a range search from "urn:Student9[0x00]" to 
"urn:Student9[0xFF]" would incorrectly include 
"urn:Student95,[remainingBindingResults]" when we only wanted rows for 
"urn:Student9").

### Tests
LUBM data and queries were added for testing.
Unit Tests

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-469)

### Checklist
- [ ] Code Review
- [ ] Squash Commits

 People To Review
@isper3at 
@kchilton2 
@pujav65 
@meiercaleb 
@amihalik 
@DLotts
@jessehatfield 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ejwhite922/incubator-rya 
RYA-469_RyaStreamsJoinIteratorBug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #285


commit a6c9bf8604705ece21d68543cd7bcc1ea252204a
Author: eric.white 
Date:   2018-03-29T19:32:56Z

RYA-469 Added tests for Rya Streams join iterator bug using LUBM data.




> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:170)
> ... 13 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420944#comment-16420944
 ] 

ASF GitHub Bot commented on RYA-469:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/285
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/718/



> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:170)
> ... 13 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

2018-03-30 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/285
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/718/



---

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420860#comment-16420860
 ] 

ASF GitHub Bot commented on RYA-469:


Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/285
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/716/Build
 result: FAILURE[...truncated 1.60 MB...][INFO] Apache Rya Spark 
Support ... SKIPPED[INFO] Apache Rya Web Projects 
 SKIPPED[INFO] Apache Rya Web Implementation 
.. SKIPPED[INFO] 
[INFO] 
BUILD FAILURE[INFO] 
[INFO] 
Total time: 25:09 min[INFO] Finished at: 2018-03-30T19:35:18+00:00[INFO] Final 
Memory: 220M/2461M[INFO] 
[ERROR] 
Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check 
(check-licenses) on project rya.indexing.example: Too many files with 
unapproved license: 1 See RAT report in: 
/home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/indexingExample/target/rat.txt
 -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run 
Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable 
full debug logging.[ERROR] [ERROR] For more information about the errors and 
possible solutions, please read the following articles:[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command[ERROR]   mvn  -rf :rya.indexing.examplechannel stoppedSetting 
status of a6c9bf8604705ece21d68543cd7bcc1ea252204a to FAILURE with url 
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/716/
 and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing



> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
>

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

2018-03-30 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/285
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/717/Failed
 Tests: 1incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.indexing.example:
 1ExamplesTest.MongoRyaDirectExampleTest



---

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420947#comment-16420947
 ] 

ASF GitHub Bot commented on RYA-469:


Github user kchilton2 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178385888
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/processors/join/KeyValueJoinStateStore.java
 ---
@@ -77,30 +77,39 @@
 /**
  * This is the maximum value of a UTF-8 character.
  */
-private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0XFF }, Charsets.UTF_8);
+private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0xFF }, Charsets.UTF_8);
+
+/**
+ * Indicates where the end of the join variables occurs.
+ */
+private static final String JOIN_VAR_END_MARKER = new 
String("~!^~".getBytes(Charsets.UTF_8), Charsets.UTF_8);
--- End diff --

I'm not sure that the marker should be in the visually renderable byte 
ranges since, while very unlikely, they could legitimately appear in the data 
that is being indexed.


> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:170)
> ... 13 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

2018-03-30 Thread kchilton2

Github user kchilton2 commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178385888
  
--- Diff: 
extras/rya.streams/kafka/src/main/java/org/apache/rya/streams/kafka/processors/join/KeyValueJoinStateStore.java
 ---
@@ -77,30 +77,39 @@
 /**
  * This is the maximum value of a UTF-8 character.
  */
-private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0XFF }, Charsets.UTF_8);
+private static final String END_RANGE_SUFFIX = new String(new byte[] { 
(byte) 0xFF }, Charsets.UTF_8);
+
+/**
+ * Indicates where the end of the join variables occurs.
+ */
+private static final String JOIN_VAR_END_MARKER = new 
String("~!^~".getBytes(Charsets.UTF_8), Charsets.UTF_8);
--- End diff --

I'm not sure that the marker should be in the visually renderable byte 
ranges since, while very unlikely, they could legitimately appear in the data 
that is being indexed.


---

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

2018-03-30 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/incubator-rya/pull/285
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/716/Build
 result: FAILURE[...truncated 1.60 MB...][INFO] Apache Rya Spark 
Support ... SKIPPED[INFO] Apache Rya Web Projects 
 SKIPPED[INFO] Apache Rya Web Implementation 
.. SKIPPED[INFO] 
[INFO] 
BUILD FAILURE[INFO] 
[INFO] 
Total time: 25:09 min[INFO] Finished at: 2018-03-30T19:35:18+00:00[INFO] Final 
Memory: 220M/2461M[INFO] 
[ERROR] 
Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check 
(check-licenses) on project rya.indexing.example: Too many files with 
unapproved license: 1 See RAT report in: 
/home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/index
 ingExample/target/rat.txt -> [Help 1][ERROR] [ERROR] To see the full stack 
trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using 
the -X switch to enable full debug logging.[ERROR] [ERROR] For more information 
about the errors and possible solutions, please read the following 
articles:[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command[ERROR]   mvn  -rf :rya.indexing.examplechannel stoppedSetting 
status of a6c9bf8604705ece21d68543cd7bcc1ea252204a to FAILURE with url 
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/716/
 and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing



---

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

2018-03-30 Thread isper3at

Github user isper3at commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178368019
  
--- Diff: extras/indexingExample/src/main/java/MongoRyaDirectExample.java 
---
@@ -805,6 +819,38 @@ public static void testAddAndDeleteNoContext(final 
SailRepositoryConnection conn
 Validate.isTrue(resultHandler.getCount() == 0);
 }
 
+public static void testLubmFile(final SailRepositoryConnection conn) 
throws MalformedQueryException, RepositoryException,
+UpdateExecutionException, QueryEvaluationException, 
TupleQueryResultHandlerException, RDFParseException, IOException {
+
+final String query = LubmQuery.LUBM_QUERY_14.getSparqlQuery();
+//"PREFIX lubm: <" + LUBM_PREFIX + "> \n" +
--- End diff --

remove commented out code


---

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420890#comment-16420890
 ] 

ASF GitHub Bot commented on RYA-469:


Github user isper3at commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178368019
  
--- Diff: extras/indexingExample/src/main/java/MongoRyaDirectExample.java 
---
@@ -805,6 +819,38 @@ public static void testAddAndDeleteNoContext(final 
SailRepositoryConnection conn
 Validate.isTrue(resultHandler.getCount() == 0);
 }
 
+public static void testLubmFile(final SailRepositoryConnection conn) 
throws MalformedQueryException, RepositoryException,
+UpdateExecutionException, QueryEvaluationException, 
TupleQueryResultHandlerException, RDFParseException, IOException {
+
+final String query = LubmQuery.LUBM_QUERY_14.getSparqlQuery();
+//"PREFIX lubm: <" + LUBM_PREFIX + "> \n" +
--- End diff --

remove commented out code


> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:170)
> ... 13 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

2018-03-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/RYA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420889#comment-16420889
 ] 

ASF GitHub Bot commented on RYA-469:


Github user isper3at commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178368138
  
--- Diff: 
extras/rya.streams/client/src/test/java/org/apache/rya/streams/client/command/RunQueryCommandIT.java
 ---
@@ -196,4 +203,74 @@ public void run() {
 // Show the read results matched the expected ones.
 assertEquals(expected, results);
 }
+
+@Test
+public void runQueryFromFile() throws Exception {
+// TODO: Maybe test with 
org.apache.rya.api.utils.LubmQuery.LUBM_QUERY_1,2,3,etc...
--- End diff --

remove TODO?


> Rya Streams - Join iterator bug.
> 
>
> Key: RYA-469
> URL: https://issues.apache.org/jira/browse/RYA-469
> Project: Rya
>  Issue Type: Bug
>Reporter: Kevin Chilton
>Assignee: Kevin Chilton
>Priority: Major
>
> {code:java}
> Exception in thread "StreamThread-3" java.lang.RuntimeException: Problem 
> encountered while iterating over the other side's values within the state 
> store.
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:178)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:95)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:112)
> at 
> org.apache.rya.streams.kafka.processors.StatementPatternProcessorSupplier$StatementPatternProcessor.process(StatementPatternProcessorSupplier.java:70)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:68)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.forward(StreamTask.java:343)
> at 
> org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:187)
> at 
> org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:64)
> at 
> org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:174)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:320)
> at 
> org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:218)
> Caused by: java.lang.IllegalStateException: The end of range marker must be 
> the last key in the iterator.
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.readNext(KeyValueJoinStateStore.java:221)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:188)
> at 
> org.apache.rya.streams.kafka.processors.join.KeyValueJoinStateStore$1.next(KeyValueJoinStateStore.java:158)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:77)
> at 
> org.apache.rya.api.function.join.LazyJoiningIterator.next(LazyJoiningIterator.java:41)
> at 
> org.apache.rya.streams.kafka.processors.join.JoinProcessorSupplier$JoinProcessor.process(JoinProcessorSupplier.java:170)
> ... 13 more{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

2018-03-30 Thread isper3at

Github user isper3at commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/285#discussion_r178368138
  
--- Diff: 
extras/rya.streams/client/src/test/java/org/apache/rya/streams/client/command/RunQueryCommandIT.java
 ---
@@ -196,4 +203,74 @@ public void run() {
 // Show the read results matched the expected ones.
 assertEquals(expected, results);
 }
+
+@Test
+public void runQueryFromFile() throws Exception {
+// TODO: Maybe test with 
org.apache.rya.api.utils.LubmQuery.LUBM_QUERY_1,2,3,etc...
--- End diff --

remove TODO?


---

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

[GitHub] incubator-rya issue #285: RYA-469 Added tests for Rya Streams join iterator ...

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[jira] [Commented] (RYA-469) Rya Streams - Join iterator bug.

[GitHub] incubator-rya pull request #285: RYA-469 Added tests for Rya Streams join it...

13 matches

Site Navigation

Mail list logo

Footer information