[GitHub] [incubator-shardingsphere] coveralls commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
coveralls commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542556682 ## Pull Request Test Coverage Report for [Build 659](https://coveralls.io/builds/26341554) * **16** of **16** **(100.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.03%**) to **67.499%** --- | Totals | [](https://coveralls.io/builds/26341554) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.03% | | Covered Lines: | 11242 | | Relevant Lines: | 16655 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
dongzl removed a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542539196 I'm dealing with the the Integration Tests problem, Please wait a moment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3291: add test for GroupByContextEngine
coveralls edited a comment on issue #3291: add test for GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291#issuecomment-542551463 ## Pull Request Test Coverage Report for [Build 660](https://coveralls.io/builds/26342477) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **67.478%** --- | Totals | [](https://coveralls.io/builds/26342477) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.006% | | Covered Lines: | 11229 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao opened a new pull request #3292: add SQL test case to moudle sql-test and parse-test
haetao opened a new pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292 Add test case Case1: insert_with_duplicate_key_way_1 Case2: insert_with_duplicate_key_way_2 Case3: insert_with_duplicate_key_way_3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3247: concat() nest left() function-->>can not find the logic table name
terrymanu closed issue #3247: concat() nest left() function-->>can not find the logic table name URL: https://github.com/apache/incubator-shardingsphere/issues/3247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3271: #3247, support left/right function parse
terrymanu merged pull request #3271: #3247, support left/right function parse URL: https://github.com/apache/incubator-shardingsphere/pull/3271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3284: Fix assignmentValueNode get error index
terrymanu commented on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542581832 > > The modification may cause problem. > > Right now we just can recognize 2 model: > > ``` > > 1. xxx = xxx > > > > 2. xxx = values(xxx) > > ``` > > > > > > So the value we need to fetch is index `2` or index `4`. > > I know we cannot get all scenarios, but if we change index to `3` on this pr, the scenario `xxx = values(xxx)` will be broken. > > The problem of this issue is AST. AST should make consist of set assignment as `3` children, the right value should in one node and other more expression should in the next level of AST. > > We need to modify g4 file to change the structure of AST. > > g4 like this will be ok? > > ``` > assignment > : columnName EQ_ assignmentRight_ > ; > > assignmentRight_ > : VALUES LP_ RP_ | assignmentValue > ; > ``` Maybe not enough ,because they may have calculate expression like `values(xx) + values(yy)` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3291: add test for GroupByContextEngine
terrymanu merged pull request #3291: add test for GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #3138: Add more unit test cases for sharding-core-preprocessor module
terrymanu opened a new issue #3138: Add more unit test cases for sharding-core-preprocessor module URL: https://github.com/apache/incubator-shardingsphere/issues/3138 sharding-core-preprocessor module is decouple with Sharding & encrypt. The codes has already stable. Should Add more unit test cases for this module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] qixiaobo commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
qixiaobo commented on a change in pull request #3288: fixes
QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336254
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
##
@@ -135,4 +135,28 @@ private static Object getValueByColumnType(final
ResultSet resultSet, final int
return resultSet.getObject(columnIndex);
}
}
+
+private static Object getIntTypeValue(final ResultSet resultSet, final int
columnIndex) throws SQLException {
+ResultSetMetaData metaData = resultSet.getMetaData();
+if (metaData.isSigned(columnIndex)) {
+return resultSet.getInt(columnIndex);
+}
+long value = resultSet.getLong(columnIndex);
+if (value > Integer.MAX_VALUE) {
+return value;
+}
+return (int) value;
+}
+
+private static Object getBigIntTypeValue(final ResultSet resultSet, final
int columnIndex) throws SQLException {
+ResultSetMetaData metaData = resultSet.getMetaData();
+if (metaData.isSigned(columnIndex)) {
+return resultSet.getLong(columnIndex);
+}
+BigDecimal value = resultSet.getBigDecimal(columnIndex);
+if (new BigDecimal(Long.MAX_VALUE).compareTo(value) <= -1) {
+return value;
Review comment:
maybe return value.toBigInteger()?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3138: Add more unit test cases for sharding-core-preprocessor module
terrymanu closed issue #3138: Add more unit test cases for sharding-core-preprocessor module URL: https://github.com/apache/incubator-shardingsphere/issues/3138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #3293: add test for OrderByContextEngine
betterjava opened a new pull request #3293: add test for OrderByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3293 Fixes #3138. Changes proposed in this pull request: - Add OrderByContextEngineTest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
KomachiSion commented on a change in pull request #3288: fixes
QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336109
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
##
@@ -135,4 +135,28 @@ private static Object getValueByColumnType(final
ResultSet resultSet, final int
return resultSet.getObject(columnIndex);
}
}
+
+private static Object getIntTypeValue(final ResultSet resultSet, final int
columnIndex) throws SQLException {
Review comment:
I think the method can be remove
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
KomachiSion commented on a change in pull request #3288: fixes
QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
URL:
https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336771
##
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
##
@@ -135,4 +135,28 @@ private static Object getValueByColumnType(final
ResultSet resultSet, final int
return resultSet.getObject(columnIndex);
}
}
+
+private static Object getIntTypeValue(final ResultSet resultSet, final int
columnIndex) throws SQLException {
+ResultSetMetaData metaData = resultSet.getMetaData();
+if (metaData.isSigned(columnIndex)) {
+return resultSet.getInt(columnIndex);
+}
+long value = resultSet.getLong(columnIndex);
+if (value > Integer.MAX_VALUE) {
+return value;
+}
+return (int) value;
+}
+
+private static Object getBigIntTypeValue(final ResultSet resultSet, final
int columnIndex) throws SQLException {
+ResultSetMetaData metaData = resultSet.getMetaData();
+if (metaData.isSigned(columnIndex)) {
+return resultSet.getLong(columnIndex);
+}
+BigDecimal value = resultSet.getBigDecimal(columnIndex);
+if (new BigDecimal(Long.MAX_VALUE).compareTo(value) <= -1) {
+return value;
+}
Review comment:
Use BigInteger replace BigDecimal may be better.
can use getBigDecimal().toBigInteger to get BigInteger
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335336757 ## File path: sharding-core/sharding-core-parse/sharding-core-parse-test/src/test/resources/sharding/dml/insert.xml ## @@ -665,4 +665,79 @@ + + Review comment: Do not name as `xxx_1` and `xxx_2`, please name the test case make sense. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.
KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335335594 ## File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java ## @@ -105,9 +105,9 @@ private static Object getValueByColumnType(final ResultSet resultSet, final int case Types.TINYINT: case Types.SMALLINT: case Types.INTEGER: -return resultSet.getInt(columnIndex); +return getIntTypeValue(resultSet, columnIndex); Review comment: TINYINT and SAMLLINT use getInt is enough INTEGER if isSigned, should still getInt, if isUnsigned can getLong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #3276: Add table owner for logic encrypt column
tristaZero commented on a change in pull request #3276: Add table owner for
logic encrypt column
URL:
https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r335343151
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/pojo/EncryptPredicateToken.java
##
@@ -32,22 +32,26 @@
* @author panjuan
*/
public final class EncryptPredicateToken extends SQLToken implements
Substitutable {
-
+
@Getter
private final int stopIndex;
-
+
+private final String tableOwner;
Review comment:
Hi..maybe it could be columnOwner?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542592442 > That maybe not enough because the expression may `values(xx) + values(xx)`. > So `VALUES` should be a part of expr ``` assignmentRight_ : VALUES LP_ assignmentValue RP_ | assignmentValue ; setAssignmentsClause : SET assignment (COMMA_ assignment)* ; assignmentValues : LP_ assignmentValue (COMMA_ assignmentValue)* RP_ | LP_ RP_ ; assignmentValue : expr | DEFAULT | blobValue ; ``` assignmentValue may be expr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index
jingshanglu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542592442 > That maybe not enough because the expression may `values(xx) + values(xx)`. > So `VALUES` should be a part of expr ``` assignmentRight_ : VALUES LP_ assignmentValue RP_ | assignmentValue ; setAssignmentsClause : SET assignment (COMMA_ assignment)* ; assignmentValues : LP_ assignmentValue (COMMA_ assignmentValue)* RP_ | LP_ RP_ ; assignmentValue : expr | DEFAULT | blobValue ; ``` @terrymanu assignmentValue may be expr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #289: Add document contributor guide and sharding-ui and sharding-secure#284
terrymanu merged pull request #289: Add document contributor guide and sharding-ui and sharding-secure#284 URL: https://github.com/apache/incubator-shardingsphere-doc/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #288: Add document contributor guide#284
terrymanu merged pull request #288: Add document contributor guide#284 URL: https://github.com/apache/incubator-shardingsphere-doc/pull/288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3292: add SQL test case to moudle sql-test and parse-test
coveralls commented on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 661](https://coveralls.io/builds/26343342) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **67.472%** --- | Totals | [](https://coveralls.io/builds/26343342) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.0% | | Covered Lines: | 11228 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #287: add benchmark folder
terrymanu merged pull request #287: add benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner opened a new issue #3294: How to compute the max pool size of sharding-proxy ?
Myshiner opened a new issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294 Project: Sharding-proxy Version: v3.1.0 & v4.x ## Question How can i count the total connections of sharding-proxy ? should I use "netstat -an|grep :3307|wc -l" to compute on the server ? And what's more, what's the max pool size of sharding-proxy ? Does it equal to total of "MaxPoolSize" in the config-master_salve.yaml and config-sharding.yaml ? For example, if i set MaxPoolSize to 50 with master node and 40 with slave node in config-sharding.yaml, and the MaxPoolSize be set to 100 with master node and 100 with slave node in config-sharding.yaml, then the total MaxPoolSize is 290 ? Thank you ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #290: Update build.sh
tristaZero opened a new pull request #290: Update build.sh URL: https://github.com/apache/incubator-shardingsphere-doc/pull/290 add benchmark This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3289: jdbcType=LONGVARCHAR insert into table fail
yanickxia commented on issue #3289: jdbcType=LONGVARCHAR insert into table fail URL: https://github.com/apache/incubator-shardingsphere/issues/3289#issuecomment-542604685 this a mybatis bug ? ```java Caused by: java.io.NotSerializableException: java.io.StringReader at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348) at com.mysql.jdbc.PreparedStatement.setSerializableObject(PreparedStatement.java:3824) ... 42 more ``` in fact, mysql jdbc driver try to Serializable it. it's fail... i think it's without any problem on sharding... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3294: How to compute the max pool size of sharding-proxy ?
yanickxia commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542606379 try [SCTL (Sharding-Proxy control language)](https://shardingsphere.apache.org/document/current/en/manual/sharding-proxy/usage/) sctl:show cached_connections | Query the number of cached physical database connections in the current TCP connection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index
coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 663](https://coveralls.io/builds/26343986) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.006%**) to **67.478%** --- | Totals | [](https://coveralls.io/builds/26343986) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.006% | | Covered Lines: | 11229 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3293: add test for OrderByContextEngine
terrymanu merged pull request #3293: add test for OrderByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542621408 I got the result. mysql> sctl:show cached_connections; ++ | CACHED_CONNECTIONS | ++ | 0 | ++ 1 row in set (0.00 sec) I wonder what's the max connection of sharding-proxy, just like the "max_connections" and "max_user_connections" of mysql. Bcoz there are so many config files like "config-master_slave.yaml" and "config-sharding_yaml", and every config file include at lest two "maxPoolSize" parameters by default value 50, maybe i have 5 logic schemas to use master-slave, and 2 logic schemas to use sharding, so i have 5 config files named config-master_slave*.yaml and 2 files named config-sharding*.yaml, so what's the total pool size ? By the way, can i set the parameter maxPoolSize with different value to different schema ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335378743 ## File path: sharding-core/sharding-core-parse/sharding-core-parse-test/src/test/resources/sharding/dml/insert.xml ## @@ -665,4 +665,79 @@ + + Review comment: I 'll modify them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542623052 Actually now many applications connected to proxy, the proxy port is 3306, and result is 113 by running command "netstat -an|grep :3306|wc -l", but it's still no cached_connections when run sctl:show cached_connections. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542627489 > Are you sure the keyword `VALUES` in the rule expr? I cannot found it, if remove `VALUES` from set assignment and do not process it in expr, the SQL will parse error values() is a function ,I add the func in expr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new pull request #291: add performance monitoring page
wqzwh opened a new pull request #291: add performance monitoring page URL: https://github.com/apache/incubator-shardingsphere-doc/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3178: The INSERT statement with
yanickxia commented on issue #3178: The INSERT statement with https://github.com/apache/incubator-shardingsphere/issues/3178#issuecomment-542629195  i use demo-example to reapet it. but i can insert this value try RC3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new pull request #292: delete benchmark folder
wqzwh opened a new pull request #292: delete benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #291: add performance monitoring page
terrymanu merged pull request #291: add performance monitoring page URL: https://github.com/apache/incubator-shardingsphere-doc/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero closed pull request #290: Update build.sh
tristaZero closed pull request #290: Update build.sh URL: https://github.com/apache/incubator-shardingsphere-doc/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gufengwyx8 commented on a change in pull request #3276: Add table owner for logic encrypt column
gufengwyx8 commented on a change in pull request #3276: Add table owner for
logic encrypt column
URL:
https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r335395946
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/pojo/EncryptPredicateToken.java
##
@@ -32,22 +32,26 @@
* @author panjuan
*/
public final class EncryptPredicateToken extends SQLToken implements
Substitutable {
-
+
@Getter
private final int stopIndex;
-
+
+private final String tableOwner;
Review comment:
sry.. I forgot to rename this field.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 664](https://coveralls.io/builds/26345375) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.01%**) to **67.484%** --- | Totals | [](https://coveralls.io/builds/26345375) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.01% | | Covered Lines: | 11230 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 665](https://coveralls.io/builds/26345472) * **0** of **0** changed or added relevant lines in **0** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.006%**) to **67.478%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java](https://coveralls.io/builds/26345472/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fkeygen%2FTimeService.java#L33) | 1 | 50.0% | | Totals | [](https://coveralls.io/builds/26345472) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.006% | | Covered Lines: | 11229 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #292: delete benchmark folder
terrymanu merged pull request #292: delete benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index
coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 666](https://coveralls.io/builds/26345511) * **0** of **0** changed or added relevant lines in **0** files are covered. * **38** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.2%**) to **67.256%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java](https://coveralls.io/builds/26345511/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fkeygen%2FTimeService.java#L33) | 1 | 50.0% | | [sharding-orchestration/sharding-orchestration-config/sharding-orchestration-config-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/config/zookeeper/curator/CuratorZookeeperConfigCenter.java](https://coveralls.io/builds/26345511/source?filename=sharding-orchestration%2Fsharding-orchestration-config%2Fsharding-orchestration-config-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fconfig%2Fzookeeper%2Fcurator%2FCuratorZookeeperConfigCenter.java#L69) | 37 | 2.7% | | Totals | [](https://coveralls.io/builds/26345511) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | -0.2% | | Covered Lines: | 11192 | | Relevant Lines: | 16641 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new issue #293: Performance monitoring page supports mobile terminal
wqzwh opened a new issue #293: Performance monitoring page supports mobile terminal URL: https://github.com/apache/incubator-shardingsphere-doc/issues/293 Project source address๏ผhttps://github.com/apache/incubator-shardingsphere-benchmark This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542640668 @terrymanu a test relate to zk failed > https://builds.apache.org/job/shardingsphere-ci/666/testReport/junit/org.apache.shardingsphere.orchestration.config.zookeeper.curator.test/CuratorZookeeperConfigCenterTest/org_apache_shardingsphere_orchestration_config_zookeeper_curator_test_CuratorZookeeperConfigCenterTest/ what's error? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3276: Add table owner for logic encrypt column
coveralls edited a comment on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542538562 ## Pull Request Test Coverage Report for [Build 667](https://coveralls.io/builds/26345969) * **18** of **20** **(90.0%)** changed or added relevant lines in **4** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.03%**) to **67.499%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/EncryptConditionEngine.java](https://coveralls.io/builds/26345969/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2FEncryptConditionEngine.java#L133) | 5 | 7 | 71.43% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/EncryptConditionEngine.java](https://coveralls.io/builds/26345969/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2FEncryptConditionEngine.java#L122) | 1 | 64.15% | | Totals | [](https://coveralls.io/builds/26345969) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.03% | | Covered Lines: | 11240 | | Relevant Lines: | 16652 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542647387 And sharding-proxy dont support "sctl:hint show status" and "sctl:hint show table status;" mysql> sctl:hint show status; ERROR 11001 (S1100): 1Could not support sctl type [sctl:hint show status]. mysql> sctl:hint show table status; ERROR 11001 (S1100): 1Could not support sctl type [sctl:hint show table status]. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node
TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu why close this issue? 4.0.0.RC2 still has select for update issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3024: proxy-4.0.0-RC2 process blob data error
yanickxia commented on issue #3024: proxy-4.0.0-RC2 process blob data error
URL:
https://github.com/apache/incubator-shardingsphere/issues/3024#issuecomment-542659474
@xriqyu i try 4 different way to reappear it , but without success.
RAW - JDBC Direct to Mysql
RAW - JDBC By Proxy to Mysql
Mybatis Direct to Mysql
Mybatis By Proxy to Mysql
this is my mybatis xml
```xml
http://mybatis.org/dtd/mybatis-3-mapper.dtd";>
INSERT INTO data_record (uuid, `type`, byteData) VALUES
(#{uuid,jdbcType=VARCHAR}, #{type,jdbcType=INTEGER}, #{byteData,
jdbcType=BLOB});
SELECT * FROM data_record where uuid = #{uuid};
```
can you see any different? or give me your demo project. thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node
TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu why close this issue? 4.0.0.RC2 still has select for update issue  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node
TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu Any progress on this issue? 4.0.0.RC2 still has select for update issue  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node
TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542663211 or could you pls advise which java files should be focused on to help to fix this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
xiyelife opened a new pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295 Fixes #ISSUSE_ID. Changes proposed in this pull request: - fixed #3234 for more than 2 cipher columns - add the encrypted test case for more than four cipher coloumns This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #3296: Enhancement about the benchmark site
tuohai666 opened a new issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296 Our benchmark site is available right now: https://shardingsphere.apache.org/benchmark/ Great progress has been made in presentation than the previous one. We have reviewed the site and found several issues need to be resolved: For text: - [ ] All **mysql** change to **MySQL**. - [ ] Modules can be **sharding-jdbc/sharding-proxy** while can not be **sharding/sharding proxy/shardingproxy/sharding_proxy/sharding jdbc/shardingjdbc/sharding_jdbc**. - [ ] Explicit point out this(https://shardingsphere.apache.org/benchmark/#/mysql-vs-sharding) is a **loss test**. - [ ] There's no **VS** statement in: https://shardingsphere.apache.org/benchmark/#/sharding-proxy-master-slave https://shardingsphere.apache.org/benchmark/#/sharding-proxy-master-slave-sharding https://shardingsphere.apache.org/benchmark/#/sharding-proxy-single-database-single-table Compared with: https://shardingsphere.apache.org/benchmark/#/shardingjdbc-vs-shardingproxy-encrypt https://shardingsphere.apache.org/benchmark/#/shardingjdbc-vs-shardingproxy-sharding-encrypt Please find a way to describe who vs who clearly. For data: - [ ] The general order of the TPS in a compared performance is: MySQL > sharding-jdbc > sharding-proxy. But we can find several exceptions like the UPDATE case in https://shardingsphere.apache.org/benchmark/#/sharding-proxy-master-slave-sharding. I this case sharding-proxy > sharding-jdbc. We need to check the test environment and find the root cause. Of course, it does not meen there's no bugs in sharding-jdbc or sharding-proxy. - [ ] For the case SELECT in https://shardingsphere.apache.org/benchmark/#/mysql-vs-sharding, the TPS of sharding-proxy is much lower than MySQL. We need to find out whether the case is reasonable or not. Or the performance of sharding-proxy need to be improved. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
coveralls commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#issuecomment-542683827 ## Pull Request Test Coverage Report for [Build 668](https://coveralls.io/builds/26348098) * **27** of **28** **(96.43%)** changed or added relevant lines in **5** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.004%**) to **67.488%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptInsertValueParameterRewriter.java](https://coveralls.io/builds/26348098/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Fparameter%2Fimpl%2FEncryptInsertValueParameterRewriter.java#L65) | 8 | 9 | 88.89% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/parameter/builder/impl/StandardParameterBuilder.java](https://coveralls.io/builds/26348098/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Fparameter%2Fbuilder%2Fimpl%2FStandardParameterBuilder.java#L75) | 1 | 94.12% | | Totals | [](https://coveralls.io/builds/26348098) | | :-- | --: | | Change from base [Build 479](https://coveralls.io/builds/26344829): | 0.004% | | Covered Lines: | 11236 | | Relevant Lines: | 16649 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beiwangnull opened a new issue #3297: select for update syntax route to slave datasource
beiwangnull opened a new issue #3297: select for update syntax route to slave datasource URL: https://github.com/apache/incubator-shardingsphere/issues/3297 ## Bug Report Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere did you use? 4.0.0-RC2 ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-JDBC ### Actual behavior https://user-images.githubusercontent.com/3151306/66921270-63e0ab00-f057-11e9-8233-ce8dd2af6693.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3296: Enhancement about the benchmark site
terrymanu commented on issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296#issuecomment-542693801 Maybe we should move this issue to https://github.com/apache/incubator-shardingsphere-benchmark This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3276: Add table owner for logic encrypt column
terrymanu merged pull request #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3262: Table owner is lost for logic encrypt column
terrymanu closed issue #3262: Table owner is lost for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/issues/3262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335470036 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + + Review comment: What's mean of equation values? maybe values function is better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] gaoguanghai commented on issue #3154: Data masking: the name of logicColumn is case sensitive
gaoguanghai commented on issue #3154: Data masking: the name of logicColumn is case sensitive URL: https://github.com/apache/incubator-shardingsphere/issues/3154#issuecomment-542714247 Hi @skyoxZ ,I'm not sure what problems you encountered, could you describe them in more detail? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335496237 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + + Review comment: equation means "a = v1+v2". v1 or v2 may be a value or a function . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sluk3r commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor
sluk3r commented on a change in pull request #3281: #3138 improved coverage for
sharding core preprocessor
URL:
https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335497199
##
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/engine/ProjectionsContextEngineTest.java
##
@@ -59,4 +62,40 @@ public void
assertProjectionsContextCreatedProperlyWhenSelectItemPresent() {
ProjectionsContext projectionsContext = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), mock(OrderByContext.class));
assertNotNull(projectionsContext);
}
+
+@Test
+public void createProjectionsContextWhenOrderByContextOrderItemsPresent() {
+SelectStatement selectStatement = mock(SelectStatement.class);
+SelectItemsSegment selectItemsSegment = mock(SelectItemsSegment.class);
+when(selectStatement.getSelectItems()).thenReturn(selectItemsSegment);
+ShorthandSelectItemSegment shorthandSelectItemSegment = new
ShorthandSelectItemSegment(0, 10, "text");
+TableSegment owner = new TableSegment(0, 10, "name");
+owner.setOwner(new SchemaSegment(0, 10, "name"));
+shorthandSelectItemSegment.setOwner(owner);
+
when(selectItemsSegment.getSelectItems()).thenReturn(Collections.singleton(shorthandSelectItemSegment));
+OrderByContext orderByContext = mock(OrderByContext.class);
+OrderByItem orderByItem = mock(OrderByItem.class);
+
when(orderByItem.getSegment()).thenReturn(mock(IndexOrderByItemSegment.class));
+
when(orderByContext.getItems()).thenReturn(Collections.singletonList(orderByItem));
+ProjectionsContext actual = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), orderByContext);
+assertNotNull(actual);
+}
+
+@Test
+public void
assertProjectionsContextCreatedProperlyWhenOrderByItemSegmentNotInstanceOfIndexOrderByItemSegment()
{
Review comment:
the method name of
assertProjectionsContextCreatedProperlyWhenOrderByItemSegmentNotInstanceOfIndexOrderByItemSegment
express the meaning: assert that ProjectionsContext instance is created when
OrderByItemSegment is not instance of InstanceOfIndexOrderByItemSegment,
corresponding to the following switch in the format of negation:
So, I think the method name of
assertProjectionsContextCreatedProperlyWhenOrderByItemSegmentNotInstanceOfIndexOrderByItemSegment
could not be changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335497672 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml ## @@ -48,4 +48,7 @@ + + + Review comment: I 'll fix it tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3298: Add sharding + encrypt test engine
terrymanu opened a new pull request #3298: Add sharding + encrypt test engine URL: https://github.com/apache/incubator-shardingsphere/pull/3298 For #1548. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor
terrymanu commented on a change in pull request #3281: #3138 improved coverage
for sharding core preprocessor
URL:
https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335544976
##
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/engine/ProjectionsContextEngineTest.java
##
@@ -59,4 +62,40 @@ public void
assertProjectionsContextCreatedProperlyWhenSelectItemPresent() {
ProjectionsContext projectionsContext = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), mock(OrderByContext.class));
assertNotNull(projectionsContext);
}
+
+@Test
+public void createProjectionsContextWhenOrderByContextOrderItemsPresent() {
+SelectStatement selectStatement = mock(SelectStatement.class);
+SelectItemsSegment selectItemsSegment = mock(SelectItemsSegment.class);
+when(selectStatement.getSelectItems()).thenReturn(selectItemsSegment);
+ShorthandSelectItemSegment shorthandSelectItemSegment = new
ShorthandSelectItemSegment(0, 10, "text");
+TableSegment owner = new TableSegment(0, 10, "name");
+owner.setOwner(new SchemaSegment(0, 10, "name"));
+shorthandSelectItemSegment.setOwner(owner);
+
when(selectItemsSegment.getSelectItems()).thenReturn(Collections.singleton(shorthandSelectItemSegment));
+OrderByContext orderByContext = mock(OrderByContext.class);
+OrderByItem orderByItem = mock(OrderByItem.class);
+
when(orderByItem.getSegment()).thenReturn(mock(IndexOrderByItemSegment.class));
+
when(orderByContext.getItems()).thenReturn(Collections.singletonList(orderByItem));
+ProjectionsContext actual = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), orderByContext);
+assertNotNull(actual);
+}
+
+@Test
+public void
assertProjectionsContextCreatedProperlyWhenOrderByItemSegmentNotInstanceOfIndexOrderByItemSegment()
{
Review comment:
I don't think so. In the unit test conduct, the testing method's prefix
should name as the to be tested method which to let user know what is actual
testing method of this case.
The proposal of the test case is that test the method
`createProjectionsContext`, so the test case name should be start with
`assertCreateProjectionsContext`.
`assertCreateProjectionsContextWithoutIndexOrderByItemSegment` maybe a
better name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] qixiaobo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node
qixiaobo commented on issue #1496: Read write splitter for `Select ... for
update` should route to master data node
URL:
https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542760093
```java
public final class MasterSlaveRouter {
private final MasterSlaveRule masterSlaveRule;
private final SQLParseEngine parseEngine;
private final boolean showSQL;
/**
* Route Master slave.
*
* @param sql SQL
* @param useCache use cache or not
* @return data source names
*/
// TODO for multiple masters may return more than one data source
public Collection route(final String sql, final boolean
useCache) {
Collection result = route(parseEngine.parse(sql, useCache));
if (showSQL) {
SQLLogger.logSQL(sql, result);
}
return result;
}
private Collection route(final SQLStatement sqlStatement) {
if (isMasterRoute(sqlStatement)) {
MasterVisitedManager.setMasterVisited();
return
Collections.singletonList(masterSlaveRule.getMasterDataSourceName());
}
return
Collections.singletonList(masterSlaveRule.getLoadBalanceAlgorithm().getDataSource(
masterSlaveRule.getName(),
masterSlaveRule.getMasterDataSourceName(), new
ArrayList<>(masterSlaveRule.getSlaveDataSourceNames(;
}
private boolean isMasterRoute(final SQLStatement sqlStatement) {
return !(sqlStatement instanceof SelectStatement) ||
MasterVisitedManager.isMasterVisited() || HintManager.isMasterRouteOnly();
}
```
You should use hintManager
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335561212 ## File path: sharding-core/sharding-core-rewrite/src/test/resources/encrypt/insert.xml ## @@ -1,59 +1,79 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + Review comment: I forget add the test cases for insert without columns, I will add it soon in other pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
terrymanu commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335561157
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptInsertValueParameterRewriter.java
##
@@ -57,10 +60,14 @@ public void rewrite(final ParameterBuilder
parameterBuilder, final SQLStatementC
if (!encryptTable.isPresent()) {
return;
}
-for (String each : encryptTable.get().getLogicColumns()) {
-Optional shardingEncryptor =
encryptRule.findShardingEncryptor(tableName, each);
+Optional insertColumnsSegment =
sqlStatementContext.getSqlStatement().findSQLSegment(InsertColumnsSegment.class);
+if (!insertColumnsSegment.isPresent()) {
+return;
+}
+for (ColumnSegment each : insertColumnsSegment.get().getColumns()) {
Review comment:
How to deal insert SQL without columns, such as: `INSERT INTO tbl VALUES(?,
?, ?)`
If no columns, the `insertColumnsSegment.get().getColumns()` will return a
empty list, and may cause failure.
I forget add the test cases for insert without columns, I will add it soon
in other pull request.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
terrymanu commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335554538
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptAssignmentParameterRewriter.java
##
@@ -78,22 +81,24 @@ private SetAssignmentsSegment
getSetAssignmentsSegment(final SQLStatement sqlSta
return ((UpdateStatement) sqlStatement).getSetAssignment();
}
-private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters) {
+private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters,
+ final Collection
assistedQueryColumns, final int count) {
Review comment:
What is the proposal of parameter `count`?
I just try to understander is that the `count` means count of `Assignment`
(`xxx = ?`).
How about if one `Assignment` have multiple parameters, such as `xxx = ? + ?`
Or the `Assignment` do not has any parameters, such as `xxx = 100`
Any suggestion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3298: Add sharding + encrypt test engine
coveralls commented on issue #3298: Add sharding + encrypt test engine URL: https://github.com/apache/incubator-shardingsphere/pull/3298#issuecomment-542769082 ## Pull Request Test Coverage Report for [Build 673](https://coveralls.io/builds/26352332) * **7** of **11** **(63.64%)** changed or added relevant lines in **6** files are covered. * **1** unchanged line in **1** file lost coverage. * Overall coverage increased (+**0.04%**) to **67.543%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/26352332/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L85) | 0 | 2 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/26352332/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L85) | 0 | 2 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/26352332/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L94) | 1 | 98.33% | | Totals | [](https://coveralls.io/builds/26352332) | | :-- | --: | | Change from base [Build 480](https://coveralls.io/builds/26349395): | 0.04% | | Covered Lines: | 11252 | | Relevant Lines: | 16659 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wu-sheng merged pull request #3298: Add sharding + encrypt test engine
wu-sheng merged pull request #3298: Add sharding + encrypt test engine URL: https://github.com/apache/incubator-shardingsphere/pull/3298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3290: fix g4 for assignmentValueNode get error by index
terrymanu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542772833 > @terrymanu a test relate to zk failed > > > https://builds.apache.org/job/shardingsphere-ci/666/testReport/junit/org.apache.shardingsphere.orchestration.config.zookeeper.curator.test/CuratorZookeeperConfigCenterTest/org_apache_shardingsphere_orchestration_config_zookeeper_curator_test_CuratorZookeeperConfigCenterTest/ > > what's error? I will check it later, I guess it is caused by ShardingSphere's build job run in same machine concurrency, every job need to create same port for zookeeper testing. Any way, this pull request is safe, I will merge it soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3290: fix g4 for assignmentValueNode get error by index
terrymanu merged pull request #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3279: Shardingjdbc execute update exception
terrymanu closed issue #3279: Shardingjdbc execute update exception URL: https://github.com/apache/incubator-shardingsphere/issues/3279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index
terrymanu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542772833 > @terrymanu a test relate to zk failed > > > https://builds.apache.org/job/shardingsphere-ci/666/testReport/junit/org.apache.shardingsphere.orchestration.config.zookeeper.curator.test/CuratorZookeeperConfigCenterTest/org_apache_shardingsphere_orchestration_config_zookeeper_curator_test_CuratorZookeeperConfigCenterTest/ > > what's error? I will check it later, I guess it caused by ShardingSphere's build job run in same machine concurrency, every job need to create same port for zookeeper testing. Any way, this pull request is safe, I will merge it soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3284: Fix assignmentValueNode get error index
terrymanu closed pull request #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3284: Fix assignmentValueNode get error index
terrymanu commented on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542774932 Fixed by #3290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3299: Finish parameterized test engine and test cases
terrymanu opened a new pull request #3299: Finish parameterized test engine and test cases URL: https://github.com/apache/incubator-shardingsphere/pull/3299 Fixes #1548. Changes proposed in this pull request: - Clean useless files - Consist sharding & encrypt test cases's table structure - Add insert without columns' test cases This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module.
terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module. URL: https://github.com/apache/incubator-shardingsphere/issues/1548#issuecomment-540567854 After rewrite module refactor already finished, we can redefine tasks for rewrite test module. - [x] Use yaml to setup encrypt rewrite engine - [x] Use parse engine to setup SQLStatementContext - [x] Unify sharding and encrypt's configuration of table names and column names - [x] Use Parametermized test and XML to setup encrypt rewrite test engine - [ ] Use Parametermized test and XML to setup sharding rewrite test engine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module.
terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module. URL: https://github.com/apache/incubator-shardingsphere/issues/1548#issuecomment-540567854 After rewrite module refactor already finished, we can redefine tasks for rewrite test module. - [x] Use yaml to setup encrypt rewrite engine - [x] Use parse engine to setup SQLStatementContext - [x] Unify sharding and encrypt's configuration of table names and column names - [x] Use Parametermized test and XML to setup encrypt rewrite test engine - [x] Use Parametermized test and XML to setup sharding rewrite test engine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module.
terrymanu edited a comment on issue #1548: Parametermized tests for Rewrite module. URL: https://github.com/apache/incubator-shardingsphere/issues/1548#issuecomment-540567854 After rewrite module refactor already finished, we can redefine tasks for rewrite test module. - [x] Use yaml to setup encrypt rewrite engine - [x] Use parse engine to setup SQLStatementContext - [x] Unify sharding and encrypt's configuration of table names and column names - [x] Use Parametermized test and XML to setup encrypt rewrite test engine - [x] Use Parametermized test and XML to setup sharding rewrite test engine - [x] Use Parametermized test and XML to setup mix for shardingย + encrypt rewrite test engine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
terrymanu commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#issuecomment-542805107 I have add test cases of insert without columns in #3299, please run your pr again to verify. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3299: Finish parameterized test engine and test cases
coveralls commented on issue #3299: Finish parameterized test engine and test cases URL: https://github.com/apache/incubator-shardingsphere/pull/3299#issuecomment-542818930 ## Pull Request Test Coverage Report for [Build 674](https://coveralls.io/builds/26354836) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.2%**) to **67.717%** --- | Totals | [](https://coveralls.io/builds/26354836) | | :-- | --: | | Change from base [Build 482](https://coveralls.io/builds/26353539): | 0.2% | | Covered Lines: | 11281 | | Relevant Lines: | 16659 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sluk3r commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor
sluk3r commented on a change in pull request #3281: #3138 improved coverage for
sharding core preprocessor
URL:
https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335741580
##
File path:
sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/engine/ProjectionsContextEngineTest.java
##
@@ -59,4 +62,40 @@ public void
assertProjectionsContextCreatedProperlyWhenSelectItemPresent() {
ProjectionsContext projectionsContext = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), mock(OrderByContext.class));
assertNotNull(projectionsContext);
}
+
+@Test
+public void createProjectionsContextWhenOrderByContextOrderItemsPresent() {
+SelectStatement selectStatement = mock(SelectStatement.class);
+SelectItemsSegment selectItemsSegment = mock(SelectItemsSegment.class);
+when(selectStatement.getSelectItems()).thenReturn(selectItemsSegment);
+ShorthandSelectItemSegment shorthandSelectItemSegment = new
ShorthandSelectItemSegment(0, 10, "text");
+TableSegment owner = new TableSegment(0, 10, "name");
+owner.setOwner(new SchemaSegment(0, 10, "name"));
+shorthandSelectItemSegment.setOwner(owner);
+
when(selectItemsSegment.getSelectItems()).thenReturn(Collections.singleton(shorthandSelectItemSegment));
+OrderByContext orderByContext = mock(OrderByContext.class);
+OrderByItem orderByItem = mock(OrderByItem.class);
+
when(orderByItem.getSegment()).thenReturn(mock(IndexOrderByItemSegment.class));
+
when(orderByContext.getItems()).thenReturn(Collections.singletonList(orderByItem));
+ProjectionsContext actual = new
ProjectionsContextEngine(null).createProjectionsContext(null, selectStatement,
mock(GroupByContext.class), orderByContext);
+assertNotNull(actual);
+}
+
+@Test
+public void
assertProjectionsContextCreatedProperlyWhenOrderByItemSegmentNotInstanceOfIndexOrderByItemSegment()
{
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3299: Finish parameterized test engine and test cases
terrymanu merged pull request #3299: Finish parameterized test engine and test cases URL: https://github.com/apache/incubator-shardingsphere/pull/3299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haetao commented on issue #3292: add SQL test case to moudle sql-test and parse-test
haetao commented on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542955350 Adjust "equation" to "function". Function is better than Equation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Myshiner commented on issue #2925: Sharding-proxy v4.0.0-RC2 can't config multi-users
Myshiner commented on issue #2925: Sharding-proxy v4.0.0-RC2 can't config multi-users URL: https://github.com/apache/incubator-shardingsphere/issues/2925#issuecomment-542961487 Yesterday I run with dev branch and multi-user didn't work if run with zk, but it's ok without zk config. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanickxia opened a new pull request #3284: Fix assignmentValueNode get error index
yanickxia opened a new pull request #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284 Fixes #3279 Changes proposed in this pull request: - Fix get error index for nest Assignment Segment Case 1๏ผ ```sql update OTS_ORDER set UPDATE_DATE = now() where ID = 1; ``` then assignmentNode child size 3, a -> CloumName; b -> = ; c -> now(), should get index 2 Case 2: ```sql update OTS_ORDER set UPDATE_DATE = (now()+1) where ID = 1; update OTS_ORDER set UPDATE_DATE = (now()) where ID = 1; ``` then assignmentNode child size 5, a -> CloumName; b -> = ; c -> (; d-> now()+1; e -> ), should get index 3 --- This change isโ[https://reviewable.io/review_button.svg"; height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/apache/incubator-shardingsphere/3284) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 677](https://coveralls.io/builds/26364395) * **0** of **0** changed or added relevant lines in **0** files are covered. * **66** unchanged lines in **9** files lost coverage. * Overall coverage increased (+**0.2%**) to **67.717%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/EncryptCondition.java](https://coveralls.io/builds/26364395/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2FEncryptCondition.java#L104) | 1 | 93.33% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/generator/impl/EncryptAssignmentTokenGenerator.java](https://coveralls.io/builds/26364395/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Ftoken%2Fgenerator%2Fimpl%2FEncryptAssignmentTokenGenerator.java#L94) | 1 | 98.33% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/token/pojo/EncryptPredicateToken.java](https://coveralls.io/builds/26364395/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2Ftoken%2Fpojo%2FEncryptPredicateToken.java#L69) | 2 | 93.1% | | [sharding-core/sharding-core-entry/src/main/java/org/apache/shardingsphere/core/BaseShardingEngine.java](https://coveralls.io/builds/26364395/source?filename=sharding-core%2Fsharding-core-entry%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2FBaseShardingEngine.java#L132) | 5 | 70.37% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/26364395/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L92) | 6 | 5.41% | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/26364395/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L92) | 7 | 5.0% | | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/EncryptConditionEngine.java](https://coveralls.io/builds/26364395/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frewrite%2Ffeature%2Fencrypt%2FEncryptConditionEngine.java#L69) | 10 | 64.15% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/EncryptPreparedStatement.java](https://coveralls.io/builds/26364395/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FEncryptPreparedStatement.java#L167) | 11 | 75.0% | | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/EncryptStatement.java](https://coveralls.io/builds/26364395/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FEncryptStatement.java#L108) | 23 | 56.96% | | Totals | [](https://coveralls.io/builds/26364395) | | :-- | --: | | Change from base [Build 476](https://coveralls.io/builds/26339072): | 0.2% | | Covered Lines: | 11281 | | Relevant Lines: | 16659 | --- # ๐ - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3276: Add table owner for logic encrypt column
tristaZero commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542967941 @gufengwyx8 Hi, good job. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu removed a comment on issue #3284: Fix assignmentValueNode get error index
terrymanu removed a comment on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542774932 Fixed by #3290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3284: Fix assignmentValueNode get error index
terrymanu commented on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542968619 Fixed with #3290 together This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
xiyelife commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335787166
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptAssignmentParameterRewriter.java
##
@@ -78,22 +81,24 @@ private SetAssignmentsSegment
getSetAssignmentsSegment(final SQLStatement sqlSta
return ((UpdateStatement) sqlStatement).getSetAssignment();
}
-private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters) {
+private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters,
+ final Collection
assistedQueryColumns, final int count) {
Review comment:
Rewrite logic according to Assignment is:
original SQL: insert table set a = ?, b = ?, c = ? value (?, ?, ?)
1.replaced original column by the cipher column:
**insert table set a_enc = ?, b_enc = ?, c_enc = ? value (?, ?, ?)**
2.now set the first original column a after a_enc,
the final a's paramterIndex = a'orignalParameterIndex(0) + count(0) + 1= 1
**insert table set a_enc = ?, a= ?, b_enc = ?, c_enc = ? value (?, ?, ?,
?)**
3.now set the second original column b after b_enc,
the fianl b's parameterIndex = b'orignalParameterIndex(1) + count(1) + 1= 3
**insert table set a_enc = ?, a= ?, b_enc = ?, b = ?, c_enc = ? value (?,
?, ?, ?, ?)**
3.now set the third original column c after c_enc,
the final c's parameterIndex = c'orignalParameterIndex(2) + count(2) + 1= 5
**insert table set a_enc = ?, a= ?, b_enc = ?, b = ?, c_enc = ?,c = ? value
(?, ?, ?, ?, ?, ?)**
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
xiyelife commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335787166
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptAssignmentParameterRewriter.java
##
@@ -78,22 +81,24 @@ private SetAssignmentsSegment
getSetAssignmentsSegment(final SQLStatement sqlSta
return ((UpdateStatement) sqlStatement).getSetAssignment();
}
-private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters) {
+private void encryptParameters(final StandardParameterBuilder
parameterBuilder, final String tableName, final AssignmentSegment
assignmentSegment, final List parameters,
+ final Collection
assistedQueryColumns, final int count) {
Review comment:
Rewrite logic according to Assignment is:
original SQL: insert table set a = ?, b = ?, c = ? value (?, ?, ?)
1.replaced original column by the cipher column:
**insert table set a_enc = ?, b_enc = ?, c_enc = ? value (?, ?, ?)**
2.now set the first original column a after a_enc,
the final a's paramterIndex = a'orignalParameterIndex(0) + count(0) + 1= 1
**insert table set a_enc = ?, a= ?, b_enc = ?, c_enc = ? value (?, ?, ?,
?)**
3.now set the second original column b after b_enc,
the fianl b's parameterIndex = b'orignalParameterIndex(1) + count(1) + 1= 3
**insert table set a_enc = ?, a= ?, b_enc = ?, b = ?, c_enc = ? value (?,
?, ?, ?, ?)**
3.now set the third original column c after c_enc,
the final c's parameterIndex = c'orignalParameterIndex(2) + count(2) + 1= 5
**insert table set a_enc = ?, a= ?, b_enc = ?, b = ?, c_enc = ?,c = ? value
(?, ?, ?, ?, ?, ?)**
if there is no **count**, the overwritten parameter is out of order.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
xiyelife commented on a change in pull request #3295: fixed for #3234 and add
the encrypted test case for more than four cipher coloumns
URL:
https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335788763
##
File path:
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/feature/encrypt/parameter/impl/EncryptInsertValueParameterRewriter.java
##
@@ -57,10 +60,14 @@ public void rewrite(final ParameterBuilder
parameterBuilder, final SQLStatementC
if (!encryptTable.isPresent()) {
return;
}
-for (String each : encryptTable.get().getLogicColumns()) {
-Optional shardingEncryptor =
encryptRule.findShardingEncryptor(tableName, each);
+Optional insertColumnsSegment =
sqlStatementContext.getSqlStatement().findSQLSegment(InsertColumnsSegment.class);
+if (!insertColumnsSegment.isPresent()) {
+return;
+}
+for (ColumnSegment each : insertColumnsSegment.get().getColumns()) {
Review comment:
Yes, I also forget add the test cases for insert without columnsใ
my purpose is:
in order to use the original order in SQL to rerwite cipher SQL, rather than
using the column order in the configured encryption rules, otherwise it will
also cause the parameters to be disordered.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns
xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335789061 ## File path: sharding-core/sharding-core-rewrite/src/test/resources/encrypt/insert.xml ## @@ -1,59 +1,79 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + Review comment: ok, I'll run my pr again to verify. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] beckhampu closed issue #280: Add document for Sharding-UI
beckhampu closed issue #280: Add document for Sharding-UI URL: https://github.com/apache/incubator-shardingsphere-doc/issues/280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] childewuque opened a new issue #3300: namespace(xml), SNOWFLAKE, we can't use random?
childewuque opened a new issue #3300: namespace(xml),SNOWFLAKE,we can't use
random?
URL: https://github.com/apache/incubator-shardingsphere/issues/3300
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub
issues](https://github.com/apache/incubator-shardingsphere/issues).
- Read documentation: [ShardingSphere
Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more
details.
If no response **more than 7 days** and we cannot reproduce it on current
information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
4.0.0-RC2
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
### Expected behavior
Invalid bean definition with name 'properties' defined in null: Could not
resolve placeholder 'random.int(1000)'
### Actual behavior
${random.int(1000)}
### Reason analyze (If you can)
format error?
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3296: Enhancement about the benchmark site
tuohai666 commented on issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296#issuecomment-542982233 Yes, you are right. The issues module for incubator-shardingsphere-benchmark is not available for now, I have asked INFRA to enable it: https://issues.apache.org/jira/browse/INFRA-19288. I'll transport this issue to benchmark repo as soon as INFRA-19288 is fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
