[Okular-devel] [okular] [Bug 325650] New: reading direction Right to Left

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=325650

Bug ID: 325650
   Summary: reading direction Right to Left
Classification: Unclassified
   Product: okular
   Version: 0.17.1
  Platform: unspecified
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com

One feature I liked in Adobe Reader is the control over reading direction from
Left to Right or Right to Left. I hope it will implemented in Okular one day.
Please see the attached image for more understanding. 

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=325650

--- Comment #3 from Fahad Al-Saidi fahad.alsa...@gmail.com ---
This option gives the control over the order of pages when the view mode is
facing pages (Center First page). I have attached two screen-shots one from
adobe reader after enabling Reading direction Right to Left and the other from
okular the current behavior. I tried to number the page in red to see what is
changes.

This feature is useful with RTL language and you want to read tow page in the
same view or you want to preview you book before sending it to the printer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=325650

--- Comment #4 from Fahad Al-Saidi fahad.alsa...@gmail.com ---
Created attachment 82675
  -- https://bugs.kde.org/attachment.cgi?id=82675action=edit
Adobe reader- reading direction options (Right to Left)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=325650

--- Comment #5 from Fahad Al-Saidi fahad.alsa...@gmail.com ---
Created attachment 82676
  -- https://bugs.kde.org/attachment.cgi?id=82676action=edit
Okular- the current reading direction (left to right)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353299] Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353299

--- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Created attachment 94769
  --> https://bugs.kde.org/attachment.cgi?id=94769=edit
an arabic odt file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353299] New: Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353299

Bug ID: 353299
   Summary: Text search does not work in Arabic
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: ODT backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com

Open any ODT files that contain arabic text then try to search any arabic word.

Reproducible: Always

Steps to Reproduce:
1. Open attach file
2. open search dialogue by crtl+f
3. type نبذة

Actual Results:  
the text not found

Expected Results:  
the word "نبذة " is the first word in the doc

I think this bug affect Hebrew.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/
---

Review request for Okular.


Bugs: 207748
http://bugs.kde.org/show_bug.cgi?id=207748


Repository: okular


Description
---

Since arabic search does not work properly in all but pdf  backends, this is a 
quick attempt to fix this problem. I assumed that text in okular document is in 
the logical order[ it is a bug by itself]. So by mirroring the search text, the 
search function works again. 

The limitation:
- you can not search arabic and english text together.

Future work:
we need to check that text generated by poppler is placed in Visual order, so 
when we copy it and paste it in text editor is still readable.


Diffs
-

  ui/searchlineedit.cpp c736759 

Diff: https://git.reviewboard.kde.org/r/125442/diff/


Testing
---

Test in Arabic & Hebrew pdfs and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/
---

(Updated Sept. 29, 2015, 5:42 a.m.)


Review request for Okular.


Bugs: 207748
http://bugs.kde.org/show_bug.cgi?id=207748


Repository: okular


Description
---

Since arabic search does not work properly in all but pdf  backends, this is a 
quick attempt to fix this problem. I assumed that text in okular document is in 
the logical order[ it is a bug by itself]. So by mirroring the search text, the 
search function works again. 

The limitation:
- you can not search arabic and english text together.

Future work:
we need to check that text generated by poppler is placed in Visual order, so 
when we copy it and paste it in text editor is still readable.


Diffs
-

  ui/searchlineedit.cpp c736759 

Diff: https://git.reviewboard.kde.org/r/125442/diff/


Testing (updated)
---

Tested in Arabic & Hebrew pdfs and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353300] New: Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353300

Bug ID: 353300
   Summary: Text search does not work in Arabic
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: EPub backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com

Open any epub files that contain arabic text then try to search any arabic
word.

Reproducible: Always

Steps to Reproduce:
1. Open attach file 
2. open search dialogue by crtl+f 
3. type كلمة

Actual Results:  
the text not found

Expected Results:  
the word "كلمة" is in the doc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353300] Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353300

--- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Created attachment 94770
  --> https://bugs.kde.org/attachment.cgi?id=94770=edit
an arabic epub file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353302] Txt Backend does not display Arabic text

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353302

--- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Created attachment 94771
  --> https://bugs.kde.org/attachment.cgi?id=94771=edit
an arabic txtfile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353302] New: Txt Backend does not display Arabic text

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353302

Bug ID: 353302
   Summary: Txt Backend does not display Arabic text
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com

Open any Arabic text file ( one is attached ). Okular shows an empty page.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=207748

Fahad Al-Saidi <fahad.alsa...@gmail.com> changed:

   What|Removed |Added

 CC||fahad.alsa...@gmail.com

--- Comment #9 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Here is a quick patch to fix this problem. 
https://git.reviewboard.kde.org/r/125442/

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353301] New: Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353301

Bug ID: 353301
   Summary: Text search does not work in Arabic
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: mobipocket backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com

Open any mobi files that contain arabic text then try to search any arabic
word.

Reproducible: Always

Steps to Reproduce:
1. Open attach file
2. open search dialogue by crtl+f 
3. type كلمة

Actual Results:  
the text not found

Expected Results:  
the word "كلمة" is in the doc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 353301] Text search does not work in Arabic

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=353301

--- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
the file is larger then 4 MB, so I couldn't attach it. However, here is the
link:
http://downloads.hindawi.org/books/19395315.mobi

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 351670] Error opening arabic named PDFs

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=351670

Fahad Al-Saidi <fahad.alsa...@gmail.com> changed:

   What|Removed |Added

 CC||fahad.alsa...@gmail.com

--- Comment #14 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
I think the problem is in your local settings. try to add your country locale,
see this link for more information:
https://wiki.archlinux.org/index.php/Locale

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 325650] reading direction Right to Left

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=325650

--- Comment #13 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---

This patch adds RTL reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.

the patch: https://git.reviewboard.kde.org/r/125397/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

Review request for Okular.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs
-

  conf/dlggeneral.cpp ad389f3 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg 76d7c37 
  conf/preferencesdialog.h dcea37e 
  interfaces/viewerinterface.h 4f27921 
  ui/pageview.cpp 6bff6ac 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > Is this something that one would expect to set manually? Shouldn't it be 
> > detected from the file contents? Or that's just too hard/not optimal?

Sorry for late reply. I didn't get notified when you wrote your comment. It is 
weired from reviewboard. However, setting this option manually is better 
because most of times you want to read pdfs in RTL & LTR lanagues so you don't 
want to be forced in RTL mode when you read LTR pdf.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
---


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92307
---



any feedback?

- Fahad Al-Saidi


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated July 26, 2016, 1:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular and Albert Astals Cid.


Changes
---

Submitted with commit 04908dba2f93842a0008ef1ba8c966621c615f9e by Olivier 
CHURLAUD to branch master.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote:
> > Ship It!

Great.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote:
> > Ship It!
> 
> Fahad Al-Saidi wrote:
> Great.
> 
> Olivier Churlaud wrote:
> Can you ship it Fahad? Or should I in your behalf?

I can if I know :-) I am new here so any informoation will be great.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 20, 2016, 6:29 p.m., Olivier Churlaud wrote:
> > Mostly style correction. Then I think it will be fine. (I'll check again)

Great. All requested changes done. Thanks


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97673
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated July 21, 2016, 5:07 a.m.)


Review request for Okular and Albert Astals Cid.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs (updated)
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Fahad Al-Saidi]

> On July 21, 2016, 9:18 a.m., Olivier Churlaud wrote:
> > Is the "future work" a lot to do? Because if is part of solving your 
> > problem, you should had this to the review.
> 
> Fahad Al-Saidi wrote:
> Well, the bug itself needs to be retested against Poppler >= 0.40 because 
> of this:
> https://bugs.freedesktop.org/show_bug.cgi?id=55977
> 
> Unfortunatly, I am using kde 4 & ubuntu 14.04 and it is diffcult for me 
> to upgrade right now.
> 
> Olivier Churlaud wrote:
> I have a newer poppler, so if you add to the bug (on bugzilla) a file 
> test, with a word to test (because I don't have an hebrew or arabic 
> keyboard), I can test it.
> 
> Fahad Al-Saidi wrote:
> done. please test

well, the current patch will fix the problem though is not the best solution 
IMHO. We need refactoring text layer in okular that okular get text from 
poppler without any modification the same way envice does.I mean by future work 
is another bug relating to RTL in general.
If it fine with you to go ahead with this patch, I will clean it up.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97695
-------


On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> ---
> 
> (Updated Sept. 29, 2015, 5:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
> http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Since arabic search does not work properly in all but pdf  backends, this is 
> a quick attempt to fix this problem. I assumed that text in okular document 
> is in the logical order[ it is a bug by itself]. So by mirroring the search 
> text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so 
> when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -
> 
>   ui/searchlineedit.cpp c736759 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/
> 
> 
> Testing
> ---
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Fahad Al-Saidi]

> On July 21, 2016, 9:18 a.m., Olivier Churlaud wrote:
> > Is the "future work" a lot to do? Because if is part of solving your 
> > problem, you should had this to the review.

Well, the bug itself needs to be retested against Poppler >= 0.40 because of 
this:
https://bugs.freedesktop.org/show_bug.cgi?id=55977

Unfortunatly, I am using kde 4 & ubuntu 14.04 and it is diffcult for me to 
upgrade right now.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97695
---


On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> ---
> 
> (Updated Sept. 29, 2015, 5:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
> http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Since arabic search does not work properly in all but pdf  backends, this is 
> a quick attempt to fix this problem. I assumed that text in okular document 
> is in the logical order[ it is a bug by itself]. So by mirroring the search 
> text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so 
> when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -
> 
>   ui/searchlineedit.cpp c736759 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/
> 
> 
> Testing
> ---
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125442: [okular] fix Arabic & Hebrew search

[Fahad Al-Saidi]

> On July 21, 2016, 9:18 a.m., Olivier Churlaud wrote:
> > Is the "future work" a lot to do? Because if is part of solving your 
> > problem, you should had this to the review.
> 
> Fahad Al-Saidi wrote:
> Well, the bug itself needs to be retested against Poppler >= 0.40 because 
> of this:
> https://bugs.freedesktop.org/show_bug.cgi?id=55977
> 
> Unfortunatly, I am using kde 4 & ubuntu 14.04 and it is diffcult for me 
> to upgrade right now.
> 
> Olivier Churlaud wrote:
> I have a newer poppler, so if you add to the bug (on bugzilla) a file 
> test, with a word to test (because I don't have an hebrew or arabic 
> keyboard), I can test it.

done. please test


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97695
-------


On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> ---
> 
> (Updated Sept. 29, 2015, 5:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
> http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Since arabic search does not work properly in all but pdf  backends, this is 
> a quick attempt to fix this problem. I assumed that text in okular document 
> is in the logical order[ it is a bug by itself]. So by mirroring the search 
> text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so 
> when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -
> 
>   ui/searchlineedit.cpp c736759 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/
> 
> 
> Testing
> ---
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated June 27, 2016, 12:54 p.m.)


Review request for Okular.


Changes
---

update patch per Albert feedback. Thanks Albert.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs (updated)
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #17 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
this bug also effect the copying the RTL text. the copied text is reversed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  In D10455#263014 , @ngraham wrote:
  
  > @fahadalsaidi, are you able to work on those?
  
  
  Sorry, I don't have  knowledge & time to fix the memory leaks. For the other 
question , I've already answered, here is it:
  
  >   The other back-ends have many problem not related to this patch as 
following:
  > 
  > - xps: okular crash when open arabic xps file and if it can open it, it 
renders it in wrong way.
  > - dejuv: searching & copying Arabic text are fine since dejuv back-end has 
it own search function.
  > - odt: there is broken in LTR or RTL. There is no text to search at all.
  > - chm: Although okular can open it but searching is bad for LTR & RTL text, 
it is basically broken.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: okular-devel, chfanzil, ngraham, aacid

[okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #19 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
I think the problem form QT interface for poppler. please see this bug 

https://bugs.freedesktop.org/show_bug.cgi?id=105015

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi created this revision.
fahadalsaidi added a reviewer: Okular.
fahadalsaidi added a project: Okular.
fahadalsaidi requested review of this revision.

REVISION SUMMARY
  Right now all text are sorted  in LTR order in 
TextPagePrivate::correctTextOrder() regardless from where they come. Since 
poppler has fixed it since 0.40, I've just ported reorderTex() from poppler to 
okular and it works. I am not sure what is unicodeTypeL() & unicodeTypeR() mean 
in poppler context so I just use isRightToLeft() instead.
  
  This patch intended to fix the following bugs:
  BUG: 207748
  BUG: 353299
  BUG: 353300
  BUG: 353301
  BUG: 184399

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  core/textpage.cpp

To: fahadalsaidi, #okular
Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #21 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
I proposed another patch to fix this bug, here

https://phabricator.kde.org/D10455

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi added reviewers: aacid, ltoscano.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #20 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
I think I've found where is the problem. It is from
TextPagePrivate::correctTextOrder(), it sorts words & characters to be LTR
using theses compareTinyTextEntityY & compareTinyTextEntityX.

This approach doesn't fit with RTL text.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #5 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
(In reply to Albert Astals Cid from comment #4)
> So you're hitting a qFatal? What is the output of the command? I guess that
> would be a good hint of what your problem is

sorry, which command you mean? if this:
grep KDESRCDIR build/autotests/CMakeFiles/parttest.dir/DependInfo.cmake

the result is:
"KDESRCDIR=\"/home/ita/kde/src/kde/kdegraphics/okular/autotests/\""

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390355] New: crash when open Arabic xps file

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390355

Bug ID: 390355
   Summary: crash when open Arabic xps file
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: XPS backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com
  Target Milestone: ---

Created attachment 110594
  --> https://bugs.kde.org/attachment.cgi?id=110594=edit
first example produced by scribus 5.4dev

Okular crashes when I try to open most of arabic xps files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390355] crash when open Arabic xps file

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390355

--- Comment #1 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Created attachment 110595
  --> https://bugs.kde.org/attachment.cgi?id=110595=edit
second example produced by MS office 2016

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi updated this revision to Diff 27038.
fahadalsaidi edited the summary of this revision.
fahadalsaidi added a comment.


  Well, I was over-optimistic. This patch is related only to  BUG: 207748 & 
BUG:184399. The other back-ends have many problem not related to this patch as 
following:
  
  - xps: okular crash when open arabic xps file and if it can open it, it 
renders it in wrong way.
  - dejuv: searching & copying Arabic text are fine since dejuv back-end has it 
own search function.
  - odt: there is broken in LTR or RTL. There is no text to search at all.
  - chm: Although okular can open it but searching is bad for LTR & RTL text, 
it is basically broken.
  
  @aacid the poppler bug  should be fixed, so anybody using QT interface can 
get the right order for RTL langs.  Okular has its own way to sort words.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10455?vs=26983=27038

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  core/textpage.cpp

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #3 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
sorry, the problem is not from cmake. When I debug it, okular crash when open
the doc, here it the debug:


Thread 3 (Thread 0x7fffdbd71700 (LWP 376)):
#0  0x75af474d in poll () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x70ef438c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#2  0x70ef449c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#3  0x7641b6af in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#4  0x763c3e2a in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#5  0x761ec8f4 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#6  0x7fffefbf5315 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
No symbol table info available.
#7  0x761f1709 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#8  0x757e36ba in start_thread (arg=0x7fffdbd71700) at
pthread_create.c:333
__res = 
pd = 0x7fffdbd71700
now = 
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140736881694464,
4209299068300874597, 0, 140737488347247, 140736881695168, 140737488347432,
-4209220105802558619, -4209311152409226395}, mask_was_saved = 0}}, priv = {pad
= {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call = 
pagesize_m1 = 
sp = 
freesize = 
__PRETTY_FUNCTION__ = "start_thread"
#9  0x75b0041d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 2 (Thread 0x7fffe3764700 (LWP 375)):
#0  0x75af474d in poll () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x7fffec9fec62 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
No symbol table info available.
#2  0x7fffeca008d7 in xcb_wait_for_event () from
/usr/lib/x86_64-linux-gnu/libxcb.so.1
No symbol table info available.
#3  0x7fffe5cbb1f9 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
No symbol table info available.
#4  0x761f1709 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#5  0x757e36ba in start_thread (arg=0x7fffe3764700) at
pthread_create.c:333
__res = 
pd = 0x7fffe3764700
now = 
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140737009567488,
4209299068300874597, 0, 140737488346191, 140737009568192, 140737488346376,
-4209271500991835291, -4209311152409226395}, mask_was_saved = 0}}, priv = {pad
= {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call = 
pagesize_m1 = 
sp = 
freesize = 
__PRETTY_FUNCTION__ = "start_thread"
#6  0x75b0041d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 1 (Thread 0x77f138c0 (LWP 367)):
#0  0x75a2e428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54
resultvar = 0
pid = 367
selftid = 367
#1  0x75a3002a in __GI_abort () at abort.c:89
save_stage = 2
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0},
sa_mask = {__val = {140737323982638, 7608672, 140737329489568, 140737351871088,
3, 7167536, 0, 140737325494784, 140737353169072, 4294967295, 140737353171408,
140737351870832, 70, 0, 3454050420342969856, 280375465082880}}, sa_flags =
327790, sa_restorer = 0x5006e}
sigs = {__val = {32, 0 }}
#2  0x761d9c71 in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#3  0x77ba9bab in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5
No symbol table info available.
#4  
No locals.
#5  0x00841f0f in ?? ()
No symbol table info available.
#6  0x76bac84a in QPagedPaintDevice::pageLayout() const () from
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
No symbol table info available.
#7  0x74310fa1 in QPrinter::orientation() const () from
/usr/lib/x86_64-linux-gnu/libQt5PrintSupport.so.5
No symbol table info available.
#8  0x7fffdb361c97 in ?? () from
/usr/lib/x86_64-linux-gnu/qt5/plugins/okular/generators/okularGenerator_poppler.so
No symbol table info available.
#9  0x778a2f6a in Okular::Document::openDocument (this=0x7fffd8b0,
docFile=..., url=..., _mime=..., password=...) at
/home/ita/kde/src/kde/kdegraphics/okular/core/document.cpp:2488
db = {d = 0x76883570}
mime = {d = {d = 0x6a85c0}}
filedata = {d = 0x764af200 }
isstdin = false
triedMimeFromFileContent = false
offer = {m_m

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #6 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Ok, I found the problem, I have to set 
Set LD_LIBRARY_PATH 
Set QT_PLUGIN_PATH
Set XDG_DATA_DIRS

in qtcreator in order to run & debug the test correctly. Please close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] New: auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

Bug ID: 390357
   Summary: auto tests fails
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com
  Target Milestone: ---

When I try to run void SearchTest::test311232(), it will fail because cmake not
know where to find data folder in autotests. When I put hard path, it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  @aacid  I want to write autotest but there is a bug #390357 in cmake test. I 
will try make autotest smiliar to test311232() but there is a problem, the pdf 
file doesn't load probably and it give me in an empty m_generator. please have 
a look on it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi retitled this revision from "add rtl support to textpage" to "Add 
RTL support for search, copy & paste in pdf".
fahadalsaidi edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi updated this revision to Diff 27043.
fahadalsaidi edited the summary of this revision.
fahadalsaidi added a comment.


  add autotest for searching in Arabic

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10455?vs=27038=27043

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  autotests/data/arabic-search-test.pdf
  autotests/searchtest.cpp
  core/textpage.cpp

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

[okular] [Bug 390356] New: wrong render for arabic xps

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390356

Bug ID: 390356
   Summary: wrong render for arabic xps
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: XPS backend
  Assignee: okular-devel@kde.org
  Reporter: fahad.alsa...@gmail.com
  Target Milestone: ---

Created attachment 110596
  --> https://bugs.kde.org/attachment.cgi?id=110596=edit
arabic xps example

in the attached file, the output is badly broken. There is no basic RTL support
in xps backend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  @aacid  any feedback?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, simgunz, aacid

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi updated this revision to Diff 27517.
fahadalsaidi added a comment.


  - use QTRY_COMPARE

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10455?vs=27043=27517

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  autotests/data/arabic-search-test.pdf
  autotests/searchtest.cpp
  core/textpage.cpp

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  @aacid Thanks for the feedback.
  
  > I'm still unconvinced the text reversion is happening at the proper level.
  
  I really a new to okular's code, so please guide me to the right direction.
  
  > And you have a memory leak in your function as reported by
  
  valgrind shows that the leak happen in:
  
makeWordFromCharacters(QList const&, int, int) 
(textpage.cpp:1209)
  
  which needs to be fix but not in this patch since it is irrelevant to it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  @chfanzil , thanks for testing and sharing your findings. The patch doesn't 
touch search logic , it deals only with inner text layer in okular.
  
  @aacid  sorry to get to you late but Unfortunately I couldn't figure out how 
to fix the leak, my knowledge in C++ & programming is limited. I am just trying 
here. In other hand why not make ouklar deal with poppler directly to search & 
get text, the same way it does with dejuv backend?  I know it is a lot of work 
but Here I am just asking.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: chfanzil, ngraham, michaelweghorn, aacid

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #10 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
This bug needs retest against Poppler >= 0.40 because there of this:
https://bugs.freedesktop.org/show_bug.cgi?id=55977

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #12 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
Created attachment 100228
  --> https://bugs.kde.org/attachment.cgi?id=100228=edit
arabic text

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 207748] LTR languages searches text backwards

[Fahad Al-Saidi via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #13 from Fahad Al-Saidi <fahad.alsa...@gmail.com> ---
you can search using this word: "بسم" in attached arabic text pdf
if you find it, it means it is fixed in upstream otherwise the problem in
okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel