Re: [Oorexx-devel] Building on Windows

2019-02-08 Thread P.O. Jonsson
Regarding the testing I get some errors, see below. The 
WindowsEventLog.testGroup aborts without finishing 

>rexx testOORexx.rex -s -S -f WindowsEventLog.testGroup
aborts at

[TEST_READRECORDS03


C:\Users\po\workspace\ooRexx-windows64-test>rexx testOORexx.rex -s -X 
native_API -x WindowsEventLog.testGroup
Searching for test containers
Executing automated test suite
Executing tests from C:\Users\po\workspace\...\ooRexx\SimpleTests.testGroup
ooTest Framework - Automated Test of the ooRexx Interpreter
C:\Users\po\workspace\ooRexx-windows64-test>rexx testOORexx.rex -s -X 
native_API -x WindowsEventLog.testGroup
Searching for test containers
Executing automated test suite
Executing tests from C:\Users\po\workspace\...\ooRexx\SimpleTests.testGroup


Interpreter:REXX-ooRexx_5.0.0(MT)_64-bit 6.05 8 Feb 2019
OS Name:WindowsNT
SysVersion: Windows 10.0.17134

Tests ran:  22788
Assertions: 377740
Failures:   8
Errors: 1

[failure] [20190208 12:10:00.934000]
  svn:r11626   Change date: 2018-12-16 22:05:44 +0100
  Test:   TEST_PACKAGE_FINDPROGRAM_REXXTRY
  Class:  Package.testGroup
  File:   C:\Users\po\workspace\...\ooRexx\base\class\Package.testGroup
  Line:   774
  Failed: assertNotSame
Expected: [[The NIL object], identityHash="-2460860450929"] \== [[The NIL 
object], identityHash="-2460860450929"]
Actual:   [[The NIL object], identityHash="-2460860450929"]  == [[The NIL 
object], identityHash="-2460860450929"]
Message:  findProgram() cannot locate 'rexxtry.rex'

[failure] [20190208 12:10:32.643000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTALLUSERSSTARTUP
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   443
  Failed: assertTrue
Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:32.674000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTAPPLICATIONDATA
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   482
  Failed: assertTrue
Expected: [1]
    Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:32.909000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTFAVORITES
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   171
  Failed: assertTrue
    Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:33.658000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTLOCALSETTINGSAPPLICATIONDATA
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   523
  Failed: assertTrue
Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:33.69]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTLOCALSETTINGSTEMPORARYINTERNETFILES
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   559
  Failed: assertTrue
Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:33.705000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTMYCOMPUTER
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   324
  Failed: assertTrue
Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[failure] [20190208 12:10:48.358000]
  svn:r11522   Change date: 2018-11-22 01:34:56 +0100
  Test:   TESTSTARTUP
  Class:  SpecialFolders.testgroup
  File:   
C:\Users\po\workspace\...\platform\windows\ole\SpecialFolders.testGroup
  Line:   188
  Failed: assertTrue
Expected: [1]
Actual:   [[0], identityHash="-2460860450865"]

[error] [20190208 12:10:23.729000]
  svn:r11683   Change date: 2019-01-20 20:56:11 +0100
  Test:   TEST_WITH_OUTPUT
  Class:  ADDRESS.testGroup
  File:   C:\Users\po\workspace\...\ooRexx\base\keyword\ADDRESS.testGroup
  Event:  [SYNTAX 98.920] raised unexpectedly.
Unable to open file 
"C:\Users\po\workspace\ooRexx-windows64-test\address-with.tmp" for writing; 
open result was "ERROR:13".
Line:  #  511
   511 *-* address "" "" with output stream ( fileName )
   *-* Compiled method "SEND" with scope "Message".
  1652 *-* .message~new(self, methodName)~send
  1630 *-* self~doTheTest(fName, aTestResult)  -- carry out the testmethod
   552 *-*   test~execute(testResult, verbose)
   552 *-*   test~execute(testResult, verbose)
   110 *-* suite~execute(testResult)
 

Re: [Oorexx-devel] Building on Windows

2019-02-08 Thread P.O. Jonsson

> Am 08.02.2019 um 16:41 schrieb Erich Steinböck :
> 
> Building is slow 
> nmake suports single-core only.  Use jom if you want multi-core builds.  For 
> instructions how, see 
> https://sourceforge.net/p/oorexx/wiki/how-to-build-oorexx/#multi-core-builds 
> 

I tried to follow that but did not succeed :-(  I will give it another try

> 
> Can you confirm that you can run say month.testGroup and get any output?
> If you change the string "rexx.lib" in FileUtils.cls to "rexx.exe" both 
> samples\ tests run fine.  Use
> testoorexx -s -p samples\

I did that but there are multiple issues still. I had uninstalled the latest 
installer version I could get my hands on (gave to many errors since the build 
and the test were out of synch I guess)
but I nevertheless had this symbol defined:
  216 *-* home = value("REXX_HOME", , 'ENVIRONMENT')
   >>>   "C:\Program Files\ooRexx"
   220 *-* if home \== ""
   >>>   "1"
   220 *-*   then
   220 *-* do
   221 *-*   if SysIsFileDirectory(home)
   >>> "0"
   224 *-* end
   225 *-*   end
   239 *-* return dir
   >>>   "The NIL object

I then failed to recognize the build dir, probably because I had missed to 
define the symbol below:

   284 *-* buildRoot = findBuildDir()
In findBuildDir
   117 *-* if .local~hasEntry("OOREXX_BUILD_HOME")
   >>>   "0"
   121 *-* dir = value("OOREXX_BUILD_HOME", , 'ENVIRONMENT');
   >>>   ""
   122 *-* if dir \== ""
   >>>   "0"

   138 *-* srcDrv = value("SRC_DRV", , 'ENVIRONMENT')
   >>>   ""
   139 *-* srcDir = value("SRC_DIR", , 'ENVIRONMENT')
   >>>   ""
   140 *-* if srcDrv \== "", srcDir \== ""
   >>>   "0"
   >>>   "0"
   149 *-* tmp = directory("..\")
   >>>   "C:\Users\po\workspace"
   150 *-* if tmp \== ""
   >>>   "1"
   150 *-*   then
   150 *-* dir = directory()
   >>>   "C:\Users\po\workspace"
   151 *-*   end
   181 *-* j = directory(currentDir)
   >>>   "C:\Users\po\workspace\ooRexx-windows64-test"
   183 *-* return dir
   >>>   "C:\Users\po\workspace"
   >>>   "C:\Users\po\workspace"
   286 *-* if buildRoot \== .nil
   >>>   "1"
   286 *-*   then
   286 *-* do
   287 *-*   sampleDir = buildRoot || "\samples\"
   >>> "C:\Users\po\workspace\samples\"


How do I define OOREXX_BUILD_HOME? Do I need to do anything else in the build 
if I am only to use it for the testing? Any advice most welcome



> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] Building on Windows

2019-02-08 Thread Erich Steinböck
>
> Building is slow
>
nmake suports single-core only.  Use jom if you want multi-core builds.
For instructions how, see
https://sourceforge.net/p/oorexx/wiki/how-to-build-oorexx/#multi-core-builds

Can you confirm that you can run say *month.testGroup* and get any output?
>
If you change the string "rexx.lib" in FileUtils.cls to "rexx.exe" both
samples\ tests run fine.  Use
testoorexx -s -p samples\
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


[Oorexx-devel] Fwd: Samples Testcases and FileUtils amended for macOS

2019-02-08 Thread P.O. Jonsson
Please find attached a diff file that include the amendments I have done to FileUtils.cls. I have added sections that are triggered for Darwin, I have not touched any other sections.Included is also one test case written in a style mimicking the existing test case for month.testGroup. Please let me know if I need to amend anything before I continue converting the remaining sample test cases.
Hälsningar/Regards/Grüsse,P.O. Jonssonoor...@jonases.se


Anfang der weitergeleiteten Nachricht:Von: "P.O. Jonsson" Betreff: Samples TestcasesDatum: 7. Februar 2019 um 19:10:08 MEZAn: "P.O. Jonsson" 

FileUtils.cls
Description: Binary data


arithmeticEvaluation.testGroup
Description: Binary data


FileUtils.diff
Description: Binary data

Hälsningar/Regards/Grüsse,P.O. Jonssonper-olov.jons...@kabelmail.de


___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] RexxUtil test coverage

2019-02-08 Thread Michael Lueck

Greetings Rick,

Rick McGuire wrote:



On Fri, Feb 8, 2019 at 6:23 AM Michael Lueck mailto:mlu...@lueckdatasystems.com>> wrote:


I added some of the RexxUtil functions. So please let me know how I may 
assist in contributing test cases for those functions.


Take a look at what functions we are missing test cases for, or even don't have many cases for in the test suite and pick one. You might want to post a notice here when you start work on tests for a 
functions to avoid someone else duplicating your work.



Sure. I will look over what exists and consider what gaps I am able to fill.




Perhaps if I were to mount the share to our file server to several mount 
points I could get back up to the number of objects that used to cause the 
crash. /mnt/ldslnx01/data, /mnt/ldslnx01/data2,
etc...

Thoughts, or do you think what Mark resolved back then resolved a crash 
trying to build a file tree of too many objects?

I don't really know if Mark resolved this crash or not, but the SysFileTree code has been completely rewritten with my version. One of the goals of the rewrite was to avoid those sorts of crashes, so 
hopefully this problem is dead-and-buried.




Then it sounds like I should do my /mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc... idea and really stress test the new code. I will do that as well on my own / not by creating a test case. At least 
the Linux version will be stress tested this way.


I am thankful,

--
Michael Lueck
Lueck Data Systems
http://www.lueckdatasystems.com/


___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] Building on Windows

2019-02-08 Thread P.O. Jonsson
Ok, my mistake, I assumed that Windows being the most used ooRexx item would be 
automatically updated. I assume that I could copy it from the slave to my own 
machine?

In the meantime I have set up & built myself today ooRexx on Windows, several 
times with various settings. Building is slow and I did not manage to speed it 
up although I run the build on a i7 machine :-(

I have also set up & run (almost) all tests but I get several errors that I do 
not know how to handle. Can I come back to U later on that?

Finally I have now amended fileutil.cls to work also for macOS and I have 
copied over and run one new sample test case. Before I convert the rest (I have 
done test cases for all sample files) I need your feedback on how it was done 
so that I can correct anything once before the bulk of the work. I will provide 
a Diff file in a separate posting.

I tried to run tests for samples also on Windows but none of the samples 
(including the ones already in) work for me on Windows. Can you confirm that 
you can run say month.testGroup and get any output?

Hälsningar/Regards/Grüsse,
P.O. Jonsson
oor...@jonases.se




> Am 08.02.2019 um 12:24 schrieb Erich Steinböck :
> 
> ooRexx-5.0.0-11724.windows.x86_64.exe, but this file is not to be seen at the 
> sourceforge download site.
> 
> Hi P.O.,
> unfortunately there's no connection between the slaves or the build server 
> and the sourceforge files section, except for two slaves, where I managed to 
> set up an automatic upload. All Windows builds that show up on sourceforge 
> have been manually uploaded by me.
> 
> Automatic upload is difficult due the required public key/private key setup 
> for each slave.
> This is why I decided to try to transfer all built installers to the Jenkins 
> master (most slaves do that now using "Archive build artefacts") and the plan 
> is to set up public/private keys so that the master can then upload to 
> sourceforge files.  That would involve a bit of scripting, including some 
> logic to also remove older builds from sourceforge again, but I haven't come 
> round to doing that.
> 
> There may be better solutions for this, but I'm not aware of any.
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] RexxUtil test coverage

2019-02-08 Thread Rick McGuire
On Fri, Feb 8, 2019 at 6:23 AM Michael Lueck 
wrote:

> Greeting Rick,
>
> Rick McGuire wrote:
> > If anybody would like to help out with this effort, contributing tests
> for rexxutil functions would be an excellent way to chip in.
>
> I added some of the RexxUtil functions. So please let me know how I may
> assist in contributing test cases for those functions.
>
> Take a look at what functions we are missing test cases for, or even don't
have many cases for in the test suite and pick one. You might want to post
a notice here when you start work on tests for a functions to avoid someone
else duplicating your work.


> Also, on SysFileTree... you seem to have done much work on that function
> which is one of my personal favorites. A long long time ago now... prior to
> me doing major cleanup on our file server, doing a
> SysFileTree call against the entire collection of files would crash the
> function.
>
> "#973 SysFileTree causes Segmentation fault"
> https://sourceforge.net/p/oorexx/bugs/973/
>
> Seems now that I have looked it back up, Mark did find something wrong...
> not that it was closed as un-reproducible. Unfortunately I had already done
> the major cleanup on our file server, so at that
> time I could not say if what Mark did resolved the problem.
>
> Perhaps if I were to mount the share to our file server to several mount
> points I could get back up to the number of objects that used to cause the
> crash. /mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc...
>
> Thoughts, or do you think what Mark resolved back then resolved a crash
> trying to build a file tree of too many objects?
>
> I don't really know if Mark resolved this crash or not, but the
SysFileTree code has been completely rewritten with my version. One of the
goals of the rewrite was to avoid those sorts of crashes, so hopefully this
problem is dead-and-buried.

Rick

> I am thankful,
>
> --
> Michael Lueck
> Lueck Data Systems
> http://www.lueckdatasystems.com/
>
>
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] Building on Windows

2019-02-08 Thread Erich Steinböck
>
> ooRexx-5.0.0-11724.windows.x86_64.exe, but this file is not to be seen at
> the sourceforge download site.
>

Hi P.O.,
unfortunately there's no connection between the slaves or the build server
and the sourceforge files section, except for two slaves, where I managed
to set up an automatic upload. All Windows builds that show up on
sourceforge have been manually uploaded by me.

Automatic upload is difficult due the required public key/private key setup
for each slave.
This is why I decided to try to transfer all built installers to the
Jenkins master (most slaves do that now using "Archive build artefacts")
and the plan is to set up public/private keys so that the master can then
upload to sourceforge files.  That would involve a bit of scripting,
including some logic to also remove older builds from sourceforge again,
but I haven't come round to doing that.

There may be better solutions for this, but I'm not aware of any.
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel


Re: [Oorexx-devel] RexxUtil test coverage

2019-02-08 Thread Michael Lueck

Greeting Rick,

Rick McGuire wrote:

If anybody would like to help out with this effort, contributing tests for 
rexxutil functions would be an excellent way to chip in.


I added some of the RexxUtil functions. So please let me know how I may assist 
in contributing test cases for those functions.

Also, on SysFileTree... you seem to have done much work on that function which is one of my personal favorites. A long long time ago now... prior to me doing major cleanup on our file server, doing a 
SysFileTree call against the entire collection of files would crash the function.


"#973 SysFileTree causes Segmentation fault"
https://sourceforge.net/p/oorexx/bugs/973/

Seems now that I have looked it back up, Mark did find something wrong... not that it was closed as un-reproducible. Unfortunately I had already done the major cleanup on our file server, so at that 
time I could not say if what Mark did resolved the problem.


Perhaps if I were to mount the share to our file server to several mount points 
I could get back up to the number of objects that used to cause the crash. 
/mnt/ldslnx01/data, /mnt/ldslnx01/data2, etc...

Thoughts, or do you think what Mark resolved back then resolved a crash trying 
to build a file tree of too many objects?

I am thankful,

--
Michael Lueck
Lueck Data Systems
http://www.lueckdatasystems.com/


___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel