Re: [OE-core] [PATCH 1/3] latencytop: remove recipe

2018-02-14 Thread Bruce Ashfield 

On 2018-02-14 9:46 AM, Mark Asselstine wrote:

On Tuesday, February 13, 2018 2:27:49 PM EST Randy MacLeod wrote:

On 2018-02-08 03:22 PM, Alexander Kanavin wrote:

Last commit and release were in 2009; website is down; it's a dead
project.


Add MarkA who might care/know more about latencytop than I do.


I believe Bruce had already identified LatencyTop as a dead end by the time we
even did our first release of OVP (I have no recollection of ever including it
and there are 0 user stories in Rally which would validate my memories on this
subject). Just in case I have added Bruce to the list. We already had LTTng
and FTrace, including a mostly dead Intel project was not a priority if I
recall correctly.



Not everything needs new features constantly, and if they aren't
causing build issues .. I tend to be ok with keeping them around.

There are uses, and users for latencytop.

That being said, I can just add it to meta-realtime, and it can
be dropped from core, since the userbase doesn't justify it in
oe-core itself.

Cheers,

Bruce


MarkA




Is there another package that makes use of the kernel feature?
The kernel Kconfig has been tweaked in 2017:

 commit a34a766ff96d9e88572e35a45066279e40a85d84
 Author: Josh Poimboeuf 
 Date:   Mon Jul 24 18:36:58 2017 -0500

   x86/kconfig: Make it easier to switch to the new ORC unwinder

and there are people updating latencytop on github last year:
 https://github.com/namhyung/latencytop/commits/master
commits on some random github page. That's shocking I know but it
does indicate that there's still interest in the tool even if the
original authors haven't been maintaining it.

../Randy








--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] latencytop: remove recipe

2018-02-14 Thread Mark Asselstine 
On Tuesday, February 13, 2018 2:27:49 PM EST Randy MacLeod wrote:
> On 2018-02-08 03:22 PM, Alexander Kanavin wrote:
> > Last commit and release were in 2009; website is down; it's a dead
> > project.
> 
> Add MarkA who might care/know more about latencytop than I do.

I believe Bruce had already identified LatencyTop as a dead end by the time we 
even did our first release of OVP (I have no recollection of ever including it 
and there are 0 user stories in Rally which would validate my memories on this 
subject). Just in case I have added Bruce to the list. We already had LTTng 
and FTrace, including a mostly dead Intel project was not a priority if I 
recall correctly.

MarkA

> 
> 
> Is there another package that makes use of the kernel feature?
> The kernel Kconfig has been tweaked in 2017:
> 
> commit a34a766ff96d9e88572e35a45066279e40a85d84
> Author: Josh Poimboeuf 
> Date:   Mon Jul 24 18:36:58 2017 -0500
> 
>   x86/kconfig: Make it easier to switch to the new ORC unwinder
> 
> and there are people updating latencytop on github last year:
> https://github.com/namhyung/latencytop/commits/master
> commits on some random github page. That's shocking I know but it
> does indicate that there's still interest in the tool even if the
> original authors haven't been maintaining it.
> 
> ../Randy
> 
> 
> 


-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [OE-core] [PATCH 1/3] latencytop: remove recipe

2018-02-13 Thread Randy MacLeod 

On 2018-02-08 03:22 PM, Alexander Kanavin wrote:

Last commit and release were in 2009; website is down; it's a dead project.


Add MarkA who might care/know more about latencytop than I do.


Is there another package that makes use of the kernel feature?
The kernel Kconfig has been tweaked in 2017:

   commit a34a766ff96d9e88572e35a45066279e40a85d84
   Author: Josh Poimboeuf 
   Date:   Mon Jul 24 18:36:58 2017 -0500

 x86/kconfig: Make it easier to switch to the new ORC unwinder

and there are people updating latencytop on github last year:
   https://github.com/namhyung/latencytop/commits/master
commits on some random github page. That's shocking I know but it
does indicate that there's still interest in the tool even if the
original authors haven't been maintaining it.

../Randy




--
# Randy MacLeod.  WR Linux
# Wind River an Intel Company
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

[OE-core] [PATCH 1/3] latencytop: remove recipe

2018-02-08 Thread Alexander Kanavin 
Last commit and release were in 2009; website is down; it's a dead project.

Signed-off-by: Alexander Kanavin 
---
 meta/conf/distro/include/distro_alias.inc  |  1 -
 meta/conf/distro/include/maintainers.inc   |  1 -
 .../packagegroup-core-tools-profile.bb |  1 -
 ...-function-signatures-to-fix-prototype-mis.patch | 64 --
 .../latencytop-0.5/latencytop-fsync.patch  | 49 -
 .../latencytop-0.5/latencytop-makefile.patch   | 43 ---
 meta/recipes-kernel/latencytop/latencytop_0.5.bb   | 32 ---
 7 files changed, 191 deletions(-)
 delete mode 100644 
meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch
 delete mode 100644 
meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync.patch
 delete mode 100644 
meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-makefile.patch
 delete mode 100644 meta/recipes-kernel/latencytop/latencytop_0.5.bb

diff --git a/meta/conf/distro/include/distro_alias.inc 
b/meta/conf/distro/include/distro_alias.inc
index 1a217daa390..8ec623befbd 100644
--- a/meta/conf/distro/include/distro_alias.inc
+++ b/meta/conf/distro/include/distro_alias.inc
@@ -159,7 +159,6 @@ DISTRO_PN_ALIAS_pn-kern-tools-native = "Windriver"
 DISTRO_PN_ALIAS_pn-keymaps = "OE-Core"
 DISTRO_PN_ALIAS_pn-kf = "OSPDT"
 DISTRO_PN_ALIAS_pn-lame = "Debian=lame Ubuntu=lame"
-DISTRO_PN_ALIAS_pn-latencytop = "Meego=latencytop Fedora=latencytop 
Debian=latencytop OpenSuSE=latencytop"
 DISTRO_PN_ALIAS_pn-ldconfig-native = "Ubuntu=libc-bin Fedora=glibc"
 DISTRO_PN_ALIAS_pn-liba52 = "Mandriva=a52dec Debian=a52dec"
 DISTRO_PN_ALIAS_pn-libacpi = "Ubuntu=libacpi Mandriva=libacpi"
diff --git a/meta/conf/distro/include/maintainers.inc 
b/meta/conf/distro/include/maintainers.inc
index 34f3d810051..9b25a112b75 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -302,7 +302,6 @@ RECIPE_MAINTAINER_pn-kmod-native = "Chen Qi 
"
 RECIPE_MAINTAINER_pn-kmscube = "Carlos Rafael Giani "
 RECIPE_MAINTAINER_pn-l3afpad = "Maxin B. John "
 RECIPE_MAINTAINER_pn-lame = "Tanu Kaskinen "
-RECIPE_MAINTAINER_pn-latencytop = "Alexander Kanavin 
"
 RECIPE_MAINTAINER_pn-ldconfig-native = "Khem Raj "
 RECIPE_MAINTAINER_pn-less = "Yi Zhao "
 RECIPE_MAINTAINER_pn-liba52 = "Tanu Kaskinen "
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb 
b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index a8e47da40cd..e3814a44bc2 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -26,7 +26,6 @@ RRECOMMENDS_${PN} = "\
 
 PROFILETOOLS = "\
 powertop \
-latencytop \
 "
 PERF = "perf"
 PERF_libc-musl = ""
diff --git 
a/meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch
 
b/meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch
deleted file mode 100644
index b248133460e..000
--- 
a/meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch
+++ /dev/null
@@ -1,64 +0,0 @@
-From db112739dc4f608a968b8104b382955dc3d96ca3 Mon Sep 17 00:00:00 2001
-From: Khem Raj 
-Date: Mon, 7 Sep 2015 07:40:10 +
-Subject: [PATCH] Rectify the function signatures to fix prototype mismatches
-
-clang is less forgiving when it comes to coding standards, correct the
-function signatures to reflect the function logic
-
-Signed-off-by: Khem Raj 

-Upstream-Status: Pending
-
- fsync.c  | 7 ---
- latencytop.h | 2 +-
- 2 files changed, 5 insertions(+), 4 deletions(-)
-
-diff --git a/fsync.c b/fsync.c
-index 82dff0e..5cefba9 100644
 a/fsync.c
-+++ b/fsync.c
-@@ -51,7 +51,7 @@ struct fsync_files {
- static GList *fsync_data;
- 
- 
--static chain_file(struct fsync_process *proc, char *filename)
-+static void chain_file(struct fsync_process *proc, char *filename)
- {
-   struct fsync_files *file;
-   GList *item;
-@@ -75,7 +75,7 @@ static chain_file(struct fsync_process *proc, char *filename)
-   proc->files = g_list_append(proc->files, file);
- }
- 
--static report_file(char *process, char *file)
-+static void report_file(char *process, char *file)
- {
-   struct fsync_process *proc;
-   GList *item;
-@@ -157,9 +157,10 @@ int enable_fsync_tracer(void)
-   write_to_file("/sys/kernel/debug/tracing/current_tracer", "fsync"); 
-   write_to_file("/sys/kernel/debug/tracing/iter_ctrl", "ftrace_printk");  
-   write_to_file("/sys/kernel/debug/tracing/tracing_on", "1");
-+