Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects
Hi Markus, I would like to extend in http://bazaar.launchpad.net/~hr-core-editors/openerp-hr/7.0/files/head:/hr_public_holidaysthat with a wizard fill that model from a ics calendar source. if you have a more cool idea we can discuss on another thread in community ml. Regards Franco Franco Tampieri System Engineer _ abstract.it - +39 06 9294 6938 Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze Legali – D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute in questo messaggio e in ogni eventuale allegato sono riservate e ne è vietata ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore, Vi preghiamo di informare immediatamente il mittente del messaggio e di eliminare l'e-mail. 2014-04-23 10:37 GMT+02:00 Markus Schneider markus.schnei...@initos.com: just update german information on the wiki we have two data we want to integrate to OpenERP: 1) city - zip code + geoinformation of the city is there a module for other country how to provide this data? 2) holidays is someone working on something simular? for hr module Greetings Markus On 23.04.2014 07:38, Info SHS-AV wrote: Hi Erdem, I prepared a web page to insert and gather informations about addresses. http://www.openerp.enterprises/wiki/OpenERP_Address You can insert or update data, in Wikimedia format. Username is *OpenERP* and password is *developer* You can find link to OpenERP Developer Community Team https://launchpad.net/%7Eopenerp-community https://launchpad.net/~openerp-community Hope is useful for you. Antonio M. Vigliotti Il 22/04/2014 18:36, Erdem Uney ha scritto: Hi all, We would like to participate for the Turkish data and maybe some help on the Eastern European region. Please add me to group. Have you decided which data and how to keep it? Is there an agreed template? Cheers, Erdem 7Gates Interactive Technologies | Istanbul - Turkiye On Tue, Mar 25, 2014 at 5:39 PM, Lionel Sausin l...@numerigraphe.com mailto:l...@numerigraphe.com wrote: Project : https://launchpad.net/openerp-data Team : https://launchpad.net/~openerp-data-editors https://launchpad.net/%7Eopenerp-data-editors ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Dipl.-Comp.-Math. Markus Schneider Softwareentwickler initOS GmbH Co. KG An der Eisenbahn 1 21224 Rosengarten Mobil: +49 (0)172 2303699 Phone: +49 (0)4105 5615613 Fax: +49 (0)4105 5615610 Email: markus.schnei...@initos.com Web: http://www.initos.com Geschäftsführung: Dipl. Wirt.-Inf. Frederik Kramer Dipl.-Ing. (FH) Torsten Francke Haftende Gesellschafterin: initOS Verwaltungs GmbH Sitz der Gesellschaft: Rosengarten – Klecken Amtsgericht Tostedt, HRA 201840 USt-IdNr: DE 275698169 Steuer-Nr: 15/205/21402 ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
[Openerp-community] web_hide_duplicate module
Hello community, Don't know if it was already done, but I made a module to hide 'Duplicate' action from 'Other' section in sidebar. OpenERP web module allows you to hide this button by using create=false but it has a drawback, you will also hide create button, so if you only want to hide duplicate button add duplicate=false to form declaration. Github repo: https://github.com/menecio/oerp-addons ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] web_hide_duplicate module
On Fri, Apr 25, 2014 at 11:27 AM, Aristóbulo Meneses aristob...@gmail.comwrote: Hello community, Don't know if it was already done, but I made a module to hide 'Duplicate' action from 'Other' section in sidebar. OpenERP web module allows you to hide this button by using create=false but it has a drawback, you will also hide create button, so if you only want to hide duplicate button add duplicate=false to form declaration. Hi ! great work if you can you can make a branch and try to merge in https://launchpad.net/web-addons Its the official community web modules. Regards, Github repo: https://github.com/menecio/oerp-addons ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Cristian Salamea @ovnicraft ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] web_hide_duplicate module
On 04/25/2014 06:33 PM, Ovnicraft wrote: On Fri, Apr 25, 2014 at 11:27 AM, Aristóbulo Meneses aristob...@gmail.com mailto:aristob...@gmail.com wrote: Hello community, Don't know if it was already done, but I made a module to hide 'Duplicate' action from 'Other' section in sidebar. OpenERP web module allows you to hide this button by using create=false but it has a drawback, you will also hide create button, so if you only want to hide duplicate button add duplicate=false to form declaration. Hi ! great work if you can you can make a branch and try to merge in https://launchpad.net/web-addons Its the official community web modules. Hello, hide_duplicate_button https://www.openerp.com/apps/6.1/hide_duplicate_button/ is also available on apps for 6.1 Regards -- Lorenzo Battistini Tel (CH): +41 91 210 23 40 Tel (IT): +39 011 198 25481 http://www.agilebg.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Duty roster module
Indeed it looks nice. A question? Do you think it could be used to define vacation days for each year? I mean, national, regional, city official holidays and company special free days (or whatever says the law)? -- Alejandro Santana alejandrosant...@anubia.es alejandrosant...@anubia.es ~ ANUBÍA, soluciones en la nube, S.L. www.anubia.es http://www.anubia.es/ Plaza Fernando Conde Montero Ríos, 9 36201, Vigo (Pontevedra) 2014-04-23 15:07 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi Pedro, It doesn't do automatic planning. I am not sure that should be done. This module is actually part of a larger project that I am working for my client in manufacturing industry, and thought it would be useful for someone else. It hasn't been thoroughly tested as a module, but should work as advertised. On Apr 23, 2014 8:18 PM, Pedro Manuel Baeza Romero pedro.ba...@gmail.com wrote: Hi, Phui, It looks very good, and indeed it's a great addition to OCA repositories. I think best place for it is *lp:openerp-hr*. Doest itinclude automatic planning of the duty roster? It would be fantastic. Regards. 2014-04-23 13:56 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi all, I have developed a duty roster module to allow shifts/schedule management. This is useful when used in conjunction with hr_holidays to calculate more accurately the number of leaves a staff can take, for example. A few screenshots are uploaded here: http://imgur.com/a/mo8jR#0 Code is hosted here: https://code.launchpad.net/~codekaki/cdkk+openerp-addons/hr_ext-7.0 I wonder if this is a candidate for inclusion into the community branch since there isn't anything like this yet. *Chang Phui-Hock* CODEKAKI SYSTEMS (R49045/14) - A web-dev company Skype: phuihock Website: http://www.codekaki.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community] Duty roster module
Never thought about that but it looks like you can adapt to for your use case. It uses the shift codes defined in hr.shift_code model. So I imagine you can define different type of shift codes for different type of holidays. On Apr 26, 2014 7:20 AM, Alejandro Santana alejandrosant...@anubia.es wrote: Indeed it looks nice. A question? Do you think it could be used to define vacation days for each year? I mean, national, regional, city official holidays and company special free days (or whatever says the law)? -- Alejandro Santana alejandrosant...@anubia.es alejandrosant...@anubia.es ~ ANUBÍA, soluciones en la nube, S.L. www.anubia.es http://www.anubia.es/ Plaza Fernando Conde Montero Ríos, 9 36201, Vigo (Pontevedra) 2014-04-23 15:07 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi Pedro, It doesn't do automatic planning. I am not sure that should be done. This module is actually part of a larger project that I am working for my client in manufacturing industry, and thought it would be useful for someone else. It hasn't been thoroughly tested as a module, but should work as advertised. On Apr 23, 2014 8:18 PM, Pedro Manuel Baeza Romero pedro.ba...@gmail.com wrote: Hi, Phui, It looks very good, and indeed it's a great addition to OCA repositories. I think best place for it is *lp:openerp-hr*. Doest itinclude automatic planning of the duty roster? It would be fantastic. Regards. 2014-04-23 13:56 GMT+02:00 Phui Hock phuih...@codekaki.com: Hi all, I have developed a duty roster module to allow shifts/schedule management. This is useful when used in conjunction with hr_holidays to calculate more accurately the number of leaves a staff can take, for example. A few screenshots are uploaded here: http://imgur.com/a/mo8jR#0 Code is hosted here: https://code.launchpad.net/~codekaki/cdkk+openerp-addons/hr_ext-7.0 I wonder if this is a candidate for inclusion into the community branch since there isn't anything like this yet. *Chang Phui-Hock* CODEKAKI SYSTEMS (R49045/14) - A web-dev company Skype: phuihock Website: http://www.codekaki.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-community@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server
Review: Needs Fixing code review, test This patch breaks the yaml_import tests. Extract from the logs: TEST test_ocb70 openerp.tools.yaml_import: 2. Duplicate the parent category and verify that the children have been duplicated too and are below the new parent ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only TEST test_ocb70 openerp.tools.yaml_import: 3. Duplicate the children then reassign them to the new parent (1st method) and check the parent_store structure. ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only TEST test_ocb70 openerp.tools.yaml_import: 4. Duplicate the children then reassign them to the new parent (2nd method) and check the parent_store structure. ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only TEST test_ocb70 openerp.tools.yaml_import: 5. Duplicate the children then reassign them to the new parent (3rd method) and make sure the parent_store structure is still right. ERROR test_ocb70 openerp.tools.yaml_import: AssertionError in Python code : After duplication, previous record must have old childs records only Can you please check this, and adapt the tests (which seem to have some assumptions broken by your changes) or fix the code in yaml_import? -- https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report
Approve - code review and test -- https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web
Hello Stefan ! Yes I have tested this branch and it is solving the problem. This bug is only effecting OCB branch because of changes from this (http://bazaar.launchpad.net/~ocb/ocb-web/7.0/revision/4040) commit . And changes from this commit is not in openerp-web. So We do not have to provide any merge propose for openerp-web. Please let me know your view on the same. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management
Review: Approve code review, no tests LGTM now, thanks ! -- https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/207630 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
I would like to suggest the following changes to purchase_group_hooks.py: - Change _key_fields_for_grouping_lines to return a list like _key_fields_for_grouping and not a tuple - function _update_merged_order_data exists but is not used? This might be the reason why the addition of field origin is not working. -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
You are right Martin, thanks. You can set review: Needs fixing and press save comment (no comment is OK because you already commented). -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-add-web_send_message_popup into lp:web-addons
Guewen Baconnier @ Camptocamp has proposed merging
lp:~camptocamp/web-addons/7.0-add-web_send_message_popup into lp:web-addons.
Commit message:
Add module web_send_message_popup changing the 'Send a message' link to open
directly the full featured message popup
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/web-addons/7.0-add-web_send_message_popup/+merge/217188
Add the web_send_message_popup module.
In the email/notes threads below the form views, the link 'Send a
message' unfold a text field. From there, a button allows to open the
text field in a full featured email popup with the subject, templates,
attachments and followers.
This module changes the link 'Send a message' so it opens directly the
full featured popup instead of the text field, avoiding an extra click
if the popup is always wanted.
--
https://code.launchpad.net/~camptocamp/web-addons/7.0-add-web_send_message_popup/+merge/217188
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~camptocamp/web-addons/7.0-add-web_send_message_popup into lp:web-addons.
=== added directory 'web_send_message_popup'
=== added file 'web_send_message_popup/__init__.py'
--- web_send_message_popup/__init__.py 1970-01-01 00:00:00 +
+++ web_send_message_popup/__init__.py 2014-04-25 09:10:25 +
@@ -0,0 +1,1 @@
+# -*- coding: utf-8 -*-
=== added file 'web_send_message_popup/__openerp__.py'
--- web_send_message_popup/__openerp__.py 1970-01-01 00:00:00 +
+++ web_send_message_popup/__openerp__.py 2014-04-25 09:10:25 +
@@ -0,0 +1,49 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Guewen Baconnier
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{'name': 'Web Send Message as Popup',
+ 'version': '1.0',
+ 'author': 'Camptocamp',
+ 'maintainer': 'Camptocamp',
+ 'license': 'AGPL-3',
+ 'category': 'Hidden',
+ 'depends': ['web',
+ ],
+ 'description':
+Web Send Message as Popup
+=
+
+In the email/notes threads below the form views, the link 'Send a
+message' unfold a text field. From there, a button allows to open the
+text field in a full featured email popup with the subject, templates,
+attachments and followers.
+
+This module changes the link 'Send a message' so it opens directly the
+full featured popup instead of the text field, avoiding an extra click
+if the popup is always wanted.
+
+ ,
+ 'website': 'http://www.camptocamp.com',
+ 'qweb': ['static/src/xml/mail.xml',
+ ],
+ 'installable': True,
+ 'auto_install': False,
+}
=== added directory 'web_send_message_popup/static'
=== added directory 'web_send_message_popup/static/src'
=== added directory 'web_send_message_popup/static/src/xml'
=== added file 'web_send_message_popup/static/src/xml/mail.xml'
--- web_send_message_popup/static/src/xml/mail.xml 1970-01-01 00:00:00 +
+++ web_send_message_popup/static/src/xml/mail.xml 2014-04-25 09:10:25 +
@@ -0,0 +1,11 @@
+?xml version=1.0 encoding=UTF-8?
+template
+ t t-extend=mail.compose_message
+t t-jquery=a.oe_compose_post:eq(0) t-operation=replace
+ a class=oe_compose_post oe_full t-if=widget.options.compose_placeholdert t-raw=widget.options.compose_placeholder//a
+/t
+t t-jquery=a.oe_compose_post:eq(1) t-operation=replace
+ a class=oe_compose_post oe_full t-if=!widget.options.compose_placeholder and !widget.options.view_mailboxSend a message/a
+/t
+ /t
+/template
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools
Hello Lorenzo, About the constraints. This module is heavily inspired by account_analytic_required which used the same technique. I must confess I did not question the approach. Initially account_analytic_required was working mainly on the vals dictionary so it would have been faster than constraints. While working on account_partner_required I identified a bug in account_analytic_required which required a refactoring [1] which possibly rendered the optimization less obvious. Now since there are really two constraints to be checked based on the policy, the current approach is probably still slightly faster. Would you agree to keep the current approach and postpone a possible performance test / refactoring with constraints to another MP? Regarding yml vs unittest, it's only a matter of personal taste in this case. I notice the unittest2 framework seems better documented [2]. But hey, at least I have tests, right :) [1] https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi [2] https://doc.openerp.com/trunk/server/05_test_framework/ -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442 Your team Account Core Editors is requested to review the proposed merge of lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows
Review: Approve code review, test LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils
Sandy, is it ok for you now? -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils
Yannick, you will need to rebase unfortunately, the head diverged. -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils. Requested reviews: Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test Related bugs: Bug #1312682 in OpenERP Launchpad Community Utils: NameError: global name 'age' is not defined https://bugs.launchpad.net/lp-community-utils/+bug/1312682 For more details, see: https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Fix lp:1312682 Restore what we had before revision 30: http://bazaar.launchpad.net/~openerp-community-reviewer/lp-community-utils/openerp-reviewers-nag/view/29/openerp-nag#L213 -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. === modified file 'openerp-nag' --- openerp-nag 2014-03-14 16:13:39 + +++ openerp-nag 2014-04-25 11:49:56 + @@ -213,6 +213,7 @@ ) # Nag about approved merges +age = (now - proposal.date_review_requested).days if (votes.approve == votes.total(for_approval=True) and (votes.approve = policy.approvals_to_bypass or votes.approve = policy.min_approve and -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1263888] Re: Context keys *_view_ref of one2many propagated to buttons
Hello,
We have backported in 7.0 a fix present in trunk.
revno: 4181 [merge]
revision-id: m...@openerp.com-20140425120002-g4126s9it705hwj5
Regards
** Changed in: openerp-web
Status: Fix Committed = Fix Released
** Changed in: openerp-web
Importance: Undecided = Low
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Web).
https://bugs.launchpad.net/bugs/1263888
Title:
Context keys *_view_ref of one2many propagated to buttons
Status in OpenERP Community Backports (Web):
Fix Released
Status in OpenERP Community Backports (Web) 7.0 series:
Fix Released
Status in OpenERP Web:
Fix Released
Bug description:
The correction [0] of this bug lp:1177063 reveals another bug.
I guess that it is related to the webclient, but I could be wrong.
Steps to reproduce:
1) Apply the patch [0]
2) Make sure you have the groups: 'Track serial number on products', 'Track
serial number on logistic units (pallets)' (the Packs should be displayed on
the delivery orders)
3) Create a delivery order
4) Click on the Split Into button
You will have an error as follows:
Can't find field 'product_uos_qty' in the following view parts composing the
view of object model 'stock.move':
* stock.move.form
The problem comes from the context, that is set on the move_lines m2o
field:
xpath expr=//field[@name='move_lines'] position=replace
field name=move_lines context={'address_out_id':
partner_id, 'picking_type': 'out',
'form_view_ref':'stock.view_move_picking_form',
'tree_view_ref':'stock.view_move_picking_tree'} options='{reload_on_button:
true}'/
/xpath
This context is also propagated when we click on the button Split
Into. So the server tries to build the view
stock.view_move_picking_form for the stock.split.into and fails.
The bug was not occuring before the patch of the stock view because
the form_view_ref and tree_view_ref were simply ignored.
[0] https://code.launchpad.net/~alhashash/openobject-
addons/7.0-bugs-1177076-1177063-alhashash/+merge/162664
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-web/+bug/1263888/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal into lp:account-financial-tools
The proposal to merge lp:~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal into lp:account-financial-tools has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal/+merge/207841 -- https://code.launchpad.net/~therp-nl/account-financial-tools/7.0-add_move_line_no_default_search_period_journal/+merge/207841 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin into lp:ocb-addons
Review: Approve code review LGTM -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin/+merge/210559 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Review: Approve code review -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin into lp:ocb-addons
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin/+merge/210559 -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin/+merge/210559 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1098557] Re: Can't set a default origin for stock pickings when duplicating from Python code
** Changed in: ocb-addons
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1098557
Title:
Can't set a default origin for stock pickings when duplicating from
Python code
Status in OpenERP Community Backports (Addons):
Fix Released
Status in OpenERP Addons (modules):
Fix Committed
Bug description:
In the Python code of custom addons, it would sometimes be useful to be able
to copy a picking while setting the origin field.
For example:
defaults={'origin': 'test', 'type': 'internal'}
id = self.pool.get('stock.picking').copy(cr, uid, 1, defaults,
context={})
However, in v6.0 and up to the current trunk, the method copy() of
stock.picking resets the field origin as soon as no default name is set.
I suggest the origin be reset only if it's not passed in the dict of default
values.
Lionel Sausin
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1098557/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes
The proposal to merge lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes has been updated. Description changed to: add module partner_custom_attributes For more details, see: https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep/+merge/217234 -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep/+merge/217234 Your team Product Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/ocb-server/7.0-bug-1274997-cron into lp:ocb-server
The proposal to merge lp:~acsone-openerp/ocb-server/7.0-bug-1274997-cron into lp:ocb-server has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~acsone-openerp/ocb-server/7.0-bug-1274997-cron/+merge/204298 -- https://code.launchpad.net/~acsone-openerp/ocb-server/7.0-bug-1274997-cron/+merge/204298 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report
The proposal to merge lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Review: Approve -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1274997] Re: Same task executed several times at same time when cron is runnning in multi thread
** Changed in: ocb-server Status: Confirmed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1274997 Title: Same task executed several times at same time when cron is runnning in multi thread Status in OpenERP Community Backports (Server): Fix Released Status in OpenERP Server: Confirmed Status in OpenERP Server Environment And Tools: New Bug description: When the cron is configured to run in multi thread (max_cron_threads 1), Some times, the same task can be executed several times et same time. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/1274997/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons
Review: Needs Information Couldn't a composed index on the columns inventory_id, location_name, product_code, product_name, prodlot_name be useful? -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons
Review: Approve -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264 -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1291986] Re: Last Product Inventories could show the last move's date too
** Changed in: ocb-addons Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1291986 Title: Last Product Inventories could show the last move's date too Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Addons (modules): New Bug description: The report model latest inventory date could be improved a bit by showing the date of the latest Stock Move as well. This would help users isolate unused products that may deserve special measures like discount sales or quality control. Of course this is not a bug in itself, rather a wishlist item. I'm filing it here to help maintainers of OCB and trunk-wms follow-up. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1291986/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting
The proposal to merge lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842 -- https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842 Your team Project Core Editors is subscribed to branch lp:project-reporting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1
The proposal to merge lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883 -- https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1192115] Re: [trunk/7.0] carrier information not propagated from sale order to pickings
** Changed in: ocb-addons/7.0 Status: New = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1192115 Title: [trunk/7.0] carrier information not propagated from sale order to pickings Status in OpenERP Community Backports (Addons): Fix Released Status in OpenERP Community Backports (Addons) 7.0 series: Fix Released Status in OpenERP Addons (modules): Fix Committed Bug description: When I create a SO in v7 with, and I add the shipping fees using the Add in Quote button, the carrier_id is removed from the Sale Order. As a result, the carrier information is not set on the pickings when the SO is confirmed, and this is not good because it prevents grouping the processing of pickings by carrier, which is very useful from a logistics point of view. Fixing this requires care to avoid invoicing the shipping fees twice. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1192115/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing
The proposal to merge lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 -- https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/allow_date_fy-sbi into lp:account-financial-tools
Review: Approve LGTM -- https://code.launchpad.net/~acsone-openerp/account-financial-tools/allow_date_fy-sbi/+merge/213644 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company into lp:account-financial-tools
The proposal to merge lp:~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company into lp:account-financial-tools has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company/+merge/212920 -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company/+merge/212920 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web
I see. In that case, there is a corresponding fix for upstream OpenERP, and you should propose the fix into the unmerged bugfixing branch then: https://code.launchpad.net/~openerp-dev/openerp-web/7.0-opw-596129-msh/+merge/180067 -- https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company into lp:account-financial-tools
Review: Approve code review -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company/+merge/212920 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep/+merge/217234
add module partner_custom_attributes
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep/+merge/217234
Your team Product Core Editors is requested to review the proposed merge of
lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into
lp:openerp-product-attributes.
=== added directory 'partner_custom_attributes'
=== added file 'partner_custom_attributes/__init__.py'
--- partner_custom_attributes/__init__.py 1970-01-01 00:00:00 +
+++ partner_custom_attributes/__init__.py 2014-04-25 12:57:27 +
@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+###
+# #
+# Author: Leonardo Pistone leonardo.pist...@camptocamp.com#
+# Copyright 2014 Camptocamp SA #
+# #
+# Inspired by the module product_custom_attributes #
+# by Benoît GUILLOT benoit.guil...@akretion.com, Akretion #
+# #
+# This program is free software: you can redistribute it and/or modify #
+# it under the terms of the GNU Affero General Public License as#
+# published by the Free Software Foundation, either version 3 of the#
+# License, or (at your option) any later version. #
+# #
+# This program is distributed in the hope that it will be useful, #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of#
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
+# GNU Affero General Public License for more details. #
+# #
+# You should have received a copy of the GNU Affero General Public License #
+# along with this program. If not, see http://www.gnu.org/licenses/. #
+# #
+###
+from . import partner # noqa
+from . import wizard # noqa
=== added file 'partner_custom_attributes/__openerp__.py'
--- partner_custom_attributes/__openerp__.py 1970-01-01 00:00:00 +
+++ partner_custom_attributes/__openerp__.py 2014-04-25 12:57:27 +
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+###
+# #
+# Author: Leonardo Pistone leonardo.pist...@camptocamp.com#
+# Copyright 2014 Camptocamp SA #
+# #
+# Inspired by the module product_custom_attributes #
+# by Benoît GUILLOT benoit.guil...@akretion.com, Akretion #
+# #
+# This program is free software: you can redistribute it and/or modify #
+# it under the terms of the GNU Affero General Public License as#
+# published by the Free Software Foundation, either version 3 of the#
+# License, or (at your option) any later version. #
+# #
+# This program is distributed in the hope that it will be useful, #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of#
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
+# GNU Affero General Public License for more details. #
+# #
+# You should have received a copy of the GNU Affero General Public License #
+# along with this program. If not, see http://www.gnu.org/licenses/. #
+# #
+###
+
+{'name': 'Partner Custom Attributes',
+ 'version': '0.1.0',
+ 'category': 'Generic Modules/Others',
+ 'license': 'AGPL-3',
+ 'description':
+Partner custom attributes
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons
Hi gbaconnier, Yes it's useful to always order the lines on the same order. Without this index, search for productions lot for a same product, or a same product on different locations can be painful on thousands of inventory lines. This index is useful for having the same order on printing and screen without re-order. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1311076] Re: multiple popup weird behavior
Apparently, this bug is uncovered by the fix for https://bugs.launchpad.net/ocb-web/+bug/1155525 and could count as an OCB regression. ** No longer affects: openerp-web ** Also affects: ocb-web/7.0 Importance: Low Assignee: Ruchir Shukla(BizzAppDev) (ruchir.shukla) Status: Confirmed ** Summary changed: - multiple popup weird behavior + [ocb] multiple popup weird behavior -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1311076 Title: [ocb] multiple popup weird behavior Status in OpenERP Community Backports (Web): Confirmed Status in OpenERP Community Backports (Web) 7.0 series: Confirmed Bug description: Lets say in case of the multiple popup. in second wizard there is a problem in footer . E.G load translation menu . when you select language . and load it . As a result it will popup new wizard . in this new wizard it has a problem as there are 2 footers one for init state and second is done state . some how OR is there from init state in second popup. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-web/+bug/1311076/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line into lp:account-invoicing
Review: Approve -- https://code.launchpad.net/~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line/+merge/211708 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views into lp:ocb-web
Review: Approve code review -- https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views/+merge/211489 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep into lp:openerp-product-attributes
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep/+merge/217247
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep/+merge/217247
Your team Product Core Editors is requested to review the proposed merge of
lp:~camptocamp/openerp-product-attributes/7.0-del-text-workaround-lep into
lp:openerp-product-attributes.
=== modified file 'product_custom_attributes/product.py'
--- product_custom_attributes/product.py 2014-03-19 17:45:33 +
+++ product_custom_attributes/product.py 2014-04-25 13:59:22 +
@@ -54,16 +54,6 @@
relation='attribute.group', string='Groups')
}
-def _fix_size_bug(self, cr, uid, result, context=None):
-#When created a field text dynamicaly, its size is limited to 64 in the view.
-#The bug is fixed but not merged
-#https://code.launchpad.net/~openerp-dev/openerp-web/6.1-opw-579462-cpa/+merge/128003
-#TO remove when the fix will be merged
-for field in result['fields']:
-if result['fields'][field]['type'] == 'text':
-if 'size' in result['fields'][field]: del result['fields'][field]['size']
-return result
-
def open_attributes(self, cr, uid, ids, context=None):
ir_model_data_obj = self.pool.get('ir.model.data')
ir_model_data_id = ir_model_data_obj.search(cr, uid, [['model', '=', 'ir.ui.view'], ['name', '=', 'product_attributes_form_view']], context=context)
@@ -122,5 +112,4 @@
)[0]
info_page.addnext(main_page)
result['arch'] = etree.tostring(eview, pretty_print=True)
-result = self._fix_size_bug(cr, uid, result, context=context)
return result
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views into lp:ocb-web
Hmm, conflict :-( The line t t-set=fileupload_style t-translation=offwidth: 83px;/t became t t-set=fileupload_style t-translation=offoverflow-x: hidden/t Id doesn't seem to be related to your fix though (changed in revisions 3745.2.424 and 3745.2.426) Can you resolve the conflict? -- https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views/+merge/211489 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report
Laurent Mignon (Acsone) has proposed merging
lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into
lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
Related bugs:
Bug #1312732 in Account - Financial Report: Plain SQL required for the first
install of account_financial_report_webkit is executed at each module update
https://bugs.launchpad.net/account-financial-report/+bug/1312732
For more details, see:
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240
[FIX] lp:1312732
Use the migration machinery to launch the initialization of the newly created
column on account_move_line only on the first installation of the module
account_financial_report_webkit
--
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240
Your team Account Report Core Editors is requested to review the proposed merge
of lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into
lp:account-financial-report.
=== modified file 'account_financial_report_webkit/account_move_line.py'
--- account_financial_report_webkit/account_move_line.py 2012-12-11 16:32:26 +
+++ account_financial_report_webkit/account_move_line.py 2014-04-25 13:34:20 +
@@ -28,24 +28,6 @@
Last rec date is the date of the last reconciliation (full or partial) account move line
_inherit = 'account.move.line'
-def init(self, cr):
-##We do not want to catch error as if sql is not run it will give invalid data
-cr.execute(UPDATE account_move_line as acm
-SET last_rec_date =
-(SELECT date from account_move_line
- WHERE reconcile_id = acm.reconcile_id
- AND reconcile_id IS NOT NULL
- ORDER BY date DESC LIMIT 1)
-WHERE last_rec_date is null;)
-
-cr.execute(UPDATE account_move_line as acm
-SET last_rec_date =
-(SELECT date from account_move_line
- WHERE reconcile_partial_id = acm.reconcile_partial_id
- AND reconcile_partial_id IS NOT NULL
- ORDER BY date DESC LIMIT 1)
-WHERE last_rec_date is null;)
-
def _get_move_line_from_line_rec(self, cr, uid, ids, context=None):
moves = []
for reconcile in self.pool.get('account.move.reconcile').browse(cr, uid, ids, context=context):
=== added directory 'account_financial_report_webkit/migrations'
=== added directory 'account_financial_report_webkit/migrations/7.0.1.0.2'
=== added file 'account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py'
--- account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py 1970-01-01 00:00:00 +
+++ account_financial_report_webkit/migrations/7.0.1.0.2/post-migration.py 2014-04-25 13:34:20 +
@@ -0,0 +1,39 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Author: Nicolas Bessi.
+#Copyright Camptocamp SA 2011
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+def migrate(cr, version):
+if not version:
+# only run at first install
+cr.execute(UPDATE account_move_line as acm
+SET last_rec_date =
+(SELECT date from account_move_line
+ WHERE reconcile_id = acm.reconcile_id
+ AND reconcile_id IS NOT NULL
+ ORDER BY date DESC LIMIT 1)
+WHERE last_rec_date is null;)
+
+cr.execute(UPDATE account_move_line as acm
+SET last_rec_date =
+(SELECT date from account_move_line
+ WHERE reconcile_partial_id = acm.reconcile_partial_id
+ AND reconcile_partial_id IS NOT NULL
+ ORDER BY date DESC LIMIT 1)
+WHERE last_rec_date is null;)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis
Review: Approve -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis
The proposal to merge lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354 -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl
The proposal to merge lp:~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge into lp:sale-wkfl has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719 -- https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/214719 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-mdh into lp:account-financial-report
Review: Approve -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-mdh/+merge/214897 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-mdh into lp:account-financial-report
The proposal to merge lp:~camptocamp/account-financial-report/7.0-add-reference-field-mdh into lp:account-financial-report has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-mdh/+merge/214897 -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-mdh/+merge/214897 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
The proposal to merge lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils
Review: Approve -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-unported into lp:project-service
Daniel Reis has proposed merging lp:~dreis-pt/project-service/7.0-unported into lp:project-service. Requested reviews: Project Core Editors (project-core-editors) For more details, see: https://code.launchpad.net/~dreis-pt/project-service/7.0-unported/+merge/217271 -- https://code.launchpad.net/~dreis-pt/project-service/7.0-unported/+merge/217271 Your team Project Core Editors is requested to review the proposed merge of lp:~dreis-pt/project-service/7.0-unported into lp:project-service. === renamed directory 'project_service_type' = '__unported__/project_service_type' -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons
Aristóbulo Meneses has proposed merging lp:~aristobulo/web-addons/web-addons
into lp:web-addons.
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
For more details, see:
https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277
--
https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~aristobulo/web-addons/web-addons into lp:web-addons.
=== added directory 'web_hide_duplicate'
=== added file 'web_hide_duplicate/__init__.py'
=== added file 'web_hide_duplicate/__openerp__.py'
--- web_hide_duplicate/__openerp__.py 1970-01-01 00:00:00 +
+++ web_hide_duplicate/__openerp__.py 2014-04-25 17:11:10 +
@@ -0,0 +1,8 @@
+{
+'name': 'Hide duplicate',
+'author': 'Aristobulo Meneses',
+'description': 'Allows to hide duplicate button under More section',
+'category': 'web',
+'depends': ['web', ],
+'js': ['static/src/js/duplicate.js', ],
+}
=== added directory 'web_hide_duplicate/static'
=== added directory 'web_hide_duplicate/static/src'
=== added directory 'web_hide_duplicate/static/src/js'
=== added file 'web_hide_duplicate/static/src/js/duplicate.js'
--- web_hide_duplicate/static/src/js/duplicate.js 1970-01-01 00:00:00 +
+++ web_hide_duplicate/static/src/js/duplicate.js 2014-04-25 17:11:10 +
@@ -0,0 +1,18 @@
+openerp.web_hide_duplicate = function (instance) {
+var _t = instance.web._t;
+
+instance.web.FormView.include({
+load_form: function(data) {
+this._super(data);
+// Now lets delete duplicate button from More section.
+console.log('Deleting duplicate button/link');
+if (!this.is_action_enabled('duplicate')) {
+var no_dup = _.reject(this.sidebar.items.other, function (item) {
+return item.label === _t('Duplicate');
+});
+this.sidebar.items.other = no_dup;
+this.sidebar.redraw();
+}
+}
+});
+};
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons
Tested on: [7.0] server: revno 5285 web: revno 4178 addons: 9997 [trunk] server: revno 5191 web: revno 3986 addons: revno 9377 -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~aristobulo/web-addons/web-addons into lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views into lp:ocb-web
Thanks for the review! Revision 4169 and 4171 of upstream OpenERP do constitute a fix for the linked bug report, so I'm retracting this proposal. -- https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views/+merge/211489 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1293085] Re: [7.0] Binary field widget in list view usability
Fixed in http://bazaar.launchpad.net/~openerp/openerp- web/7.0/revision/4169 and http://bazaar.launchpad.net/~openerp/openerp- web/7.0/revision/4171 ** No longer affects: ocb-web/7.0 ** No longer affects: ocb-web ** Changed in: openerp-web Status: New = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1293085 Title: [7.0] Binary field widget in list view usability Status in OpenERP Web: Fix Released Bug description: When editing a binary field in a list view, the region that allows the user to upload a file covers the 'Save as' button completely and even stretches into the 'Clear' button. To manage notifications about this bug go to: https://bugs.launchpad.net/openerp-web/+bug/1293085/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-ContextGroupByPropagationIssue-1101840 into lp:ocb-web
Reverted this change here: http://bazaar.launchpad.net/~ocb/ocb-web/7.0/revision/4189, because the upstream fix http://bazaar.launchpad.net/~ocb/ocb-web/7.0/revision/4190, while equivalent, is slightly different (takes advantage of existing underscore API instead of copying it in with the fix). -- https://code.launchpad.net/~camptocamp/ocb-web/7.0-ContextGroupByPropagationIssue-1101840/+merge/198582 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] OCB conflict: timesheet timezone vs. new attendances in confirmed timesheet
Dear community reviewers, news from the OCB-replay front here. We have had a couple of trivial conflicts recently, caused by OpenERP developers fixing bugs in the 7.0 branches that are already fixed in OCB but more or less differently (sometimes because they were unaware of the community fix, and sometimes with good reason). This is signalled by the replay process and at that moment we go in and revert the OCB fix in favour of the upstream fix. I try to take care and indicate this on the original OCB merge proposal. Today however, the addons replay process broke on a less trivial conflict between http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/10015 and a fix for a totally different problem by Yannick Vaucher: https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1204224-yvr/+merge/183670. It would seem wise to ask the original submitter of the conflicting OCB revision to resolve this conflict himself by proposing a branch that includes lp:openobject-addons/7.0 up until revision 10015 into ocb-addons. Yannick, would that be possible? (unless someone else volunteers) As for the replay process, there are basically two options here and I need a vote on this from you 1. revert the conflicting ocb revision in lp:ocb-addons ASAP to restart the replay process, or 2. do nothing and keep the replay process stalled at the current revision until the conflict has been resolved, proposed and approved For me, it depends on the time that it would take Yannick or someone else to submit a solution. I'd prefer to shorttrack this and hold off new bugfixes in upstream OpenERP for a short period of time rather than cause a regression but I don't know if that is possible. Note that the choice we make slightly affects the approach to fix the conflict: in the first case, the original bugfix needs to be reapplied because the bzr revision containing it is already included in OCB but its changes reverted. In the second case, it suffices to merge lp:openobject-addons/7.0 -r 10015 into a branch of ocb-addons, which will reveal the conflict. Hoping to hear from you. Cheers, Stefan. -- Therp - Maatwerk in open ontwikkeling Stefan Rijnhart - Ontwerp en implementatie mail: ste...@therp.nl tel: +31 (0) 614478606 web: http://therp.nl -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
