Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v9]
On Fri, 27 May 2022 16:47:04 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2. When WebView goes out of scope (disposed from app) , its Event Listeners >> are not being garbage collected. >> >> Solution: >> 1. Detached the jni global reference from JavaEventListener. >> 2. Create scoped ref counted wrapper class JavaObjectWrapperHandler for jni >> global reference. >> 3. Create unique JavaObjectWrapperHandler object for each JavaEventListener. >> 4. EventListenerManager is a singleton class , which stores the >> JavaObjectWrapperHandler mapped with JavaEventListener. >> 5. EventListenerManager also stores the JavaEventListener mapped with >> DOMWindow. >> 6. When Event listener explicitly removed , JavaEventListener is being >> forwarded to EventListenerManager to clear the listener. >> 7. When WebView goes out of scope, EventListenerManager will de-registered >> all the event listeners based on the ref counts attached with WebView >> DOMWindow. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > Adingef else block to unregisterListener LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/799
Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]
On Wed, 25 May 2022 10:10:08 GMT, Jay Bhaskar wrote:
>> This PR is new implementation of JavaEvent listener memory management.
>> Issue
>> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1)
>>
>> 1. Calling remove event listener does not free jni global references.
>> 2. When WebView goes out of scope (disposed from app) , its Event Listeners
>> are not being garbage collected.
>>
>> Solution:
>> 1. Detached the jni global reference from JavaEventListener.
>> 2. Create scoped ref counted wrapper class JavaObjectWrapperHandler for jni
>> global reference.
>> 3. Create unique JavaObjectWrapperHandler object for each JavaEventListener.
>> 4. EventListenerManager is a singleton class , which stores the
>> JavaObjectWrapperHandler mapped with JavaEventListener.
>> 5. EventListenerManager also stores the JavaEventListener mapped with
>> DOMWindow.
>> 6. When Event listener explicitly removed , JavaEventListener is being
>> forwarded to EventListenerManager to clear the listener.
>> 7. When WebView goes out of scope, EventListenerManager will de-registered
>> all the event listeners based on the ref counts attached with WebView
>> DOMWindow.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments applied
My review is not complete. I shall continue later. Providing few comments for
now.
Please take a look.
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
line 34:
> 32: EventListenerManager& EventListenerManager::get_instance()
> 33: {
> 34: static NeverDestroyed sharedManager;
This does behave well as a singleton class. But I think the instance should be
class member variable or a pointer.
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
line 38:
> 36: }
> 37:
> 38: EventListenerManager::EventListenerManager() { }
Empty constructor. Can be moved to .h file.
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
line 52:
> 50: it = listener_lists.find(ptr);
> 51: JNIEnv *env = nullptr;
> 52: env = JavaScriptCore_GetJavaEnv();
env seems unused. should be removed.
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
line 109:
> 107: isReferringToOtherListener = false;
> 108: else
> 109: isReferringToOtherListener = true;
I have not looked very clearly, but here is a question: Should the loop break
when `if` condition passes ?
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
line 115:
> 113: if (window == win_it->second)
> 114:windowHasEvent.erase(win_it->first);
> 115: }
I would change the code to be something like:
if (!isReferringToOtherListener) {
for (win_it = windowHasEvent.begin(); win_it != windowHasEvent.end();
win_it++) {
if (window == win_it->second)
windowHasEvent.erase(win_it->first);
}
}
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.h
line 36:
> 34: #include
> 35: #include
> 36: #include
minor: Add space after `#include`, on line 34, 36.
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.h
line 79:
> 77:
> 78: private:
> 79: EventListenerManager();
I would recommend to move it in previous private block. (line 65, 66)
modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaEventListener.cpp
line 50:
> 48: ? static_cast JavaEventListener*>()
> 49: : nullptr;
> 50: return jother && (this == jother);
`this` will never be null so the statement can be changed to: `return this ==
jother;`
modules/javafx.web/src/main/native/Source/WebCore/dom/Node.cpp line 2151:
> 2149: #if PLATFORM(JAVA)
> 2150:
> EventListenerManager::get_instance().registerDOMWindow(targetNode->document().domWindow(),
> 2151: static_cast
> (().get()));
minor: Alignment correction, should move few spaces to left.
-
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/799
Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >> order. >> >> The fix also works for: >> https://bugs.openjdk.java.net/browse/JDK-8269429 >> >> But this one might need another fix: >> https://bugs.openjdk.java.net/browse/JDK-8240640 > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Revert "Set the focus on the latest window when re-enabling them" > > This reverts commit b024de586c187f9000f791dab99507a4979cc027. Marked as reviewed by arapte (Reviewer). The fix look good to me. The other behavior is observed on mac but not on windows. The platform behavior itself looks different. Not sure if should be captured in a JBS (at least for documentation purpose) - PR: https://git.openjdk.java.net/jfx/pull/784
Re: RFR: 8283869: Update attribution in webkit.md file
On Tue, 10 May 2022 16:37:57 GMT, Kevin Rushforth wrote: > Doc-only change to update the license attribution in our `webkit.md` file. LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/793
Re: RFR: 8284654: Modal behavior returns to wrong stage [v2]
On Mon, 9 May 2022 14:54:55 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >> order. >> >> The fix also works for: >> https://bugs.openjdk.java.net/browse/JDK-8269429 >> >> But this one might need another fix: >> https://bugs.openjdk.java.net/browse/JDK-8240640 > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Set the focus on the latest window when re-enabling them The original fix gets affected by the new commit. Now, after closing dialog the focus always returns only to the stage that was created later. 1. Run the sample attached to [JDK-8284654](https://bugs.openjdk.java.net/browse/JDK-8284654). 2. Click button One and Two both once in order 3. Re-arrange both the windows such that they are visible. 4. Click the button "Click here" in Window One: Error dialog will be displayed 5. Close the Error dialog => Window Two gets focused but Window One should gets focused. => This worked correctly before the latest commit. - PR: https://git.openjdk.java.net/jfx/pull/784
Re: RFR: 8284654: Modal behavior returns to wrong stage
On Fri, 6 May 2022 13:37:22 GMT, Thiago Milczarek Sayao wrote: > Did you test it on Linux? I tested it on MacOS Catalina 10.15.7 > the window should not accept focus when disabled, The window does not really gets the focus. The button cannot be clicked. but it does bring the window in foreground. Yes, It may be a different bug. The similarity is that the focus does not go back to parent stage after closing the dialog. - PR: https://git.openjdk.java.net/jfx/pull/784
Re: RFR: 8284654: Modal behavior returns to wrong stage
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao wrote: > When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee > order. > > The fix also works for: > https://bugs.openjdk.java.net/browse/JDK-8269429 > > But this one might need another fix: > https://bugs.openjdk.java.net/browse/JDK-8240640 This change fixes the exact issue that is reported in [JDK-8284654](https://bugs.openjdk.java.net/browse/JDK-8284654). But I observed another issue that occurs with this change. Steps: 1. Run the sample attached to [JDK-8284654](https://bugs.openjdk.java.net/browse/JDK-8284654). 2. Click button One and Two both once 3. Re-arrange both the windows such that they are visible. 4. Click the button "Click here" in Window Two: Error dialog will be displayed 5. Click anywhere in Window One 6. Close the Error dialog => Observe that Window One gets the focus and not Window Two. I think the expected behavior here should be: After closing a dialog the Focus should return to its parent window. - PR: https://git.openjdk.java.net/jfx/pull/784
Re: [jfx11u] RFR: 8274274: Update JUnit to version 5.8.1
On Sat, 30 Apr 2022 13:45:39 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u`. It isn't a clean backport since the > mainline patch updated `gradle/verification-metadata.xml`, which doesn't > exist in 11. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/97
Re: [jfx11u] RFR: 8281564: Update cmake to 3.22.3
On Sat, 30 Apr 2022 13:39:32 GMT, Kevin Rushforth wrote: > Simple backport to `jfx11u`. It isn't a clean backport since the mainline > patch had an update to `gradle/verification-metadata.xml`, which doesn't > exist in 11. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/95
[jfx17u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
Reviewed-by: kcr, arapte - Commit messages: - 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Changes: https://git.openjdk.java.net/jfx17u/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=51=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284184 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx17u/pull/51.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/51/head:pull/51 PR: https://git.openjdk.java.net/jfx17u/pull/51
[jfx17u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
On Mon, 2 May 2022 11:48:02 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 13ca8ee8 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/13ca8ee891486b17551f55ef93532a703de37c3e Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Backport-of: 64da125f05f2a25038ce3370c8fe7c0baf0a354b - PR: https://git.openjdk.java.net/jfx17u/pull/51
[jfx17u] Integrated: 8270867: Debug build of WebKit 613.1 fails on Linux
On Fri, 29 Apr 2022 17:14:21 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, jbhaskar This pull request has now been integrated. Changeset: 367f3d5a Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/367f3d5a8227aeb83af5fbc646329c860ca0fcdc Stats: 142 lines in 2 files changed: 1 ins; 141 del; 0 mod 8270867: Debug build of WebKit 613.1 fails on Linux Backport-of: eb7fa5dd1c0911bca15576060691d884d29895a1 - PR: https://git.openjdk.java.net/jfx17u/pull/48
[jfx17u] Integrated: 8280020: Underline and line-through not straight in WebView
On Fri, 29 Apr 2022 17:10:09 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 8e52c7be Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/8e52c7bee8cd4e5aa83a6ea33572cd41026f9776 Stats: 192 lines in 2 files changed: 182 ins; 2 del; 8 mod 8280020: Underline and line-through not straight in WebView Backport-of: 263db3df5fdf9e0f6955be6ae58173aa589e55fe - PR: https://git.openjdk.java.net/jfx17u/pull/47
[jfx17u] Integrated: 8269115: WebView paste event contains old data
On Fri, 29 Apr 2022 17:08:56 GMT, Ambarish Rapte wrote: > Reviewed-by: arapte, kcr This pull request has now been integrated. Changeset: cc835ba1 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/cc835ba1fe0a135e82c6e6461f67e3ff56cf7b37 Stats: 120 lines in 3 files changed: 108 ins; 3 del; 9 mod 8269115: WebView paste event contains old data Backport-of: 2338821bdbb7db929a89aa89903271dcff333a5c - PR: https://git.openjdk.java.net/jfx17u/pull/46
[jfx17u] Integrated: 8255940: localStorage is null after window.close()
On Fri, 29 Apr 2022 17:07:27 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: ca7303ce Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/ca7303ce40e38848a7e606b940f376e979f6e187 Stats: 168 lines in 4 files changed: 167 ins; 0 del; 1 mod 8255940: localStorage is null after window.close() Backport-of: 5112be957be70dd6521e6fb6ee64e669c148729c - PR: https://git.openjdk.java.net/jfx17u/pull/45
[jfx17u] Integrated: 8278759: PointerEvent: buttons property set to 0 when mouse down
On Fri, 29 Apr 2022 17:06:02 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: dd592f13 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/dd592f13ca63abc1691b8eeff01bb03abf6ca6dc Stats: 302 lines in 8 files changed: 293 ins; 1 del; 8 mod 8278759: PointerEvent: buttons property set to 0 when mouse down Backport-of: 2e8a4a5e97bb88a5807ae5fe075b98e1d54a4ca0 - PR: https://git.openjdk.java.net/jfx17u/pull/44
[jfx17u] Integrated: 8282134: Certain regex can cause a JS trap in WebView
On Fri, 29 Apr 2022 17:04:44 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 350fb532 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/350fb53261e2d51be4ba25f538ad127aa16f6471 Stats: 22 lines in 3 files changed: 21 ins; 0 del; 1 mod 8282134: Certain regex can cause a JS trap in WebView Backport-of: 73963960dc6e56fe34d7aa5fb4ce6f6d2f07acc5 - PR: https://git.openjdk.java.net/jfx17u/pull/43
[jfx17u] Integrated: 8280841: Update SQLite to 3.37.2
On Fri, 29 Apr 2022 16:59:33 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: e05362c9 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx17u/commit/e05362c9b81c91450cf928304ea3c2aefd71017a Stats: 22902 lines in 5 files changed: 11655 ins; 3597 del; 7650 mod 8280841: Update SQLite to 3.37.2 Backport-of: 6b7b463cd2286658ad7d236824ded9b1020329e7 - PR: https://git.openjdk.java.net/jfx17u/pull/42
[jfx17u] RFR: 8255940: localStorage is null after window.close()
Reviewed-by: kcr, arapte - Commit messages: - 8255940: localStorage is null after window.close() Changes: https://git.openjdk.java.net/jfx17u/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=45=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255940 Stats: 168 lines in 4 files changed: 167 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx17u/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/45/head:pull/45 PR: https://git.openjdk.java.net/jfx17u/pull/45
[jfx17u] RFR: 8280020: Underline and line-through not straight in WebView
Reviewed-by: kcr, arapte - Commit messages: - 8280020: Underline and line-through not straight in WebView Changes: https://git.openjdk.java.net/jfx17u/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=47=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280020 Stats: 192 lines in 2 files changed: 182 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jfx17u/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/47/head:pull/47 PR: https://git.openjdk.java.net/jfx17u/pull/47
[jfx17u] RFR: 8269115: WebView paste event contains old data
Reviewed-by: arapte, kcr - Commit messages: - 8269115: WebView paste event contains old data Changes: https://git.openjdk.java.net/jfx17u/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=46=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269115 Stats: 120 lines in 3 files changed: 108 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jfx17u/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/46/head:pull/46 PR: https://git.openjdk.java.net/jfx17u/pull/46
[jfx17u] RFR: 8282134: Certain regex can cause a JS trap in WebView
Reviewed-by: kcr, arapte - Commit messages: - 8282134: Certain regex can cause a JS trap in WebView Changes: https://git.openjdk.java.net/jfx17u/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=43=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282134 Stats: 22 lines in 3 files changed: 21 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx17u/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/43/head:pull/43 PR: https://git.openjdk.java.net/jfx17u/pull/43
[jfx17u] RFR: 8278759: PointerEvent: buttons property set to 0 when mouse down
Reviewed-by: kcr, arapte - Commit messages: - 8278759: PointerEvent: buttons property set to 0 when mouse down Changes: https://git.openjdk.java.net/jfx17u/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=44=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278759 Stats: 302 lines in 8 files changed: 293 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jfx17u/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/44/head:pull/44 PR: https://git.openjdk.java.net/jfx17u/pull/44
[jfx17u] RFR: 8270867: Debug build of WebKit 613.1 fails on Linux
Reviewed-by: kcr, jbhaskar - Commit messages: - 8270867: Debug build of WebKit 613.1 fails on Linux Changes: https://git.openjdk.java.net/jfx17u/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=48=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270867 Stats: 142 lines in 2 files changed: 1 ins; 141 del; 0 mod Patch: https://git.openjdk.java.net/jfx17u/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/48/head:pull/48 PR: https://git.openjdk.java.net/jfx17u/pull/48
[jfx17u] RFR: 8280841: Update SQLite to 3.37.2
Reviewed-by: kcr, arapte - Commit messages: - 8280841: Update SQLite to 3.37.2 Changes: https://git.openjdk.java.net/jfx17u/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=42=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280841 Stats: 22902 lines in 5 files changed: 11655 ins; 3597 del; 7650 mod Patch: https://git.openjdk.java.net/jfx17u/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jfx17u pull/42/head:pull/42 PR: https://git.openjdk.java.net/jfx17u/pull/42
[jfx11u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
Reviewed-by: kcr, arapte - Commit messages: - 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Changes: https://git.openjdk.java.net/jfx11u/pull/92/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=92=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284184 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx11u/pull/92.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/92/head:pull/92 PR: https://git.openjdk.java.net/jfx11u/pull/92
[jfx11u] Integrated: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
On Thu, 28 Apr 2022 18:12:41 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: f8d4b48b Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/f8d4b48b03e2af4ec1f927448a4cf95303a29a9f Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ Backport-of: 64da125f05f2a25038ce3370c8fe7c0baf0a354b - PR: https://git.openjdk.java.net/jfx11u/pull/92
[jfx11u] Integrated: 8270867: Debug build of WebKit 613.1 fails on Linux
On Thu, 28 Apr 2022 17:52:40 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, jbhaskar This pull request has now been integrated. Changeset: 8706f989 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/8706f9893a0acd3c07a7f5574e77badeb05deed3 Stats: 142 lines in 2 files changed: 1 ins; 141 del; 0 mod 8270867: Debug build of WebKit 613.1 fails on Linux Backport-of: eb7fa5dd1c0911bca15576060691d884d29895a1 - PR: https://git.openjdk.java.net/jfx11u/pull/91
[jfx11u] Integrated: 8269115: WebView paste event contains old data
On Thu, 28 Apr 2022 17:48:23 GMT, Ambarish Rapte wrote: > Reviewed-by: arapte, kcr This pull request has now been integrated. Changeset: 567685c9 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/567685c9c7bf7d8d779701c6709856be328c1cd4 Stats: 120 lines in 3 files changed: 108 ins; 3 del; 9 mod 8269115: WebView paste event contains old data Backport-of: 2338821bdbb7db929a89aa89903271dcff333a5c - PR: https://git.openjdk.java.net/jfx11u/pull/89
[jfx11u] Integrated: 8280020: Underline and line-through not straight in WebView
On Thu, 28 Apr 2022 17:50:08 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 104e7b67 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/104e7b67ed7714cd3c5849d5012f5877ef2f57dc Stats: 192 lines in 2 files changed: 182 ins; 2 del; 8 mod 8280020: Underline and line-through not straight in WebView Backport-of: 263db3df5fdf9e0f6955be6ae58173aa589e55fe - PR: https://git.openjdk.java.net/jfx11u/pull/90
[jfx11u] Integrated: 8255940: localStorage is null after window.close()
On Thu, 28 Apr 2022 17:46:45 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 57e4c94a Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/57e4c94a0bc1a47d2381e86275a7d8a53ce4ce5e Stats: 168 lines in 4 files changed: 167 ins; 0 del; 1 mod 8255940: localStorage is null after window.close() Backport-of: 5112be957be70dd6521e6fb6ee64e669c148729c - PR: https://git.openjdk.java.net/jfx11u/pull/88
[jfx11u] Integrated: 8278759: PointerEvent: buttons property set to 0 when mouse down
On Thu, 28 Apr 2022 17:16:40 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: c2c62ff4 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/c2c62ff459edded8284c09307fb6d709b54aebef Stats: 302 lines in 8 files changed: 293 ins; 1 del; 8 mod 8278759: PointerEvent: buttons property set to 0 when mouse down Backport-of: 2e8a4a5e97bb88a5807ae5fe075b98e1d54a4ca0 - PR: https://git.openjdk.java.net/jfx11u/pull/87
[jfx11u] Integrated: 8282134: Certain regex can cause a JS trap in WebView
On Thu, 28 Apr 2022 17:13:19 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 3cfee273 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/3cfee27342f3b1fc1b8533823f50ebd9660955e4 Stats: 22 lines in 3 files changed: 21 ins; 0 del; 1 mod 8282134: Certain regex can cause a JS trap in WebView Backport-of: 73963960dc6e56fe34d7aa5fb4ce6f6d2f07acc5 - PR: https://git.openjdk.java.net/jfx11u/pull/86
[jfx11u] RFR: 8280020: Underline and line-through not straight in WebView
Reviewed-by: kcr, arapte - Commit messages: - 8280020: Underline and line-through not straight in WebView Changes: https://git.openjdk.java.net/jfx11u/pull/90/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=90=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280020 Stats: 192 lines in 2 files changed: 182 ins; 2 del; 8 mod Patch: https://git.openjdk.java.net/jfx11u/pull/90.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/90/head:pull/90 PR: https://git.openjdk.java.net/jfx11u/pull/90
[jfx11u] Integrated: 8280841: Update SQLite to 3.37.2
On Thu, 28 Apr 2022 17:04:37 GMT, Ambarish Rapte wrote: > Reviewed-by: kcr, arapte This pull request has now been integrated. Changeset: 6fe09f46 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx11u/commit/6fe09f4618a6767d323f4c490014a7eea6756da8 Stats: 22902 lines in 5 files changed: 11655 ins; 3597 del; 7650 mod 8280841: Update SQLite to 3.37.2 Backport-of: 6b7b463cd2286658ad7d236824ded9b1020329e7 - PR: https://git.openjdk.java.net/jfx11u/pull/85
[jfx11u] RFR: 8270867: Debug build of WebKit 613.1 fails on Linux
Reviewed-by: kcr, jbhaskar - Commit messages: - 8270867: Debug build of WebKit 613.1 fails on Linux Changes: https://git.openjdk.java.net/jfx11u/pull/91/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=91=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270867 Stats: 142 lines in 2 files changed: 1 ins; 141 del; 0 mod Patch: https://git.openjdk.java.net/jfx11u/pull/91.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/91/head:pull/91 PR: https://git.openjdk.java.net/jfx11u/pull/91
[jfx11u] RFR: 8255940: localStorage is null after window.close()
Reviewed-by: kcr, arapte - Commit messages: - 8255940: localStorage is null after window.close() Changes: https://git.openjdk.java.net/jfx11u/pull/88/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=88=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255940 Stats: 168 lines in 4 files changed: 167 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx11u/pull/88.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/88/head:pull/88 PR: https://git.openjdk.java.net/jfx11u/pull/88
[jfx11u] RFR: 8269115: WebView paste event contains old data
Reviewed-by: arapte, kcr - Commit messages: - 8269115: WebView paste event contains old data Changes: https://git.openjdk.java.net/jfx11u/pull/89/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=89=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269115 Stats: 120 lines in 3 files changed: 108 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/jfx11u/pull/89.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/89/head:pull/89 PR: https://git.openjdk.java.net/jfx11u/pull/89
[jfx11u] RFR: 8278759: PointerEvent: buttons property set to 0 when mouse down
Reviewed-by: kcr, arapte - Commit messages: - 8278759: PointerEvent: buttons property set to 0 when mouse down Changes: https://git.openjdk.java.net/jfx11u/pull/87/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=87=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278759 Stats: 302 lines in 8 files changed: 293 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jfx11u/pull/87.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/87/head:pull/87 PR: https://git.openjdk.java.net/jfx11u/pull/87
[jfx11u] RFR: 8282134: Certain regex can cause a JS trap in WebView
Reviewed-by: kcr, arapte - Commit messages: - 8282134: Certain regex can cause a JS trap in WebView Changes: https://git.openjdk.java.net/jfx11u/pull/86/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=86=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282134 Stats: 22 lines in 3 files changed: 21 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx11u/pull/86.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/86/head:pull/86 PR: https://git.openjdk.java.net/jfx11u/pull/86
[jfx11u] RFR: 8280841: Update SQLite to 3.37.2
Reviewed-by: kcr, arapte - Commit messages: - 8280841: Update SQLite to 3.37.2 Changes: https://git.openjdk.java.net/jfx11u/pull/85/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=85=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280841 Stats: 22902 lines in 5 files changed: 11655 ins; 3597 del; 7650 mod Patch: https://git.openjdk.java.net/jfx11u/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/85/head:pull/85 PR: https://git.openjdk.java.net/jfx11u/pull/85
Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests [v2]
On Fri, 22 Apr 2022 07:30:25 GMT, Ajit Ghaisas wrote: >> This PR is to cleanup a few `javafx.controls` unit tests that were ignored. >> >> Here is the list of targeted unit test classes- >> - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, >> `PaginationTest` >> - Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest` >> >> Results of `javafx.controls` unit tests- >> **Before this PR :** >> Total tests - 8610 >> Failures - 0 >> Ignored - 246 >> >> **After this PR :** >> Total tests - 8608 >> Failures - 0 >> Ignored - 235 > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > address review comments LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/780
Re: RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests
On Thu, 21 Apr 2022 11:23:35 GMT, Ajit Ghaisas wrote: > This PR is to cleanup a few `javafx.controls` unit tests that were ignored. > > Here is the list of targeted unit test classes- > - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, > `PaginationTest` > - Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest` > > Results of `javafx.controls` unit tests- > **Before this PR :** > Total tests - 8610 > Failures - 0 > Ignored - 246 > > **After this PR :** > Total tests - 8608 > Failures - 0 > Ignored - 235 Looks good to me, Providing minor suggestions. modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 387: > 385: cell.requestFocus(); > 386: Toolkit.getToolkit().firePulse(); > 387: Minor: Optional: Adding `assertTrue(cell.isEditing());` here can be a good sanity check. But I leave it to you. Similar comment for the change in `DateCellTest.loseFocusWhileEditing()` modules/javafx.controls/src/test/java/test/javafx/scene/control/CellTest.java line 392: > 390: > 391: assertFalse(cell.isEditing()); > 392: } I would recommend to call `stage.hide()` similar to that in the `@AfterClass cleanup` methods. Similar comment for the change in `DateCellTest.loseFocusWhileEditing()` - Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/780
Integrated: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows
On Thu, 21 Apr 2022 15:44:57 GMT, Ambarish Rapte wrote: > The test ServiceTest.testManyServicesRunConcurrently fails intermittently on > Windows platform with a time out error. > Test needs to be skipped until fixed. This pull request has now been integrated. Changeset: 5a023bd8 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/5a023bd8d15a0e70336bad96efa39e24a07679da Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/783
Integrated: 8282449: Intermittent OOM error in PredefinedMeshManagerTest
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for > [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). > The attributes of Sphere and Cylinder were chosen such that their hash code > would collide. The large number of divisions results in creating large sized > triangle mesh and sometimes cause OOM. > > The fix: is to use different combination of hashcode colliding attributes > with smaller number of divisions to avoid OOM. > > There are two commits in the PR: > 1. [First > commit](https://github.com/openjdk/jfx/commit/1ff6054503f5042f9ede54faac6fa00ec4369612) > contains the source changes with which test should fail. Only > `sphereCacheTest` fails with this commit but not the `cylinderCacheTest`. The > earlier combination of Cylinder attributes also does NOT fail. > 2. [Second > commit](https://github.com/openjdk/jfx/commit/0c8649abe94ef2b526007c37fab6910315a98654) > reverts the source code changes. This pull request has now been integrated. Changeset: 7ddcb8bd Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/7ddcb8bdf8549c3c140b8697c781eb294ea2b0dc Stats: 9 lines in 1 file changed: 0 ins; 3 del; 6 mod 8282449: Intermittent OOM error in PredefinedMeshManagerTest Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/782
RFR: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows
The test ServiceTest.testManyServicesRunConcurrently fails intermittently on Windows platform with a time out error. Test needs to be skipped until fixed. - Commit messages: - skip-test Changes: https://git.openjdk.java.net/jfx/pull/783/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=783=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285034 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/783.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/783/head:pull/783 PR: https://git.openjdk.java.net/jfx/pull/783
RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest
This is a test only fix. The tests used to create Sphere and Cylinder of large divisions, which could fail intermittently with OOM. The tests were added along with the fix for [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). The attributes of Sphere and Cylinder were chosen such that their hash code would collide. The large number of divisions results in creating large sized triangle mesh and sometimes cause OOM. The fix: is to use different combination of hashcode colliding attributes with smaller number of divisions to avoid OOM. There are two commits in the PR: 1. [First commit](https://github.com/openjdk/jfx/commit/1ff6054503f5042f9ede54faac6fa00ec4369612) contains the source changes with which test should fail. Only `sphereCacheTest` fails with this commit but not the `cylinderCacheTest`. The earlier combination of Cylinder attributes also does NOT fail. 2. [Second commit](https://github.com/openjdk/jfx/commit/0c8649abe94ef2b526007c37fab6910315a98654) reverts the source code changes. - Commit messages: - revert temp source changes - commit with source changes where test fails Changes: https://git.openjdk.java.net/jfx/pull/782/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=782=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282449 Stats: 9 lines in 1 file changed: 0 ins; 3 del; 6 mod Patch: https://git.openjdk.java.net/jfx/pull/782.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/782/head:pull/782 PR: https://git.openjdk.java.net/jfx/pull/782
Re: RFR: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8
On Fri, 11 Mar 2022 03:01:39 GMT, Alexander Matveev wrote: > - Problem was that our code which checks if URI ends with file extension was > not considering that URI can have query parameters. Fixed by checking URI > path, instead of actual URI. > - Also, creation of HLS Connection holder was missing checking for mimetype, > since we do support URI without extensions as long as they provide correct > mimetype. > - Added #EXTM3U to file signature check in case if extension and mimetype > checks failed to determine stream type. All playlists of HLS based on spec > should start with #EXTM3U. For some reason this particular stream has > mimetype of "audio/x-mpegurl" and it is not mimetype from spec. Based on spec > it should be "audio/mpegurl". Thus check for signature was added in case if > URI does not use extension and has unsupported mimetype. > > Note: audio will not work on Windows and Linux for stream provided in this > bug report due to provided example uses separate audio stream via EXT-X-MEDIA > tag and it is not supported. I filed separate issue for this. Tested on windows. lgtm. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/750
Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > check length of DashArray Looks safe and minimal change. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/765
Integrated: 8281564: Update cmake to 3.22.3
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. This pull request has now been integrated. Changeset: d960d639 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/d960d639dc6e37de0cdb69075a31a17090b83a3d Stats: 10 lines in 2 files changed: 0 ins; 0 del; 10 mod 8281564: Update cmake to 3.22.3 Reviewed-by: kcr, jvos - PR: https://git.openjdk.java.net/jfx/pull/767
Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and WebKit. lgtm. Verified build and sanity test. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/766
RFR: 8281564: Update cmake to 3.22.3
Update cmake to 3.22.3 Verified build on all three platforms. The sanity test looks good. - Commit messages: - cmake-update Changes: https://git.openjdk.java.net/jfx/pull/767/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=767=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281564 Stats: 10 lines in 2 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/767.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/767/head:pull/767 PR: https://git.openjdk.java.net/jfx/pull/767
Re: RFR: 8283328: Update libxml2 to 2.9.13 [v2]
On Fri, 1 Apr 2022 08:19:28 GMT, Hima Bindu Meda wrote: >> We currently use libxml2 version 2.9.12. It should be updated to latest >> stable release, which is version 2.9.13. >> The steps to update libxml are documented in UPDATING.txt. >> There is compilation issue with the release 2.9.13, as mentioned here: >> https://gitlab.gnome.org/GNOME/libxml2/-/issues/349. >> Updated the code with the changes as per the fix mentioned in above link. >> >> Compiled and verified on Windows, Mac and Linux platforms. >> Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Add README.md and update libxml2.md Looks good, tested Mac M1 build and macos sanity check. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/764
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Build on Ubuntu 20.04 looked fine to me. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283402: Update to gcc 11.2 on Linux
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. I shall do a test build and update. - PR: https://git.openjdk.java.net/jfx/pull/761
Re: RFR: 8283517: Update boot JDK to 18
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update > gradle at this time. > > I have done a full set of tests on all three platforms. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/760
Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, since decoder >> cannot handle AAC elementary streams directly. DirectShow decoder works >> without it. >> - DirectShow H.264 decoder on Windows and H.265/H.264 decoder on Linux will >> be reloaded when fMP4 stream changes resolution. Dynamic format change did >> not worked for these streams on Windows and Linux. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3] Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/726
Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v10]
On Tue, 8 Mar 2022 20:32:53 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window = activeWindows.get(activeWindows.size() - 1);
>> window.setIconified(false);
>> window.requestToFront();
>> window.requestFocus();
>> }
>>
>>
>> **glass_window.cpp**
>>
>> void WindowContextBase::process_focus(GdkEventFocus* event) {
>>...
>>
>> if (jwindow) {
>> if (!event->in || isEnabled()) {
>> mainEnv->CallVoidMethod(jwindow, jWindowNotifyFocus,
>> event->in ?
>> com_sun_glass_events_WindowEvent_FOCUS_GAINED :
>> com_sun_glass_events_WindowEvent_FOCUS_LOST);
>> CHECK_JNI_EXCEPTION(mainEnv)
>> } else {
>> mainEnv->CallVoidMethod(jwindow, jWindowNotifyFocusDisabled);
>> CHECK_JNI_EXCEPTION(mainEnv)
>> }
>> }
>> }
>>
>>
>> So `glass_window.cpp` was triggering `jWindowNotifyFocusDisabled` which
>> triggered the java code on the Primary Stage (on the bug reproduce code).
>>
>> The docs states:
>>
>> /**
>> * Enables or disables the window.
>> *
>> * A disabled window is unfocusable by definition.
>> * Also, key or mouse events aren't generated for disabled windows.
>> *
>> * When a user tries to activate a disabled window, or the window gets
>> * accidentally brought to the top of the stacking order, the window
>> * generates the FOCUS_DISABLED window event. A Glass client should react
>> * to this event and bring the currently active modal blocker of the
>> * disabled window to top by calling blocker's minimize(false),
>> toFront(),
>> * and requestFocus() methods. It may also 'blink' the blocker window to
>> * further attract user's attention.
>> *
>> .
>>
>>
>> So I guess the C++ side looks ok, java side on `handleFocusDisabled` I did
>> not understand why it `requestToFront` and `requestFocus` on the latest
>> window.
>>
>> The solution makes disabled windows unfocusable and prevents mouse and
>> keyboard events as the docs states, making it compatible with other
>> platforms.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review adjustments
Marked as reviewed by arapte (Reviewer).
-
PR: https://git.openjdk.java.net/jfx/pull/598
Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window = activeWindows.get(activeWindows.size() - 1);
>> window.setIconified(false);
>> window.requestToFront();
>> window.requestFocus();
>> }
>>
>>
>> **glass_window.cpp**
>>
>> void WindowContextBase::process_focus(GdkEventFocus* event) {
>>...
>>
>> if (jwindow) {
>> if (!event->in || isEnabled()) {
>> mainEnv->CallVoidMethod(jwindow, jWindowNotifyFocus,
>> event->in ?
>> com_sun_glass_events_WindowEvent_FOCUS_GAINED :
>> com_sun_glass_events_WindowEvent_FOCUS_LOST);
>> CHECK_JNI_EXCEPTION(mainEnv)
>> } else {
>> mainEnv->CallVoidMethod(jwindow, jWindowNotifyFocusDisabled);
>> CHECK_JNI_EXCEPTION(mainEnv)
>> }
>> }
>> }
>>
>>
>> So `glass_window.cpp` was triggering `jWindowNotifyFocusDisabled` which
>> triggered the java code on the Primary Stage (on the bug reproduce code).
>>
>> The docs states:
>>
>> /**
>> * Enables or disables the window.
>> *
>> * A disabled window is unfocusable by definition.
>> * Also, key or mouse events aren't generated for disabled windows.
>> *
>> * When a user tries to activate a disabled window, or the window gets
>> * accidentally brought to the top of the stacking order, the window
>> * generates the FOCUS_DISABLED window event. A Glass client should react
>> * to this event and bring the currently active modal blocker of the
>> * disabled window to top by calling blocker's minimize(false),
>> toFront(),
>> * and requestFocus() methods. It may also 'blink' the blocker window to
>> * further attract user's attention.
>> *
>> .
>>
>>
>> So I guess the C++ side looks ok, java side on `handleFocusDisabled` I did
>> not understand why it `requestToFront` and `requestFocus` on the latest
>> window.
>>
>> The solution makes disabled windows unfocusable and prevents mouse and
>> keyboard events as the docs states, making it compatible with other
>> platforms.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Capture event serial on process_key
The fix itself looks good. though I have a query. I did not observe any
mis-behaviour, so please check if the suggested change is required or not.
modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 780:
> 778: }
> 779:
> 780: event_serial = 0;
should we use GDK_CURRENT_TIME instead of 0 ?
GDK_CURRENT_TIME is defined also as 0 and represent current time.
modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1390:
> 1388: // prevents activeWindows on WindowStage.java to be out of
> order which may cause the FOCUS_DISABLED event
> 1389: // to bring up the wrong window (it brings up the last which
> will not be the real "last" if out of order).
> 1390: gtk_window_present_with_time(GTK_WINDOW(gtk_widget),
> event_serial);
`event_serial` is not reset after use. I could observe that a stale value of
`event_serial` gets reused several times.
Steps to observe the behavior:
1. Print event_serial in this method
2. Run the sample program attached to JBS.
3. Press the "Click Me!" button
4. Answer YES on the Alert
5. Three stages should be visible on the screen.
6. Relocate such that all stages are visible
7. Click on 'This should be on Top' Stage
8. Click on "This is a stage with no owner' stage.
9. Click on StageTest icon in Taskbar. Keep repeating this step. The stage
gains and looses focus and the same event_serial gets printed on terminal.
=> It does not look harmful behavior wise. But can observe that `event_serial`
gets reused.
Screenshot:
https://user-images.githubusercontent.com/11330676/157248115-61240f6c-1710-461e-ba60-08e6210774e7.png;>
Will it be good idea to reset it to 0/GDK_CURRENT_TIME and use something like,
if (event_serial == GDK_CURRENT_TIME) {
gtk_window_present(GTK_WINDOW(gtk_widget));
} else {
gtk_window_present_with_time(GTK_WINDOW(gtk_widget), event_serial);
event_serial = GDK_CURRENT_TIME;
}
OR
gtk_window_present_with_time(GTK_WINDOW(gtk_widget), event_serial);
event_serial = GDK_CURRENT_TIME;
-
PR: https://git.openjdk.java.net/jfx/pull/598
Re: RFR: 8280020: Underline and line-through not straight in WebView [v8]
On Mon, 7 Mar 2022 09:28:52 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add thickness to the y position of end point of line. >> Start Point(x,y) --End Point(x + width, 0) > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > formating for drawline Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/731
Re: RFR: 8269115: WebView paste event contains old data [v7]
On Fri, 4 Mar 2022 02:50:24 GMT, Jay Bhaskar wrote: >> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and >> appending mime types in pasteboard operation like setPlainText, Hence it >> will append duplicate mime types in m_availMimeTypes , in this case the >> length clipboardData.types would be wrong, and duplicates data would be >> copied to clipboard target. >> Solution: Use ListHashSet data Structure instead of Vector for >> m_availMimeTypes. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > removed automated test HTMLClipBoardTest.java, as manual test added looks good to me too. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/729
Re: RFR: 8255940: localStorage is null after window.close() [v9]
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) >> "User agents should expire data from the local storage areas only for >> security reasons or when requested to do so by the user. User agents should >> always avoid deleting data while a script that could access that data is >> running." > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > Added review change JAVA Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/703
Re: RFR: 8255940: localStorage is null after window.close() [v7]
On Tue, 1 Mar 2022 02:42:54 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>> spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/)
>> "User agents should expire data from the local storage areas only for
>> security reasons or when requested to do so by the user. User agents should
>> always avoid deleting data while a script that could access that data is
>> running."
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clean up test and fix
The fix looks good, suggesting a minor change in test and a change in
`DOMWindow.cpp`
The JavaFX specific changes in the shared code should be enclosed inside `#if
PLATFORM(JAVA)` macro.
modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 850:
> 848: return Exception { SecurityError };
> 849:
> 850: if (m_localStorage)
Let's enclose this change in `#if PLATFORM(JAVA)` macro. It makes easy to
identify Java platform specific changes and handle merging when updating WebKit.
modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
line 49:
> 47: import javafx.concurrent.Worker;
> 48: import javafx.scene.web.WebView;
> 49: import javafx.scene.web.WebEngine;
Several import statements can be removed. Only below imports are sufficient to
run the test, others can be removed.
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertNotNull;
import org.junit.AfterClass;
import org.junit.Test;
import java.io.File;
import java.io.IOException;
import javafx.scene.web.WebView;
import javafx.scene.web.WebEngine;
-
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/703
Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/77
Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/76
Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]
On Tue, 1 Mar 2022 06:19:04 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed only with javafx >> webView.Other browsers set the buttons property to 1, when there is mouse >> press or drag. >> The issue happens because the buttons property is not updated in the >> framework. >> Added implementation to update and propagate the buttons property from >> javafx platform to native webkit.Added a robot test case for the same. >>Performed sanity testing with the added implementation and the buttons >> property is compliant with the specification mentioned in >> https://w3c.github.io/pointerevents/#the-buttons-property. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > add stage show event listener Looks good to me, verified on Windows and Mac. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/742
Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Verified that the backport is clean. and there was no diff except copyright year. - PR: https://git.openjdk.java.net/jfx11u/pull/77
Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v3]
On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed only with javafx
>> webView.Other browsers set the buttons property to 1, when there is mouse
>> press or drag.
>> The issue happens because the buttons property is not updated in the
>> framework.
>> Added implementation to update and propagate the buttons property from
>> javafx platform to native webkit.Added a robot test case for the same.
>>Performed sanity testing with the added implementation and the buttons
>> property is compliant with the specification mentioned in
>> https://w3c.github.io/pointerevents/#the-buttons-property.
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Use ESC key so that the popup, if any, disappears
Fix itself looks good.
Suggesting some changes in the test.
tests/system/src/test/java/test/robot/javafx/web/PointerEventTest.java line 112:
> 110: webEngine = webView.getEngine();
> 111: String URL =
> this.getClass().getResource("pointerEvent.html").toString();
> 112: webEngine.load( URL);
Minor: `webEngine.load(URL);`
While you are at it, please remove the double spaces on line 111, 144
tests/system/src/test/java/test/robot/javafx/web/PointerEventTest.java line 113:
> 111: String URL =
> this.getClass().getResource("pointerEvent.html").toString();
> 112: webEngine.load( URL);
> 113:
> webView.getEngine().getLoadWorker().stateProperty().addListener((ov, o, n) ->
> {
The listener ideally should be added before calling `load()`. (before line 111)
tests/system/src/test/java/test/robot/javafx/web/PointerEventTest.java line 123:
> 121: stage.setScene(scene);
> 122: stage.setAlwaysOnTop(true);
> 123: Platform.runLater(startupLatch::countDown);
This latch countDown should be done when the stage is shown on the screen.
It should be: `stage.setOnShown(e -> { Platform.runLater(() ->
startupLatch.countDown()); });`
-
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/742
Re: RFR: 8269115: WebView paste event contains old data
On Tue, 8 Feb 2022 11:13:20 GMT, Jay Bhaskar wrote: > Issue: The DataObject uses m_availMimeTypes as Vector of strings, and > appending mime types in pasteboard operation like setPlainText, Hence it will > append duplicate mime types in m_availMimeTypes , in this case the length > clipboardData.types would be wrong, and duplicates data would be copied to > clipboard target. > Solution: Use ListHashSet data Structure instead of Vector for > m_availMimeTypes. The fix itself looks good. Suggested few minor changes. Regarding test: Observed that the test does not fail without this fix. Please recheck. Also, I would recommend to add new tests to test the behavior mentioned in JBS, and modify any pre-existing tests if they now become invalid with fix. modules/javafx.web/src/main/native/Source/WebCore/platform/java/DataObjectJava.h line 133: > 131: Vector types; > 132: types.appendRange(m_availMimeTypes.begin(), > m_availMimeTypes.end()); > 133: //returns MIME Types available in clipboard.z Minor: The comment should be the first line in the method, as it was before this. The character z at the end must be unintended. modules/javafx.web/src/main/native/Source/WebCore/platform/java/PasteboardJava.cpp line 240: > 238: // TODO: setURL, setFiles, setData, setHtml (needs URL) > 239: data->setPlainText(jGetPlainText()); > 240: data->setData(DataObjectJava::mimeHTML(),jGetPlainText()); Minor: Please add a space after `,` modules/javafx.web/src/test/java/test/javafx/scene/web/HTMLEditingTest.java line 73: > 71: Clipboard.getSystemClipboard().setContent(content); > 72: > 73: The extra line is not required and would recommend to remove. - Changes requested by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/729
Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. This pull request has now been integrated. Changeset: 6f201f7a Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/6f201f7a02dba14328d183e7d0db5dede4416ce4 Stats: 186 lines in 11 files changed: 116 ins; 33 del; 37 mod 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2) Reviewed-by: kcr, jvos - PR: https://git.openjdk.java.net/jfx/pull/740
RFR: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)
Include additional stabilization fixes of WebKit 613.1 Sanity testing did not show any concerns. - Commit messages: - Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx/pull/740/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=740=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282099 Stats: 186 lines in 11 files changed: 116 ins; 33 del; 37 mod Patch: https://git.openjdk.java.net/jfx/pull/740.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/740/head:pull/740 PR: https://git.openjdk.java.net/jfx/pull/740
Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not available. The pull > request now contains one commit: > > 8282134: Certain regex can cause a JS trap in WebView Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/739
Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote: >> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can >> cause a JS trap in WebView > > Jay Bhaskar has refreshed the contents of this pull request, and previous > commits have been removed. Incremental views are not available. The pull > request now contains one commit: > > 8282134: Certain regex can cause a JS trap in WebView Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/739
Re: RFR: 8282134: Certain regex can cause a JS trap in WebView
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote: > Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can > cause a JS trap in WebView Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/739
Re: RFR: 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start
On Wed, 16 Feb 2022 16:46:47 GMT, Kevin Rushforth wrote:
> The `javafx.graphics` module has a number of native libraries, including the
> redistributable Microsoft DLLs on Windows. When running an application using
> the standalone JavaFX SDK, we load all of the needed DLLs from the SDK `bin`
> directory and everything works as expected.
>
> When creating the jmods, we currently exclude the Microsoft DLLs from
> `javafx.graphics.jmod` to avoid the problem described in
> [JDK-8207015](https://bugs.openjdk.java.net/browse/JDK-8207015) where `jlink`
> complains about two modules (`java.base` and `javafx.graphics`) deliver the
> same file(s). That works as long as the set of Microsoft DLLs delivered by
> the JDK is from the same or newer version of Microsoft Visual Studio. This
> means that you can't take, for example, JDK 11.0.x and run the latest version
> of JavaFX, since JDK 11.x uses VS 2017 and JavaFX 15 (and later) uses VS 2019.
>
> Up until now this has just been a minor bug, but we are now at the point
> where we need to update to VS 2019 for building JavaFX 11.0.15, which means
> that a jlinked JDK 11.0.X + JavaFX 11.0.15 will no longer work.
>
> This fix is to add the Microsoft DLLs back into `javafx.graphics.jmod` (i.e.,
> stop excluding them at build time), but deliver them in `bin/javafx` so they
> don't conflict with the ones delivered by the JDK.
>
> The changes are:
>
> 1. `build.gradle` - When creating the jmods on Windows, copy all of the DLLs
> to a javafx sub-directory
> 2. `NativeLibLoader.java` - in the case of JavaFX modules jlinked into the
> Java runtime, load the libraries first from `${java.home}` rather than always
> falling back to `System::loadLibrary`. Most of the changes are just simple
> refactoring. The additional logic is in the new `libDirForJRT` method.
>
> When running using the SDK or the modules on maven central, there is no
> change in behavior.
>
> I've tested this on all platforms, including a test of a custom JDK 11.x
> created with jlink. On a Windows I tested it on a system where a key VS 2019
> runtime library was not present in C:\Windows\System32 and it now runs.
Marked as reviewed by arapte (Reviewer).
-
PR: https://git.openjdk.java.net/jfx/pull/734
Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes
On Wed, 16 Feb 2022 08:07:35 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. This pull request has now been integrated. Changeset: 418d3437 Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/418d3437923fed0a298c48b54214af069e3bb3bd Stats: 1218 lines in 127 files changed: 767 ins; 169 del; 282 mod 8281711: Cherry-pick WebKit 613.1 stabilization fixes Stabilization fixes from WebKitGTK 2.34.5 Reviewed-by: jvos, kcr - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
On Wed, 16 Feb 2022 08:49:15 GMT, danielpeintner wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> correct unintentional change > > modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRetainPtr.h > line 9: > >> 7: * >> 8: * 1. Redistributions of source code must retain the above copyright >> 9: q * notice, this list of conditions and the following disclaimer. > > seems to be unintentional Thank you, It is corrected now. - PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes [v2]
> Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: correct unintentional change - Changes: - all: https://git.openjdk.java.net/jfx/pull/733/files - new: https://git.openjdk.java.net/jfx/pull/733/files/e58b3e38..a725f3dc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=733=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=733=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/733.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/733/head:pull/733 PR: https://git.openjdk.java.net/jfx/pull/733
RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes
Include additional stabilization fixes of WebKit 613.1 Sanity testing did not show any concerns. - Commit messages: - Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx/pull/733/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=733=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281711 Stats: 1219 lines in 127 files changed: 767 ins; 169 del; 283 mod Patch: https://git.openjdk.java.net/jfx/pull/733.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/733/head:pull/733 PR: https://git.openjdk.java.net/jfx/pull/733
Re: RFR: 8280841: Update SQLite to 3.37.2 [v3]
On Thu, 10 Feb 2022 05:56:47 GMT, Hima Bindu Meda wrote: >> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version >> 3.32.3. >> >> Website : https://www.sqlite.org/index.html >> Source code can be found from https://www.sqlite.org/download.html at >> [sqlite-amalgamation-3370200.zip](https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip) >> >> Verified the updated version with unit tests and sanity testing. >> No issues are observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Accomodated PR comments Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/727
Integrated: 8281459: WebKit 613.1 build broken on M1
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in this PR, now the file `MacroAssemblerARM64.h` matches > with the WebKit mainline. This pull request has now been integrated. Changeset: cdebc6cb Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/cdebc6cbafb579148b4addee44d307bd9739454b Stats: 20 lines in 1 file changed: 0 ins; 20 del; 0 mod 8281459: WebKit 613.1 build broken on M1 Reviewed-by: kcr, jvos - PR: https://git.openjdk.java.net/jfx/pull/730
RFR: 8281459: WebKit 613.1 build broken on M1
This seems like a bad merge issue. There were duplicate copies of four methods in `MacroAssemblerARM64.h` which caused WebKit build failure on Mac M1 machines. Just removing the methods removes the error. With the changes in this PR, now the file `MacroAssemblerARM64.h` matches with the WebKit mainline. - Commit messages: - MacOS M1 arch64 build error Changes: https://git.openjdk.java.net/jfx/pull/730/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=730=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281459 Stats: 20 lines in 1 file changed: 0 ins; 20 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/730.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/730/head:pull/730 PR: https://git.openjdk.java.net/jfx/pull/730
Re: RFR: 8280841: Update SQLite to 3.37.2
On Fri, 4 Feb 2022 12:53:51 GMT, Hima Bindu Meda wrote: > Updated SQLite to 3.37.2 released on 2022-01-06 from the current version > 3.32.3. > > Website : https://www.sqlite.org/index.html > Source code can be found from https://www.sqlite.org/download.html at > [sqlite-amalgamation-3370200.zip](https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip) > > Verified the updated version with unit tests and sanity testing. > No issues are observed. The source files match with https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip Sanity testing looks good. I would recommend to add UPDATING.txt to document the steps. You can refer: [libxml UPDATING.txt](https://github.com/openjdk/jfx/blob/f326e78ffdfcbbc9085bc50a38e0b4454b757157/modules/javafx.web/src/main/native/Source/ThirdParty/libxml/UPDATING.txt) , [icu UPDATING.txt](https://github.com/openjdk/jfx/blob/f326e78ffdfcbbc9085bc50a38e0b4454b757157/modules/javafx.web/src/main/native/Source/ThirdParty/icu/UPDATING.txt) - PR: https://git.openjdk.java.net/jfx/pull/727
Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `LightBase` >> since different light types share characteristics. `LightBase` now contains >> a summary of its subtypes and all the explanations of the >> properties/characteristics of the lights divided into sections: Color, >> Scope, Direction, Attenuation. >> * Each light type links to the relevant section in `LightBase` when it >> mentioned the properties it has. >> * Added examples of real-world applications for each light type. >> * Consolidated the writing style for all the subclasses. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Changed description of ambient light Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/717
Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]
On Sat, 8 Jan 2022 17:30:55 GMT, Michael Strauß wrote:
>> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype
>> specified for images encoded in data URIs. This should be improved as
>> follows:
>>
>> 1. If the specified image subtype is not supported, an exception will be
>> thrown.
>> 2. If the specified image subtype is supported, but the data contained in
>> the URI is of a different (but also supported) image format, the image will
>> be loaded and a warning will be logged. For example, if the MIME type is
>> "image/jpeg", but the image data is PNG, the following warning will be
>> generated:
>>
>>
>> Image format 'PNG' does not match MIME type 'image/jpeg' in URI
>> 'data:image/jpeg;base64,iVBORw0KGgoAAA...AAAElFTkSuQmCC'
>>
>>
>> Also, the javadoc of `javafx.scene.image.Image` incorrectly states:
>>
>> 94* If a URL uses the "data" scheme, the data must be base64-encoded
>> 95* and the MIME type must either be empty or a subtype of the
>> 96* {@code image} type.
>>
>> However, omitting the MIME type of a data URI is specified to imply
>> "text/plain" (RFC 2397, section 2). Since the `com.sun.javafx.util.DataURI`
>> class is implemented according to this specification, trying to load an
>> image without MIME type correctly fails with an `ImageStorageException`:
>> "Unexpected MIME type: text".
>>
>> The solution is to fix the documentation:
>>
>> 94* If a URL uses the "data" scheme, the data must be
>> base64-encoded
>> - 95* and the MIME type must either be empty or a subtype of the
>> - 96* {@code image} type.
>> + 95* and the MIME type must be a subtype of the {@code image} type.
>> + 96* The MIME type must match the image format of the data
>> contained in
>> + 97* the URL. In case of a mismatch between MIME type and image
>> format,
>> + 98* the image will be loaded if the image format can be determined
>> by
>> + 99* JavaFX, and a warning will be logged.
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Don't let EOFException bubble up
Marked as reviewed by arapte (Reviewer).
-
PR: https://git.openjdk.java.net/jfx/pull/676
Integrated: 8278980: Update WebKit to 613.1
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored using > [JDK-8280421](https://bugs.openjdk.java.net/browse/JDK-8280421) This pull request has now been integrated. Changeset: 6f28d912 Author:Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/6f28d912024495278c4c35ab054bc2aab480b3e4 Stats: 412962 lines in 6737 files changed: 231442 ins; 135635 del; 45885 mod 8278980: Update WebKit to 613.1 Co-authored-by: Ajit Ghaisas Co-authored-by: Jay Bhaskar Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, aghaisas - PR: https://git.openjdk.java.net/jfx/pull/723
Re: RFR: 8278980: Update WebKit to 613.1
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > You may have noticed ... The change file contains changes that are not > related to the WebKit upgrade. It looks like you're reverting to an older > version. Thanks for pointing it out. It is corrected now. Thanks @kevinrushforth for quick fix. - PR: https://git.openjdk.java.net/jfx/pull/723
Re: RFR: 8278980: Update WebKit to 613.1 [v2]
> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored using > [JDK-8280421](https://bugs.openjdk.java.net/browse/JDK-8280421) Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: Restore commits that were mistakenly reverted. 8279013: ES2Pipeline fails to detect AMD vega20 graphics card 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning 8277122: SplitPane divider drag can hang the layout - Changes: - all: https://git.openjdk.java.net/jfx/pull/723/files - new: https://git.openjdk.java.net/jfx/pull/723/files/b1cd88e7..ef730f84 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=723=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=723=00-01 Stats: 121 lines in 5 files changed: 112 ins; 1 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/723.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/723/head:pull/723 PR: https://git.openjdk.java.net/jfx/pull/723
RFR: 8278980: Update to 613.1 version of WebKit
Update JavaFX WebKit to GTK WebKit 2.34 (613.1). Verified the updated version build, tests run and sanity testing. This does not cause any issues except a unit test failure `IrresponsiveScriptTest`. It is recorded and ignored using [JDK-8280421](https://bugs.openjdk.java.net/browse/JDK-8280421) - Commit messages: - webkit update 613.1 Changes: https://git.openjdk.java.net/jfx/pull/723/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=723=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278980 Stats: 413083 lines in 6742 files changed: 231443 ins; 135747 del; 45893 mod Patch: https://git.openjdk.java.net/jfx/pull/723.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/723/head:pull/723 PR: https://git.openjdk.java.net/jfx/pull/723
Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote:
> Now that the standard concrete light types were added, there is an
> opportunity to rearrange and rewrite some of the class docs. Here is a
> summary of the changes:
>
> * Moved the explanations of attenuation and direction up to `LightBase` since
> different light types share characteristics. `LightBase` now contains a
> summary of its subtypes and all the explanations of the
> properties/characteristics of the lights divided into sections: Color, Scope,
> Direction, Attenuation.
> * Each light type links to the relevant section in `LightBase` when it
> mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
modules/javafx.graphics/src/main/java/javafx/scene/DirectionalLight.java line
46:
> 44: * {@code DirectionalLight}s can represent strong light sources that are
> far enough from the objects they illuminate
> 45: * that their light rays appear to be parallel. Because these light
> sources are considered to be infinitely far, they
> 46: * cannot be attenuated. The sun's light on Earth is a common light
> source that can be simulated with this light type.
The previous statement seems more suitable here:
`The Sun is a common light source that can be simulated with this light type.`
or little modified version of this new statement:
`The Sun light on Earth is a common type of light that can be simulated with
this light type.`
modules/javafx.graphics/src/main/java/javafx/scene/LightBase.java line 133:
> 131: *
> 132: * Direction
> 133: * The direction the light is facing, defined by the {@code direction}
> vector property of the light. The light's
The direction of the light is defined by the {@code direction} vector property
of the light
-
PR: https://git.openjdk.java.net/jfx/pull/717
Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses
On Tue, 25 Jan 2022 00:40:18 GMT, Kevin Rushforth wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of attenuation and direction up to `LightBase`
>> since different light types share characteristics. `LightBase` now contains
>> a summary of its subtypes and all the explanations of the
>> properties/characteristics of the lights divided into sections: Color,
>> Scope, Direction, Attenuation.
>> * Each light type links to the relevant section in `LightBase` when it
>> mentioned the properties it has.
>> * Added examples of real-world applications for each light type.
>> * Consolidated the writing style for all the subclasses.
>
> modules/javafx.graphics/src/main/java/javafx/scene/AmbientLight.java line 37:
>
>> 35: *
>> 36: * {@code AmbientLight}s can represent strong light sources in an
>> enclosed area where the lights bounces from many
>> 37: * objects, causing them to be illuminated from many directions. A
>> strong light in a room and moonlight are common light
>
>> A strong light in a room ...
>
> I think this is OK, as long as a reader doesn't think of an overhead light in
> a room, which also has the properties of a point light.
Ambient light is a light that comes from all directions, scattered from
different surfaces and it does not cast shadow. So I think the example of
strong light and moon light should be avoided. Moon light is more like the Sun
light, a directional light.
-
PR: https://git.openjdk.java.net/jfx/pull/717
Re: [jfx18] RFR: 8280280: Update boot JDK to 17.0.2
On Wed, 19 Jan 2022 18:43:31 GMT, Kevin Rushforth wrote: > JDK 17.0.2 shipped yesterday as part of the January CPU release. We should > update the JavaFX 18 build to use that version, so this is targeted for > `jfx18`. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/721
Re: RFR: 8279615: Change JavaFX release version to 19
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2021 at 16:00 UTC. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/707
Re: RFR: 8279396: Define version in .jcheck/conf
On Tue, 4 Jan 2022 13:09:33 GMT, Kevin Rushforth wrote: > This patch adds the version property to `.jcheck/conf`. By doing this we can > remove the corresponding configuration from the Skara bots, which in turn > reduces the need for timing and general complexity of starting a new JavaFX > release. See openjdk/jdk#6929 for the similar PR for the `jdk` repo. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/706
Re: RFR: 8234921: Add DirectionalLight to the selection of 3D light types [v6]
On Mon, 20 Dec 2021 13:13:09 GMT, Nir Lisker wrote: >> Adds a directional light as a subclass of `LightBase`. I think that this is >> the correct hierarchy for it. >> >> I tried to simulate a directional light by putting a point light far away, >> but I got artifacts when the distance was large. Instead, I added an on/off >> attenuation flag as the 4th component of the attenuation 4-vector. When it >> is 0, a simpler computation is used in the pixel/fragment shader that >> calculates the illumination based on the light direction only (making the >> position variables meaningless). When it is 1, the point/spot light >> computation is used. It's possible that the vertex shader can also be >> simplified in this case since it does not need to transform the position >> vectors, but I left this optimization avenue for another time. >> >> I noticed a drop of ~1 fps in the stress test of 5000 meshes. >> >> I added a system test that verifies the correct color result from a few >> directions. I also updated the lighting sample application to include 3 >> directional lights and tested them on all the models visually. The lights >> seem to behave the way I would expect. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added import Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/548
Integrated: 8279078: Update copyright header for files modified in 2021
On Tue, 21 Dec 2021 18:31:13 GMT, Ambarish Rapte wrote: > Fix for updating last modified year in the files that were modified during > year 2021. > @kevinrushforth, Please take a look. This pull request has now been integrated. Changeset: 303bcdb9 Author: Ambarish Rapte URL: https://git.openjdk.java.net/jfx/commit/303bcdb9ba40b7d82e555d675dad8d028e018c86 Stats: 75 lines in 74 files changed: 0 ins; 0 del; 75 mod 8279078: Update copyright header for files modified in 2021 Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/699
RFR: 8279078: Update copyright header for files modified in 2021
Fix for updating last modified year in the files that were modified during year 2021. @kevinrushforth, Please take a look. - Commit messages: - copyright year update 2021 Changes: https://git.openjdk.java.net/jfx/pull/699/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=699=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279078 Stats: 75 lines in 74 files changed: 0 ins; 0 del; 75 mod Patch: https://git.openjdk.java.net/jfx/pull/699.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/699/head:pull/699 PR: https://git.openjdk.java.net/jfx/pull/699
Re: [jfx17u] RFR: 8272638: Update copyright header for files modified in 2021
On Tue, 7 Dec 2021 13:30:44 GMT, Kevin Rushforth wrote: > Backport fix to update copyright changes. This was done by a script that > checks the copyright years for all files modified this year and updates the > ones that are missing 2021. As such it won't be a clean backport. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx17u/pull/26
Re: [jfx11u] RFR: 8272638: Update copyright header for files modified in 2021
On Tue, 7 Dec 2021 13:31:38 GMT, Kevin Rushforth wrote: > Backport fix to update copyright headers. This was done by a script that > checks the copyright years for all files modified this year and updates the > ones that are missing 2021. As such it won't be a clean backport. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx11u/pull/67
Re: RFR: 8278494: Remove .hgtags
On Thu, 9 Dec 2021 13:02:32 GMT, Kevin Rushforth wrote: > Trivial fix to remove the obsolete `.hgtags` file from the repo. As mentioned > in JBS, this file has (intentionally) not been updated since the switch to > git. It will continue to be available in the `jfx17` branch > [here](https://github.com/openjdk/jfx/blob/jfx17/.hgtags). The corresponding > file was recently removed from the `jdk` repo. Marked as reviewed by arapte (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/691
