Re: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK
On Thu, 2 Jan 2020 06:08:09 GMT, Pankaj Bansal wrote: >> The pull request has been updated with 1 additional commit. > > Sorry for late review. I have reviewed the code and have run few tests for > DND on Ubuntu 18.04, Ubuntu 19.04 and OL 7.5. All works fine for me. Approved. @tsayao this is ready for you to integrate. I note that it will only show one reviewer in the commit message; Pankaj did review it, but still needs to associate his GitHub ID with his OpenJDK ID before it will show up (so it will miss being recorded in the commit for this fix). - PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK
On Thu, 2 Jan 2020 06:08:25 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8225571 >> >> To run tests (on the root of the source tree): >> ./gradlew apps >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropWithControls >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropColor >> >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor > > The pull request has been updated with 1 additional commit. Sorry for late review. I have reviewed the code and have run few tests for DND on Ubuntu 18.04, Ubuntu 19.04 and OL 7.5. All works fine for me. Approved. - Marked as reviewed by pankaj-ban...@github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK
On Tue, 17 Dec 2019 17:29:02 GMT, Thiago Milczarek Sayao wrote: >> https://bugs.openjdk.java.net/browse/JDK-8225571 >> >> To run tests (on the root of the source tree): >> ./gradlew apps >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropWithControls >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropColor >> >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor > > The pull request has been updated with 1 additional commit. Looks good. Pending 2nd reviewer. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 11 Dec 2019 19:05:54 GMT, Thiago Milczarek Sayao wrote: >> With your latest patch, which reverts the changes to `GtkDnDClipboard.java`, >> I now get the DRAG_DONE event, but the following warning printed to the >> console in the case of a `DRAG_DONE` event with a null transfer mode: >> >> GOT A dragExit when dndGesture is null! >> >> This is coming from >> [Scene.java#L2925](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/Scene.java#L2925). > > My mistake. I saw that and thought it was from the test app. > > Will fix. All my testing looks good now. I tried both of the programs you listed in the description, as well as `tests/manual/dnd/DndTest.java`, on Ubuntu 16.04, Ubuntu 19.04, and Oracle Linux 7.7. I ran with the default gtk-3 implementation as well as gtk-2. I'll do a final code review, probably early next week. This will need a second reviewer. @pankaj-bansal can you also review this. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor The pull request has been updated with 1 additional commit. - Added commits: - b24f407f: Fix "GOT A dragExit when dndGesture is null!" Changes: - all: https://git.openjdk.java.net/jfx/pull/4/files - new: https://git.openjdk.java.net/jfx/pull/4/files/47155b08..b24f407f Webrevs: - full: https://webrevs.openjdk.java.net/jfx/4/webrev.04 - incr: https://webrevs.openjdk.java.net/jfx/4/webrev.03-04 Stats: 17 lines in 1 file changed: 12 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 11 Dec 2019 18:43:23 GMT, Kevin Rushforth wrote: >> I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu >> 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior. > > With your latest patch, which reverts the changes to `GtkDnDClipboard.java`, > I now get the DRAG_DONE event, but the following warning printed to the > console in the case of a `DRAG_DONE` event with a null transfer mode: > > GOT A dragExit when dndGesture is null! > > This is coming from > [Scene.java#L2925](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/Scene.java#L2925). My mistake. I saw that and thought it was from the test app. Will fix. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 11 Dec 2019 00:21:20 GMT, Kevin Rushforth wrote: >>> Does it send the event on other platforms? I can test on Windows. >> >> Yes, it always sends the `DRAG_DONE` event on all platforms today (I tested >> it on Mac, Windows, and Linux). >> >>> Will look into the assertion error - it does not happen on 18.04. >> >> It doesn't happen on 19.10 either. Only 16.04 as far as I have tested. I'll >> also test on Oracle Linux 7.x. > > I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu > 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior. With your latest patch, which reverts the changes to `GtkDnDClipboard.java`, I now get the DRAG_DONE event, but the following warning printed to the console in the case of a `DRAG_DONE` event with a null transfer mode: GOT A dragExit when dndGesture is null! This is coming from [Scene.java#L2925](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/Scene.java#L2925). - PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 03] RFR: 8225571: Port DND source to use GTK instead of GDK
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor Previous commits in this pull request have been removed, probably due to a force push. The incremental views will show differences compared to the previous content of the PR. - Added commits: - 47155b08: Remove blank line Changes: - all: https://git.openjdk.java.net/jfx/pull/4/files - new: https://git.openjdk.java.net/jfx/pull/4/files/554734c0..47155b08 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/4/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/4/webrev.02-03 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 02] RFR: 8225571: Port DND source to use GTK instead of GDK
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor The pull request has been updated with 1 additional commit. - Added commits: - 554734c0: Remove blank line Changes: - all: https://git.openjdk.java.net/jfx/pull/4/files - new: https://git.openjdk.java.net/jfx/pull/4/files/d16fc2c6..554734c0 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/4/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/4/webrev.01-02 Stats: 3 lines in 3 files changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 PR: https://git.openjdk.java.net/jfx/pull/4
Re: [Rev 01] RFR: 8225571: Port DND source to use GTK instead of GDK
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor The pull request has been updated with 1 additional commit. - Added commits: - d16fc2c6: Restore DRAG_DONE behaviour Changes: - all: https://git.openjdk.java.net/jfx/pull/4/files - new: https://git.openjdk.java.net/jfx/pull/4/files/3d650b2b..d16fc2c6 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/4/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/4/webrev.00-01 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Tue, 10 Dec 2019 23:53:27 GMT, Kevin Rushforth wrote: >> @kevinrushforth I changed that behaviour. Since the drag does not complete i >> find it counter-intuitive to send the DRAG_DONE event. >> >> Does it send the event on other platforms? I can test on Windows. >> >> Will look into the assertion error - it does not happen on 18.04. > >> Does it send the event on other platforms? I can test on Windows. > > Yes, it always sends the `DRAG_DONE` event on all platforms today (I tested > it on Mac, Windows, and Linux). > >> Will look into the assertion error - it does not happen on 18.04. > > It doesn't happen on 19.10 either. Only 16.04 as far as I have tested. I'll > also test on Oracle Linux 7.x. I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Tue, 10 Dec 2019 19:41:05 GMT, Thiago Milczarek Sayao wrote: >> I'm starting to look at this. I see at least one behavioral difference that >> will need to be addressed. With the existing implementation, if I drag / >> drop onto a target that set up to receive the drop, the transfer completes >> with a transfer mode of `null`. With your patch, the transfer never >> completes -- the `DRAG_DONE` event is never sent. >> >> This can be most easily seen by running the `DragDropWithControls` app and >> doing one of the following two things: >> >> 1. Drag from the source rectangle and drop somewhere _other than_ the >> target rectangle, for example, in the status text box at the bottom. >> 2. Change the source data format to `HTML` (uncheck `PLAINTEXT`), leaving >> the target at `PLAINTEXT`, then drag from the source rectangle and drop onto >> the target rectangle >> >> In addition to the drop not happening, I get the following assertion error >> on Ubuntu 16.04: >> >> (java:22328): Gdk-CRITICAL **: gdk_frame_clock_get_frame_time: assertion >> 'GDK_IS_FRAME_CLOCK (frame_clock)' failed >> >> I'm using the default GTK 3 library. > > @kevinrushforth I changed that behaviour. Since the drag does not complete i > find it counter-intuitive to send the DRAG_DONE event. > > Does it send the event on other platforms? I can test on Windows. > > Will look into the assertion error - it does not happen on 18.04. > Does it send the event on other platforms? I can test on Windows. Yes, it always sends the `DRAG_DONE` event on all platforms today (I tested it on Mac, Windows, and Linux). > Will look into the assertion error - it does not happen on 18.04. It doesn't happen on 19.10 either. Only 16.04 as far as I have tested. I'll also test on Oracle Linux 7.x. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Tue, 10 Dec 2019 16:13:06 GMT, Kevin Rushforth wrote: >> Just a reminder to take a look when time allows. > > I'm starting to look at this. I see at least one behavioral difference that > will need to be addressed. With the existing implementation, if I drag / drop > onto a target that set up to receive the drop, the transfer completes with a > transfer mode of `null`. With your patch, the transfer never completes -- the > `DRAG_DONE` event is never sent. > > This can be most easily seen by running the `DragDropWithControls` app and > doing one of the following two things: > > 1. Drag from the source rectangle and drop somewhere _other than_ the target > rectangle, for example, in the status text box at the bottom. > 2. Change the source data format to `HTML` (uncheck `PLAINTEXT`), leaving the > target at `PLAINTEXT`, then drag from the source rectangle and drop onto the > target rectangle > > In addition to the drop not happening, I get the following assertion error on > Ubuntu 16.04: > > (java:22328): Gdk-CRITICAL **: gdk_frame_clock_get_frame_time: assertion > 'GDK_IS_FRAME_CLOCK (frame_clock)' failed > > I'm using the default GTK 3 library. @kevinrushforth I changed that behaviour. Since the drag does not complete i find it counter-intuitive to send the DRAG_DONE event. Does it send the event on other platforms? I can test on Windows. Will look into the assertion error - it does not happen on 18.04. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Mon, 2 Dec 2019 11:09:05 GMT, Thiago Milczarek Sayao wrote: >> Preliminary review was here: >> [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490) > > Just a reminder to take a look when time allows. I'm starting to look at this. I see at least one behavioral difference that will need to be addressed. With the existing implementation, if I drag / drop onto a target that set up to receive the drop, the transfer completes with a transfer mode of `null`. With your patch, the transfer never completes -- the `DRAG_DONE` event is never sent. This can be most easily seen by running the `DragDropWithControls` app and doing one of the following two things: 1. Drag from the source rectangle and drop somewhere _other than_ the target rectangle, for example, in the status text box at the bottom. 2. Change the source data format to `HTML` (uncheck `PLAINTEXT`), leaving the target at `PLAINTEXT`, then drag from the source rectangle and drop onto the target rectangle In addition to the drop not happening, I get the following assertion error on Ubuntu 16.04: (java:22328): Gdk-CRITICAL **: gdk_frame_clock_get_frame_time: assertion 'GDK_IS_FRAME_CLOCK (frame_clock)' failed I'm using the default GTK 3 library. - PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Fri, 4 Oct 2019 23:03:00 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote: > >> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao >> wrote: >> >>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: >>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao wrote: > https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor > > > > Commits: > - 3d650b2b: Gtk DND port for Linux > > Changes: https://git.openjdk.java.net/jfx/pull/4/files > Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 > Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod > Patch: https://git.openjdk.java.net/jfx/pull/4.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID so should do this instead: > If you already are an OpenJDK > [Author](https://openjdk.java.net/bylaws#author), > [Committer](https://openjdk.java.net/bylaws#committer) or > [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click > [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1) > to open a new issue so that we can record that fact. Please use "Add > GitHub user tsayao" as summary for the issue. >>> >>> Yes, noticed that while reading the comment again. I have opened an issue. >>> Thanks. >> >> @pankaj-bansal can you review this as well? > > Preliminary review was here: > [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490) Just a reminder to take a look when time allows. PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao > wrote: > >> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: >> >>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao >>> wrote: >>> https://bugs.openjdk.java.net/browse/JDK-8225571 To run tests (on the root of the source tree): ./gradlew apps java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor Commits: - 3d650b2b: Gtk DND port for Linux Changes: https://git.openjdk.java.net/jfx/pull/4/files Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 >>> >>> @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID >>> so should do this instead: >>> If you already are an OpenJDK [Author](https://openjdk.java.net/bylaws#author), [Committer](https://openjdk.java.net/bylaws#committer) or [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1) to open a new issue so that we can record that fact. Please use "Add GitHub user tsayao" as summary for the issue. >> >> Yes, noticed that while reading the comment again. I have opened an issue. >> Thanks. > > @pankaj-bansal can you review this as well? Preliminary review was here: [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490) PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao wrote: > On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: > >> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao >> wrote: >> >>> https://bugs.openjdk.java.net/browse/JDK-8225571 >>> >>> To run tests (on the root of the source tree): >>> ./gradlew apps >>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >>> dragdrop.DragDropWithControls >>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >>> dragdrop.DragDropColor >>> >>> java -Djdk.gtk.version=2 @build/run.args -cp >>> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >>> java -Djdk.gtk.version=2 @build/run.args -cp >>> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor >>> >>> >>> >>> Commits: >>> - 3d650b2b: Gtk DND port for Linux >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/4/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 >>> Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/4.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 >> >> @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID >> so should do this instead: >> >>> If you already are an OpenJDK >>> [Author](https://openjdk.java.net/bylaws#author), >>> [Committer](https://openjdk.java.net/bylaws#committer) or >>> [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click >>> [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1) >>> to open a new issue so that we can record that fact. Please use "Add >>> GitHub user tsayao" as summary for the issue. > > Yes, noticed that while reading the comment again. I have opened an issue. > Thanks. @pankaj-bansal can you review this as well? PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao > wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8225571 >> >> To run tests (on the root of the source tree): >> ./gradlew apps >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropWithControls >> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >> dragdrop.DragDropColor >> >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >> java -Djdk.gtk.version=2 @build/run.args -cp >> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor >> >> >> >> Commits: >> - 3d650b2b: Gtk DND port for Linux >> >> Changes: https://git.openjdk.java.net/jfx/pull/4/files >> Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 >> Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod >> Patch: https://git.openjdk.java.net/jfx/pull/4.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 > > @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID > so should do this instead: > >> If you already are an OpenJDK >> [Author](https://openjdk.java.net/bylaws#author), >> [Committer](https://openjdk.java.net/bylaws#committer) or >> [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click >> [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1) >> to open a new issue so that we can record that fact. Please use "Add GitHub >> user tsayao" as summary for the issue. Yes, noticed that while reading the comment again. I have opened an issue. Thanks. PR: https://git.openjdk.java.net/jfx/pull/4
Re: RFR: 8225571: Port DND source to use GTK instead of GDK
On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao wrote: > https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropColor > > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls > java -Djdk.gtk.version=2 @build/run.args -cp > apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor > > > > Commits: > - 3d650b2b: Gtk DND port for Linux > > Changes: https://git.openjdk.java.net/jfx/pull/4/files > Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 > Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod > Patch: https://git.openjdk.java.net/jfx/pull/4.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID so should do this instead: > If you already are an OpenJDK > [Author](https://openjdk.java.net/bylaws#author), > [Committer](https://openjdk.java.net/bylaws#committer) or > [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click > [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1) > to open a new issue so that we can record that fact. Please use "Add GitHub > user tsayao" as summary for the issue. PR: https://git.openjdk.java.net/jfx/pull/4
RFR: 8225571: Port DND source to use GTK instead of GDK
https://bugs.openjdk.java.net/browse/JDK-8225571 To run tests (on the root of the source tree): /gradlew apps java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls java -Djdk.gtk.version=2 @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor Commits: - 3d650b2b: Gtk DND port for Linux Changes: https://git.openjdk.java.net/jfx/pull/4/files Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod Patch: https://git.openjdk.java.net/jfx/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 PR: https://git.openjdk.java.net/jfx/pull/4
