Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Fri, 7 May 2021 16:00:31 GMT, John Neffenger wrote: > I also think that we should remove it. If you read its history on the mailing > list, it was added to the repository in part as a solution to the `WINSDK_DIR > not defined` error. See the message ["Problems building openjfx"][1] on the > mailing list. That discussion starts with `WINSDK_DIR`. My goal in #488 is > to give developers a better chance at getting the official build under Cygwin > working after hitting the error. > > [1]: > https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-November/022858.html > Directories configuration issues that by the way still persist. In fact what I did to build the project in the end was to manually set the dir in the gradle config files and that was the only solution that would make the project compilable on my PC - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). > > I have run a full build and test using this new compiler. > > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is out > for review as PR #211 , I plan to wait until that one is approved. I will > then integrate PR #211 followed by this PR. I also think that we should remove it. If you read its history on the mailing list, it was added to the repository in part as a solution to the `WINSDK_DIR not defined` error. See the message ["Problems building openjfx"][1] on the mailing list. That discussion starts with `WINSDK_DIR`. My goal in #488 is to give developers a better chance at getting the official build under Cygwin working after hitting the error. [1]: https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-November/022858.html - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). > > I have run a full build and test using this new compiler. > > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is out > for review as PR #211 , I plan to wait until that one is approved. I will > then integrate PR #211 followed by this PR. I am not a big fan of scripts in a source code repository, unless they are automatically tested with every commit. Scripts are good candidates for being outdated soon, and often contain bitrotten code. We strive towards excellent code quality in the repository, and towards a very high test coverage for this code. If we can't achieve the same quality for scripts (which I believe is extremely hard to do), I am in favor of splitting of those scripts -- and maybe have them in a separate repository, maintained by different people? - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 3 Mar 2021 22:07:34 GMT, Alessadro Parisi wrote: >> This is a toolchain upgrade on Windows from the current Visual Studio 2017 >> (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a >> recent upgrade done for JDK 15 -- see >> [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). >> >> I have run a full build and test using this new compiler. >> >> NOTE: although this isn't strictly dependent on >> [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is >> out for review as PR #211 , I plan to wait until that one is approved. I >> will then integrate PR #211 followed by this PR. > > Can you also update the build script located in tools/scripts? > Build fails on my system with `FAIL: WINSDK_DIR not defined` > Also, it's not possible to install Windows SDK 7.1 on Windows 10, so that > should be updated too @palexdev Please ignore my previous comment and see #488 if you're still getting the `WINSDK_DIR` error. - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Thu, 25 Mar 2021 22:58:57 GMT, Kevin Rushforth wrote: > Build fails on my system with `FAIL: WINSDK_DIR not defined` @palexdev I hit that error, too. You may have already found this, but you can work around the problem by using the sample [`windows_tools.properties`][1] file on the Building OpenJFX page (click "Expand source"). You just have to adjust the `WINDOWS_VS_PATH` and remember to copy the file to `build/windows_tools.properties` after running `gradle clean` and before running a build. [1]: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Missingpathsissue - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 3 Mar 2021 22:07:34 GMT, Alessadro Parisi wrote: > Can you also update the build script located in tools/scripts? > Build fails on my system with `FAIL: WINSDK_DIR not defined` I filed [JDK-8264219](https://bugs.openjdk.java.net/browse/JDK-8264219) to track this. We don't use that script, and I have no good way to test it. Maybe someone in the community could pick it up. > Also, it's not possible to install Windows SDK 7.1 on Windows 10, so that > should be updated too The dependency on Windows SDK 7.1 has been eliminated; I noted that in the bug report. - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Mon, 11 May 2020 04:50:22 GMT, Ambarish Rapte wrote: >> This is a toolchain upgrade on Windows from the current Visual Studio 2017 >> (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a >> recent upgrade done for JDK 15 -- see >> [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). >> >> I have run a full build and test using this new compiler. >> >> NOTE: although this isn't strictly dependent on >> [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is >> out for review as PR #211 , I plan to wait until that one is approved. I >> will then integrate PR #211 followed by this PR. > > lgtm, verified a local build on Windows10. Can you also update the build script located in tools/scripts? Build fails on my system with `FAIL: WINSDK_DIR not defined` - PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 > (version 16.5.3). This will match a recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). I have run > a full build and test using this new > compiler. > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which > is out for review as PR #211 , I plan to wait until that one is approved. I > will then integrate PR #211 followed by > this PR. lgtm, verified a local build on Windows10. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 > (version 16.5.3). This will match a recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). I have run > a full build and test using this new > compiler. > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which > is out for review as PR #211 , I plan to wait until that one is approved. I > will then integrate PR #211 followed by > this PR. Confirmed to work on our build system. - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/212
Re: RFR: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth wrote: > This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 > (version 16.5.3). This will match a recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). I have run > a full build and test using this new > compiler. > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which > is out for review as PR #211 , I plan to wait until that one is approved. I > will then integrate PR #211 followed by > this PR. @arapte can you also review this? - PR: https://git.openjdk.java.net/jfx/pull/212
