Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
I'm tracking my work here https://github.com/simonsmiley/openlp-remote It currently requires Tim's branch (With a minor fix that's comented on his merge request) To get it running, clone the repo and run "npm install" followed by "npm start" you will need to enable cross origin resource sharing for now (because it's served under another location than the api) I'm using chromium with this extension https://chrome.google.com/webstore/detail/allow-control-allow-origi/nlfbmbojpeacfghkpbjhddihlkkiljbi?utm_source=chrome-app-launcher-info-dialog It currently can display everything but can't search or use alerts. All the buttons in the footer are functioning -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Simon if you start with https://code.launchpad.net/~trb143/openlp/websockets you will find all the remote code has been moved into core and under an API directory. The existing api's have been converted and where they start with /api there is a version without that. Long term aim is to remove the /api but for now, we support both. The decorators around the api's can support post. There is an override on the url wrapper called method which defaults to GET. I have not tested POST yet as I have no examples. You could start on the existing code and move to the code in a few weeks when the code is more stable. Adding new urls is not an issue as long and the android and IOS code still works! The new code supports websocket end points which have enabled the removal of the polling code which will give you some options. Tim On 23 July 2016 at 01:55, Simon Hannawrote: > Ok, I got started with angular. All the fetching works like a charm. I > have issues with posting though. It's because the current remote doesn't > actually use post requests and there doesn't seem to be a nice way in > angular2 to send data along a get request. > > Could this be changed along the process? It would require updates to the > mobile apps as well... > -- > https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 > Your team OpenLP Core is requested to review the proposed merge of > lp:~thelinuxguy/openlp/rework-remote into lp:openlp. > > ___ > Mailing list: https://launchpad.net/~openlp-core > Post to : openlp-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~openlp-core > More help : https://help.launchpad.net/ListHelp > -- Tim and Alison Bentley h...@trarbentley.net https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Ok, I got started with angular. All the fetching works like a charm. I have issues with posting though. It's because the current remote doesn't actually use post requests and there doesn't seem to be a nice way in angular2 to send data along a get request. Could this be changed along the process? It would require updates to the mobile apps as well... -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Hi Simon, I've just had to fix a problem with our web remote and updated versions of jQuery, and I'm really keen to get this into OpenLP 2.6. We're rewriting half of it anyway, so why not add more! But yes, let's go with AngularJS and angular-material. -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
So, after quite some time, I'm coming back to this :-) In the meantime I played around a little with material frameworks (materializecss.com) and also with angular. I don't think ionic is the way to go, because it's mainly targeting mobile phone displays. I would go for plain html with materializecss or angular with angular-material. Which approach do you prefer -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
I used bootstrap, because I'm familiar with it and get it done :-) Since there are mobile apps for android and ios, I thought that having the remote a responsive website makes it usable from computers (or just tablets with bigger screens). I think having the remote somewhat responsive is a nice feature. I will not try to fix the errors, unless we actually go with this. If the android app is also suffering the issue, could it be that the bug is in the rest api? -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Hi Simon, I just tested this out, and while I like the direction, there are a couple of bugs and I'm not a fan of the "mobile website" look. It's not supposed to be a mobile website, but more of a mobile app. I think using a Material design would probably work better than the basic default Bootstrap theme. I wonder if we shouldn't actually just use something like AngularJS, perhaps even Ionic. One of the bugs I picked up is that when I click on a slide further down on a song, I'm suddenly left at the top of the song again. There's a similar bug in the Android app and it's immensely frustrating when trying to actually use the app in a live context. -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Hi Simon, This is a really big change, so I'm going to have to ask you to defer it till after 2.4. This means that we need to update package dependencies and make sure everything works properly, so I'd prefer to wait till we have more time to test and fix packaging issues. -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Yeah, I didn't think it would make into 2.4 I'm not so good with webdesign, so if someone wants to write a theme to have something other than the default look, go ahead! -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
Bootstrap++ though, I like it. -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
I think it looks good! :) The only issue I found in my quick testing was that when using the prev/next buttons in the slidecontroller the buttons stay "marked". -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~thelinuxguy/openlp/rework-remote into lp:openlp
fixed the buttons -- https://code.launchpad.net/~thelinuxguy/openlp/rework-remote/+merge/282342 Your team OpenLP Core is requested to review the proposed merge of lp:~thelinuxguy/openlp/rework-remote into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp