Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-17 Thread Heiko Hund 
On Sonntag, 9. Oktober 2016 17:25:50 CEST Gert Doering wrote:
> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
> index 4a11d10..1250547 100644
> --- a/src/openvpn/tun.c
> +++ b/src/openvpn/tun.c
> @@ -1373,11 +1373,13 @@ do_ifconfig (struct tuntap *tt,
>   else
> {
>   /* example: netsh interface ipv6 set address interface=42
> 2001:608:8003::d store=active */ +char iface[64];
> + openvpn_snprintf(iface, sizeof(iface), "interface=%lu",
> tt->adapter_index ); argv_printf (,
> -  "%s%sc interface ipv6 set address interface=%lu %s 
> store=active",
> +  "%s%sc interface ipv6 set address %s %s store=active",
>get_win_sys_path(),
>NETSH_PATH_SUFFIX,
> -  tt->adapter_index,
> +  iface,
>ifconfig_ipv6_local );
>   netsh_command (, 4, M_FATAL);
> }
> 
> I've done a "v2" of Heiko's patch with that change included, which I'll
> append below.  Samuli, could you build us a windows installer with master
> plus that patch, for "windows early alpha testing"?  If that change
> works for people, we are very close to 2.4_alpha1...

ACK for the partial rollback.

Shakes fist at argv_printf(). =)

Thanks Gert

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen 
Il 10/10/2016 18:09, debbie10t ha scritto:
> Hi
>
> On 10/10/16 14:42, Samuli Seppänen wrote:
>
>> Installers with the attached patch:
>>
>> 
>> 
>>
>
> For the hell of it I tested -i686 on WXP ..
> It successfully installs but then fails to run, missing fwpuclnt.dll
>
> You may want to include a refusal to install on WXP ?
>

Hi,

We did exactly that in "Fail if trying to run I60x installer on Windows 
XP" commit:


 


Even though that change was crafted pretty carefully, it made all 
installers - including I00x ones - fail on Windows XP. So we had to 
revert the change:



I have not had time to look into that issue again. If somebody has a 
clue why the NSI code in commit 65e328c89 did not work please let me know.

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread debbie10t 
Hi

On 10/10/16 14:42, Samuli Seppänen wrote:

> Installers with the attached patch:
>
> 
> 
>

For the hell of it I tested -i686 on WXP ..
It successfully installs but then fails to run, missing fwpuclnt.dll

You may want to include a refusal to install on WXP ?

Regards


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen 
Il 09/10/2016 18:25, Gert Doering ha scritto:
> Hi,
>
> On Sun, Oct 09, 2016 at 05:06:59PM +0200, Gert Doering wrote:
>> Running more tests with that hunk reverted next...
>
> With the following patch applied on top of Heiko's patch
>
> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
> index 4a11d10..1250547 100644
> --- a/src/openvpn/tun.c
> +++ b/src/openvpn/tun.c
> @@ -1373,11 +1373,13 @@ do_ifconfig (struct tuntap *tt,
>   else
> {
>   /* example: netsh interface ipv6 set address interface=42 
> 2001:608:8003::d store=active */
> + char iface[64];
> + openvpn_snprintf(iface, sizeof(iface), "interface=%lu", 
> tt->adapter_index );
>   argv_printf (,
> -  "%s%sc interface ipv6 set address interface=%lu %s 
> store=active",
> +  "%s%sc interface ipv6 set address %s %s store=active",
>get_win_sys_path(),
>NETSH_PATH_SUFFIX,
> -  tt->adapter_index,
> +  iface,
>ifconfig_ipv6_local );
>   netsh_command (, 4, M_FATAL);
> }
>
>
> ... the resulting binary now actually works :-) - tested on win7, without(!)
> iservice (because Heiko already tested that), testing all the variants
> of "--ip-win32".  Only a single tap adapter in the system, but will test
> with 2-3 taps next (and trying to run multiple instances).
>
> I've done a "v2" of Heiko's patch with that change included, which I'll
> append below.  Samuli, could you build us a windows installer with master
> plus that patch, for "windows early alpha testing"?  If that change
> works for people, we are very close to 2.4_alpha1...
>
> gert
>

Installers with the attached patch:




-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-25 Thread Selva Nair 
On Sat, Jun 25, 2016 at 3:45 AM, Heiko Hund  wrote:

> On Freitag, 24. Juni 2016 19:37:13 CEST Gert Doering wrote:
> > This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some
> > initialization code to init_tun, where it belongs, and removes duplicate
> > code that is now no longer needed.
>
> Yeah, I was skeptic at first, too. But it seems to work. That said, I've
> only
> tested with the interactive service in place. It's the only option how to
> run
> Openvpn in a sane manner on Windows anyways. =)
>
>
True but not yet practical  in some cases. For example, we do not yet have
way to start openvpn using interactive service without using the GUI -- say
run a client or a server (as from an init script). We should do something
about it, but until then testing without interactive service is important
-- easy to do, just run from the command line.

Also, a test against the old tap driver (NDIS 5.x) is in order..

Selva

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-25 Thread Heiko Hund 
On Freitag, 24. Juni 2016 19:37:13 CEST Gert Doering wrote:
> This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some
> initialization code to init_tun, where it belongs, and removes duplicate
> code that is now no longer needed.

Yeah, I was skeptic at first, too. But it seems to work. That said, I've only 
tested with the interactive service in place. It's the only option how to run 
Openvpn in a sane manner on Windows anyways. =)

Cheers
Heiko

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-24 Thread Gert Doering 
Hi,

On Fri, Jun 24, 2016 at 06:01:41PM +0200, Heiko Hund wrote:
> This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some
> initialization code to init_tun, where it belongs, and removes duplicate
> code that is now no longer needed.

While I totally like this, I'm still baffled why we had the other order
before, and what might break due to the change.  I assume you've already
run quite a few --route-method variations in testing?

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature