[OpenWrt-Devel] Customizing openssh password login, preprovisioned root passwords, etc.

2018-06-21 Thread Philip Prindeville
Hi all,

A while back I proposed some PR’s to allow baking in root passwords 
(configurable, so it wouldn’t have to be some lame constant password) as well 
as turning off password login for OpenSSH server.

The maintainers of base-files and openssh didn’t like either.

So I’m proposing a virtual package that scribbles on both as part of its 
/postinst script, which was suggested as a compromise.

Please see:

https://github.com/openwrt/packages/pull/6311

and leave comments.

Thanks,

-Philip


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/3] toolchain/gcc: add GCC 8.1.0

2018-06-21 Thread Syrone Wong
Hi,

I did some googling without testing.

There is a similar issue here[0], it's caused by an unrecognized flag,
please post the configure log related to the error message to see if
it's the case.

Other posts say gas-preprocessor is a Perl script, it seems the
interpreter is not found when configuring. We may add perl as
PKG_BUILD_DEPENDS.

[0]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200714


Best Regards,
Syrone Wong


On Fri, Jun 22, 2018 at 8:14 AM, Rosen Penev  wrote:
> On Thu, Jun 21, 2018 at 5:09 PM Syrone Wong  wrote:
>>
>> HI,
>>
>> We are using FFmpeg 3.2.10, it was cut from master on 2016-10-26,
>> definitely has no fixes to GCC 8, you may want to check the latest
>> 4.0.1. 4.0.1 was released on 2018-06-16. It is the latest stable
>> FFmpeg release from the 4.0 release branch, which was cut from master
>> on 2018-04-16.
>>
>> You can disable FFmpeg temporarily and make sure other important
>> components are working as expected, e.g. kernel, busybox, procd,
>> firewall3, etc.
> Added FFmpeg maintainer to CC.
>>
>>
>> Best Regards,
>> Syrone Wong
>>
>>
>> On Fri, Jun 22, 2018 at 2:07 AM, Rosen Penev  wrote:
>> > Error while compiling ffmpeg:
>> >
>> > GNU assembler not found, install/update gas-preprocessor
>> >
>> >
>> > On Thu, Jun 21, 2018 at 8:09 AM  wrote:
>> >>
>> >> From: Syrone Wong 
>> >>
>> >> Changes compared to GCC 7.x
>> >>
>> >> 001-revert_register_mode_search.patch dropped
>> >>
>> >> The commit guards comparison via maybe_gt(), while 
>> >> 001-revert_register_mode_search.patch simply ignore
>> >> "GET_MODE_SIZE (mode) > GET_MODE_SIZE (found_mode)", the powerpc issue 
>> >> might be fixed, I'm not pretty sure.
>> >>
>> >> upstream commit: 
>> >> https://github.com/gcc-mirror/gcc/commit/52acb7aee19f4bb33e76819907eff343bf4f42e8
>> >>
>> >> 020-PR-libstdc-81797-Add-.NOTPARALLEL-to-include-Makefil.patch dropped 
>> >> due to already upstream
>> >>
>> >> 100-PR-rtl-optimization-83496.patch dropped due to already upstream
>> >>
>> >> 910-mbsd_multi.patch
>> >> modified to fix ambiguous overloaded inform() call error
>> >>
>> >> gcc/input.h
>> >> header: define UNKNOWN_LOCATION ((source_location) 0)
>> >>
>> >> -inform (0, "someone does not honour COPTS correctly, passed %d 
>> >> times",
>> >> - honour_copts);
>> >> +inform (UNKNOWN_LOCATION, "someone does not honour COPTS 
>> >> correctly, passed %d times",
>> >> + honour_copts);
>> >>
>> >> 940-no-clobber-stamp-bits.patch dropped due to fixed upstream by another 
>> >> way
>> >> upstream commit: 
>> >> https://github.com/gcc-mirror/gcc/commit/87b2d547f8ac9778d66909b8726fe967d1efbc74
>> >>
>> >> 950-cpp_file_path_translation.patch dropped, Both -fmacro-prefix-map and 
>> >> -ffile-prefix-map are added
>> >> to gcc 8.1.0, if I understand it correctly, we should use 
>> >> -fmacro-prefix-map
>> >> usage: -fmacro-prefix-map=@var{old}=@var{new}
>> >> upstream commit: 
>> >> https://github.com/gcc-mirror/gcc/commit/859b51f83662d01e4f158ea9327db9ca37fe70b3
>> >>
>> >> -iremap exists as a flag for a long time, for backward compatibility, I 
>> >> think we should keep the
>> >> variable name unchanged but change its value in rules.mk for gcc 8.x and 
>> >> higher.
>> >>
>> >> Compile and run tested on x86_64
>> >>
>> >> Signed-off-by: Syrone Wong 
>> >> ---
>> >>  toolchain/gcc/Config.in   |   3 +
>> >>  toolchain/gcc/Config.version  |   5 +
>> >>  toolchain/gcc/common.mk   |   4 +
>> >>  .../patches/8.1.0/002-case_insensitive.patch  |  24 +++
>> >>  .../gcc/patches/8.1.0/010-documentation.patch |  35 
>> >>  .../patches/8.1.0/110-Fix-MIPS-PR-84790.patch |  20 +++
>> >>  .../gcc/patches/8.1.0/230-musl_libssp.patch   |  13 ++
>> >>  .../300-mips_Os_cpu_rtx_cost_model.patch  |  21 +++
>> >>  .../8.1.0/800-arm_v5te_no_ldrd_strd.patch |  11 ++
>> >>  .../8.1.0/810-arm-softfloat-libgcc.patch  |  33 
>> >>  .../gcc/patches/8.1.0/820-libgcc_pic.patch|  44 +
>> >>  .../8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch |  28 +++
>> >>  .../patches/8.1.0/850-use_shared_libgcc.patch |  54 ++
>> >>  .../patches/8.1.0/851-libgcc_no_compat.patch  |  22 +++
>> >>  .../patches/8.1.0/870-ppc_no_crtsavres.patch  |  11 ++
>> >>  .../gcc/patches/8.1.0/881-no_tm_section.patch |  11 ++
>> >>  .../patches/8.1.0/900-bad-mips16-crt.patch|   9 +
>> >>  .../gcc/patches/8.1.0/910-mbsd_multi.patch| 146 +++
>> >>  .../8.1.0/920-specs_nonfatal_getenv.patch |  22 +++
>> >>  .../8.1.0/930-fix-mips-noexecstack.patch  | 111 
>> >>  ...ibffi-fix-MIPS-softfloat-build-issue.patch | 168 ++
>> >>  ...mpilation-when-making-cross-compiler.patch |  67 +++
>> >>  22 files changed, 862 insertions(+)
>> >>  create mode 100644 toolchain/gcc/patches/8.1.0/002-case_insensitive.patch
>> >>  create mode 100644 toolchain/gcc/patches/8.1.0/010-documentation.patch
>> >>  create mode 100644 
>> >> 

Re: [OpenWrt-Devel] [PATCH 3/3] package: ignore some new errors introduced by GCC 8

2018-06-21 Thread Rosen Penev
On Thu, Jun 21, 2018 at 5:16 PM Syrone Wong  wrote:
>
> Hi,
>
> I definitely agree we should fix errors, this commit is to bypass
> warnings and see if other important components are working well, e.g.
> no kernel panic,
> busybox is functional, etc. Others can be fixed as the follow-up. It
> makes sense to ignore this testing commit.
Patches have been posted FWIW.
>
>
> Best Regards,
> Syrone Wong
>
>
> On Fri, Jun 22, 2018 at 3:15 AM, Mathias Kresin  wrote:
> > 21.06.2018 17:08, wong.syr...@gmail.com:
> >
> >> From: Syrone Wong 
> >>
> >> Signed-off-by: Syrone Wong 
> >> ---
> >>   package/network/config/firewall/Makefile | 2 +-
> >>   package/system/procd/Makefile| 2 ++
> >>   2 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/package/network/config/firewall/Makefile
> >> b/package/network/config/firewall/Makefile
> >> index 01fea237f3..43673cf777 100644
> >> --- a/package/network/config/firewall/Makefile
> >> +++ b/package/network/config/firewall/Makefile
> >> @@ -40,7 +40,7 @@ define Package/firewall/conffiles
> >>   /etc/firewall.user
> >>   endef
> >>   -TARGET_CFLAGS += -ffunction-sections -fdata-sections
> >> +TARGET_CFLAGS += -ffunction-sections -fdata-sections
> >> -Wno-error=format-overflow
> >>   TARGET_LDFLAGS += -Wl,--gc-sections
> >>   CMAKE_OPTIONS += $(if $(CONFIG_IPV6),,-DDISABLE_IPV6=1)
> >>   diff --git a/package/system/procd/Makefile
> >> b/package/system/procd/Makefile
> >> index 5971e0293d..c47ff23352 100644
> >> --- a/package/system/procd/Makefile
> >> +++ b/package/system/procd/Makefile
> >> @@ -37,6 +37,8 @@ endif
> >>   CMAKE_OPTIONS += -DEARLY_PATH="$(TARGET_INIT_PATH)"
> >>   TARGET_LDFLAGS += $(if $(CONFIG_USE_GLIBC),-lrt)
> >>   +TARGET_CFLAGS += -Wno-error=format-truncation
> >> +
> >>   define Package/procd
> >> SECTION:=base
> >> CATEGORY:=Base system
> >
> >
> > NAK.
> >
> > Please fix the errors instead of hiding the warning. Both packages are
> > OpenWrt specific ones. Shouldn't be that difficult to get the fixes applied.
> >
> > Mathias
> >
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/3] toolchain/gcc: add GCC 8.1.0

2018-06-21 Thread Rosen Penev
On Thu, Jun 21, 2018 at 5:09 PM Syrone Wong  wrote:
>
> HI,
>
> We are using FFmpeg 3.2.10, it was cut from master on 2016-10-26,
> definitely has no fixes to GCC 8, you may want to check the latest
> 4.0.1. 4.0.1 was released on 2018-06-16. It is the latest stable
> FFmpeg release from the 4.0 release branch, which was cut from master
> on 2018-04-16.
>
> You can disable FFmpeg temporarily and make sure other important
> components are working as expected, e.g. kernel, busybox, procd,
> firewall3, etc.
Added FFmpeg maintainer to CC.
>
>
> Best Regards,
> Syrone Wong
>
>
> On Fri, Jun 22, 2018 at 2:07 AM, Rosen Penev  wrote:
> > Error while compiling ffmpeg:
> >
> > GNU assembler not found, install/update gas-preprocessor
> >
> >
> > On Thu, Jun 21, 2018 at 8:09 AM  wrote:
> >>
> >> From: Syrone Wong 
> >>
> >> Changes compared to GCC 7.x
> >>
> >> 001-revert_register_mode_search.patch dropped
> >>
> >> The commit guards comparison via maybe_gt(), while 
> >> 001-revert_register_mode_search.patch simply ignore
> >> "GET_MODE_SIZE (mode) > GET_MODE_SIZE (found_mode)", the powerpc issue 
> >> might be fixed, I'm not pretty sure.
> >>
> >> upstream commit: 
> >> https://github.com/gcc-mirror/gcc/commit/52acb7aee19f4bb33e76819907eff343bf4f42e8
> >>
> >> 020-PR-libstdc-81797-Add-.NOTPARALLEL-to-include-Makefil.patch dropped due 
> >> to already upstream
> >>
> >> 100-PR-rtl-optimization-83496.patch dropped due to already upstream
> >>
> >> 910-mbsd_multi.patch
> >> modified to fix ambiguous overloaded inform() call error
> >>
> >> gcc/input.h
> >> header: define UNKNOWN_LOCATION ((source_location) 0)
> >>
> >> -inform (0, "someone does not honour COPTS correctly, passed %d 
> >> times",
> >> - honour_copts);
> >> +inform (UNKNOWN_LOCATION, "someone does not honour COPTS 
> >> correctly, passed %d times",
> >> + honour_copts);
> >>
> >> 940-no-clobber-stamp-bits.patch dropped due to fixed upstream by another 
> >> way
> >> upstream commit: 
> >> https://github.com/gcc-mirror/gcc/commit/87b2d547f8ac9778d66909b8726fe967d1efbc74
> >>
> >> 950-cpp_file_path_translation.patch dropped, Both -fmacro-prefix-map and 
> >> -ffile-prefix-map are added
> >> to gcc 8.1.0, if I understand it correctly, we should use 
> >> -fmacro-prefix-map
> >> usage: -fmacro-prefix-map=@var{old}=@var{new}
> >> upstream commit: 
> >> https://github.com/gcc-mirror/gcc/commit/859b51f83662d01e4f158ea9327db9ca37fe70b3
> >>
> >> -iremap exists as a flag for a long time, for backward compatibility, I 
> >> think we should keep the
> >> variable name unchanged but change its value in rules.mk for gcc 8.x and 
> >> higher.
> >>
> >> Compile and run tested on x86_64
> >>
> >> Signed-off-by: Syrone Wong 
> >> ---
> >>  toolchain/gcc/Config.in   |   3 +
> >>  toolchain/gcc/Config.version  |   5 +
> >>  toolchain/gcc/common.mk   |   4 +
> >>  .../patches/8.1.0/002-case_insensitive.patch  |  24 +++
> >>  .../gcc/patches/8.1.0/010-documentation.patch |  35 
> >>  .../patches/8.1.0/110-Fix-MIPS-PR-84790.patch |  20 +++
> >>  .../gcc/patches/8.1.0/230-musl_libssp.patch   |  13 ++
> >>  .../300-mips_Os_cpu_rtx_cost_model.patch  |  21 +++
> >>  .../8.1.0/800-arm_v5te_no_ldrd_strd.patch |  11 ++
> >>  .../8.1.0/810-arm-softfloat-libgcc.patch  |  33 
> >>  .../gcc/patches/8.1.0/820-libgcc_pic.patch|  44 +
> >>  .../8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch |  28 +++
> >>  .../patches/8.1.0/850-use_shared_libgcc.patch |  54 ++
> >>  .../patches/8.1.0/851-libgcc_no_compat.patch  |  22 +++
> >>  .../patches/8.1.0/870-ppc_no_crtsavres.patch  |  11 ++
> >>  .../gcc/patches/8.1.0/881-no_tm_section.patch |  11 ++
> >>  .../patches/8.1.0/900-bad-mips16-crt.patch|   9 +
> >>  .../gcc/patches/8.1.0/910-mbsd_multi.patch| 146 +++
> >>  .../8.1.0/920-specs_nonfatal_getenv.patch |  22 +++
> >>  .../8.1.0/930-fix-mips-noexecstack.patch  | 111 
> >>  ...ibffi-fix-MIPS-softfloat-build-issue.patch | 168 ++
> >>  ...mpilation-when-making-cross-compiler.patch |  67 +++
> >>  22 files changed, 862 insertions(+)
> >>  create mode 100644 toolchain/gcc/patches/8.1.0/002-case_insensitive.patch
> >>  create mode 100644 toolchain/gcc/patches/8.1.0/010-documentation.patch
> >>  create mode 100644 toolchain/gcc/patches/8.1.0/110-Fix-MIPS-PR-84790.patch
> >>  create mode 100644 toolchain/gcc/patches/8.1.0/230-musl_libssp.patch
> >>  create mode 100644 
> >> toolchain/gcc/patches/8.1.0/300-mips_Os_cpu_rtx_cost_model.patch
> >>  create mode 100644 
> >> toolchain/gcc/patches/8.1.0/800-arm_v5te_no_ldrd_strd.patch
> >>  create mode 100644 
> >> toolchain/gcc/patches/8.1.0/810-arm-softfloat-libgcc.patch
> >>  create mode 100644 toolchain/gcc/patches/8.1.0/820-libgcc_pic.patch
> >>  create mode 100644 
> >> toolchain/gcc/patches/8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch
> >>  create mode 100644 

Re: [OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-21 Thread Syrone Wong
HI,

I'm not sure whether it's the correct way to deal with the flag. When
we add GCC 9 in the future, we have to remember to apply this dirty
overwrite hack as well.
Please feel free to share more elegant ways.


Best Regards,
Syrone Wong


On Thu, Jun 21, 2018 at 11:08 PM,   wrote:
> From: Syrone Wong 
>
> The original -iremap is replaced by -fmacro-prefix-map in GCC 8
>
> Signed-off-by: Syrone Wong 
> ---
>  rules.mk | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/rules.mk b/rules.mk
> index a97b2d2155..8eb8e21a7e 100644
> --- a/rules.mk
> +++ b/rules.mk
> @@ -141,6 +141,10 @@ endif
>
>  ifeq ($(or 
> $(CONFIG_EXTERNAL_TOOLCHAIN),$(CONFIG_GCC_VERSION_4_8),$(CONFIG_TARGET_uml)),)
>iremap = -iremap$(1):$(2)
> +  # just overwrite iremap for GCC 8.1 and higher to keep backward 
> compatibility
> +  ifeq ($(CONFIG_GCC_VERSION_8),y)
> +iremap = -fmacro-prefix-map=$(1)=$(2)
> +  endif
>  endif
>
>  PACKAGE_DIR:=$(BIN_DIR)/packages
> --
> 2.17.1
>

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 3/3] package: ignore some new errors introduced by GCC 8

2018-06-21 Thread Syrone Wong
Hi,

I definitely agree we should fix errors, this commit is to bypass
warnings and see if other important components are working well, e.g.
no kernel panic,
busybox is functional, etc. Others can be fixed as the follow-up. It
makes sense to ignore this testing commit.


Best Regards,
Syrone Wong


On Fri, Jun 22, 2018 at 3:15 AM, Mathias Kresin  wrote:
> 21.06.2018 17:08, wong.syr...@gmail.com:
>
>> From: Syrone Wong 
>>
>> Signed-off-by: Syrone Wong 
>> ---
>>   package/network/config/firewall/Makefile | 2 +-
>>   package/system/procd/Makefile| 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/network/config/firewall/Makefile
>> b/package/network/config/firewall/Makefile
>> index 01fea237f3..43673cf777 100644
>> --- a/package/network/config/firewall/Makefile
>> +++ b/package/network/config/firewall/Makefile
>> @@ -40,7 +40,7 @@ define Package/firewall/conffiles
>>   /etc/firewall.user
>>   endef
>>   -TARGET_CFLAGS += -ffunction-sections -fdata-sections
>> +TARGET_CFLAGS += -ffunction-sections -fdata-sections
>> -Wno-error=format-overflow
>>   TARGET_LDFLAGS += -Wl,--gc-sections
>>   CMAKE_OPTIONS += $(if $(CONFIG_IPV6),,-DDISABLE_IPV6=1)
>>   diff --git a/package/system/procd/Makefile
>> b/package/system/procd/Makefile
>> index 5971e0293d..c47ff23352 100644
>> --- a/package/system/procd/Makefile
>> +++ b/package/system/procd/Makefile
>> @@ -37,6 +37,8 @@ endif
>>   CMAKE_OPTIONS += -DEARLY_PATH="$(TARGET_INIT_PATH)"
>>   TARGET_LDFLAGS += $(if $(CONFIG_USE_GLIBC),-lrt)
>>   +TARGET_CFLAGS += -Wno-error=format-truncation
>> +
>>   define Package/procd
>> SECTION:=base
>> CATEGORY:=Base system
>
>
> NAK.
>
> Please fix the errors instead of hiding the warning. Both packages are
> OpenWrt specific ones. Shouldn't be that difficult to get the fixes applied.
>
> Mathias
>

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/3] toolchain/gcc: add GCC 8.1.0

2018-06-21 Thread Syrone Wong
HI,

We are using FFmpeg 3.2.10, it was cut from master on 2016-10-26,
definitely has no fixes to GCC 8, you may want to check the latest
4.0.1. 4.0.1 was released on 2018-06-16. It is the latest stable
FFmpeg release from the 4.0 release branch, which was cut from master
on 2018-04-16.

You can disable FFmpeg temporarily and make sure other important
components are working as expected, e.g. kernel, busybox, procd,
firewall3, etc.


Best Regards,
Syrone Wong


On Fri, Jun 22, 2018 at 2:07 AM, Rosen Penev  wrote:
> Error while compiling ffmpeg:
>
> GNU assembler not found, install/update gas-preprocessor
>
>
> On Thu, Jun 21, 2018 at 8:09 AM  wrote:
>>
>> From: Syrone Wong 
>>
>> Changes compared to GCC 7.x
>>
>> 001-revert_register_mode_search.patch dropped
>>
>> The commit guards comparison via maybe_gt(), while 
>> 001-revert_register_mode_search.patch simply ignore
>> "GET_MODE_SIZE (mode) > GET_MODE_SIZE (found_mode)", the powerpc issue might 
>> be fixed, I'm not pretty sure.
>>
>> upstream commit: 
>> https://github.com/gcc-mirror/gcc/commit/52acb7aee19f4bb33e76819907eff343bf4f42e8
>>
>> 020-PR-libstdc-81797-Add-.NOTPARALLEL-to-include-Makefil.patch dropped due 
>> to already upstream
>>
>> 100-PR-rtl-optimization-83496.patch dropped due to already upstream
>>
>> 910-mbsd_multi.patch
>> modified to fix ambiguous overloaded inform() call error
>>
>> gcc/input.h
>> header: define UNKNOWN_LOCATION ((source_location) 0)
>>
>> -inform (0, "someone does not honour COPTS correctly, passed %d 
>> times",
>> - honour_copts);
>> +inform (UNKNOWN_LOCATION, "someone does not honour COPTS correctly, 
>> passed %d times",
>> + honour_copts);
>>
>> 940-no-clobber-stamp-bits.patch dropped due to fixed upstream by another way
>> upstream commit: 
>> https://github.com/gcc-mirror/gcc/commit/87b2d547f8ac9778d66909b8726fe967d1efbc74
>>
>> 950-cpp_file_path_translation.patch dropped, Both -fmacro-prefix-map and 
>> -ffile-prefix-map are added
>> to gcc 8.1.0, if I understand it correctly, we should use -fmacro-prefix-map
>> usage: -fmacro-prefix-map=@var{old}=@var{new}
>> upstream commit: 
>> https://github.com/gcc-mirror/gcc/commit/859b51f83662d01e4f158ea9327db9ca37fe70b3
>>
>> -iremap exists as a flag for a long time, for backward compatibility, I 
>> think we should keep the
>> variable name unchanged but change its value in rules.mk for gcc 8.x and 
>> higher.
>>
>> Compile and run tested on x86_64
>>
>> Signed-off-by: Syrone Wong 
>> ---
>>  toolchain/gcc/Config.in   |   3 +
>>  toolchain/gcc/Config.version  |   5 +
>>  toolchain/gcc/common.mk   |   4 +
>>  .../patches/8.1.0/002-case_insensitive.patch  |  24 +++
>>  .../gcc/patches/8.1.0/010-documentation.patch |  35 
>>  .../patches/8.1.0/110-Fix-MIPS-PR-84790.patch |  20 +++
>>  .../gcc/patches/8.1.0/230-musl_libssp.patch   |  13 ++
>>  .../300-mips_Os_cpu_rtx_cost_model.patch  |  21 +++
>>  .../8.1.0/800-arm_v5te_no_ldrd_strd.patch |  11 ++
>>  .../8.1.0/810-arm-softfloat-libgcc.patch  |  33 
>>  .../gcc/patches/8.1.0/820-libgcc_pic.patch|  44 +
>>  .../8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch |  28 +++
>>  .../patches/8.1.0/850-use_shared_libgcc.patch |  54 ++
>>  .../patches/8.1.0/851-libgcc_no_compat.patch  |  22 +++
>>  .../patches/8.1.0/870-ppc_no_crtsavres.patch  |  11 ++
>>  .../gcc/patches/8.1.0/881-no_tm_section.patch |  11 ++
>>  .../patches/8.1.0/900-bad-mips16-crt.patch|   9 +
>>  .../gcc/patches/8.1.0/910-mbsd_multi.patch| 146 +++
>>  .../8.1.0/920-specs_nonfatal_getenv.patch |  22 +++
>>  .../8.1.0/930-fix-mips-noexecstack.patch  | 111 
>>  ...ibffi-fix-MIPS-softfloat-build-issue.patch | 168 ++
>>  ...mpilation-when-making-cross-compiler.patch |  67 +++
>>  22 files changed, 862 insertions(+)
>>  create mode 100644 toolchain/gcc/patches/8.1.0/002-case_insensitive.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/010-documentation.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/110-Fix-MIPS-PR-84790.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/230-musl_libssp.patch
>>  create mode 100644 
>> toolchain/gcc/patches/8.1.0/300-mips_Os_cpu_rtx_cost_model.patch
>>  create mode 100644 
>> toolchain/gcc/patches/8.1.0/800-arm_v5te_no_ldrd_strd.patch
>>  create mode 100644 
>> toolchain/gcc/patches/8.1.0/810-arm-softfloat-libgcc.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/820-libgcc_pic.patch
>>  create mode 100644 
>> toolchain/gcc/patches/8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/850-use_shared_libgcc.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/851-libgcc_no_compat.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/870-ppc_no_crtsavres.patch
>>  create mode 100644 toolchain/gcc/patches/8.1.0/881-no_tm_section.patch
>>  create mode 100644 

[OpenWrt-Devel] [PATCH] firewall3: Fix GCC8 warnings by replacing sprintf with snprintf

2018-06-21 Thread Rosen Penev
error: ‘%u’ directive writing between 1 and 10 bytes into a region of size
between 7 and 11 [-Werror=format-overflow=]
sprintf(buf, "%u-%u", port->port_min, port->port_max);
 ^~
note: directive argument in the range [0, 2147483647]
sprintf(buf, "%u-%u", port->port_min, port->port_max);
 ^~~
note: ‘sprintf’ output between 4 and 17 bytes into a destination of size
13
sprintf(buf, "%u-%u", port->port_min, port->port_max);

Signed-off-by: Rosen Penev 
---
 iptables.c  | 8 
 redirects.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/iptables.c b/iptables.c
index f8d4d46..adf64c0 100644
--- a/iptables.c
+++ b/iptables.c
@@ -899,7 +899,7 @@ fw3_ipt_rule_sport_dport(struct fw3_ipt_rule *r,
if (sp->port_min == sp->port_max)
sprintf(buf, "%u", sp->port_min);
else
-   sprintf(buf, "%u:%u", sp->port_min, sp->port_max);
+   snprintf(buf, sizeof(buf), "%u:%u", sp->port_min, 
sp->port_max);
 
fw3_ipt_rule_addarg(r, sp->invert, "--sport", buf);
}
@@ -909,7 +909,7 @@ fw3_ipt_rule_sport_dport(struct fw3_ipt_rule *r,
if (dp->port_min == dp->port_max)
sprintf(buf, "%u", dp->port_min);
else
-   sprintf(buf, "%u:%u", dp->port_min, dp->port_max);
+   snprintf(buf, sizeof(buf), "%u:%u", dp->port_min, 
dp->port_max);
 
fw3_ipt_rule_addarg(r, dp->invert, "--dport", buf);
}
@@ -955,7 +955,7 @@ fw3_ipt_rule_icmptype(struct fw3_ipt_rule *r, struct 
fw3_icmptype *icmp)
if (icmp->code6_min == 0 && icmp->code6_max == 0xFF)
sprintf(buf, "%u", icmp->type6);
else
-   sprintf(buf, "%u/%u", icmp->type6, icmp->code6_min);
+   snprintf(buf, sizeof(buf), "%u/%u", icmp->type6, 
icmp->code6_min);
 
fw3_ipt_rule_addarg(r, icmp->invert, "--icmpv6-type", buf);
}
@@ -965,7 +965,7 @@ fw3_ipt_rule_icmptype(struct fw3_ipt_rule *r, struct 
fw3_icmptype *icmp)
if (icmp->code_min == 0 && icmp->code_max == 0xFF)
sprintf(buf, "%u", icmp->type);
else
-   sprintf(buf, "%u/%u", icmp->type, icmp->code_min);
+   snprintf(buf, sizeof(buf), "%u/%u", icmp->type, 
icmp->code_min);
 
fw3_ipt_rule_addarg(r, icmp->invert, "--icmp-type", buf);
}
diff --git a/redirects.c b/redirects.c
index 7f9948c..6cd09f1 100644
--- a/redirects.c
+++ b/redirects.c
@@ -466,7 +466,7 @@ set_redirect(struct fw3_ipt_rule *r, struct fw3_port *port)
if (port->port_min == port->port_max)
sprintf(buf, "%u", port->port_min);
else
-   sprintf(buf, "%u-%u", port->port_min, port->port_max);
+   snprintf(buf, sizeof(buf), "%u-%u", port->port_min, 
port->port_max);
 
fw3_ipt_rule_addarg(r, false, "--to-ports", buf);
}
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] procd: Fix compile error with GCC8

2018-06-21 Thread Arjen de Korte

Citeren John Crispin :


On 21/06/18 22:58, Rosen Penev wrote:

error: ‘%d’ directive output may be truncated writing between 2 and 10
bytes into a region of size 3 [-Werror=format-truncation=]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
^~~
note: directive argument in the range [0, 2147483647]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
   ^
note: ‘snprintf’ output between 3 and 11 bytes into a destination of size
3
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);

Signed-off-by: Rosen Penev 
---
 watchdog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/watchdog.c b/watchdog.c
index ec10ba6..efe30f1 100644
--- a/watchdog.c
+++ b/watchdog.c
@@ -144,8 +144,9 @@ char* watchdog_fd(void)
 {
static char fd_buf[3];
 -  if (wdt_fd < 0)
+   if (wdt_fd < 0 || wdt_fd > 99)
return NULL;
+
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);

imho the %d should be changed to %ld or something similar.


That's not the problem here. The fd_buf is only large enough to store  
values between 0 and 99 (inclusive). Although this will fix the  
compilation warning/error, I'm slightly worried that this may confuse  
callers when the filedescriptor is > 99. Before this patch, you'd get  
a truncated value (the first two digits), after there will be no  
difference between an error condition (wdt_fd < 0) or a filedescriptor  
that is too large to fit in the static fd_buf.


The wdt_fd is defined as an 'int', so %d is appropriate here.


return fd_buf;



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel





___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] procd: Fix compile error with GCC8

2018-06-21 Thread John Crispin



On 21/06/18 22:58, Rosen Penev wrote:

error: ‘%d’ directive output may be truncated writing between 2 and 10
bytes into a region of size 3 [-Werror=format-truncation=]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
 ^~~
note: directive argument in the range [0, 2147483647]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
^
note: ‘snprintf’ output between 3 and 11 bytes into a destination of size
3
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);

Signed-off-by: Rosen Penev 
---
  watchdog.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/watchdog.c b/watchdog.c
index ec10ba6..efe30f1 100644
--- a/watchdog.c
+++ b/watchdog.c
@@ -144,8 +144,9 @@ char* watchdog_fd(void)
  {
static char fd_buf[3];
  
-	if (wdt_fd < 0)

+   if (wdt_fd < 0 || wdt_fd > 99)
return NULL;
+
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);

imho the %d should be changed to %ld or something similar.
  
  	return fd_buf;



___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] procd: Fix compile error with GCC8

2018-06-21 Thread Rosen Penev
error: ‘%d’ directive output may be truncated writing between 2 and 10
bytes into a region of size 3 [-Werror=format-truncation=]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
^~~
note: directive argument in the range [0, 2147483647]
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
   ^
note: ‘snprintf’ output between 3 and 11 bytes into a destination of size
3
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);

Signed-off-by: Rosen Penev 
---
 watchdog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/watchdog.c b/watchdog.c
index ec10ba6..efe30f1 100644
--- a/watchdog.c
+++ b/watchdog.c
@@ -144,8 +144,9 @@ char* watchdog_fd(void)
 {
static char fd_buf[3];
 
-   if (wdt_fd < 0)
+   if (wdt_fd < 0 || wdt_fd > 99)
return NULL;
+
snprintf(fd_buf, sizeof(fd_buf), "%d", wdt_fd);
 
return fd_buf;
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH v2] kernel: bump 4.14 to 4.14.51

2018-06-21 Thread Rosen Penev
On Thu, Jun 21, 2018 at 12:24 PM Kevin Darbyshire-Bryant via
openwrt-devel  wrote:
>
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
>
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
>
>
> -- Forwarded message --
> From: Kevin Darbyshire-Bryant 
> To: openwrt-devel@lists.openwrt.org
> Cc: Kevin Darbyshire-Bryant 
> Bcc:
> Date: Thu, 21 Jun 2018 20:23:38 +0100
> Subject: [PATCH v2] kernel: bump 4.14 to 4.14.51
> Refresh patches.
>
> Remove patch that can be reverse applied:
> mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch
> mvebu/patches-4.14/531-ATA-ahci_mvebu-pmp-stop-errata-226.patch
>
> Update patch that no longer applied:
> ipq806x/patches-4.14/0035-clk-mux-Split-out-register-accessors-for-reuse.patch
>
> Compiled-tested-for: lantiq, ramips
> Run-tested-on: lantiq BT hh5a, ramips MIR3g
>
> Signed-off-by: Kevin Darbyshire-Bryant 
Tested-by: Rosen Penev 

ethernet speed has returned on the R7800.
> ---
> v2 - actually it turns out 531-ATA-achi... isn't required & causes build
> failure - oops!  Thanks to Gerard Looije for pointing out the error in
> my ways :-)
>
>  include/kernel-version.mk  |   4 +-
>  ...stmmac-Disable-frame-filtering-completely.patch |   2 +-
>  16-netfilter-flow-table-support-for-IPv6.patch |   2 +-
>  ...r-improve-flow-table-Kconfig-dependencies.patch |   2 +-
>  ...lowtable-infrastructure-depends-on-NETFIL.patch |   2 +-
>  .../650-netfilter-add-xt_OFFLOAD-target.patch  |   4 +-
>  .../902-essedma-alloc-skb-ip-align.patch   |   7 +-
>  .../patches-4.14/997-device_tree_cmdline.patch |   4 +-
>  ...ux-Split-out-register-accessors-for-reuse.patch |   6 +-
>  .../patches-4.14/0069-arm-boot-add-dts-files.patch |  12 +-
>  .../0012-clk-dont-disable-unused-clocks.patch  |   2 +-
>  ...TA-ahci_mvebu-enable-stop_engine-override.patch | 224 
> -
>  .../531-ATA-ahci_mvebu-pmp-stop-errata-226.patch   | 110 --
>  13 files changed, 21 insertions(+), 360 deletions(-)
>  delete mode 100644 
> target/linux/mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch
>  delete mode 100644 
> target/linux/mvebu/patches-4.14/531-ATA-ahci_mvebu-pmp-stop-errata-226.patch
>
> diff --git a/include/kernel-version.mk b/include/kernel-version.mk
> index 825a227915..52a8433ec6 100644
> --- a/include/kernel-version.mk
> +++ b/include/kernel-version.mk
> @@ -5,12 +5,12 @@ LINUX_RELEASE?=1
>  LINUX_VERSION-3.18 = .71
>  LINUX_VERSION-4.4 = .121
>  LINUX_VERSION-4.9 = .109
> -LINUX_VERSION-4.14 = .50
> +LINUX_VERSION-4.14 = .51
>
>  LINUX_KERNEL_HASH-3.18.71 = 
> 5abc9778ad44ce02ed6c8ab52ece8a21c6d20d21f6ed8a19287b4a38a50c1240
>  LINUX_KERNEL_HASH-4.4.121 = 
> 44a88268b5088dc326b30c9b9133ac35a9a200b636b7268d08f32abeae6ca729
>  LINUX_KERNEL_HASH-4.9.109 = 
> 3dcd5654a553432119492b69e649c4ed117781bfd571edcb02346c945be359b0
> -LINUX_KERNEL_HASH-4.14.50 = 
> 703a8d013b25dc428d936f72858fa0c702c22cb3114a040fb9bb47562e4ea2ac
> +LINUX_KERNEL_HASH-4.14.51 = 
> dab2402baa2444348f9b3c354e8f65382a466d1766942a57441209f9a2df972b
>
>  remove_uri_prefix=$(subst git://,,$(subst http://,,$(subst https://,,$(1
>  sanitize_uri=$(call qstrip,$(subst @,_,$(subst :,_,$(subst .,_,$(subst 
> -,_,$(subst /,_,$(1)))
> diff --git 
> a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
>  
> b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
> index 58094ae96d..e63c2e934b 100644
> --- 
> a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
> +++ 
> b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
> @@ -20,7 +20,7 @@ Signed-off-by: Alexey Brodkin 
>
>  --- a/drivers/net/ethernet/stmicro/stmmac/common.h
>  +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
> -@@ -49,7 +49,7 @@
> +@@ -46,7 +46,7 @@
>   #define STMMAC_GET_ENTRY(x, size) ((x + 1) & (size - 1))
>
>   #undef FRAME_FILTER_DEBUG
> diff --git 
> a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
>  
> b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
> index a561f2669d..874195558c 100644
> --- 
> a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
> +++ 
> b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
> @@ -45,7 +45,7 @@ Signed-off-by: Pablo Neira Ayuso 
>   {
>  --- a/net/ipv6/netfilter/Kconfig
>  +++ b/net/ipv6/netfilter/Kconfig
> -@@ -71,6 +71,14 @@ config NFT_FIB_IPV6
> +@@ -99,6 +99,14 @@ config NFT_FIB_IPV6
>   endif # NF_TABLES_IPV6
>   endif # NF_TABLES
>
> diff --git 
> a/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
>  
> 

Re: [OpenWrt-Devel] [PATCH v2] kernel: bump 4.14 to 4.14.51

2018-06-21 Thread Michael Yartys via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---

Tested-by: Michael Yartys  

Compile-tested on: ipq806x 
Runtime-tested on: ipq806x

--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] kernel: atm: pppoatm fix vc-mux connection failures

2018-06-21 Thread Paul Oranje
that's really quick, congratulations !

> Op 18 jun. 2018, om 11:08 heeft Kevin Darbyshire-Bryant via openwrt-devel 
>  het volgende geschreven:
> 
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
> 
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
> Van: Kevin Darbyshire-Bryant 
> Onderwerp: [PATCH] kernel: atm: pppoatm fix vc-mux connection failures
> Datum: 18 juni 2018 om 11:07:41 CEST
> Aan: openwrt-devel@lists.openwrt.org
> Kopie: Kevin Darbyshire-Bryant 
> 
> 
> Backport a hot off the press upstream kernel ATM fix:
> 
> Preserve value of skb->truesize when accounting to vcc
> 
> "There's a hack in pskb_expand_head() to avoid adjusting skb->truesize
> for certain skbs. Ideally it would cover ATM too. It doesn't. Just
> stashing the accounted value and using it in atm_raw_pop() is probably
> the easiest way to cope."
> 
> The issue was exposed by upstream with:
> 
> commit 14afee4b6092fde451ee17604e5f5c89da33e71e
> Author: Reshetova, Elena 
> Date:   Fri Jun 30 13:08:00 2017 +0300
> 
>net: convert sock.sk_wmem_alloc from atomic_t to refcount_t
> 
> But an earlier commit left the ticking timebomb:
> 
> 158f323b9868 ("net: adjust skb->truesize in pskb_expand_head()
> 
> Sincerest thanks to Mathias Kresin  for debugging
> assistance and to David Woodhouse  for further
> guidance, cajoling & patience in interpreting the debug I was giving him
> and producing a fix!
> 
> Fixes FS#1567
> 
> Signed-off-by: Kevin Darbyshire-Bryant 
> ---
> ...-sock.sk_wmem_alloc-from-atomic_t-to-refc.patch | 172 +
> 1 file changed, 172 insertions(+)
> create mode 100644 
> target/linux/generic/backport-4.14/080-net-convert-sock.sk_wmem_alloc-from-atomic_t-to-refc.patch
> 
> diff --git 
> a/target/linux/generic/backport-4.14/080-net-convert-sock.sk_wmem_alloc-from-atomic_t-to-refc.patch
>  
> b/target/linux/generic/backport-4.14/080-net-convert-sock.sk_wmem_alloc-from-atomic_t-to-refc.patch
> new file mode 100644
> index 00..06d00886f1
> --- /dev/null
> +++ 
> b/target/linux/generic/backport-4.14/080-net-convert-sock.sk_wmem_alloc-from-atomic_t-to-refc.patch
> @@ -0,0 +1,172 @@
> +From 9bbe60a67be5a1c6f79b3c9be5003481a50529ff Mon Sep 17 00:00:00 2001
> +From: David Woodhouse 
> +Date: Sat, 16 Jun 2018 11:55:44 +0100
> +Subject: atm: Preserve value of skb->truesize when accounting to vcc
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +ATM accounts for in-flight TX packets in sk_wmem_alloc of the VCC on
> +which they are to be sent. But it doesn't take ownership of those
> +packets from the sock (if any) which originally owned them. They should
> +remain owned by their actual sender until they've left the box.
> +
> +There's a hack in pskb_expand_head() to avoid adjusting skb->truesize
> +for certain skbs, precisely to avoid messing up sk_wmem_alloc
> +accounting. Ideally that hack would cover the ATM use case too, but it
> +doesn't — skbs which aren't owned by any sock, for example PPP control
> +frames, still get their truesize adjusted when the low-level ATM driver
> +adds headroom.
> +
> +This has always been an issue, it seems. The truesize of a packet
> +increases, and sk_wmem_alloc on the VCC goes negative. But this wasn't
> +for normal traffic, only for control frames. So I think we just got away
> +with it, and we probably needed to send 2GiB of LCP echo frames before
> +the misaccounting would ever have caused a problem and caused
> +atm_may_send() to start refusing packets.
> +
> +Commit 14afee4b609 ("net: convert sock.sk_wmem_alloc from atomic_t to
> +refcount_t") did exactly what it was intended to do, and turned this
> +mostly-theoretical problem into a real one, causing PPPoATM to fail
> +immediately as sk_wmem_alloc underflows and atm_may_send() *immediately*
> +starts refusing to allow new packets.
> +
> +The least intrusive solution to this problem is to stash the value of
> +skb->truesize that was accounted to the VCC, in a new member of the
> +ATM_SKB(skb) structure. Then in atm_pop_raw() subtract precisely that
> +value instead of the then-current value of skb->truesize.
> +
> +Fixes: 158f323b9868 ("net: adjust skb->truesize in pskb_expand_head()")
> +Signed-off-by: David Woodhouse 
> +Tested-by: Kevin Darbyshire-Bryant 
> +Signed-off-by: David S. Miller 
> +---
> + include/linux/atmdev.h | 15 +++
> + net/atm/br2684.c   |  3 +--
> + net/atm/clip.c |  3 +--
> + net/atm/common.c   |  3 +--
> + net/atm/lec.c  |  3 +--
> + net/atm/mpc.c  |  3 +--
> + net/atm/pppoatm.c  |  3 +--
> + net/atm/raw.c  |  4 ++--
> + 8 files changed, 23 insertions(+), 14 deletions(-)
> +
> +--- a/include/linux/atmdev.h
>  b/include/linux/atmdev.h
> +@@ -214,6 +214,7 @@ struct atmphy_ops {
> + struct atm_skb_data {
> + struct atm_vcc  

Re: [OpenWrt-Devel] 18.06: Cherry pick mtu fix

2018-06-21 Thread Mathias Kresin

21.06.2018 21:18, Jaap Buurman:

Dear Kevin,

Some very good points you are giving. Is there anyone able and willing
to cherry-pick these 3 commits to the 18.06 branch before the RC1
release is tagged tomorrow?



At least I'll not do so.

I would like to see this change a bit more tested in master. The code is 
shared between all mediatek mips SoCs and might cause regressions for 
the other SoCs.


Considering that it took near to two months for the first public report 
of the mtu regression after making k4.14 the default, I don't feel 
comfortable to assume that five days in master are enough for testing.


Mathias

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH v2] kernel: bump 4.14 to 4.14.51

2018-06-21 Thread Kevin Darbyshire-Bryant via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Refresh patches.

Remove patch that can be reverse applied:
mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch
mvebu/patches-4.14/531-ATA-ahci_mvebu-pmp-stop-errata-226.patch

Update patch that no longer applied:
ipq806x/patches-4.14/0035-clk-mux-Split-out-register-accessors-for-reuse.patch

Compiled-tested-for: lantiq, ramips
Run-tested-on: lantiq BT hh5a, ramips MIR3g

Signed-off-by: Kevin Darbyshire-Bryant 
---
v2 - actually it turns out 531-ATA-achi... isn't required & causes build
failure - oops!  Thanks to Gerard Looije for pointing out the error in
my ways :-)

 include/kernel-version.mk  |   4 +-
 ...stmmac-Disable-frame-filtering-completely.patch |   2 +-
 16-netfilter-flow-table-support-for-IPv6.patch |   2 +-
 ...r-improve-flow-table-Kconfig-dependencies.patch |   2 +-
 ...lowtable-infrastructure-depends-on-NETFIL.patch |   2 +-
 .../650-netfilter-add-xt_OFFLOAD-target.patch  |   4 +-
 .../902-essedma-alloc-skb-ip-align.patch   |   7 +-
 .../patches-4.14/997-device_tree_cmdline.patch |   4 +-
 ...ux-Split-out-register-accessors-for-reuse.patch |   6 +-
 .../patches-4.14/0069-arm-boot-add-dts-files.patch |  12 +-
 .../0012-clk-dont-disable-unused-clocks.patch  |   2 +-
 ...TA-ahci_mvebu-enable-stop_engine-override.patch | 224 -
 .../531-ATA-ahci_mvebu-pmp-stop-errata-226.patch   | 110 --
 13 files changed, 21 insertions(+), 360 deletions(-)
 delete mode 100644 
target/linux/mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch
 delete mode 100644 
target/linux/mvebu/patches-4.14/531-ATA-ahci_mvebu-pmp-stop-errata-226.patch

diff --git a/include/kernel-version.mk b/include/kernel-version.mk
index 825a227915..52a8433ec6 100644
--- a/include/kernel-version.mk
+++ b/include/kernel-version.mk
@@ -5,12 +5,12 @@ LINUX_RELEASE?=1
 LINUX_VERSION-3.18 = .71
 LINUX_VERSION-4.4 = .121
 LINUX_VERSION-4.9 = .109
-LINUX_VERSION-4.14 = .50
+LINUX_VERSION-4.14 = .51
 
 LINUX_KERNEL_HASH-3.18.71 = 
5abc9778ad44ce02ed6c8ab52ece8a21c6d20d21f6ed8a19287b4a38a50c1240
 LINUX_KERNEL_HASH-4.4.121 = 
44a88268b5088dc326b30c9b9133ac35a9a200b636b7268d08f32abeae6ca729
 LINUX_KERNEL_HASH-4.9.109 = 
3dcd5654a553432119492b69e649c4ed117781bfd571edcb02346c945be359b0
-LINUX_KERNEL_HASH-4.14.50 = 
703a8d013b25dc428d936f72858fa0c702c22cb3114a040fb9bb47562e4ea2ac
+LINUX_KERNEL_HASH-4.14.51 = 
dab2402baa2444348f9b3c354e8f65382a466d1766942a57441209f9a2df972b
 
 remove_uri_prefix=$(subst git://,,$(subst http://,,$(subst https://,,$(1
 sanitize_uri=$(call qstrip,$(subst @,_,$(subst :,_,$(subst .,_,$(subst 
-,_,$(subst /,_,$(1)))
diff --git 
a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
 
b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
index 58094ae96d..e63c2e934b 100644
--- 
a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
+++ 
b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
@@ -20,7 +20,7 @@ Signed-off-by: Alexey Brodkin 
 
 --- a/drivers/net/ethernet/stmicro/stmmac/common.h
 +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
-@@ -49,7 +49,7 @@
+@@ -46,7 +46,7 @@
  #define STMMAC_GET_ENTRY(x, size) ((x + 1) & (size - 1))
  
  #undef FRAME_FILTER_DEBUG
diff --git 
a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
 
b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
index a561f2669d..874195558c 100644
--- 
a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
+++ 
b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
@@ -45,7 +45,7 @@ Signed-off-by: Pablo Neira Ayuso 
  {
 --- a/net/ipv6/netfilter/Kconfig
 +++ b/net/ipv6/netfilter/Kconfig
-@@ -71,6 +71,14 @@ config NFT_FIB_IPV6
+@@ -99,6 +99,14 @@ config NFT_FIB_IPV6
  endif # NF_TABLES_IPV6
  endif # NF_TABLES
  
diff --git 
a/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
 
b/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
index c897c36724..7174723fc9 100644
--- 
a/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
+++ 
b/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
@@ -72,7 +72,7 @@ Signed-off-by: Pablo Neira Ayuso 
  
 --- a/net/ipv6/netfilter/Kconfig
 +++ b/net/ipv6/netfilter/Kconfig
-@@ -72,8 +72,9 @@ endif # NF_TABLES_IPV6
+@@ -100,8 +100,9 @@ endif # NF_TABLES_IPV6
  endif # 

Re: [OpenWrt-Devel] [PATCH 3/3] package: ignore some new errors introduced by GCC 8

2018-06-21 Thread Mathias Kresin

21.06.2018 17:08, wong.syr...@gmail.com:

From: Syrone Wong 

Signed-off-by: Syrone Wong 
---
  package/network/config/firewall/Makefile | 2 +-
  package/system/procd/Makefile| 2 ++
  2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/network/config/firewall/Makefile 
b/package/network/config/firewall/Makefile
index 01fea237f3..43673cf777 100644
--- a/package/network/config/firewall/Makefile
+++ b/package/network/config/firewall/Makefile
@@ -40,7 +40,7 @@ define Package/firewall/conffiles
  /etc/firewall.user
  endef
  
-TARGET_CFLAGS += -ffunction-sections -fdata-sections

+TARGET_CFLAGS += -ffunction-sections -fdata-sections -Wno-error=format-overflow
  TARGET_LDFLAGS += -Wl,--gc-sections
  CMAKE_OPTIONS += $(if $(CONFIG_IPV6),,-DDISABLE_IPV6=1)
  
diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile

index 5971e0293d..c47ff23352 100644
--- a/package/system/procd/Makefile
+++ b/package/system/procd/Makefile
@@ -37,6 +37,8 @@ endif
  CMAKE_OPTIONS += -DEARLY_PATH="$(TARGET_INIT_PATH)"
  TARGET_LDFLAGS += $(if $(CONFIG_USE_GLIBC),-lrt)
  
+TARGET_CFLAGS += -Wno-error=format-truncation

+
  define Package/procd
SECTION:=base
CATEGORY:=Base system


NAK.

Please fix the errors instead of hiding the warning. Both packages are 
OpenWrt specific ones. Shouldn't be that difficult to get the fixes applied.


Mathias


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] 18.06: Cherry pick mtu fix

2018-06-21 Thread Jaap Buurman
Dear Kevin,

Some very good points you are giving. Is there anyone able and willing
to cherry-pick these 3 commits to the 18.06 branch before the RC1
release is tagged tomorrow?

Yours sincerely,

Jaap Buurman
On Thu, Jun 21, 2018 at 10:27 AM Kevin Darbyshire-Bryant
 wrote:
>
>
>
> > On 21 Jun 2018, at 08:13, Jaap Buurman  wrote:
> >
> > Dear all,
> >
> > The move to kernel 4.14 broke mtu settings larger than 1500 by
> > default, unless the correct mtu was explicitly specified. The
> > following commit fixes this for the mt7621 target:
> > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=5da2c68d001ee44b15a58639ed03a0ebb6f68020
> >
> > 1) Would it be possible for someone to cherry-pick this to the 18.06
> > branch, so that it can receive widespread testing in the upcoming
> > 18.06 RC1 release?
>
> Personally I’d also pick the preceding mtk driver commit "ec502cd3fe ramips: 
> rename ethernet driver folder to the same one that upstream uses” for clarity 
> & easier cherry-picks going forward for 18.06.  And I’d be very strongly 
> tempted to have 9a4253b81f ramips: improve ethernet driver performance with 
> GRO/TSO  as well…. which gets 18.06 into the same state as master for mtk eth 
> drivers.
>
> > 2) From the commit's message I get the impression this isn't an issue
> > with just mt7621, but with all targets that are able to handle a mtu >
> > 1500. Is my impression correct in this regard, and is this something
> > that should be fixed before a 18.06 release? Changing mtu settings >
> > 1500 does sound like basic functionality for routers nowadays.
>
> It is dependent upon the driver setting a suitable max_mtu in the netdev 
> structure *IF* it supports values greater than 1500.
>
> +   if (IS_ENABLED(CONFIG_SOC_MT7621))
> +   netdev->max_mtu = 2048;
>
> The version of driver included with kernel 4.14 at present is too dumb to 
> understand >1500 mtu, which is why openwrt replaces it with a version that 
> (now) does.
>
> That’s my opinion anyway :-)
>
> Kevin
>

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH v2 1/2] ath79: add Netgear WNR612 v2

2018-06-21 Thread Rafał Miłecki
On Wed, 20 Jun 2018 at 16:22, Zoltan HERPAI  wrote:
>
> Netgear WNR612 v2:
>  - cpu Atheros AR7240 (Python) @400MHz
>  - flash 4MB
>  - ram 32MB
>  - ethernet 10/100: 1xwan + 2xlan (only two)
>  - radio AR9285
>
> As there is a rebranded WNR612v2 called ON Networks N150R, add
> a dtsi which includes all device support, and add a separate dts
> for the device only (with a separate one for the subsequent N150R).
>
> Signed-off-by: Zoltan HERPAI 

Looks OK, thanks!

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCHv2] dropbear: Install to /(s)bin instead of /usr so OpenSSH can coexist

2018-06-21 Thread Rosen Penev
If you run opkg install openssh-client and then remove it, the ssh client
symlink that was initially there goes away. This avoids that problem.

Signed-off-by: Rosen Penev 
---
v2: Fixed new key generation
 package/network/services/dropbear/Makefile | 18 +-
 .../services/dropbear/files/dropbear.init  |  6 +++---
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/package/network/services/dropbear/Makefile 
b/package/network/services/dropbear/Makefile
index 21ac09f724..41f51b284b 100644
--- a/package/network/services/dropbear/Makefile
+++ b/package/network/services/dropbear/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=dropbear
 PKG_VERSION:=2017.75
-PKG_RELEASE:=5
+PKG_RELEASE:=6
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
 PKG_SOURCE_URL:= \
@@ -57,7 +57,7 @@ endef
 
 define Package/dropbear/conffiles
 /etc/dropbear/dropbear_rsa_host_key
-/etc/config/dropbear 
+/etc/config/dropbear
 endef
 
 define Package/dropbearconvert
@@ -128,13 +128,13 @@ define Build/Compile
 endef
 
 define Package/dropbear/install
-   $(INSTALL_DIR) $(1)/usr/sbin
-   $(INSTALL_BIN) $(PKG_BUILD_DIR)/dropbearmulti $(1)/usr/sbin/dropbear
-   $(INSTALL_DIR) $(1)/usr/bin
-   $(LN) ../sbin/dropbear $(1)/usr/bin/scp
-   $(LN) ../sbin/dropbear $(1)/usr/bin/ssh
-   $(LN) ../sbin/dropbear $(1)/usr/bin/dbclient
-   $(LN) ../sbin/dropbear $(1)/usr/bin/dropbearkey
+   $(INSTALL_DIR) $(1)/sbin
+   $(INSTALL_BIN) $(PKG_BUILD_DIR)/dropbearmulti $(1)/sbin/dropbear
+   $(INSTALL_DIR) $(1)/bin
+   $(LN) ../sbin/dropbear $(1)/bin/scp
+   $(LN) ../sbin/dropbear $(1)/bin/ssh
+   $(LN) ../sbin/dropbear $(1)/bin/dbclient
+   $(LN) ../sbin/dropbear $(1)/bin/dropbearkey
$(INSTALL_DIR) $(1)/etc/config
$(INSTALL_DATA) ./files/dropbear.config $(1)/etc/config/dropbear
$(INSTALL_DIR) $(1)/etc/init.d
diff --git a/package/network/services/dropbear/files/dropbear.init 
b/package/network/services/dropbear/files/dropbear.init
index 2225113498..e40cdb2bd5 100755
--- a/package/network/services/dropbear/files/dropbear.init
+++ b/package/network/services/dropbear/files/dropbear.init
@@ -6,7 +6,7 @@ START=50
 STOP=50
 
 USE_PROCD=1
-PROG=/usr/sbin/dropbear
+PROG=/sbin/dropbear
 NAME=dropbear
 PIDCOUNT=0
 EXTRA_COMMANDS="killclients"
@@ -96,8 +96,8 @@ keygen()
[ -f /tmp/$key -o -s /etc/$key ] || {
# generate missing keys
mkdir -p /tmp/dropbear
-   [ -x /usr/bin/dropbearkey ] && {
-   /usr/bin/dropbearkey -t $keytype -f /tmp/$key 
2>&- >&- && exec /etc/rc.common "$initscript" start
+   [ -x /bin/dropbearkey ] && {
+   /bin/dropbearkey -t $keytype -f /tmp/$key 2>&- 
>&- && exec /etc/rc.common "$initscript" start
} &
exit 0
}
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 1/3] toolchain/gcc: add GCC 8.1.0

2018-06-21 Thread Rosen Penev
Error while compiling ffmpeg:

GNU assembler not found, install/update gas-preprocessor


On Thu, Jun 21, 2018 at 8:09 AM  wrote:
>
> From: Syrone Wong 
>
> Changes compared to GCC 7.x
>
> 001-revert_register_mode_search.patch dropped
>
> The commit guards comparison via maybe_gt(), while 
> 001-revert_register_mode_search.patch simply ignore
> "GET_MODE_SIZE (mode) > GET_MODE_SIZE (found_mode)", the powerpc issue might 
> be fixed, I'm not pretty sure.
>
> upstream commit: 
> https://github.com/gcc-mirror/gcc/commit/52acb7aee19f4bb33e76819907eff343bf4f42e8
>
> 020-PR-libstdc-81797-Add-.NOTPARALLEL-to-include-Makefil.patch dropped due to 
> already upstream
>
> 100-PR-rtl-optimization-83496.patch dropped due to already upstream
>
> 910-mbsd_multi.patch
> modified to fix ambiguous overloaded inform() call error
>
> gcc/input.h
> header: define UNKNOWN_LOCATION ((source_location) 0)
>
> -inform (0, "someone does not honour COPTS correctly, passed %d 
> times",
> - honour_copts);
> +inform (UNKNOWN_LOCATION, "someone does not honour COPTS correctly, 
> passed %d times",
> + honour_copts);
>
> 940-no-clobber-stamp-bits.patch dropped due to fixed upstream by another way
> upstream commit: 
> https://github.com/gcc-mirror/gcc/commit/87b2d547f8ac9778d66909b8726fe967d1efbc74
>
> 950-cpp_file_path_translation.patch dropped, Both -fmacro-prefix-map and 
> -ffile-prefix-map are added
> to gcc 8.1.0, if I understand it correctly, we should use -fmacro-prefix-map
> usage: -fmacro-prefix-map=@var{old}=@var{new}
> upstream commit: 
> https://github.com/gcc-mirror/gcc/commit/859b51f83662d01e4f158ea9327db9ca37fe70b3
>
> -iremap exists as a flag for a long time, for backward compatibility, I think 
> we should keep the
> variable name unchanged but change its value in rules.mk for gcc 8.x and 
> higher.
>
> Compile and run tested on x86_64
>
> Signed-off-by: Syrone Wong 
> ---
>  toolchain/gcc/Config.in   |   3 +
>  toolchain/gcc/Config.version  |   5 +
>  toolchain/gcc/common.mk   |   4 +
>  .../patches/8.1.0/002-case_insensitive.patch  |  24 +++
>  .../gcc/patches/8.1.0/010-documentation.patch |  35 
>  .../patches/8.1.0/110-Fix-MIPS-PR-84790.patch |  20 +++
>  .../gcc/patches/8.1.0/230-musl_libssp.patch   |  13 ++
>  .../300-mips_Os_cpu_rtx_cost_model.patch  |  21 +++
>  .../8.1.0/800-arm_v5te_no_ldrd_strd.patch |  11 ++
>  .../8.1.0/810-arm-softfloat-libgcc.patch  |  33 
>  .../gcc/patches/8.1.0/820-libgcc_pic.patch|  44 +
>  .../8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch |  28 +++
>  .../patches/8.1.0/850-use_shared_libgcc.patch |  54 ++
>  .../patches/8.1.0/851-libgcc_no_compat.patch  |  22 +++
>  .../patches/8.1.0/870-ppc_no_crtsavres.patch  |  11 ++
>  .../gcc/patches/8.1.0/881-no_tm_section.patch |  11 ++
>  .../patches/8.1.0/900-bad-mips16-crt.patch|   9 +
>  .../gcc/patches/8.1.0/910-mbsd_multi.patch| 146 +++
>  .../8.1.0/920-specs_nonfatal_getenv.patch |  22 +++
>  .../8.1.0/930-fix-mips-noexecstack.patch  | 111 
>  ...ibffi-fix-MIPS-softfloat-build-issue.patch | 168 ++
>  ...mpilation-when-making-cross-compiler.patch |  67 +++
>  22 files changed, 862 insertions(+)
>  create mode 100644 toolchain/gcc/patches/8.1.0/002-case_insensitive.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/010-documentation.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/110-Fix-MIPS-PR-84790.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/230-musl_libssp.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/300-mips_Os_cpu_rtx_cost_model.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/800-arm_v5te_no_ldrd_strd.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/810-arm-softfloat-libgcc.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/820-libgcc_pic.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/850-use_shared_libgcc.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/851-libgcc_no_compat.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/870-ppc_no_crtsavres.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/881-no_tm_section.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/900-bad-mips16-crt.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/910-mbsd_multi.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/920-specs_nonfatal_getenv.patch
>  create mode 100644 toolchain/gcc/patches/8.1.0/930-fix-mips-noexecstack.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/931-libffi-fix-MIPS-softfloat-build-issue.patch
>  create mode 100644 
> toolchain/gcc/patches/8.1.0/960-gotools-fix-compilation-when-making-cross-compiler.patch
>
> diff --git a/toolchain/gcc/Config.in b/toolchain/gcc/Config.in
> index 37437900b1..c3208d372c 100644
> --- a/toolchain/gcc/Config.in
> +++ 

[OpenWrt-Devel] [PATCH] netfilter: add bpf match support

2018-06-21 Thread Alin Nastac
Add xt_bpf modules to {kmod-ipt,iptables-mod}-filter.

Match using Linux Socket Filter. Expects a BPF program in decimal
format. This is the format generated by the nfbpf_compile utility.

Signed-off-by: Alin Nastac 
---
 include/netfilter.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/netfilter.mk b/include/netfilter.mk
index 5d532ce..510aa18 100644
--- a/include/netfilter.mk
+++ b/include/netfilter.mk
@@ -106,6 +106,7 @@ $(eval $(call 
nf_add,IPT_PHYSDEV,CONFIG_NETFILTER_XT_MATCH_PHYSDEV, $(P_XT)xt_ph
 # filter
 
 $(eval $(call nf_add,IPT_FILTER,CONFIG_NETFILTER_XT_MATCH_STRING, 
$(P_XT)xt_string))
+$(eval $(call nf_add,IPT_FILTER,CONFIG_NETFILTER_XT_MATCH_BPF, $(P_XT)xt_bpf))
 
 
 # ipopt
-- 
2.7.4


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 3/3] package: ignore some new errors introduced by GCC 8

2018-06-21 Thread wong . syrone
From: Syrone Wong 

Signed-off-by: Syrone Wong 
---
 package/network/config/firewall/Makefile | 2 +-
 package/system/procd/Makefile| 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/network/config/firewall/Makefile 
b/package/network/config/firewall/Makefile
index 01fea237f3..43673cf777 100644
--- a/package/network/config/firewall/Makefile
+++ b/package/network/config/firewall/Makefile
@@ -40,7 +40,7 @@ define Package/firewall/conffiles
 /etc/firewall.user
 endef
 
-TARGET_CFLAGS += -ffunction-sections -fdata-sections
+TARGET_CFLAGS += -ffunction-sections -fdata-sections -Wno-error=format-overflow
 TARGET_LDFLAGS += -Wl,--gc-sections
 CMAKE_OPTIONS += $(if $(CONFIG_IPV6),,-DDISABLE_IPV6=1)
 
diff --git a/package/system/procd/Makefile b/package/system/procd/Makefile
index 5971e0293d..c47ff23352 100644
--- a/package/system/procd/Makefile
+++ b/package/system/procd/Makefile
@@ -37,6 +37,8 @@ endif
 CMAKE_OPTIONS += -DEARLY_PATH="$(TARGET_INIT_PATH)"
 TARGET_LDFLAGS += $(if $(CONFIG_USE_GLIBC),-lrt)
 
+TARGET_CFLAGS += -Wno-error=format-truncation
+
 define Package/procd
   SECTION:=base
   CATEGORY:=Base system
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-21 Thread wong . syrone
From: Syrone Wong 

The original -iremap is replaced by -fmacro-prefix-map in GCC 8

Signed-off-by: Syrone Wong 
---
 rules.mk | 4 
 1 file changed, 4 insertions(+)

diff --git a/rules.mk b/rules.mk
index a97b2d2155..8eb8e21a7e 100644
--- a/rules.mk
+++ b/rules.mk
@@ -141,6 +141,10 @@ endif
 
 ifeq ($(or 
$(CONFIG_EXTERNAL_TOOLCHAIN),$(CONFIG_GCC_VERSION_4_8),$(CONFIG_TARGET_uml)),)
   iremap = -iremap$(1):$(2)
+  # just overwrite iremap for GCC 8.1 and higher to keep backward compatibility
+  ifeq ($(CONFIG_GCC_VERSION_8),y)
+iremap = -fmacro-prefix-map=$(1)=$(2)
+  endif
 endif
 
 PACKAGE_DIR:=$(BIN_DIR)/packages
-- 
2.17.1


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 1/3] toolchain/gcc: add GCC 8.1.0

2018-06-21 Thread wong . syrone
From: Syrone Wong 

Changes compared to GCC 7.x

001-revert_register_mode_search.patch dropped

The commit guards comparison via maybe_gt(), while 
001-revert_register_mode_search.patch simply ignore
"GET_MODE_SIZE (mode) > GET_MODE_SIZE (found_mode)", the powerpc issue might be 
fixed, I'm not pretty sure.

upstream commit: 
https://github.com/gcc-mirror/gcc/commit/52acb7aee19f4bb33e76819907eff343bf4f42e8

020-PR-libstdc-81797-Add-.NOTPARALLEL-to-include-Makefil.patch dropped due to 
already upstream

100-PR-rtl-optimization-83496.patch dropped due to already upstream

910-mbsd_multi.patch
modified to fix ambiguous overloaded inform() call error

gcc/input.h
header: define UNKNOWN_LOCATION ((source_location) 0)

-inform (0, "someone does not honour COPTS correctly, passed %d times",
- honour_copts);
+inform (UNKNOWN_LOCATION, "someone does not honour COPTS correctly, 
passed %d times",
+ honour_copts);

940-no-clobber-stamp-bits.patch dropped due to fixed upstream by another way
upstream commit: 
https://github.com/gcc-mirror/gcc/commit/87b2d547f8ac9778d66909b8726fe967d1efbc74

950-cpp_file_path_translation.patch dropped, Both -fmacro-prefix-map and 
-ffile-prefix-map are added
to gcc 8.1.0, if I understand it correctly, we should use -fmacro-prefix-map
usage: -fmacro-prefix-map=@var{old}=@var{new}
upstream commit: 
https://github.com/gcc-mirror/gcc/commit/859b51f83662d01e4f158ea9327db9ca37fe70b3

-iremap exists as a flag for a long time, for backward compatibility, I think 
we should keep the
variable name unchanged but change its value in rules.mk for gcc 8.x and higher.

Compile and run tested on x86_64

Signed-off-by: Syrone Wong 
---
 toolchain/gcc/Config.in   |   3 +
 toolchain/gcc/Config.version  |   5 +
 toolchain/gcc/common.mk   |   4 +
 .../patches/8.1.0/002-case_insensitive.patch  |  24 +++
 .../gcc/patches/8.1.0/010-documentation.patch |  35 
 .../patches/8.1.0/110-Fix-MIPS-PR-84790.patch |  20 +++
 .../gcc/patches/8.1.0/230-musl_libssp.patch   |  13 ++
 .../300-mips_Os_cpu_rtx_cost_model.patch  |  21 +++
 .../8.1.0/800-arm_v5te_no_ldrd_strd.patch |  11 ++
 .../8.1.0/810-arm-softfloat-libgcc.patch  |  33 
 .../gcc/patches/8.1.0/820-libgcc_pic.patch|  44 +
 .../8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch |  28 +++
 .../patches/8.1.0/850-use_shared_libgcc.patch |  54 ++
 .../patches/8.1.0/851-libgcc_no_compat.patch  |  22 +++
 .../patches/8.1.0/870-ppc_no_crtsavres.patch  |  11 ++
 .../gcc/patches/8.1.0/881-no_tm_section.patch |  11 ++
 .../patches/8.1.0/900-bad-mips16-crt.patch|   9 +
 .../gcc/patches/8.1.0/910-mbsd_multi.patch| 146 +++
 .../8.1.0/920-specs_nonfatal_getenv.patch |  22 +++
 .../8.1.0/930-fix-mips-noexecstack.patch  | 111 
 ...ibffi-fix-MIPS-softfloat-build-issue.patch | 168 ++
 ...mpilation-when-making-cross-compiler.patch |  67 +++
 22 files changed, 862 insertions(+)
 create mode 100644 toolchain/gcc/patches/8.1.0/002-case_insensitive.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/010-documentation.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/110-Fix-MIPS-PR-84790.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/230-musl_libssp.patch
 create mode 100644 
toolchain/gcc/patches/8.1.0/300-mips_Os_cpu_rtx_cost_model.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/800-arm_v5te_no_ldrd_strd.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/810-arm-softfloat-libgcc.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/820-libgcc_pic.patch
 create mode 100644 
toolchain/gcc/patches/8.1.0/840-armv4_pass_fix-v4bx_to_ld.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/850-use_shared_libgcc.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/851-libgcc_no_compat.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/870-ppc_no_crtsavres.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/881-no_tm_section.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/900-bad-mips16-crt.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/910-mbsd_multi.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/920-specs_nonfatal_getenv.patch
 create mode 100644 toolchain/gcc/patches/8.1.0/930-fix-mips-noexecstack.patch
 create mode 100644 
toolchain/gcc/patches/8.1.0/931-libffi-fix-MIPS-softfloat-build-issue.patch
 create mode 100644 
toolchain/gcc/patches/8.1.0/960-gotools-fix-compilation-when-making-cross-compiler.patch

diff --git a/toolchain/gcc/Config.in b/toolchain/gcc/Config.in
index 37437900b1..c3208d372c 100644
--- a/toolchain/gcc/Config.in
+++ b/toolchain/gcc/Config.in
@@ -20,6 +20,9 @@ choice
bool "gcc 7.x"
depends on !arc
 
+   config GCC_USE_VERSION_8
+   bool "gcc 8.x"
+   depends on !arc
 endchoice
 
 config GCC_USE_GRAPHITE
diff --git a/toolchain/gcc/Config.version b/toolchain/gcc/Config.version
index 

Re: [OpenWrt-Devel] 18.06: Cherry pick mtu fix

2018-06-21 Thread Kevin Darbyshire-Bryant via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---


> On 21 Jun 2018, at 08:13, Jaap Buurman  wrote:
> 
> Dear all,
> 
> The move to kernel 4.14 broke mtu settings larger than 1500 by
> default, unless the correct mtu was explicitly specified. The
> following commit fixes this for the mt7621 target:
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=5da2c68d001ee44b15a58639ed03a0ebb6f68020
> 
> 1) Would it be possible for someone to cherry-pick this to the 18.06
> branch, so that it can receive widespread testing in the upcoming
> 18.06 RC1 release?

Personally I’d also pick the preceding mtk driver commit "ec502cd3fe ramips: 
rename ethernet driver folder to the same one that upstream uses” for clarity & 
easier cherry-picks going forward for 18.06.  And I’d be very strongly tempted 
to have 9a4253b81f ramips: improve ethernet driver performance with GRO/TSO  as 
well…. which gets 18.06 into the same state as master for mtk eth drivers.

> 2) From the commit's message I get the impression this isn't an issue
> with just mt7621, but with all targets that are able to handle a mtu >
> 1500. Is my impression correct in this regard, and is this something
> that should be fixed before a 18.06 release? Changing mtu settings >
> 1500 does sound like basic functionality for routers nowadays.

It is dependent upon the driver setting a suitable max_mtu in the netdev 
structure *IF* it supports values greater than 1500.

+   if (IS_ENABLED(CONFIG_SOC_MT7621))
+   netdev->max_mtu = 2048;

The version of driver included with kernel 4.14 at present is too dumb to 
understand >1500 mtu, which is why openwrt replaces it with a version that 
(now) does.

That’s my opinion anyway :-)

Kevin



signature.asc
Description: Message signed with OpenPGP
--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] 18.06: Cherry pick mtu fix

2018-06-21 Thread Jaap Buurman
Dear all,

The move to kernel 4.14 broke mtu settings larger than 1500 by
default, unless the correct mtu was explicitly specified. The
following commit fixes this for the mt7621 target:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=5da2c68d001ee44b15a58639ed03a0ebb6f68020

1) Would it be possible for someone to cherry-pick this to the 18.06
branch, so that it can receive widespread testing in the upcoming
18.06 RC1 release?
2) From the commit's message I get the impression this isn't an issue
with just mt7621, but with all targets that are able to handle a mtu >
1500. Is my impression correct in this regard, and is this something
that should be fixed before a 18.06 release? Changing mtu settings >
1500 does sound like basic functionality for routers nowadays.

Yours sincerely,

Jaap Buurman

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH] kernel: bump 4.14 to 4.14.51

2018-06-21 Thread Kevin Darbyshire-Bryant via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Refresh patches.

Remove patch that can be reverse applied:
mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch

Update patch that no longer applied:
ipq806x/patches-4.14/0035-clk-mux-Split-out-register-accessors-for-reuse.patch

Compiled-tested-for: lantiq, ramips
Run-tested-on: lantiq BT hh5a, ramips MIR3g

Signed-off-by: Kevin Darbyshire-Bryant 
---
 include/kernel-version.mk  |   4 +-
 ...stmmac-Disable-frame-filtering-completely.patch |   2 +-
 16-netfilter-flow-table-support-for-IPv6.patch |   2 +-
 ...r-improve-flow-table-Kconfig-dependencies.patch |   2 +-
 ...lowtable-infrastructure-depends-on-NETFIL.patch |   2 +-
 .../650-netfilter-add-xt_OFFLOAD-target.patch  |   4 +-
 .../902-essedma-alloc-skb-ip-align.patch   |   7 +-
 .../patches-4.14/997-device_tree_cmdline.patch |   4 +-
 ...ux-Split-out-register-accessors-for-reuse.patch |   6 +-
 .../patches-4.14/0069-arm-boot-add-dts-files.patch |  12 +-
 .../0012-clk-dont-disable-unused-clocks.patch  |   2 +-
 ...TA-ahci_mvebu-enable-stop_engine-override.patch | 224 -
 .../531-ATA-ahci_mvebu-pmp-stop-errata-226.patch   |  13 +-
 13 files changed, 26 insertions(+), 258 deletions(-)
 delete mode 100644 
target/linux/mvebu/patches-4.14/530-ATA-ahci_mvebu-enable-stop_engine-override.patch

diff --git a/include/kernel-version.mk b/include/kernel-version.mk
index 825a227915..52a8433ec6 100644
--- a/include/kernel-version.mk
+++ b/include/kernel-version.mk
@@ -5,12 +5,12 @@ LINUX_RELEASE?=1
 LINUX_VERSION-3.18 = .71
 LINUX_VERSION-4.4 = .121
 LINUX_VERSION-4.9 = .109
-LINUX_VERSION-4.14 = .50
+LINUX_VERSION-4.14 = .51
 
 LINUX_KERNEL_HASH-3.18.71 = 
5abc9778ad44ce02ed6c8ab52ece8a21c6d20d21f6ed8a19287b4a38a50c1240
 LINUX_KERNEL_HASH-4.4.121 = 
44a88268b5088dc326b30c9b9133ac35a9a200b636b7268d08f32abeae6ca729
 LINUX_KERNEL_HASH-4.9.109 = 
3dcd5654a553432119492b69e649c4ed117781bfd571edcb02346c945be359b0
-LINUX_KERNEL_HASH-4.14.50 = 
703a8d013b25dc428d936f72858fa0c702c22cb3114a040fb9bb47562e4ea2ac
+LINUX_KERNEL_HASH-4.14.51 = 
dab2402baa2444348f9b3c354e8f65382a466d1766942a57441209f9a2df972b
 
 remove_uri_prefix=$(subst git://,,$(subst http://,,$(subst https://,,$(1
 sanitize_uri=$(call qstrip,$(subst @,_,$(subst :,_,$(subst .,_,$(subst 
-,_,$(subst /,_,$(1)))
diff --git 
a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
 
b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
index 58094ae96d..e63c2e934b 100644
--- 
a/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
+++ 
b/target/linux/arc770/patches-4.14/700-stmmac-Disable-frame-filtering-completely.patch
@@ -20,7 +20,7 @@ Signed-off-by: Alexey Brodkin 
 
 --- a/drivers/net/ethernet/stmicro/stmmac/common.h
 +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
-@@ -49,7 +49,7 @@
+@@ -46,7 +46,7 @@
  #define STMMAC_GET_ENTRY(x, size) ((x + 1) & (size - 1))
  
  #undef FRAME_FILTER_DEBUG
diff --git 
a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
 
b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
index a561f2669d..874195558c 100644
--- 
a/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
+++ 
b/target/linux/generic/backport-4.14/324-v4.16-netfilter-flow-table-support-for-IPv6.patch
@@ -45,7 +45,7 @@ Signed-off-by: Pablo Neira Ayuso 
  {
 --- a/net/ipv6/netfilter/Kconfig
 +++ b/net/ipv6/netfilter/Kconfig
-@@ -71,6 +71,14 @@ config NFT_FIB_IPV6
+@@ -99,6 +99,14 @@ config NFT_FIB_IPV6
  endif # NF_TABLES_IPV6
  endif # NF_TABLES
  
diff --git 
a/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
 
b/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
index c897c36724..7174723fc9 100644
--- 
a/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
+++ 
b/target/linux/generic/backport-4.14/329-v4.16-netfilter-improve-flow-table-Kconfig-dependencies.patch
@@ -72,7 +72,7 @@ Signed-off-by: Pablo Neira Ayuso 
  
 --- a/net/ipv6/netfilter/Kconfig
 +++ b/net/ipv6/netfilter/Kconfig
-@@ -72,8 +72,9 @@ endif # NF_TABLES_IPV6
+@@ -100,8 +100,9 @@ endif # NF_TABLES_IPV6
  endif # NF_TABLES
  
  config NF_FLOW_TABLE_IPV6
diff --git 
a/target/linux/generic/backport-4.14/346-v4.16-netfilter-flowtable-infrastructure-depends-on-NETFIL.patch
 
b/target/linux/generic/backport-4.14/346-v4.16-netfilter-flowtable-infrastructure-depends-on-NETFIL.patch
index 5267fd2f67..162086e340 100644
---