[Bug 874128] Review Request: php-horde-Horde-Stream - Horde stream handler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874128 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Remi Collet --- Thanks New Package SCM Request === Package Name: php-horde-Horde-Stream Short Description: Horde stream handler Owners: remi Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zHtgSKi93A&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874172] Review Request: php-horde-Horde-Secret - Secret Encryption API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874172 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Remi Collet --- Thanks for the review New Package SCM Request === Package Name: php-horde-Horde-Secret Short Description: Secret Encryption API Owners: remi Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9BIwciERHy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873408] Review Request: php-horde-Horde-Role - PEAR installer role used to install Horde components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873408 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Remi Collet --- Thanks for the review New Package SCM Request === Package Name: php-horde-Horde-Role Short Description: PEAR installer role used to install Horde components Owners: remi Branches: f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KG8dXC7gP4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873395] Review Request: php-horde-Horde-Thrift - Thrift
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873395 --- Comment #3 from Remi Collet --- Good catch https://github.com/remicollet/remirepo/commit/e62bfbd62816e73bd35534e2892e997f7d0f8fe5 Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Thrift/php-horde-Horde-Thrift.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Thrift-2.0.1-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=V3n0EVmuiV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874128] Review Request: php-horde-Horde-Stream - Horde stream handler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874128 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Shawn Iwinski --- No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vVZA3exAYY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874128] Review Request: php-horde-Horde-Stream - Horde stream handler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874128 --- Comment #3 from Shawn Iwinski --- Created attachment 666513 --> https://bugzilla.redhat.com/attachment.cgi?id=666513&action=edit php-horde-Horde-Stream-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 874128 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oy8avYOmPX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874128] Review Request: php-horde-Horde-Stream - Horde stream handler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874128 --- Comment #2 from Shawn Iwinski --- Created attachment 666512 --> https://bugzilla.redhat.com/attachment.cgi?id=666512&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VDEYMlGlg0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874128] Review Request: php-horde-Horde-Stream - Horde stream handler
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874128 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dam1N1Fym1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874172] Review Request: php-horde-Horde-Secret - Secret Encryption API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874172 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Shawn Iwinski --- No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=98Jp1qhZFZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874172] Review Request: php-horde-Horde-Secret - Secret Encryption API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874172 --- Comment #3 from Shawn Iwinski --- Created attachment 666510 --> https://bugzilla.redhat.com/attachment.cgi?id=666510&action=edit php-horde-Horde-Secret-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 874172 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6DoGBzqHcX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874172] Review Request: php-horde-Horde-Secret - Secret Encryption API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874172 --- Comment #2 from Shawn Iwinski --- Created attachment 666509 --> https://bugzilla.redhat.com/attachment.cgi?id=666509&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BFZuOIhF1U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874172] Review Request: php-horde-Horde-Secret - Secret Encryption API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874172 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5mgqPTFYXY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873408] Review Request: php-horde-Horde-Role - PEAR installer role used to install Horde components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873408 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Shawn Iwinski --- No blockers. = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QQxXub5z0b&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873408] Review Request: php-horde-Horde-Role - PEAR installer role used to install Horde components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873408 --- Comment #4 from Shawn Iwinski --- Created attachment 666507 --> https://bugzilla.redhat.com/attachment.cgi?id=666507&action=edit php-horde-Horde-Role-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 873408 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LVLzgzd3jF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873408] Review Request: php-horde-Horde-Role - PEAR installer role used to install Horde components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873408 --- Comment #3 from Shawn Iwinski --- Created attachment 666506 --> https://bugzilla.redhat.com/attachment.cgi?id=666506&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1zVCTbUc7v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873408] Review Request: php-horde-Horde-Role - PEAR installer role used to install Horde components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=873408 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mt1KNPMBlN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-19 22:18:30 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nJIBT0gzt6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864187] Review Request: openscad - The Programmers Solid 3D CAD Modeller
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864187 --- Comment #34 from Fedora Update System --- openscad-2012.10.31-5.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l8zCUuA3u5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884876] Review Request: openscad-MCAD - OpenSCAD Parametric CAD Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884876 Bug 884876 depends on bug 864187, which changed state. Bug 864187 Summary: Review Request: openscad - The Programmers Solid 3D CAD Modeller https://bugzilla.redhat.com/show_bug.cgi?id=864187 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GWGhtfVm58&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882090] Review Request: python-nose-progressive - Nose plugin to show a progress bar and tracebacks during tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882090 --- Comment #14 from Fedora Update System --- python-nose-progressive-1.3-3.fc17, python-blessings-1.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0C3207Jwjq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882090] Review Request: python-nose-progressive - Nose plugin to show a progress bar and tracebacks during tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882090 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-19 22:17:29 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pubzjjAmRG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882084] Review Request: python-blessings - Python library for terminal coloring, styling, and positioning
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882084 --- Comment #9 from Fedora Update System --- python-nose-progressive-1.3-3.fc17, python-blessings-1.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qUZTPBUMW0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882084] Review Request: python-blessings - Python library for terminal coloring, styling, and positioning
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882084 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-19 22:17:20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2wgINtHrMZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882090] Review Request: python-nose-progressive - Nose plugin to show a progress bar and tracebacks during tests
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882090 Bug 882090 depends on bug 882084, which changed state. Bug 882084 Summary: Review Request: python-blessings - Python library for terminal coloring, styling, and positioning https://bugzilla.redhat.com/show_bug.cgi?id=882084 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9aFrdYEXSX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864125 --- Comment #10 from Fedora Update System --- opendyslexic-fonts-0.600-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gg5UcsC7WP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 864125] Review Request: opendyslexic-fonts - Font designed for dyslexics and high readability
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=864125 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-19 22:16:50 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bjWoaMhCTr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #24 from Fedora Update System --- libnetfilter_acct-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libnetfilter_acct-1.0.0-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zE7uMDjMiP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #23 from Fedora Update System --- libnetfilter_acct-1.0.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libnetfilter_acct-1.0.0-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z2rlH4LXzw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #22 from Fedora Update System --- libnetfilter_acct-1.0.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libnetfilter_acct-1.0.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NwoEtaUhY9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 --- Comment #21 from Fedora Update System --- libnetfilter_acct-1.0.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libnetfilter_acct-1.0.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YSikTt6KjE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848990] Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848990 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BsJXDNHZMw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889011] New: Review Request: rubygem-asciidoctor - A pure Ruby implementation of AsciiDoc
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889011 Bug ID: 889011 Summary: Review Request: rubygem-asciidoctor - A pure Ruby implementation of AsciiDoc Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: dal...@redhat.com Repository: https://github.com/mojavelinux/rubygem-asciidoctor Spec URL: https://raw.github.com/mojavelinux/rubygem-asciidoctor/master/rubygem-asciidoctor.spec SRPM URL: https://github.com/mojavelinux/rubygem-asciidoctor/raw/master/srpms/rubygem-asciidoctor-0.0.8-1.fc17.src.rpm Description: Asciidoctor is a pure-Ruby processor for parsing AsciiDoc documents or strings and rendering them as HTML and other formats using Tilt-based templates. Fedora Account System Username: mojavelinux -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kt7HRu2oaM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884855] Review Request: python-webtest1.3 - Helper to test WSGI applications
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=884855 Tomas Dabašinskas changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Tomas Dabašinskas --- review completed, package approved -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WYDJ1uYVIx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880716] Review Request: knot - Authoritative DNS server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880716 Paul Wouters changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Paul Wouters --- New Package SCM Request === Package Name: knot Short Description: KNOT DNS is a high-performance authoritative DNS server implementation. Owners: pwouters Branches: f17, f18, el6, el5 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYRKEa06ls&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880716] Review Request: knot - Authoritative DNS server
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880716 --- Comment #5 from Paul Wouters --- Talked to upstream, and we agreed to wait for 1.1.3rc to become a full release, then package it up with current spec file. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zDzDzM7e9P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888958] Review Request: gtk-solidity-engine - Solidity Gtk+ theming engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888958 --- Comment #1 from Michael Schwendt --- Very important: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags rpmlint likely complains, too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HXIm5tX2mn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 886492] Review Request: openslides - Presentation and assembly system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886492 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dPPolhPeel&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884291] Review Request: gvrng - LOGO styled programming tutor for kids
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884291 --- Comment #4 from Mario Blättermann --- Scratch build for f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4804369 $ rpmlint -i -v * gvrng.src: I: checking gvrng.src: I: checking-url http://gvr.sourceforge.net (timeout 10 seconds) gvrng.src: I: checking-url http://downloads.sourceforge.net/project/gvr/GvR%20GTK/4.4/GvRng_4.4.tgz (timeout 10 seconds) gvrng.noarch: I: checking gvrng.noarch: I: checking-url http://gvr.sourceforge.net (timeout 10 seconds) gvrng.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/gvrng/gvrng.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/gvrng.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/14.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/start_activity.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/01.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/17.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/12.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/GvrController.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/02.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/GvrModel.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gvrng/GPL-2 This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/GPL-2 The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/08.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/share/doc/gvrng/lessons/en/html/04.html The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. gvrng.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/gvrng/utils.py The Free Software Foundation address in this file seems to be outdated or misspelled.
[Bug 886492] Review Request: openslides - Presentation and assembly system
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886492 --- Comment #9 from Fedora Update System --- openslides-1.3-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yPL8C0fXo2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863145] Review Request: listadmin - Command line interface to mailman mailing lists
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863145 --- Comment #6 from Michael Schwendt --- True. I've pointed out something like that many times before, but have nearly given up doing so unless I assign a full review to myself. There are packagers who reintroduce *.gz and similar wildcards in existing packages and in new package submissions, because they don't care until the compression changes actually or until the guidelines make it a MUST item. You can also meet some who refuse to use listadmin.1* because it would include uncompressed *and* compressed files at the same time. They would then accept listadmin.1.* even if only reluctantly. ;) Though, I wouldn't call it "a major nitpick", since the compression technique hasn't changed for years. It could be, however, that someone (downstream or locally) reconfigures it, and to make the spec file more versatile (and future-proof) is added value. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FJrf6OeM8V&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785444] Review Request: php-horde-Horde-Alarm - Horde Alarm Libraries
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785444
--- Comment #5 from Shawn Iwinski ---
(In reply to comment #4)
After quick review:
* Missing %{pear_metadir}
* Please group your build requires together
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rjd4UBrq01&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785450
Shawn Iwinski changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #11 from Shawn Iwinski ---
= COULD items =
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel
pear.horde.org"
* Add a note in %description letting end-users know that they are responsible
for installing whichever support opcode cache they would like.
No blockers.
= APPROVED =
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0NVOFGgiU6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #10 from Shawn Iwinski --- Created attachment 666398 --> https://bugzilla.redhat.com/attachment.cgi?id=666398&action=edit php-horde-Horde-Cache-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785450 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oixJgnFi4P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #9 from Shawn Iwinski --- Created attachment 666397 --> https://bugzilla.redhat.com/attachment.cgi?id=666397&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=20bCNrzirc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884291] Review Request: gvrng - LOGO styled programming tutor for kids
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884291 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Alias||gvrng Flags||fedora-review? --- Comment #3 from Mario Blättermann --- Taking this for a full review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7VglsDxj6a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823096 Paulo Andrade changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Paulo Andrade --- New Package SCM Request === Package Name: nvidia-texture-tools Short Description: Collection of image processing and texture manipulation tools Owners: pcpa Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zuCCUQY9jQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823096 --- Comment #10 from Paulo Andrade --- (In reply to comment #8) > Upon further review, this package is no longer blocked on FE-Legal. It does > contain an S3TC implementation, but the patent license provided by NVIDIA > has been determined to be sufficient. Please do not take the S3TC > implementation from this codebase and copy it into any other code, because > that would not be covered under the terms of the NVIDIA patent license (and > not acceptable for Fedora). > > Lifting FE-Legal Many thanks for looking back at this issue and reviewing it! I updated the package before requesting scm and should now match fully your recommendations: - Correct source url (#823096). - No need for a -progs subpackage (#823096). Spec URL: http://fedorapeople.org/~pcpa/nvidia-texture-tools.spec SRPM URL: http://fedorapeople.org/~pcpa/nvidia-texture-tools-2.0.8-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L2UJbZ9hVh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888958] Review Request: gtk-solidity-engine - Solidity Gtk+ theming engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888958 Mario Blättermann changed: What|Removed |Added Alias||gtk-solidity-engine -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vY9rSkBnNR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888958] New: Review Request: gtk-solidity-engine - Solidity Gtk+ theming engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888958 Bug ID: 888958 Summary: Review Request: gtk-solidity-engine - Solidity Gtk+ theming engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: mario.blaetterm...@gmail.com Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/gtk-solidity-engine.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/gtk-solidity-engine-0.4.1-1.fc18.src.rpm Description: Solidity Gtk+ theming engine Fedora Account System Username: mariobl -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NFXaxv2oGn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854077] Review Request: cputemp - Monitors and logs CPU Temperature via ACPI
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=854077
Michael Schwendt changed:
What|Removed |Added
Version|17 |rawhide
--- Comment #4 from Michael Schwendt ---
Some hints (I've not tried to build/test this):
* The following page explains how you can request web storage where to offer
your src.rpm and spec file during the review process:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
The page also mentions how to do a scratch build in the Fedora build system.
Also on the page, in the "Make a package" section, is a pointer at the Review
Guidelines. It is highly recommended to take a look at them
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
and give "rpmlint" (a MUST item on that page) a try. Run "rpmlint -i" on your
src.rpm and the built packages. Fix as much as sounds plausible and can be
verified via the packaging guidelines. Some of what it reports are false
positives, however. ;)
> License:GPLv3
That doesn't match the source code file, which contains a "GPLv2+" preamble.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification
> Source0:cputemp-%{version}.tar.gz
https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net
> BuildArch: noarch
> BuildRequires: python-devel
It doesn't need the stuff in python-devel, but "BuildRequires: python", does
it?
> %build
> # Remove CFLAGS=... for noarch packages (unneeded)
> # CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
> #./Setup.py --binprefix=%{_prefix}
It's better to remove lines if they are not needed at all. rpmlint gives help
about this, too.
> mkdir -p $RPM_BUILD_ROOT%{_datarootdir}/doc/cputemp
Interesting to encounter %_datarootdir once more after a very long time.
Thousands of packages use the shorter %{_datadir} instead. Also notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
> cp cputemp-%{version}\ Change\ Log $RPM_BUILD_ROOT%{_datarootdir}/doc/cputemp
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
> mv CPUTemp.py cputemp
> mv cputemp $RPM_BUILD_ROOT/%{_bindir}/cputemp
Even if this is just a tiny package, please don't get used to deleting/moving
files in the builddir, because that breaks rpmbuild's --short-circuit options.
Prefer copying/installing files to their target location. If you ever
co-maintain a larger package with a more complex %files section, you might meet
a co-maintainer who will want to do a --short-circuit install to check the
installed %files.
> %files
> "%{_datarootdir}/doc/cputemp/cputemp-%{version} Change Log"
Directory /usr/share/doc/cputemp would not be included:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=F2mbtkiRX9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785480] Review Request: php-horde-Horde-Log - Horde Logging library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785480 Nick Bebout changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Nick Bebout --- New Package SCM Request === Package Name: php-horde-Horde-Log Short Description: Horde Logging package with configurable handlers, filters, and formatting Owners: nb Branches: f17 f18 el6 InitialCC: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xo4YzUUfL8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785479] Review Request: php-horde-Horde-Constraint - Horde Constraint library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 Nick Bebout changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Nick Bebout --- New Package SCM Request === Package Name: php-horde-Horde-Constraint Short Description: A programmatic way of building constraints that evaluate to true or false Owners: nb Branches: f17 f18 el6 InitialCC: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kSfPDMnpQf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Whiteboard|NotReady| --- Comment #8 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache-2.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mQavbOOwP4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785449] Review Request: php-horde-Horde-Browser - Horde Browser API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785449 Nick Bebout changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jw3bqqClfd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785449] Review Request: php-horde-Horde-Browser - Horde Browser API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785449 --- Comment #9 from Nick Bebout --- New Package SCM Request === Package Name: php-horde-Horde-Browser Short Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities Owners: nb Branches: f17 f18 el6 InitialCC: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZUPCZixvi1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
--- Comment #16 from Sebastien Jodogne ---
Spec URL: http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc.spec
SRPM URL:
http://www.montefiore.ulg.ac.be/~jodogne/Orthanc/Fedora/orthanc-0.4.0-5.fc17.src.rpm
Hi all,
Thank you much for your massive feedback on this package! I have just uploaded
another version of the package with your latest comments (cf. above). Let me
quickly summarize the status of the package.
**LEGAL STUFF**
According to the Legal mailing list, the license for Orthanc is "GPLv3 with
exceptions":
http://lists.fedoraproject.org/pipermail/legal/2012-December/002052.html
This is fixed in the latest version of the package.
**JSONCPP**
The actual release of the Orthanc package depends on the packaging of JsonCpp:
https://bugzilla.redhat.com/show_bug.cgi?id=882617
Even though the Orthanc package does work right now because it statically links
against JsonCpp, it is probably a Good Thing to wait for JsonCpp to be
officially packaged.
**OTHER CHANGES**
A few other changes have been spotted by several people and are fixed in the
last version of the package. Here is a summary of these changes:
* "%doc %{_mandir}/man1/*.1*" => "%{_mandir}/man1/*.1*"
* "BuildRequires: Python"
* "%attr" removed for "/etc/orthanc" and "/etc/orthanc/orthanc.json"
Please let me know if I have forgotten to answer some concern.
Regards,
Sébastien-
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lXUyLqvY4K&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #15 from Sebastien Jodogne --- Hi again, > * There are at least two licenses: MIT (OrthancCppClient) and GPLv3. This > should be reflected in the SPEC file as in: > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#Multiple_Licensing_Scenarios I am not comfortable enough with legal stuff, but as I understand on the following page, I should just specify "GPLv3" because it corresponds to the license of the Orthanc binaries that are shipped inside the package: https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F "Here are some common cases: [...] The source code contains some .c files which are GPLv2+ and some other .c files which are BSD. They're compiled together to form an executable. Since some of the files are licensed as GPL, the resulting executable is also GPL. The License tag should read: License: GPLv2+" Let me know if I'm wrong, but I think that the different licensing schemes for the OrthancCppClient and the Core/SQLite folders are upstream-related stuff, and do not interfere with the Fedora package. > * Core/SQlite contains an sqlite wrapper from chrome. Is it under BSD > license. I see there are some modifications specifically made for Orthanc, > which could qualify as a fork. Sebastian, in order to understand if this is > the case, would you mind to comment (briefly) on these questions > (https://fedoraproject.org/wiki/Packaging: > No_Bundled_Libraries#Standard_questions)? I think that this work should not be considered as a fork of Chrome, since it is just an excerpt of a few files that happen to compile well outside the Chrome framework: Chrome does not provide a standalone SQLite wrapper by itself, and thus this folder is not a fork. > * I see a lot of cmake files that deal with 3rd part libraries. If you don't > use them, why don't you "rm -rf" them in the %prep section? Just to be sure > we are not using them? Well, the CMake framework of Orthanc is rather complex, as Orthanc is built so as to compile as well on Windows and on several flavors of Linux: This notably implies that it is possible to statically link Orthanc against all the third-party dependencies. Even if only 5% of the Resources/CMake folder is used for dynamic linking in Linux, the upstream package is maintained for more general linking scenarios. I have the feeling that it would not be a good thing to modify the CMake scripts just for the Fedora package, because the same work would have to be done again and again with each release of Orthanc, which would be error-prone and time-consuming. Cheers, Sébastien- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7bYGo3JRCa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884291] Review Request: gvrng - LOGO styled programming tutor for kids
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884291 --- Comment #2 from Neil Horman --- Thanks trond, I'll note that and clean it up when I get an official review of this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k9mfwzb3jg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884291] Review Request: gvrng - LOGO styled programming tutor for kids
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=884291 Trond H. Amundsen changed: What|Removed |Added CC||t.h.amund...@usit.uio.no --- Comment #1 from Trond H. Amundsen --- Based on a quick reading of the spec I have only one comment. Don't use macros for basic commands like in the %clean section. In fact, the whole %clean section isn't needed unless EPEL5 is one of the intended targets for the package: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7ezKMc5kjE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878188 --- Comment #11 from Rex Dieter --- Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase.spec SRPM URL: Description: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtbase-5.0.0-1.fc18.src.rpm %changelog * Wed Dec 19 2012 Rex Dieter 5.0.0-1 - 5.0 (final) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ieuacqEBKb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 798438] Review Request: uthash-devel - Hash table and linked list for C structures
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=798438 --- Comment #9 from Michael Schwendt --- If one followed today's decision made by the Fedora Packaging Committee about a similar package, they would do what I pointed out in comment 2: Name the package "uthash" (src.rpm name and upstream name), and additionally, they would store all files in a built uthash package, too, not in a uthash-devel. I hope they will clarify the guidelines as there is an inconsistency in them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YqkJuFv00q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski changed: What|Removed |Added Whiteboard||NotReady --- Comment #7 from Shawn Iwinski --- Please remove APC from requires. It is an optional require and end-users should not be forced to install APC if they are using one of the other opcode caches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eZYuEkCB1U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
--- Comment #14 from Michael Schwendt ---
Created attachment 666287
--> https://bugzilla.redhat.com/attachment.cgi?id=666287&action=edit
fedora-18-x86_64 mock build.log
Build failure with "mock --rebuild orthanc-0.4.0-4.fc17.src.rpm".
No "python" installed in the buildroot:
$ grep python root.log
DEBUG util.py:264: python-libs-2.7.3-13.fc18.x86_64
DEBUG util.py:264: boost-python x86_64 1.50.0-4.fc18
fedora 123 k
DEBUG util.py:264: boost-python3 x86_64 1.50.0-4.fc18
fedora 126 k
DEBUG util.py:264:boost-python.x86_64 0:1.50.0-4.fc18
DEBUG util.py:264:boost-python3.x86_64 0:1.50.0-4.fc18
>> %doc %{_mandir}/man1/*.1*
>>
>> Hint: %_mandir is marked %doc automatically.
>
> I was uncertain about this line. Is it harmful for the package's building ?
Not harmful. Only redundant. Many reviewers point it out.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=WFKJlQ8w6G&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785449] Review Request: php-horde-Horde-Browser - Horde Browser API
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785449
Shawn Iwinski changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #8 from Shawn Iwinski ---
= COULD items =
* Require php-pcre
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel
pear.horde.org"
No blockers.
= APPROVED =
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ucmwKELQGR&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785449] Review Request: php-horde-Horde-Browser - Horde Browser API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785449 --- Comment #7 from Shawn Iwinski --- Created attachment 666286 --> https://bugzilla.redhat.com/attachment.cgi?id=666286&action=edit php-horde-Horde-Browser-review.txt -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lTUvzNGZE9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785449] Review Request: php-horde-Horde-Browser - Horde Browser API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785449 --- Comment #6 from Shawn Iwinski --- Created attachment 666283 --> https://bugzilla.redhat.com/attachment.cgi?id=666283&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xR3X5Tf7dp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 --- Comment #14 from Fedora Update System --- Package php-doctrine-DoctrineCommon-2.3.0-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing php-doctrine-DoctrineCommon-2.3.0-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-13801/php-doctrine-DoctrineCommon-2.3.0-2.el6 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5WLZrfD7iX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877705] Review Request: torsocks - Use SOCKS-friendly applications with Tor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877705 --- Comment #16 from Fedora Update System --- torsocks-1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HZ5CbeDEGK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837666] Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=837666 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=I3ImNpkaRm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 880964] Review Request: python-django-select2 - Select2 option fields for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880964 --- Comment #8 from Fedora Update System --- python-django-select2-3.1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FIKl3Lfcjr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 --- Comment #9 from Fedora Update System --- Package php-Faker-1.1.0-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing php-Faker-1.1.0-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-13792/php-Faker-1.1.0-2.el6 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F4MdT4REum&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885515] Review Request: php-Faker - A PHP library that generates fake data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885515 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sjXN9hPgDO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 873395] Review Request: php-horde-Horde-Thrift - Thrift
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=873395
--- Comment #2 from Shawn Iwinski ---
= MUST items =
[!]: Package requires other packages for directories it uses.
[!]: Package must own all directories that it creates.
Since no other Horde packages required, "%dir %{pear_phpdir}/Horde" is missing
missing from %files
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=N6xiVYZmyT&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885348] Review Request: ghc-stringsearch - Fast searching, splitting and replacing of ByteStrings
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885348 Ben Boeckel changed: What|Removed |Added Flags|needinfo?(maths...@gmail.co | |m) | --- Comment #4 from Ben Boeckel --- Hrm...the DNS settings failed to apply; apparently linode's servers are down? I'll try to dig into this more tonight. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HTMsWxRWcU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853922] Review Request: guacamole - The main Guacamole web application
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=853922 --- Comment #11 from Simone Caronni --- Yes, I updated the prerequisites yesterday. Here is the update: Spec URL: http://slaanesh.fedorapeople.org/guacamole.spec SRPM URL: http://slaanesh.fedorapeople.org/guacamole-0.7.0-1.fc17.src.rpm There are also the prerequisites pending for f17/f18 if you want to test on those platforms: https://admin.fedoraproject.org/updates/search/guacamole -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KhXnolhKiG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877661] Review Request: seam-conversation - Conversation management logic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877661 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vBKW0XN4ub&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888598] Review Request: opengrm-ngram - Library for making and modifying n-gram language models
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888598
--- Comment #1 from Mario Ceresa ---
Hi Jerry,
I have a couple of questions:
* Why do you especially require gsl-devel%{?_isa}, openfst-devel%{?_isa} in the
devel package? Do you think it is appropriate to add a brief comment as
requested in
http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires ?
* Shouldn't the sonames be 1.0.3 instead of 0.0.0?
(/usr/lib64/libngram.so.0.0.0)
The rest of the package is fine for me.
Please reply to this comment and I'll post the formal review
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0ZPkqv9Vr0&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888840] Review Request: maven-dependency-analyzer - Maven dependency analyzer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=40 Stanislav Ochotnicky changed: What|Removed |Added CC||m...@redhat.com, ||socho...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qdRzm2lN4T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885291] Review Request: netsed - A tool to modify network packets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885291 --- Comment #2 from Fabian Affolter --- (In reply to comment #1) > Package is good, just missing the test suite, if you can enable it, I will > approve the package ( or if you have a reason to not enable it ). Tests added. Thanks for the hint. * Wed Dec 19 2012 Fabian Affolter - 1.1-2 - Docs added - Test enabled Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/netsed.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/netsed-1.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MYFySjAd6W&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877661] Review Request: seam-conversation - Conversation management logic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877661 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from gil cattaneo --- New Package SCM Request === Package Name: seam-conversation Short Description: Conversation management logic Owners: gil Branches: f17 f18 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JS1tLVNkv3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 885043] Review Request: seam-solder - A portable CDI extensions library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885043 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dGcqd1conp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
--- Comment #13 from Antonio Trande ---
(In reply to comment #9)
Hi Mario.
> Oops mid-air collision!! :)
>
> Hi again, some miscellaneous findings before a more through review:
>
> * There are at least two licenses: MIT (OrthancCppClient) and GPLv3. This
> should be reflected in the SPEC file as in:
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Multiple_Licensing_Scenarios
>
The licenses issue have already been bring up (see comment #3). :)
Hi Michael
>> * An automated build attempt in Plague/Mock here failed:
>> ...
>> make[2]: python: Command not found
>> make[2]: Leaving directory `/builddir/build/BUILD/Orthanc-0.4.0'
>>
>> Note that you could submit a scratch build in the Fedora Build System:
>>
>> https://fedoraproject.org/wiki/
>> Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.
>> 29_and_set_up_your_certificate
>Mmmm... strange, I just mocked it and it worked... let's try with a scratch
>>build!
For me too ...
>> %doc %{_mandir}/man1/*.1*
>Hint: %_mandir is marked %doc automatically.
I was uncertain about this line. Is it harmful for the package's building ?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pvsb2hi8A8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857843] Review Request: lessjs - Less.js The dynamic stylesheet language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 --- Comment #12 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eyt26meMZn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823096 Tom "spot" Callaway changed: What|Removed |Added Assignee|nob...@fedoraproject.org|tcall...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FLkyY13Hnn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823096
Tom "spot" Callaway changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from Tom "spot" Callaway ---
== Review ==
Good:
- rpmlint checks return:
nvidia-texture-tools.x86_64: W: spelling-error %description -l en_US mipmap ->
mishap
nvidia-texture-tools.x86_64: W: shared-lib-calls-exit
/usr/lib64/libnvcore.so.2.0.8 exit@GLIBC_2.2.5
nvidia-texture-tools.src: W: spelling-error %description -l en_US mipmap ->
mishap
All safe to ignore
- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(6b3c83500b420ee976f61eeae16e5727e2401e133f543baeac76c66c381eed2e)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
MINOR ISSUES:
* The source url is wrong, should be:
http://nvidia-texture-tools.googlecode.com/files/%{name}-%{version}-1.tar.gz
* I don't see the value in a separate "progs" subpackage (it is only 41K). I
strongly suggest just combining it into the main package (especially since the
naming "nvidia-texture-tools" implies the presence of tools), but I leave that
to your discretion.
Please fix the source URL (and dropping the "progs" subpackage if you choose to
do so) before committing to Fedora, but this package is otherwise very well
done.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uDiid3VVpe&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888840] Review Request: maven-dependency-analyzer - Maven dependency analyzer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=40 Tomas Radej changed: What|Removed |Added Blocks||880233 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ombvmAmdje&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857843] Review Request: lessjs - Less.js The dynamic stylesheet language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 Stephen Gallagher changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Stephen Gallagher --- New Package SCM Request === Package Name: lessjs Short Description: Less.js The dynamic stylesheet language Owners: sgallagh mrunge Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5dWyLaZoG9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823096 Tom "spot" Callaway changed: What|Removed |Added Status|CLOSED |ASSIGNED CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | Resolution|WONTFIX |--- Keywords||Reopened --- Comment #8 from Tom "spot" Callaway --- Upon further review, this package is no longer blocked on FE-Legal. It does contain an S3TC implementation, but the patent license provided by NVIDIA has been determined to be sufficient. Please do not take the S3TC implementation from this codebase and copy it into any other code, because that would not be covered under the terms of the NVIDIA patent license (and not acceptable for Fedora). Lifting FE-Legal -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eLqIEUaVHm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857843] Review Request: lessjs - Less.js The dynamic stylesheet language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 Fabian Deutsch changed: What|Removed |Added CC||fabian.deut...@gmx.de Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kkkuogsdSu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 857843] Review Request: lessjs - Less.js The dynamic stylesheet language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 --- Comment #10 from Fabian Deutsch --- As discussed on IRC, both lciense should stay in the field, as we still ship cssmin.js, but remove it. Therefor, Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IILbiSgJjy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877661] Review Request: seam-conversation - Conversation management logic
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877661
Gerard Ryan changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Gerard Ryan ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
javadoc
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)". 1 files have unknown license. Detailed output of
licensecheck in /home/grdryn/dev/fedora/review/877661-seam-
conversation/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: If package uses '-Dmaven.local.depmap' explain why it was needed in a
comment
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: If package uses "-Dmaven.test.skip=true" explain why it was needed in a
[Bug 857843] Review Request: lessjs - Less.js The dynamic stylesheet language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=857843 --- Comment #9 from Fabian Deutsch --- Stephen, the latest spec is nearly fine for me. You need to adjust the License field again as cssmin.js is removed now. And a last small nitpick: You could use rm instead of the 0004-Remove-pre-builds.patch - but that's just my pov. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EAyPgpOxeo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853922] Review Request: guacamole - The main Guacamole web application
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=853922 --- Comment #10 from Tomas Radej --- The package does not build. The required guacamole-common = 0.6.2 is missing, it was already updated to 0.7.0. Please, fix the requirements before I proceed with the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tuVxhs2jN5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823337] Review Request: rubygem-mixlib-shellout - mixin for running external commands
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823337
--- Comment #15 from Julian C. Dunn ---
(In reply to comment #14)
> Cool. Thank you for the patches. I hope they'll get accepted soon.
>
> Just cannot resist, have you tested it on F18+? Since /tmp is now TmpFs, I
> hope it will not cause another troubles ;)
Yes, I tested my patches on a F18-beta VM.
> And few other notes:
>
> * Mark patches as Patch0 and Patch1
> - I'd love to see the patches marked as Patch0, Patch1 instead of Source2,
> Source3. I don't think where will be any difference in the end, but it
> feels
> better to me.
That makes sense.
> * %exclude %{gem_instdir}/spec should not be needed
> - If I am not mistaken, this line is not needed, since you expand the test
> suite after the %install section is done, so there is no chance that it
> could appear in %{buildroot}
Correct.
The above problems have been fixed and SPEC/SRPM have been updated.
http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout.spec
http://fedorapeople.org/~jdunn/rubygem-mixlib-shellout/rubygem-mixlib-shellout-1.1.0-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vawJuSub7N&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785475] Review Request: php-horde-Horde-Lock - Horde Resource Locking System
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785475 Shawn Iwinski changed: What|Removed |Added Whiteboard||NotReady --- Comment #1 from Shawn Iwinski --- Please update to latest version before review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9jaKTkRsEY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877661] Review Request: seam-conversation - Conversation management logic
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877661 Gerard Ryan changed: What|Removed |Added CC||ger...@ryan.lt Flags||fedora-review? --- Comment #2 from Gerard Ryan --- I'll review this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oJDU5jqBpa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #12 from Michael Schwendt --- s/based/based builds/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vp3WGesBxw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888598] Review Request: opengrm-ngram - Library for making and modifying n-gram language models
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888598 Mario Ceresa changed: What|Removed |Added Status|NEW |ASSIGNED CC||mrcer...@gmail.com Assignee|nob...@fedoraproject.org|mrcer...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AakTil8Qe7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888301] Review Request: orthanc - RESTful DICOM server for healthcare and medical research
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #11 from Michael Schwendt --- "BuildRequires: python" is missing indeed. At least for F18, because neither is python on the list of BuildRequires exceptions, https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 nor is it listed in root.log for Koji/Plague based in Mock. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WJpEN8hLY9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888840] Review Request: maven-dependency-analyzer - Maven dependency analyzer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=40 Tomas Radej changed: What|Removed |Added Blocks||850077 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gBEaV00XHJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
