[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302876



--- Comment #30 from Fedora Update System  ---
clatd-1.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375926] Review Request: python-nose2 - Next generation of nicer testing for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375926



--- Comment #7 from Neal Gompa  ---
Could you please post updated Spec and SRPM links so that fedora-review can
process them?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Neal Gompa  ---
Comments based on the review above:

* rpmlint is a little brain-dead here, and I understand that this is how our
other Xorg video drivers are packaged, so I'm letting this go.

* Obviously the .so files are unversioned, as they are "plugins" for Xorg
itself, and Xorg doesn't care for soversions.

* The dependencies look right to me.

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #12 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[?]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 22 files have
 unknown license. Detailed output of licensecheck in
 /home/makerpm/1372938-xorg-x11-drv-amdgpu/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[?]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xorg-x11
 -drv-amdgpu-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[!]: Package should compile and build into binary rpms on all supported
 

[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302876



--- Comment #29 from Fedora Update System  ---
clatd-1.4-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376635] Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com
 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376635] New: Review Request: ostrichriders - Knights flying on ostriches compete against other riders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376635

Bug ID: 1376635
   Summary: Review Request: ostrichriders - Knights flying on
ostriches compete against other riders
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: du...@identicalsoftware.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/dulsi/ostrichriders/raw/master/ostrichriders.spec
SRPM URL:
http://identicalsoftware.com/ostrichriders/ostrichriders-0.6.4-1.fc24.src.rpm
Description: Enemy knights are invading the kingdom. As one of the elite
ostrich riders,
it is your duty to defend the kingdom. With lance in hand you fly off.
Remember to stay above your opponent least you fall to his lance. Collect the
eggs least your opponent hatches stronger than before. Work together with
other knights.
Fedora Account System Username: dulsi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360258] Review Request: qt5-qtserialbus - The Qt Serial Bus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360258

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
qt5-qtserialbus-5.7.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-09d43bf08f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376207] Review Request: python-fedmsg-atomic-composer - Composes atomic trees when Fedora repositories are updated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376207



--- Comment #12 from Fedora Update System  ---
python-fedmsg-atomic-composer-2016.2-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d31fc60666

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376207] Review Request: python-fedmsg-atomic-composer - Composes atomic trees when Fedora repositories are updated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376207



--- Comment #11 from Fedora Update System  ---
python-fedmsg-atomic-composer-2016.2-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e10c8a3162

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376207] Review Request: python-fedmsg-atomic-composer - Composes atomic trees when Fedora repositories are updated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376207

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-fedmsg-atomic-composer-2016.2-2.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-edaf3dccd0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #11 from Christopher Atherton  ---
New version 1.1.1 released today

Spec: https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu.spec
SRPM:
https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu-1.1.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302876



--- Comment #28 from Fedora Update System  ---
clatd-1.4-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cstra...@redhat.com
   Assignee|nob...@fedoraproject.org|cstra...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369688] Review Request: python35 - Version 3.5 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369688



--- Comment #10 from Charalampos Stratakis  ---
(In reply to Miro Hrončok from comment #9)
> (In reply to Charalampos Stratakis from comment #8)
> > Also a correction to my previous comment.
> > 
> > Please consider building the package in a timeframe of 2+ weeks, so that
> > enough people will have updated their F23 systems, in order to get the
> > latest release of python3, which keeps the upgrade path clean.
> 
> Actually the updated python3 is not in F23, only in F24+, so this does not
> make any sense. All I need is to wait until it reaches stable and mirrors.

Yes you are correct. This is applicable for the fedora-repos package which
caused an issue with the upgrade path, and an update was sent out recently for
F23. Apologies for the confusion.

https://bodhi.fedoraproject.org/updates/FEDORA-2016-772911949e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #11 from Tim Flink  ---
I installed the libphutil and arcanist packages from these reviews into a clean
f26 chroot and php-cli is installed with arcanist with no issue. If I use the
older packages that are referenced in the ticket that Kamil linked to, there is
a problem.

Therefore I conclude that there is no longer an issue with the requires and the
review can go ahead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839



--- Comment #22 from Fedora Update System  ---
python-pycodestyle-2.0.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4461dd7a21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839



--- Comment #21 from Fedora Update System  ---
python-pycodestyle-2.0.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d87d3b3103

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839



--- Comment #20 from Fedora Update System  ---
python-pycodestyle-2.0.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dce2f89dec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839

Miro Hrončok  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||python-pycodestyle-2.0.0-2.
   ||fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839

Miro Hrončok  changed:

   What|Removed |Added

  Flags|needinfo?(lmac...@redhat.co |
   |m)  |
   |needinfo?(lmac...@redhat.co |
   |m)  |



--- Comment #19 from Miro Hrončok  ---
I've just built this in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376149] Review Request: fedora-obsolete-packages - A package to obsolete retired packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376149



--- Comment #3 from Jon Ciesla  ---
(In reply to Jason Tibbitts from comment #2)
> For the record, the weird permission thing is because my umask is 007, which
> is the Posix ACL group scheme with default privacy.  The permissions
> wouldn't be weird if building an srpm in mock or the buildsys.  I kind of
> wish rpmlint would stop complaining about that.

If wishes were horses. . .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375765



--- Comment #2 from Eric Smith  ---
koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15640020

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375765



--- Comment #1 from Eric Smith  ---
Spec URL: https://fedorapeople.org/~brouhaha/yosys/yosys.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/yosys/yosys-0.6.0-1.20160909git5199aaf.fc24.src.rpm

aarch64 problem turned out to be due to non-deterministic regression test
generation; realmath floating point tests include operations not guaranteed by
IEEE 754 to be bit-accurate.  Added a patch to Makefile and test scripts to
allow explicit specification of PRNG seed.  Submitted a pull request upstream. 
Spec file and SRPM updated; now builds fine on 32-bit and 64-bit x86 and ARM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 968136] Review Request: camel - Apache Camel integration framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=968136
Bug 968136 depends on bug 1367518, which changed state.

Bug 1367518 Summary: Review Request: async-http-client1 - Asynchronous Http 
Client for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1367518

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518



--- Comment #6 from Fedora Update System  ---
async-http-client1-1.9.39-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-15 14:40:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(praiskup@redhat.c
   ||om)



--- Comment #16 from Randy Barlow  ---
I like the idea of renaming it with a vim- prefix, but that makes me inclined
to think that we should also do the obsoletes/provides stuff that a package
rename would do:

https://fedoraproject.org/wiki/Package_Renaming_Process

It sounds like this package was last in Fedora 21 maybe (based on the dead
package file saying that it was dropped in F22), so there could still be users
out there with the old packages that could benefit from the update.

Also, fedora-review is still failing to install the packages:

$ sudo /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 26 --disableplugin=local --setopt=deltarpm=false install
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-ada-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-scss-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-spec-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-scala-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-html-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-matlab-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-erlang-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vhdl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-cucumber-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-asciidoc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-sh-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-haskell-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-yacc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-javascript-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-d-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-perl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-json-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-glsl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-coq-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-yaml-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-tex-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-nasm-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-zsh-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vala-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-ruby-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-cpp-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-rnc-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-go-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-c-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-coffee-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-python-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-php-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-eruby-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-xslt-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-haml-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-z80-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-objcpp-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-vim-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-tcl-3.7.0-4.fc26.noarch.rpm
/home/rbarlow/reviews/1374138-vim-syntastic/results/vim-syntastic-css-3.7.0-4.fc26.noarch.rpm

[Bug 1376149] Review Request: fedora-obsolete-packages - A package to obsolete retired packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376149



--- Comment #2 from Jason Tibbitts  ---
For the record, the weird permission thing is because my umask is 007, which is
the Posix ACL group scheme with default privacy.  The permissions wouldn't be
weird if building an srpm in mock or the buildsys.  I kind of wish rpmlint
would stop complaining about that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376149] Review Request: fedora-obsolete-packages - A package to obsolete retired packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376149

Jon Ciesla  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jon Ciesla  ---
- rpmlint checks return:

fedora-obsolete-packages.src: W: strange-permission
fedora-obsolete-packages.spec 660
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

fedora-obsolete-packages.src: W: no-%prep-section
The spec file does not contain a %prep section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality.  Add the section, even if
empty.

fedora-obsolete-packages.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

fedora-obsolete-packages.src: W: no-%install-section
The spec file does not contain an %install section.  Even if some packages
don't directly need it, section markers may be overridden in rpm's
configuration to provide additional "under the hood" functionality.  Add the
section, even if empty.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Ignorable.

- package meets naming guidelines
- package meets packaging guidelines
- license ( Public Domain ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Looks great, does what it says on the tin.  I might recommend having something
suggesting that new Obsoletes added include a comment saying when they were
added, so they can be pruned after they're no longer relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376149] Review Request: fedora-obsolete-packages - A package to obsolete retired packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376149

Jon Ciesla  changed:

   What|Removed |Added

 CC||limburg...@gmail.com
   Assignee|nob...@fedoraproject.org|limburg...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #75 from Parag AN(पराग)  ---
This closed review should not keep blocking FE-NEEDSPONSOR.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376511] Review Request: nexus - NeXus scientific data file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376511

Stuart Campbell  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376511] New: Review Request: nexus - NeXus scientific data file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376511

Bug ID: 1376511
   Summary: Review Request: nexus - NeXus scientific data file
format
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: stu...@stuartcampbell.me
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC URL:
https://github.com/stuartcampbell/rpm-packages/blob/master/nexus/nexus.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sic/science/fedora-rawhide-x86_64/00453405-nexus/nexus-4.4.3-2.fc26.src.rpm


Description: NeXus scientific data file format - 
 NeXus is a common data format for neutron, x-ray, and muon science. It
 is being developed as an international standard by scientists and
 programmers representing major scientific facilities in Europe, Asia,
 Australia, and North America in order to facilitate greater cooperation
 in the analysis and visualization of neutron, x-ray, and muon data. 

Fedora Account System Username: sic

This is my first packages and so I will need a sponsor.  Thank you.
(Well I did submit another package but that hasn't been approved -
https://bugzilla.redhat.com/show_bug.cgi?id=1268380)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369688] Review Request: python35 - Version 3.5 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369688



--- Comment #9 from Miro Hrončok  ---
(In reply to Charalampos Stratakis from comment #8)
> Also a correction to my previous comment.
> 
> Please consider building the package in a timeframe of 2+ weeks, so that
> enough people will have updated their F23 systems, in order to get the
> latest release of python3, which keeps the upgrade path clean.

Actually the updated python3 is not in F23, only in F24+, so this does not make
any sense. All I need is to wait until it reaches stable and mirrors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cstra...@redhat.com
   Assignee|nob...@fedoraproject.org|cstra...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369688] Review Request: python35 - Version 3.5 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369688



--- Comment #8 from Charalampos Stratakis  ---
Also a correction to my previous comment.

Please consider building the package in a timeframe of 2+ weeks, so that enough
people will have updated their F23 systems, in order to get the latest release
of python3, which keeps the upgrade path clean.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #15 from Pavel Raiskup  ---
(In reply to Pavel Raiskup from comment #12)
> TBH, I have no idea what Gnome Software is so I'm not the best
> person to write the patch.  If you can help here, I can include that now
> or in post-review time.

Let me fix my sentence ^^ here.  I wanted to write that if somebody can
help here and _write the patch_, I can include that no or anytime later :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #14 from Pavel Raiskup  ---
Thanks for the links Víťo, but sorry - I have zero motivation in this stuff
now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369688] Review Request: python35 - Version 3.5 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369688

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Charalampos Stratakis  ---
Some final notes.

Package is updated to 3.5.2

Rewheel mode is disabled.

Debug build is disabled.

Package is flat, meaning that there are no subpackages, all the files and
directories are at the main package.

Most binaries, as well as libraries and man pages are removed so they do not
conflict with the system python3 package. The binary for this package is
renamed to python35 [0].

[0]
https://github.com/fedora-python/python35/commit/9e55727e6d2e48e2377fd312d453746b4e49dbba

python(abi) is not required/provided.

setuptools and pip come bundled with this package so to comply with the
packaging guidelines [1], virtual provides are added [2]

[1]
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries#Requirement_if_you_bundle

[2]
https://github.com/fedora-python/python35/commit/32884823a3aa88983fe8370f6696a11068cdecfe

%{pylibdir} gets expanded to %{_libdir}/python3.5 so it will not conflict with
%{_libdir}/python3.4 at F23.

Also after some testing on F23 VM's I did not notice any regressions. 

'python3' command fires up the python 3.4.2 shell and 'python35' the 3.5.2
shell.

Please, before you make a build and push it to the repos, wait for [3][4] to be
pushed to stable repos, so no one will get caught in an upgrade path issue.

[3] https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e71caf3e6
[4] https://bodhi.fedoraproject.org/updates/FEDORA-2016-d49f8ec161

Package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376450] Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376450

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Depends On||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376450] New: Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376450

Bug ID: 1376450
   Summary: Review Request: libdvbpsi - Library for MPEG TS and
DVB PSI tables decoding and generation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://pkgs.rpmfusion.org/cgit/free/libdvbpsi.git/tree/libdvbpsi.spec
SRPM URL:
http://download1.rpmfusion.org/free/fedora/development/rawhide/Everything/source/SRPMS/l/libdvbpsi-1.3.0-1.fc24.src.rpm
Description: Library for MPEG TS and DVB PSI tables decoding and generation
Fedora Account System Username: kwizart

This package is provided in a 3rd part repository, but I believe it should be
in fedora instead. (provided that it pass FE-Legal).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047

Tomas Mraz  changed:

   What|Removed |Added

 CC||tm...@redhat.com
   Assignee|nob...@fedoraproject.org|tm...@redhat.com
  Flags||fedora-review?



--- Comment #23 from Tomas Mraz  ---
I'll review this package.

My comments:

Use ExclusiveArch instead of BuildArch and in general follow
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Architecture_Support
If the reason for building on just the architectures specified is that the
other platforms do not have the hardware needed, then please at least add a
comment about this fact to the spec.

The build is nonstandard and does not apply RPM_OPT_FLAGS and LDFLAGS during
the build which means that hardening and optimalization is not applied. This
must be fixed too.

%attr(0755,root,root) %{_libdir}/*.so
- %attr is not applicable to symlink

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363923] Review Request: springframework4 - Spring Java Application Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363923



--- Comment #3 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/springframework4.spec
SRPM URL: https://gil.fedorapeople.org/springframework4-4.1.9-1.fc24.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15641731

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376436



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
Blocked FE-Legal because the header contains structures related to possibly
patented format. I expect it's more around mux than codec, but need to be
confirmed. Also there is no implementation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376436

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Depends On||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376436

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Blocks||1376438




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376438
[Bug 1376438] Review Request: dvblast - Simple and powerful streaming
application
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Depends On||1376436




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376436
[Bug 1376436] Review Request: bitstream - Simpler access to binary
structures such as specified by MPEG, DVB, IETF
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376438] New: Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438

Bug ID: 1376438
   Summary: Review Request: dvblast - Simple and powerful
streaming application
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/dvblast.spec
SRPM URL: http://dl.kwizart.net/review/dvblast-3.0-1.fc26.src.rpm
Description: Simple and powerful streaming application
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376437




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376437
[Bug 1376437] Review Request: golang-github-fatih-color - Color package for
Go (golang)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376437] Review Request: golang-github-fatih-color - Color package for Go (golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376437

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389
 Depends On||1376407, 1376412




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1376407
[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for
golang
https://bugzilla.redhat.com/show_bug.cgi?id=1376412
[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable
writer for windows.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376407

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376437




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376437
[Bug 1376437] Review Request: golang-github-fatih-color - Color package for
Go (golang)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376437] New: Review Request: golang-github-fatih-color - Color package for Go (golang)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376437

Bug ID: 1376437
   Summary: Review Request: golang-github-fatih-color - Color
package for Go (golang)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-fatih-color/golang-github-fatih-color.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-fatih-color/golang-github-fatih-color-0-0.1.git4f7bcef.fc24.src.rpm

Description: Color package for Go (golang)

Fedora Account System Username: mrunge

$ rpmlint golang-github-fatih-color-0-0.1.git4f7bcef.fc24.src.rpm
golang-github-fatih-color-devel-0-0.1.git4f7bcef.fc24.noarch.rpm
golang-github-fatih-color-unit-test-devel-0-0.1.git4f7bcef.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376436] New: Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376436

Bug ID: 1376436
   Summary: Review Request: bitstream - Simpler access to binary
structures such as specified by MPEG, DVB, IETF
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/bitstream.spec
SRPM URL: http://dl.kwizart.net/review/bitstream-1.1-1.fc26.src.rpm
Description: Simpler access to binary structures such as specified by MPEG,
DVB, IETF.
Fedora Account System Username: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #13 from Vít Ondruch  ---
(In reply to Pavel Raiskup from comment #12)
> > 2. It is good idea to include AppData file in package, to make this plugin
> > visible in Gnome Software.
> 
> TBH, I have no idea what Gnome Software is so I'm not the best
> person to write the patch.  If you can help here, I can include that now
> or in post-review time.


There is not to much magic in it. Here is the guidelines [0]. You can take some
inspiration in vim-fugitive for example [1, 2 , 3]


[0]
https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation
[1]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.metainfo.xml
[2]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.spec#n17
[3]
http://pkgs.fedoraproject.org/cgit/rpms/vim-fugitive.git/tree/vim-fugitive.spec#n81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376407

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376412




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable
writer for windows.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389
 Depends On||1376407




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1376407
[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for
golang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376412] New: Review Request: golang-github-mattn-go-colorable - Colorable writer for windows.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376412

Bug ID: 1376412
   Summary: Review Request: golang-github-mattn-go-colorable -
Colorable writer for windows.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-colorable/golang-github-mattn-go-colorable.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-colorable/golang-github-mattn-go-colorable-0-0.1.git9cbef7c.fc24.src.rpm

Description: Colorable writer for windows.

Fedora Account System Username: mrunge

$ rpmlint golang-github-mattn-go-colorable-0-0.1.git9cbef7c.fc24.src.rpm
golang-github-mattn-go-colorable-devel-0-0.1.git9cbef7c.fc24.noarch.rpm
golang-github-mattn-go-colorable.src: W: summary-ended-with-dot C Colorable
writer for windows.
golang-github-mattn-go-colorable-devel.noarch: W: summary-ended-with-dot C
Colorable writer for windows.
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


this package depends on https://bugzilla.redhat.com/show_bug.cgi?id=1376407

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376407] Review Request: golang-github-mattn-go-isatty - isatty for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376407

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376407] New: Review Request: golang-github-mattn-go-isatty - isatty for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376407

Bug ID: 1376407
   Summary: Review Request: golang-github-mattn-go-isatty - isatty
for golang
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-isatty/golang-github-mattn-go-isatty.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-mattn-go-isatty/golang-github-mattn-go-isatty-0-0.1.git56b76bd.fc24.src.rpm

Description: isatty for golang

Fedora Account System Username: mrunge

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15641289

$ rpmlint golang-github-mattn-go-isatty-0-0.1.git56b76bd.fc24.src.rpm
golang-github-mattn-go-isatty-devel-0-0.1.git56b76bd.fc24.noarch.rpm
golang-github-mattn-go-isatty.src: W: summary-not-capitalized C isatty for
golang
golang-github-mattn-go-isatty-devel.noarch: W: summary-not-capitalized C isatty
for golang
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #12 from Pavel Raiskup  ---
Thanks for having a look!

(In reply to Vít Ondruch from comment #11)
> 1. I consider good habit to include vim- prefix in vim plugin package name.

That's one of the notes I suggested in original review.

> 2. It is good idea to include AppData file in package, to make this plugin
> visible in Gnome Software.

TBH, I have no idea what Gnome Software is so I'm not the best
person to write the patch.  If you can help here, I can include that now
or in post-review time.

Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/vim-syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/vim-syntastic-3.7.0-4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #11 from Vít Ondruch  ---
Two notes here:

1. I consider good habit to include vim- prefix in vim plugin package name.

2. It is good idea to include AppData file in package, to make this plugin
visible in Gnome Software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376387] Review Request: golang-github-Unknwon-com - Commonly used functions for the Go programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376387

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1211821] Review Request: golang-github-bradfitz-gomemcache - Go Memcached client library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1211821

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1376389




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376389
[Bug 1376389] Tracker for grafana dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1376387] New: Review Request: golang-github-Unknwon-com - Commonly used functions for the Go programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376387

Bug ID: 1376387
   Summary: Review Request: golang-github-Unknwon-com - Commonly
used functions for the Go programming language
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mru...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://mrunge.fedorapeople.org/reviews/golang-github-Unknwon-com/golang-github-Unknwon-com.spec

SRPM URL:
https://mrunge.fedorapeople.org/reviews/golang-github-Unknwon-com/golang-github-Unknwon-com-0-0.1.gitd9bcf40.fc24.src.rpm

Description: This is an open source project for commonly used functions for the
Go
programming language.

Fedora Account System Username: mrunge

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15640721

$ rpmlint golang-github-Unknwon-com-0-0.1.gitd9bcf40.fc24.src.rpm
golang-github-Unknwon-com-devel-0-0.1.gitd9bcf40.fc24.noarch.rpm
golang-github-Unknwon-com-unit-test-devel-0-0.1.gitd9bcf40.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1211821] Review Request: golang-github-bradfitz-gomemcache - Go Memcached client library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1211821

Matthias Runge  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||mru...@redhat.com
   Assignee|nob...@fedoraproject.org|mru...@redhat.com
  Flags||fedora-review+



--- Comment #3 from Matthias Runge  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 2 files have unknown
 license. Detailed output of licensecheck in /home/fedora/1211821
 -golang-github-bradfitz-gomemcache/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/bradfitz(golang-github-bradfitz-
 http2-devel)
Both packages don't conflict and both own
/usr/share/gocode/src/github.com/bradfitz; they are adding subdirs to that dir.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is 

[Bug 1259486] Review Request: libglvnd - The GL Vendor-Neutral Dispatch library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259486



--- Comment #15 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/libglvnd.spec
SRPM URL:
http://dl.kwizart.net/review/libglvnd-0.2.999-1.git14f6283.fc24.src.rpm

koji scratch build for f26:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15640225

Changelog:
- Update to 2.999 version
- Add EGL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #10 from Pavel Raiskup  ---
FTR: https://github.com/rpm-software-management/rpm/pull/91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #9 from Pavel Raiskup  ---
FYI: https://github.com/praiskup/syntastic-rpm/commit/fa3a37e273a538


Spec URL:
https://raw.githubusercontent.com/praiskup/syntastic-rpm/private-praiskup-unretirement-2016/syntastic.spec
SRPM URL: http://praiskup.fedorapeople.org/syntastic-3.7.0-3.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374024] Review Request: python-plotcat - Python library for plotting live serial input using matplotlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374024



--- Comment #8 from Parag AN(पराग)  ---
1) The keyword here "Upstream" is not correct for this bugzilla, hence I
removed it.

2) I missed to ask do you want to add this package to epel7. If no them remove
all if...else added in spec file which may look almost same as by running
"pyp2rpm plotcat".

But if you want to add it to epel7 then just need to move following BR: inside
python3-plotcat package.
BuildRequires:  python3-setuptools
BuildRequires:  python3-devel

3) The pyp2rpm is adding the BuildRequires: python-setuptools which should have
been python2-setuptools for Fedora specific builds,but again if you want to add
this package to epel7 then keep BR: python-setuptools else change it to BR:
python2-setuptools.

4) symlink is not needed for this package so it can be removed. Again it looks
its added by the usage of pyp2rpm. Remove following lines
-
cp %{buildroot}/%{_bindir}/live_plot.py %{buildroot}/%{_bindir}/live_plot.py-3
ln -sf %{_bindir}/live_plot.py-3
%{buildroot}/%{_bindir}/live_plot.py-%{python3_version}

cp %{buildroot}/%{_bindir}/live_plot.py %{buildroot}/%{_bindir}/live_plot.py-2
ln -sf %{_bindir}/live_plot.py-2
%{buildroot}/%{_bindir}/live_plot.py-%{python2_version}
---
and then from the %files section as well. Just install live_plot.py file.

But then you should be having properly set python shebang in live_plot.py file.
Hence, change in you spec file
sed -i -e '/^#!\//, 1d' *.py
to
sed -i -e '/^#!\//, 1d' plotcat/*.py


5) And yes add the trailing "/" as suggested by Igor in above comment.

6) Indeed after looking into LICENSE file and source files, the license is
"GPLv3+" not just "GPLv3" because there is a "or later version" clause in
LICENSE file.



Provide updated SPEC and SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #19 from Tomas Repik  ---
(In reply to gil cattaneo from comment #18)
> [!]: Package contains BR: python2-devel or python3-devel
> Missing "python_provide" and:
> %check
> %{__pythonX} setup.py test
> or add a comment, in the spec file, why do not run test suite
added  "python_provide" and the %check section as well
> [!]: %check is present and all tests pass.
> have you contacted upstream for report the problem?
I'm gonna update the package to 3.7 and see if the tests fail again. If yes I'm
gonna ask upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org