[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349

Link Dupont  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|l...@sub-pop.net
  Flags||fedora-review?



--- Comment #4 from Link Dupont  ---
LGTM. I'll give this a final once over and finish up once I'm approved as a
packager.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #15 from Link Dupont  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #14)
> So... package is good, but you need packager privileges. See the bottom part
> of comment #c4 for the next steps. Also, please fill in your full name in
> FAS (https://admin.fedoraproject.org/accounts/user/view/linkdupont).

Oh yea. I did a review of flyingsaucersattack on 1303349. Looks like there's a
follow-up for me. I'll track down a couple others.

I do have my full name in FAS. Is it not showing up?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381029] Review Request: python-more-itertools - Python library for efficient use of itertools utility in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381029



--- Comment #14 from Fedora Update System  ---
python-more-itertools-2.2-4.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f4b339a351

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381029] Review Request: python-more-itertools - Python library for efficient use of itertools utility in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381029



--- Comment #13 from Fedora Update System  ---
python-more-itertools-2.2-4.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8c6ddc739d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381029] Review Request: python-more-itertools - Python library for efficient use of itertools utility in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381029



--- Comment #12 from Fedora Update System  ---
python-more-itertools-2.2-4.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-194f805855

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1355592] Review Request: libvmi - A library for performing virtual-machine introspection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1355592



--- Comment #6 from Matthew Garrett  ---
Broadly speaking, this seems fine, but one significant issue: the library
package is shipping libvmi-0.11.so and libvmi.so. This seems wrong. If there's
an expectation that multiple versions of the libvmi development environment
should be parallel-installable, we should have libvmi-0.11.so.something in the
main package and libvmi-0.11.so in the -devel package. If not, we should have
libvmi.so.11 (or some other versioning) in the main package and libvmi.so in
the -devel package. Raw .so files should not be in the main libvmi package.
This is probably something that needs to be discussed with upstream - it's
easier if we solve library versioning issues there.

There's also the general concern over shared libraries calling exit(), but I
think in this case it's reasonable (it's only in the safe_malloc() function).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385180] Review Request: purple-facebook - Facebook protocol plugin for purple2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385180

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
into pidgin → for pidgin

%{__rm} → rm
There's absolutely no need to do this. The guidelines require macros for
*directories*, but not for executables. If you have a rogue rm in the path, you
have bigger problems, and anyway, there are various other programs called
during build, so guarding just rm isn't useful. Same for %__make.

+ package name is OK
+ latest version
+ license is acceptable for Fedora (GPLv2+)
+ license is specified correctly
+ provides/requires look OK
+ builds and installs OK
+ no scriptlets needed (.so in private directory)
- versioning doesn't follow the guidelines
[https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages has
the rules, but it's rather muddled unfortunately]. I think keeping the git date
in version makes sense, but the git tag should be moved to the release tag.

%global gitcommit ea683512f9b82f2257770f0ed56d819eea230fc2
%global gitdate 20160405
%{?gitcommit:%global gitcommitshort %(c=%{gitcommit}; echo ${c:0:7})}

Version: 0.0.%{gitdate}
Release: 1%{?gitcommit:.git%{gitcommitshort}}%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1355592] Review Request: libvmi - A library for performing virtual-machine introspection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1355592

Matthew Garrett  changed:

   What|Removed |Added

 CC||mj...@srcf.ucam.org
   Assignee|ignate...@redhat.com|mj...@srcf.ucam.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #8 from Tim Fenn  ---
(In reply to Antonio Trande from comment #7)
> (In reply to Tim Fenn from comment #6)
> > (In reply to Antonio Trande from comment #5)
> > > (In reply to Tim Fenn from comment #4)
> > > > 
> > > > > - doc sub-package isn't noarch
> > > > > 
> > > > 
> > > > I didn't specify it as such?
> > > 
> > > I don't see any 'BuildArch: noarch' line...
> > > 
> > 
> > OK I'll have that fixed in the next build - sorry, I misread this the first
> > time.
> > 
> > > > 
> > > > New files:
> > > > 
> > > > spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
> > > > srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA
> > > 
> > > '%defattr(-,root,root,-)' and 'rm -rf %{buildroot}' are used for epel5 
> > > only.
> > > 
> > 
> > Is the %if 0%{?rhel} not sufficient around these statements?  Or should it
> > just be removed all together?
> 
> If this package isn't for epel5, you can remove all.
> 

OK done.

> > 
> > > Why coot-1.spec ?
> > > SPEC file must have same name of src-rpm.
> > 
> > Doh, silly google drive renaming.  I'll fix in the next upload.
> 
> Why not fedorapeople?

Fair enough - new files:

https://timfenn.fedorapeople.org/coot.spec
https://timfenn.fedorapeople.org/coot-0.8.6.1-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #7 from Raphael Groner  ---
Tests work locally and in mock. But I don't know what's the reason to let them
fail for the htmlunit parts in koji, maybe caused by some network restriction
or general limitation of resources.

Asking upstream: https://github.com/JWebUnit/jwebunit/issues/5

Running net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest
Tests run: 3, Failures: 1, Errors: 2, Skipped: 0, Time elapsed: 2.31 sec <<<
FAILURE! - in net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest
testChangeRefreshHandler(net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest) 
Time elapsed: 1.435 sec  <<< ERROR!
net.sourceforge.jwebunit.exception.TestingEngineResponseException: unexpected
status code [503] at URL:
[http://localhost:8082/jwebunit/RefreshHandlerTest/testPage.html]
at
net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest.testChangeRefreshHandler(RefreshHandlerTest.java:96)
Caused by: com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 503
Service Unavailable for
http://localhost:8082/jwebunit/RefreshHandlerTest/testPage.html
at
net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest.testChangeRefreshHandler(RefreshHandlerTest.java:96)
testAlternateRefreshHandler(net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest)
 Time elapsed: 0.024 sec  <<< ERROR!
net.sourceforge.jwebunit.exception.TestingEngineResponseException: unexpected
status code [503] at URL:
[http://localhost:8082/jwebunit/RefreshHandlerTest/testPage.html]
at
net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest.testAlternateRefreshHandler(RefreshHandlerTest.java:75)
Caused by: com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 503
Service Unavailable for
http://localhost:8082/jwebunit/RefreshHandlerTest/testPage.html
at
net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest.testAlternateRefreshHandler(RefreshHandlerTest.java:75)
testDefaultRefreshHandler(net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest)
 Time elapsed: 0.028 sec  <<< FAILURE!
java.lang.AssertionError: 
msg was not as expected.
[unexpected status code [503] at URL:
[http://localhost:8082/jwebunit/RefreshHandlerTest/testPage.html]]
at
net.sourceforge.jwebunit.htmlunit.RefreshHandlerTest.testDefaultRefreshHandler(RefreshHandlerTest.java:55)
[…]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382797] Review Request: python-pyvo - Access to remote data and services of the Virtual observatory (VO) using Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382797

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:13



--- Comment #6 from Fedora Update System  ---
python-pyvo-0.0-0.1.20161005git70090d6.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:03



--- Comment #8 from Fedora Update System  ---
python-astroscrappy-1.0.5-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375962] Review Request: python-sphinx-intl - Sphinx utility that make it easy to translate and to apply translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375962

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:17



--- Comment #10 from Fedora Update System  ---
python-sphinx-intl-0.9.9-3.gitbf6edc2.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:08



--- Comment #9 from Fedora Update System  ---
python-reproject-0.3.1-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||karlthe...@gmail.com
   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---
So... package is good, but you need packager privileges. See the bottom part of
comment #c4 for the next steps. Also, please fill in your full name in FAS
(https://admin.fedoraproject.org/accounts/user/view/linkdupont).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385244] Review Request: pew - Manage multiple Python virtual environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385244

Mathieu Bridon  changed:

   What|Removed |Added

 Depends On||1385240, 1385237




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385237
[Bug 1385237] Review Request: python-pythonz-bd - Manage python
installations in your system
https://bugzilla.redhat.com/show_bug.cgi?id=1385240
[Bug 1385240] Please provide the /usr/bin/virtualenv-MAJOR symlinks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385237] Review Request: python-pythonz-bd - Manage python installations in your system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385237

Mathieu Bridon  changed:

   What|Removed |Added

 Blocks||1385244




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385244
[Bug 1385244] Review Request: pew - Manage multiple Python virtual
environments
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385244] New: Review Request: pew - Manage multiple Python virtual environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385244

Bug ID: 1385244
   Summary: Review Request: pew - Manage multiple Python virtual
environments
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: boche...@daitauha.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bochecha.fedorapeople.org/packages/pew.spec
SRPM URL: https://bochecha.fedorapeople.org/packages/pew-0.1.24-1.fc24.src.rpm

Description:
Python Env Wrapper is a set of commands to manage multiple virtual
environments. Pew can create, delete and copy your environments, using a
single command to switch to them wherever you are, while keeping them in a
single (configurable) location.

Virtualenvs make it easier to work on more than one project at a time without
introducing conflicts in their dependencies.

Pew is completely shell-agnostic and thus works on bash, zsh, fish,
powershell, etc.


Fedora Account System Username: bochecha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1110070] Review Request: vert.x - A lightweight, high-performance, polyglot, event-driven application platform for JVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1110070



--- Comment #6 from gil cattaneo  ---
Seem the 3.x series do not provides anymore lang-rhino
https://github.com/vert-x3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385237] Review Request: python-pythonz-bd - Manage python installations in your system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385237

Mathieu Bridon  changed:

   What|Removed |Added

 Depends On||1302744




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302744
[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library
to fetch files over HTTP and resuming their download
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Mathieu Bridon  changed:

   What|Removed |Added

 Blocks||1385237




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385237
[Bug 1385237] Review Request: python-pythonz-bd - Manage python
installations in your system
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385237] New: Review Request: python-pythonz-bd - Manage python installations in your system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385237

Bug ID: 1385237
   Summary: Review Request: python-pythonz-bd - Manage python
installations in your system
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: boche...@daitauha.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bochecha.fedorapeople.org/packages/python-pythonz-bd.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-pythonz-bd-1.11.2-1.fc24.src.rpm

Description:
pythonz is a program to automate the building and installation of Python in
the users $HOME. This is a fork of the original project, pythonbrew.

CPython, Stackless, PyPy and Jython are supported.

Fedora Account System Username: bochecha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744



--- Comment #3 from Mathieu Bridon  ---
Here's a new version of the package for review, now that python-rangehttpserver
has been approved.

Spec URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-resumable-urlretrieve-0.1.2-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #2 from David Hannequin  ---
Hello,

* It is better to be more specific and use `python2-setuptools` instead of
`python-setuptools`.

I fix this.

* It is good to indicate in the subpackage description whether it is Python 2
or Python3.

I fix this too.

* Tests are packaged but the %check section is not present.

I add %check but work only with python 2 because pyhon 3 test failed. I'll
report to upstream. 

Could pass anyway for review ? 

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Mathieu Bridon  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com



--- Comment #3 from Mathieu Bridon  ---
Thanks for the review Pierre-Yves and Haikel!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||karlthe...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Haïkel Guémar  ---
Two nitpicks:
- I'm fine with not including python2, but add a comment explaining that
it is supported upstream and co-maintainers are welcome to add it.
- No license file, I made a PR to fix it upstream, just add a comment linking
to it (for future maintainers documentation)
https://github.com/danvk/RangeHTTPServer/pull/15

As all of the above can be made at import time, i hereby approve this package.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 6 files have unknown license. Detailed
 output of licensecheck in /home/haikel/1385223-python-
 rangehttpserver/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python3-rangehttpserver (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
Pull Request by reviewer https://github.com/danvk/RangeHTTPServer/pull/15
[x]: Final provides and requires are sane 

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Pierre-YvesChibon  changed:

   What|Removed |Added

 CC||pin...@pingoured.fr



--- Comment #1 from Pierre-YvesChibon  ---
! The license tag seems odd :)

* spec is nice and clean
* License is fine for Fedora
* spec respects the packaging guidelines

I can't do the testing/building right now so if someone wants to finish the
review please go ahead, otherwise I'll finish later

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library to fetch files over HTTP and resuming their download

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302744

Mathieu Bridon  changed:

   What|Removed |Added

 Depends On||1385223




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385223
[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer
with support for Range requests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] New: Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Bug ID: 1385223
   Summary: Review Request: python-rangehttpserver -
SimpleHTTPServer with support for Range requests
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: boche...@daitauha.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://bochecha.fedorapeople.org/packages/python-rangehttpserver.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-rangehttpserver-1.2.0-1.fc25.src.rpm

Description:
SimpleHTTPServer with support for Range requests.

Fedora Account System Username: bochecha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385223] Review Request: python-rangehttpserver - SimpleHTTPServer with support for Range requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385223

Mathieu Bridon  changed:

   What|Removed |Added

 Blocks||1302744




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302744
[Bug 1302744] Review Request: python-resumable-urlretrieve - Small library
to fetch files over HTTP and resuming their download
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482



--- Comment #16 from Didier  ---
> 
> EPEL is pending some fixes to patches before it gets an update
> 

Am I mistaken in understanding that compiling & running nC 10.0.1 on EL7 merely
involves disabling Patch7 & Patch8 (which seem merely cosmetic patches too me)
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384917] Review Request: python-pykwalify - Python lib/cli for JSON/ YAML schema validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384917



--- Comment #1 from Parag AN(पराग)  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
1) Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

==> We have only PyYAML and not python-PyYAML, fix Requires: this for
python2-pykwalify

   Do not write any versions for Requires: lines. Packages in that particular
release should resolve dependencies.

2) Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/doc/python2-pykwalify/README.md
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

==> Remove tests/files/README.md from both the packages, tests files are not
getting installed so don't install its README.md

3) Remove egg-info in %prep end section as below to fix rpmlint errors.
rm -rf *.egg-info

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "JSON MIT/X11 (BSD like)", "Unknown or generated". 110 files
 have unknown license. Detailed output of licensecheck in
 /home/parag/Downloads/1384917-python-pykwalify/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: 

[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #13 from Link Dupont  ---
I can take this now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org