[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379798

MartinKG  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mgans...@alice.de
   Assignee|nob...@fedoraproject.org|mgans...@alice.de



--- Comment #2 from MartinKG  ---
please modify your spec file, 

replace in build section:
make %{?_smp_mflags}
by
%make_build

and in install section:
make %{?_smp_mflags} install DESTDIR=%{buildroot}
by
%make_install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030



--- Comment #3 from Nikos Mavrogiannopoulos  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1347878] Review Request: xorsearch - Search for a given string in an XOR, ROL, ROT or SHIFT encoded binary file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1347878



--- Comment #7 from Fedora Update System  ---
xorsearch-1.11.1-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b043636f33

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1347878] Review Request: xorsearch - Search for a given string in an XOR, ROL, ROT or SHIFT encoded binary file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1347878

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1347878] Review Request: xorsearch - Search for a given string in an XOR, ROL, ROT or SHIFT encoded binary file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1347878



--- Comment #6 from Fedora Update System  ---
xorsearch-1.11.1-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3507bc8eea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261



--- Comment #1 from Yaakov Selkowitz  ---
There are two reasons for including a package in -ugly: 1) license of included
code or dependent library is "stronger" than LGPL (usually GPL), and/or 2)
software patents.  The former should still be acceptable for Fedora; as
mentioned above, there are already other GPL plugins in -bad-free.

Therefore, requesting legal review of the above plugins to see which (if any)
fall under the former category and can therefore be included.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148

Yaakov Selkowitz  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-22 00:09:45



--- Comment #9 from Yaakov Selkowitz  ---
gstreamer1-plugin-mpg123 is in.  Opened a separate bug for a possible
-ugly-free.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] New: Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261

Bug ID: 1397261
   Summary: Review Request: gstreamer1-plugins-ugly-free -
GStreamer ugly plugins
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: yselk...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: extras...@fedoraproject.org, mat...@redhat.com,
package-review@lists.fedoraproject.org
Depends On: 1396139
Blocks: 182235 (FE-Legal)



+++ This bug was initially created as a clone of Bug #1394148 +++

Spec URL:
https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec
SRPM URL:
https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-1.fc25.src.rpm
Description: GStreamer plug-in for mp3 support through mpeg123.
Fedora Account System Username: wtaymans

This is the GStreamer plugin for mp3 playback extracted from the
gstreamer1-plugins-ugly package.

--- Additional comment from Yaakov Selkowitz on 2016-11-11 15:13:24 EST ---

Are there any other parts of gst-plugins-ugly which we can include as a
(slightly) more complete gstreamer1-plugins-ugly-free?

There are five plugins under gst/ with actual code:

* asfdemux: demuxer for Microsoft's Advanced Streaming Format
* dvdlpcmdec: Decode DVD LPCM frames into standard PCM
* dvdsub: DVD subtitle parser and decoder
* realmedia: RealMedia support
* xingmux: add Xing tags to MP3 files

And the following plugins under ext/ which just wrap other libraries which are,
or could be, in Fedora:

* cdio: read CD audio with libcdio (which is free but GPL)
* dvdread: access DVDs with libdvdread (which is free but GPL; note that there
is another plugin already in gstreamer1-plugins-bad-free which uses
libdvd{nav,read})
* mad: MP3 decoding with libmad (now considered free but GPL; currently under
package review in bug 1396139)
* mpg123: just added as gstreamer1-plugin-mpg123.

There are others, but their dependent libraries are not in Fedora for legal
reasons, or just obsolete (namely, libsidplay).  Precedence is that ext/
plugins need not be removed from the tarballs even if they wrap unacceptable
libraries, since they are just wrappers.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1396139
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396139

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1397261




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397261
[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly
plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839



--- Comment #6 from Sundeep Anand  ---
Thank you for pointing this! Have corrected and updated package:

SPEC URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-notifications-hq.spec

SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-django-notifications-hq-1.2-1.fc24.src.rpm

Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16558924

- getting some errors in py3 tests:
django.core.exceptions.ImproperlyConfigured: Requested setting AUTH_USER_MODEL,
but settings are not configured. You must either define the environment
variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing
settings.

- initially intended to package for epel7 also, but some dependencies are not
packaged for epel7 so, may be for fedora only.

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383416

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||panem...@gmail.com



--- Comment #3 from Parag AN(पराग)  ---
Iryna,
   I think if you are not sponsored yet then you should not assign reviews to
your self. Suppose some other reviewer want to approve package then neither he
can approve as you have assigned review to yourself nor you can approve. Thus
nothing get progressed on such package reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396139

Yaakov Selkowitz  changed:

   What|Removed |Added

 CC||yselk...@redhat.com



--- Comment #8 from Yaakov Selkowitz  ---
(In reply to Neal Gompa from comment #7)
> * Sources are missing from the libmad-debuginfo subpackage. This needs to be
> fixed.

I suggest the following patches:

https://gitweb.gentoo.org/repo/gentoo.git/plain/media-libs/libmad/files/libmad-0.15.1b-cflags.patch
https://gitweb.gentoo.org/repo/gentoo.git/plain/media-libs/libmad/files/libmad-0.15.1b-cflags-O2.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273

Jeremy Newton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|alexjn...@gmail.com



--- Comment #8 from Jeremy Newton  ---
(In reply to MartinKG from comment #7)
> (In reply to Jeremy Newton from comment #6)
> > 
> > Any status on this? Are you still interested in packaging this?
> > I can review this if you're interested in a review swap.
> 
> ok lets us swap the review.

Sounds good, I have #1379798 available to review.

As for this review, please update the spec to the latest version (1.0.16) and
update the source url to something like this:
https://github.com/j-jorge/%{name}/archive/%{version}.tar.gz#/%{name}_%{version}.tar.gz

As well, please unbundle plee-the-bear if possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379798



--- Comment #1 from Jeremy Newton  ---
Reuploading and disabling hardened build

SPEC URL:
https://dl.dropboxusercontent.com/u/42480493/pcsxr.spec

SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/pcsxr-1.9.94-3.fc25.src.rpm

Also, koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16558025

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873



--- Comment #6 from Michal Ambroz  ---
Thanks Zbysek for comments.
Updated package:

Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm

Best regards
Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Stephen Gallagher  ---
OK, I think this looks good to go. Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391444] Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391444



--- Comment #4 from Haïkel Guémar  ---
@Jason: it's a RDO package review, RDO being based upon CentOS 7 (though we try
tofollow Fedora guidelines when possible)
Actually, we're following the //-installable boost package in EPEL convention
(Boost 1.48 being shipped as boost148)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1159091] Review Request: openra - Libre/ Free Real Time Strategy project [+Tracker to unbundle all dependencies]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1159091



--- Comment #17 from Jeremy Newton  ---
(In reply to Matthias Mailänder from comment #16)
> If getting software into Fedora is such an bureaucratic, time-consuming and
> laborious act, we could also collaborate together on a FlatPak/AppImage
> bundle that works across distributions.
> https://github.com/OpenRA/OpenRA/issues/12257
> 
> I guess this task will fail anyway in the IP review as OpenRA relies a lot
> on foreign intellectual property. Even though trademarks are avoided, the
> code is a clean room implementation and most of the assets are hosted
> separately on a community mirror server with silent approval from Electronic
> Arts, I assume licensing and redistribution of files as in
> https://github.com/OpenRA/OpenRA/tree/bleed/mods/ra/bits are a real problem,
> that has to be addressed first.

IMHO, most of the bureaucratic issues came down to the strict no-bundling
policy and a few other issues that have since been reworked and "loosened".

Although in regard to the "foreign intellectual property", I can imagine you
are correct, but I can't speak for the legal team.

RPMFusion could be used to package this if legal rejects this, but with that
said, I would still think that a FlatPak would be the easiest option.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #8 from Merlin Mathesius  ---
Thank you for the additional detailed feedback.

According to description of the following commit in the upstream repository, it
is intended that users can customize the %config files in
%{_sysconfdir}/avocado/sysinfo:

   
https://github.com/avocado-framework/avocado/commit/0a6dc703252cd2405b5251ecebfc545a587ef4c8

Updates have been made to address the rest of your review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-6.fc24.src.rpm
COPR build URL:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479732/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1347878] Review Request: xorsearch - Search for a given string in an XOR, ROL, ROT or SHIFT encoded binary file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1347878



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xorsearch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-async-timeout-1.1.0-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da89a216e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1371810] Review Request: python-iowait - Platform-independent module for I/O completion events

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371810

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-iowait-0.2-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d5a2ff69

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-thriftpy-0.3.9-1.fc25, python-toro-1.0.1-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4362aee1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-thriftpy-0.3.9-1.fc25, python-toro-1.0.1-1.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b4362aee1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
perl-HTTP-Entity-Parser-0.18-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #21 from Fedora Update System  ---
modulemd-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3a627bbae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #3 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery-0.1.5-1.fc26.src.rpm

* Mon Nov 21 2016 Orion Poplawski  - 0.1.5-3
- Add upstream patch to fix UnicodeDecodeError

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Stephen Gallagher  changed:

   What|Removed |Added

  Flags||needinfo?(mmathesi@redhat.c
   ||om)



--- Comment #7 from Stephen Gallagher  ---
I have just a few remaining comments at this point:

- Please put a space after %config(noreplace), for readability. It looks like
part of the path, which it is not.

- %config(noreplace)%{_sysconfdir}/avocado/conf.d/README, %config(noreplace)
{_sysconfdir}/avocado/scripts/job/pre.d/README and
%config(noreplace)%{_sysconfdir}/avocado/scripts/job/post.d/README should not
be %config(noreplace). They shouldn't be edited by the end-user and as such we
want changes to them clobbered on update.

- Are %config(noreplace)%{_sysconfdir}/avocado/sysinfo/commands,
%config(noreplace)%{_sysconfdir}/avocado/sysinfo/files and
%config(noreplace)%{_sysconfdir}/avocado/sysinfo/profilers supposed to be
editable by the end-user? If they're not *really* config files, they should not
be %config(noreplace) (also, it would be best if upstream moved them to
/usr/share if they're truly supposed to be immutable).

- Please remove the executable bit from all python files in %doc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1159091] Review Request: openra - Libre/ Free Real Time Strategy project [+Tracker to unbundle all dependencies]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1159091



--- Comment #16 from Matthias Mailänder  ---
If getting software into Fedora is such an bureaucratic, time-consuming and
laborious act, we could also collaborate together on a FlatPak/AppImage bundle
that works across distributions. https://github.com/OpenRA/OpenRA/issues/12257

I guess this task will fail anyway in the IP review as OpenRA relies a lot on
foreign intellectual property. Even though trademarks are avoided, the code is
a clean room implementation and most of the assets are hosted separately on a
community mirror server with silent approval from Electronic Arts, I assume
licensing and redistribution of files as in
https://github.com/OpenRA/OpenRA/tree/bleed/mods/ra/bits are a real problem,
that has to be addressed first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #7 from Antonio Trande  ---
(In reply to Link Dupont from comment #6)
> It does run without those fonts in that path. I assumed it would fall back
> to the system-provided fonts, and it appears I was lucky it did. So no need
> to symlink to system-level fonts. Pulling them in via Requires: was
> sufficient.
> 
> The only contents in %{_datadir}/%{name}/default/data/fonts were the *.ttf
> files and some README/licenses.

mmh..
dejavu-sans-fonts and google-roboto-fonts use different paths. Please, create
the symlinks to be sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1159091] Review Request: openra - Libre/ Free Real Time Strategy project [+Tracker to unbundle all dependencies]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1159091



--- Comment #15 from Matthias Mailänder  ---
If getting software into Fedora is such an bureaucratic, time-consuming and
laborious we could also collaborate together on a FlatPak/AppImage bundle that
works across distributions. https://github.com/OpenRA/OpenRA/issues/12257

I guess this task will fail anyway in the IP review as OpenRA relies a lot on
foreign intellectual property. Even though trademarks are avoided, the code is
a clean room implementation and most of the assets are hosted separately on a
community mirror server with silent approval from Electronic Arts, I assume
licensing and redistribution of files as in
https://github.com/OpenRA/OpenRA/tree/bleed/mods/ra/bits are a real problem,
that has to be addressed first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273



--- Comment #7 from MartinKG  ---
(In reply to Jeremy Newton from comment #6)
> 
> Any status on this? Are you still interested in packaging this?
> I can review this if you're interested in a review swap.

ok lets us swap the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971

Antonio Trande  changed:

   What|Removed |Added

Summary|Review Request: Elemental - |Review Request: elemental -
   | distributed-memory dense   | distributed-memory dense
   |and sparse-direct linear|and sparse-direct linear
   |algebra and optimizatio |algebra and optimizatio



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #19 from Antonio Trande  ---
- Code under external/suite_sparse is under LGPLv2+ license.
  Other code/cmake files is MIT, Boost.
  Please, update License tag and pack debian/copyright by using
  %license tag.

- Don't need to execute ldconfig scripts.

- Some tests are failed on PPC64:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16555354

- I see you're using a master.zip archive source code. It would be better
indicate the date of the commit,
elemental-0.87-2.%{checkout}git%{commitnumber}%{?dist}
  See https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages

x MUST: The package must be named according to the Package Naming Guidelines .
x MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
x MUST: The package must meet the Packaging Guidelines .
x MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
! MUST: The License field in the package spec file must match the actual
license. [3]
x MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %license.[4]

x MUST: The spec file must be written in American English. [5]
x MUST: The spec file for the package MUST be legible. [6]
? MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once   imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.

! MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]

x MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
! MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
x MUST: Packages must NOT bundle copies of system libraries.[11]
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]

x MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
x MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
x MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. [15]
x MUST: Each package must consistently use macros. [16]
x MUST: The package must contain code, or permissible content. [17]
- MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]

x MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
- MUST: Static libraries must be in a -static package. [19]
x MUST: Development files must be in a -devel package. [20]
x MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
x MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[19]
- MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]

x MUST: Packages must not own files or directories already owned by 

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #6 from Merlin Mathesius  ---
Updated to (hopefully) address all review concerns.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-5.fc24.src.rpm
COPR build URLs:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479689/ and
(because fedora-rawhide-x86_64 build mysteriously failed on the first try)
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/479690/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273

Jeremy Newton  changed:

   What|Removed |Added

 CC||alexjn...@gmail.com



--- Comment #6 from Jeremy Newton  ---
(In reply to MartinKG from comment #5)
> (In reply to Raphael Groner from comment #3)
> >
> > * SHOULD what is "Plee the Bear"? How is it related to this package? You
> > won't be able to create two individual subpackges for that 'bear' and
> > 'bear-factory' stuff. So consider to package that separately and unbundle.
> > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> > > of the Bear Engine for Plee the Bear & Andy's Super Great Park.
> > 
> 
> there is already a package plee-the-bear for Fedora and only needs to be
> unbundled.
> https://apps.fedoraproject.org/packages/plee-the-bear

Any status on this? Are you still interested in packaging this?
I can review this if you're interested in a review swap.

> yes this is a valid link for asgp-1.0.8
> 
> but there is a recent version 1.0.12 on https://github.com/j-jorge/asgp/
> build instruction:
> 
> mkdir asgp-build
> cd asgp-build
> git clone https://github.com/j-jorge/bear.git
> git clone https://github.com/j-jorge/asgp.git
> 
> [root@fc21 asgp-build]# du -sk *
> 1140264   asgp
> 37616 bear
> 
> approx. 1,17 GByte
> 
> should we use this version ?
There is a new version available. Also your URL comment doesn't correctly
explain how to get the sources, but fortunately enough, it should be sufficient
to update the URL to the following:
https://github.com/j-jorge/%{name}/archive/%{version}.tar.gz#/%{name}_%{version}.tar.gz

At a quick glance, a few things will need to be updated (for example, "%setup
-qn %{oname}-%{version}" can be replaced with "%setup -q"), but it's pretty
minor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396296] New OSP11 package from CBS -- python-tenacity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396296

Steve Linabery  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||python-tenacity-3.2.1-1.el7
   ||ost



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Jeremy Newton  changed:

   What|Removed |Added

 CC||alexjn...@gmail.com



--- Comment #7 from Jeremy Newton  ---
Hi,

I can take this review if you're interested in review swapping with me

(In reply to Igor Gnatenko from comment #2)
> Note that not all bundled jars are available in repos. I don't know how
> properly make Provides: bundled() for them.

Although the bundling policy is looser now, you still require the "Provides:
bundled()" information for anything that you cannot unbundle. This makes it
easier to track bundled libraries, such as if the library is introduced into
fedora and it can be unbundled, or if a security issue exists and all bundled
versions must be patched, etc.

For example if you bundled "foo" with version "1.0.0":

Provides: bundled(foo) = 1.0.0

See the guidelines for details:
https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396296] New OSP11 package from CBS -- python-tenacity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396296

Lon Hohberger  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793

Ben Rosser  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #30 from Ben Rosser  ---
Good catch with savepng; it seems that licensecheck didn't pick up on that. :(

Anyway, this package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated".
 39 files have unknown license. Detailed output of licensecheck in
 /home/bjr/Programming/fedora/reviews/1155793-hyperrogue/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 

[Bug 1159091] Review Request: openra - Libre/ Free Real Time Strategy project [+Tracker to unbundle all dependencies]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1159091

Jeremy Newton  changed:

   What|Removed |Added

 CC||alexjn...@gmail.com



--- Comment #14 from Jeremy Newton  ---
Unbundling third party libraries shouldn't be a hard blocker anymore due to
changes in Fedora's policies. Is there licensing issues? If not, this should
still be good to package, providing any bundled software (that can't be
removed) is built from source and the necessary "Provides: bundled(*)" are
added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #6 from Link Dupont  ---
It does run without those fonts in that path. I assumed it would fall back to
the system-provided fonts, and it appears I was lucky it did. So no need to
symlink to system-level fonts. Pulling them in via Requires: was sufficient.

The only contents in %{_datadir}/%{name}/default/data/fonts were the *.ttf
files and some README/licenses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839



--- Comment #5 from Julien Enselme  ---
- Can you launch the tests on python 3 too ? I also think that since you may
not be packaging python 2 depending on the system, you should guard the python
2 tests with the %if 0%{?with_python2} macros.
- The lists of requires are good. However, they are not in the proper package.
If you look at the output of fedora-review or rpm -qp --requires PACKAGE you
will see:
python2-django-notifications-hq (rpmlib, GLIBC filtered):
python(abi)

python3-django-notifications-hq (rpmlib, GLIBC filtered):
python(abi)

For them to be correct, you must declare them like this:
%if 0%{?with_python2}
%package -n python2-%{pypi_name}
Requires:  python2-django
Requires:  pytz
Requires:  python2-django-model-utils
Requires:  python2-django-jsonfield
Summary:%{summary}
%{?python_provide:%python_provide python2-%{pypi_name}}

%description -n python2-%{pypi_name}
GitHub notification alike app for Django, derived from django-activity-stream.
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140

Jeremy Newton  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] New: Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140

Bug ID: 1397140
   Summary: Review Request: mrrescue - Arcade-style fire fighting
game
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: alexjn...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://dl.dropboxusercontent.com/u/42480493/mrrescue.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/mrrescue-1.02e-1.fc24.src.rpm

Description:
Mr. Rescue is an arcade styled 2d action game centered around evacuating
civilians from burning buildings. The game features fast paced fire
extinguishing action, intense boss battles, a catchy soundtrack and lots of
throwing people around in pseudo-randomly generated buildings.

Fedora Account System Username: Mystro256

Notes:
-This spec is based on an existing package "orthorobot" (maintained by me), so
this review should be pretty straight forward
-The icon is just the splash screen cropped and re-centered using ImageMagick
on build (I can move this to prep if prefered)
-Appdata is added as a patch (upstream aims to only distribute Linux binaries
as "love" files, thus not applicable upstream)
-Code is licensed under CC-BY-SA with 3 files licensed as MIT, which should be
fully compatible with Fedora, see SPEC comment and LICENSE
-The exclude arch is used, as the "love" dependency does not compile on all
arch's for F26+
-No rpmlint output

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395554] Review Request: python-astral - Calculations for the position of the sun and moon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395554



--- Comment #7 from Fabian Affolter  ---
* Mon Nov 21 2016 Fabian Affolter  - 1.3.2-1
- Add license file
- Run test without third party interaction
- Update to latest upstream release 1.3.2

Updates files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-astral.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-astral-1.3.2-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030

Daiki Ueno  changed:

   What|Removed |Added

 CC||du...@redhat.com
   Assignee|nob...@fedoraproject.org|du...@redhat.com
  Flags||fedora-review+



--- Comment #2 from Daiki Ueno  ---
It looks good to me.  Here are some issues that would be good to fix:

- there are mentions of "zlib compression library", which probably came from
the template
- maybe good to use %license instead of %doc for COPYING
- there are inconsistent uses of tabs and spaces

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Sources can be downloaded from URI in Source: tag
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be 

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #4 from Rex Dieter  ---
compromise: drop from summary, include in description if you insist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #3 from Rex Dieter  ---
It's a slippery slope (I shudder thinking if *all* packages mentioned largely
irrelevant technical details), but I can understand your point of view even if
I disagree with it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #2 from Kevin Kofler  ---
And I think this is actually essential information and the main reason why I
would pick one application over another doing the same thing. I don't like your
removal of these mentions at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #3 from Iryna Shcherbina  ---
Hello Fabian,

thank you for the changes.

The spec file looks good to me, but I would suggest to do another small change.
The %description is missing one sentence comparing to the one in package
documentation and therefore seems incomplete.
Please change it to the original one:

A simple Python module to retrieve battery information on Linux-based operating
system. No ACPI or external software is needed. Only the Linux kernel and its
/sys/class/power_supply folder.

Also, could you please explain to me why you define the following:

> %if 0%{?fedora}
> %bcond_without python3
> %else
> %bcond_with python3
> %endif


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should 

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu



--- Comment #1 from Rex Dieter  ---
Small suggestion (my usual pet-peave): remove mention of Qt from
summary/description, users don't need to know or care what toolkit is used

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389404] Review Request: python-Flask-PyMongo - PyMongo support for Flask applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389404



--- Comment #2 from David Hannequin  ---
Hi,

You right directory /usr/lib/pythonX/site-packages/tests isn't necessary for
package. 

I delete this directory after test rpm.

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fl@sh  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] New: Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Bug ID: 1397089
   Summary: Review Request: DNSCryptClient - qt gui for dnscrypt
proxy
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: alex.mail.1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient.spec

SRPM URL:
https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient-1.0.0-1.fc26.src.rpm

Description: The Qt GUI wrapped over dnscrypt-proxy
for encrypting all DNS traffic between the user and DNS resolvers,
preventing any spying, spoofing or man-in-the-middle attacks.

Fedora Account System Username: f1ash

Success build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16553976

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215



--- Comment #8 from Fedora Update System  ---
perl-Tie-DataUUID-1.02-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7a74d13110

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174



--- Comment #10 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc25 perl-XML-Spice-0.05-1.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fb58d68c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #6 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc24 perl-XML-Spice-0.05-1.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a19778f161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #7 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc24 perl-XML-Spice-0.05-1.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a19778f161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174



--- Comment #11 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc24 perl-XML-Spice-0.05-1.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a19778f161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #4 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc25 perl-XML-Spice-0.05-1.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fb58d68c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #5 from Fedora Update System  ---
perl-Net-DAVTalk-0.11-1.fc25 perl-XML-Spice-0.05-1.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fb58d68c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240



--- Comment #8 from Fedora Update System  ---
perl-XML-Fast-0.11-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-84113c90c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #6 from gil cattaneo  ---
can you add 

 %pom_xpath_inject "pom:project" "bundle" 
 %pom_add_plugin org.apache.felix:maven-bundle-plugin . "
 true
 
   true
   
 com.github.ben-manes.caffeine
 com.github.ben-manes.caffeine
 \${project.version}
   
 
 
   
 bundle-manifest
 process-classes
 
   manifest
 
   
 "

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383416

David Hannequin  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-inlfuxdb -  InfluxDB |python-influxdb -  InfluxDB
   |Python client   |Python client



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #4 from gil cattaneo  ---
Issues:
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'

 Please, add find -name "*.jar" -delete in %prep section

Please, use:

Source0:   
https://github.com/ben-manes/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
instead of

Source0:https://github.com/ben-manes/%{name}/archive/v%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #5 from gil cattaneo  ---
Only a question can you build guava and jcache sub modules?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'
 Please, add find -name "*.jar" -delete in %prep section

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* GPL (v2)", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 13 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1397051-caffeine/licensecheck.txt
 GPL (v2)
caffeine-2.3.3/caffeine/src/jmh/java/com/github/benmanes/caffeine/cache/impl/ConcurrentHashMapV7.java
 but not used/packaged
 CC-BY 4.0
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/cache2k/LICENSE.txt
  
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/cache2k/orm-busy.trace.xz
  
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/cache2k/orm-night.trace.xz
  
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/cache2k/web07.trace.xz
  
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/cache2k/web12.trace.xz
 but not used/packaged

[x]: License file installed when any subpackage combination is installed.
[?]: Package contains no bundled libraries without FPC exception.

caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/lirs/lirs.c

caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/lirs/lirs.h
 but not used/packaged
 see
caffeine-2.3.3/simulator/src/main/resources/com/github/benmanes/caffeine/cache/simulator/parser/lirs/README

[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
 see above
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not 

[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290342

Tomas Repik  changed:

   What|Removed |Added

 CC||tre...@redhat.com
   Assignee|nob...@fedoraproject.org|tre...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #2 from gil cattaneo  ---
Is available a new relase 2.3.5. Please, consider updating

Please, use:

Source0:   
https://github.com/ben-manes/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
instead of

Source0:https://github.com/ben-manes/%{name}/archive/v%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #1 from gil cattaneo  ---
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290342 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389346] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389346



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to David Hannequin from comment #2)
> Is what I need to delete .egg-info ?

There's no need to delete it in .spec. If you do delete it, it's not a big
deal, but it's unnecessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051

Tomas Repik  changed:

   What|Removed |Added

 Blocks||1324020




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandra - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1341272 |1397051



--- Comment #26 from Tomas Repik  ---
We managed to package caffeine, the last missing dependency.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341272
[Bug 1341272] undefined symbol: sigar_skip_token
https://bugzilla.redhat.com/show_bug.cgi?id=1397051
[Bug 1397051] Review Request: caffeine - High performance java 8 caching
library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] New: Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051

Bug ID: 1397051
   Summary: Review Request: caffeine - High performance java 8
caching library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tre...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://trepik.fedorapeople.org/caffeine/v0/caffeine.spec
SRPM URL:
https://trepik.fedorapeople.org/caffeine/v0/caffeine-2.3.3-1.fc24.src.rpm
Description: A Cache is similar to ConcurrentMap, but not quite the same. The
most
fundamental difference is that a ConcurrentMap persists all elements that are
added to it until they are explicitly removed. A Cache on the other hand is
generally configured to evict entries automatically, in order to constrain its
memory footprint. In some cases a LoadingCache or AsyncLoadingCache can be
useful even if it doesn't evict entries, due to its automatic cache loading.

Caffeine provide flexible construction to create a cache with a combination
of the following features:
automatic loading of entries into the cache, optionally asynchronously
size-based eviction when a maximum is exceeded based on frequency and recency
time-based expiration of entries, measured since last access or last write
asynchronously refresh when the first stale request for an entry occurs
keys automatically wrapped in weak references
values automatically wrapped in weak or soft references
notification of evicted (or otherwise removed) entries
writes propagated to an external resource
accumulation of cache access statistics

The reason for packaging this library is that Apache Cassandra (opensource
database) uses caffeine.

Fedora Account System Username: trepik

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Net-DAVTalk-0.11-1.fc2
   ||6



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183



--- Comment #9 from Fedora Update System  ---
perl-Text-VCardFast-0.11-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-02d23ebb5a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183



--- Comment #8 from Fedora Update System  ---
perl-Text-VCardFast-0.11-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d21eb3c9e9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-DAVTalk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #20 from Fedora Update System  ---
stress-ng-0.07.05-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b925ae12fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #19 from Fedora Update System  ---
stress-ng-0.07.05-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0663121c05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #18 from Fedora Update System  ---
stress-ng-0.07.05-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7960f25459

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #5 from Antonio Trande  ---
>rm -rf %{buildroot}%{_datadir}/%{name}/default/data/fonts

Have you tested freeorion?
Does it use the icons?

Usually, bundled icons are replaced with symbolic links to system icons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #17 from Fedora Update System  ---
stress-ng-0.07.05-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3bb7571351

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #16 from Fedora Update System  ---
stress-ng-0.07.05-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e8476982e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #15 from Fedora Update System  ---
stress-ng-0.07.05-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ef192fa61

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198760

Michal Ambroz  changed:

   What|Removed |Added

  Flags||needinfo?(mail@fabian-affol
   ||ter.ch)



--- Comment #14 from Michal Ambroz  ---
Latest version is 0.18.2
Pyamf package still not available in Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #14 from Sascha Spreitzer  ---
License field changed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389346] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389346



--- Comment #2 from David Hannequin  ---
Hi,

I fix description and summary with %_description and %{summary}. 

Is what I need to delete .egg-info ?

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030



--- Comment #1 from Nikos Mavrogiannopoulos  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=16552737

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] New: Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030

Bug ID: 1397030
   Summary: Review Request: mingw-libidn2 - MinGW Windows
Internationalized Domain Name 2008 support library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: nmavr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/nmavrogi/fedora/mingw-libidn2.spec
SRPM URL:
http://people.redhat.com/nmavrogi/fedora/mingw-libidn2-0.10-1.fc24.src.rpm
Description: Libidn2 is an implementation of the IDNA2008 specifications in RFC
5890, 5891, 5892 and 5893 for internationalized domain names (IDN).
It is a standalone library, without any dependency on libidn.
Fedora Account System Username: nmavrogi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-DAVTalk-0.11-1.fc26.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(Carp)
  1 perl(DateTime::Format::ISO8601)
  1 perl(DateTime::TimeZone)
  1 perl(Encode)
  1 perl(Exporter)
  1 perl(HTTP::Tiny) >= 0.016
  1 perl(JSON)
  1 perl(MIME::Base64)
  1 perl(Net::DAVTalk::XMLParser)
  1 perl(Tie::DataUUID) >= 1.02
  1 perl(URI) >= 1.60
  1 perl(URI::Escape)
  1 perl(XML::Fast) >= 0.11
  1 perl(XML::Spice) >= 0.03
  1 perl(base)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-DAVTalk-0.11-1.fc26.noarch.rpm | sort | uniq -c
  1 perl(Net::DAVTalk) = 0.11
  1 perl(Net::DAVTalk::XMLParser)
  1 perl-Net-DAVTalk = 0.11-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Net-DAVTalk*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389695] Review Request: python-wcsaxes - A Python framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389695



--- Comment #6 from Sergio Pascual  ---
Great, thank you for the review anyway

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org