[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1183877 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1183877
[Bug 1183877] thrift-0.9.3 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1397051 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397051
[Bug 1397051] Review Request: caffeine - High performance java 8 caching
library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1397051, which changed state.

Bug 1397051 Summary: Review Request: caffeine - High performance java 8 caching 
library
https://bugzilla.redhat.com/show_bug.cgi?id=1397051

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-12-08 05:00:54



--- Comment #39 from Tomas Repik  ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=823599

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #38 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/cassandra

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #37 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v7/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v7/cassandra-3.9-1.fc24.src.rpm

Thank YOU!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #36 from gil cattaneo  ---
These instrunctions are also useless : "%attr(755, root, root) %{_bindir}/..."
Please, consider removing them

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #35 from gil cattaneo  ---
(In reply to Tomas Repik from comment #34)
> (In reply to gil cattaneo from comment #33)
> > License fiels should be: ASL 2.0 and BSD
> > Please,  add also a comment, e.g.:
> DONE
> Thanks for helping with this I'm always confused with the licenses
> > The "Requires" list is automatically generated. This entry, for me is
> > useless.
> > What is rh-maven33? why maven? why is necessary? Please, to explain in a
> > comment in the spec file.
> Removed for now, will be added later if needed
> 
> Is there any other issue?

For me right now should be fine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #34 from Tomas Repik  ---
(In reply to gil cattaneo from comment #33)
> License fiels should be: ASL 2.0 and BSD
> Please,  add also a comment, e.g.:
DONE
Thanks for helping with this I'm always confused with the licenses
> The "Requires" list is automatically generated. This entry, for me is
> useless.
> What is rh-maven33? why maven? why is necessary? Please, to explain in a
> comment in the spec file.
Removed for now, will be added later if needed

Is there any other issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #33 from gil cattaneo  ---
(In reply to gil cattaneo from comment #31)
> Issues:
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
>  generated", "*No copyright* Apache (v2.0)". 74 files have unknown
>  license. Detailed output of licensecheck in
>  /home/gil/1324020-cassandra/licensecheck.txt
> 
>  Apache (v2.0) BSD (3 clause)
> cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

License fiels should be: ASL 2.0 and BSD
Please,  add also a comment, e.g.:

# Apache (v2.0) BSD (3 clause):
# ./src/java/org/apache/cassandra/utils/vint/VIntCoding.java 
License:ASL 2.0 and BSD

> [!]: Requires correct, justified where necessary.
>  Please, remove useless: %{?scl:Requires: %scl_require rh-maven33}

The "Requires" list is automatically generated. This entry, for me is useless.
What is rh-maven33? why maven? why is necessary? Please, to explain in a
comment in the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #32 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v6/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v6/cassandra-3.9-1.fc24.src.rpm
Koji Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16756287

- changed the installation of stress sub-package as suggested
- added NOTICE.txt to the javadoc sub-package
- asked upstream to include license headers [1]
- asked upstream to update some cassandra dependencies to fedora versions,
providing them patches updating their sources, all of these are mentioned in
the spec file
- added systemd macros

[1] https://issues.apache.org/jira/browse/CASSANDRA-12993

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #31 from gil cattaneo  ---
Issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 74 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1324020-cassandra/licensecheck.txt

 Apache (v2.0) BSD (3 clause)
cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

[!]: License file installed when any subpackage combination is installed.
 Missing NOTICE.txt in javadoc sub package

 The following source files are without license headers:
  cassandra-3.9/doc/source/_static/extra.css

  cassandra-3.9/src/java/org/apache/cassandra/db/commitlog/IntervalSet.java
  cassandra-3.9/src/java/org/apache/cassandra/utils/IntegerInterval.java

 
cassandra-3.9/test/unit/org/apache/cassandra/db/commitlog/CommitLogCQLTest.java
  cassandra-3.9/test/unit/org/apache/cassandra/utils/IntegerIntervalsTest.java

  cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/WorkManager.java
 
cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/util/TimingIntervals.java

 Please, contact upstream and ask to confirm the licensing of code and/or
content/s, and add license headers

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification


> (In reply to gil cattaneo from comment #28)
> > A question:
> > ...
> > install -p -D -m 755 build/tools/lib/%{pkg_name}-stress.jar
> > %{buildroot}%{_javadir}/%{pkg_name}-stress.jar
> > ...
> > %attr(755, root, root) %{_javadir}/%{pkg_name}-stress.jar
> > 
> > why?
> 
> should be
> 
> install -p -D -m 644 build/tools/lib/%{pkg_name}-stress.jar
> %{buildroot}%{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar
> 
> %{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar

https://fedoraproject.org/wiki/Packaging:Java#JAR_file_installation

Not available "macros to handle systemd scriptlet operations"
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd

[!]: Requires correct, justified where necessary.
 Please, remove useless: %{?scl:Requires: %scl_require rh-maven33}

[!]: Packages are noarch unless they use JNI
 Note: cassandra subpackage is not noarch. Please verify manually

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #30 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'


= MUST items =

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 74 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1324020-cassandra/licensecheck.txt

 Apache (v2.0) BSD (3 clause)
cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

[!]: License file installed when any subpackage combination is installed.
 Missing NOTICE.txt in javadoc sub package

 The following source files are without license headers:
  cassandra-3.9/doc/source/_static/extra.css

  cassandra-3.9/src/java/org/apache/cassandra/db/commitlog/IntervalSet.java
  cassandra-3.9/src/java/org/apache/cassandra/utils/IntegerInterval.java

 
cassandra-3.9/test/unit/org/apache/cassandra/db/commitlog/CommitLogCQLTest.java
  cassandra-3.9/test/unit/org/apache/cassandra/utils/IntegerIntervalsTest.java

  cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/WorkManager.java
 
cassandra-3.9/tools/stress/src/org/apache/cassandra/stress/util/TimingIntervals.java

 Please, contact upstream and ask to confirm the licensing of code and/or
content/s, and add license headers

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/java,
 /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.

[?]: Package contains no bundled libraries without FPC exception.
 cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 Please, remove: %{?scl:Requires: %scl_require rh-maven33}
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 440320 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package 

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #29 from gil cattaneo  ---
(In reply to gil cattaneo from comment #28)
> A question:
> ...
> install -p -D -m 755 build/tools/lib/%{pkg_name}-stress.jar
> %{buildroot}%{_javadir}/%{pkg_name}-stress.jar
> ...
> %attr(755, root, root) %{_javadir}/%{pkg_name}-stress.jar
> 
> why?

should be

install -p -D -m 644 build/tools/lib/%{pkg_name}-stress.jar
%{buildroot}%{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar

%{_javadir}/%{pkg_name}/%{pkg_name}-stress.jar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #28 from gil cattaneo  ---
A question:
...
install -p -D -m 755 build/tools/lib/%{pkg_name}-stress.jar
%{buildroot}%{_javadir}/%{pkg_name}-stress.jar
...
%attr(755, root, root) %{_javadir}/%{pkg_name}-stress.jar

why?
should be

install -p -D -m 644 build/tools/lib/%{pkg_name}-stress.jar
%{buildroot}%{_javadir}/%{pkg_name}-stress.jar
%{_javadir}/%{pkg_name}-stress.jar

can you use this instruction to install the artifact:

%mvn_package org.apache.cassandra:%{pkg_name}-stress stress
%mvn_artifact org.apache.cassandra:%{pkg_name}-stress:%{version}
build/tools/lib/%{pkg_name}-stress.jar

%files stress  -f .mfiles-stress
%license LICENSE.txt NOTICE.txt
%attr(755, root, root) %{_bindir}/%{pkg_name}-stress
%attr(755, root, root) %{_bindir}/%{pkg_name}-stressd
%attr(755, root, root) %{_bindir}/%{pkg_name}.in.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #27 from Tomas Repik  ---
Tramtadamtamtamtamt!

Spec URL: https://trepik.fedorapeople.org/cassandra/v5/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v5/cassandra-3.9-1.fc24.src.rpm
Koji Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16692989

- all of the dependencies finally in fedora
- changed the method of linking the dependencies to the lib folder
(build-jar-repository)
- SCLized - added some SCL macros to be able to build it as a SCL 
- net.mintern:primitive - removed as it's gonna be removed in later cassandra
release

I feel that it's gonna be in fedora very soon!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1341272 |1397051



--- Comment #26 from Tomas Repik  ---
We managed to package caffeine, the last missing dependency.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341272
[Bug 1341272] undefined symbol: sigar_skip_token
https://bugzilla.redhat.com/show_bug.cgi?id=1397051
[Bug 1397051] Review Request: caffeine - High performance java 8 caching
library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #25 from gil cattaneo  ---
(In reply to Tomas Repik from comment #24)
> (In reply to gil cattaneo from comment #23)
> > caffeine replace
> > com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru 
> > (see https://github.com/ben-manes/concurrentlinkedhashmap/issues/48),
> > you could try to remove it but could produce other issues.
> 
> All right I'll with with somebody to package caffeine and it's dependencies
> into  fedora.

i have begun this @ https://gil.fedorapeople.org/caffeine/
but there are some unavailable deps:
com.typesafe:config:1.3.0 https://bugzilla.redhat.com/show_bug.cgi?id=1249965
com.squareup:javapoet:?
net.openhft:koloboke-api-jdk8,koloboke-impl-jdk8:0.6.7

Dependencies with issues:
com.github.brianfrankcooper.ycsb:core:0.10.0 (use apache
htrace-core4.1.0-incubating ; this package was retired)
com.typesafe.akka:akka-actor_2.10:2.3.15 (this package was retired)

Dependencies changes:
javax.cache:cache-api:1.0.0 (NON free, use
org.apache.geronimo.specs:geronimo-jcache_1.0_spec)

> > Default Python interpreter for Fedora (in rawhide) should be python3
> > I do not understand ...
> 
> I didn't remember why we choose python2, but after some research I know now.
> Cassandra itself uses python 2.7 and its code (cqlshlib) is not python3
> compatible [1].

OK. Please, add a comment in the spec file

> > All test suite? or few tests?
> 
> Almost all of the tests.


> Also there has been a new release od cassandra 3.9 recently, I'll focus on
> that one.
> 
> [1] https://paste.fedoraproject.org/444041/69193147/raw/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #24 from Tomas Repik  ---
(In reply to gil cattaneo from comment #23)
> caffeine replace
> com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru 
> (see https://github.com/ben-manes/concurrentlinkedhashmap/issues/48),
> you could try to remove it but could produce other issues.

All right I'll with with somebody to package caffeine and it's dependencies
into  fedora.

> Default Python interpreter for Fedora (in rawhide) should be python3
> I do not understand ...

I didn't remember why we choose python2, but after some research I know now.
Cassandra itself uses python 2.7 and its code (cqlshlib) is not python3
compatible [1].

> All test suite? or few tests?

Almost all of the tests.

> Please, cleanup spec file

DONE (will post new spec file with some other changes that might come)

Also there has been a new release od cassandra 3.9 recently, I'll focus on that
one.

[1] https://paste.fedoraproject.org/444041/69193147/raw/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #23 from gil cattaneo  ---
(In reply to Tomas Repik from comment #22)

> 
> (In reply to gil cattaneo from comment #21)
> > i know caffeine is "not friendly" (read crap) with packager. but this will
> > not be the possibility of keeping the package, at length, in Fedora
> So you think it's ineviteble to package caffeine? What if we removed
> caffeine 
> from cassandra so it's not dependent? Is that not possible? I can help with
> doing either.

caffeine replace
com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru 
(see https://github.com/ben-manes/concurrentlinkedhashmap/issues/48),
you could try to remove it but could produce other issues.

> > Default Python interpreter for Fedora (in rawhide) should be python3
> > For me should better split clientutil package in:
> > - clientutil only the binaries/scripts files
> > - python2-cqlshlib and/or python3-cqlshlib
> DONE (only python2 because of usage in SCLs)
I do not understand ...

> > [!]: Packages are noarch unless they use JNI
> > %package parent
> DONE
> 
> Tests still don't work...
All test suite? or few tests?

Please, cleanup spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #22 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v4/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v4/cassandra-3.5-1.fc23.src.rpm

(In reply to gil cattaneo from comment #21)
> i know caffeine is "not friendly" (read crap) with packager. but this will
> not be the possibility of keeping the package, at length, in Fedora
So you think it's ineviteble to package caffeine? What if we removed caffeine 
from cassandra so it's not dependent? Is that not possible? I can help with
doing either.

> Default Python interpreter for Fedora (in rawhide) should be python3
> For me should better split clientutil package in:
> - clientutil only the binaries/scripts files
> - python2-cqlshlib and/or python3-cqlshlib
DONE (only python2 because of usage in SCLs)

> [!]: Packages are noarch unless they use JNI
> %package parent
DONE

Tests still don't work...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #21 from gil cattaneo  ---
(In reply to Tomas Repik from comment #20)
> So far not much progress:
> * submitted an issue about failing tests on cassandra's jira [1]
> 
> * new version 3.7 has a new dependency (caffeine [2]) which is not in
> rawhide, and won't be for a while, so for now I would use the 3.5, which is
> fine

i know caffeine is "not friendly" (read crap) with packager. but this will not
be the possibility of keeping the package, at length, in Fedora

> Is there anything else I should resolve for the review?

> [!]: Package contains BR: python2-devel or python3-devel

Default Python interpreter for Fedora (in rawhide) should be python3
For me should better split clientutil package in:
- clientutil only the binaries/scripts files
- python2-cqlshlib and/or python3-cqlshlib

as in https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
http://python-rpm-porting.readthedocs.io/en/latest/modules.html#ported-rpm-spec-file

> [!]: Packages are noarch unless they use JNI
%package parent

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #20 from Tomas Repik  ---
So far not much progress:
* submitted an issue about failing tests on cassandra's jira [1]

* new version 3.7 has a new dependency (caffeine [2]) which is not in rawhide,
and won't be for a while, so for now I would use the 3.5, which is fine

Is there anything else I should resolve for the review?

[1] https://issues.apache.org/jira/browse/CASSANDRA-12708
[2] https://github.com/ben-manes/caffeine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #19 from Tomas Repik  ---
(In reply to gil cattaneo from comment #18)
> [!]: Package contains BR: python2-devel or python3-devel
> Missing "python_provide" and:
> %check
> %{__pythonX} setup.py test
> or add a comment, in the spec file, why do not run test suite
added  "python_provide" and the %check section as well
> [!]: %check is present and all tests pass.
> have you contacted upstream for report the problem?
I'm gonna update the package to 3.7 and see if the tests fail again. If yes I'm
gonna ask upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #18 from gil cattaneo  ---
(In reply to Tomas Repik from comment #17)
> (In reply to gil cattaneo from comment #15)
> > [!]: Package contains BR: python2-devel or python3-devel
> > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
> Can you be more specific about what you don't like about it? Even from the
> link you gave I don't see anything wrong.

Missing "python_provide" and:
%check
%{__pythonX} setup.py test
or add a comment, in the spec file, why do not run test suite

> > [!]: License field in the package spec file matches the actual license.
> I checked the attachement about licenses but I think the license headers are
> present and sane as well.
> > [!]: Latest version is packaged.
> I'm gonna update to the version 3.7 in very near future.
OK
> > [!]: %check is present and all tests pass.
> Now I remembered ahy i skipped the tests, I got these errors and, so far was
> unable to solve those.
> * Error1 Caused by: org.apache.cassandra.exceptions.ConfigurationException:
> Unable to check disk space available to build/test/cassandra/commitlog:21.
> Perhaps the Cassandra user does not have the necessary permissions
> * Error2 Caused by: java.io.IOException: Mount point not found
> I can provide full log if you'd like.

have you contacted upstream for report the problem?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #17 from Tomas Repik  ---
(In reply to gil cattaneo from comment #15)
> [!]: Package contains BR: python2-devel or python3-devel
> Still not available. can you revert?
> see this template
> https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Can you be more specific about what you don't like about it? Even from the link
you gave I don't see anything wrong.
> [!]: License field in the package spec file matches the actual license.
I checked the attachement about licenses but I think the license headers are
present and sane as well.
> [!]: Latest version is packaged.
I'm gonna update to the version 3.7 in very near future.
> [!]: %check is present and all tests pass.
Now I remembered ahy i skipped the tests, I got these errors and, so far was
unable to solve those.
* Error1 Caused by: org.apache.cassandra.exceptions.ConfigurationException:
Unable to check disk space available to build/test/cassandra/commitlog:21.
Perhaps the Cassandra user does not have the necessary permissions
* Error2 Caused by: java.io.IOException: Mount point not found
I can provide full log if you'd like.
> [!]: Packages are noarch unless they use JNI
> also %package parent is noarch
DONE
(In reply to gil cattaneo from comment #15)
> remove all unnecessary comments
Yes I'm gonna do that, but as the last step before building for rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #16 from gil cattaneo  ---
and please, remove all unnecessary comments. especially those who have "%". to
reduce problems with rpmlint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #15 from gil cattaneo  ---
(In reply to Tomas Repik from comment #14)

> Fixed the issues discussed above.

> > [!]: Package contains BR: python2-devel or python3-devel
> Moved to clientutil subpackage
Still not available. can you revert?
see this template
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

> > [!]: License field in the package spec file matches the actual license.
> ignore for now
Why?


> > [!]: Latest version is packaged.
> obviously I know there is a newer version, if that is really necessary I'm
> gonna do the 3.7 version but new versions are released pretty often
As you want
> > [!]: %check is present and all tests pass.
> I don't think there is anything to check
sorry, there are no test suite to run?
> > [!]: Packages are noarch unless they use JNI
> DONE
also %package parent is noarch
> > Rpmlint
> ignored for now
Why?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #14 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v3/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v3/cassandra-3.5-1.fc23.src.rpm

Fixed the issues discussed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #13 from gil cattaneo  ---
(In reply to Tomas Repik from comment #11)
> (In reply to gil cattaneo from comment #8)
> > Issues:
> > ===
> > - Packages have proper BuildRequires/Requires on jpackage-utils
> DONE
> > - Bundled jar/class files should be removed before build
> Jar files are firstly removed and then replaced only with simlinks to
> respective jar files allready installed in the system
> > - If the package provides multiple JAR file, files SHOULD be installed in a
> > %{name} subdirectory
> DONE
> > - JAR files MUST NOT include class-path entry inside META-INF/MANIFEST.MF
> Any advice how to remove the entry?

sed -i '/Class-Path/d' build.xml

remove this line:""

> > [!]: License field in the package spec file matches the actual license.
> ignore for now
> > [!]: License file installed when any subpackage combination is installed.
> DONE
> > [!]: Package contains no bundled libraries without FPC exception.
> >  cassandra-3.5/src/java/org/apache/cassandra/utils/vint/VIntCoding.java This
> > file is part of protocol-buffer project
> >  Please, add Provides:   bundled(protobuf) =  "protobuf version"
> I don't think it is necessary, yes there is a protobuf header, but also
> there is a comment saying VIntCoding.java: "Borrows idea from [1]" There is
> no scource file called VIntCoding.java in protobuf sources [2]

> > [!]: Package contains BR: python2-devel or python3-devel
> Moved to clientutil subpackage
> > [!]: Latest version is packaged.
> obviously I know there is a newer version, if that is really necessary I'm
> gonna do the 3.7 version but new versions are released pretty often
> > [!]: %check is present and all tests pass.
> I don't think there is anything to check
> > [!]: Packages are noarch unless they use JNI
> DONE
> > Rpmlint
> ignored for now
> 
> [1] https://developers.google.com/protocol-buffers/docs/encoding#varints
> [2] https://github.com/google/protobuf


  (In reply to Tomas Repik from comment #12)
> (In reply to gil cattaneo from comment #10)
> > Other issues:
> > in file cassandra-env.sh is set "JVM_OPTS="$JVM_OPTS
> > -Djava.library.path=/usr/lib64/sigar""
> 
> What is wrong with this?
on 32 bit arches /usr/lib64/sigar is not available

waiting the new spec and src rpm, thanks for your work

waiting the new spec and src rpm, thanks for your work

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #12 from Tomas Repik  ---
(In reply to gil cattaneo from comment #10)
> Other issues:
> in file cassandra-env.sh is set "JVM_OPTS="$JVM_OPTS
> -Djava.library.path=/usr/lib64/sigar""

What is wrong with this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #11 from Tomas Repik  ---
(In reply to gil cattaneo from comment #8)
> Issues:
> ===
> - Packages have proper BuildRequires/Requires on jpackage-utils
DONE
> - Bundled jar/class files should be removed before build
Jar files are firstly removed and then replaced only with simlinks to
respective jar files allready installed in the system
> - If the package provides multiple JAR file, files SHOULD be installed in a
> %{name} subdirectory
DONE
> - JAR files MUST NOT include class-path entry inside META-INF/MANIFEST.MF
Any advice how to remove the entry?
> [!]: License field in the package spec file matches the actual license.
ignore for now
> [!]: License file installed when any subpackage combination is installed.
DONE
> [!]: Package contains no bundled libraries without FPC exception.
>  cassandra-3.5/src/java/org/apache/cassandra/utils/vint/VIntCoding.java This
> file is part of protocol-buffer project
>  Please, add Provides:   bundled(protobuf) =  "protobuf version"
I don't think it is necessary, yes there is a protobuf header, but also there
is a comment saying VIntCoding.java: "Borrows idea from [1]" There is no
scource file called VIntCoding.java in protobuf sources [2]
> [!]: Package contains BR: python2-devel or python3-devel
Moved to clientutil subpackage
> [!]: Latest version is packaged.
obviously I know there is a newer version, if that is really necessary I'm
gonna do the 3.7 version but new versions are released pretty often
> [!]: %check is present and all tests pass.
I don't think there is anything to check
> [!]: Packages are noarch unless they use JNI
DONE
> Rpmlint
ignored for now

[1] https://developers.google.com/protocol-buffers/docs/encoding#varints
[2] https://github.com/google/protobuf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #10 from gil cattaneo  ---
Other issues:
in file cassandra-env.sh is set "JVM_OPTS="$JVM_OPTS
-Djava.library.path=/usr/lib64/sigar""

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #9 from gil cattaneo  ---
Created attachment 1199298
  --> https://bugzilla.redhat.com/attachment.cgi?id=1199298=edit
source files are without license headers

Please, report the problem to upstream
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #8 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-utils
  Note: Maven packages do not need to (Build)Require jpackage-utils. It is
  pulled in by maven-local
  See: https://fedoraproject.org/wiki/Packaging:Java
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'
- If the package provides multiple JAR file, files SHOULD be installed in a
%{name} subdirectory
  %{_javadir}/%{name}-stress.jar
  https://fedoraproject.org/wiki/Packaging:Java#Installation_directory
- JAR files MUST NOT include class-path entry inside META-INF/MANIFEST.MF
  cassandra.i686: W: class-path-in-manifest
/usr/lib/java/cassandra/cassandra-all.jar
  https://fedoraproject.org/wiki/Packaging:Java#No_class-path_in_MANIFEST.MF

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 135 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1324020-cassandra/licensecheck.txt

[!]: License file installed when any subpackage combination is installed.
 Missing NOTICE.txt file in javadoc subpackage

[!]: Package contains no bundled libraries without FPC exception.
 cassandra-3.5/src/java/org/apache/cassandra/utils/vint/VIntCoding.java This
file is part of protocol-buffer project
 Please, add Provides:   bundled(protobuf) =  "protobuf version"

[!]: Package contains BR: python2-devel or python3-devel

[!]: Latest version is packaged.
  Available cassandra-3.7

[!]: %check is present and all tests pass.

[!]: Packages are noarch unless they use JNI
 Note: cassandra subpackage is not noarch. Please verify manually
 cassandra-javadoc-3.5-1.fc26.i686.rpm
 cassandra-parent-3.5-1.fc26.i686.rpm
 cassandra-stress-3.5-1.fc26.i686.rpm

= MUST items =

C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 135 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1324020-cassandra/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/java,
 /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 419840 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #7 from gil cattaneo  ---
Please, remove "Requires:jpackage-utils" is useless

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #6 from Tomas Repik  ---
Here is a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15543966

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

Version|rawhide |25
 Whiteboard|NotReady|
  Flags|needinfo+   |



--- Comment #5 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v2/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v2/cassandra-3.5-1.fc23.src.rpm

All right, finaly I have the package ready for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1341272, which changed state.

Bug 1341272 Summary: undefined symbol: sigar_skip_token
https://bugzilla.redhat.com/show_bug.cgi?id=1341272

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1348231 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1348231
[Bug 1348231] update python-cassandra-driver
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1348231, which changed state.

Bug 1348231 Summary: update python-cassandra-driver
https://bugzilla.redhat.com/show_bug.cgi?id=1348231

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1020835 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1020835
[Bug 1020835] snappy-java-1.1.2.6  is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1020835, which changed state.

Bug 1020835 Summary: snappy-java-1.1.2.6  is available
https://bugzilla.redhat.com/show_bug.cgi?id=1020835

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

  Flags|needinfo?(tre...@redhat.com |
   |)   |



--- Comment #4 from Tomas Repik  ---
As does the Whiteboard say, the package is still not ready for review. It
should be though, approximately at the end of June.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1341272




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341272
[Bug 1341272] undefined symbol: sigar_skip_token
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Sascha Spreitzer  changed:

   What|Removed |Added

 CC||sspre...@redhat.com,
   ||tre...@redhat.com
  Flags||needinfo+
   ||needinfo?(tre...@redhat.com
   ||)



--- Comment #3 from Sascha Spreitzer  ---
Review state NEEDINFO

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1329199, 1341013|




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329199
[Bug 1329199] Review Request: concurrent-trees - Concurrent Trees for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1341013
[Bug 1341013] Review Request: compile-command-annotations - Hotspot compile
command annotations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1341013, which changed state.

Bug 1341013 Summary: Review Request: compile-command-annotations - Hotspot 
compile command annotations
https://bugzilla.redhat.com/show_bug.cgi?id=1341013

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1329199, which changed state.

Bug 1329199 Summary: Review Request: concurrent-trees - Concurrent Trees for 
Java
https://bugzilla.redhat.com/show_bug.cgi?id=1329199

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1348231




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1348231
[Bug 1348231] update python-cassandra-driver
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1340876 |



--- Comment #2 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v1/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v1/cassandra-3.5-0.fc23.src.rpm

Getting closer but still not final...


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1340876
[Bug 1340876] cant find symbol error
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1340876, which changed state.

Bug 1340876 Summary: cant find symbol error
https://bugzilla.redhat.com/show_bug.cgi?id=1340876

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1341013




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341013
[Bug 1341013] Review Request: compile-command-annotations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1340876, which changed state.

Bug 1340876 Summary: cant find symbol error
https://bugzilla.redhat.com/show_bug.cgi?id=1340876

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|NOTABUG |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1340876, which changed state.

Bug 1340876 Summary: cant find symbol error
https://bugzilla.redhat.com/show_bug.cgi?id=1340876

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1340876




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1340876
[Bug 1340876] cant find symbol error
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
Add packaging progress and referencies in
https://fedoraproject.org/wiki/SIGs/bigdata/packaging#Packages_we.27re_working_on
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1329201 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329201
[Bug 1329201] Review Request: primitive - Utility methods for Java's
primitive types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1329201, which changed state.

Bug 1329201 Summary: Review Request: primitive - Utility methods for Java's 
primitive types
https://bugzilla.redhat.com/show_bug.cgi?id=1329201

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1329201




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329201
[Bug 1329201] Review Request: primitive - Utility methods for Java's
primitive types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1329199




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329199
[Bug 1329199] Review Request: concurrent-trees - Concurrent Trees for Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1324734 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1324734
[Bug 1324734] Review Request: cassandra-java-driver - DataStax Java Driver
for Apache Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1324734, which changed state.

Bug 1324734 Summary: Review Request: cassandra-java-driver - DataStax Java 
Driver for Apache Cassandra
https://bugzilla.redhat.com/show_bug.cgi?id=1324734

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1306945 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1306945
[Bug 1306945] Review Request: ohc - Java large off heap cache
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1306945, which changed state.

Bug 1306945 Summary: Review Request: ohc - Java large off heap cache
https://bugzilla.redhat.com/show_bug.cgi?id=1306945

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1306629 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1306629
[Bug 1306629] Review Request: metrics-reporter-config - Manages config for
Coda Hale’s Metrics-reporter
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1306629, which changed state.

Bug 1306629 Summary: Review Request: metrics-reporter-config - Manages config 
for Coda Hale’s Metrics-reporter
https://bugzilla.redhat.com/show_bug.cgi?id=1306629

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1324734




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1324734
[Bug 1324734] Review Request: cassandra-java-driver - DataStax Java Driver
for Apache Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On|1306575 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1306575
[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server
implementation backed by LMAX Disruptor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

jiri vanek  changed:

   What|Removed |Added

Summary|Review Request: cassandrsa  |Review Request: cassandra -
   |- OpenSource database   |OpenSource database Apache
   |Apache Cassandra|Cassandra



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org