[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-30 09:06:05



--- Comment #27 from Fedora Update System  ---
kiwi-9.14.0-1.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339
Bug 1483339 depends on bug 1500958, which changed state.

Bug 1500958 Summary: Review Request: python-kiwi-gtk - Framework for Python GUI 
applications
https://bugzilla.redhat.com/show_bug.cgi?id=1500958

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #26 from Fedora Update System  ---
kiwi-9.14.0-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e2a73f7f7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #25 from Fedora Update System  ---
kiwi-9.14.0-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e2a73f7f7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #24 from Fedora Update System  ---
kiwi-9.13.7-2.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e2a73f7f7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #23 from Fedora Update System  ---
kiwi-9.13.7-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1e2a73f7f7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #22 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kiwi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Fabio Valentini  ---
Since those two last issues are fixed:

Package Approved!

(I won't bore you with the full fedora-review output, it would now be
completely redundant with all the comments I made above.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #20 from Neal Gompa  ---
(In reply to Fabio Valentini from comment #19)
> 
> Final remarks:
> 
> - The wrong "BR: python-devel" and "BR: python-setuptools" are still there,
> I assume you just missed them in the last round. Please change the
> BuildRequires to python2-devel and python2-setuptools before importing.
> 

Yep, missed those. Fixed.

> - The wrong shebang in the kiwi/xml_parse.py file is still present. Please
> remove the shebang line with sed or add a patch to remove the line,
> otherwise the automatic shebang mangling will do the wrong thing eventually.
> 

Fixed.

> Please just update the .spec file (no srpm or scratch build necessary,
> though) for those two issues one last time - since these really _are_
> blocking issues by definition ("MUST NOT" items from the guidelines ... [0],
> [1]).
> 
> [0]: http://fedoraproject.org/wiki/Packaging:Python#Dependencies
> [1]: http://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

Done. New stuff below.

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/0072-kiwi/kiwi.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/0072-kiwi/kiwi-9.13.7-0.fc29.4.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #19 from Fabio Valentini  ---
(In reply to Neal Gompa from comment #18)
> (In reply to Fabio Valentini from comment #17)
> > 
> > If you look at the koji task log, you'll see that there was an error where
> > python2-kiwi built differently on ppc64 and x86_64, which I think will be an
> > error for real package builds. It looks like the noarch package virtually
> > provides archful python-kiwi, which is plain wrong. It looks like the 
> > %python_provide macro fails here ...
> > 
> 
> I've discovered this is caused when %python_provide is used before
> "BuildArch: noarch" is declared. the spec parser doesn't yet know the
> subpackage is not archful, so it does the wrong thing here... If the
> "BuildArch: noarch" is _before_ the %python_provide macro, it works as it
> should.
> 
> I've fixed it accordingly.

Wow, that's surprisingly stupid of rpm (or whatever tool is responsible) ...
Good catch.

> > There are three additional, minor things I would suggest to change:
> > 
> > 13) You could drop the leading "A" from the summary tag. It's just noise.
> > 
> 
> Done.

+1

> > 14) Since the -cli subpackage provides %{name}, you could just drop the cli
> > subpackage entirely and put everything from it into the "main" kiwi package.
> > But that's up to you.
> > 
> 
> I do this because I want the content of the cli package to be noarch, and
> limitations in rpm prevent me from doing it with the source package name
> while having some archful subpackages.
> 
> Most of KIWI is noarch, so I did that to have it work out that way.

Ah, you're right. I didn't consider that.

> > 15) Since the package builds binaries from .c files with a Makefile, you
> > will have to add "BR: gcc" and maybe even "BR: make" eventually.
> > 
> > 
> 
> Right. Done.

Ack.

> > Once fedora-review finally finishes I can conclude the review, since most
> > issues have been addressed AFAICT.
> 
> Awesome.
> 
> For "final" verification:
> 
> Spec URL:
> https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-
> x86_64/00728842-kiwi/kiwi.spec
> 
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-
> x86_64/00728842-kiwi/kiwi-9.13.7-0.fc29.3.src.rpm
> 
> Koji scratch build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=25750129

Final remarks:

- The wrong "BR: python-devel" and "BR: python-setuptools" are still there, I
assume you just missed them in the last round. Please change the BuildRequires
to python2-devel and python2-setuptools before importing.

- The wrong shebang in the kiwi/xml_parse.py file is still present. Please
remove the shebang line with sed or add a patch to remove the line, otherwise
the automatic shebang mangling will do the wrong thing eventually.

Please just update the .spec file (no srpm or scratch build necessary, though)
for those two issues one last time - since these really _are_ blocking issues
by definition ("MUST NOT" items from the guidelines ... [0], [1]).

[0]: http://fedoraproject.org/wiki/Packaging:Python#Dependencies
[1]: http://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #18 from Neal Gompa  ---
(In reply to Fabio Valentini from comment #17)
> 
> If you look at the koji task log, you'll see that there was an error where
> python2-kiwi built differently on ppc64 and x86_64, which I think will be an
> error for real package builds. It looks like the noarch package virtually
> provides archful python-kiwi, which is plain wrong. It looks like the 
> %python_provide macro fails here ...
> 

I've discovered this is caused when %python_provide is used before "BuildArch:
noarch" is declared. the spec parser doesn't yet know the subpackage is not
archful, so it does the wrong thing here... If the "BuildArch: noarch" is
_before_ the %python_provide macro, it works as it should.

I've fixed it accordingly.

> There are three additional, minor things I would suggest to change:
> 
> 13) You could drop the leading "A" from the summary tag. It's just noise.
> 

Done.

> 14) Since the -cli subpackage provides %{name}, you could just drop the cli
> subpackage entirely and put everything from it into the "main" kiwi package.
> But that's up to you.
> 

I do this because I want the content of the cli package to be noarch, and
limitations in rpm prevent me from doing it with the source package name while
having some archful subpackages.

Most of KIWI is noarch, so I did that to have it work out that way.

> 15) Since the package builds binaries from .c files with a Makefile, you
> will have to add "BR: gcc" and maybe even "BR: make" eventually.
> 
> 

Right. Done.

> Once fedora-review finally finishes I can conclude the review, since most
> issues have been addressed AFAICT.

Awesome.

For "final" verification:

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728842-kiwi/kiwi.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728842-kiwi/kiwi-9.13.7-0.fc29.3.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25750129

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #17 from Fabio Valentini  ---
(In reply to Neal Gompa from comment #16)
> (In reply to Fabio Valentini from comment #15)
> > There is one obvious error:
> > 
> > 0) The python2-kiwi package isn't installable on rawhide.
> > 
> > This is caused by using python-NAME Requires in the python2 subpackage. You
> > must use the fully qualified python2-NAME requires, they're all available as
> > far as I can tell:
> > 
> > BR: python-devel -> python2-devel
> > 
> > and
> > 
> > python-docopt -> python2-docopt
> > python-future -> python2-future
> > python-PyYAML -> python2-pyyaml
> > python-requests -> python2-requests
> > python-setuptools -> python2-setuptools
> > python-six -> python2-six
> > python-pyxattr -> python2-pyxattr
> > 
> > (Please double-check. You could even switch to using
> > "python2dist(docopt)"-style dependencies, if you want to be fancy.)
> > 
> > 
> 
> Fixed.

Well, not completely fixed, there are still "BR: python-devel" and "BR:
python-setuptools".

And where have the other dependencies gone? Are they now automatocally covered
by invoking the python dependency generator?

> > There are some other issues:
> > 
> > 1) Can you update the package to the latest version (9.13.9) for the final
> > review? A koji scratch build of the "final" package would be nice, too -
> > just to see if it builds correctly on all arches.
> > 
> 
> It's not yet uploaded to PyPI, so I've done it for 9.13.7 (the latest
> uploaded version).

That's fine.

> > 2) The kiwi-specific virtual provides look strange. Why not use a format
> > like kiwi(image:docker)? Additionally, they are unversioned, which rpmlint
> > complains about. And what is the "Provides: kiwi-schema" for?
> > 
> 
> This is used by obs-build for doing the correct substitution rules for
> certain things, so I can't really change them.

Ack.

> > 3) fedora-review complains about the %defattr(), and claims it's not needed.
> > Please double-check, since I suspect this is a false positive.
> > 
> 
> I've dropped it as tftp-server is packaged slightly differently in Fedora.

Good.

> > 4) Please don't write "%package -n %{name}-cli". Just use "%package cli"
> > (and %description cli, %files cli, etc.). Same goes for -tools and -pxeboot
> > subpackages. I suspect this is left-over from the previous
> > "python-kiwi"-named packaging.
> > 
> 
> Fixed.

Ack.

> > 5) The user and group creation scriptlet in "%pre -n kiwi-pxeboot (-> "%pre
> > pxeboot", btw) doesn't match the example scriptlet in the Packaging
> > Guidelines. Please check against [0]. Also, "Requires(pre): shadow-utils" is
> > missing from "%package pxeboot".
> > 
> 
> Dropped as it's not needed for our tftp-server packaging.

Nice :)

> > 6) The -pxeboot subpackage doesn't install a LICENSE file. Every other
> > combination pulls in a LICENSE file, as far as I can tell.
> > 
> 
> Fixed.

Ack.

> > 7) The file "kiwi/xml_parse.py" has "#!/usr/bin/env python" shebang, which
> > is wrong and must be replaced by "#!/usr/bin/python3" (sic!) and the file
> > marked as executable, or the shebang should be removed entirely (for both
> > the python2 and python3 version). That file isn't even compatible with
> > python2, so ... I guess that should be fixed upstream.
> > 
> 
> Issue filed: https://github.com/SUSE/kiwi/issues/666

I commented on the issue. It looks like you will have to fix this downstream.

> > 8) dracut modules (in "/usr/lib/drac7t/modules.d/99kiwi-lib/*" have bash
> > shebangs, but aren't marked as executable. Is that correct?
> > 
> 
> Issue filed: https://github.com/SUSE/kiwi/issues/668

Ack.

> > 9) The symlinks for "kiwi-ng" and "kiwicompat" don't look like they are
> > created proplerly. rpmlint complains that they are dangling symlinks.
> > 
> 
> This is because the versioned binaries exist in python3-kiwi and the
> unversioned ones are in kiwi-cli. kiwi-cli requires python3-kiwi, so they'll
> be satisfied on install.

OK, I trust that you have verified that this works as it is supposed to.

> > 10) "tools/kversion.c" has the wrong FSF address.
> > 
> 
> Issue filed: https://github.com/SUSE/kiwi/issues/667

Ack.

> > 11) There are unowned directories left:
> > 
> >  Note: Directories without known owners:
> >  /usr/share/bash-completion,
> >  /usr/lib/dracut,
> >  /usr/share/bash-completion/completions,
> >  /usr/lib/dracut/modules.d
> > 
> > Add the missing "Requires:" tags to the appropriate packages, or if that
> > doesn't work, co-own the directories.
> > 
> 
> Fixed.
> 
> > 12) The "/var/lib/tftpboot" directory and some files are already owned by
> > other packages (tftp-server and cobbler):
> > 
> >  Note: Dirs in package are owned also by:
> >  /var/lib/tftpboot(tftp-server),
> >  /var/lib/tftpboot/boot(cobbler),
> >  /var/lib/tftpboot/pxelinux.cfg(cobbler)
> > 
> 
> Fixed.
> 
> --
> 
> Spec URL:
> 

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #16 from Neal Gompa  ---
(In reply to Fabio Valentini from comment #15)
> There is one obvious error:
> 
> 0) The python2-kiwi package isn't installable on rawhide.
> 
> This is caused by using python-NAME Requires in the python2 subpackage. You
> must use the fully qualified python2-NAME requires, they're all available as
> far as I can tell:
> 
> BR: python-devel -> python2-devel
> 
> and
> 
> python-docopt -> python2-docopt
> python-future -> python2-future
> python-PyYAML -> python2-pyyaml
> python-requests -> python2-requests
> python-setuptools -> python2-setuptools
> python-six -> python2-six
> python-pyxattr -> python2-pyxattr
> 
> (Please double-check. You could even switch to using
> "python2dist(docopt)"-style dependencies, if you want to be fancy.)
> 
> 

Fixed.

> There are some other issues:
> 
> 1) Can you update the package to the latest version (9.13.9) for the final
> review? A koji scratch build of the "final" package would be nice, too -
> just to see if it builds correctly on all arches.
> 

It's not yet uploaded to PyPI, so I've done it for 9.13.7 (the latest uploaded
version).

> 2) The kiwi-specific virtual provides look strange. Why not use a format
> like kiwi(image:docker)? Additionally, they are unversioned, which rpmlint
> complains about. And what is the "Provides: kiwi-schema" for?
> 

This is used by obs-build for doing the correct substitution rules for certain
things, so I can't really change them.

> 3) fedora-review complains about the %defattr(), and claims it's not needed.
> Please double-check, since I suspect this is a false positive.
> 

I've dropped it as tftp-server is packaged slightly differently in Fedora.

> 4) Please don't write "%package -n %{name}-cli". Just use "%package cli"
> (and %description cli, %files cli, etc.). Same goes for -tools and -pxeboot
> subpackages. I suspect this is left-over from the previous
> "python-kiwi"-named packaging.
> 

Fixed.

> 5) The user and group creation scriptlet in "%pre -n kiwi-pxeboot (-> "%pre
> pxeboot", btw) doesn't match the example scriptlet in the Packaging
> Guidelines. Please check against [0]. Also, "Requires(pre): shadow-utils" is
> missing from "%package pxeboot".
> 

Dropped as it's not needed for our tftp-server packaging.

> 6) The -pxeboot subpackage doesn't install a LICENSE file. Every other
> combination pulls in a LICENSE file, as far as I can tell.
> 

Fixed.

> 7) The file "kiwi/xml_parse.py" has "#!/usr/bin/env python" shebang, which
> is wrong and must be replaced by "#!/usr/bin/python3" (sic!) and the file
> marked as executable, or the shebang should be removed entirely (for both
> the python2 and python3 version). That file isn't even compatible with
> python2, so ... I guess that should be fixed upstream.
> 

Issue filed: https://github.com/SUSE/kiwi/issues/666

> 8) dracut modules (in "/usr/lib/drac7t/modules.d/99kiwi-lib/*" have bash
> shebangs, but aren't marked as executable. Is that correct?
> 

Issue filed: https://github.com/SUSE/kiwi/issues/668

> 9) The symlinks for "kiwi-ng" and "kiwicompat" don't look like they are
> created proplerly. rpmlint complains that they are dangling symlinks.
> 

This is because the versioned binaries exist in python3-kiwi and the
unversioned ones are in kiwi-cli. kiwi-cli requires python3-kiwi, so they'll be
satisfied on install.

> 10) "tools/kversion.c" has the wrong FSF address.
> 

Issue filed: https://github.com/SUSE/kiwi/issues/667

> 11) There are unowned directories left:
> 
>  Note: Directories without known owners:
>  /usr/share/bash-completion,
>  /usr/lib/dracut,
>  /usr/share/bash-completion/completions,
>  /usr/lib/dracut/modules.d
> 
> Add the missing "Requires:" tags to the appropriate packages, or if that
> doesn't work, co-own the directories.
> 

Fixed.

> 12) The "/var/lib/tftpboot" directory and some files are already owned by
> other packages (tftp-server and cobbler):
> 
>  Note: Dirs in package are owned also by:
>  /var/lib/tftpboot(tftp-server),
>  /var/lib/tftpboot/boot(cobbler),
>  /var/lib/tftpboot/pxelinux.cfg(cobbler)
> 

Fixed.

--

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728607-kiwi/kiwi.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00728607-kiwi/kiwi-9.13.7-0.fc29.2.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25743697

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #15 from Fabio Valentini  ---
There is one obvious error:

0) The python2-kiwi package isn't installable on rawhide.

This is caused by using python-NAME Requires in the python2 subpackage. You
must use the fully qualified python2-NAME requires, they're all available as
far as I can tell:

BR: python-devel -> python2-devel

and

python-docopt -> python2-docopt
python-future -> python2-future
python-PyYAML -> python2-pyyaml
python-requests -> python2-requests
python-setuptools -> python2-setuptools
python-six -> python2-six
python-pyxattr -> python2-pyxattr

(Please double-check. You could even switch to using
"python2dist(docopt)"-style dependencies, if you want to be fancy.)


There are some other issues:

1) Can you update the package to the latest version (9.13.9) for the final
review? A koji scratch build of the "final" package would be nice, too - just
to see if it builds correctly on all arches.

2) The kiwi-specific virtual provides look strange. Why not use a format like
kiwi(image:docker)? Additionally, they are unversioned, which rpmlint complains
about. And what is the "Provides: kiwi-schema" for?

3) fedora-review complains about the %defattr(), and claims it's not needed.
Please double-check, since I suspect this is a false positive.

4) Please don't write "%package -n %{name}-cli". Just use "%package cli" (and
%description cli, %files cli, etc.). Same goes for -tools and -pxeboot
subpackages. I suspect this is left-over from the previous "python-kiwi"-named
packaging.

5) The user and group creation scriptlet in "%pre -n kiwi-pxeboot (-> "%pre
pxeboot", btw) doesn't match the example scriptlet in the Packaging Guidelines.
Please check against [0]. Also, "Requires(pre): shadow-utils" is missing from
"%package pxeboot".

6) The -pxeboot subpackage doesn't install a LICENSE file. Every other
combination pulls in a LICENSE file, as far as I can tell.

7) The file "kiwi/xml_parse.py" has "#!/usr/bin/env python" shebang, which is
wrong and must be replaced by "#!/usr/bin/python3" (sic!) and the file marked
as executable, or the shebang should be removed entirely (for both the python2
and python3 version). That file isn't even compatible with python2, so ... I
guess that should be fixed upstream.

8) dracut modules (in "/usr/lib/drac7t/modules.d/99kiwi-lib/*" have bash
shebangs, but aren't marked as executable. Is that correct?

9) The symlinks for "kiwi-ng" and "kiwicompat" don't look like they are created
proplerly. rpmlint complains that they are dangling symlinks.

10) "tools/kversion.c" has the wrong FSF address.

11) There are unowned directories left:

 Note: Directories without known owners:
 /usr/share/bash-completion,
 /usr/lib/dracut,
 /usr/share/bash-completion/completions,
 /usr/lib/dracut/modules.d

Add the missing "Requires:" tags to the appropriate packages, or if that
doesn't work, co-own the directories.

12) The "/var/lib/tftpboot" directory and some files are already owned by other
packages (tftp-server and cobbler):

 Note: Dirs in package are owned also by:
 /var/lib/tftpboot(tftp-server),
 /var/lib/tftpboot/boot(cobbler),
 /var/lib/tftpboot/pxelinux.cfg(cobbler)


[0]: https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #14 from Neal Gompa  ---
There's nothing else blocking this package. `python-kiwi` has been retired, and
`python-kiwi-gtk` is submitted as an update:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-83f7373a17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #13 from Fabio Valentini  ---
With the renamed source package, is there anything else blocking this package?
If not, I'll continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #12 from Neal Gompa  ---
(In reply to Fabio Valentini from comment #11)
> Is there a reason for renaming the source package (python-kiwi -> kiwi),
> other than the current name clash in fedora?

The way we handle source package management in git and koji makes it too
complicated to easily reuse the name without causing tons of confusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339



--- Comment #11 from Fabio Valentini  ---
Is there a reason for renaming the source package (python-kiwi -> kiwi), other
than the current name clash in fedora?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] Review Request: kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Neal Gompa  changed:

   What|Removed |Added

Summary|Review Request: python-kiwi |Review Request: kiwi - A
   |- A flexible operating  |flexible operating system
   |system image builder|image builder



--- Comment #10 from Neal Gompa  ---
I've renamed the source package and made a kiwi-cli subpackage instead. I've
also bumped to the latest version.

I'm still waiting on kiwi-gtk thing to get done, though...

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00720923-kiwi/kiwi.spec

SPRM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00720923-kiwi/kiwi-9.13.0-0.fc28.3.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org