needinfo canceled: [Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Blaine Story
's needinfo:
Bug 1535384: Review Request: tomb - a CLI tool to manage encrypted storage
https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #7 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #5 from Robert-André Mauchin  ---
Using:

* SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00793623-tomb/tomb.spec

* SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00793623-tomb/tomb-2.5-4.fc30.src.rpm


 - The man page must not be marked as %doc:

%{_mandir}/man1/tomb.1*

 - Might be cool to add subpackages for the extras:

# Extras

Tomb comes with a bunch of extra tools that contribute to enhance its
functionality or integrate it into particular system environments.

## extras/gtk-tray

The Gtk tray adds a nifty tomb skull into the desktop toolbar: one can
use it to close, slam and explore the open tomb represented by it.

When using pinentry-gtk-2 it also adds a little skull on the password
input, useful to not confuse it with other password inputs.

To have it change directory `extras/gtk-tray` then

 1. make sure libnotify and gtk+-2.0 dev packages are available
 2. run `make` inside the directory to build `tomb-gtk-tray`
 3. run `sudo make install` (default PREFIX is `/usr/local`)
 4. start `tomb-gtk-tray tombname` after the tomb is open

Of cource one can include the launch of tomb-gtk-tray scripts.

## extras/qt-tray

The QT tray adds a tomb tray in a QT desktop toolbar. It requires at
least QT libraries of version 5.4 or above.
Build with 'qmake' and then 'make'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #4 from Blaine Story  ---
I have included COPYING.txt to the %license macro and added a few files
(including the manpage) to %doc. 

There are several PDF files bundled with the upstream tarball which do deep
dives into encryption that I have opted to not include because it would
increase the RPM filesize from 57kb to several megabytes for items which are
only tangentially related to the package.

Updated SPEC and SRPM:

*
https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702627-tomb/tomb.spec

*
https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702627-tomb/tomb-2.5-4.fc28.src.rpm

Koji builds:

* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249594
* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249578
* https://koji.fedoraproject.org/koji/taskinfo?taskID=24249529

I'm still rather new to RPM packaging but will give what advice I can to
pending review requests.

Thank you for helping me get this far.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #3 from Iwicki Artur  ---
One thing I haven't noticed earlier is that you're not packaging the licence
text. You should include the licence (COPYING.txt) using the %license macro.
You can read more here:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

You may also consider including some files as documentation (%doc macro).
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

Another thing that's good to do is doing a scratch koji build ("koji build
--scratch") of your package and posting the result in this ticket. This way
whoever is reviewing the package can be sure it will build properly in the
Fedora build system.

Before you can get sponsored, you will also need to do some package reviews.
This does not mean doing "full" reviews, just posting some comments. You should
visit the review request queue once in a while, look for new requests, see if
you can spot any mistakes and report them (or report that everything seems
fine).

I do not have sponsor privileges, but I hope this few bits of advice will help
you on your way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #2 from Blaine Story  ---
Thank you for your fixes. I have implemented them in my COPR repo and it built
just fine.

Here are my updated SPEC and SRPM URLs:

https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702599-tomb/tomb.spec

https://copr-be.cloud.fedoraproject.org/results/blainester/tomb/fedora-rawhide-x86_64/00702599-tomb/tomb-2.5-3.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1535384] Review Request: tomb - a CLI tool to manage encrypted storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1535384

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Patch0: tomb.patch
Ideally, patches should have some description of what they it. It can either be
part of the patch name (like "tomb-do-not-use-usr-env.patch"), or a #comment in
the spec.

>%make_install PREFIX=/usr
Use "%{_prefix}" instead of "/usr".

As a style remark, %install is usually put before %files. It might also be good
to write a simple comment like "# Nothing to build" in the %build section. The
%description could also be a bit longer; the text on the Tomb website seems
friendly enough for this purpose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org