[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-04-24 05:00:19



--- Comment #11 from Petr Kubat  ---
The nss_nis package has been built for f28 so I guess this can be closed now.

https://koji.fedoraproject.org/koji/buildinfo?buildID=1024013

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nss_nis

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Petr Kubat  ---
There are some obsolete m4 macros (please file a bug against upstream for them)
but otherwise lgtm.

Also be aware that there is a F28 change for removing ldconfig scriptlets:
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

According to the change doc you can just remove the scriplets entirely if the
package is only for F28+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073



--- Comment #8 from Petr Kubat  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of 

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073



--- Comment #7 from Petr Kubat  ---
(In reply to Matej Mužila from comment #6)

> The packaged version is 3.0 already. As long as I know, there is no more
> recent version yet.

Now that I am looking at the contents of the source rpm you are right. I got
confused by the 2.0.0 version on the shared library file, but it is versioned
exactly the same way in upstream.

I guess this is a nitpick but it would be nice to have the library version
match the release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Matej Mužila  changed:

   What|Removed |Added

  Flags|needinfo?(mmuz...@redhat.co |
   |m)  |



--- Comment #6 from Matej Mužila  ---
(In reply to Petr Kubat from comment #5)
> Actually, Matej can you rebase the package against latest upstream release
> first? I see Thorsten just released version 3 a few days ago - this
> versioning will make more sense with the versioning we are going to use for
> the rpm package.

The packaged version is 3.0 already. As long as I know, there is no more recent
version yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

  Flags||needinfo?(mmuz...@redhat.co
   ||m)



--- Comment #5 from Petr Kubat  ---
Actually, Matej can you rebase the package against latest upstream release
first? I see Thorsten just released version 3 a few days ago - this versioning
will make more sense with the versioning we are going to use for the rpm
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073



--- Comment #4 from Petr Kubat  ---
>I think we absolutely should keep the name for the binary RPM.

After thinking about it a bit more I agree with keeping the name of the package
as nss_nis. Changing it to libnss_nis would have some positives but there are
also some other issues that would pop up.

Since the package only has a single binary rpm it does not make sense to me to
rename the srpm either. So lets keep it as it is.

Will continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073



--- Comment #3 from Florian Weimer  ---
(In reply to Matej Mužila from comment #2)
> this package replaces the nss_nis package, previously a subpackage of glibc.
> I think, it would be better to stay with the name "nss_nis". There are also
> other nss modues, that use this name scheme (nss_).
> 
> I've already discussed the package name with Florian, he thinks that
> "keeping nss_nis would be okay".

I think we absolutely should keep the name for the binary RPM.  I do not have a
strong opinion regarding the source RPM, but lean to nss_nis as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Matej Mužila  changed:

   What|Removed |Added

  Flags|needinfo?(mmuz...@redhat.co |
   |m)  |



--- Comment #2 from Matej Mužila  ---
Hi,

this package replaces the nss_nis package, previously a subpackage of glibc.
I think, it would be better to stay with the name "nss_nis". There are also
other nss modues, that use this name scheme (nss_).

I've already discussed the package name with Florian, he thinks that "keeping
nss_nis would be okay".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

 CC||mmuz...@redhat.com
  Flags||needinfo?(mmuz...@redhat.co
   ||m)



--- Comment #1 from Petr Kubat  ---
Please rename the package to the upstream name - libnss_nis.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Petr Kubat  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|pku...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540073] Review Request: nss_nis - Name Service Switch (NSS) module using NIS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540073

Florian Weimer  changed:

   What|Removed |Added

 Blocks||1537258




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1537258
[Bug 1537258] NIS switching to new libnsl to support IPv6
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org