Re: [win32-gui] RE: [perl-win32-gui-hackers] CVS Commit - More Win32::GUI::Constants changes

2006-05-19 Thread Jeremy White
The only thing that concerns me is that the distribution is growing in size 
quite rapidly, and once things are in it's difficult to take them out.   Is 
anyone concerned if the binary distribution doubles in size? How about if 
it trebles in size?


I guess the real question is how do we decide what's in the core and what's 
not.  Should we start separate distributions for some modules instead of 
having one large distribution?


Personally I wouldn't mind if the binary distribution increased by 10 times 
- even then it would still be small compared to some toolkits!:) As long as 
the runtime sizes are kept the same (i.e., we're not loading modules if they 
aren't being used) and the exe generators (PAR, perl2exe  perlapp) don't 
automatically include them - then there really isn't any issue other than 
bandwidth.


There are other advantages of bundling them together - there is some shared 
code which could be removed, with other code simplified. Going forward, all 
these modules need to brought together anyway so we can support the NEM, 
improved class logic (via UserData type methods), Unicode and no doubt other 
things too:)  We could always assume that the user will have these modules 
installed. Your win32-gui widget script for example, would show Perl code 
via Scintilla and link to the documentation (locally or on the web) via 
AxWindow (click on a method in the Scintilla window, and the documentation 
is shown).


Cheers,

jez.





Re: [win32-gui] RE: [perl-win32-gui-hackers] CVS Commit - More Win32::GUI::Constants changes

2006-05-17 Thread Robert May

Robert May wrote:

Robert May wrote:

Jeremy White wrote:


Bareword Win32::GUI::MB_OK not allowed while strict subs in use 
at C:/perl/site/lib/Client/WindowManager.pm line 120.
Bareword Win32::GUI::MB_ICONINFORMATION not allowed while strict 
subs in use at C:/perl/site/lib/Client/WindowManager.pm line 120.


In the WindowManager package I've got the following code:

 Win32::GUI::MessageBox($mainwindow,$text,Message, 
Win32::GUI::MB_OK | Win32::GUI::MB_ICONINFORMATION);


Hmm.  This is problematic with the current code.  You must be doing an
unadorned 'use Win32::GUI;' somewhere (and if running under warnings
you'll get a warning about this).  I've got a small patch to 
Constants.pm that fixes this issue - it'll be in CVS shortly.


It's in CVS, but I've broken non-qualified barewords.  Back to the 
drawing board.


Another attempt in CVS - I think that's nailed it, but there's a problem 
with the test that I have to get to the bottom of: they all pass when 
using 'prove' from the command line, but there's some failures under 
'make test'.


Rob.



Re: [win32-gui] RE: [perl-win32-gui-hackers] CVS Commit - More Win32::GUI::Constants changes

2006-05-17 Thread Robert May

Robert May wrote:
Another attempt in CVS - I think that's nailed it, but there's a problem 
with the test that I have to get to the bottom of: they all pass when 
using 'prove' from the command line, but there's some failures under 
'make test'.


Not sure what I messed up in my environment - but all tests are actually 
fine.


Jez, does the current CVS allow your scripts to run, albeit with lots of 
warnings?


Regards,
Rob.