Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Jing Li]

Hi Dave,
Since we're hoping to get this change working for GPDB we've currently using
this method to detect if it's gpdb and show the appropriate graphs. Right now it
displays errors on the dashboard if it's connected to a gpdb server.For this
patch specifically, the goal is to improve the experience for greenplum users so
they can get the same information as someone connected to a postgres server.
I do agree that this is a bigger discussion about how we handle behavior change
overall if it's regular postgres or something else. Let's talk about how we can
restructure this behavior in a wider context. Are you open to meeting about it?
Thanks,~Jing  






On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com  wrote:
Hi Violet.
I don't really like the way this has been implemented. It adds a variable which
is only used for gpdb.
There are other places in the code where the behaviour is changed if the server
is ppas or regular postgres.
Candidly I think all of this needs restructuring.
Dave Cramer  
On 15 August 2017 at 23:29, Violet Cheng   wrote:

Hi,
Any comment on this patch? If no, will it be committed soon?
Thanks,Violet
On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear   wrote:
Hi Hackers!

This patch enables Greenplum users to see the same charts on the dashboard as
postgres users. It also adds some additional information to the DDL that is
Greenplum specific and necessary to create a new table.
Thanks!
Sarah

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Dave Page]

Ashesh, do you have a recommended way to do this?

I haven't looked at the patch, but I assume it adds a database driver
module for GPDB?

On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:

> Hi Dave,
>
> Since we're hoping to get this change working for GPDB we've currently
> using this method to detect if it's gpdb and show the appropriate graphs.
> Right now it displays errors on the dashboard if it's connected to a gpdb
> server.
> For this patch specifically, the goal is to improve the experience for
> greenplum users so they can get the same information as someone connected
> to a postgres server.
>
> I do agree that this is a bigger discussion about how we handle behavior
> change overall if it's regular postgres or something else. Let's talk about
> how we can restructure this behavior in a wider context. Are you open to
> meeting about it?
>
> Thanks,
> ~Jing
>
>
>
> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>
>> Hi Violet.
>>
>> I don't really like the way this has been implemented. It adds a variable
>> which is only used for gpdb.
>>
>> There are other places in the code where the behaviour is changed if the
>> server is ppas or regular postgres.
>>
>> Candidly I think all of this needs restructuring.
>>
>> Dave Cramer
>>
>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>
>> Hi,
>>
>> Any comment on this patch? If no, will it be committed soon?
>>
>> Thanks,
>> Violet
>>
>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>> wrote:
>>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>>
>>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Ashesh Vashi]

On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:

> Ashesh, do you have a recommended way to do this?
>
> I haven't looked at the patch, but I assume it adds a database driver
> module for GPDB?
>
I have not looked at the patch yet.
I will take a look at it.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>
>> Hi Dave,
>>
>> Since we're hoping to get this change working for GPDB we've currently
>> using this method to detect if it's gpdb and show the appropriate graphs.
>> Right now it displays errors on the dashboard if it's connected to a gpdb
>> server.
>> For this patch specifically, the goal is to improve the experience for
>> greenplum users so they can get the same information as someone connected
>> to a postgres server.
>>
>> I do agree that this is a bigger discussion about how we handle behavior
>> change overall if it's regular postgres or something else. Let's talk about
>> how we can restructure this behavior in a wider context. Are you open to
>> meeting about it?
>>
>> Thanks,
>> ~Jing
>>
>>
>>
>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>>
>>> Hi Violet.
>>>
>>> I don't really like the way this has been implemented. It adds a
>>> variable which is only used for gpdb.
>>>
>>> There are other places in the code where the behaviour is changed if the
>>> server is ppas or regular postgres.
>>>
>>> Candidly I think all of this needs restructuring.
>>>
>>> Dave Cramer
>>>
>>> On 15 August 2017 at 23:29, Violet Cheng  wrote:
>>>
>>> Hi,
>>>
>>> Any comment on this patch? If no, will it be committed soon?
>>>
>>> Thanks,
>>> Violet
>>>
>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
>>> wrote:
>>>
>>> Hi Hackers!
>>>
>>> This patch enables Greenplum users to see the same charts on the
>>> dashboard as postgres users. It also adds some additional information to
>>> the DDL that is Greenplum specific and necessary to create a new table.
>>>
>>> Thanks!
>>> Sarah
>>>
>>>
>>>
>>>
>>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: PATCH: pgagent connection string parsing

[Dave Page]

On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi  wrote:

>
>
> On Aug 21, 2017 10:52, "Thomas Krennwallner" 
> wrote:
>
> On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote:
> >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1]
> tk+pg...@postsubmeta.net>
> >wrote:
> >
> >  % ./pgagent -f -t60 -l2  dbname=xxx user=tkren connection_timeout=5
> [...]
> >  Sun Aug 20 18:24:34 2017 : DEBUG: Creating DB connection:
> user=tkren connection_timeout=5 dbname=xxx
> >  Sun Aug 20 18:24:34 2017 : WARNING: Couldn't create the primary
> connection (attempt 1): invalid connection option "connection_timeout"
> >
> >This suggests pgAgent is not using the latest version of libpq.
> >Please use LD_LIBRARY_PATH environment to inform pgAgent to use the
> libpq,
> >it is compiled with.
> >-- Thanks,
> >Ashesh Vashi
> >-- Thanks, Ashesh
>
> Unfortunately, this does not work. On a current Debian sid system,
> I've compiled pgagent from source and get
>
>  % ldd ./pgagent
>  [...]
> libpq.so.5 => /usr/lib/x86_64-linux-gnu/libpq.so.5
> (0x7ff531382000)
>  [...]
>
>
> The system has libpq 9.6.4 installed:
>
>  % apt-cache show libpq5
>  Package: libpq5
>  Source: postgresql-9.6
>  Version: 9.6.4-1
>  [...]
>
> You may want set the rpath manually using chrpath utility for testing.
>
>
Regardless of that, connection.cpp does need to be taught the correct name
for connect_timeout, as well as the additional appname related parameters
right?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: PATCH: pgagent connection string parsing

[Ashesh Vashi]

On Mon, Aug 21, 2017 at 1:41 PM, Dave Page  wrote:

>
>
> On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Aug 21, 2017 10:52, "Thomas Krennwallner" 
>> wrote:
>>
>> On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote:
>> >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1]
>> tk+pg...@postsubmeta.net>
>> >wrote:
>> >
>> >  % ./pgagent -f -t60 -l2  dbname=xxx user=tkren connection_timeout=5
>> [...]
>> >  Sun Aug 20 18:24:34 2017 : DEBUG: Creating DB connection:
>> user=tkren connection_timeout=5 dbname=xxx
>> >  Sun Aug 20 18:24:34 2017 : WARNING: Couldn't create the primary
>> connection (attempt 1): invalid connection option "connection_timeout"
>> >
>> >This suggests pgAgent is not using the latest version of libpq.
>> >Please use LD_LIBRARY_PATH environment to inform pgAgent to use the
>> libpq,
>> >it is compiled with.
>> >-- Thanks,
>> >Ashesh Vashi
>> >-- Thanks, Ashesh
>>
>> Unfortunately, this does not work. On a current Debian sid system,
>> I've compiled pgagent from source and get
>>
>>  % ldd ./pgagent
>>  [...]
>> libpq.so.5 => /usr/lib/x86_64-linux-gnu/libpq.so.5
>> (0x7ff531382000)
>>  [...]
>>
>>
>> The system has libpq 9.6.4 installed:
>>
>>  % apt-cache show libpq5
>>  Package: libpq5
>>  Source: postgresql-9.6
>>  Version: 9.6.4-1
>>  [...]
>>
>> You may want set the rpath manually using chrpath utility for testing.
>>
>>
> Regardless of that, connection.cpp does need to be taught the correct name
> for connect_timeout, as well as the additional appname related parameters
> right?
>
True.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: PATCH: pgagent connection string parsing

[Dave Page]

On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi  wrote:

> On Mon, Aug 21, 2017 at 1:41 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Aug 21, 2017 10:52, "Thomas Krennwallner" 
>>> wrote:
>>>
>>> On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote:
>>> >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1]
>>> tk+pg...@postsubmeta.net>
>>> >wrote:
>>> >
>>> >  % ./pgagent -f -t60 -l2  dbname=xxx user=tkren
>>> connection_timeout=5
>>> [...]
>>> >  Sun Aug 20 18:24:34 2017 : DEBUG: Creating DB connection:
>>> user=tkren connection_timeout=5 dbname=xxx
>>> >  Sun Aug 20 18:24:34 2017 : WARNING: Couldn't create the primary
>>> connection (attempt 1): invalid connection option "connection_timeout"
>>> >
>>> >This suggests pgAgent is not using the latest version of libpq.
>>> >Please use LD_LIBRARY_PATH environment to inform pgAgent to use the
>>> libpq,
>>> >it is compiled with.
>>> >-- Thanks,
>>> >Ashesh Vashi
>>> >-- Thanks, Ashesh
>>>
>>> Unfortunately, this does not work. On a current Debian sid system,
>>> I've compiled pgagent from source and get
>>>
>>>  % ldd ./pgagent
>>>  [...]
>>> libpq.so.5 => /usr/lib/x86_64-linux-gnu/libpq.so.5
>>> (0x7ff531382000)
>>>  [...]
>>>
>>>
>>> The system has libpq 9.6.4 installed:
>>>
>>>  % apt-cache show libpq5
>>>  Package: libpq5
>>>  Source: postgresql-9.6
>>>  Version: 9.6.4-1
>>>  [...]
>>>
>>> You may want set the rpath manually using chrpath utility for testing.
>>>
>>>
>> Regardless of that, connection.cpp does need to be taught the correct
>> name for connect_timeout, as well as the additional appname related
>> parameters right?
>>
> True.
>

Thanks for volunteering :-)

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

[Teng Zhang]

Hi,

Thanks for the review, here is a fixed patch working for GBDP which shows
the appropriate graphs.
In this fix, we toke out the changes to diver/psycopg2 and implemented the
greenplum version checking process in the ppas way mentioned by Dave Cramer.

Regards,
Teng Zhang & Hao Wang

On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi  wrote:

> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:
>
>> Ashesh, do you have a recommended way to do this?
>>
>> I haven't looked at the patch, but I assume it adds a database driver
>> module for GPDB?
>>
> I have not looked at the patch yet.
> I will take a look at it.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>>
>>> Hi Dave,
>>>
>>> Since we're hoping to get this change working for GPDB we've currently
>>> using this method to detect if it's gpdb and show the appropriate graphs.
>>> Right now it displays errors on the dashboard if it's connected to a gpdb
>>> server.
>>> For this patch specifically, the goal is to improve the experience for
>>> greenplum users so they can get the same information as someone connected
>>> to a postgres server.
>>>
>>> I do agree that this is a bigger discussion about how we handle behavior
>>> change overall if it's regular postgres or something else. Let's talk about
>>> how we can restructure this behavior in a wider context. Are you open to
>>> meeting about it?
>>>
>>> Thanks,
>>> ~Jing
>>>
>>>
>>>
>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com wrote:
>>>
 Hi Violet.

 I don't really like the way this has been implemented. It adds a
 variable which is only used for gpdb.

 There are other places in the code where the behaviour is changed if
 the server is ppas or regular postgres.

 Candidly I think all of this needs restructuring.

 Dave Cramer

 On 15 August 2017 at 23:29, Violet Cheng  wrote:

 Hi,

 Any comment on this patch? If no, will it be committed soon?

 Thanks,
 Violet

 On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear 
 wrote:

 Hi Hackers!

 This patch enables Greenplum users to see the same charts on the
 dashboard as postgres users. It also adds some additional information to
 the DDL that is Greenplum specific and necessary to create a new table.

 Thanks!
 Sarah





>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/config.py b/web/config.py
index f4609e4e..90dd4ded 100644
--- a/web/config.py
+++ b/web/config.py
@@ -299,7 +299,8 @@ STORAGE_DIR = os.path.join(DATA_DIR, 'storage')
 ##
 DEFAULT_BINARY_PATHS = {
 "pg":   "",
-"ppas": ""
+"ppas": "",
+"gpdb": ""
 }
 
 ##
diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
new file mode 100644
index ..9bcfd598
--- /dev/null
+++ 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/gpdb_5.0_plus/create.sql
@@ -0,0 +1,168 @@
+{% import 'macros/schemas/security.macros' as SECLABEL %}
+{% import 'macros/schemas/privilege.macros' as PRIVILEGE %}
+{% import 'macros/variable.macros' as VARIABLE %}
+{% import 'column/macros/security.macros' as COLUMN_SECLABEL %}
+{% import 'column/macros/privilege.macros' as COLUMN_PRIVILEGE %}
+{% import 'table/sql/macros/constraints.macro' as CONSTRAINTS %}
+{% import 'type/macros/get_full_type_sql_format.macros' as GET_TYPE %}
+{#===#}
+{#== MAIN TABLE TEMPLATE STARTS HERE ==#}
+{#===#}
+{#
+ If user has not provided any details but only name then
+ add empty bracket with table name
+#}
+{% set empty_bracket = ""%}
+{% if data.coll_inherits|length == 0 and  data.columns|length == 0 and not 
data.typname and not data.like_relation and data.primary_key|length == 0 and 
data.unique_constraint|length == 0 and data.foreign_key|length == 0 and 
data.check_constraint|length == 0 and data.exclude_constraint|length == 0 %}
+{% set empty_bracket = "\n(\n)"%}
+{% endif %}
+CREATE {% if data.relpersistence %}UNLOGGED {% endif %}TABLE 
{{conn|qtIdent(data.schema, data.name)}}{{empty_bracket}}
+{% if data.typname %}
+OF {{ data.typname }}
+{% endif %}
+{% if data.like_relation or data.coll_inherits or data.columns|length > 0 or 
data.primar

Re: PATCH: pgagent connection string parsing

[Thomas Krennwallner]

On Mon Aug 21, 2017 09:47:47AM +0100, Dave Page wrote:
> On Mon, Aug 21, 2017 at 9:46 AM, Ashesh Vashi  wrote:
> > On Mon, Aug 21, 2017 at 1:41 PM, Dave Page  wrote:
> >> Regardless of that, connection.cpp does need to be taught the correct
> >> name for connect_timeout, as well as the additional appname related
> >> parameters right?
> >>
> > True.
> >
> 
> Thanks for volunteering :-)

The patch attached in my first email fixes both problems.

TK

[pgAdmin4][Patch]: RM_ 2654 - Unable to set start and end time while creating pgAgent Job

[Surinder Kumar]

Hi,

The bootstrap-datetimepicker
 library being used
was an older version which had this issue.
So updated the bootstrap-datetimepicker library to the latest
 one and this issue
is fixed in newer version.

Please find attached patch and review.

Thanks,
Surinder


RM_2654.patch
Description: Binary data

[pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue where it was throwing error for valid
connection string if user passed host value as ip address.
RM#2655

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git 
a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
 
b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
index 0c5a523..72515a4 100644
--- 
a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
+++ 
b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
@@ -241,7 +241,7 @@ define('pgadmin.node.pga_jobstep', [
 } else {
   this.errorModel.unset('jstdbname');
   var msg,
-r = /\s*\b(\w+)\s*=\s*('([^'\\]*(?:\\.[^'\\]*)*)'|\w*)/g;
+r = /\s*\b(\w+)\s*=\s*('([^'\\]*(?:\\.[^'\\]*)*)'|[\w|\.]*)/g;
   val = this.get('jstconnstr');
   if (
 _.isUndefined(val) || _.isNull(val) ||

[pgAdmin4][Patch]: Update codemirror to latest version

[Murtuza Zabuawala]

Hi,

PFA patch to update CodeMirror to latest version(5.28.0
) which will fixes below listed
issues,

*Fixes:*
RM#1697
RM#2168
RM#2447
RM#2562

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]

diff --git a/web/package.json b/web/package.json
index 8e7fee3..a8cc950 100644
--- a/web/package.json
+++ b/web/package.json
@@ -55,7 +55,7 @@
 "bootstrap-switch": "3.3.2",
 "bowser": "1.6.1",
 "browserify": "~14.1.0",
-"codemirror": "^5.27.2",
+"codemirror": "^5.28.0",
 "css-loader": "0.14.0",
 "cssnano": "^3.10.0",
 "dropzone": "^5.1.1",

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

[Ashesh Vashi]

On Wed, Aug 16, 2017 at 8:55 AM, Violet Cheng  wrote:

> Hi,
>
> Is there any update on these patches? Will it be committed soon?
>
Dave - would please take care of this?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> Thanks,
> Violet
>
> On Thu, Aug 10, 2017 at 2:31 PM, Wenlin Zhang  wrote:
>
>> Hi hackers,
>>
>>We have rebased all the three patches and they are ready to be applied.
>>
>> Thanks,
>>
>> Wenlin & Matt
>>
>> On Wed, Aug 9, 2017 at 11:20 AM, Sarah McAlear 
>> wrote:
>>
>>> Oh, great! Thanks Murtuza!
>>>
>>> On Tue, Aug 8, 2017 at 6:16 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Wenlin,

 Patch looks good to me.

 I'm also attaching minor patch to update document for new keyboard
 shortcuts.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Tue, Aug 8, 2017 at 1:41 PM, Wenlin Zhang  wrote:

> Hi Murtuza,
>
>  Thanks for your review.
>
>   We have fixed download bug, you can try it with the new patch
> 1.3_refactor_keyactions.diff, to see if it works.
>   And we also changed the typo in the patch
> 2.1_change_keyboard_shortcuts_for_commenting_and_fix_typo.diff, 
> ('client_plaform'
> -> 'client_platform').
>
> Thanks.
>
> Wenlin & Violet
>
> On Mon, Aug 7, 2017 at 2:30 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Sarah,
>>
>> - Download button is not working, getting error on console (attaching
>> screenshot).
>> - While testing the patch I also observed another minor issue, If we
>> click on Explain & Explain analyze buttons, previous messages from 
>> Message
>> tab are not getting clear but instead new messages are getting appended 
>> to
>> previous ones.
>>
>> And could you please correct a typo introduced by Me from file
>> ../templates/datagrid/index.html, 'client_plaform' ->
>> 'client_platform' in your next patch as you working on it :)
>>
>> Rest of the changes looks good to me.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Mon, Aug 7, 2017 at 8:09 AM, Sarah McAlear 
>> wrote:
>>
>>> Hi Murtuza,
>>>
>>>  We have rebased and send the new patch.
>>>
>>> Thanks,
>>>
>>> Wenlin and Sarah
>>>
>>> On Fri, Aug 4, 2017 at 8:54 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Sarah,

 Could you please rebase and send the patch again, I am not able to
 apply any of the patch.

 murtuza@laptop:~/Documents/projects/pgadmin4$ git apply
 ~/Downloads/1_refactor_keyactions.diff
 error: patch failed: web/pgadmin/tools/sqleditor/st
 atic/js/sqleditor.js:552
 error: web/pgadmin/tools/sqleditor/static/js/sqleditor.js: patch
 does not apply
 murtuza@laptop:~/Documents/projects/pgadmin4$ git apply
 ~/Downloads/2_change_keyboard_shortcuts_for_commenting.diff
 error: patch failed: web/pgadmin/static/js/sqledito
 r/keyboard_shortcuts.js:26
 error: web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js:
 patch does not apply
 error: patch failed: web/regression/javascript/sqle
 ditor/keyboard_shortcuts_spec.js:181
 error: web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js:
 patch does not apply


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Fri, Aug 4, 2017 at 5:37 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> Murtuza,
>
> On Thu, Aug 3, 2017 at 3:38 PM, Sarah McAlear  > wrote:
>
>> Hi Hackers!
>>
>> Attached is a patch that extracts the functions called by the
>> keyboard_shortcuts function extracted earlier from sqlEditor.
>> This includes
>>
>>- executeQuery
>>- explainAnalyze
>>- explain
>>- download
>>- commentBlockCode
>>- commentLineCode
>>- uncommentLineCode
>>
>>
>> There is still more work to be done, but this is it for now.
>>
>> The

pgAdmin 4 commit: Update datetime picker. Fixes #2654

[Dave Page]

Update datetime picker. Fixes #2654

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d7b54eb62259dc53ffa36b012ccbf62126ab1bb
Author: Surinder Kumar 

Modified Files
--
web/package.json  | 4 ++--
.../server_groups/servers/pgagent/schedules/static/js/pga_schedule.js | 2 +-
web/pgadmin/static/css/style.css  | 4 ++--
web/webpack.shim.js   | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)

Re: [pgAdmin4][Patch]: RM_ 2654 - Unable to set start and end time while creating pgAgent Job

[Dave Page]

Thanks, applied.

On Mon, Aug 21, 2017 at 11:38 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> The bootstrap-datetimepicker
>  library being used
> was an older version which had this issue.
> So updated the bootstrap-datetimepicker library to the latest
>  one and this issue
> is fixed in newer version.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix connection string validation for pgAgent jobs. Fi

[Dave Page]

Fix connection string validation for pgAgent jobs. Fixes #2655

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d757d8698d095d249d434da0f1d65f85a2f01d74
Author: Murtuza Zabuawala 

Modified Files
--
.../server_groups/servers/pgagent/steps/static/js/pga_jobstep.js| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

[Dave Page]

Thanks, applied.

On Mon, Aug 21, 2017 at 12:12 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where it was throwing error for valid
> connection string if user passed host value as ip address.
> RM#2655
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update CodeMirror version. Fixes #1697. Fixes #2168.

[Dave Page]

Update CodeMirror version. Fixes #1697. Fixes #2168. Fixes #2447. Fixes #2562.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=654326a0d12a923b8e9fa9c0290448b78b32816e
Author: Murtuza Zabuawala 

Modified Files
--
web/package.json |  2 +-
web/yarn.lock| 33 -
2 files changed, 25 insertions(+), 10 deletions(-)

Re: [pgAdmin4][Patch]: Update codemirror to latest version

[Dave Page]

Thanks, applied.

On Mon, Aug 21, 2017 at 12:52 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to update CodeMirror to latest version(5.28.0
> ) which will fixes below listed
> issues,
>
> *Fixes:*
> RM#1697
> RM#2168
> RM#2447
> RM#2562
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure role names are escaped in the membership contr

[Dave Page]

Ensure role names are escaped in the membership control. Fixes #2606

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e2ca260206baaf0f5e5de6d571c9bf7cb7d7e17
Author: Murtuza Zabuawala 

Modified Files
--
.../server_groups/servers/roles/static/js/role.js  |  4 +-
.../feature_tests/xss_checks_roles_control_test.py | 88 ++
web/regression/python_test_utils/test_utils.py | 50 
3 files changed, 140 insertions(+), 2 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python26 #409

[pgAdmin 4 Jenkins]

See 

pgAdmin 4 commit: Refactor keyboard shortcut functions in the query too

[Dave Page]

Refactor keyboard shortcut functions in the query tool. Fix some incorrect 
keycodes and update docs.

Initial work by Sarah & Violet @ Pivotal, with additional tweaks by Murtuza @ 
EDB.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b585063a26ba74d4ef48254b3ee41da2ba7cdcf9
Author: Sarah McAlear 

Modified Files
--
docs/en_US/keyboard_shortcuts.rst  |6 +-
.../static/js/sqleditor/keyboard_shortcuts.js  |   36 +-
.../static/js/sqleditor/query_tool_actions.js  |   99 +
web/pgadmin/tools/datagrid/__init__.py |2 +-
.../tools/datagrid/templates/datagrid/index.html   |   26 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 6671 ++--
.../sqleditor/keyboard_shortcuts_spec.js   |  273 +-
.../sqleditor/query_tool_actions_spec.js   |  398 ++
8 files changed, 4000 insertions(+), 3511 deletions(-)

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

[Dave Page]

Thanks, patches applied.

On Mon, Aug 21, 2017 at 1:14 PM, Ashesh Vashi  wrote:

>
>
> On Wed, Aug 16, 2017 at 8:55 AM, Violet Cheng  wrote:
>
>> Hi,
>>
>> Is there any update on these patches? Will it be committed soon?
>>
> Dave - would please take care of this?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> Thanks,
>> Violet
>>
>> On Thu, Aug 10, 2017 at 2:31 PM, Wenlin Zhang  wrote:
>>
>>> Hi hackers,
>>>
>>>We have rebased all the three patches and they are ready to be
>>> applied.
>>>
>>> Thanks,
>>>
>>> Wenlin & Matt
>>>
>>> On Wed, Aug 9, 2017 at 11:20 AM, Sarah McAlear 
>>> wrote:
>>>
 Oh, great! Thanks Murtuza!

 On Tue, Aug 8, 2017 at 6:16 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Wenlin,
>
> Patch looks good to me.
>
> I'm also attaching minor patch to update document for new keyboard
> shortcuts.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 1:41 PM, Wenlin Zhang 
> wrote:
>
>> Hi Murtuza,
>>
>>  Thanks for your review.
>>
>>   We have fixed download bug, you can try it with the new patch
>> 1.3_refactor_keyactions.diff, to see if it works.
>>   And we also changed the typo in the patch
>> 2.1_change_keyboard_shortcuts_for_commenting_and_fix_typo.diff, 
>> ('client_plaform'
>> -> 'client_platform').
>>
>> Thanks.
>>
>> Wenlin & Violet
>>
>> On Mon, Aug 7, 2017 at 2:30 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Sarah,
>>>
>>> - Download button is not working, getting error on console
>>> (attaching screenshot).
>>> - While testing the patch I also observed another minor issue, If we
>>> click on Explain & Explain analyze buttons, previous messages from 
>>> Message
>>> tab are not getting clear but instead new messages are getting appended 
>>> to
>>> previous ones.
>>>
>>> And could you please correct a typo introduced by Me from file
>>> ../templates/datagrid/index.html, 'client_plaform' ->
>>> 'client_platform' in your next patch as you working on it :)
>>>
>>> Rest of the changes looks good to me.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Mon, Aug 7, 2017 at 8:09 AM, Sarah McAlear 
>>> wrote:
>>>
 Hi Murtuza,

  We have rebased and send the new patch.

 Thanks,

 Wenlin and Sarah

 On Fri, Aug 4, 2017 at 8:54 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Sarah,
>
> Could you please rebase and send the patch again, I am not able to
> apply any of the patch.
>
> murtuza@laptop:~/Documents/projects/pgadmin4$ git apply
> ~/Downloads/1_refactor_keyactions.diff
> error: patch failed: web/pgadmin/tools/sqleditor/st
> atic/js/sqleditor.js:552
> error: web/pgadmin/tools/sqleditor/static/js/sqleditor.js: patch
> does not apply
> murtuza@laptop:~/Documents/projects/pgadmin4$ git apply
> ~/Downloads/2_change_keyboard_shortcuts_for_commenting.diff
> error: patch failed: web/pgadmin/static/js/sqledito
> r/keyboard_shortcuts.js:26
> error: web/pgadmin/static/js/sqleditor/keyboard_shortcuts.js:
> patch does not apply
> error: patch failed: web/regression/javascript/sqle
> ditor/keyboard_shortcuts_spec.js:181
> error: web/regression/javascript/sqle
> ditor/keyboard_shortcuts_spec.js: patch does not apply
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Fri, Aug 4, 2017 at 5:37 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Murtuza,
>>
>> On Thu, Aug 3, 2017 at 3:38 PM, Sarah McAlear <
>> smcal...@pivotal.io> wrote:
>>
>>> Hi Hackers!
>>>
>>> Attached is a patch that extracts the functions called by the
>>> keyboard_shortcuts function extracted earlier from sqlEditor.
>>> This includes
>>>
>>>- executeQuery

Build failed in Jenkins: pgadmin4-master-python33 #289

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Refactor keyboard shortcut functions in the query tool. Fix some

--
[...truncated 336.04 KB...]
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.2:

149 tests passed
0 tests failed
23 tests skipped:
PackageGetTestCase (Fetch Package Node URL)
EventTriggerDeleteTestCase (Fetch Event Trigger Node URL)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table)
ViewsGetTestCase (Get materialized view under schema node)
ResourceGroupsGetTestCase (Get resource groups)
PackageAddTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
SynonymAddTestCase (Default Node URL)
ViewsUpdateTestCase (Update materialized view under schema node)
ResourceGroupsAddTestCase (Add resource groups)
EventTriggerGetTestCase (Fetch Event Trigger Node URL)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PackageDeleteTestCase (Fetch Package Node URL)
ViewsAddTestCase (Add materialized view under schema node)
EventTriggerAddTestCase (Fetch Event Trigger Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
EventTriggerPutTestCase (Fetch Event Trigger Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
ViewsDeleteTestCase (Delete materialized view under schema node)
ResourceGroupsPutTestCase (Put resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

157 tests passed
0 tests failed
15 tests skipped:
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
PackageGetTestCase (Fetch Package Node URL)
PackageDeleteTestCase (Fetch Package Node URL)
TableUpdateTestCase (Attach partition to existing list 
partitioned table,
Detach partition from existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Create partitions of existing list 
partitioned table,
Detach partition from existing range 
partitioned table,
Create partitions of existing range 
partitioned table)
SynonymGetTestCase (Fetch synonym Node URL)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
PackageAddTestCase (Fetch Package Node URL)
SynonymPutTestCase (Fetch synonym Node URL)
PackagePutTestCase (Fetch Package Node URL)
SynonymAddTestCase (Default Node URL)
ResourceGroupsGetTestCase (Get resource groups)
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsAddTestCase (Add resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.4:

157 tests passed
0 tests failed
15 tests skipped:
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned tabl

Re: pgAdmin4 - Tree view icons for final reveiw

[Shirley Wang]

Hi Chethana,

I just thought of something with these icons. What happens with the ones
that appear in dialog headers? In the blue bar?

On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hello Team,
>
> I have applied labels for each icon for identification purpose.  So please
> consider this copy for your feedback.
>
> *Note*: The "icon_demo.png" is attached to show case the view on webpage.
>
> Regards,
> Chethana kumar
>
> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hello Team,
>>
>> Here are the revised and final icons for tree view control.
>> I have attached in .svg file format as well so that you can do zoom in
>> view at any level.
>>
>> Please share your feedback on the same.
>>
>>
>> Thanks and regards,
>>
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>> www.enterprisedb.com
>>
>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146 <+91%2086981%2057146>
> www.enterprisedb.com
>

Re: Selecting tables from Browser

[Shirley Wang]

Hi Rob
On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt 
wrote:

> Shirley,
>
> I have a few questions.
>
>1. Why 20. It is a dunbar number and seems smallish but is there
>another reason?
>
> The browser fits about 30 ish items right now on my smallish laptop
screen. The question we asked ourselves is 'what is the most content we can
show before the browser gets unwieldy?'

You have thoughts on this?


>
>1. Since this is referred to as an Object Manager I assume the same
>thing will eventually be available for databases, schema, partitions, etc.
>How do permissions work currently to limit m view of these objects? (or do
>they)
>
>
Good point about the name implying further reach than just tables. We're
going to change the dialog header to show 'Select tables for display', at
least until we decide we want to include databases, schema, partitions.

I'm not sure how permissions works to limit the view, our assumption is
that permissions does though.

Dave P do you have more insight on what permissions can limit?

>
>1. Do you think that this would look differently if you assumptions
>were based on a user who writes BI reports or some other non-DBA user?
>
> Potentially, as you mentioned off the email thread, a DBA would be
interested in a larger list of tables than someone who writes BI reports.

That said, since this is a problem we hear from DBAs, and they feel the
most pain around this, I think it's fine to focus on solving the problem
for them. Solving their pains will also address the pains of people who
write BI reports since they also feel the same issues at a lesser intensity

We will be testing with non-DBA users though too.


>
>

Re: Selecting tables from Browser

[Robert Eckhardt]

On Mon, Aug 21, 2017 at 7:17 PM, Shirley Wang  wrote:

> Hi Rob
> On Mon, Aug 21, 2017 at 1:53 PM Robert Eckhardt 
> wrote:
>
>> Shirley,
>>
>> I have a few questions.
>>
>>1. Why 20. It is a dunbar number and seems smallish but is there
>>another reason?
>>
>> The browser fits about 30 ish items right now on my smallish laptop
> screen. The question we asked ourselves is 'what is the most content we can
> show before the browser gets unwieldy?'
>
> You have thoughts on this?
>

No thought better than 20. I was thinking a few hand full or a large enough
number to cause performance issues.


>
>
>>
>>1. Since this is referred to as an Object Manager I assume the same
>>thing will eventually be available for databases, schema, partitions, etc.
>>How do permissions work currently to limit m view of these objects? (or do
>>they)
>>
>>
> Good point about the name implying further reach than just tables. We're
> going to change the dialog header to show 'Select tables for display', at
> least until we decide we want to include databases, schema, partitions.
>
> I'm not sure how permissions works to limit the view, our assumption is
> that permissions does though.
>
> Dave P do you have more insight on what permissions can limit?
>
>>
>>1. Do you think that this would look differently if you assumptions
>>were based on a user who writes BI reports or some other non-DBA user?
>>
>> Potentially, as you mentioned off the email thread, a DBA would be
> interested in a larger list of tables than someone who writes BI reports.
>
> That said, since this is a problem we hear from DBAs, and they feel the
> most pain around this, I think it's fine to focus on solving the problem
> for them. Solving their pains will also address the pains of people who
> write BI reports since they also feel the same issues at a lesser intensity
>
> We will be testing with non-DBA users though too.
>

I'm mostly curious about this because I only really know how I interacted
with a DB in both roles.

-- Rob


>
>
>>
>>

Re: pgAdmin4 - Tree view icons for final reveiw

[Chethana Kumar]

Yes Shirley, I have already thought through on it.
Basically, we need to have one more set of icons in white color mode so
that we can use it on dialog headers as well.
As the blue theme icons won't fit there.

Please share your thoughts.

Regards,
Chethana kumar

On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang  wrote:

> Hi Chethana,
>
> I just thought of something with these icons. What happens with the ones
> that appear in dialog headers? In the blue bar?
>
> On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hello Team,
>>
>> I have applied labels for each icon for identification purpose.  So
>> please consider this copy for your feedback.
>>
>> *Note*: The "icon_demo.png" is attached to show case the view on webpage.
>>
>> Regards,
>> Chethana kumar
>>
>> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
>> chethana.ku...@enterprisedb.com> wrote:
>>
>>> Hello Team,
>>>
>>> Here are the revised and final icons for tree view control.
>>> I have attached in .svg file format as well so that you can do zoom in
>>> view at any level.
>>>
>>> Please share your feedback on the same.
>>>
>>>
>>> Thanks and regards,
>>>
>>> Chethana Kumar
>>> Principal UI/UX Designer
>>> EnterpriseDB Corporation
>>>
>>>
>>> The Postgres Database Company
>>>
>>> P: +91 86981 57146 <+91%2086981%2057146>
>>> www.enterprisedb.com
>>>
>>
>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>> www.enterprisedb.com
>>
>


-- 
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146
www.enterprisedb.com

Re: pgAdmin4 - Tree view icons for final reveiw

[Murtuza Zabuawala]

Hi Chethana,

- The icons for Server node is missing, we will need given set of icons for
server.
1) Basic Server icon (Disconnect state)
2) PG (Connected state)
3) EPAS (Connected state)
4) GreenPlum (Connected state)
[Attaching current icons for PG & EPAS, I'm not sure about GreenPlum server
icon.]

- I'm not sure where we will use serverbad icon from 'tree_view_Icons.svg'
file as it looks like server-group icon and not individual server.

- Icon set for Schema & Catalog (both collection and individual) looks very
similar to each other with minor colour difference, we have to look very
carefully to identify them each.

- Why do we require two different set of icons for Tables & Columns, I mean
one for Schema and one for Catalog?

- Icons for Partition node is same for collection and individual.

- Icons for Event trigger node and Trigger node are very different from
each other despite both are triggers.

I know this is out of context but in my own opinion these icons have
resemblance with Flat design where as rest of our application is in 2d
design, for example buttons, dialogs etc.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Yes Shirley, I have already thought through on it.
> Basically, we need to have one more set of icons in white color mode so
> that we can use it on dialog headers as well.
> As the blue theme icons won't fit there.
>
> Please share your thoughts.
>
> Regards,
> Chethana kumar
>
> On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang  wrote:
>
>> Hi Chethana,
>>
>> I just thought of something with these icons. What happens with the ones
>> that appear in dialog headers? In the blue bar?
>>
>> On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
>> chethana.ku...@enterprisedb.com> wrote:
>>
>>> Hello Team,
>>>
>>> I have applied labels for each icon for identification purpose.  So
>>> please consider this copy for your feedback.
>>>
>>> *Note*: The "icon_demo.png" is attached to show case the view on
>>> webpage.
>>>
>>> Regards,
>>> Chethana kumar
>>>
>>> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Hello Team,

 Here are the revised and final icons for tree view control.
 I have attached in .svg file format as well so that you can do zoom in
 view at any level.

 Please share your feedback on the same.


 Thanks and regards,

 Chethana Kumar
 Principal UI/UX Designer
 EnterpriseDB Corporation


 The Postgres Database Company

 P: +91 86981 57146 <+91%2086981%2057146>
 www.enterprisedb.com

>>>
>>>
>>>
>>> --
>>> Chethana Kumar
>>> Principal UI/UX Designer
>>> EnterpriseDB Corporation
>>>
>>>
>>> The Postgres Database Company
>>>
>>> P: +91 86981 57146 <+91%2086981%2057146>
>>> www.enterprisedb.com
>>>
>>
>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>

Re: pgAdmin4 - Tree view icons for final reveiw

[Surinder Kumar]

Hi Chethana,

The icons dimensions seem to vary in attached SVG. I have attached
screenshot.
Ideally, the icon(s) must fit(take full width/height) in the dimensions
either it is 16x16 or 14x14. because we will not adjust the pixels for each
icon.

Can you please tell what are the dimensions for an icon we are going to use?

Thanks,
Surinder

On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Chethana,
>
> - The icons for Server node is missing, we will need given set of icons
> for server.
> 1) Basic Server icon (Disconnect state)
> 2) PG (Connected state)
> 3) EPAS (Connected state)
> 4) GreenPlum (Connected state)
> [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum
> server icon.]
>
> - I'm not sure where we will use serverbad icon from 'tree_view_Icons.svg'
> file as it looks like server-group icon and not individual server.
>
> - Icon set for Schema & Catalog (both collection and individual) looks
> very similar to each other with minor colour difference, we have to look
> very carefully to identify them each.
>
> - Why do we require two different set of icons for Tables & Columns, I
> mean one for Schema and one for Catalog?
>
> - Icons for Partition node is same for collection and individual.
>
> - Icons for Event trigger node and Trigger node are very different from
> each other despite both are triggers.
>
> I know this is out of context but in my own opinion these icons have
> resemblance with Flat design where as rest of our application is in 2d
> design, for example buttons, dialogs etc.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Yes Shirley, I have already thought through on it.
>> Basically, we need to have one more set of icons in white color mode so
>> that we can use it on dialog headers as well.
>> As the blue theme icons won't fit there.
>>
>> Please share your thoughts.
>>
>> Regards,
>> Chethana kumar
>>
>> On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang  wrote:
>>
>>> Hi Chethana,
>>>
>>> I just thought of something with these icons. What happens with the ones
>>> that appear in dialog headers? In the blue bar?
>>>
>>> On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Hello Team,

 I have applied labels for each icon for identification purpose.  So
 please consider this copy for your feedback.

 *Note*: The "icon_demo.png" is attached to show case the view on
 webpage.

 Regards,
 Chethana kumar

 On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
 chethana.ku...@enterprisedb.com> wrote:

> Hello Team,
>
> Here are the revised and final icons for tree view control.
> I have attached in .svg file format as well so that you can do zoom in
> view at any level.
>
> Please share your feedback on the same.
>
>
> Thanks and regards,
>
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146 <+91%2086981%2057146>
> www.enterprisedb.com
>



 --
 Chethana Kumar
 Principal UI/UX Designer
 EnterpriseDB Corporation


 The Postgres Database Company

 P: +91 86981 57146 <+91%2086981%2057146>
 www.enterprisedb.com

>>>
>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>
>