Re: [pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

[Murtuza Zabuawala]

Hi,

This will not work, this is generic issue and not specific to database name 
only, we need to do proper unescaping of special character for every object 
name.

( eg: create a schema with name as 'test\’ not go to table node and try to 
create table by selecting 'test\’ schema, it will fail also)


 

> On 06-Jun-2016, at 6:29 pm, Sanket Mehta  
> wrote:
> 
> Hi,
> 
> I have resolved the issue and patch is attached with this mail.
> Please review it and let me know in case any issues.
> 
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
> 
> On Mon, Jun 6, 2016 at 4:23 PM,  > wrote:
> Issue #1292 has been updated by Sanket Mehta.
> Assignee set to Sanket Mehta
> Bug #1292: ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does 
> not exist message throws if template database contain special charterers 
> 
> Author: Fahar Abbas
> Status: In Progress
> Priority: Normal
> Assignee: Sanket Mehta
> Category:
> Target version: 1.0 Beta 1
> Commit ID:
> ---
> commit 954163b4957c1dce89c0632d009b845cbe90faf4
> 
> Browser version:
> 
> Firefox 45.0.2
> 
> Python version:
> 
> 3.5.1+
> 
> Platforms:
> All
> 
> ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist 
> message throws if user try to create database with template database that 
> name contain special charterers.
> 
> Please note that this issue is not reproducible in other template databases 
> that name is simple one.
> 
> Please note that this is not reproduce in pgAdmin3.
> 
> Steps:
> 
> 1. Install pgAdmin4 on Ubuntu 16.04
> 2. Install PG-9.6-beta 1 installer
> 3. Expand database node
> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/.,
> 5. Database created successfully
> 6. Again create new database and give it's name abcd
> 7. Click on definition tab
> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/.,
> 9. Click on Save button
> 
> Files
> Screen Shot 2016-06-02 at 10.25.34 am.png 
> 
>  (1020 KB)
> Screen Shot 2016-06-02 at 10.26.01 am.png 
> 
>  (1.03 MB)
> You have received this notification because you have either subscribed to it, 
> or are involved in it.
> To change your notification preferences, please click here: 
> https://redmine.postgresql.org/my/account 
> 
> 
> -- 
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fixing the decryption issue during restoring the conn

[Ashesh Vashi]

Fixing the decryption issue during restoring the connection on restart.

As we convert the binary password to string during storing the
connection information, we also need to convert it back to byte-arrays
during restoring the connections.

Hence - decode the passowrd using 'utf-8' encoding during storing the
connection information, and encode it during restoring the connections.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=37e2e1d24beb9d5a4474dfaacfa209d2c060991f

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Paresh More]

Hello Dave,

Windows batch has problem with file search and replace when it comes to
white spaces. Now the search and replace code is change to python.

So the installer creation issue is resolve.

Attached is the updated patch.


On Mon, Jun 6, 2016 at 2:51 PM, Dave Page  wrote:

> Hi,
>
> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More 
> wrote:
>
>> Hello Dave.
>>
>> There was problem with the Make.bat file ^M characters which is been
>> removed.
>>
>> Issues are fixed along with some code and README tidied
>>
>
> I'm still seeing the same error:
>
> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> 1 file(s) copied.
> Error on line 113 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell :  +919922000564 |  www.enterprisedb.com


pgadmin4_window_6_June_16.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

[Surinder Kumar]

Hi,

Please find updated patch:
*Issue*: Code changes are not consistent with the present code in
functions/__init__.py, like don't rename variable func_def to
func_defintion until it is required.
Review comment given by Ashesh personally.

Please review.

On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch for:
> 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
> 2. RM#1294 - Comments are not visible in sql pane for trigger functions
> and functions
>
> Explanation:
> Previously we we using 'get_defintion.sql' template to generate SQL for
> SQL pane for functions, procedure & trigger functions node.
> but GRANT statements and COMMENTS changes were missing. In order to fix
> that, now we have used both 'create.sql' and 'get_definition.sql' templates
> to generate full SQL query
> for SQL pane.
>
> Please review.
>
> On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Please ignore this patch. I will send another patch.
>>
>> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch for RM#1293.
>>> Add support to display GRANT privilege query in SQL Pane.
>>>
>>> Please review.
>>>
>>> Thanks,
>>> Surinder Kumar
>>>
>>
>>
>


fix_for_RM#1293_and_RM#1294_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Destroy header controls properly [pgadmin4]

[Ashesh Vashi]

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Fri, Jun 3, 2016 at 4:00 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for tokes control in fts configuration and  variable control.
>
> Issue fixed : Destroy header controls properly.
>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Remove the header controls of subnode control properl

[Ashesh Vashi]

Remove the header controls of subnode control properly, when removing it
from the VariableControl, and the customized TokenControl in the
fts_configuration javascript module during clean up process.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f1e57c2a61a24dfde33fd020039624dba515212
Author: Harshal Dhumal 

Modified Files
--
.../templates/fts_configuration/js/fts_configuration.js | 6 +-
web/pgadmin/browser/server_groups/servers/static/js/variable.js | 5 +
2 files changed, 10 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers

[Sanket Mehta]

Hi,

I have resolved the issue and patch is attached with this mail.
Please review it and let me know in case any issues.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Jun 6, 2016 at 4:23 PM,  wrote:

> Issue #1292 has been updated by Sanket Mehta.
>
>- *Assignee* set to *Sanket Mehta*
>
> --
> Bug #1292: ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does
> not exist message throws if template database contain special charterers
> 
>
>- Author: Fahar Abbas
>- Status: In Progress
>- Priority: Normal
>- Assignee: Sanket Mehta
>- Category:
>- Target version: 1.0 Beta 1
>
> Commit ID:
> ---
> commit 954163b4957c1dce89c0632d009b845cbe90faf4
>
> Browser version:
> 
> Firefox 45.0.2
>
> Python version:
> 
> 3.5.1+
>
> Platforms:
> All
>
> ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist
> message throws if user try to create database with template database that
> name contain special charterers.
>
> Please note that this issue is not reproducible in other template
> databases that name is simple one.
>
> Please note that this is not reproduce in pgAdmin3.
>
> Steps:
>
> 1. Install pgAdmin4 on Ubuntu 16.04
> 2. Install PG-9.6-beta 1 installer
> 3. Expand database node
> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/.,
> 5. Database created successfully
> 6. Again create new database and give it's name abcd
> 7. Click on definition tab
> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/.,
> 9. Click on Save button
> Files Screen Shot 2016-06-02 at 10.25.34 am.png
> 
> (1020 KB)
> Screen Shot 2016-06-02 at 10.26.01 am.png
> 
> (1.03 MB)
> --
>
> You have received this notification because you have either subscribed to
> it, or are involved in it.
> To change your notification preferences, please click here:
> https://redmine.postgresql.org/my/account
>
diff --git a/web/pgadmin/browser/server_groups/servers/databases/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
index 5084d88..261e3d2 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/__init__.py
@@ -447,6 +447,24 @@ class DatabaseView(PGChildNodeView):
 )
 )
 try:
+# Fetch template name from oid is specified
+if 'template' in data:
+SQL = render_template(
+"/".join([self.template_path,'properties.sql']),
+did=data['template'], conn=self.conn
+)
+
+status, res = self.conn.execute_dict(SQL)
+if not status:
+return internal_server_error(errormsg=status)
+
+if len(res['rows']) == 0:
+return gone(
+_("Could not find the database on the server.")
+)
+
+data['template'] = res['rows'][0]['name']
+
 # The below SQL will execute CREATE DDL only
 SQL = render_template(
 "/".join([self.template_path, 'create.sql']),
@@ -709,6 +727,24 @@ class DatabaseView(PGChildNodeView):
 data[aclcol], allowedacl['acl']
 )
 
+# Fetch template name from oid is specified
+if 'template' in data:
+SQL = render_template(
+"/".join([self.template_path, 'properties.sql']),
+did=data['template'], conn=self.conn
+)
+
+status, res = self.conn.execute_dict(SQL)
+if not status:
+return internal_server_error(errormsg=status)
+
+if len(res['rows']) == 0:
+return gone(
+_("Could not find the database on the server.")
+)
+
+data['template'] = res['rows'][0]['name']
+
 SQL = render_template(
 "/".join([self.template_path, 'create.sql']),
 data=data, conn=self.conn
diff --git a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js
index 8441b0c..34b9ed7 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/templates/databases/js/databases.js
@@ -240,7 +240,7 @@ function($, _, S, pgAdmin, pgBrowser, Alertify) {
   id: 'template', label: '{{ _('Template') }}',
   editable: false, type: 'text', group: 

Re: [pgadmin-hackers] PATCH: Security label was not properly handled (pgAdmin4)

[Ashesh Vashi]

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Mon, Jun 6, 2016 at 12:35 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue in security label model validation where it was
> not properly throwing error on partial inputs.
>
> Additionally, I have updated tablespace required fields validation which
> not proper.
> (RM#1110)
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1110 - Proper validation for the security labe

[Ashesh Vashi]

Fixes #1110 - Proper validation for the security labels.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ed2530b1f5da91a24235d2e60280df4d0bbda0b
Author: Murtuza Zabuawala 

Modified Files
--
.../templates/tablespaces/js/tablespaces.js| 13 +--
.../servers/templates/servers/servers.js   | 27 +++---
2 files changed, 25 insertions(+), 15 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Dave Page]

Hi

Thanks - I've commit as-is (with some minor tweaks), however the
following issues are present:

1) I get an error: "Invalid Email id: dpage...@pgadmin.org". That is a
perfectly valid email address, but I guess we're not recognising the
+.

2) When I mouse-over the Users menu option, the cursor isn't changing
to a pointer.

3) The font in the Close button is still not quite the same as for the
other dialogues.

Please fix and submit patch(es).

Thanks.

On Mon, Jun 6, 2016 at 11:58 AM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA updated patch (V6) for user management functionality.
>
> Changes: As per Ashesh's suggestion I have disabled email update of existing
> user.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jun 6, 2016 at 2:16 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Fri, Jun 3, 2016 at 10:52 PM, Harshal Dhumal
>>  wrote:
>> > Hi,
>> >
>> >
>> > PFA attached patch (V5) for user management functionality.
>> >
>> > Note: If you've applied any of the previous patch of this functionality
>> > then
>> > set ConfigDB value to 10 in version table of and also delete role
>> > 'Standard'
>> > from role table before applying this patch.
>>
>> Done - also restarted my app server, and done a hard refresh of the
>> browser...
>>
>> And I get "(index):310 Uncaught TypeError: Cannot read property
>> 'show_users' of undefined" when I try to open the Users menu option.
>
>
> This was an issue. Ideally Users menu shouldn't be visible to non admin
> users. I have fixed in this patch.
>
>>
>>
>> >> - The Close button should be disabled if errors are present.
>> >
>> >
>> > I'm not convinced that to deny superuser from closing dialog for his
>> > mistakes (accidental mistakes).
>> >
>> > Consider a case when superuser clears email for any old user
>> > inadvertently
>> > (obviously this won't reflect on server). At this point there is no
>> > proper
>> > way that he can roll back or close the dialog without saving it if we
>> > disable close button. He has to either enter correct email for that user
>> > or
>> > refresh the browser.
>> >
>> > Another case while adding new user if he plans not to add user then he
>> > has
>> > to clear that partially filled user from grid before he can close the
>> > dialog.
>>
>> Well we either need that, or a message box asking the user if he wants
>> to discard his changes and offering OK/Cancel options.
>
>
> I have added confirmation before closing dialog if any unsaved changes are
> present.
>
>
>>
>>
>> >> - If I enter all the details for a new user and then hit Close, the
>> >> dialog
>> >> is closed and the new user is NOT added. I have to click something else
>> >> first so the row loses focus, and then click close.
>> >
>> >
>> > I was not able to reproduce this issue. I tried with both close buttons
>> > (top-right and bottom-right). Users were created in both the cases by
>> > adding
>> > all details and directly closing dialog without clicking anywhere on the
>> > dialog.
>>
>> Hmm, I'll re-test when I get an updated patch.
>
> Ok
>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: User management.

[Dave Page]

User management.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3ab4501d50f3938de998d7bafdf2872aa81d3a5
Author: Harshal Dhumal 

Modified Files
--
web/config.py  |   2 +-
web/pgadmin/browser/__init__.py|   1 +
web/pgadmin/browser/templates/browser/index.html   |   4 +
web/pgadmin/static/css/overrides.css   |  64 +-
web/pgadmin/tools/user_management/__init__.py  | 327 +++
.../user_management/js/user_management.js  | 651 +
web/setup.py   |  24 +-
7 files changed, 1068 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Dave Page]

PFA.

On Mon, Jun 6, 2016 at 10:46 AM, Paresh More 
wrote:

> Hello Dave,
>
> Can you please attached the file C:\Users\dpage\Documents\
> pgadmin4\pkg\win32\installer.iss
>
>
>
> On Mon, Jun 6, 2016 at 2:51 PM, Dave Page  wrote:
>
>> Hi,
>>
>> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More > > wrote:
>>
>>> Hello Dave.
>>>
>>> There was problem with the Make.bat file ^M characters which is been
>>> removed.
>>>
>>> Issues are fixed along with some code and README tidied
>>>
>>
>> I'm still seeing the same error:
>>
>> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
>> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
>> 1 file(s) copied.
>> Error on line 113 in
>> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
>> Semicolon (';') expected.
>> Compile aborted.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
>
> Thanks & Regards
>
> *Paresh More*
>
> [image: NEW-EDB-logo-4c]
>
> Pune, India.
> Cell :  +919922000564 |  www.enterprisedb.com
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


installer.iss
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Paresh More]

Hello Dave,

Can you please attached the file C:\Users\dpage\Documents\
pgadmin4\pkg\win32\installer.iss



On Mon, Jun 6, 2016 at 2:51 PM, Dave Page  wrote:

> Hi,
>
> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More 
> wrote:
>
>> Hello Dave.
>>
>> There was problem with the Make.bat file ^M characters which is been
>> removed.
>>
>> Issues are fixed along with some code and README tidied
>>
>
> I'm still seeing the same error:
>
> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
> 1 file(s) copied.
> Error on line 113 in
> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
> Semicolon (';') expected.
> Compile aborted.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 

Thanks & Regards

*Paresh More*

[image: NEW-EDB-logo-4c]

Pune, India.
Cell :  +919922000564 |  www.enterprisedb.com

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

[Dave Page]

Hi,

On Fri, Jun 3, 2016 at 9:30 PM, Paresh More 
wrote:

> Hello Dave.
>
> There was problem with the Make.bat file ^M characters which is been
> removed.
>
> Issues are fixed along with some code and README tidied
>

I'm still seeing the same error:

copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in"
"C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss"
1 file(s) copied.
Error on line 113 in
C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3:
Semicolon (';') expected.
Compile aborted.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Ashesh Vashi]

On Mon, Jun 6, 2016 at 2:44 PM, Dave Page  wrote:

> Hmm, virtualenv's a good point.
>
> I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there
> any good reason to support SxS there? Stability I suppose, but then we
> don't support back-branches long term anyway.
>
pgAdmin IV may need particular version of third party libraries.
We may not control over, what other application will require.

Hence - it can create dependency issue.

>
> Does anyone think we need to support side-by-side RPM/DEB installation of
> multiple major versions of pgAdmin? Devrim? Hamid?
>
I do not feel the requirement of it.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> The config file would be part of the web package.
>
> On Mon, Jun 6, 2016 at 10:09 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> I already asked them about the APIs, though I didn't ask them about what
>> is the best way to handle SxS installation. Will check with them.
>>
>> PIP package for pgadmin4 doesn't support SxS as it creates the directory
>> with the name 'pgadmin4' only. Googling about the SxS with PIP says that
>> people use virtualenv to achieve it.
>>
>> Regarding pgadmin4-v1.conf - will it be a part of pgadmin4-docs RPM?
>> Needed for Debian also?
>>
>> On Mon, Jun 6, 2016 at 1:53 PM, Dave Page  wrote:
>>
>>> I have no idea. I would ask one of the Python guru's sitting next to you
>>> (as well as whether the way we'd handle side-by-side packages is
>>> appropriate). Also, look at what the PIP package does (does that even work
>>> properly in a SxS scenario? I don't know if we thought to check that).
>>>
>>> BTW; on the RPMs - we also need to include a config snippet for Apache,
>>> e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
>>> section on configuring that.
>>>
>>>
>>>
>>> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Yeah, I got the point. To distinguish between v1 and v2, we can have
 blank __init__.py in the v1 and v2 directories. I tried it and could
 successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4"
 and "import pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename
 hyphen to underscore in the directories to achieve this.

 But, I spent enough time to find the API that can get me the location
 for "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
 idea?


 On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:

> My point is that the runtime uses the platform supplied Python
> interpreter, which presumably knows where to search for packages. Mind 
> you,
> I suppose the issue there is that it wouldn't be able to distinguish
> between v1 and v2 then...
>
> I don't have a major issue with your suggested code - I just want to
> make sure we need it.
>
>
> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Do you mean to say when a python app is launched, it imports some
>> modules automatically and in that sense it knows about where it's
>> site-packages are? May be, but how the pgAdmin4 runtime will know where 
>> the
>> Web App is installed?
>>
>> The changes that I have done to the runtime is to let it know the
>> path of the Web App which is present in
>> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
>> set the PythonPath like we did for appbundle because I thought it is not
>> needed and it will automatically load the modules from the site-packages,
>> but it is to set the ApplicationPath.
>>
>> I missed something? or misunderstood something?
>>
>> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:
>>
>>> Hi,
>>>
>>> Well, I have to wonder why we need the changes to the runtime? We're
>>> linking the runtime with the same build of Python that's already on the
>>> system - doesn't it know where it's site-packages are already? I could 
>>> see
>>> us needing this is we were using a distro-independent build of Python 
>>> and
>>> wanted to find the OS site-packages location, but we're not.
>>>
>>>
>>> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 how about changes in the pgadmin4 source code for conf.py and
 Server.cpp? Looks okay?

 On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
 sandeep.thak...@enterprisedb.com> wrote:

> Thanks Dave.
>
> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page 

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Sandeep Thakkar]

--Adding back Devrim :-)


On Mon, Jun 6, 2016 at 2:44 PM, Dave Page  wrote:

> Hmm, virtualenv's a good point.
>
> I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there
> any good reason to support SxS there? Stability I suppose, but then we
> don't support back-branches long term anyway.
>
> Does anyone think we need to support side-by-side RPM/DEB installation of
> multiple major versions of pgAdmin? Devrim? Hamid?
>
> The config file would be part of the web package.
>
> On Mon, Jun 6, 2016 at 10:09 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> I already asked them about the APIs, though I didn't ask them about what
>> is the best way to handle SxS installation. Will check with them.
>>
>> PIP package for pgadmin4 doesn't support SxS as it creates the directory
>> with the name 'pgadmin4' only. Googling about the SxS with PIP says that
>> people use virtualenv to achieve it.
>>
>> Regarding pgadmin4-v1.conf - will it be a part of pgadmin4-docs RPM?
>> Needed for Debian also?
>>
>> On Mon, Jun 6, 2016 at 1:53 PM, Dave Page  wrote:
>>
>>> I have no idea. I would ask one of the Python guru's sitting next to you
>>> (as well as whether the way we'd handle side-by-side packages is
>>> appropriate). Also, look at what the PIP package does (does that even work
>>> properly in a SxS scenario? I don't know if we thought to check that).
>>>
>>> BTW; on the RPMs - we also need to include a config snippet for Apache,
>>> e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
>>> section on configuring that.
>>>
>>>
>>>
>>> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Yeah, I got the point. To distinguish between v1 and v2, we can have
 blank __init__.py in the v1 and v2 directories. I tried it and could
 successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4"
 and "import pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename
 hyphen to underscore in the directories to achieve this.

 But, I spent enough time to find the API that can get me the location
 for "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
 idea?


 On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:

> My point is that the runtime uses the platform supplied Python
> interpreter, which presumably knows where to search for packages. Mind 
> you,
> I suppose the issue there is that it wouldn't be able to distinguish
> between v1 and v2 then...
>
> I don't have a major issue with your suggested code - I just want to
> make sure we need it.
>
>
> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Do you mean to say when a python app is launched, it imports some
>> modules automatically and in that sense it knows about where it's
>> site-packages are? May be, but how the pgAdmin4 runtime will know where 
>> the
>> Web App is installed?
>>
>> The changes that I have done to the runtime is to let it know the
>> path of the Web App which is present in
>> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
>> set the PythonPath like we did for appbundle because I thought it is not
>> needed and it will automatically load the modules from the site-packages,
>> but it is to set the ApplicationPath.
>>
>> I missed something? or misunderstood something?
>>
>> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:
>>
>>> Hi,
>>>
>>> Well, I have to wonder why we need the changes to the runtime? We're
>>> linking the runtime with the same build of Python that's already on the
>>> system - doesn't it know where it's site-packages are already? I could 
>>> see
>>> us needing this is we were using a distro-independent build of Python 
>>> and
>>> wanted to find the OS site-packages location, but we're not.
>>>
>>>
>>> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 how about changes in the pgadmin4 source code for conf.py and
 Server.cpp? Looks okay?

 On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
 sandeep.thak...@enterprisedb.com> wrote:

> Thanks Dave.
>
> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page 
> wrote:
>
>> Hi
>>
>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
>>  wrote:
>> > Hi Devrim, Hi Dave,
>> >
>> > I have updated the patch. The earlier patch may fail because of
>> app bundle
>> > commit in git.
>> >
>> > For testing, you 

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Dave Page]

Hmm, virtualenv's a good point.

I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there
any good reason to support SxS there? Stability I suppose, but then we
don't support back-branches long term anyway.

Does anyone think we need to support side-by-side RPM/DEB installation of
multiple major versions of pgAdmin? Devrim? Hamid?

The config file would be part of the web package.

On Mon, Jun 6, 2016 at 10:09 AM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:

> I already asked them about the APIs, though I didn't ask them about what
> is the best way to handle SxS installation. Will check with them.
>
> PIP package for pgadmin4 doesn't support SxS as it creates the directory
> with the name 'pgadmin4' only. Googling about the SxS with PIP says that
> people use virtualenv to achieve it.
>
> Regarding pgadmin4-v1.conf - will it be a part of pgadmin4-docs RPM?
> Needed for Debian also?
>
> On Mon, Jun 6, 2016 at 1:53 PM, Dave Page  wrote:
>
>> I have no idea. I would ask one of the Python guru's sitting next to you
>> (as well as whether the way we'd handle side-by-side packages is
>> appropriate). Also, look at what the PIP package does (does that even work
>> properly in a SxS scenario? I don't know if we thought to check that).
>>
>> BTW; on the RPMs - we also need to include a config snippet for Apache,
>> e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
>> section on configuring that.
>>
>>
>>
>> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
>> sandeep.thak...@enterprisedb.com> wrote:
>>
>>> Yeah, I got the point. To distinguish between v1 and v2, we can have
>>> blank __init__.py in the v1 and v2 directories. I tried it and could
>>> successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4"
>>> and "import pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename
>>> hyphen to underscore in the directories to achieve this.
>>>
>>> But, I spent enough time to find the API that can get me the location
>>> for "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
>>> idea?
>>>
>>>
>>> On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:
>>>
 My point is that the runtime uses the platform supplied Python
 interpreter, which presumably knows where to search for packages. Mind you,
 I suppose the issue there is that it wouldn't be able to distinguish
 between v1 and v2 then...

 I don't have a major issue with your suggested code - I just want to
 make sure we need it.


 On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
 sandeep.thak...@enterprisedb.com> wrote:

> Do you mean to say when a python app is launched, it imports some
> modules automatically and in that sense it knows about where it's
> site-packages are? May be, but how the pgAdmin4 runtime will know where 
> the
> Web App is installed?
>
> The changes that I have done to the runtime is to let it know the path
> of the Web App which is present in
> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
> set the PythonPath like we did for appbundle because I thought it is not
> needed and it will automatically load the modules from the site-packages,
> but it is to set the ApplicationPath.
>
> I missed something? or misunderstood something?
>
> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:
>
>> Hi,
>>
>> Well, I have to wonder why we need the changes to the runtime? We're
>> linking the runtime with the same build of Python that's already on the
>> system - doesn't it know where it's site-packages are already? I could 
>> see
>> us needing this is we were using a distro-independent build of Python and
>> wanted to find the OS site-packages location, but we're not.
>>
>>
>> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
>> sandeep.thak...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> how about changes in the pgadmin4 source code for conf.py and
>>> Server.cpp? Looks okay?
>>>
>>> On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Thanks Dave.

 On Fri, Jun 3, 2016 at 2:08 PM, Dave Page 
 wrote:

> Hi
>
> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
>  wrote:
> > Hi Devrim, Hi Dave,
> >
> > I have updated the patch. The earlier patch may fail because of
> app bundle
> > commit in git.
> >
> > For testing, you may define the source tarball location as :
> > Source0:
> >
> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
> >
> > Known issue that I'm still working on:
> > 

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Sandeep Thakkar]

I already asked them about the APIs, though I didn't ask them about what is
the best way to handle SxS installation. Will check with them.

PIP package for pgadmin4 doesn't support SxS as it creates the directory
with the name 'pgadmin4' only. Googling about the SxS with PIP says that
people use virtualenv to achieve it.

Regarding pgadmin4-v1.conf - will it be a part of pgadmin4-docs RPM? Needed
for Debian also?

On Mon, Jun 6, 2016 at 1:53 PM, Dave Page  wrote:

> I have no idea. I would ask one of the Python guru's sitting next to you
> (as well as whether the way we'd handle side-by-side packages is
> appropriate). Also, look at what the PIP package does (does that even work
> properly in a SxS scenario? I don't know if we thought to check that).
>
> BTW; on the RPMs - we also need to include a config snippet for Apache,
> e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
> section on configuring that.
>
>
>
> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Yeah, I got the point. To distinguish between v1 and v2, we can have
>> blank __init__.py in the v1 and v2 directories. I tried it and could
>> successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4"
>> and "import pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename
>> hyphen to underscore in the directories to achieve this.
>>
>> But, I spent enough time to find the API that can get me the location for
>> "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
>> idea?
>>
>>
>> On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:
>>
>>> My point is that the runtime uses the platform supplied Python
>>> interpreter, which presumably knows where to search for packages. Mind you,
>>> I suppose the issue there is that it wouldn't be able to distinguish
>>> between v1 and v2 then...
>>>
>>> I don't have a major issue with your suggested code - I just want to
>>> make sure we need it.
>>>
>>>
>>> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Do you mean to say when a python app is launched, it imports some
 modules automatically and in that sense it knows about where it's
 site-packages are? May be, but how the pgAdmin4 runtime will know where the
 Web App is installed?

 The changes that I have done to the runtime is to let it know the path
 of the Web App which is present in
 "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
 set the PythonPath like we did for appbundle because I thought it is not
 needed and it will automatically load the modules from the site-packages,
 but it is to set the ApplicationPath.

 I missed something? or misunderstood something?

 On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:

> Hi,
>
> Well, I have to wonder why we need the changes to the runtime? We're
> linking the runtime with the same build of Python that's already on the
> system - doesn't it know where it's site-packages are already? I could see
> us needing this is we were using a distro-independent build of Python and
> wanted to find the OS site-packages location, but we're not.
>
>
> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> how about changes in the pgadmin4 source code for conf.py and
>> Server.cpp? Looks okay?
>>
>> On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
>> sandeep.thak...@enterprisedb.com> wrote:
>>
>>> Thanks Dave.
>>>
>>> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page  wrote:
>>>
 Hi

 On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
  wrote:
 > Hi Devrim, Hi Dave,
 >
 > I have updated the patch. The earlier patch may fail because of
 app bundle
 > commit in git.
 >
 > For testing, you may define the source tarball location as :
 > Source0:
 >
 http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
 >
 > Known issue that I'm still working on:
 > 1. web rpm has a dependency on doc. But, even if I install doc,
 the web
 > still complains. Here is the scenario:
 > [root@localhost tmp]# rpm -ivh
 > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
 > error: Failed dependencies:
 > pgadmin4-doc = 1.0_dev is needed by
 pgadmin4-web-1.0_dev-1.rhel7.noarch
 > ... ( trimmed the python dependencies list here...)
 >
 > [root@localhost tmp]# rpm -ivh
 > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
 > Preparing...
 #
 > [100%]

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

[Dave Page]

Hi

On Fri, Jun 3, 2016 at 10:52 PM, Harshal Dhumal
 wrote:
> Hi,
>
>
> PFA attached patch (V5) for user management functionality.
>
> Note: If you've applied any of the previous patch of this functionality then
> set ConfigDB value to 10 in version table of and also delete role 'Standard'
> from role table before applying this patch.

Done - also restarted my app server, and done a hard refresh of the browser...

And I get "(index):310 Uncaught TypeError: Cannot read property
'show_users' of undefined" when I try to open the Users menu option.

>> - The Close button should be disabled if errors are present.
>
>
> I'm not convinced that to deny superuser from closing dialog for his
> mistakes (accidental mistakes).
>
> Consider a case when superuser clears email for any old user inadvertently
> (obviously this won't reflect on server). At this point there is no proper
> way that he can roll back or close the dialog without saving it if we
> disable close button. He has to either enter correct email for that user or
> refresh the browser.
>
> Another case while adding new user if he plans not to add user then he has
> to clear that partially filled user from grid before he can close the
> dialog.

Well we either need that, or a message box asking the user if he wants
to discard his changes and offering OK/Cancel options.

>> - If I enter all the details for a new user and then hit Close, the dialog
>> is closed and the new user is NOT added. I have to click something else
>> first so the row loses focus, and then click close.
>
>
> I was not able to reproduce this issue. I tried with both close buttons
> (top-right and bottom-right). Users were created in both the cases by adding
> all details and directly closing dialog without clicking anywhere on the
> dialog.

Hmm, I'll re-test when I get an updated patch.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1277 - Few cosmetic issues with preference dialog

[Surinder Kumar]

Hi,

Please find the patch for issues fixed:
1. Foreign keys listed twice
The label for Exclusion constraint was set to 'Foreign keys'. fixed it.
2. Trigger function, Unique constraint, Primary key should be in title case
3. if user click outside of Preferences window it disappear (it should not
disappear)
set preference alertify dialog option *closableByDimmer to false.*
4. Columns node settings listed twice
Override the *register_preferences* method in Columns
*CatalogObjectColumnsModule* class
because there are two types of columns node, catalogs columns and tables
columns.
so the settings for table columns should also work for catalog columns.
Thats why we are not showing preference option for catalogs column node.
*Ashesh* fixed this issue.


Please review.

Thanks,
Surinder Kumar


RM#1277.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

[Priyanka Shendge]

On 6 June 2016 at 14:03, Dave Page  wrote:

> Hi
>
> On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge
>  wrote:
> > Hi,
> >
> > PFA patch for API test cases for tree nodes/modules. This patch does not
> > include
> > api tests for following modules:
> >
> > 1. Type
> > 2. Table child nodes
> > 3. FTS modules
> >
> > Kindly, review the same and let me know for any modification.
>
> I took a very quick look at the patch and immediately saw a serious
> problem I'm afraid - you cannot hard-code paths like this:
>
> +if
> os.path.isfile('/home/edb/Downloads/pgadmin4/web/regression/'
> +  'parent_id.pkl'):
> +exst_server_id = open('/home/edb/Downloads/pgadmin4/web'
> +  '/regression/''parent_id.pkl', 'rb')
>
> You need to dynamically generate such paths so this will work on any
> machine. Look at line 19 of web/pgAdmin4.py to see how to get the
> patch to the current file as an example.
>
Sure, i'll check and update accordingly.

>
> Also; despite this not being part of the end-user interface, please
> try to follow the standards for messages, e.g. instead of:
>
> No event trigger(s) to update!!!
>
> use
>
> No event trigger(s) to update.
>
Noted. I will update for all applicable files.

>
> There is likely more to change of course, but please fix these issues
> first.
>
Sure.

Thank you.

>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Best,
Priyanka

EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

[Dave Page]

Hi

On Sun, Jun 5, 2016 at 6:56 PM, Priyanka Shendge
 wrote:
> Hi,
>
> PFA patch for API test cases for tree nodes/modules. This patch does not
> include
> api tests for following modules:
>
> 1. Type
> 2. Table child nodes
> 3. FTS modules
>
> Kindly, review the same and let me know for any modification.

I took a very quick look at the patch and immediately saw a serious
problem I'm afraid - you cannot hard-code paths like this:

+if os.path.isfile('/home/edb/Downloads/pgadmin4/web/regression/'
+  'parent_id.pkl'):
+exst_server_id = open('/home/edb/Downloads/pgadmin4/web'
+  '/regression/''parent_id.pkl', 'rb')

You need to dynamically generate such paths so this will work on any
machine. Look at line 19 of web/pgAdmin4.py to see how to get the
patch to the current file as an example.

Also; despite this not being part of the end-user interface, please
try to follow the standards for messages, e.g. instead of:

No event trigger(s) to update!!!

use

No event trigger(s) to update.

There is likely more to change of course, but please fix these issues first.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Dave Page]

I have no idea. I would ask one of the Python guru's sitting next to you
(as well as whether the way we'd handle side-by-side packages is
appropriate). Also, look at what the PIP package does (does that even work
properly in a SxS scenario? I don't know if we thought to check that).

BTW; on the RPMs - we also need to include a config snippet for Apache,
e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a
section on configuring that.



On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar <
sandeep.thak...@enterprisedb.com> wrote:

> Yeah, I got the point. To distinguish between v1 and v2, we can have blank
> __init__.py in the v1 and v2 directories. I tried it and could successfully
> import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4" and "import
> pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename hyphen to
> underscore in the directories to achieve this.
>
> But, I spent enough time to find the API that can get me the location for
> "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
> idea?
>
>
> On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:
>
>> My point is that the runtime uses the platform supplied Python
>> interpreter, which presumably knows where to search for packages. Mind you,
>> I suppose the issue there is that it wouldn't be able to distinguish
>> between v1 and v2 then...
>>
>> I don't have a major issue with your suggested code - I just want to make
>> sure we need it.
>>
>>
>> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
>> sandeep.thak...@enterprisedb.com> wrote:
>>
>>> Do you mean to say when a python app is launched, it imports some
>>> modules automatically and in that sense it knows about where it's
>>> site-packages are? May be, but how the pgAdmin4 runtime will know where the
>>> Web App is installed?
>>>
>>> The changes that I have done to the runtime is to let it know the path
>>> of the Web App which is present in
>>> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
>>> set the PythonPath like we did for appbundle because I thought it is not
>>> needed and it will automatically load the modules from the site-packages,
>>> but it is to set the ApplicationPath.
>>>
>>> I missed something? or misunderstood something?
>>>
>>> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:
>>>
 Hi,

 Well, I have to wonder why we need the changes to the runtime? We're
 linking the runtime with the same build of Python that's already on the
 system - doesn't it know where it's site-packages are already? I could see
 us needing this is we were using a distro-independent build of Python and
 wanted to find the OS site-packages location, but we're not.


 On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
 sandeep.thak...@enterprisedb.com> wrote:

> Hi Dave,
>
> how about changes in the pgadmin4 source code for conf.py and
> Server.cpp? Looks okay?
>
> On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Thanks Dave.
>>
>> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
>>>  wrote:
>>> > Hi Devrim, Hi Dave,
>>> >
>>> > I have updated the patch. The earlier patch may fail because of
>>> app bundle
>>> > commit in git.
>>> >
>>> > For testing, you may define the source tarball location as :
>>> > Source0:
>>> >
>>> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
>>> >
>>> > Known issue that I'm still working on:
>>> > 1. web rpm has a dependency on doc. But, even if I install doc,
>>> the web
>>> > still complains. Here is the scenario:
>>> > [root@localhost tmp]# rpm -ivh
>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
>>> > error: Failed dependencies:
>>> > pgadmin4-doc = 1.0_dev is needed by
>>> pgadmin4-web-1.0_dev-1.rhel7.noarch
>>> > ... ( trimmed the python dependencies list here...)
>>> >
>>> > [root@localhost tmp]# rpm -ivh
>>> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
>>> > Preparing...
>>> #
>>> > [100%]
>>> > Updating / installing...
>>> >1:pgadmin4-docs-1.0_dev-1.rhel7
>>> #
>>> > [100%]
>>> >
>>> >
>>> > [root@localhost tmp]# yum list | grep pgadmin4-docs
>>> > pgadmin4-docs.noarch1.0_dev-1.rhel7
>>> > installed
>>> >
>>> >
>>> > [root@localhost tmp]# rpm -ivh
>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
>>> > error: Failed dependencies:
>>> > pgadmin4-doc = 1.0_dev is needed by
>>> pgadmin4-web-1.0_dev-1.rhel7.noarch
>>>
>>> You have a typo - the Requires 

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

[Sandeep Thakkar]

Yeah, I got the point. To distinguish between v1 and v2, we can have blank
__init__.py in the v1 and v2 directories. I tried it and could successfully
import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4" and "import
pgadmin4_web_v2.pgAdmin4".  Please note that I had to rename hyphen to
underscore in the directories to achieve this.

But, I spent enough time to find the API that can get me the location for
"pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an
idea?


On Fri, Jun 3, 2016 at 8:24 PM, Dave Page  wrote:

> My point is that the runtime uses the platform supplied Python
> interpreter, which presumably knows where to search for packages. Mind you,
> I suppose the issue there is that it wouldn't be able to distinguish
> between v1 and v2 then...
>
> I don't have a major issue with your suggested code - I just want to make
> sure we need it.
>
>
> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar <
> sandeep.thak...@enterprisedb.com> wrote:
>
>> Do you mean to say when a python app is launched, it imports some modules
>> automatically and in that sense it knows about where it's site-packages
>> are? May be, but how the pgAdmin4 runtime will know where the Web App is
>> installed?
>>
>> The changes that I have done to the runtime is to let it know the path of
>> the Web App which is present in
>> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to
>> set the PythonPath like we did for appbundle because I thought it is not
>> needed and it will automatically load the modules from the site-packages,
>> but it is to set the ApplicationPath.
>>
>> I missed something? or misunderstood something?
>>
>> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page  wrote:
>>
>>> Hi,
>>>
>>> Well, I have to wonder why we need the changes to the runtime? We're
>>> linking the runtime with the same build of Python that's already on the
>>> system - doesn't it know where it's site-packages are already? I could see
>>> us needing this is we were using a distro-independent build of Python and
>>> wanted to find the OS site-packages location, but we're not.
>>>
>>>
>>> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <
>>> sandeep.thak...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 how about changes in the pgadmin4 source code for conf.py and
 Server.cpp? Looks okay?

 On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <
 sandeep.thak...@enterprisedb.com> wrote:

> Thanks Dave.
>
> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
>>  wrote:
>> > Hi Devrim, Hi Dave,
>> >
>> > I have updated the patch. The earlier patch may fail because of app
>> bundle
>> > commit in git.
>> >
>> > For testing, you may define the source tarball location as :
>> > Source0:
>> >
>> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
>> >
>> > Known issue that I'm still working on:
>> > 1. web rpm has a dependency on doc. But, even if I install doc, the
>> web
>> > still complains. Here is the scenario:
>> > [root@localhost tmp]# rpm -ivh
>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
>> > error: Failed dependencies:
>> > pgadmin4-doc = 1.0_dev is needed by
>> pgadmin4-web-1.0_dev-1.rhel7.noarch
>> > ... ( trimmed the python dependencies list here...)
>> >
>> > [root@localhost tmp]# rpm -ivh
>> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
>> > Preparing...
>> #
>> > [100%]
>> > Updating / installing...
>> >1:pgadmin4-docs-1.0_dev-1.rhel7
>> #
>> > [100%]
>> >
>> >
>> > [root@localhost tmp]# yum list | grep pgadmin4-docs
>> > pgadmin4-docs.noarch1.0_dev-1.rhel7
>> > installed
>> >
>> >
>> > [root@localhost tmp]# rpm -ivh
>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
>> > error: Failed dependencies:
>> > pgadmin4-doc = 1.0_dev is needed by
>> pgadmin4-web-1.0_dev-1.rhel7.noarch
>>
>> You have a typo - the Requires line is for pgadmin4-doc, but the RPM
>> is pgadmin4-docs.
>>
>> Oh, right.
>
>
>> Other review comments:
>>
>> - We have multiple identical pgadmin4.spec.in's in the patch. We need
>> to get that down to a single file.
>>
>> - In fact, why do we need a directory for each distro at all? As far
>> as I can see, the only difference is the $DIST definition, which is
>> surely something we can get programmatically very easily. It seems to
>> me we could reduce this all to 3 files - Makefile, README and
>> pgadmin4.spec.in
>>
>> Agree. I copied the structure from somewhere thinking this is good to
> have more 

Re: [pgadmin-hackers] Pgadmin4: emoji in comments

[Dave Page]

Hi

On Fri, Jun 3, 2016 at 11:28 PM, eMerzh  wrote:
> Hi,
>
> i just pulled the latest git,
> and tried to display a table with an emoji in comments of the table
> and i got an exception...
>
> using python3.5
> 4398d1d8694024b3f357e74fba4683d5f3cd5745
>
> here is the traceback
>
> 2016-06-04 00:23:15,050: ERRORpgadmin:Exception on
> /browser/table/sql/1/1/25554/2200/34037 [GET]
> Traceback (most recent call last):
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1817, in wsgi_app
> response = self.full_dispatch_request()
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1477, in full_dispatch_request
> rv = self.handle_user_exception(e)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1381, in handle_user_exception
> reraise(exc_type, exc_value, tb)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/_compat.py",
> line 33, in reraise
> raise value
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1475, in full_dispatch_request
> rv = self.dispatch_request()
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1461, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
>   File "/tmp/pgadmin4/web/pgadmin/browser/utils.py", line 233, in
> dispatch_request
> return method(*args, **kwargs)
>   File
> "/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 328, in wrap
> return f(*args, **kwargs)
>   File
> "/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 2437, in sql
> data=data, conn=self.conn)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
> 128, in render_template
> context, ctx.app)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
> 110, in _render
> rv = template.render(context)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
> line 969, in render
> return self.environment.handle_exception(exc_info, True)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
> line 742, in handle_exception
> reraise(exc_type, exc_value, tb)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/_compat.py",
> line 36, in reraise
> raise value.with_traceback(tb)
>   File
> "/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/9.5_plus/create.sql",
> line 123, in 
> IS {{c.description|qtLiteral}};
>   File "/tmp/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line
> 1405, in qtLiteral
> res = adapt(value).getquoted()
> UnicodeEncodeError: 'latin-1' codec can't encode character '\U0001f4a9' in
> position 6: ordinal not in range(256)
> 2016-06-04 00:23:17,443: ERRORpgadmin:Exception on
> /browser/table/sql/1/1/25554/2200/34037 [GET]
> Traceback (most recent call last):
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1817, in wsgi_app
> response = self.full_dispatch_request()
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1477, in full_dispatch_request
> rv = self.handle_user_exception(e)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1381, in handle_user_exception
> reraise(exc_type, exc_value, tb)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/_compat.py",
> line 33, in reraise
> raise value
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1475, in full_dispatch_request
> rv = self.dispatch_request()
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
> 1461, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
>   File "/tmp/pgadmin4/web/pgadmin/browser/utils.py", line 233, in
> dispatch_request
> return method(*args, **kwargs)
>   File
> "/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 328, in wrap
> return f(*args, **kwargs)
>   File
> "/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 2437, in sql
> data=data, conn=self.conn)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
> 128, in render_template
> context, ctx.app)
>   File
> "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
> 110, in _render
> rv = template.render(context)
>   File
> 

[pgadmin-hackers] Pgadmin4: emoji in comments

[eMerzh]

Hi,

i just pulled the latest git,
and tried to display a table with an emoji in comments of the table
and i got an exception...

using python3.5
4398d1d8694024b3f357e74fba4683d5f3cd5745

here is the traceback

2016-06-04 00:23:15,050: ERRORpgadmin:Exception on
/browser/table/sql/1/1/25554/2200/34037 [GET]
Traceback (most recent call last):
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1817, in wsgi_app
response = self.full_dispatch_request()
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1477, in full_dispatch_request
rv = self.handle_user_exception(e)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/_compat.py",
line 33, in reraise
raise value
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1475, in full_dispatch_request
rv = self.dispatch_request()
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1461, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
  File "/tmp/pgadmin4/web/pgadmin/browser/utils.py", line 233, in
dispatch_request
return method(*args, **kwargs)
  File
"/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 328, in wrap
return f(*args, **kwargs)
  File
"/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 2437, in sql
data=data, conn=self.conn)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
128, in render_template
context, ctx.app)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
110, in _render
rv = template.render(context)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
line 969, in render
return self.environment.handle_exception(exc_info, True)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
line 742, in handle_exception
reraise(exc_type, exc_value, tb)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/_compat.py",
line 36, in reraise
raise value.with_traceback(tb)
  File
"/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/9.5_plus/create.sql",
line 123, in 
IS {{c.description|qtLiteral}};
  File "/tmp/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line
1405, in qtLiteral
res = adapt(value).getquoted()
UnicodeEncodeError: 'latin-1' codec can't encode character '\U0001f4a9' in
position 6: ordinal not in range(256)
2016-06-04 00:23:17,443: ERRORpgadmin:Exception on
/browser/table/sql/1/1/25554/2200/34037 [GET]
Traceback (most recent call last):
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1817, in wsgi_app
response = self.full_dispatch_request()
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1477, in full_dispatch_request
rv = self.handle_user_exception(e)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1381, in handle_user_exception
reraise(exc_type, exc_value, tb)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/_compat.py",
line 33, in reraise
raise value
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1475, in full_dispatch_request
rv = self.dispatch_request()
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/app.py", line
1461, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File "/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/views.py",
line 84, in view
return self.dispatch_request(*args, **kwargs)
  File "/tmp/pgadmin4/web/pgadmin/browser/utils.py", line 233, in
dispatch_request
return method(*args, **kwargs)
  File
"/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 328, in wrap
return f(*args, **kwargs)
  File
"/tmp/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
line 2437, in sql
data=data, conn=self.conn)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
128, in render_template
context, ctx.app)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/flask/templating.py", line
110, in _render
rv = template.render(context)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
line 969, in render
return self.environment.handle_exception(exc_info, True)
  File
"/tmp/pgadmin4/venv3/lib/python3.5/site-packages/jinja2/environment.py",
line 742, in handle_exception
reraise(exc_type, exc_value, tb)
  

[pgadmin-hackers] PATCH: Security label was not properly handled (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue in security label model validation where it was
not properly throwing error on partial inputs.

Additionally, I have updated tablespace required fields validation which
not proper.
(RM#1110)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1110.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers