Re: [DOCS] FAQ future
Magnus Hagander wrote: > On 7 apr 2009, at 07.04, Euler Taveira de Oliveira > wrote: > > > Bruce Momjian escreveu: > >> Now that the main FAQ is on the wiki, what are we doing with the > >> FAQ in > >> CVS? Remove it? What about the language-speicific ones? > > +1. IIRC, Alvaro asked the authors to move it to wiki; and, some of > > them [1] are already there. Let's give some more time (8.4RC1?) > > before removing them from CVS. > > > > Yes, let's remove them. > > Let's remove the main one now, ao there is just one source. Done. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Euler Taveira de Oliveira wrote:
> Bruce Momjian escreveu:
> > Oops, here is the patch; Euler, would you look to see if you can find
> > anything else missing; you seem to be good at that. :-)
> >
> My English is not as good as yours but here is another try. Personally, I
> prefer the second one but...
Great, I used your second version. I had already done some of the ones
you found, but you had many more. I also used your "0 disables" wording
consistently in the file. Thanks for the help. Committed.
--
Bruce Momjian http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: src/backend/utils/misc/guc.c
===
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.500
diff -c -c -r1.500 guc.c
*** src/backend/utils/misc/guc.c 6 Apr 2009 21:00:52 - 1.500
--- src/backend/utils/misc/guc.c 7 Apr 2009 22:15:25 -
***
*** 1316,1322
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock."),
NULL,
GUC_UNIT_MS
},
--- 1316,1322
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***
*** 1406,1412
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
--- 1406,1412
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations, in kilobytes."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
***
*** 1569,1575
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication."),
NULL,
GUC_UNIT_S
},
--- 1569,1575
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication, in seconds."),
NULL,
GUC_UNIT_S
},
***
*** 1599,1605
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints."),
NULL,
GUC_UNIT_S
},
--- 1599,1605
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints, in seconds."),
NULL,
GUC_UNIT_S
},
***
*** 1632,1638
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes."),
NULL,
GUC_UNIT_MS
},
--- 1632,1638
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***
*** 1673,1680
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time above which "
! "statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
--- 1673,1680
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time (in milliseconds) above "
! "which statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
***
*** 1684,1690
{
{"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT,
! gettext_noop("Sets the minimum execution milliseconds above which "
"autovacuum actions will be logged."),
gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."),
GUC_UNIT_MS
--- 1684,1690
{
{"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT,
! gettext_noop("Sets the minimum execution in milliseconds above which "
"autovacuum actions will be logged."),
gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."),
GUC_UNIT_MS
***
*** 1695,1701
{
{"bgwriter_delay", PGC_SIGHUP, RESOURCES,
! gettext_noop("Background writer sleep time between rounds."),
NULL,
GUC_UNIT_MS
},
--- 1695,1701
{
{"bgwriter_delay", PGC_SIGHUP, RESOURCES,
! gettext_noop("Background writer sleep time between rounds, i
Re: [DOCS] log_min_duration_statement units
Bruce Momjian wrote: > Euler Taveira de Oliveira wrote: > > Bruce Momjian escreveu: > > > Oops, here is the patch; Euler, would you look to see if you can find > > > anything else missing; you seem to be good at that. :-) > > > > > My English is not as good as yours but here is another try. Personally, I > > prefer the second one but... > > Great, I used your second version. I had already done some of the ones > you found, but you had many more. I also used your "0 disables" wording > consistently in the file. Thanks for the help. Committed. Huh ... I thought the units were removed from the descriptions when the whole unit thing got introduced in guc.c. This seems more a regression than anything else -- see guc.c rev 1.361. -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Euler Taveira de Oliveira wrote: > > > Bruce Momjian escreveu: > > > > Oops, here is the patch; Euler, would you look to see if you can find > > > > anything else missing; you seem to be good at that. :-) > > > > > > > My English is not as good as yours but here is another try. Personally, I > > > prefer the second one but... > > > > Great, I used your second version. I had already done some of the ones > > you found, but you had many more. I also used your "0 disables" wording > > consistently in the file. Thanks for the help. Committed. > > Huh ... I thought the units were removed from the descriptions when the > whole unit thing got introduced in guc.c. This seems more a regression > than anything else -- see guc.c rev 1.361. Which is why I originally did: #log_min_duration_statement = -1ms# -1 is disabled, 0 logs all statements but people complained so I went with adding it to the description. The units are only to document the default if no units are supplied. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Bruce Momjian writes: > Euler Taveira de Oliveira wrote: >> My English is not as good as yours but here is another try. Personally, I >> prefer the second one but... > Great, I used your second version. I had already done some of the ones > you found, but you had many more. I also used your "0 disables" wording > consistently in the file. Thanks for the help. Committed. You know, it suddenly strikes me that this is going in largely the wrong direction. Wasn't a key part of the reasoning for the GUC units support to *eliminate* the need for people to know what the underlying variable's unit is? I certainly think that putting the unit info into the text descriptions is a seriously bad idea. It makes an already overly wide view even wider, and the information is 100% redundant with the "unit" column of the pg_settings view. regards, tom lane -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Tom Lane wrote: > Bruce Momjian writes: > > Euler Taveira de Oliveira wrote: > >> My English is not as good as yours but here is another try. Personally, I > >> prefer the second one but... > > > Great, I used your second version. I had already done some of the ones > > you found, but you had many more. I also used your "0 disables" wording > > consistently in the file. Thanks for the help. Committed. > > You know, it suddenly strikes me that this is going in largely the wrong > direction. Wasn't a key part of the reasoning for the GUC units support > to *eliminate* the need for people to know what the underlying > variable's unit is? I certainly think that putting the unit info into > the text descriptions is a seriously bad idea. It makes an already > overly wide view even wider, and the information is 100% redundant with > the "unit" column of the pg_settings view. Right, the problem particularly is with the -1/special values that don't have a real unit. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Bruce Momjian writes: > Tom Lane wrote: >> You know, it suddenly strikes me that this is going in largely the wrong >> direction. > Right, the problem particularly is with the -1/special values that don't > have a real unit. I don't object to what you did to postgresql.conf.sample, but I think you should revert the changes to the descriptions in guc.c. regards, tom lane -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> You know, it suddenly strikes me that this is going in largely the wrong
> >> direction.
>
> > Right, the problem particularly is with the -1/special values that don't
> > have a real unit.
>
> I don't object to what you did to postgresql.conf.sample, but I think
> you should revert the changes to the descriptions in guc.c.
Agreed; attached patch applied.
--
Bruce Momjian http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: guc.c
===
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.499
retrieving revision 1.501
diff -c -c -r1.499 -r1.501
*** guc.c 2 Apr 2009 19:57:19 - 1.499
--- guc.c 7 Apr 2009 22:22:19 - 1.501
***
*** 10,16
* Written by Peter Eisentraut .
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.499 2009/04/02 19:57:19 momjian Exp $
*
*
*/
--- 10,16
* Written by Peter Eisentraut .
*
* IDENTIFICATION
! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.501 2009/04/07 22:22:19 momjian Exp $
*
*
*/
***
*** 1316,1322
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock."),
NULL,
GUC_UNIT_MS
},
--- 1316,1322
{
/* This is PGC_SIGHUP so all backends have the same value. */
{"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT,
! gettext_noop("Sets the time to wait on a lock before checking for deadlock, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***
*** 1406,1412
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
--- 1406,1412
{
{"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM,
! gettext_noop("Sets the maximum memory to be used for maintenance operations, in kilobytes."),
gettext_noop("This includes operations such as VACUUM and CREATE INDEX."),
GUC_UNIT_KB
},
***
*** 1530,1536
{
{"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT,
! gettext_noop("Sets the maximum allowed duration of any statement."),
gettext_noop("A value of 0 turns off the timeout."),
GUC_UNIT_MS
},
--- 1530,1536
{
{"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT,
! gettext_noop("Sets the maximum duration of any statement, in milliseconds."),
gettext_noop("A value of 0 turns off the timeout."),
GUC_UNIT_MS
},
***
*** 1569,1575
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication."),
NULL,
GUC_UNIT_S
},
--- 1569,1575
{
{"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY,
! gettext_noop("Sets the maximum allowed time to complete client authentication, in seconds."),
NULL,
GUC_UNIT_S
},
***
*** 1599,1605
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints."),
NULL,
GUC_UNIT_S
},
--- 1599,1605
{
{"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS,
! gettext_noop("Sets the maximum time between automatic WAL checkpoints, in seconds."),
NULL,
GUC_UNIT_S
},
***
*** 1632,1638
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes."),
NULL,
GUC_UNIT_MS
},
--- 1632,1638
{
{"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS,
! gettext_noop("WAL writer sleep time between WAL flushes, in milliseconds."),
NULL,
GUC_UNIT_MS
},
***
*** 1673,1680
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time above which "
! "statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
--- 1673,1680
{
{"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN,
! gettext_noop("Sets the minimum execution time (in milliseconds) above "
! "which statements will be logged."),
gettext_noop("Zero prints all queries. -1 turns this feature off."),
GUC_UNIT_MS
},
***
*** 1684,1690
Re: [DOCS] log_min_duration_statement units
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Tom Lane wrote: > > >> You know, it suddenly strikes me that this is going in largely the wrong > > >> direction. > > > > > Right, the problem particularly is with the -1/special values that don't > > > have a real unit. > > > > I don't object to what you did to postgresql.conf.sample, but I think > > you should revert the changes to the descriptions in guc.c. > > Agreed; attached patch applied. However, keep in mind that units are _not_ displayed for zero values: test=> show statement_timeout; statement_timeout --- 0 (1 row) test=> set statement_timeout = 100; SET test=> show statement_timeout; statement_timeout --- 100ms (1 row) because of this test in guc.c: else if (use_units && result > 0 && (record->flags & GUC_UNIT_TIME)) pg_settings does show the units. Changing this to display the units might be odd since many zero values mean 'disabled'. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
Re: [DOCS] log_min_duration_statement units
Bruce Momjian writes: > However, keep in mind that units are _not_ displayed for zero values: Well, zero is zero, so that seems fine. regards, tom lane -- Sent via pgsql-docs mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
