Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
Jon Parise wrote: I still do not understand what magical values in php.ini-dist need to be applied to run-tests.php and why those values, if they are so important, can't be explicitly enabled via ini_set() calls. Glad to explain :) If you install php.ini-recommended as you default php.ini for CLI, the output is buffered since buffering is enabled in php.ini-recommended. This is very frustrating since I see output with 4096 byte chunks. i.e. type make test, then many seconds later, I see first chunk of outputs at once. We should make it execute run-tests.php well with php.ini-recommend, since it's shipped with PHP. The reason why I suggesting to use php.ini-dist is even person who has CVS account don't understand this. AND I'm not confident nor comfortable writing run-tests.php that runs well under any configuration. (Well I may be able to, but it's a waste of time IMO) Therefore, I'm insisting the use of php.ini-dist many times. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
Sander Roobol wrote: On Thu, Oct 24, 2002 at 11:59:19AM -0400, Jon Parise wrote: - Change the compiled default value for output_buffering to 0. - Allow output_buffering to be set by ini_set(). - Specify 'output_buffering = 0' via the -D command line option for run-tests.php. - Pass a php.ini configuration file to run-tests.php using -C. Can't we just flush all the open output buffers? Something like this: while(ob_get_level()) ob_end_clean(); Of course, I know that. But my points are - run-tests.php itself is not test script, but phpt is. - with specific ini, we can get rid of code aren't needed - we don't have to care about careless patches, and say 'Hey your patch does not work with my php.ini. - things are easier with certain ini. - etc, etc. So far, I didn't see any good point using various php.ini settings for run-tsets.php. Person, who get rid of the setting and insist specifying php.ini is not worth, even cannot find and fix problem with php.ini-recommended. Better choice is obvious, isn't? -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
Derick this is nonsense! We developers can use php -c bla run-tests.php xyz But make is for automated things and for those not reading README.TESTING where everything should be explained. The typical user who is just glad to be able to build his private distribution of php will just call 'make test' to check that the created php executable works. After doing some ini settings many tests will fail In contrast when you want complex tests just use --INI-- section to test different ini values. Even better would be to use this --INI-- section where ever a special value is needed. Remeber the tests are not made to test your ini file but for testing the general functionality of PHP. And this should of cause not be affected by some private ini settings. So please readd the ini to make test and use commandline when you want to test other ini files. marcus At 10:46 23.10.2002, Derick Rethans wrote: derick Wed Oct 23 04:46:50 2002 EDT Modified files: /php4 Makefile.global Log: - Remove this messed up thing AGAIN #- Yasuo: touch it and I'll fly over applying a YART on you. Index: php4/Makefile.global diff -u php4/Makefile.global:1.34 php4/Makefile.global:1.35 --- php4/Makefile.global:1.34 Tue Oct 22 21:21:04 2002 +++ php4/Makefile.globalWed Oct 23 04:46:49 2002 -49,7 +49,7 test: $(SAPI_CLI_PATH) TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \ TEST_PHP_SRCDIR=$(top_srcdir) \ - $(top_builddir)/$(SAPI_CLI_PATH) -c $(top_srcdir)/php.ini-dist $(top_srcdir)/run-tests.php $(TESTS) + $(top_builddir)/$(SAPI_CLI_PATH) $(top_srcdir)/run-tests.php $(TESTS) clean: find . -name \*.lo -o -name \*.o | xargs rm -f -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
On Wed, 23 Oct 2002, Marcus Börger wrote: Derick this is nonsense! Yeah, start yelling. That will really help us all. We developers can use php -c bla run-tests.php xyz But make is for automated things and for those not reading README.TESTING where everything should be explained. If people refuse to read documentatino for tool they don't deserve to use it. Come'n.. if you are professional enough to even run a testsuite then you're certainly professional enough to read a README. The typical user who is just glad to be able to build his private distribution of php will just call 'make test' to check that the created php executable works. After doing some ini settings many tests will fail No, not true. All tests we have should be made working with the settings it depends on hardcoded in the --INI-- section, or for the run-tests.php script with ini_set()'s. _That_ will make a robust test suite. In contrast when you want complex tests just use --INI-- section to test different ini values. Even better would be to use this --INI-- section where ever a special value is needed. Remeber the tests are not made to test your ini file but for testing the general functionality of PHP. And this should of cause not be affected by some private ini settings. Actually, it should, see my reasoning before. So please readd the ini to make test and use commandline when you want to test other ini files. This is not for me, it's the general idea that the test suite works whatever stupid ini settings a user made. If tests fail because of this, or the test suite doesn't work we need to fix the tests and the suite. That's the intention behind it all. Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
At 14:29 23-10-2002, Derick Rethans wrote: If people refuse to read documentatino for tool they don't deserve to use it. Come'n.. if you are professional enough to even run a testsuite then you're certainly professional enough to read a README. Unrelated to the ini issue, but could a: if(isset($ENV['DONT_ASK_QA'])) be implemented to facilitate automated builds/tests ? Then you may fight over the default setting -: P.S. I know about expect(1) but shouldn't rely on that IMO. Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
On Wed, 23 Oct 2002, Melvyn Sopacua wrote: At 14:29 23-10-2002, Derick Rethans wrote: If people refuse to read documentatino for tool they don't deserve to use it. Come'n.. if you are professional enough to even run a testsuite then you're certainly professional enough to read a README. Unrelated to the ini issue, but could a: if(isset($ENV['DONT_ASK_QA'])) be implemented to facilitate automated builds/tests ? Sure we can... but as I dont have any test can you come up with a patch yourself (using getenv() instead of $_ENV)? Then you may fight over the default setting -: funny guy :) Default should be that it should ask to mail to QA :) Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
This is not for me, it's the general idea that the test suite works whatever stupid ini settings a user made. If tests fail because of this, or the test suite doesn't work we need to fix the tests and the suite. That's the intention behind it all. This is not always the case... Some functions need a particular ini setting due to their natures: ex-infamous mbstr-enc-trans is one of them. Marcus may also want to point out this one because he made a tese case for it. Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
On Thu, 24 Oct 2002, Moriyoshi Koizumi wrote: This is not for me, it's the general idea that the test suite works whatever stupid ini settings a user made. If tests fail because of this, or the test suite doesn't work we need to fix the tests and the suite. That's the intention behind it all. This is not always the case... Some functions need a particular ini setting due to their natures: ex-infamous mbstr-enc-trans is one of them. Marcus may also want to point out this one because he made a tese case for it. That's what the --INI-- section in the test files are for. You can hard code ini settings for your test there. Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
That's what the --INI-- section in the test files are for. You can hard code ini settings for your test there. Okay, I'd just like to see how you think about it. Then, no problem :) Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
At 17:40 23-10-2002, Derick Rethans wrote: On Wed, 23 Oct 2002, Melvyn Sopacua wrote: At 14:29 23-10-2002, Derick Rethans wrote: If people refuse to read documentatino for tool they don't deserve to use it. Come'n.. if you are professional enough to even run a testsuite then you're certainly professional enough to read a README. Unrelated to the ini issue, but could a: if(isset($ENV['DONT_ASK_QA'])) be implemented to facilitate automated builds/tests ? Sure we can... but as I dont have any test can you come up with a patch yourself (using getenv() instead of $_ENV)? I disagree on the default, that's why I asked :) Not a real issue for me though. Just don't know if it's a good idea to put in interactivity in something that can become part of an interactive application in the future - like PEAR. So - for future compatibility I decided to go with NO_INTERACTION=1, which should be wrapped around any (future) parts where user input is required. However - this could apply to individual tests as well - for instance I can imagine that readline tests, require user input. If you agree, I can also make a patch to pass that on to the individual tests, so SKIP implementations can work around that. PS. Sorry for the override of your patch - I had already done the bit and the docs. Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
Jon Parise wrote: On Wed, Oct 23, 2002 at 05:38:09PM +0900, Yasuo Ohgaki wrote: Hi Ilia and Jon, Do you still think specifying ini used _for_ run-tests.php is bad thing? I hope I've explained enough. I think you don't care, do you? I don't want to involve myself in some sort of religious argument that I honestly know very little about. I do care about technical things, however. So, once again, all I really want to know is what is so special about php.ini-dist? And what _specific_ settings do you (Yasuo) feel must be applied to run-tests.php in order to run properly? And why can't they just be specified via ini_set() calls. In short, I just want to know why run-tests.php needs an external dependency on php.ini-dist. I would much prefer run-tests.php to be self-contained. I really fail to see why we need to ask troubles for executing run-tests.php. It's executed by various people and better to run always with less problems when people typed make test. Anyway, main problem is Derick is changing the line w/o knowledge of the consequence. He hasn't even fixed a issue I mentioned, yet he reverted my patch twice. 1st time is ok, since he didn't know, 2nd time is not ok since I let him know. He should fix the problem I mentioned at the same time at least. Don't think it's rude, Derick :) Or is it too difficult for you to fix, even the problem I explicitly mentioned? -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 / Makefile.global
On Thu, Oct 24, 2002 at 07:27:31AM +0900, Yasuo Ohgaki wrote: So, once again, all I really want to know is what is so special about php.ini-dist? And what _specific_ settings do you (Yasuo) feel must be applied to run-tests.php in order to run properly? And why can't they just be specified via ini_set() calls. In short, I just want to know why run-tests.php needs an external dependency on php.ini-dist. I would much prefer run-tests.php to be self-contained. I really fail to see why we need to ask troubles for executing run-tests.php. It's executed by various people and better to run always with less problems when people typed make test. Listen, I don't (personally) care about all this Derick did this and Yasuo did that stuff. All I'm looking for are anwers to the questions I've asked. I'd like to be able to understand the technical situation at hand here before I can even think about taking a side, but I am not receiving the information I'm requesting. I still do not understand what magical values in php.ini-dist need to be applied to run-tests.php and why those values, if they are so important, can't be explicitly enabled via ini_set() calls. -- Jon Parise ([EMAIL PROTECTED]) :: The PHP Project (http://www.php.net/) -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
