Bug#690695: no debian version in maven-repo

2016-10-17 Thread Thorsten Glaser 
Hi Emmanuel (and others),

> On Sat, 15 Oct 2016, Emmanuel Bourg wrote:
> 
> > Hum old bug, it should have been closed since we use the 0.x version for
> > this library now.
> 
> Well closure-compiler doesn’t, it depends on the debian version,
> and so do all things that depend on it.

> > I added you to the group, welcome :) The patch isn't strictly
> 
> OK, thanks.
> 
> > necessary, you could add a substitution rule in the minify-maven-plugin
> > package (in debian/maven.rules) such as:
> 
> No, because it chokes before mh_make is even finished, and I
> cannot change debian/maven.rules and restart mh_make because
> it starts from the beginning.

I’ve pushed a patch which at least allows me to progress further,
but did not upload it yet, because I wanted to get this discussed
at first.

This may or may not be (also) a bug in closure-compiler, but I
think having a debian version won’t hurt as most Debian packagers
expect them to exist for most packages since our tools default to
it (I stumbled over that for an (aborted) attempt at packaging
(something no longer needed) already, and Natureshadow cursed
about it already as well). I’ve only added it for one of the two
artefact aliases, though.

This may also help the gerrit packaging effort.

I don’t know how/if this could hurt anything / introduce new bugs
or regressions, please tell me if it does, as I don’t see it.

Are you okay with uploading that? If so, I’ll do it.

Thanks,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#690695: no debian version in maven-repo

2016-10-14 Thread Thorsten Glaser 
On Sat, 15 Oct 2016, Emmanuel Bourg wrote:

> Hum old bug, it should have been closed since we use the 0.x version for
> this library now.

Well closure-compiler doesn’t, it depends on the debian version,
and so do all things that depend on it.

> Le 15/10/2016 à 00:29, Thorsten Glaser a écrit :
> 
> > Shouldn’t *every* artefact have a debian version, anyway?
> 
> Every artifact (except the Maven plugins) should have a generic version
> that doesn't change with every update. The recommended version is
> 'debian' because it's the default and doesn't require any extra

OK.

> substitution rule, but sometimes we use a '.x' version when two
> incompatible versions share the same groupId/artifactId (junit 3 and 4
> is a good example).

AFAICT, this doesn’t apply to jsr305?

> > Anyway, patch attached. I applied to join pkg-java on Alioth; if
> > that’s granted I’ll commit and team-upload it, otherwise I might
> > consider an NMU unless you prefer to handle this.
> 
> I added you to the group, welcome :) The patch isn't strictly

OK, thanks.

> necessary, you could add a substitution rule in the minify-maven-plugin
> package (in debian/maven.rules) such as:

No, because it chokes before mh_make is even finished, and I
cannot change debian/maven.rules and restart mh_make because
it starts from the beginning.

> A 'debian' version wouldn't hurt though, I added a --relocate option to
> maven-repo-helper recently to ease the migration from '.x' to
> 'debian' version or other groupId/artifactId changes.

OK, nice.

Merci,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#690695: no debian version in maven-repo

2016-10-14 Thread Emmanuel Bourg 
Hum old bug, it should have been closed since we use the 0.x version for
this library now.


Le 15/10/2016 à 00:29, Thorsten Glaser a écrit :

> Ideally, yes. I need one in com/google/code/findbugs/jsr305 at the
> very least, to package minify-maven-plugin which depends on Google’s
> closure-compiler, which depends on debian of jsr305
> at least according to:
> /usr/share/maven-repo/com/google/javascript/closure-compiler/debian/closure-compiler-debian.pom
> 
> Shouldn’t *every* artefact have a debian version, anyway?

Every artifact (except the Maven plugins) should have a generic version
that doesn't change with every update. The recommended version is
'debian' because it's the default and doesn't require any extra
substitution rule, but sometimes we use a '.x' version when two
incompatible versions share the same groupId/artifactId (junit 3 and 4
is a good example).


> Anyway, patch attached. I applied to join pkg-java on Alioth; if
> that’s granted I’ll commit and team-upload it, otherwise I might
> consider an NMU unless you prefer to handle this.

I added you to the group, welcome :) The patch isn't strictly
necessary, you could add a substitution rule in the minify-maven-plugin
package (in debian/maven.rules) such as:

  s/com.google.code.findbugs/org.jsr-305/ jsr305 * s/.*/0.x/ * *

A 'debian' version wouldn't hurt though, I added a --relocate option to
maven-repo-helper recently to ease the migration from '.x' to
'debian' version or other groupId/artifactId changes.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#690695: no debian version in maven-repo

2016-10-14 Thread Thorsten Glaser 
On Thu, 18 Oct 2012, tony mancill wrote:

> same location it was found in for -4.  Should there be a debian version
> under both org/jsr-305/jsr-305 and com/google/code/findbugs/jsr305 ?

Ideally, yes. I need one in com/google/code/findbugs/jsr305 at the
very least, to package minify-maven-plugin which depends on Google’s
closure-compiler, which depends on debian of jsr305
at least according to:
/usr/share/maven-repo/com/google/javascript/closure-compiler/debian/closure-compiler-debian.pom

Shouldn’t *every* artefact have a debian version, anyway?

Anyway, patch attached. I applied to join pkg-java on Alioth; if
that’s granted I’ll commit and team-upload it, otherwise I might
consider an NMU unless you prefer to handle this.

bye,
//mirabilos
-- 
tarent solutions GmbH
Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/
Tel: +49 228 54881-393 • Fax: +49 228 54881-235
HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander SteegFrom c1486399453d44c5f2055925377b114cd357bb10 Mon Sep 17 00:00:00 2001
From: mirabilos 
Date: Sat, 15 Oct 2016 00:18:55 +0200
Subject: [PATCH] Install a 'debian' maven version as well (Closes: #690695)

---
 debian/changelog  | 7 +++
 debian/maven-debian.rules | 2 ++
 debian/rules  | 9 ++---
 3 files changed, 15 insertions(+), 3 deletions(-)
 create mode 100644 debian/maven-debian.rules

diff --git a/debian/changelog b/debian/changelog
index 9dc35f8..3b3fa37 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libjsr305-java (0.1~+svn49-9.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Install a 'debian' maven version as well (Closes: #690695)
+
+ -- Thorsten Glaser   Sat, 15 Oct 2016 00:18:50 +0200
+
 libjsr305-java (0.1~+svn49-9) unstable; urgency=medium
 
   * Team upload.
diff --git a/debian/maven-debian.rules b/debian/maven-debian.rules
new file mode 100644
index 000..77cdaee
--- /dev/null
+++ b/debian/maven-debian.rules
@@ -0,0 +1,2 @@
+# Remap this version to debian in deb maven repo
+s/org.jsr-305/com.google.code.findbugs/ s/ri/jsr305/ * s/0\..*/debian/ * *
diff --git a/debian/rules b/debian/rules
index 6b4b698..351740c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -23,9 +23,12 @@ get-orig-source:
 override_jh_installlibs:
 	cp ri/pom.xml debian/pom.xml
 	mh_installpom -plib$(PACKAGE)-java --no-parent --rules=debian/maven-compat.rules debian/pom.xml
-	mh_installjar -plib$(PACKAGE)-java --rules=debian/maven-compat.rules debian/pom.xml $(PACKAGE).jar 
+	mh_installjar -plib$(PACKAGE)-java --rules=debian/maven-compat.rules debian/pom.xml $(PACKAGE).jar
 	dh_link -plib$(PACKAGE)-java /usr/share/java/jsr305.jar usr/share/maven-repo/org/jsr-305/jsr305/0.1-SNAPSHOT/jsr305-0.1-SNAPSHOT.jar
+	cp ri/pom.xml debian/pom.xml
+	mh_installpom -plib$(PACKAGE)-java --no-parent --rules=debian/maven-debian.rules debian/pom.xml
+	mh_installjar -plib$(PACKAGE)-java --rules=debian/maven-debian.rules debian/pom.xml $(PACKAGE).jar
+	dh_link -plib$(PACKAGE)-java /usr/share/java/jsr305.jar usr/share/maven-repo/com/google/code/findbugs/jsr305/debian/jsr305-debian.jar
 	mh_installpoms -plib$(PACKAGE)-java
 	mh_installjar -plib$(PACKAGE)-java --usj-version=$(DEB_UPSTREAM_VERSION) \
-		-l ri/pom.xml $(PACKAGE).jar 
-
+		-l ri/pom.xml $(PACKAGE).jar
-- 
2.9.3

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#690695: no debian version in maven-repo

2012-10-18 Thread tony mancill 
Thank you for the bug report.

On 10/16/2012 08:40 AM, Thomas Koch wrote:
 Package: libjsr305-java
 Version: 0.1~+svn49-5
 Severity: normal
 Control: block 589436 by -1
 
 Hi,
 
 thank you for changing the maven coordinates as requested in bug 683632. It
 seems however that the switch broke the guava package (a dependency of Gerrit)
 which depended on the old coordinates until version 11.0.2-2. The newer
 version switched the coordinates to
 com.google.code.findbugs:jsr305:jar:debian
 but there is no debian version.
 
 I observe this bug when trying to build libgwt-orm-java (ITP) which depends on
 guava.
 
 I wonder however how guava could have been built by dak?

I think the short answer is that guava is arch:all, and so isn't built
by any of the autobuilders.  There's a recent thread on this general
topic on debian-devel [1].

 In any case I believe that every java library should have a debian
 version. What do you think?

The -5 package still ships a debian version and pom, but it's in
/usr/share/maven-repo/org/jsr-305/jsr-305/debian/jsr-305-debian.pom, the
same location it was found in for -4.  Should there be a debian version
under both org/jsr-305/jsr-305 and com/google/code/findbugs/jsr305 ?

Thank you,
tony


[1] http://lists.debian.org/debian-devel/2012/10/msg00296.html



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#690695: no debian version in maven-repo

2012-10-16 Thread Thomas Koch 
Package: libjsr305-java
Version: 0.1~+svn49-5
Severity: normal
Control: block 589436 by -1

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi,

thank you for changing the maven coordinates as requested in bug 683632. It
seems however that the switch broke the guava package (a dependency of Gerrit)
which depended on the old coordinates until version 11.0.2-2. The newer
version switched the coordinates to
com.google.code.findbugs:jsr305:jar:debian
but there is no debian version.

I observe this bug when trying to build libgwt-orm-java (ITP) which depends on
guava.

I wonder however how guava could have been built by dak?

In any case I believe that every java library should have a debian
version. What do you think?

Regards, Thomas Koch


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQfX/rAAoJEAf8SJEEK6ZaXDsQAMvysDIPCIhBOgyaXcn+npTx
133WA92/mqeOoUJNAWJcvXntieChkDWcH1U8udPtCNRxyASKlFeJWiQNppfk8D5P
sgqJ4ALEVQd+p/1qJA9lSYVqRVdT7Mj8EhA3UTLtQuzqfvbXIsXu5CX9t5c14PV3
xBN3IBWHSUQQTEmbynF9qKj8jWvmeIke6JRu/DFR1Ym8KugbUgigX/wfHeNkWLmd
/H/SswqJaPrLxio+ujQkB2O8EHpTy3H2Qdx2J2+TxChgJvFzY3DiHpRr3vUNExp5
yj//RfkRqcbBq3Yub3L5TW8NRmi2A7xZyzqJVjUPfkwB24D7qJzYQI+ejwI3a5Ap
EOSVdL1jTVAepOnWKyPclX5jswH9wQ8YNhhh5e2tFUqYaghFjoUM0YuIZqHZMSex
xDjGY04I3poBCus7MbajOSJqxQ4QMgKs4rcJAEormKQFlm4VuNueGoOGGmBRJ+0S
oGJxf/xasgpgaNARGDynmvO2+DgTMFL2mSRsB4l8aNPMfvx9WU9HgF3kAqHLJuAb
CLW0sF36oN3FCTBzNGF2Uh2hsCLei/Iq7m6xkJS9CmoUoUC8nRK+C7mKlEzUU/pY
E8XKECX3iSQ2GD6eLassdCWj3vnc/ghHF9INdZD1FnvVz3Jnj0UaEYrsqwby8MxK
Zbn6do2lhtYkYeQrX4Pp
=UVDm
-END PGP SIGNATURE-

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.