Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Le mardi, 5 juin 2012 22.59:34, Boris Pek a écrit : Great! Thank you. So you could upload it when you decide it is ready. It's not. src:kcm-gtk is available on all Debian architectures where src:kde- gtk-config at least failed on hurd and kfreebsd with the following error: …/kde-gtk-config-2.0/gtk3proxies/preview3.c:28:25: fatal error: sys/inotify.h: No such file or directory See https://buildd.debian.org/status/package.php?p=kde-gtk- configsuite=experimental This has to be fixed before any upload to unstable. Cheers, OdyX ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, src:kcm-gtk is available on all Debian architectures where src:kde- gtk-config at least failed on hurd and kfreebsd with the following error: …/kde-gtk-config-2.0/gtk3proxies/preview3.c:28:25: fatal error: sys/inotify.h: No such file or directory See https://buildd.debian.org/status/package.php?p=kde-gtk- configsuite=experimental This has to be fixed before any upload to unstable. Ok, I'll fix it ASAP. Any other issues? Best regards, Boris ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Le lundi, 4 juin 2012 22.23:58, Boris Pek a écrit : Hi, I'll upload this package [0] when user changes setup by kde-config-gtk-style 2:0.5.3-1 are kept and converted (if needed) by kde-config-gtk-style 3:2.0-1. That's rather easy to test… Done. Patch is tiny [1], but it works well. Direct link for download: http://mentors.debian.net/debian/pool/main/k/kde-gtk-config/kde-gtk-config _2.0-1.dsc Uploaded; thanks for your work. It will land in NEW for experimental later tonight. ftpmaster: for your information, src:kde-gtk-config takes over the kde-config- gtk-style binary package from src:kcm-gtk on purpose. This has been discussed in the #672268 ITP bugreport and on the debian-mentors mailing list in this thread: https://lists.debian.org/debian-mentors/2012/05/threads.html#00115 Cheers, OdyX signature.asc Description: This is a digitally signed message part. ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, Uploaded; thanks for your work. It will land in NEW for experimental later tonight. ftpmaster: for your information, src:kde-gtk-config takes over the kde-config- gtk-style binary package from src:kcm-gtk on purpose. This has been discussed in the #672268 ITP bugreport and on the debian-mentors mailing list in this thread: https://lists.debian.org/debian-mentors/2012/05/threads.html#00115 Great! Thank you. I have updated the package: kde-gtk-config (3:2.0-2) unstable; urgency=low * Package moved to unstable after tests: no changes required. * This package replaces src:kcm-gtk and closes its bugs: - fixed working on clean install (Closes: #631591) - added support of Gtk+ 3.x (LP: #734979) So you could upload it when you decide it is ready. Direct link for download: http://mentors.debian.net/debian/pool/main/k/kde-gtk-config/kde-gtk-config_2.0-2.dsc How long the package will in experimental of approximately? Best regards, Boris ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Le samedi, 2 juin 2012 16.56:10, vous avez écrit :
2) Handling of the transition
I just tested with a clean user: the current kde-config-gtk-style creates
one .gtkrc-2.0-kde while your new kde-config-gtk-style creates one
.gtkrc-2.0-kde4 that is a symlink to .gtkrc-2.0 . You should probably
cope with
04_no_kde4_in_configfile.diff in src:kcm-gtk and make sure any changes
put there by kcm-gtk is kept gracefully.
Done.
Sorry, but no. I just tested and it doesn't work.
With the attached .gtkrc-2.0-kde as created by the current src:kcm-gtk, when
entering the dialog of src:kde-gtk-config, the dialogs don't show Raleigh
nor DejaVu Sans 9, but oxygen-gtk and Bitstream Charter 12 (and Emacs
for the GTK3 theme). That's not what I'd call any changes there are kept
gracefully.
I'll upload this package [0] when user changes setup by kde-config-gtk-style
2:0.5.3-1 are kept and converted (if needed) by kde-config-gtk-style 3:2.0-1.
That's rather easy to test…
Cheers,
OdyX
[0] But feel free to find another sponsor.
# This file was written by KDE
# You can edit it in the KDE control center, under GTK Styles and Fonts
include /usr/share/themes/Raleigh/gtk-2.0/gtkrc
style user-font
{
font_name=DejaVu Sans
}
gtk-theme-name=Raleigh
gtk-font-name=DejaVu Sans 9
signature.asc
Description: This is a digitally signed message part.
___
pkg-kde-extras mailing list
pkg-kde-extras@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, Sorry, but no. I just tested and it doesn't work. With the attached .gtkrc-2.0-kde as created by the current src:kcm-gtk, when entering the dialog of src:kde-gtk-config, the dialogs don't show Raleigh nor DejaVu Sans 9, but oxygen-gtk and Bitstream Charter 12 (and Emacs for the GTK3 theme). That's not what I'd call any changes there are kept gracefully. I'll upload this package [0] when user changes setup by kde-config-gtk-style 2:0.5.3-1 are kept and converted (if needed) by kde-config-gtk-style 3:2.0-1. That's rather easy to test… I thought we were talking about clean install. But not about total changing of configuration file and its parser. Ok, I'll use your file for tests. Best regards, Boris ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, Sorry, but no. I just tested and it doesn't work. With the attached .gtkrc-2.0-kde as created by the current src:kcm-gtk, when entering the dialog of src:kde-gtk-config, the dialogs don't show Raleigh nor DejaVu Sans 9, but oxygen-gtk and Bitstream Charter 12 (and Emacs for the GTK3 theme). That's not what I'd call any changes there are kept gracefully. I'll upload this package [0] when user changes setup by kde-config-gtk-style 2:0.5.3-1 are kept and converted (if needed) by kde-config-gtk-style 3:2.0-1. That's rather easy to test… Done. Patch is tiny [1], but it works well. Direct link for download: http://mentors.debian.net/debian/pool/main/k/kde-gtk-config/kde-gtk-config_2.0-1.dsc Best regards, Boris [1] https://github.com/tehnick/kde-gtk-config-debian/blob/master/debian/patches/mirgation-from-package-src:kcm-gtk ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, Thank you for a reply. 2) Handling of the transition I just tested with a clean user: the current kde-config-gtk-style creates one .gtkrc-2.0-kde while your new kde-config-gtk-style creates one .gtkrc-2.0-kde4 that is a symlink to .gtkrc-2.0 . You should probably cope with 04_no_kde4_in_configfile.diff in src:kcm-gtk and make sure any changes put there by kcm-gtk is kept gracefully. Done. As a general rule, make sure that any bug fixed in kcm-gtk (by its patches or by its code) is not re-introduced by src:kde-gtk-config. Ok. I have read all bug reports in Debian BTS [1] and in Launchpad [2]. There is only one bug report [3] in Debian BTS (which is still opened). And this bug is exactly about .gtkrc-2.0-kde symlink. So it will be fixed by my package when it is uploaded to unstable. There is the same bug report in Launchpad [4]. All other bugs from Ubuntu are not related with my new package. Other than that, it looks fine but at least 2) ought to be fixed. Great! So I think the package is ready for upload now. Direct link for download: http://mentors.debian.net/debian/pool/main/k/kde-gtk-config/kde-gtk-config_2.0-1.dsc Best regards, Boris [1] http://bugs.debian.org/cgi-bin/pkgreport.cgi?archive=both;src=kcm-gtk [2] http://tinyurl.com/cg8lbwa [3] http://bugs.debian.org/631591 [4] https://bugs.launchpad.net/ubuntu/+source/kcm-gtk/+bug/473197 ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
(Hereby ignoring the tone of your private ping) Le mercredi, 16 mai 2012 23.23:02, Boris Pek a écrit : Great! Could you look on the package now? Yeah. I took a look. 1) Versioning So, what I wrote before about the version is not completely true: bumping the epoch is not _strictly_ needed as 2:0.5.3-1 from src:kcm-gtk would sort before an 2:2.0-1 from src:kde-gtk-config. That said, I think that bumping the epoch would be a clear indication that the source for this package changed so is not necessarily bad. I'll leave that decision up to you. 2) Handling of the transition I just tested with a clean user: the current kde-config-gtk-style creates one .gtkrc-2.0-kde while your new kde-config-gtk-style creates one .gtkrc-2.0-kde4 that is a symlink to .gtkrc-2.0 . You should probably cope with 04_no_kde4_in_configfile.diff in src:kcm-gtk and make sure any changes put there by kcm-gtk is kept gracefully. As a general rule, make sure that any bug fixed in kcm-gtk (by its patches or by its code) is not re-introduced by src:kde-gtk-config. Other than that, it looks fine but at least 2) ought to be fixed. Cheers, OdyX ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Hi, Thank you for a reply. We are talking about replacing the package kcm-gtk by package kde-gtk-config which has wider functionality. That's debatable. I can't agree with you: kde-gtk-config has wider functionality objectively. As I wrote earlier, kcm-gtk does not allow to: * select themes for Gtk 3.x applications * preview available themes for Gtk 2.x and Gtk 3.x applications * custmize toolbars and menus for Gtk applications * select icon themes for Gtk applications * download and apply Gtk 2.x and Gtk 3.x themes from http://opendesktop.org/ in few mouse clicks All these things can be done in kde-gtk-config. Wheezy freeze will be soon. And I really believe that this configuration module should be in it. That's subjective. There are Gtk 3.x applications in Wheezy. And their look and fill can't be configured in KDE using current configurations module. Is it subjective? Anyway; I would strongly oppose a duplication of packages with similar functionality: either the existing src:kcm-gtk is enhanced to support the new features or it should be deprecated in favour of a new source package producing a binary package named identically. Agreed. But kde-gtk-config already exists and in good shape. Upstream is very friendly. He accepted my patches and fixed my issues. It was about 40 e-mails between us during preparing the package. And I don't want to drop this work into trash. And if you want similar features in kcm-gtk, someone should write them from scratch. Does it make sense? (A third solution, technically ugly but doable would be to keep the src:kcm-gtk source name but have it's content be the new source's.) Yep, this is not a variant. What is the procedure for replacing the binary package by one from another source package? The only existing procedure is consensus, reached through discussion. Ok. Could I maintain my package outside kde-extras team in this case? This wouldn't make sense. Ok. Now Debian KDE Extras Team is a maintainer and I am an uploader. So; such a package would make sense if it provides a set of functionalities including _everything_ currently provided by src:kcm-gtk. kcm-gtk has only 4 functions: 1) Selecting available Gtk 2.x theme. 2) Selecting few paths for searching Gtk 2.x themes in the system. 3) Setting up the same font as in KDE applications. 4) Setting up font manually. Functions 2) and 3) are not available in kde-gtk-config now. But... Function 2) has no sense. Because kde-gtk-config allow to install themes from any local location and from special web site (http://opendesktop.org/). Function 3) can be added very quickly. But even now it is not very important because fonts could be set manually. In that case, it shall be named kde-config-gtk-style and get a version bigger than the current 2:0.5.3-1 (such as it's 2.0-1 version plus a bigger epoch such as 3:2.0-1). Done. Then, after some testing, I would be OK to deprecate kcm-gtk (removing the source from unstable). And what about testing branch of Debian? Will be the package processed automatically? In order to allow such testing before the Wheezy's release, I think this new kde-gtk-config should be targeted at experimental, to ease upgrading and functionality testing without breaking Wheezy Done. If such changes are donc, I might consider sponsoring. Great! Could you look on the package now? Links: http://mentors.debian.net/debian/pool/main/k/kde-gtk-config/kde-gtk-config_2.0-1.dsc http://mentors.debian.net/package/kde-gtk-config https://github.com/tehnick/kde-gtk-config-debian/tree/master/debian/ Best regards, Boris ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
Re: [Pkg-kde-extras] Bug#672268: RFS: kde-gtk-config/2.0-1 [ITP] -- KDE configuration module for GTK+ 2.x and GTK+ 3.x style selection
Sorry for a broken message. Here is the correct one: Hi, You could read the beginning of this thread: https://lists.debian.org/debian-mentors/2012/05/threads.html#00115 (Please Cc me in replies, I am not subscribed to pkg-kde-extras mailing list) kde-config-gtk-style does not allow to: * select themes for Gtk 3.x applications * preview available themes for Gtk 2.x and Gtk 3.x applications * custmize toolbars and menus for Gtk applications * select icon themes for Gtk applications * download and apply Gtk 2.x and Gtk 3.x themes from http://opendesktop.org/ in few mouse clicks All these things can be done in kde-gtk-config. what about the following plan then: talk with the kde-config-gtk-style maintainers (kde-extras team and didier raboud) wether it makes sense to just let your package take over the kde-config-gtk-style name. What is the procedure for replacing the binary package by one from another source package? Could I maintain my package outside kde-extras team in this case? Also I have offtopic question: How can translations for kde-gtk-config get into kde-l10n-* packages? It doesn't look like the current utility does something your utility doesn't, am I right? kde-config-gtk-style has only 4 functions: 1) Selecting available Gtk 2 theme. 2) Selecting few paths for searching Gtk 2 themes in the system. 3) Setting up the same font as in KDE applications. 4) Setting up font manually. Features 2) and 3) are not available in kde-gtk-config. No need to have two tools with the same dependencies, same audience and one tool just does a subset of the other. Agreed. Regards, Boris ___ pkg-kde-extras mailing list pkg-kde-extras@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-extras
