Re: QtWebEngine ready for upload

2016-10-27 Thread Sandro Knauß
Hey,
 
> Please rename the binary packages for consistency with other Qt modules:
> 
> * libqt5webengine-dev → qtwebengine5-dev  (cf. qtbase5-dev)
> * qt5webengine-examples → qtwebengine5-examples  (cf. qtbase5-examples)
> * qt5webengine-doc{,-html} → qtwebengine5-doc{,-html}  (cf. qtbase5-doc)

Done.
 
> Which script did you use for generating debian/copyright?
> It would be nice to get that documented in debian/README.Debian
> (with instructions on how to update that file for newer releases).

I used the script created by maxy (don't find the url again). But sofar the 
tool is not suitible to update a existing copyright file and still needs a lot 
of love afterwards. But maybe maxy has some workflow, how he used the tool for 
update.

I did the update from 5.6.1 -> 5.7.1 by creating a script that using a patch 
of the update and than split by what changed:
file deleted -> remove the entry from copyright
file added/modified check license by mxay script vs. the license that is in 
copyright file.

but stil this was a lot of handmade work.

Maybe i should make this script ready for use for others.

> There are also some weird entries there, like:

made another round in copyright file do delete those entries.

Regards,

sandro


signature.asc
Description: This is a digitally signed message part.
-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk

Re: QtWebEngine ready for upload

2016-10-27 Thread Dmitry Shachnev
Hi Sandro,

On Thu, Oct 27, 2016 at 05:28:20PM +0200, Sandro Knauß wrote:
> Hey,
>
> after days I spent inside the copyright file. I think now QtWebEngine is now 
> ready for upload. Could somebody please review the package?
> If it helps I can also upload one built to mentors, because it takes ~2h on 
> my 
> machine.

Please rename the binary packages for consistency with other Qt modules:

* libqt5webengine-dev → qtwebengine5-dev  (cf. qtbase5-dev)
* qt5webengine-examples → qtwebengine5-examples  (cf. qtbase5-examples)
* qt5webengine-doc{,-html} → qtwebengine5-doc{,-html}  (cf. qtbase5-doc)

Which script did you use for generating debian/copyright?
It would be nice to get that documented in debian/README.Debian
(with instructions on how to update that file for newer releases).

There are also some weird entries there, like:

  Files: src/3rdparty/chromium/third_party/skia/*
  Copyright: 2008-2016, Google Inc
 2015, Google Inc.
 2015, Google Inc." "
 2013-2015, Google, Inc
 [...]
 block
 block suitable for this language, with the
  License: BSD-3-clause

In any case, the FTP masters will do a more thorough review of copyright
file than me :)

> I packaged the 5.7.1 snapshot, that is built against Qt 5.6.1 (sid)
> successfully, should it uploaded to experimental or testing? Tighen dependency
> to one specific Qt version?

It would be nice to depend on 5.7.1~20161021 versions of Qt (again like we
do in all the other modules). However qtwebchannel 5.7 is not yet available,
and qtdeclarative is only available on amd64/i386 at the moment, so I do not
insist on this.

--
Dmitry Shachnev


signature.asc
Description: PGP signature
-- 
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-kde-talk