Re: Review Request 122861: Micro-optimize LayoutManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122861/ --- (Updated March 10, 2015, 6:05 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 26596c054dd212ce8ad4333145575414d54b08f2 by Kai Uwe Broulik to branch master. Repository: plasma-desktop Description --- This micro-optimizes the LayoutManager by: - using Array and Object literals rather than new Object/Array, and also creating the whole structure at once if applicable - Store end values in for loops rather than calculating them on each iteration - Adjust coding style here and there Diffs - containments/desktop/package/contents/code/LayoutManager.js 14d0dfc Diff: https://git.reviewboard.kde.org/r/122861/diff/ Testing --- Moving applets (especially using Eike's press-and-hold when using it on a touchscreen :P) feels snappier, doesn't print any new warnings on console and seems to work as before. However, I can no longer cause plasmashell to go berserk when moving a small applet ontop of a huge one (eg. small sticky note on wide fuzzy clock) where it desperately tries to find a place and fails. I think the grid size should be based on units somehow, having a 24x24 grid on a high dpi screen also benefits the aforementioned behavior. One surprising discovery I made is that using Qt.point instead of a handcrafted JS Object is one order of magnitude(!) slower. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122894: Add config option for Kickoff icon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/#review77271 --- Ship it! applets/kickoff/package/contents/ui/configGeneral.qml https://git.reviewboard.kde.org/r/122894/#comment53054 i would find semantically slightly more correct units.smallSpacing*2 instead of gridUnit/2, but that's not really important, just tastes applets/kickoff/package/contents/ui/configGeneral.qml https://git.reviewboard.kde.org/r/122894/#comment53053 this looks a bit hackish, sure is visually really necessary? - Marco Martin On March 10, 2015, 8:55 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/ --- (Updated March 10, 2015, 8:55 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- This restores the functionality from the 4.x times. The button uses the same style used in various places, such as lockscreen and display manager, it has a Choose action and a, previously missing, convenient Clear action. Diffs - applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 Diff: https://git.reviewboard.kde.org/r/122894/diff/ Testing --- Choosing an icon works, applying changes the icon, and reset resets it. Is there a way to set a config back to its defaults? File Attachments Config in action https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122888: Port the look and feel KCM to the qml only version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/#review77300 --- Ship it! (when other stuff is merged obviously) - David Edmundson On March 10, 2015, 11:32 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/ --- (Updated March 10, 2015, 11:32 a.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-desktop Description --- this ports the lf kcm to KDeclarative::ConfigModule showing an example on how should be used Diffs - CMakeLists.txt 7c6284c kcms/lookandfeel/CMakeLists.txt 2cde16f kcms/lookandfeel/autotests/CMakeLists.txt 1f01310 kcms/lookandfeel/kcm.h c082cd3 kcms/lookandfeel/kcm.cpp d930b45 kcms/lookandfeel/package/contents/ui/main.qml 9ff3df3 Diff: https://git.reviewboard.kde.org/r/122888/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Monday 09 March 2015, kainz.a wrote: Hi plasma developers, I'm part of the VDG and do some artwork for the Breeze icon set. ... My question was: - Can I start a Wallpaper contest for the plasma team to have additional standard wallpapers in plasma 5.3. Hi, it would be cool, yes :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Bugs
Thanks for that David. Here's the list of products in bugzilla I manually add new versions to when there is a new release. Please look and check all the products you expect to be there are there. systemsettings Powerdevil plasma-nm Oxygen frameworks-modemmanager-qt ksysguard KScreen kwin kwayland ksysguard kmenuedit kio-extras kinfocenter khotkeys khelpcenter kde-cli-tools Breeze Baloo plasmashell kdeplasma-addons Touchpad-KCM ksshaskpass solid user-manager krunner muon kde-gtk-config kded-appmenu kstart ksplash Plasma%20Workspace%20Wallpapers policykit-kde-agent-1 kwrited drkonqi klipper knetattach kfontview solid is a strange product in bugzilla which covers everything that has ever been solid (bluetooth, libsolid, networkmanager, powerdevil). Everything has newer products, should I kill it closing all the bugs and create a new product for bluedevil? What's the best way to close bugs with a scripted message of moved to product foo, if you still get this please create a new bug? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122842: Allow selecting notifications position on screen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/ --- (Updated March 11, 2015, 7:09 p.m.) Review request for Plasma. Changes --- Forgot to stage the new file ;) Bugs: 344841 https://bugs.kde.org/show_bug.cgi?id=344841 Repository: plasma-workspace Description --- Allows to select each corner and top or bottom edges of the screen. The radio selection thing is currently a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post in the forums). Diffs (updated) - applets/notifications/package/contents/config/main.xml 6e55fe8 applets/notifications/package/contents/ui/Notifications.qml 4312774 applets/notifications/package/contents/ui/ScreenPositionSelector.qml PRE-CREATION applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 applets/notifications/plugin/notificationshelper.h ca0b63b applets/notifications/plugin/notificationshelper.cpp e7c4e29 Diff: https://git.reviewboard.kde.org/r/122842/diff/ Testing --- All positions work File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png New Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122916: Fix displaying label1 in job notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/ --- Review request for Plasma. Repository: plasma-workspace Description --- Repeater in JobDetailsItem.qml is iterating over jobItem (JobDelegate.qml) properties, but it only contains label0. This patch moves the label1 + labelName1 properties from JobDetailsItem.qml to JobDelegate.qml Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab applets/notifications/package/contents/ui/JobDetailsItem.qml 2f557ee Diff: https://git.reviewboard.kde.org/r/122916/diff/ Testing --- Notifications now correctly shows both labels (in my case From and To labels in receive files notification) Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77349 --- Ship it! Ship It! - Lukáš Tinkl On Bře. 11, 2015, 8:03 odp., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated Bře. 11, 2015, 8:03 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122917: Fix thumbnail previews for directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/ --- Review request for Plasma. Repository: kio-extras Description --- Fix thumbnail previews for directories. Diffs - thumbnail/thumbnail.cpp b92e326 Diff: https://git.reviewboard.kde.org/r/122917/diff/ Testing --- Opened Dolphin5 Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: However do you know how it is with property licenses when used as backgrounds? It varies by country, sensible countries make sure that photos of public buildings are not restricted by copyright. Both the UK and the US are sensible countries in this regard. http://en.wikipedia.org/wiki/Freedom_of_panorama That is not true, for example Trafalgar Square or Parliament Square in London that are not private tourist photos _must_ have a property release before using it commercially. And there are many such buildings or landmarks in US and everywhere else too. Same goes with children or any person on photos, there you need model release (ie. the person's signature that his/her photo can be used for various purposes). Personality rights for people modelling is only a US concept, sensible countries have no such restrictions. That is also not true and it's more complicated. Basically, taking a picture on the public space/street should be safe, but as soon as the person (and especially children) are the main object of the photos, you do need to have a license to use those in a non-private way. All I'm saying is, better stay safe (licensing Golden Gate Bridge for non-private use is 2000$, getting sued could be very very very expensive). Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122917: Fix thumbnail previews for directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/#review77357 --- Ship it! Ship It! - Bhushan Shah On March 12, 2015, 6:13 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/ --- (Updated March 12, 2015, 6:13 p.m.) Review request for Plasma. Repository: kio-extras Description --- Fix thumbnail previews for directories. Diffs - thumbnail/thumbnail.cpp b92e326 Diff: https://git.reviewboard.kde.org/r/122917/diff/ Testing --- Opened Dolphin5 Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77358 --- Good catch? src/plasma/theme.cpp https://git.reviewboard.kde.org/r/122915/#comment53120 Would it work to: QMetaObject::invoke(d-rectSaveTimer, SLOT(start())); that will mean we always use the timer? - David Edmundson On March 12, 2015, 10:34 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 10:34 a.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 12:50 p.m., David Edmundson wrote: Good catch? I have no idea why I put a question mark there. That wasn't intended. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77358 --- On March 12, 2015, 10:34 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 10:34 a.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Thu, Mar 12, 2015 at 2:05 PM, Jonathan Riddell j...@jriddell.org wrote: You're mixing several unrelated laws here. Personality rights in the US applies to people who make a living from their celebrity. Privacy rights in the EU applies to helping protect the little children. There's some common law concepts in Scotland and elsewhere around photos of models and celebrities but it's very unlikely to apply to photos given away under the GPL at no cost and has no bearing on KDE's licence policy which is based only on the copyright owner. All I'm saying is that if we choose to distribute a picture of a person without any written consent from that person and if that person changes his/her mind at any time after we've released it, it could go bad as suddenly that person's face is on millions of computers and I guess it would be hard to explain to any legal body how did it end up there when the person is saying he/she does not/did not want to be there. I just think it doesn't seem worthy to get ourselves into potential problems like this. Stay safe. That is all. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77371 --- Ship it! My apologies, please leave it in AutoConnection. Other than that it should go in. I'm still unsure if there's nothing else that will fail on the multithreaded case but this is a step forward nevertheless. - Aleix Pol Gonzalez On March 12, 2015, 2:38 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:38 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 80d5a6fddaa3857fddaa1185ce0786b5dd19802c by Marco Martin to branch master. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 12:50 p.m., David Edmundson wrote: src/plasma/theme.cpp, line 424 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line424 Would it work to: QMetaObject::invoke(d-rectSaveTimer, SLOT(start())); that will mean we always use the timer? Seems so: does invokeMethod always call it from the own thread? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77358 --- On March 12, 2015, 10:34 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 10:34 a.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 1:28 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/2/?file=354540#file354540line421 You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be the drop replacement, but Qt::QueuedConnection is faster and enough in this case. it defaults to Auto which is Queued if it needs to be. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77365 --- On March 12, 2015, 1:25 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class members at the same time... Marco Martin wrote: seems things gets called from a different thread once right after being created.. that would make it the case for every single class created from QML i guess? needs more investigation, but this can potentially unveil a deeper problem in QML? Aleix Pol Gonzalez wrote: Can you maybe provide a backtrace of the Q_UNLIKELY path? It can be interesting to understand what's going on. This, seems to happen always only once in the lifecycle of a SvgItem: 0 Plasma::Theme::insertIntoRectsCache theme.cpp 422 0x7f0794bf21fd 1 Plasma::SvgPrivate::findAndCacheElementRect svg.cpp 551 0x7f0794be8bb4 2 Plasma::SvgPrivate::elementRect svg.cpp 525 0x7f0794be8778 3 Plasma::Svg::hasElement svg.cpp 865 0x7f0794bea652 4 Plasma::SvgPrivate::findInCache svg.cpp 335 0x7f0794be7329 5 Plasma::Svg::image svg.cpp 771 0x7f0794be9cb1 6 Plasma::SvgItem::updatePaintNodesvgitem.cpp 161 0x7f077c080a86 7 QQuickWindowPrivate::updateDirtyNodeqquickwindow.cpp2823 0x7f0795333811 8 QQuickWindowPrivate::updateDirtyNodes qquickwindow.cpp2648 0x7f079533285f 9 QQuickWindowPrivate::syncSceneGraph qquickwindow.cpp340 0x7f0795327d4c 10 QSGRenderThread::sync qsgthreadedrenderloop.cpp 510 0x7f07952f15da 11 QSGRenderThread::syncAndRender qsgthreadedrenderloop.cpp 553 0x7f07952f1abf 12 QSGRenderThread::runqsgthreadedrenderloop.cpp 663 0x7f07952f2734 13 QThreadPrivate::start qthread_unix.cpp337 0x7f07905321bf 14 start_thread/lib64/libpthread.so.0 0x7f078f6800db 15 clone /lib64/libc.so.60x7f078f97f90d - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 --- On March 12, 2015, 1:25 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Thursday 12 March 2015 14:29:11 Martin Klapetek wrote: All I'm saying is that if we choose to distribute a picture of a person without any written consent from that person and if that person changes his/her mind at any time after we've released it, it could go bad as suddenly that person's face is on millions of computers and I guess it would be hard to explain to any legal body how did it end up there when the person is saying he/she does not/did not want to be there. while in some places this may be true for landmarks as well, the worst case scenario I guess is indeed for the photo of people.. but given how wallpapers should look in general, a no humans policy for the selected photos could be sane anyways. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122917: Fix thumbnail previews for directories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/ --- (Updated March 12, 2015, 1:45 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit b027b0191826d2b937213b0028831edd28eeb479 by David Edmundson to branch Plasma/5.2. Repository: kio-extras Description --- Fix thumbnail previews for directories. Diffs - thumbnail/thumbnail.cpp b92e326 Diff: https://git.reviewboard.kde.org/r/122917/diff/ Testing --- Opened Dolphin5 Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 2:28 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/2/?file=354540#file354540line421 You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be the drop replacement, but Qt::QueuedConnection is faster and enough in this case. David Edmundson wrote: it defaults to Auto which is Queued if it needs to be. True, I should have read the documentation. . (Default) If the receiver lives in the thread that emits the signal, Qt::DirectConnection is used. Otherwise, Qt::QueuedConnection is used. The connection type is determined when the signal is emitted. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77365 --- On March 12, 2015, 2:38 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:38 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class members at the same time... seems things gets called from a different thread once right after being created.. that would make it the case for every single class created from QML i guess? needs more investigation, but this can potentially unveil a deeper problem in QML? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 --- On March 12, 2015, 10:34 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 10:34 a.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs (updated) - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77366 --- shell/panelshadows.cpp https://git.reviewboard.kde.org/r/122909/#comment53127 This is wrong. It will now cause pixmap leakage. - Martin Gräßlin On March 12, 2015, 2:24 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated March 12, 2015, 2:24 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
On March 12, 2015, 2:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class members at the same time... Marco Martin wrote: seems things gets called from a different thread once right after being created.. that would make it the case for every single class created from QML i guess? needs more investigation, but this can potentially unveil a deeper problem in QML? Can you maybe provide a backtrace of the Q_UNLIKELY path? It can be interesting to understand what's going on. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 --- On March 12, 2015, 2:25 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated March 12, 2015, 1:24 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit aba0ad12685e2946a42d6a60d8cca58aa24b6d2a by Jan Kundrát to branch master. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77365 --- src/plasma/theme.cpp https://git.reviewboard.kde.org/r/122915/#comment53126 You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be the drop replacement, but Qt::QueuedConnection is faster and enough in this case. - Aleix Pol Gonzalez On March 12, 2015, 2:25 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:38 p.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs (updated) - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77369 --- For the record I reverted with http://commits.kde.org/plasma-workspace/c4c7e6d53f66fbdd6d58b40e5f3b443c6cf2e197: The reason for revertion is that it leaks pixmaps. QX11Info::display should not return a nullptr if there is no QScreen. This needs fixing in Qt, not workarounds in our software. None of our X11 specific code in plasma-workspace or frameworks can handle the case that the Display* or xcb_connection_t* becomes null suddenly. Neither can Qt internally. If it would happen Qt would abort. The only application in our workspace which would be somewhat safe is KWin because it caches the returned Display after first invokation to QX11Info::display. - Martin Gräßlin On March 12, 2015, 2:24 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated March 12, 2015, 2:24 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122909: Fix segfault with missing screens
On March 12, 2015, 1:40 p.m., Martin Gräßlin wrote: For the record I reverted with http://commits.kde.org/plasma-workspace/c4c7e6d53f66fbdd6d58b40e5f3b443c6cf2e197: The reason for revertion is that it leaks pixmaps. QX11Info::display should not return a nullptr if there is no QScreen. This needs fixing in Qt, not workarounds in our software. None of our X11 specific code in plasma-workspace or frameworks can handle the case that the Display* or xcb_connection_t* becomes null suddenly. Neither can Qt internally. If it would happen Qt would abort. The only application in our workspace which would be somewhat safe is KWin because it caches the returned Display after first invokation to QX11Info::display. Now someone has told me about the problem, I can fix this trivially in Qt. - Richard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77369 --- On March 12, 2015, 1:24 p.m., Jan Kundrát wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated March 12, 2015, 1:24 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Fix segfault with missing screens This is to keep up with the Qt 5.5 changes with null QScreen. BT: #0 XInternAtom (dpy=0x0, name=0x7f1195725664 _KDE_NET_WM_SHADOW, onlyIfExists=0) at /var/tmp/portage/x11-libs/libX11-1.6.2/work/libX11-1.6.2/src/IntAtom.c:174 #1 0x7f11956e438c in PanelShadows::Private::clearShadow (this=optimized out, window=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:494 #2 0x7f11956e7139 in PanelShadows::removeWindow (this=0x7f119593b060 (anonymous namespace)::Q_QGS_privateDialogShadowsSelf::innerFunction()::holder, window=window@entry=0x7f119958ff90) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelshadows.cpp:142 #3 0x7f11956dd8f5 in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:124 #4 0x7f11956dd9af in PanelView::~PanelView (this=0x7f119958ff90, __in_chrg=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/panelview.cpp:125 #5 0x7f11956effa8 in ShellCorona::removeView (this=0x7f1196c19b40, idx=0) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:710 #6 0x7f11956f0038 in ShellCorona::remove (this=this@entry=0x7f1196c19b40, desktopView=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:662 #7 0x7f11956f009f in ShellCorona::screenRemoved (this=0x7f1196c19b40, screen=optimized out) at /var/tmp/portage/kde-plasma/plasma-workspace-5.2.1/work/plasma-workspace-5.2.1/shell/shellcorona.cpp:743 Diffs - shell/panelshadows.cpp c97564a2417a66e17a1a02237155f19addf2b9c7 Diff: https://git.reviewboard.kde.org/r/122909/diff/ Testing --- Thanks, Jan Kundrát ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122915: check we are started from the correct thread before starting timer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 --- src/plasma/theme.cpp https://git.reviewboard.kde.org/r/122915/#comment53121 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class members at the same time... - Aleix Pol Gonzalez On March 12, 2015, 11:34 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 11:34 a.m.) Review request for Plasma. Repository: plasma-framework Description --- rectSaveTimer is used to event compress the save and sync of the configuration file that is used as a cache of the rectangles of svg items (in order to avoid svg renderers creation when possible) there is exactly one situation where it seems to not work: during creation of svgitems/framesvgitems, insertintorectcache ends up being called by another thread than the Theme's qobject thread, and that is not allowed. so in this case during normal svg resizes, all goes as before Diffs - src/plasma/theme.cpp 18d4ed6 Diff: https://git.reviewboard.kde.org/r/122915/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Project: libmuon package install for 3rd party applications
On Thu, Mar 12, 2015 at 8:34 PM, Jonathan Riddell j...@jriddell.org wrote: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages? Like I told you, I think that what you're aiming to do here really is packagekit. If you think about it, it will never be as simple as you'd like it to be anyway. Designing API, jobs. You only want to install? Or also delete? As an alternative, we can work on the muon-discover --application orca use-case. It will spawn a full application, but at least the user will be knowing what he's installing. Maybe even creating a muon-cli, but I don't really think we want to expose API from muon. Aleix PS: A good GSoC would be to make sure that Appstream can finally be adopted properly in Kubuntu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122919: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122919/ --- Review request for Plasma. Repository: sddm-kcm Description --- I can't find any reference to these dependencies, so remove them. Diffs - CMakeLists.txt 52e1ace5fb9cee4afa0711b4f6bc0b851500d427 src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c Diff: https://git.reviewboard.kde.org/r/122919/diff/ Testing --- Inspected source. Builds. No library links to the affected dependencies before and after the change. Thanks, Michael Palimaka ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/ --- Review request for Plasma. Repository: plasma-workspace Description --- Don't show pause button for jobs that are not suspendable. Clicking on the pause button for non-suspendable jobs has no effect anyway. This patch also applies same logic for stop (kill) button. Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab Diff: https://git.reviewboard.kde.org/r/122920/diff/ Testing --- Non-suspendable jobs no longer have pause button in notifications. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
thanks for the information. thats the reason that the plasma team should find the winner and not the community via rating. cheers Andreas Am 12.03.2015 13:46 schrieb Martin Klapetek martin.klape...@gmail.com: On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: However do you know how it is with property licenses when used as backgrounds? It varies by country, sensible countries make sure that photos of public buildings are not restricted by copyright. Both the UK and the US are sensible countries in this regard. http://en.wikipedia.org/wiki/Freedom_of_panorama That is not true, for example Trafalgar Square or Parliament Square in London that are not private tourist photos _must_ have a property release before using it commercially. And there are many such buildings or landmarks in US and everywhere else too. Same goes with children or any person on photos, there you need model release (ie. the person's signature that his/her photo can be used for various purposes). Personality rights for people modelling is only a US concept, sensible countries have no such restrictions. That is also not true and it's more complicated. Basically, taking a picture on the public space/street should be safe, but as soon as the person (and especially children) are the main object of the photos, you do need to have a license to use those in a non-private way. All I'm saying is, better stay safe (licensing Golden Gate Bridge for non-private use is 2000$, getting sued could be very very very expensive). Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122921: Handle job error when showing job finished notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- Review request for Plasma. Repository: plasma-workspace Description --- When job finishes, the notifications applet shows a %job_message%: Finished notification with action to open url (extracted from description). If the job finishes with error, this notification still displays Finished and offers to open url, but as the job finished with error, this url will most probably be invalid. There is also no indication that the job actually finished with error. This patch checks for job error and in case of error, set notification summary to %job_message%: Error, body to error text and clears the actions (no open url). It only works with jobs that actually sets the error text (KJob::setErrorText), because KJob::error is not exposed in dataengine. Diffs - applets/notifications/package/contents/ui/Jobs.qml ee3ec5b Diff: https://git.reviewboard.kde.org/r/122921/diff/ Testing --- Error in job is now detected, displayed in notification and there is no open url action. File Attachments error-notification https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122921: Handle job error when showing job finished notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- (Updated March 12, 2015, 5:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 5a592ed7d7f617681f0aa6fc508213cf5212042d by David Rosca to branch master. Repository: plasma-workspace Description --- When job finishes, the notifications applet shows a %job_message%: Finished notification with action to open url (extracted from description). If the job finishes with error, this notification still displays Finished and offers to open url, but as the job finished with error, this url will most probably be invalid. There is also no indication that the job actually finished with error. This patch checks for job error and in case of error, set notification summary to %job_message%: Error, body to error text and clears the actions (no open url). It only works with jobs that actually sets the error text (KJob::setErrorText), because KJob::error is not exposed in dataengine. Diffs - applets/notifications/package/contents/ui/Jobs.qml ee3ec5b Diff: https://git.reviewboard.kde.org/r/122921/diff/ Testing --- Error in job is now detected, displayed in notification and there is no open url action. File Attachments error-notification https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122921: Handle job error when showing job finished notification
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/#review77390 --- Ship it! Thanks for doing this - David Edmundson On March 12, 2015, 4:50 p.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- (Updated March 12, 2015, 4:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- When job finishes, the notifications applet shows a %job_message%: Finished notification with action to open url (extracted from description). If the job finishes with error, this notification still displays Finished and offers to open url, but as the job finished with error, this url will most probably be invalid. There is also no indication that the job actually finished with error. This patch checks for job error and in case of error, set notification summary to %job_message%: Error, body to error text and clears the actions (no open url). It only works with jobs that actually sets the error text (KJob::setErrorText), because KJob::error is not exposed in dataengine. Diffs - applets/notifications/package/contents/ui/Jobs.qml ee3ec5b Diff: https://git.reviewboard.kde.org/r/122921/diff/ Testing --- Error in job is now detected, displayed in notification and there is no open url action. File Attachments error-notification https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 7 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 7:01 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs (updated) - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122916: Fix displaying label1 in job notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/ --- (Updated March 12, 2015, 8:40 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6b462e70ec6072b9861b57e720407ada9a78ac80 by David Rosca to branch Plasma/5.2. Repository: plasma-workspace Description --- Repeater in JobDetailsItem.qml is iterating over jobItem (JobDelegate.qml) properties, but it only contains label0. This patch moves the label1 + labelName1 properties from JobDetailsItem.qml to JobDelegate.qml Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab applets/notifications/package/contents/ui/JobDetailsItem.qml 2f557ee Diff: https://git.reviewboard.kde.org/r/122916/diff/ Testing --- Notifications now correctly shows both labels (in my case From and To labels in receive files notification) Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/ --- (Updated March 12, 2015, 8:40 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 69fb206e395a9795648bd3e4ba28898f1c042c99 by David Rosca to branch Plasma/5.2. Repository: plasma-workspace Description --- Don't show pause button for jobs that are not suspendable. Clicking on the pause button for non-suspendable jobs has no effect anyway. This patch also applies same logic for stop (kill) button. Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab Diff: https://git.reviewboard.kde.org/r/122920/diff/ Testing --- Non-suspendable jobs no longer have pause button in notifications. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 2:58 p.m.) Review request for KDE Frameworks and Plasma. Repository: kcmutils Description --- This makes KCMLoader try to load the qobject-only, qml based kcms as well, if it succeeds it wraps them in the KCModuleQML KCModule subclass and returns it as loaded module (the class itself is not exported, so no new symbols). This makes systemsettings, kcmshell and any config dialog that loads kcms transparently load those config modules not based upon KCModule Diffs (updated) - CMakeLists.txt cb4ae5d src/CMakeLists.txt f7b869f src/kcmoduleloader.cpp 5ccf236 src/kcmoduleqml.cpp PRE-CREATION src/kcmoduleqml_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122887/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
On March 10, 2015, 11:30 a.m., Marco Martin wrote: src/quickaddons/configmodule.h, line 43 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line43 I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but unfortunately that name is terrible, since makes people think this arrives from Qt (should have been called KQuickAddons, all old classes in it namespaced etc, that library is a disaster :/)) I'm almost tempted to re-export everything under KQuickAddons both library and namespace, deprecating completely QuickAddons (ConfigModule class would be only in kquickaddons, not the old one) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77247 --- On March 12, 2015, 2:55 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
BluezQt in kdereview
Hi all, I'd like to announce that BluezQt is now in kdereview. https://projects.kde.org/projects/kdereview/bluez-qt It is a Bluez 5 DBus API wrapper library and is going to replace libbluedevil in Bluedevil. If there are no issues, it will be moved to kde/workspace and used in Bluedevil for Plasma 5.3 release. I'll be glad for any comments during review process. Thanks, David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Project: libmuon package install for 3rd party applications
2015-03-12 21:00 GMT+01:00 Jonathan Riddell j...@jriddell.org: On Thu, Mar 12, 2015 at 08:40:46PM +0100, Matthias Klumpp wrote: 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: [...] What's the difference between this and the already existing PackageKit(-Qt) and PackageKit session interface? (and the combination of it with AppStream to avoid hardcoding a list of packages, as it seems to be the plan here (?)) Mostly it would keep Debian and Kubuntu happier who aren't great fans of PackageKit. Yeah, I am still waiting for bug reports and feature requests for that ;-) The only thing where PK falls short is for advanced package managers like Synaptic on Debian, because it doesn't support features like holding packages etc. But it was never designed for that. (although to my suprise someone recently submitted a patch to PK to allow downgrading of packages) Using appstream seems sensible, how do I use it to find the name of e.g. the samba package? It would require the distributor or upstream vendor to ship the metadata[1]. If upstream projects do that, everyone has the required information, and getting the packages (e.g. via libappstream-qt) is as simple as Database::componentById(samba)-packageNames() AppStream was not only designed for applications, but also to fetch metadata about any software component. E.g. it is already used for input-methods, fonts and firmware. The other half of the project would be to implement this in the various places that KDE software needs it which nobody seems to have done yet. Finding places where KDE software could benefit from it would also be quite a challenge (it's not documented, and lots of software silently works around missing components). Cheers, Matthias [1]: http://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent -- Debian Developer | Freedesktop-Developer I welcome VSRE emails. See http://vsre.info/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Project: libmuon package install for 3rd party applications
Hi! 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages? What's the difference between this and the already existing PackageKit(-Qt) and PackageKit session interface? (and the combination of it with AppStream to avoid hardcoding a list of packages, as it seems to be the plan here (?)) Cheers, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Project: libmuon package install for 3rd party applications
On Thu, Mar 12, 2015 at 08:40:46PM +0100, Matthias Klumpp wrote: 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages? What's the difference between this and the already existing PackageKit(-Qt) and PackageKit session interface? (and the combination of it with AppStream to avoid hardcoding a list of packages, as it seems to be the plan here (?)) Mostly it would keep Debian and Kubuntu happier who aren't great fans of PackageKit. Using appstream seems sensible, how do I use it to find the name of e.g. the samba package? The other half of the project would be to implement this in the various places that KDE software needs it which nobody seems to have done yet. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122916: Fix displaying label1 in job notifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/#review77397 --- Ship it! Please commit to Plasma/5.2 branch and then merge into master. - Kai Uwe Broulik On März 12, 2015, 11:13 vorm., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/ --- (Updated März 12, 2015, 11:13 vorm.) Review request for Plasma. Repository: plasma-workspace Description --- Repeater in JobDetailsItem.qml is iterating over jobItem (JobDelegate.qml) properties, but it only contains label0. This patch moves the label1 + labelName1 properties from JobDetailsItem.qml to JobDelegate.qml Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab applets/notifications/package/contents/ui/JobDetailsItem.qml 2f557ee Diff: https://git.reviewboard.kde.org/r/122916/diff/ Testing --- Notifications now correctly shows both labels (in my case From and To labels in receive files notification) Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/#review77398 --- Ship it! applets/notifications/package/contents/ui/JobDelegate.qml https://git.reviewboard.kde.org/r/122920/#comment53150 You can just do visible: getData(jobsSource.data, suspendable, 0) - Kai Uwe Broulik On März 12, 2015, 4:06 nachm., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/ --- (Updated März 12, 2015, 4:06 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- Don't show pause button for jobs that are not suspendable. Clicking on the pause button for non-suspendable jobs has no effect anyway. This patch also applies same logic for stop (kill) button. Diffs - applets/notifications/package/contents/ui/JobDelegate.qml a27b5ab Diff: https://git.reviewboard.kde.org/r/122920/diff/ Testing --- Non-suspendable jobs no longer have pause button in notifications. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Project: libmuon package install for 3rd party applications
Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages? Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Bugs
On Thu, Mar 12, 2015 at 6:56 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Mar 11, 2015 at 2:24 PM, David Edmundson da...@davidedmundson.co.uk wrote: All plasmashell bugs are now set up to CC plasma-bugs as discussed at the sprint as some maintainers weren't doing a very good job of keeping on top of things. You can subscribe here. https://mail.kde.org/mailman/listinfo/plasma-bugs You can also choose to follow the plasma-bugs bugzilla user by going to bugs.kde.org - preferences - email - user watching which has the same effect. This reduces duplicates if you are in the CC list for a bug anyway. I think I'd mentioned this at the sprint as well, this is not a solution. It just throws the bugs under another place where none looks. As you said, _another_ place. . I don't see how you could possibly argue it's worse in any way. I'm open to ideas of better solutions, but at the sprint you didn't provide any. You're not providing any here either. I do not see the point of subscribing to a mailing list with such high traffic. If one wants to see what bugs haven't been triaged, there are bugzilla queries. This seems more like a manpower issue. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Bugs
On Wed, Mar 11, 2015 at 2:24 PM, David Edmundson da...@davidedmundson.co.uk wrote: All plasmashell bugs are now set up to CC plasma-bugs as discussed at the sprint as some maintainers weren't doing a very good job of keeping on top of things. You can subscribe here. https://mail.kde.org/mailman/listinfo/plasma-bugs You can also choose to follow the plasma-bugs bugzilla user by going to bugs.kde.org - preferences - email - user watching which has the same effect. This reduces duplicates if you are in the CC list for a bug anyway. I think I'd mentioned this at the sprint as well, this is not a solution. It just throws the bugs under another place where none looks. I do not see the point of subscribing to a mailing list with such high traffic. If one wants to see what bugs haven't been triaged, there are bugzilla queries. This seems more like a manpower issue. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
Well just as a suggestion can't we post something like please remember to check your local laws concerning official buildings and people and then IF someone hands over an image of an official building then we can ask them. I mean there's no point burning the house down to protect it from burglars is there? On Thursday, March 12, 2015 01:45:34 PM Martin Klapetek wrote: On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: However do you know how it is with property licenses when used as backgrounds? It varies by country, sensible countries make sure that photos of public buildings are not restricted by copyright. Both the UK and the US are sensible countries in this regard. http://en.wikipedia.org/wiki/Freedom_of_panorama That is not true, for example Trafalgar Square or Parliament Square in London that are not private tourist photos _must_ have a property release before using it commercially. And there are many such buildings or landmarks in US and everywhere else too. Same goes with children or any person on photos, there you need model release (ie. the person's signature that his/her photo can be used for various purposes). Personality rights for people modelling is only a US concept, sensible countries have no such restrictions. That is also not true and it's more complicated. Basically, taking a picture on the public space/street should be safe, but as soon as the person (and especially children) are the main object of the photos, you do need to have a license to use those in a non-private way. All I'm saying is, better stay safe (licensing Golden Gate Bridge for non-private use is 2000$, getting sued could be very very very expensive). Cheers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Thu, Mar 12, 2015 at 1:53 PM, Jens Reuterberg j...@ohyran.se wrote: Well just as a suggestion can't we post something like please remember to check your local laws concerning official buildings and people and then IF someone hands over an image of an official building then we can ask them. I mean there's no point burning the house down to protect it from burglars is there? It gets complicated with KDE's international distribution though, one law not being valid in one country might be very valid in another country. But then again, I don't understand it enough to make educated claims, I'm just raising what I know as a photographer who actually tried to license some of his photos to a company. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
On Thu, Mar 12, 2015 at 01:45:34PM +0100, Martin Klapetek wrote: On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: A A However do you know how it is with property licenses when used as A A backgrounds? It varies by country, sensible countries make sure that photos of public buildings are not restricted by copyright.A Both the UK and the US are sensible countries in this regard. http://en.wikipedia.org/wiki/Freedom_of_panorama That is not true, for example Trafalgar Square or Parliament Square in London that are not private tourist photos _must_ have a property release before using it commercially. And there are many such buildings or landmarks in US and everywhere else too. There seems to be some specific byelaws for Trafalgar Square and Parliament Square that restrict photography https://www.london.gov.uk/sites/default/files/Trafalgar%20Square%20Byelaws%2025Jan2012_1.pdf in which case sure, just make sure there's no photos of these two sites in the competition if we want to keep Boris Johnston happy (personally I'd love to see him get upset). Same goes for the Atonium in Brussels or the Little Mermaid statue in Copenhagen where they don't have sensible laws regarding photos of buildings. US law is weird and mixed but there's no real restrictions and if wikipedia are happy to put photos of the golden gate bridge then I trust them to have done the research to know it's fine A A Same goes with children or any person on photos, A A there you need model release (ie. the person's signature that his/her A A photo A A can be used for various purposes). Personality rights for people modelling is only a US concept, sensible countries have no such restrictions. That is also not true and it's more complicated. Basically, taking a picture on the public space/street should be safe, but as soon as the person (and especially children) are the main object of the photos, you do need to have a license to use those in a non-private way. You're mixing several unrelated laws here. Personality rights in the US applies to people who make a living from their celebrity. Privacy rights in the EU applies to helping protect the little children. There's some common law concepts in Scotland and elsewhere around photos of models and celebrities but it's very unlikely to apply to photos given away under the GPL at no cost and has no bearing on KDE's licence policy which is based only on the copyright owner. Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
Well I'm no legal expert so neither can I. I just think that beyond some care to tell people not to break any local laws there isn't much we can do without making it a contest for who can grasp international trademark law the best. Lets just roll with it for now. Perhaps tell people to check in with legal issues and that its GPL we're going with license wise and not stress out about to much at this early stage, On Thursday, March 12, 2015 02:00:23 PM Martin Klapetek wrote: On Thu, Mar 12, 2015 at 1:53 PM, Jens Reuterberg j...@ohyran.se wrote: Well just as a suggestion can't we post something like please remember to check your local laws concerning official buildings and people and then IF someone hands over an image of an official building then we can ask them. I mean there's no point burning the house down to protect it from burglars is there? It gets complicated with KDE's international distribution though, one law not being valid in one country might be very valid in another country. But then again, I don't understand it enough to make educated claims, I'm just raising what I know as a photographer who actually tried to license some of his photos to a company. Cheers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122914: Take Shown and Hidden status in account when showing sidebar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122914/#review77351 --- Ship it! Ship It! - Marco Martin On March 12, 2015, 4:24 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122914/ --- (Updated March 12, 2015, 4:24 a.m.) Review request for Plasma. Bugs: 344795 https://bugs.kde.org/show_bug.cgi?id=344795 Repository: plasma-workspace Description --- - if clicked on arrow show sidebar - if clicked on always hidden applet show sidebar - if clicked on always shown applet hide sidebar - in case of passive applet show sidebar Diffs - applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 0b9f96f Diff: https://git.reviewboard.kde.org/r/122914/diff/ Testing --- Checked all cases Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122914: Take Shown and Hidden status in account when showing sidebar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122914/ --- (Updated March 12, 2015, 5:40 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 344795 https://bugs.kde.org/show_bug.cgi?id=344795 Repository: plasma-workspace Description --- - if clicked on arrow show sidebar - if clicked on always hidden applet show sidebar - if clicked on always shown applet hide sidebar - in case of passive applet show sidebar Diffs - applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 0b9f96f Diff: https://git.reviewboard.kde.org/r/122914/diff/ Testing --- Checked all cases Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasma wallpapers
Hey, On Mon, Mar 9, 2015 at 3:46 PM, kainz.a kain...@gmail.com wrote: Hi plasma developers, I'm part of the VDG and do some artwork for the Breeze icon set. Plasma 5.1 and 5.2 has a new wallpaper but only one. I would like to see some nice wallpapers for 5.3 in other areas. There was a nice weather wallpaper app in kde 4, I think it wasn't ported but for this there were never realy usefull wallpapers. In addition there should be also wallpapers for more categories. I ask the digikam developers cause they are the picture guys for help and they say ask on Google+ than you will find enough contributors, we will also support you. My question was: - Can I start a Wallpaper contest for the plasma team to have additional standard wallpapers in plasma 5.3. I will make an plog post, You can select the best images for your wallpaper package. Nice initiative! However do you know how it is with property licenses when used as backgrounds? I'm asking because normally when you want to give/sell a license of a photo with say Golden Gate Bridge, you must first seek property release from the city of San Francisco (I've heard that many places in London are actually unlicenceable when it comes to photos). Same goes with children or any person on photos, there you need model release (ie. the person's signature that his/her photo can be used for various purposes). I really don't know how is it with photos not being sold but given your call has Konqi from Silicon Valley or City of Bangkok or Children wallpaper (not sure if you meant actual children :), I think it's better to stay on the safe side and specify a bit more what the background can be than later be sued by cities and stuff. And finally, you do require a model/property release for anything that's even remotely identifiable. Basically if the person can recognize it's him/her (even if there's just a leg with special shoes) or if the owner of the property can recognize his/her property, you need a release :) See [1] for more details. So, there's that :) [1] - https://iso.500px.com/10-photos-you-wouldnt-think-need-model-releases-but-do/ Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53086 this should mention packages somewhere. src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53084 This documentation tells me nothing, and I'm not sure what this does from the method name. src/quickaddons/configmodule.h https://git.reviewboard.kde.org/r/122886/#comment53083 I guess you copy and pasted all these. KConfigXT isn't relevant at all here. src/quickaddons/configmodule.cpp https://git.reviewboard.kde.org/r/122886/#comment53085 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. - David Edmundson On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122886: QML-only KCM base
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 373 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line373 I guess you copy and pasted all these. KConfigXT isn't relevant at all here. yes, is pretty much KCModule docs :) I think they are fine-ish, I think needs mostly the addition of how to combine that with QML in the general class description seciton. On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 338 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line338 This documentation tells me nothing, and I'm not sure what this does from the method name. eh, I have no idea about this method as well :/ it's a thing exported by KCModule, so here just wrapping it. it's presumably used for some reason, somewhere, but even from the code it's not understandable. on lxr, seems the only place where is used is KInfoCenter http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5 (may be worth even just dumping it...) On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.cpp, line 102 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102 when combined with your other KCModule patch you have a crash. From KCModule docs: This sets the KAboutData returned by aboutData() The about data is now owned by KCModule. So this will result in a double delete. Same for the delete in setAboutData. hmm, would work actually creating a copy of this about data in the wrapper class? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- On March 10, 2015, 11:28 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 10, 2015, 11:28 a.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- This is a QObject-based fork of KCmodule, with the api slightly adaped to be more declarative friendly. it loads a qml file that then will be able to access its instance as kcm or as the KCM attached property, like what happens in plasmoids (for how attached proeprties work, unfortunately only properties of the base class will be accessible). They will be loaded in systemsettings by review 122887 Diffs - src/quickaddons/CMakeLists.txt 3c7a34b src/quickaddons/configmodule.h PRE-CREATION src/quickaddons/configmodule.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122886/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- (Updated March 10, 2015, 5:10 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 148e0022f67e4d189b0a5a0a5a370e2eed5e5993 by Marco Martin to branch master. Repository: plasma-framework Description --- (still in progress but here for feedback) when QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps generated by Svg will be scaled up to give a proper texture. This is complementary but not replacing our current approach: the pixelratio that can be accessed by units is now in relation to the qt pixel ratio, spacings are also adjusted accordingly (therefore, spaces and sizes won't need an integer value like pixelratio) svg introduces also a scaleFactor property (that is pretty much like its old pixelRatio) basically, scalefactor, will scale both the textures *and* all the reported sizes, (old method) pixelratio just scales textures without altering measures (like qt pixelratio likes) they are now both used and combined, so a) we can have this working before supporting officially qt pixelratio when will be good enough but b) keeping the old mwthod working for the time being c) by using both at the sae time we can at least scale sizes of values != from integers, for screens that are too dense for 1 and not enough for 2 Diffs - src/declarativeimports/core/framesvgitem.cpp dae8a4f src/declarativeimports/core/iconitem.cpp 03f40c4 src/declarativeimports/core/svgitem.cpp 570c1c3 src/declarativeimports/core/units.h 6c038ba src/declarativeimports/core/units.cpp a740145 src/plasma/framesvg.cpp 1bb3510 src/plasma/private/svg_p.h a31d0ac src/plasma/svg.h 0bcbd7a src/plasma/svg.cpp 0a0db5e Diff: https://git.reviewboard.kde.org/r/122673/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
