KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/115/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 02 Feb 2018 06:34:22 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codes

D5209: Load translations from KPackage files if bundled

[Aleksandar Varagic]

avaragic added a dependency: D10215: Make KReport use marble component, KEXI & 
KEXI frameworks stable is 3.1.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: ltoscano, Zren, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10181: Removed the "fastblur" path

[Aleksandar Varagic]

avaragic added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D10181#198862, @fredrik wrote:
  
  > Code wise this LGTM.
  >
  > Consider it accepted if the VDG has no objections.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10181

To: anemeth, graesslin, #kwin, #plasma, #vdg
Cc: avaragic, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Aleksandar Varagic]

Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Martin Flöser]

graesslin updated this revision to Diff 26362.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Make m_device mutable and always lazy load it.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10236?vs=26337&id=26362

BRANCH
  libinput-event-device

REVISION DETAIL
  https://phabricator.kde.org/D10236

AFFECTED FILES
  libinput/events.cpp
  libinput/events.h

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 4 bug reports: Open for bugs

[Martin Flöser]

Am 2018-02-01 22:19, schrieb David Edmundson:

In bugzilla a product can be "Open for bug entry" or not.
It can also be done at a per-version level.

When unset a user will not see it in the "enter bug" list, or the
version won't be listed. If they force it, they'll get a message like:
https://bugs.kde.org/enter_bug.cgi?product=Aktion

Currently Plasma 4 is "open for bug entry".

One can also enter a bug on the 4.x entries on products like
systemsettings, kscreenlocker etc.


kscreenlocker is still a product in 5.



Should we disable them? It still gets a few every month and it's
wasting the user's time if we're clearly not going to do anything with
it.


+1



FWIW: I've already disabled new bugs on plasmashell 5.0 -> 5.7, I know
Martin does the same in kwin


I'm even more strict. For KWin the following rules are applied:
 * latest two minor version of current release (e.g. currently 5.11.5 
and 5.11.4)
 * latest two minor version of current LTS release (e.g. currently 5.8.7 
and 5.8.8)

 * latest development release
 * master

The main thinking is: I'm not interested in triaging bugs for 5.10, we 
won't do fixes any more. Neither am I interested in bugs for 5.11.3 -> 
distros should update.


So next week this will change to:
 * 5.11.95 will be disabled
 * 5.8.x will be disabled
 * 5.11.4 will be disabled

If we apply that rule for more prodcuts, it would be super awesome to 
automate. I just noticed that all 5.11 versions were still open for 
bugs.


Cheers
Martin

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

[Nathaniel Graham]

ngraham added a comment.


  We need screenshots! This is impossible to review without applying the diff 
without before-and-after screenshots.
  
  Also, the title becomes the commit message, and should therefore follow 
standard commit message guidelines: describe the fix, use the imperative mood, 
don't include the bug number. So how about something like "Improve visibility 
of disconnected Wi-Fi icon"?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10224: Give a default player name

[Nicolas Fella]

nicolasfella added a comment.


  Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does 
not get recognized as such. Chrome works fine. I will try to dig into the 
underlying issue.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10224

To: nicolasfella, broulik, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D10243: Disconnected wi-fi icons are almost invisible BUG:384018

[Andreas Kainz]

andreask edited the summary of this revision.
andreask added reviewers: Plasma, Plasma Accessibility, sebas, ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10243

To: andreask, #plasma, #plasma_accessibility, sebas, ngraham
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10237: Bring back embedded top3 reviews on the ApplicationPage

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  F5687564: What it looks like.png 
  
  Nice! There are a few polish changes I'd like to see:
  
  - Add a header label saying "Top reviews", since it's otherwise not obvious 
what users are looking at ("Newest reviews?" "Developer's favorite reviews?"). 
We could probably replace the blue line with this header
  - Change the label that says "Show Reviews" to "Show more reviews" (unless 
you deliberately avoided changing any strings to squeak it in for 5.12)
  - Could we increase the vertical padding between each review a bit?
  - For KDenlive's entry, I noticed three extra dummy reviews:
  
  F5687562: Extra reviews.png 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10237

To: apol, ngraham
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Plasma 4 bug reports: Open for bugs

[David Edmundson]

In bugzilla a product can be "Open for bug entry" or not.
It can also be done at a per-version level.

When unset a user will not see it in the "enter bug" list, or the version
won't be listed. If they force it, they'll get a message like:
https://bugs.kde.org/enter_bug.cgi?product=Aktion

Currently Plasma 4 is "open for bug entry".

One can also enter a bug on the 4.x entries on products like
systemsettings, kscreenlocker etc.

Should we disable them? It still gets a few every month and it's wasting
the user's time if we're clearly not going to do anything with it.

FWIW: I've already disabled new bugs on plasmashell 5.0 -> 5.7, I know
Martin does the same in kwin

David

D10236: [libinput] Ensure Event::device returns a proper Device

[Fabian Vogt]

fvogt added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D10236#199259, @graesslin wrote:
  
  > In https://phabricator.kde.org/D10236#199252, @fvogt wrote:
  >
  > > Now you can remove the initial setting of `m_device` as well.
  >
  >
  > I thought about it while doing the change. I decided against it for the 
following reasons:
  >
  > - it would need to be inited with null instead
  
  
  Alternatively just call `device()` once explicitly in the constructor to 
avoid code duplication.
  That way the lazyness of `device()` is lost, but that's not a goal anyway.
  
  > - the norm is not having this problem, the switch event is an exception
  
  It's not, this can happen to literally any event if they get queued together.
  
  > - device would have to lose the const-ness, the const_cast hack is in my 
opinion only a valid solution for exceptions, for the standard case it would 
have to be changed.
  
  Just set `m_device` as `mutable` instead, that's what it's intended for.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D10236#199252, @fvogt wrote:
  
  > Now you can remove the initial setting of `m_device` as well.
  
  
  I thought about it while doing the change. I decided against it for the 
following reasons:
  
  - it would need to be inited with null instead
  - the norm is not having this problem, the switch event is an exception
  - device would have to lose the const-ness, the const_cast hack is in my 
opinion only a valid solution for exceptions, for the standard case it would 
have to be changed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10225: Define property in Units.qml for the Plasma styles

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a02e91a271c3: Define property in Units.qml for the Plasma 
styles (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10225?vs=26312&id=26344

REVISION DETAIL
  https://phabricator.kde.org/D10225

AFFECTED FILES
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: apol, #plasma, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Fabian Vogt]

fvogt added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Now you can remove the initial setting of `m_device` as well.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10217: Choose source with a combobox, but only on the desktop view

[Nathaniel Graham]

ngraham added a comment.


  We were not able to achieve consensus, I'm afraid. If you'd like to be 
involved in Discover's design, please let me know and I'll invite you to the 
Discover-Design Telegram room, where we discuss these things.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D10217

To: ngraham, apol, #discover_software_store, #vdg
Cc: davidc, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/114/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 18:02:57 +
 Build duration:
4 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 546.48 KB...]Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 10%] Automatic MOC for target kcm_standard_actions[ 10%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 10%] Automatic MOC for target kcm_keys[ 10%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/home/jenkins/work

D10237: Bring back embedded top3 reviews on the ApplicationPage

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10237

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/ReviewDelegate.qml

To: apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10057: Require libinput and udev

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  If nobody objects by Sunday I'm going to push this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10057

To: graesslin, #kwin, #plasma
Cc: mart, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  alternative approach in https://phabricator.kde.org/D10236

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10236: [libinput] Ensure Event::device returns a proper Device

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, fvogt.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  This fixes a problem when a Device added and another event on the Device
  are queued together. In that case the second event would not get the
  Device set as it's not yet created.
  
  This change ensures that when accessing device the pointer will be
  updated.
  
  BUG: 389674
  FIXED-IN: 5.12.1

REPOSITORY
  R108 KWin

BRANCH
  libinput-event-device

REVISION DETAIL
  https://phabricator.kde.org/D10236

AFFECTED FILES
  libinput/events.cpp
  libinput/events.h

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10235: [server] Add support for the frame semantics of Pointer version 5

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma, Frameworks.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  This change implements the required changes for wl_seat version 5.
  There seem to be applications which require version 5 and refuse to
  start if the server doesn't provide it. Thus we need to provide it.
  
  The main difference with version 5 is that pointer need to send a
  frame event after each logical group of events. As we don't support the
  new events from version 5 yet, we just emit the frame after each event
  and implement the suggested semantics for the enter/leave behavior.
  
  To really make use of this, we will have to implement additions in the
  API and then in KWin to expose the new API elements. But to just support
  the semantics we don't need it.
  
  BUG: 389189

TEST PLAN
  Extended autotest

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/registry.cpp
  src/server/pointer_interface.cpp
  src/server/pointer_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #kwin, #plasma, #frameworks
Cc: plasma-devel, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D10234#199165, @fvogt wrote:
  
  > In https://phabricator.kde.org/D10234#199148, @graesslin wrote:
  >
  > > I had another idea: when the Event gets processed and the m_device is 
null, we just update it again from the event.
  > >
  > > Something like
  > >
  > >   if (!event->device()) {
  > >   event->updateDevice();
  > >   }
  > >
  > >
  > > with
  > >
  > >   void Device::updateDevice()
  > >   {
  > >   m_device = Device::getDevice(libinput_event_get_device(m_event);
  > >   }
  > >  
  > >  
  > >
  >
  >
  > I wouldn't do that manually, rather replace `m_device` references with a 
`device()` method and if `m_device` is nullptr, assign it lazily.
  
  
  That's even better.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Fabian Vogt]

fvogt added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D10234#199148, @graesslin wrote:
  
  > I had another idea: when the Event gets processed and the m_device is null, 
we just update it again from the event.
  >
  > Something like
  >
  >   if (!event->device()) {
  >   event->updateDevice();
  >   }
  >
  >
  > with
  >
  >   void Device::updateDevice()
  >   {
  >   m_device = Device::getDevice(libinput_event_get_device(m_event);
  >   }
  >  
  >  
  >
  
  
  I wouldn't do that manually, rather replace `m_device` references with a 
`device()` method and if `m_device` is nullptr, assign it lazily.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D10170#199153, @anemeth wrote:
  
  > Now only enabled blur when the frame is transparent.
  >
  > @hpereiradacosta
  >  drawPanelMenuPrimitive only runs once per panel creation and not 60 times 
per second, right?
  
  
  Well it is also probably called every time the selected (on mouse-over) item 
changes. So basically everytime you move the mouse in the list. 
  Now setting the property only once per menu (or rather, only at creation or 
when its sizes change), would require quite a bit more machinery. Probably 
something like a "breezeblurhelper" to which you would need to register the 
menu at creation (in ::polish) and then deal with resizeevent and configuration 
changes inside there.  
  Unless you feel like giving it a shot yourself, I could probably take care of 
that when this code is committed.
  There was some code of this kind (more complex though), in the now 
decommissioned oxygen-transparent code. That was called oxygenblurhelper.
  
  > This is what enabled blur behind a window: 
https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245
  >  I don't think it checks if it's already enabled.
  >  But if it's called only once per panel then it's not an issue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e1673f18e942: Adjust spacing between text and plotter 
line in Speed tab of nm applet (authored by kamathraghavendra, committed by 
nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10183?vs=26190&id=26330

REVISION DETAIL
  https://phabricator.kde.org/D10183

AFFECTED FILES
  applet/contents/ui/TrafficMonitor.qml

To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich, ngraham
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10225: Define property in Units.qml for the Plasma styles

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10225

To: apol, #plasma, mart
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 58 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/58/
 Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 01 Feb 2018 16:07:10 +
 Build duration:
7 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 10 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.knsbackendtestFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.wrongInput
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report65%
(11/17)69%
(75/108)69%
(75/108)52%
(2401/4578)38%
(1271/3381)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover90%
(9/10)90%
(9/10)52%
(317/613)34%
(127/372)discover.autotests100%
(1/1)100%
(1/1)100%
(93/93)53%
(48/90)exporter0%
(0/3)0%
(0/3)0%
(0/67)0%
(0/50)libdiscover70%
(7/10)70%
(7/10)58%
(141/244)48%
(92/192)libdiscover.Category100%
(5/5)100%
(5/5)58%
(128/222)40%
(91/226)libdiscover.ReviewsBackend100%
(8/8)100%
(8/8)60%
(136/227)64%
(49/76)libdiscover.Transaction63%
(5/8)63%
(5/8)44%
(127/286)36%
(50/139)libdiscover.UpdateModel100%
(4/4)100%
(4/4)79%
(144/182)64%
(58/90)libdiscover.appstream0%
(0/4)0%
(0/4)0%
(0/211)0%
(0/132)libdiscover.backends.DummyBackend91%
(10/11)91%
(10/11)73%
(199/273)69%
(95/137)libdiscover.backends.DummyBackend.tests100%
(3/3)100%
(3/3)96%
(246/255)52%
(205/396)libdiscover.backends.KNSBackend0%
(0/6)0%
(0/6)0%
(0/402)0%
(0/250)libdiscover.backends.KNSBackend.tests0%
(0/2)0%
(0/2)0%
(0/83)0%
(0/144)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/4)0%
(0/2)libdiscover.resources91%
(20/22)91%
(20/22)62%
(640/1039)44%
(331/757)libdiscover.tests100%
(3/3)100%
(3/3)85%
(230/272)51%
(125/244)notifier0%

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/45/
 Project:
Plasma discover stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 16:05:59 +
 Build duration:
4 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 9 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.appargFailed: TestSuite.appstreamUrlFailed: TestSuite.categoryargFailed: TestSuite.installFailed: TestSuite.missingResourceFailed: TestSuite.packageArgumentFailed: TestSuite.toplevelsFailed: TestSuite.updateandinstallFailed: TestSuite.wrongInput

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth marked 4 inline comments as done.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth updated this revision to Diff 26329.
anemeth added a comment.


  Now only enabled blur when the frame is transparent.
  
  @hpereiradacosta
  drawPanelMenuPrimitive only runs once per panel creation and not 60 times per 
second, right?
  This is what enabled blur behind a window: 
https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245
  I don't think it checks if it's already enabled.
  But if it's called only once per panel then it's not an issue.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10170?vs=26278&id=26329

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10170

AFFECTED FILES
  kstyle/breeze.kcfg
  kstyle/breezestyle.cpp
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

tars up for Plasma 5.12.0

[Bhushan Shah]

Hello,

Tars are up for Plasma 5.12.0 on racnoss for packagers to package.
release is signed by my key, fingerprint is in signature.

https://www.kde.org/info/plasma-5.12.0.php

Plasma devs: any last minute bug fixes ask me for a re-roll of tars.

Errata https://community.kde.org/Plasma/5.12_Errata

Announcemnt is not up yet as I don't have svn kerma, it will be done by
tomorrow morning

Happy packaging!

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

KDE CI: Plasma discover stable-kf5-qt5 SUSEQt5.9 - Build # 57 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20SUSEQt5.9/57/
 Project:
Plasma discover stable-kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 01 Feb 2018 16:01:49 +
 Build duration:
5 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 235.62 KB...]Generating MOC predefs moc_predefs.hGenerating MOC source include/DiscoverObject.moc/home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/discover/DiscoverObject.cpp:80: Warning: Class OurSortFilterProxyModel implements the interface QQmlParserStatus but does not list it in Q_INTERFACES. qobject_cast to QQmlParserStatus will not work!Generating MOC predefs moc_predefs.hGenerating MOC source include/KNSBackend.mocGenerating MOC source include/KNSReviews.mocGenerating MOC source EWIEGA46WW/moc_KNSBackend.cppGenerating MOC source EWIEGA46WW/moc_KNSResource.cppGenerating MOC source EWIEGA46WW/moc_KNSReviews.cppGenerating MOC compilation mocs_compilation.cpp[ 64%] Built target kns-backend_autogenScanning dependencies of target plasma-discover-exporter[ 64%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/main.cpp.oGenerating MOC source EWIEGA46WW/moc_DiscoverDeclarativePlugin.cppGenerating MOC source EWIEGA46WW/moc_DiscoverObject.cppGenerating MOC source EWIEGA46WW/moc_FeaturedModel.cppGenerating MOC source EWIEGA46WW/moc_PaginateModel.cppGenerating MOC source EWIEGA46WW/moc_UnityLauncher.cppGenerating MOC compilation mocs_compilation.cpp[ 64%] Built target plasma-discover_autogen[ 65%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.oIn file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function 'void ModelTest::data()':/home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~In file included from /usr/include/qt5/QtCore/QtCore:4:0, from /usr/include/qt5/QtGui/QtGuiDepends:3, from /usr/include/qt5/QtGui/QtGui:3, from /home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:43:/home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp: In member function 'void ModelTest::data()':/home/jenkins/workspace/Plasma discover stable-kf5-qt5 SUSEQt5.9/libdiscover/tests/modeltest.cpp:429:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Q_ASSERT ( alignment == ( alignment & ( Qt::AlignHorizontal_Mask | Qt::AlignVertical_Mask ) ) );~~^~~~[ 66%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[ 67%] Linking CXX executable CategoriesTest[ 67%] Built target CategoriesTest[ 68%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/plasma-discover-exporter_autogen/mocs_compilation.cpp.o[ 70%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[ 70%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/knsbackendtest_autogen/mocs_compilation.cpp.oScanning dependencies of target kns-backend[ 71%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 72%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[ 73%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[ 74%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[ 75%] Linking CXX executable knsbackendtest[ 76%] Linking CXX executable updatedummytest[ 77%] Linking CXX executable plasma-discover-exporter[ 77%] Built target knsbackendtest[ 77%] Built target updatedummytestScanning dependencies of target dummy-backend[ 78%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.oScanning dependencies of target plasma-discover[ 78%] Built target plasma-discover-exporter[ 79%] Building CXX object discover/CMakeFiles/plasma-discover.dir/qrc_resources.cpp.o[ 80%] Building CXX object libdiscover/backends/DummyBacke

KDE CI: Plasma discover stable-kf5-qt5 FreeBSDQt5.9 - Build # 44 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20discover%20stable-kf5-qt5%20FreeBSDQt5.9/44/
 Project:
Plasma discover stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 16:01:49 +
 Build duration:
3 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 165.33 KB...][ 23%] Built target DiscoverNotifierDeclarativePlugin[ 24%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.oScanning dependencies of target DummyNotifier[ 25%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[ 26%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[ 27%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[ 28%] Linking CXX shared module DummyNotifier.so[ 28%] Built target DummyNotifier[ 29%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[ 30%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[ 31%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[ 32%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[ 33%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[ 34%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[ 35%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[ 36%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesProxyModel.cpp.o[ 37%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/PackageState.cpp.o[ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesUpdatesModel.cpp.o[ 38%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StandardBackendUpdater.cpp.o[ 39%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/SourcesModel.cpp.o[ 40%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResourcesBackend.cpp.o[ 41%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractResource.cpp.o[ 42%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractBackendUpdater.cpp.o[ 43%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/AbstractSourcesBackend.cpp.o[ 44%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/StoredResultsStream.cpp.o[ 45%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/CachedNetworkAccessManager.cpp.o[ 46%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ActionsModel.cpp.o[ 47%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverBackendsFactory.cpp.o[ 48%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ScreenshotsModel.cpp.o[ 50%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ApplicationAddonsModel.cpp.o[ 51%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[ 52%] Linking CXX shared library libDiscoverCommon.so[ 52%] Built target DiscoverCommonScanning dependencies of target kns-backend_autogenScanning dependencies of target knsbackendtest_autogen[ 53%] Automatic MOC for target knsbackendtest[ 54%] Automatic MOC for target kns-backend[ 54%] Built target knsbackendtest_autogenScanning dependencies of target dummy-backend_autogen[ 54%] Automatic MOC for target dummy-backend[ 54%] Built target dummy-backend_autogenScanning dependencies of target updatedummytest_autogen[ 55%] Automatic MOC for target updatedummytest[ 55%] Built target kns-backend_autogenScanning dependencies of target dummytest_autogen[ 56%] Automatic MOC for target dummytest[ 56%] Built target dummytest_autogenScanning dependencies of target CategoriesTest_autogen[ 57%] Automatic MOC for target CategoriesTest[ 57%] Built target updatedummytest_autogenScanning dependencies of target plasma-discover_autogen[ 58%] Automatic MOC for target plasma-discover[ 58%] Built target CategoriesTest_autogenScanning dependencies of target plasma-discover-exporter_autogen[ 59%] Automatic MOC for target plasma-discover-exporter[ 59%] Built target plasma-discover-exporter_autogenScanning dependencies of target kns-backend[ 60%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[ 60%] Built target plasma-discover_autogen[ 61%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.oScanning dependencies of target knsbackendtest[ 62%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[ 63%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

[Jan Grulich]

jgrulich accepted this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D10183

To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich, ngraham
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I had another idea: when the Event gets processed and the m_device is null, 
we just update it again from the event.
  
  Something like
  
if (!event->device()) {
event->updateDevice();
}
  
  with
  
void Device::updateDevice()
{
m_device = Device::getDevice(libinput_event_get_device(m_event);
}

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Fabian Vogt]

fvogt edited the summary of this revision.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10234

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10234: LibInput: Queue native libinput events instead of LibInput::Event

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, graesslin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin.
fvogt requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  The KWin-native LibInput::Event type needs to know the KWin-native
  LibInput::Device during construction. This is not guaranteed to be
  known when the event loop is being filled.
  So instead create the KWin-native Event only when it's needed.
  
  BUG: 389674

TEST PLAN
  kwin_wayland starts now without crashing.

REPOSITORY
  R108 KWin

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10234

AFFECTED FILES
  libinput/connection.cpp
  libinput/connection.h
  libinput/context.cpp
  libinput/context.h

To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10232: Include a pixel more in the dirty area

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, Konsole.
Restricted Application added projects: Plasma, Konsole.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  withfractional scaling sometimes there are visual glithches
  in rendering.
  painting areas of the terminal is heavily based on QRegion
  which is all integer, and sometimes rounding errors can happen
  this mitigates the problem, ensuring an area big enough gets
  updated when repainting partial areas that cover eventual
  pixel fractions that were rounded away
  CCBUG:373232

TEST PLAN
  most of the visual glitches are gone now, a missing pixel line
  in the background very rarely still happening but seems a separate issue
  somewhere else in the painting code

REPOSITORY
  R319 Konsole

BRANCH
  phab/dirty

REVISION DETAIL
  https://phabricator.kde.org/D10232

AFFECTED FILES
  src/TerminalDisplay.cpp

To: mart, #plasma, #konsole
Cc: plasma-devel, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, hindenburg, sebas, apol, mart

D10223: Improve preview thumbnail quality

[Eike Hein]

hein added a comment.


  In https://phabricator.kde.org/D10223#199103, @hein wrote:
  
  > In https://phabricator.kde.org/D10223#199099, @kossebau wrote:
  >
  > > Random by-passer nitpick comment: "twice as large thumbnails"... actually 
4 x large in pixels, given you scale 2x in two dimensions ;)
  >
  >
  > https://www.youtube.com/watch?v=RbTUTNenvCY&t=9s

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10223

To: hein, #plasma
Cc: kossebau, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10223: Improve preview thumbnail quality

[Eike Hein]

hein added a comment.


  In https://phabricator.kde.org/D10223#199099, @kossebau wrote:
  
  > Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 
x large in pixels, given you scale 2x in two dimensions ;)
  
  
  https://www.youtube.com/watch?v=RbTUTNenvCY&t=9s

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10223

To: hein, #plasma
Cc: kossebau, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10223: Improve preview thumbnail quality

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x 
large in pixels, given you scale 2x in two dimensions ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10223

To: hein, #plasma
Cc: kossebau, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10225: Define property in Units.qml for the Plasma styles

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Much like it is specified by kirigami itself

TEST PLAN
  Now I don't get a warning

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10225

AFFECTED FILES
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: apol, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 12:47:18 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kcm-keyboard-iso_codesFailed: TestSuite.lookandfeel-kcmTest

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 113 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/113/
 Project:
Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 12:17:16 +
 Build duration:
45 min and counting
   CONSOLE OUTPUT
  [...truncated 546.71 KB...]Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 10%] Automatic MOC for target kcm_standard_actions[ 10%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 10%] Automatic MOC for target kcm_keys[ 10%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/home/jenkins/workspace

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D10170#199003, @fredrik wrote:
  
  > > I think the "blur" option should go. Blur should be controlled centrally 
by the desktop effect. In other words: BlurBehind should always be set to true, 
and then left to kwin to handle. Having an extra option here seems like 
micro-management. Why would you need blur behind plasma widgets (as handled by 
the desktop effect) and not behind menus ? (or vice versa). Also, right now, 
selecting "blur" in the style settings, but unselecting the desktop effect 
results in no blur behind menu, and hence inconsistency with what the style 
option says.
  >
  > KWin has no way of knowing which pixels should be blurred behind a window. 
That's the reason the hint exists.
  >  If you set the hint unconditionally, the effect will be applied 
unconditionally. Even when the menus are fully opaque.
  
  
  Correct. 
  So the call to enableBlurBehind should be made only if "asAlphaChannel" _and_ 
opacity < 1
  This still does not need an extra option.
  Added comment in the code about this.
  Thanks for the clarification.

INLINE COMMENTS

> breezestyle.cpp:3630
> +#if !BREEZE_USE_KDE4
> +KWindowEffects::enableBlurBehind(widget->winId(), true);
> +#endif

This should be called only if StyleConfigData::menuOpacity() is < 100
And in fact, I wonder if it is safe to make the call at every painting call. 
I guess it depends on how the underlying function is implemented (does it first 
check for the property ?)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 25 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/25/
 Project:
Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 01 Feb 2018 12:08:38 +
 Build duration:
38 min and counting
   CONSOLE OUTPUT
  [...truncated 536.62 KB...]Unknown property type for key "X-KDE-Keywords[en_GB]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[es]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[et]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[eu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[fr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ga]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[gl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[he]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[hu]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ia]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[id]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[is]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[it]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ja]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[kk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[km]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ko]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[lt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[mr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nb]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nds]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[nn]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pa]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[pt_BR]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ro]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ru]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[ug]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[vi]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9/build/kcms/desktoptheme/kcm_desktoptheme.json" [ 10%] Automatic MOC for target kcm_desktoptheme[ 10%] Built target kcm_desktoptheme_autogenScanning dependencies of target kcm_standard_actions_autogen[ 11%] Automatic MOC for target kcm_standard_actions[ 11%] Built target kcm_standard_actions_autogenScanning dependencies of target kcm_keys_autogen[ 11%] Automatic MOC for target kcm_keys[ 11%] Built target kcm_keys_autogenScanning dependencies of target kcm_smserver_autogen[ 11%] Automatic MOC for target kcm_smserver[ 11%] Built target kcm_smserver_autogenScanning dependencies of target kcm_lookandfeel-kcms-metadata-json[ 12%] Generating kcm_lookandfeel-kcms-metadata.jsonAbout to parse service type file "/usr/home/jenkins/install-prefix/share/kservicetypes5/plasma-generic.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-API" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringUnknown property type for key "X-Plasma-RemoteLocation" -> falling back to stringGenerated  "/usr/ho

D10170: Added optional transparency/blur to menu frames

[Fredrik Höglund]

fredrik added a comment.


  > I think the "blur" option should go. Blur should be controlled centrally by 
the desktop effect. In other words: BlurBehind should always be set to true, 
and then left to kwin to handle. Having an extra option here seems like 
micro-management. Why would you need blur behind plasma widgets (as handled by 
the desktop effect) and not behind menus ? (or vice versa). Also, right now, 
selecting "blur" in the style settings, but unselecting the desktop effect 
results in no blur behind menu, and hence inconsistency with what the style 
option says.
  
  KWin has no way of knowing which pixels should be blurred behind a window. 
That's the reason the hint exists.
  If you set the hint unconditionally, the effect will be applied 
unconditionally. Even when the menus are fully opaque.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D10224: Give a default player name

[Aleix Pol Gonzalez]

apol requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10224

To: nicolasfella, broulik, apol
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D10224: Give a default player name

[Aleix Pol Gonzalez]

apol added a comment.


  Is this a workaround because Plasma Browser Integration doesn't provide an 
identity? Because if so I'd say the PBI should be fixed.
  
  Here if anything it should add "Default" or "Unknown".

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10224

To: nicolasfella, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D10224: Give a default player name

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: broulik.
nicolasfella added a project: Plasma.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Default to "Plasma Browser Integration" as a default MPRIS player identity. 
This makes KDE Connect look prettier.

TEST PLAN
  Before: 
  F5686841: Screenshot_20180201-121452.jpg 

  
  After:
  F5686842: Screenshot_20180201-124731.jpg 


REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D10224

AFFECTED FILES
  host/mprisplugin.cpp

To: nicolasfella, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Alex Nemeth]

anemeth added a comment.


  In https://phabricator.kde.org/D10170#198972, @hpereiradacosta wrote:
  
  > IMHO this change somewhat muddies Breeze's identity (flat and simple, not 
bloated) for no real gain. This said, I do appreciate your work.
  
  
  The exact opposite.
  By default the Breeze style desktop theme is transparent and blurry. Kicker 
and Kickoff are transparent. The plasmoids on the panel are transparent.
  This change can just make it more consistent.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10170: Added optional transparency/blur to menu frames

[Hugo Pereira Da Costa]

hpereiradacosta added reviewers: colomar, alake.
hpereiradacosta added a subscriber: alake.
hpereiradacosta added a comment.


  Hello,
  thanks for taking care of 1, 2 and 3.
  
  for 4 (the use case), I am adding @alake (one of the original designers of 
the breeze style) and @colomar as reviewer so that they have a chance to give 
their opinion too.
  My personal (not so important) worry, is that we are adding yet another 
option to the style for something which is only eye candy (in my understanding 
it brings no improvement to usability, quite the contrary in fact) and the code 
complexity that goes with it. IMHO this change somewhat muddies Breeze's 
identity (flat and simple, not bloated) for no real gain. This said, I do 
appreciate your work.
  
  Opinions welcome
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10223: Improve preview thumbnail quality

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  This patch does two things:
  
  - Instead of giving the KAbstractViewAdapter the actual icon size, we 
overprovision by giving it the size times two. This is because while we're 
deriving the grid view cell size from the icon size setting, it's not the 
actual size the thumbnails will be displayed at. Our IconItem is sized to 
almost fill the cell, and for image sources with non-square aspect ratios 
IconItem doesn't scale to the next icon size.
  
  - We set IconItem to do smooth scaling.
  
  While this results in lovely visual fidelity, I the performance
  impact is a concern. We're requesting twice as large thumbnails
  now, and we're doing more scaling work. However, thumbnail
  generation is async and doesn't slow down listing. There's also
  the possibility IconItem::smooth could have general performance
  impact unless things are smart enough not to scale when not
  necessary, which is hopefully the case.
  
  BUG:376848

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10223

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart